Martin v. Löwis mar...@v.loewis.de added the comment:
What needs reinitialization is not the time module, but the CRT. This is not
possible without starting a completely new process.
--
___
Python tracker rep...@bugs.python.org
http
Martin v. Löwis mar...@v.loewis.de added the comment:
As for the reproducibility issue: The configure/Makefile system
coming with Python simply doesn't support creating a Windows build. I
hope it's clear that the patch is NOT about creating a Windows
installer. If this is a requirement
Changes by Martin v. Löwis mar...@v.loewis.de:
--
Removed message: http://bugs.python.org/msg54865
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1528154
Martin v. Löwis mar...@v.loewis.de added the comment:
- Embedding Python by just compiling/linking all the .c files in
seems to be a major feature to me; so fixing compilation is useful
for its own
If that's the objective of the patch, I'm -1 on it.
- The win32 build system has never used
Martin v. Löwis mar...@v.loewis.de added the comment:
Please, one issue per report and checkin, and no work-in-progress on the
tracker. The issue of factually correcting claims about the unicodedata module
and elaborations on how it works are unrelated issues.
--
nosy: +loewis
Martin v. Löwis mar...@v.loewis.de added the comment:
There is no readline support on Windows at all, so I don't think the Windows
installer can be affected. I'm uncertain what the proposed change to Python is
at this point, though.
--
___
Python
Martin v. Löwis mar...@v.loewis.de added the comment:
Why? I thought release early, release often was a good thing.
Create a branch for that, or post an issue on Rietveld. W-I-P IMO
confuses people reviewing the patches, running into the same ones
over-and-over again, only to find out every
Martin v. Löwis mar...@v.loewis.de added the comment:
Can you please formulate that is a test case? Use this structure:
1. do this
2. this happens
3. this should happen instead
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http
Martin v. Löwis mar...@v.loewis.de added the comment:
The source is correct. Fixed in r87171.
--
nosy: +loewis
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10681
Martin v. Löwis mar...@v.loewis.de added the comment:
It's not an incompatible change, but I added the versionchanged anyway in
r87173.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10681
Martin v. Löwis mar...@v.loewis.de added the comment:
It's source level incompatible - my extension modules compiled fine with
v3.2a but failed with v3.2b1.
That's because you are using C++, right? In C, there shouldn't be any
problems
Martin v. Löwis mar...@v.loewis.de added the comment:
It's clearly not a bug: the documented grammar matches the implemented grammar.
Asking for more abstract consistency is a feature request. This also clearly
falls under the PEP 3003 moratorium.
--
nosy: +loewis
type: behavior
Martin v. Löwis mar...@v.loewis.de added the comment:
Retargetting, as this falls under the moratorium, and also because 3.2b1 has
been released.
--
nosy: +loewis
versions: +Python 3.3 -Python 3.2
___
Python tracker rep...@bugs.python.org
http
Martin v. Löwis mar...@v.loewis.de added the comment:
The problem is different: there is a stray in pythoncore\getbuildinfo.o.
Kristjan, this is your change: can you take a look?
--
nosy: +krisvale, loewis
___
Python tracker rep...@bugs.python.org
Martin v. Löwis mar...@v.loewis.de added the comment:
So, Martin, are you then arguing that this should in fact be
considered a bug in ZipFile? The documentation for the constructor
says Open a ZIP file, where file can be either a path to a file (a
string) or a file-like object. Reading
Martin v. Löwis mar...@v.loewis.de added the comment:
Ok, so closing as rejected.
--
resolution: - rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10682
Martin v. Löwis mar...@v.loewis.de added the comment:
In #10682, several committers indicated that they would prefer not to change
this. So I'm closing this as rejected. Per convention, it would probably
require a PEP to modify Python in this aspect (as there is no clear consensus
Martin v. Löwis mar...@v.loewis.de added the comment:
Are you going to reject say issue2636 on this basis? :-) Has *any*
patch ever been rejected as incomplete?
I certainly did close patches for that reason. Before that, I keep
asking people not to post W-I-P. As for issue2636, I have been
Martin v. Löwis mar...@v.loewis.de added the comment:
I stand by my evaluation: there is clearly no consensus about this change, so
it certainly requires more discussion, potentially leading to proponents being
asked to write a PEP.
--
___
Python
Martin v. Löwis mar...@v.loewis.de added the comment:
2to3 patches should currently be made against and checked into the sandbox.
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
Martin v. Löwis mar...@v.loewis.de added the comment:
The question really is whether we want or want not to support RFC 1945 (i.e
HTTP/1.0). If we want to support it, we also must comply to section 3.1, which
says
The version of an HTTP message is indicated by an HTTP-Version field
Martin v. Löwis mar...@v.loewis.de added the comment:
I'm rejecting this as won't fix. Users having the underlying problem (i.e.
need more than 2GB of heap) really should switch to a 64-bit installation. The
risk of something breaking is just not worth it.
That testing showed no issues
Martin v. Löwis mar...@v.loewis.de added the comment:
Am 17.12.2010 01:56, schrieb STINNER Victor:
STINNER Victor victor.stin...@haypocalc.com added the comment:
Ooops, sorry. I just applied the patch suggested by Marc-Andre
Lemburg in msg22885 (#1054943). As the patch worked
Martin v. Löwis mar...@v.loewis.de added the comment:
So lacking a new patch, I think we should revert the existing change
for now.
Oops, I missed that Alexander has proposed a patch.
--
___
Python tracker rep...@bugs.python.org
http
Martin v. Löwis mar...@v.loewis.de added the comment:
The logic suggested by Martin in msg120018 looks right to me, but the
whole code seems to be unnecessarily complex. (And comb1==comb may
need to be changed to comb1=comb.) I don't understand why linear
search through skipped array
Martin v. Löwis mar...@v.loewis.de added the comment:
Passing Part3 tests and not crashing on crash.py is probably good
enough for a commit, but I don't have a proof that length 20 skipped
buffer is always enough.
I would agree with that. I still didn't have time to fully review the
patch
Martin v. Löwis mar...@v.loewis.de added the comment:
The C forms (NFC and NFKC) do canonical composition and U+FDFA is a
compatibility composite. (BTW, makeunicodedata.py checks that maximum
decomposed length of a character is 19, but it would be better if it
would compute and define
Martin v. Löwis mar...@v.loewis.de added the comment:
I would like to see this reopened: we have a very large class of
users that are not ready to entirely port to 64-bit and need this
now.
And I remain -1 to such requests. You can appeal to that by writing a
PEP, or finding a committer who
Martin v. Löwis mar...@v.loewis.de added the comment:
I fail to see the problem. The context is a plain void*, not (necessarily) a
function pointer, and getargs uses it with the same type it put in. Why do you
think PyCapsule_Destructor is of relevance
Martin v. Löwis mar...@v.loewis.de added the comment:
This is tricky. It's clearly ill-formed XML, so I'm not sure that this needs to
be bug-compatible with Apple's implementation.
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http
Martin v. Löwis mar...@v.loewis.de added the comment:
I don't think this needs to block the beta release.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10734
Martin v. Löwis mar...@v.loewis.de added the comment:
The problem is that the nested group doesn't share/propagate mutually exclusive
groups with its parent container. The attached patch fixes this.
--
keywords: +patch
Added file: http://bugs.python.org/file20114/argparse.diff
Martin v. Löwis mar...@v.loewis.de added the comment:
On Windows, using the bytes APIs for filenames is unreliable and fails for
characters that are not in the ANSI code page. So you should use
import os
for i in os.listdir(u'.'):
print os.path.isfile(i), '\t', i
instead.
--
nosy
Martin v. Löwis mar...@v.loewis.de added the comment:
What's the use case for this function?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10755
Martin v. Löwis mar...@v.loewis.de added the comment:
This is not a bug. Your code that produces very nasty filename is the right
one - the file name is actually the one you asked for. The second code is also
behaving correctly: filename already *is* a bytestring, calling .encode
Martin v. Löwis mar...@v.loewis.de added the comment:
Oops, I take this back - I didn't notice you were using Python 3.1.
In any case, your first code is correct. What you get is the best you can ask
for.
That the second case fails is indeed a bug.
--
resolution: invalid -
status
Martin v. Löwis mar...@v.loewis.de added the comment:
I don't think we can change this for the maintenance branches. The code behaves
according to the documentation:
access(path, mode) - True if granted, False otherwise
False otherwise is really meant that way: otherwise. The specific
Martin v. Löwis mar...@v.loewis.de added the comment:
IIUC, the issue is that people installing a 64-bit Python, and VS Express, and
then wonder why they can't build extension modules. I'm not so sure that there
is a bug in Python here - this setup is not supported (and that's really
Martin v. Löwis mar...@v.loewis.de added the comment:
Thorsten: my recommendation is to ignore this issue in your software. It's just
a warning.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9709
Martin v. Löwis mar...@v.loewis.de added the comment:
So, in reverse of issue 4871, it appears that in this case the API should
reject bytes input with an appropriate error message.
-1. It is quite common to produce ill-formed zipfiles, and other
ziptools are interpreting them in violation
Martin v. Löwis mar...@v.loewis.de added the comment:
Why do you think this is a bug in Python?
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10776
Martin v. Löwis mar...@v.loewis.de added the comment:
The documentation is incorrect; writexml does not support an encoding
parameter. Only Document nodes support the encoding parameter in writexml, and
it is intentional that its only effect is to fill out the XML declaration.
I don't
Martin v. Löwis mar...@v.loewis.de added the comment:
The last sentence has nothing to do with the report, it was just a general
remark that
it would be nice if minidom could support unicode string directly.
minidom most certainly supports Unicode directly. All element names,
attribute
Martin v. Löwis mar...@v.loewis.de added the comment:
Looks good. Would there be a point in making any of the parameters optional?
No. The API should look exactly as it does on the system level. Anybody
calling these functions should know how call them
Martin v. Löwis mar...@v.loewis.de added the comment:
Just for the record, I was about to try to do this, when I realized that
exposing prctl requires expecting a variable number of arguments with
variable types.
It turns out providing a Python wrapper for such a kind of C API is just
Martin v. Löwis mar...@v.loewis.de added the comment:
Seriously, it can wait 3.3.
What exactly can wait until 3.3? The presented patch introduces no
user visible changes. It is only a stepping stone to restoring some
sanity in a way supplementary characters are treated by narrow builds
Martin v. Löwis mar...@v.loewis.de added the comment:
Are you serious? This sounds like a py4k idea. Can you give us a
hint on what the new representation will be?
I'm thinking about an approach of a variable representation:
one, two, or four bytes, depending on the widest character
Martin v. Löwis mar...@v.loewis.de added the comment:
Actually, it looks like PEP 3131 and the Language Reference [1] still
disagree. The latter says:
identifier ::= id_start id_continue*
which should probably be
identifier ::= xid_start xid_continue*
instead.
Interesting
New submission from Martin v. Löwis mar...@v.loewis.de:
This is similar to #10348, but has a different scope; the attached patch
disables the ProcessPoolExecutor if the system has too few POSIX semaphores.
To keep support for the ThreadPoolExecutor, I had the test cases stop using
Martin v. Löwis mar...@v.loewis.de added the comment:
The attached patch fixes it for me. No time to write tests right now.
--
keywords: +patch
Added file: http://bugs.python.org/file20205/zipfile.diff
___
Python tracker rep...@bugs.python.org
http
Martin v. Löwis mar...@v.loewis.de added the comment:
I find the solution (running every test in a subprocess) a bit too drastic for
the problem. How about a modified approach: run regrtest with -S, and have it
create a subprocess for test_site only
Martin v. Löwis mar...@v.loewis.de added the comment:
I think the policy is that it is ok to add more 3k warnings to 2.7; these are
not considered new features (or explicitly exempted, or some such).
--
___
Python tracker rep...@bugs.python.org
http
Martin v. Löwis mar...@v.loewis.de added the comment:
Isn't it kind of a CPython-specific detail, though?
If other implementations do provide proper keyword arguments,
I'd be skeptical that they all settled on the names that the
library documentation gives to the arguments.
--
title
Changes by Martin v. Löwis mar...@v.loewis.de:
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10802
___
___
Python-bugs-list
Martin v. Löwis mar...@v.loewis.de added the comment:
Can you please run the script under strace, and report what system call is not
implemented? I.e. put
import subprocess
subprocess.Popen('ls')
into a file (foo.py), then run
strace -o trace.txt python foo.py
Please attach the output
Martin v. Löwis mar...@v.loewis.de added the comment:
If more people report this, there is still something Python could do:
- the configure test could verify that the running kernel actually implements
the system call, and undefine HAVE_PIPE2 if that's not the case. Of course this
would only
Martin v. Löwis mar...@v.loewis.de added the comment:
The patch looks still fine. The only concern is that the test probably fails on
FAT, but I think that's acceptable.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8278
Martin v. Löwis mar...@v.loewis.de added the comment:
Hmm. I wonder why the code doesn't use the st_mtime field. We should really
deprecate the stat module.
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10810
Martin v. Löwis mar...@v.loewis.de added the comment:
I like the logic of Antoine's patch much better (basing this on whether the
listening socket had a timeout). I wonder whether it's correct though if there
is a defaulttimeout: shouldn't it then leave the timeout on the socket instead
Martin v. Löwis mar...@v.loewis.de added the comment:
Is this really the time for restructuring tests? I think such activity should
wait until after the 3.2 release.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10798
Martin v. Löwis mar...@v.loewis.de added the comment:
Thanks for the review, committed as r87665. Fixing flaky tests is fine, of
course.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10798
Martin v. Löwis mar...@v.loewis.de added the comment:
Follow-up: I have disabled test_all_completed_some_already_completed in r87667,
as I couldn't figure out why it hangs.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Martin v. Löwis mar...@v.loewis.de added the comment:
Interesting. I wonder whether a reboot of the system would help (as it may have
old semaphores hanging around).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10798
Martin v. Löwis mar...@v.loewis.de added the comment:
I wonder why reading from /dev/urandom has a loop in the first place, though -
isn't it guaranteed that you can read as many bytes as you want in one go? This
goes back to #934711, and apparently, even the original patch had the loop
Martin v. Löwis mar...@v.loewis.de added the comment:
haypo: please avoid introducing explicit casts (such as the one in pyexpat.c).
Use SAFECASTs instead. If you are absolutely certain that a cast cannot
possibly truncate, add a comment explaining why that is. In the specific case,
I think
Martin v. Löwis mar...@v.loewis.de added the comment:
Closing it. It seems that people feel more safe when urandom loops until it has
enough data (see
http://stackoverflow.com/questions/4598507/dev-urandom-maximum-size/4598534#4598534).
I might still pursue this idea, but in a different issue
Martin v. Löwis mar...@v.loewis.de added the comment:
I think this patch (nonblock2.patch) is wrong. If I have a non-blocking server
socket on *BSD, and do accept, with no default timeout: IIUC, under the patch,
I will get a blocking connection socket. However, according to the operating
Martin v. Löwis mar...@v.loewis.de added the comment:
It's a bug in random.c that doesn' t check for signal pending inside the
read(2) code, so you have no chance to kill the process via signals until
the read(2) syscall is finished, and it could take a lot of time before
return
Martin v. Löwis mar...@v.loewis.de added the comment:
MvL If you are absolutely certain that a cast cannot possibly truncate,
MvL add a comment explaining why that is.
Ah yes, sorry, I forgot to add a comment: done in r87746.
But the comment is actually wrong: It says
len = buf_size
Martin v. Löwis mar...@v.loewis.de added the comment:
Well, either the defaulttimeout should have the priority over the parent
socket's settings (your argument in msg125135), or it shouldn't. I'm
fine with both, but I think any more complicated combination would end
up puzzling for the user
Martin v. Löwis mar...@v.loewis.de added the comment:
I don't think we should adding tests to 2.7, perhaps unless there are also
fixes for it. So targetting 3.3+ only seems reasonable.
--
___
Python tracker rep...@bugs.python.org
http
Martin v. Löwis mar...@v.loewis.de added the comment:
Oh. Not only is the comment is wrong, but the code is also wrong. It
should return a negative value on error, whereas it returns the string
length which is always positive (except on a unlikely Py_ssize_t = int
overflow?).
Right. See
Martin v. Löwis mar...@v.loewis.de added the comment:
Ok, here is a patch which prefers the default timeout (if set) over fixing of
inherited flags. Tested under Linux, Windows, OpenSolaris.
This patch looks fine to me. Please also update the accept documentation
to explain the situation
Martin v. Löwis mar...@v.loewis.de added the comment:
Alternatively, val_int should have type sqlite3_int64, which is the return type
of sqlite3_value_int64.
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8033
Martin v. Löwis mar...@v.loewis.de added the comment:
Martin, we would like to exclude Py_buffer from the stable ABI for
Python 3.2, until we have a chance to thrash out the missing pieces
of the documentation for 3.3. I *think* it is a documentation
problem, but until we're certain, it
Martin v. Löwis mar...@v.loewis.de added the comment:
Removal of the buffer interface from the ABI has been committed as r87805,
r87806, r87805, r87808, and r87809.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10181
Martin v. Löwis mar...@v.loewis.de added the comment:
I fail to see the bug. Garbage in, garbage out. AFAIU, returning
/usr/bin/python2.7 still might be the wrong answer.
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http
Martin v. Löwis mar...@v.loewis.de added the comment:
You'll see that read returns less that 100M bytes when interrupted.
I see.
while len(data) expected:
read(expected - len(data))
So we're sure it won't break under some systems/conditions.
I think this is not quite the idiom we
Martin v. Löwis mar...@v.loewis.de added the comment:
Patch looks mostly good. Some comments:
- sethostname supports names with embedded null bytes, so
wrapper should not use strlen
- it's a bit asymmetric that gethostname is in the socket
module and supports Windows, and sethostname
Martin v. Löwis mar...@v.loewis.de added the comment:
I wonder whether there is a precedent of some system mapping SIGINT to
an exception. We could probably learn something from them.
- should KeyboardInterrupt always exit with SIGINT, or only if it was
actually raised by a signal handler
Martin v. Löwis mar...@v.loewis.de added the comment:
I agree that not guessing would be better.
Well, on Linux, readlink(/proc/self/exe) would be better than
guessing.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10835
Martin v. Löwis mar...@v.loewis.de added the comment:
Closing this as won't fix. Python is not going to reimplement depends.exe.
--
nosy: +loewis
resolution: - wont fix
status: open - closed
___
Python tracker rep...@bugs.python.org
http
Martin v. Löwis mar...@v.loewis.de added the comment:
According to the spec for gethostname(), the hostname that it returns
is null-terminated so it won't support embedded NUL bytes. Should we
still add it anyway?
Oops, I misread the spec. No, gethostname should then not be duplicated
Martin v. Löwis mar...@v.loewis.de added the comment:
According to the spec, gethostid does not set errno - it now checks anyway.
Sorry, I misread that also. Leaving the check is fine; reverting it to
the previous code would be fine as well
Martin v. Löwis mar...@v.loewis.de added the comment:
I'm with Raymond here (probably not surprisingly): -1 on backporting new
features into 2.7. This really is foremost about having policies and sticking
to them; special cases aren't special enough to break the rules.
Personally, I haven't
Martin v. Löwis mar...@v.loewis.de added the comment:
You should use begin/end allow threads when the system call might block. To get
an indication, trace through the kernel code of some system; my guess is that
these are typically non-blocking (i.e. return immediately) - but I might be
wrong
Martin v. Löwis mar...@v.loewis.de added the comment:
Unless you think the code is actually incorrect as it stands, it's certainly
worse to change it (in whatever respect) than to leave it.
--
___
Python tracker rep...@bugs.python.org
http
Martin v. Löwis mar...@v.loewis.de added the comment:
Brian: On native Windows, Read Execute has no real affect on
applications. Why do you say that? The FILE_EXECUTE permission certainly has a
meaning on Windows, see
http://msdn.microsoft.com/en-us/library/gg258116(v=vs.85).aspx
I agree
Martin v. Löwis mar...@v.loewis.de added the comment:
Thank you @loewis. However, I don't see where
set_default_verify_path - is defined in the patch you have provided.
It's not defined in the patch, as it is already committed to Python.
--
title: some stdlib modules need
Martin v. Löwis mar...@v.loewis.de added the comment:
I would focus on trying to provide a unique interface across all
platforms. Being sendfile() not a standard POSIX I think we should
not worry about providing a strict one-to-one interface.
We absolutely need to expose sendfile
Martin v. Löwis mar...@v.loewis.de added the comment:
I thought that patches weren't meant to include the regenerated files.
Correct. Not including them is perfectly fine.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Changes by Martin v. Löwis mar...@v.loewis.de:
--
versions: +Python 2.7, Python 3.1, Python 3.2, Python 3.3 -Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7936
Martin v. Löwis mar...@v.loewis.de added the comment:
You need to install the MS CRT (msvcrt90.dll, along with its assembly manifests
and stuff) as well; it's not surprising that copying over an installation
doesn't work.
I'll also point out that this is not a bug: copying over
Martin v. Löwis mar...@v.loewis.de added the comment:
I think this issue falls into a similar category as support for
case-insensitive but case-preserving file systems. Python uses regular file
system lookups, but then may need to verify whether it got the right one.
I'd like to request
Martin v. Löwis mar...@v.loewis.de added the comment:
There is also issue c) what if the filesystem encoding can only
represent a compatibility character, say U+00B5, but not its NFKC
equivalent, U+03BC?
That should be considered as similar to file systems that just cannot
represent certain
Martin v. Löwis mar...@v.loewis.de added the comment:
Only Mac OS X and the HFS+ filesystem normalize filenames (to a variant
of NFD). But such normalization is a good thing! I mean that I don't
think that we have anything to do for that.
That may well be - I don't have a case where
Martin v. Löwis mar...@v.loewis.de added the comment:
As this clearly seems to be a Tk bug, I suggest to close this report as won't
fix - 3rd party.
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10973
Martin v. Löwis mar...@v.loewis.de added the comment:
Notice that a boilerplate module is already available: xxlimited.c.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10943
Martin v. Löwis mar...@v.loewis.de added the comment:
I see your point. The problem is that IDLE is somewhat included with
Python (so in a sense it is not 3rd party), and seems like a good
tool for learning Python: my concern is similar to that in message
126276 http://bugs.python.org
Martin v. Löwis mar...@v.loewis.de added the comment:
Hmm. It seems better to me to accept this bug (and document it, and
point out that it isn't Python's fault) than depriving 64-bit users
of IDLE, or (even worse) of tkinter.
I disagree. There aren't really 64-bit users on OSX, thanks
201 - 300 of 4659 matches
Mail list logo