Meador Inge mead...@gmail.com added the comment:
LGTM. Thanks for fixing this.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13665
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12705
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13629
Meador Inge mead...@gmail.com added the comment:
Éric, I got it.
Erno, thanks for the patch.
--
nosy: +meador.inge
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http
New submission from Meador Inge mead...@gmail.com:
While fixing issue13725 I noticed that there is a long option for 'trace', but
it is not actually handled:
[meadori@motherbrain cpython]$ ./python -m test --trace
No handler for option --trace. Please report this as a bug at
http
Meador Inge mead...@gmail.com added the comment:
Fixed.
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13786
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10112
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
components: +ctypes
nosy: +meador.inge
stage: - needs patch
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13709
Meador Inge mead...@gmail.com added the comment:
Here is a patch that renumber the tokens. I also regenerated token.py.
--
nosy: +georg.brandl
Added file: http://bugs.python.org/file24225/renumber-tokens.patch
___
Python tracker rep
Meador Inge mead...@gmail.com added the comment:
I can reproduce this in tip as well:
ast.dump(ast.parse('a = (1,2)'), include_attributes=True)
Module(body=[Assign(targets=[Name(id='a', ctx=Store(), lineno=1,
col_offset=0)], value=Tuple(elts=[Num(n=1, lineno=1, col_offset=5), Num(n=2,
lineno
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13697
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +orsenthil
stage: - test needed
versions: +Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13696
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13585
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
stage: - needs patch
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13672
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12857
___
___
Python-bugs-list
Meador Inge mead...@gmail.com added the comment:
The cmdoption directive should be used with a program directive.
Ah, nice. Thanks for the tip Éric.
Updated patch attached along with a patch for the 2.7/3.2 doc update attached.
--
Added file: http://bugs.python.org/file24088
Changes by Meador Inge mead...@gmail.com:
Added file: http://bugs.python.org/file24089/tokenize-docs-2.7-3.2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2134
Meador Inge mead...@gmail.com added the comment:
Committed. Thanks for the review Terry.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Meador Inge mead...@gmail.com added the comment:
ec44f2e82707 fixed compilation on Fedora and test_ssl passed fine.
Awesome, thanks Antoine. I will checkout the DH patch from issue13626 on
Fedora today.
--
___
Python tracker rep
Meador Inge mead...@gmail.com added the comment:
Per the Red Hat problems in issue13627 I just tried this patch on Fedora 16.
Everything built just fine. However, the patch doesn't apply cleanly to tip an
longer:
[meadori@motherbrain cpython]$ patch -p1 ../patches/dh.patch
patching file
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13607
___
___
Python-bugs-list
Meador Inge mead...@gmail.com added the comment:
With the new patch I see no benefits on the same micro-benchmarks you posted
(it is even slower for the smaller case) on a quad-core 64-bit F15 box:
BEFORE:
$ ./python -mtimeit def y(n): for x in range(n): yield x
sum(y(10))
100
Meador Inge mead...@gmail.com added the comment:
ECC is *not* available in the OpenSSL package provided on RedHat systems.
RedHat intentionally strips it due to patent concerns
(http://en.wikipedia.org/wiki/ECC_patents). Therefore committing this work
made it much more difficult to build
New submission from Meador Inge mead...@gmail.com:
When making the changes to remove backticks in eb2f70fdbf32, the
_PyParser_TokenNames table was incorrectly updated. Now the indexes into
_PyParser_TokenNames don't match the token numbers. This can be seen in the
output of 'python -d
Changes by Meador Inge mead...@gmail.com:
--
components: +Demos and Tools
stage: - patch review
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13628
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13628
___
___
Python-bugs-list
Meador Inge mead...@gmail.com added the comment:
Is there a reason not to renumber token.h?
I thought about that, but at the time I wasn't sure whether or not that
would break anything. I went with the current patch because it is lower
risk.
On the other hand, proper clients of token.h
Meador Inge mead...@gmail.com added the comment:
The proposed documentation text seems too complicated and language expert
speaky to me. We should try to link to standard definitions when possible to
reduce the text here. For example, I believe the Operators and Delimiters
tokens
New submission from Meador Inge mead...@gmail.com:
The current token documentation is out of date with respect to the currently
available token types:
Python 3.3.0a0 (default:766136049b44+, Dec 18 2011, 21:54:42)
[GCC 4.6.2 20111027 (Red Hat 4.6.2-1)] on linux
Type help, copyright, credits
Meador Inge mead...@gmail.com added the comment:
On Thu, Dec 15, 2011 at 1:42 AM, maniram maniram rep...@bugs.python.org wrote:
Why isn't anybody commiting or commenting on my patches?
Your patch is much appreciated. Thank you. It takes some time to get
things reviewed. Please read the Dev
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2134
___
___
Python-bugs-list
Meador Inge mead...@gmail.com added the comment:
I just noticed this problem as well.
I don't know the code well enough to determine if Brian's patch is the
right thing to do. The documentation claims that maxtries is used to
put a limit on recursion:
http://docs.python.org/dev/library
Meador Inge mead...@gmail.com added the comment:
I agree with Benjamin about this being too domain specific for stdlib.
Also, I don't really see a good argument as to why this functionality is
useful. -1 from me too.
--
nosy: +meador.inge
Meador Inge mead...@gmail.com added the comment:
Thanks for the review Brett. Fix committed.
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Meador Inge mead...@gmail.com added the comment:
Fix committed. Thanks for the review Antoine and Brett.
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http
Meador Inge mead...@gmail.com added the comment:
On Wed, Dec 14, 2011 at 10:58 PM, Benjamin Peterson
rep...@bugs.python.org wrote:
Hardly, being a widely applicable mathematical function.
I was just typing a similar response.
Also, it's in a C math library which is what Python's
Meador Inge mead...@gmail.com added the comment:
On Thu, Dec 1, 2011 at 2:11 AM, STINNER Victor rep...@bugs.python.org wrote:
Is there really an use case where you need 2 ** 20 (1,048,576) arguments? If
yes, I'm not against the torture in this case :-)
Not very likely :-) However
New submission from Meador Inge mead...@gmail.com:
I was recently reading the 'importlib' code and noticed that the utility
decorators have not been updated for '__qualname__':
def f(): pass
...
importlib.util.set_loader(f)
function set_loader.locals.wrapper at 0x7f4b323f1f60
Meador Inge mead...@gmail.com added the comment:
I can reproduce this on tip. What happens is that
'importlib.import_module(my_lib.bar)' is effectively computed as:
import my_lib
import bar
by '_bootstrap._gcd_import'. When '_gcd_import' goes to do the import
of 'bar' it does
Meador Inge mead...@gmail.com added the comment:
Updated patch with tests.
--
Added file: http://bugs.python.org/file23951/issue13591-2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13591
Meador Inge mead...@gmail.com added the comment:
Yup, oversight on my part. Thanks.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13544
Meador Inge mead...@gmail.com added the comment:
On Sun, Dec 11, 2011 at 12:17 PM, sbt rep...@bugs.python.org wrote:
I don't really know that much about pickle, but Antoine mentioned that
'bytearray'
works fine going from 3.2 to 2.7. Given that, can't we just compose 'bytes
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13591
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1785
___
___
Python-bugs-list
Meador Inge mead...@gmail.com added the comment:
For the most part this looks OK, but I am not sure about this hunk:
diff --git a/Objects/typeobject.c b/Objects/typeobject.c
--- a/Objects/typeobject.c
+++ b/Objects/typeobject.c
@@ -3724,7 +3724,7 @@ add_methods(PyTypeObject *type, PyMethod
Meador Inge mead...@gmail.com added the comment:
On Sun, Dec 11, 2011 at 4:42 AM, Nick Coghlan rep...@bugs.python.org wrote:
Explicitly spelling out __qualname__ like that makes the tests a bit too
sensitive to otherwise irrelevant details of the test layout.
I suggest using comparisons
Meador Inge mead...@gmail.com added the comment:
Thanks for the patch Filip.
--
resolution: - fixed
stage: patch review - committed/rejected
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13544
Meador Inge mead...@gmail.com added the comment:
I don't really know that much about pickle, but Antoine mentioned that
'bytearray'
works fine going from 3.2 to 2.7. Given that, can't we just compose 'bytes'
with
'bytearray'? Something like:
Python 3.3.0a0 (default:aab45b904141+, Dec 10
Meador Inge mead...@gmail.com added the comment:
Filip, with the exception of some minor whitespace problems (remember to run
'make patchcheck') and a missed testcase in 'TestWraps.test_default_update',
this looks good to me. I was just about to attach a similar patch. Here is
an updated
New submission from Meador Inge mead...@gmail.com:
I was recently experimenting with the new PEP 3155 '__qualname__ implementation
and noticed that '__qualname__' is not present on builtin methods and functions:
[meadori@motherbrain cpython]$ ./python
Python 3.3.0a0 (default:aab45b904141
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13543
Meador Inge mead...@gmail.com added the comment:
I looked at the 'ctypes' leak a bit. I haven't determined exactly what
is going on, but the leak has something to do with a change in the patch that
runs 'dash_R_cleanup' twice instead of once. The new behavior can be reduced
to something like
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13521
Meador Inge mead...@gmail.com added the comment:
Fixed. Thanks for the review y'all.
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13513
Meador Inge mead...@gmail.com added the comment:
On Fri, Dec 2, 2011 at 12:12 PM, Antoine Pitrou rep...@bugs.python.org wrote:
yes, c6dafa2e2594 was found with this patch. It's the only one, though
(there's also a leak in test_ctypes but I don't want to investigate :-)).
I'll take a look
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13508
Meador Inge mead...@gmail.com added the comment:
On Wed, Nov 30, 2011 at 6:20 AM, Amaury Forgeot d'Arc
rep...@bugs.python.org wrote:
Right, alloca() could be replaced by some malloc(), but is it really useful?
After all, when a C function calls back to Python, all arguments needs
Changes by Meador Inge mead...@gmail.com:
--
priority: normal - low
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13097
___
___
Python-bugs-list
New submission from Meador Inge mead...@gmail.com:
The current IOBase documentation [1] reads:
IOBase (and its subclasses) support the iterator protocol, meaning that an
IOBase object can be iterated over yielding the lines in a stream. Lines are
defined slightly differently depending
Meador Inge mead...@gmail.com added the comment:
I am skeptical that such a note will help. The iterator behavior is clearly
pointed out in the Python Tutorial [1] and in the IOBase documentation [2]. I
suspect this bad code pattern is just being copied and pasted from other
sources without
Meador Inge mead...@gmail.com added the comment:
Ilya, I agree. Thanks for the test patch. These two patches look OK to me.
Georg OK with you?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13120
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13505
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13492
Meador Inge mead...@gmail.com added the comment:
+1
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13494
___
___
Python-bugs
Meador Inge mead...@gmail.com added the comment:
Cool. The test can still be committed in that branch too.
The regression test for this issue was already committed for 2.7 in
bcc7bf3963cc as a part of creating the unit test baseline. I just committed
the bug fix to 3.2 and default.
Thanks
Changes by Meador Inge mead...@gmail.com:
--
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12618
Meador Inge mead...@gmail.com added the comment:
Also see issue4130.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13492
___
___
Python-bugs
Meador Inge mead...@gmail.com added the comment:
Without seeing a specific example of what you are trying to do, it is hard to
tell whether ctypes would be a good fit. I am closing this issue since the
original questions have been answered. Please open a new issue if you think
ctypes could
Changes by Meador Inge mead...@gmail.com:
--
assignee: - meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13096
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
assignee: - meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13097
___
___
Python-bugs-list
Meador Inge mead...@gmail.com added the comment:
benrg, any further interest in this? If so, please comment on my last reply.
Otherwise, I am closing this issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11427
Meador Inge mead...@gmail.com added the comment:
Here is a small patch against tip. OK?
--
keywords: +patch
stage: needs patch - patch review
Added file: http://bugs.python.org/file23800/issue13096.patch
___
Python tracker rep...@bugs.python.org
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13487
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13120
___
___
Python-bugs-list
Meador Inge mead...@gmail.com added the comment:
Here a some of the relevant links from POSIX 2008:
1. Shell Command Language -
http://pubs.opengroup.org/onlinepubs/9699919799/idx/shell.html
3. Shell Command Language Rationale -
http://pubs.opengroup.org/onlinepubs/9699919799/xrat
Meador Inge mead...@gmail.com added the comment:
Normally a test case is needed. I tried the following:
diff --git a/Lib/test/test_pdb.py b/Lib/test/test_pdb.py
--- a/Lib/test/test_pdb.py
+++ b/Lib/test/test_pdb.py
@@ -595,6 +595,25 @@ def test_pdb_run_with_code_object():
(Pdb) continue
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11107
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12627
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2775
___
___
Python-bugs-list
Meador Inge mead...@gmail.com added the comment:
On Sat, Nov 26, 2011 at 7:17 AM, Antoine Pitrou rep...@bugs.python.org wrote:
The tests break on the Windows buildbots:
I am investigating now.
--
___
Python tracker rep...@bugs.python.org
http
Meador Inge mead...@gmail.com added the comment:
The tests are fixed now. A relative path was being computed, but on Windows
the current working directory drive and the drive of the relative path we were
computing was different (and so this test bug would *not* be seen if running
Meador Inge mead...@gmail.com added the comment:
we don’t know what people do with symlinks and relative paths out
there, so I’d prefer adding a safe special case* rather than always
calling abspath. What do you think?
Éric, I agree. I didn't know about the strange symlink + relative
Meador Inge mead...@gmail.com added the comment:
Éric, sure, I will commit the tests sometime today. Then I will respond to the
'os.path.abspath' question as well.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12618
Meador Inge mead...@gmail.com added the comment:
Committed. Thanks for the review Antoine.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13411
___
___
Python-bugs-list
Meador Inge mead...@gmail.com added the comment:
- you duplicated the part with CFUNCTYPE(c_int)(lambda: None) without
removing the original chunk of code
- some platforms can't compile ctypes, you must handle that case in
regrtest
Both fixed. Thanks for the review. Second patch
Meador Inge mead...@gmail.com added the comment:
Hmmm... I take back what I said before (not sure what I was thinking), I
don't think this is a regression. If this ever did work, it must have
been a bug. For one reason, Python byte strings are now immutable.
Allowing their memory
New submission from Meador Inge mead...@gmail.com:
Currently it is possible to somewhat easily get false positives for reference
leaks when running the ctypes regression tests with -R. See issue13250 for an
example where I got tripped up. The reason is that the ctypes caches are not
cleared
Meador Inge mead...@gmail.com added the comment:
I opened issue13380 for fixing the ctypes regrtest caching problem.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13250
Meador Inge mead...@gmail.com added the comment:
I agree this is a regression. I am looking more into it now.
--
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11427
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13370
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10977
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13328
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13298
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13272
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13266
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13253
___
___
Python-bugs-list
Meador Inge mead...@gmail.com added the comment:
P.S. We could probably get rid of the HAVE macro all together by doing
all the work in the 'configure' script.
Would that be a breach of backward compatibility for sysconfig?
Yeah, I think so. Best to leave it alone
Meador Inge mead...@gmail.com added the comment:
I think it might be easier to just always use the absolute path rather than
looking at the directory length. Maybe something like the attached. I added
unit tests as well.
--
nosy: +meador.inge
stage: test needed - patch review
Added
Meador Inge mead...@gmail.com added the comment:
Actually, I think sysconfig does the right thing when it comes to all
the configure-generated HAVE_XXX variables
I agree. The 'configure' script could be improved, though. If we truly
want to enable this by default, then the defaulting should
301 - 400 of 625 matches
Mail list logo
