Michael Foord mich...@voidspace.org.uk added the comment:
Reworked as a patch, including documentation and NEWS update.
--
keywords: +patch
Added file: http://bugs.python.org/file19669/getattr_static.patch
___
Python tracker rep...@bugs.python.org
Changes by Michael Foord mich...@voidspace.org.uk:
Removed file: http://bugs.python.org/file19669/getattr_static.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9732
Changes by Michael Foord mich...@voidspace.org.uk:
--
versions: +Python 2.5 -Python 3.2
Added file: http://bugs.python.org/file19673/getattr_static.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9732
Michael Foord mich...@voidspace.org.uk added the comment:
Committed revision 86566.
--
resolution: - accepted
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9732
Michael Foord mich...@voidspace.org.uk added the comment:
Applied to Python 3.2 in revision 86570.
Python 2.7 will have to be fixed after the next release as we are currently in
release candidate stage.
--
___
Python tracker rep...@bugs.python.org
New submission from Michael Foord mich...@voidspace.org.uk:
python -m unittest does nothing useful (runs 0 tests). It would be good to
have it default to discovery, which removes the useless behaviour *and* makes
the default invocation for test discovery shorter.
--
assignee
Michael Foord mich...@voidspace.org.uk added the comment:
@Eric
No. python -m unittest discover ... will still be needed where you want to
pass arguments to discovery (python -m unittest ... still has a different
meaning where you pass arguments). All this will do is give the previously
Michael Foord mich...@voidspace.org.uk added the comment:
The test now passes for me on Mac OS X and yes - looks like the same issue as
issue 8447.
--
resolution: - invalid
stage: needs patch - committed/rejected
status: open - closed
___
Python
Michael Foord mich...@voidspace.org.uk added the comment:
Sorry for the late reply. I don't think the patch as provided is sufficient as
it would interfere with people causing unittest.main() directly from a test
module. Checking that TestProgram.loader is None is the way to detect we have
Michael Foord mich...@voidspace.org.uk added the comment:
Committed revision 86649.
--
resolution: - accepted
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10470
Michael Foord mich...@voidspace.org.uk added the comment:
Eli - I quite agree. TestProgram is a *particularly* obscure part of unittest.
A much better solution (well - both would be ideal) would be to refactor the
code so that it isn't so obscure.
TestProgram is an artefact of unittest's
New submission from Michael Foord mich...@voidspace.org.uk:
Add the unittestgui test runner, built with Tk, to the Tools directory.
It would be good to have this script included in the bin/ directory of the Mac
installer as well.
The unittestgui runner can be found at:
https
Michael Foord mich...@voidspace.org.uk added the comment:
It will need documenting, or at least pointing to in the documentation,
probably with a note recommending Hudson for production use - unittestgui is a
tool for beginners / convenience.
Note also that Brian Curtin has contributed
Michael Foord mich...@voidspace.org.uk added the comment:
Bringing back callable but with a different name is horrible. Just bring it
back for goodness sake.
--
nosy: +michael.foord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Michael Foord mich...@voidspace.org.uk added the comment:
Well, Guido has already approved its return - so further debate is relatively
pointless. (Not that that usually stops us...)
--
___
Python tracker rep...@bugs.python.org
http
Michael Foord mich...@voidspace.org.uk added the comment:
It was on python-ideas in the recent thread about bringing back callable. Feel
free to post a link here for the record.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
New submission from Michael Foord mich...@voidspace.org.uk:
As discussed with tarek. It shouldn't be up to distutils2 to decide whether or
not a Python file that has been included in the package should be installed or
not if it is included in the set of files the developer has *asked
Michael Foord mich...@voidspace.org.uk added the comment:
I would love this functionality (I almost always initialise defaultdict with a
lambda that just returns a concrete value).
Unfortunately it seems like adding a keyword argument isn't possible because
defaultdict takes arbitrary keyword
Michael Foord mich...@voidspace.org.uk added the comment:
Well, I was perfectly aware of __missing__ - it's just a three liner to do it
when using a lambda isn't *that* bad... I'm sure the documentation could be
improved to highlight __missing__ though. It's almost always the case
Changes by Michael Foord mich...@voidspace.org.uk:
--
assignee: - michael.foord
components: +Library (Lib)
type: - behavior
versions: +Python 2.7, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10543
Michael Foord mich...@voidspace.org.uk added the comment:
Won't need fixing in 3.2. The __pycache__ changes mean that the module.__file__
no longer points to the compiled bytecode file.
--
versions: -Python 3.2
___
Python tracker rep
Michael Foord mich...@voidspace.org.uk added the comment:
I'm also thinking that it might be better to include the name of the
deprecated method in the message and use three filters for fail* methods,
assert* methods, and the assert*Regexp* methods that will be deprecated.
That sounds good
New submission from Michael Foord mich...@voidspace.org.uk:
Reported by Konrad Delong.
class MyTest(unittest.TestCase):
def setUp(self):
raise Exception
@unittest.expectedFailure
def testSomething(self):
assert False, test method failed
This code will report
Michael Foord mich...@voidspace.org.uk added the comment:
Scanning with Microsoft Security Essentials says no threat detected.
--
nosy: +michael.foord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10500
Michael Foord mich...@voidspace.org.uk added the comment:
We follow engineering which uses j.
(I was about to close this as wontfix but Antoine is particularly keen that
Mark deals with this issue...)
--
nosy: +michael.foord
___
Python tracker rep
Michael Foord mich...@voidspace.org.uk added the comment:
The same is also true for tearDown and cleanUp functions.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10548
Michael Foord mich...@voidspace.org.uk added the comment:
FWIW (which isn't much I guess) it annoys me that I have to protect calls to
issubclass with if isinstance(obj, type).
--
nosy: +michael.foord
___
Python tracker rep...@bugs.python.org
http
Michael Foord mich...@voidspace.org.uk added the comment:
Note that if an error is raised in a tearDown or cleanUp then
unexpected-success should not be reported either. Not very important but might
as well be fixed at the same time.
--
___
Python
New submission from Michael Foord mich...@voidspace.org.uk:
Having tests in Lib/test instead of inside the package makes it easier to grep
the unittest package without grepping the tests. The Windows installer has an
install without tests option which is easier to honour if the tests aren't
New submission from Michael Foord mich...@voidspace.org.uk:
The unittest documentation, argument names and implementation need to be
consistent about the order of (actual, expected) for TestCase.assert methods
that take two arguments.
This is particularly relevant for the methods
Michael Foord mich...@voidspace.org.uk added the comment:
__unittest needs to die (with appropriate deprecation).
I agree that a nicer API for marking functions and methods as needing to be
excluded from unittest stacktraces would be useful. A decorator is a good way
to expose that API
Michael Foord mich...@voidspace.org.uk added the comment:
Raymond - I created a new issue for moving the tests: issue 10572
However, it seems that you are incorrect in saying that Python practise is to
avoid putting tests inside standard library packages. In fact current Python
practise seems
Michael Foord mich...@voidspace.org.uk added the comment:
The same is true for 2.7 though, and that is getting bug fixes. svnmerge would
no longer work (and to making the change would mean moving the tests in a point
release).
--
___
Python tracker
Michael Foord mich...@voidspace.org.uk added the comment:
That list of examples was non-exhaustive, there is also tkinter.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10572
Michael Foord mich...@voidspace.org.uk added the comment:
Works for me too. Great!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9227
Michael Foord mich...@voidspace.org.uk added the comment:
Committed revision 86944.
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7911
New submission from Michael Foord mich...@voidspace.org.uk:
Reported by a unittest2 user.
A SystemExit (or GeneratorExit) will cause a test run to stop in 2.7 / 3.2.
This would just be reported as an error in 2.6.
from unittest import TestCase
def test(s):
... raise GeneratorExit
Changes by Michael Foord mich...@voidspace.org.uk:
--
title: sys.exit() in a test causes the run to stp - sys.exit() in a test
causes a test run to die
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10611
New submission from Michael Foord mich...@voidspace.org.uk:
It is hard for test infrastructure to halt a test run unless it has access to
the result object.
A StopTestRun exception could be provided. This could be caught in TestCase.run
and call TestResult.stop().
It could be parameterized
Changes by Michael Foord mich...@voidspace.org.uk:
--
nosy: -michael.foord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10562
___
___
Python
New submission from Michael Foord mich...@voidspace.org.uk:
If a test module fails to load during unittest test discovery (SyntaxError or
other exception) then the error is reported during the test run.
Due to the way the exception is re-raised the traceback is lost.
Originally reported
New submission from Michael Foord mich...@voidspace.org.uk:
Feature request against unittest2. Issue 18:
https://code.google.com/p/unittest-ext/issues/detail?id=18
As providing a file path instead of module name to the unittest command line
runner currently fails there is no backwards
Michael Foord mich...@voidspace.org.uk added the comment:
Committed revision 87003.
--
resolution: - fixed
stage: - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10620
Michael Foord mich...@voidspace.org.uk added the comment:
(made slightly redundant by Holger's comment but I'll continue anyway)
I think the issue is that setUp / tearDown are used for two different purposes.
The first is setting up and tearing down test infrastructure - where you do
want
Michael Foord mich...@voidspace.org.uk added the comment:
Well, the original report is here:
http://code.google.com/p/unittest-ext/issues/detail?id=21
I copied all the details provided into this issue though. Obviously the
original reporter feels that they have a genuine use case
Michael Foord mich...@voidspace.org.uk added the comment:
So from the stackframe you can only get to the code object not to the function
object and although the code object is also reachable from a decorator it isn't
mutable so we can't mark it in any way. We could in theory 're-build
Michael Foord mich...@voidspace.org.uk added the comment:
Global registry of code objects, hmmm... Could work. I'll prototype it and test
it with IronPython / Jython / pypy.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Michael Foord mich...@voidspace.org.uk added the comment:
At the moment exception handling for setUp / tearDown / testMethod and cleanUp
functions are all handled separately. They all have to call addError and as a
result we have inconsistent handling of skips, expected failures (etc
Changes by Michael Foord mich...@voidspace.org.uk:
--
nosy: +michael.foord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2212
___
___
Python-bugs
Michael Foord mich...@voidspace.org.uk added the comment:
Presumably not an issue for 3.1/3.2.
(Terry - I assume Sean means the fix is in the bug report comment when he says
'inline'.) A patch and a test would still be nice.
--
versions: +Python 2.7 -Python 2.6
Changes by Michael Foord mich...@voidspace.org.uk:
--
versions: +Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2212
___
___
Python-bugs
Michael Foord mich...@voidspace.org.uk added the comment:
The argument order doesn't match the name (which isn't a huge deal I don't
think) - but subset in dict does match the element in container order of
assertIn.
--
___
Python tracker rep
Michael Foord mich...@voidspace.org.uk added the comment:
Committed revision 87390.
It is a stretch to see this as a bugfix rather than a new feature so probably
*shouldn't* be backported to 2.7. On the other hand the fix is combined with
the fix for issue 9857 which *is* a bugfix and *should
Michael Foord mich...@voidspace.org.uk added the comment:
Correction, the fix is combined with the fix for issue 10611.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9857
Michael Foord mich...@voidspace.org.uk added the comment:
Committed to Python 2.7 in revision 87406.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http
Michael Foord mich...@voidspace.org.uk added the comment:
Improved implementation committed to 2.7 revision 87407. Method name unchanged
there.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10242
Michael Foord mich...@voidspace.org.uk added the comment:
This is committed to 2.7 and 3.2 (using the old name assertItemsEqual in 2.7).
As we're well into the beta cycle I don't think we can change the name in 3.2.
The current failure output is very nice for comparing sequences like [1, 2, 3
New submission from Michael Foord mich...@voidspace.org.uk:
sysconfig assumes there will be a makefile if the platform is posix, which
isn't always true. For example IronPython on Mac OS X with mono.
This leads to a traceback on startup with IronPython 2.7:
$ ipy27
Traceback (most recent call
Michael Foord mich...@voidspace.org.uk added the comment:
TextTestRunner is initialised with a stream to output messages on that defaults
to sys.stderr. The correct way to redirect messages is to construct it with a
different stream.
If you want a redirectable stream then construct
Michael Foord mich...@voidspace.org.uk added the comment:
Actually I can't see a good reason why not to just lookup the *current*
sys.stderr at instantiation time instead of binding at import time as is the
current behaviour.
Patch with tests will make it more likely that this change goes
Michael Foord mich...@voidspace.org.uk added the comment:
No, issue 9878 can't be implemented for Python 2.7 whereas the issues other
implementations have with sysconfig *could* still be resolved in 2.7 as a
bugfix. (Specifically for IronPython on Mac OS X it would mean not assuming
Michael Foord mich...@voidspace.org.uk added the comment:
Committed to py3k in revision 87582.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10786
Michael Foord mich...@voidspace.org.uk added the comment:
Thanks Terry. Done. Doc changes committed revision 87679.
--
keywords: -patch
nosy: -MarkRoddy, terry.reedy
resolution: - accepted
stage: needs patch - committed/rejected
status: open - closed
type: feature request - behavior
Michael Foord mich...@voidspace.org.uk added the comment:
I'm fine with this functionality being added in 3.3.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10775
Michael Foord mich...@voidspace.org.uk added the comment:
Committed revision 87685.
It would be nice to see this included in the Mac OS X and Windows distribution,
but I guess that applies to the *whole* Tools/ directory.
--
resolution: - accepted
stage: needs patch - committed
Michael Foord mich...@voidspace.org.uk added the comment:
This doesn't appear to be true on py3k (traceback.format_exc is used to
preserve the original traceback). Need to check on Python 2.7.
--
versions: -Python 3.2
___
Python tracker rep
Michael Foord mich...@voidspace.org.uk added the comment:
In Python 3.2 assertItemsEqual has been replaced with assertCountEqual that has
a completely different implementation and error format. The implementation and
error output will be backported to the assertItemsEqual method of 2.7
Michael Foord mich...@voidspace.org.uk added the comment:
Same is true of Python 2.7 - looks like an invalid error report.
--
resolution: - invalid
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep
Changes by Michael Foord mich...@voidspace.org.uk:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10620
___
___
Python
Michael Foord mich...@voidspace.org.uk added the comment:
It isn't in __all__ and it is undocumented - so I'd say its private already.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10859
Michael Foord mich...@voidspace.org.uk added the comment:
There was a discussion on python-dev about naming conventions in the standard
library. There was no clear consensus that everything non-public should start
with an underscore. Several developers thought that merely being undocumented
Michael Foord mich...@voidspace.org.uk added the comment:
I have no objection to a rename that adds a leading underscore.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10859
Changes by Michael Foord mich...@voidspace.org.uk:
--
nosy: -michael.foord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10859
___
___
Python
Michael Foord mich...@voidspace.org.uk added the comment:
This looks good Ned. My main concern is that we make it clear from the
*Download* page that users who want IDLE to just work (even on 10.6) they
should install the 32 bit version.
Noting that Activestate Tcl/Tk 8.5 is a *requirement
Michael Foord mich...@voidspace.org.uk added the comment:
For what it's worth I prefer Raymond's original wording. Installing the
Activestate Tcl/Tk will never be a *bad* thing to do for using Python, so I
don't see a problem with stating it as a requirement. Users are unlikely to see
Michael Foord mich...@voidspace.org.uk added the comment:
There are a few issues here.
X11 is not installed by *default* on Mac OS X (it is supplied separately) so it
doesn't provide an out of the box solution.
Starting IDLE as 32bit alone doesn't solve the problem as it launches
Changes by Michael Foord mich...@voidspace.org.uk:
--
assignee: - michael.foord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10979
Michael Foord mich...@voidspace.org.uk added the comment:
There was a BDFL ruling on python-dev mailing list that assert argument names
should be (first, second).
See:
http://mail.python.org/pipermail/python-dev/2010-December/106954.html
I'm basically reverting the patch to go back
Michael Foord mich...@voidspace.org.uk added the comment:
Note that I looked at making the sequence comparison code symmetric - but it
generates nice diffs for even nested containers by using prettyprint and
difflib. Switching to a symmetric output (in first, not in second etc) would
be very
Michael Foord mich...@voidspace.org.uk added the comment:
Activestate has said (replying to me on Twitter as it happens) that a patch is
available and they will do a new 8.5 release before 3.2 final.
--
___
Python tracker rep...@bugs.python.org
http
Michael Foord mich...@voidspace.org.uk added the comment:
Ronald: The subprocess also uses Tkinter (right?) so would also require 32bit.
FWIW I'm -1 on X11 as well.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10973
Michael Foord mich...@voidspace.org.uk added the comment:
The reason I think it is an issue is that a previous release of Python 2.7
could start IDLE (the initial window would appear), but a dialog would also
appear saying that it could not connect to the subprocess and IDLE would exit.
IDLE
Michael Foord mich...@voidspace.org.uk added the comment:
Patch to docs and minor change to assertCountEqual to not use actual / expected
internally.
--
Added file: http://bugs.python.org/file20580/expected-actual.diff
___
Python tracker rep
Changes by Michael Foord mich...@voidspace.org.uk:
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10573
New submission from Michael Foord mich...@voidspace.org.uk:
Looks like some unittest doc changes got incorrectly backported to Python 3.1.
For example the command line features using -m are new in 3.2 and don't work
with 3.1:
http://docs.python.org/py3k/library/unittest.html#command-line
Michael Foord mich...@voidspace.org.uk added the comment:
This incorrect section on unittest command line features was added by Eric
according to svn blame.
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Michael Foord mich...@voidspace.org.uk added the comment:
The fix is to use dict methods rather than accessing members through the
instance. It will have to wait until 3.2 is out now though.
--
___
Python tracker rep...@bugs.python.org
http
Changes by Michael Foord mich...@voidspace.org.uk:
--
assignee: - michael.foord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11133
Michael Foord mich...@voidspace.org.uk added the comment:
Care to provide a patch Noufal?
--
nosy: +michael.foord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11151
New submission from Michael Foord mich...@voidspace.org.uk:
Reported by a user and verified by me with both Python 2.7 and 3.2.
Trying to run tests by module or package name seems to fail.
directory structure:
project root: C:\Users\hpierson\Projects\pytest
\test
Michael Foord mich...@voidspace.org.uk added the comment:
__dict__ as a property is documented as an exception to the no code execution
claim.
The patch is not sufficient - instances may have a class member __dict__
whilst still having an instance __dict__. Alternatively the __dict__ property
Michael Foord mich...@voidspace.org.uk added the comment:
Sounds like a good change to the docs. Care to provide a patch?
--
nosy: +michael.foord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11298
Michael Foord mich...@voidspace.org.uk added the comment:
Thanks blokely, looks good. Needs applying to 2.7 / 3.2 and 3.3 branches.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11298
Michael Foord mich...@voidspace.org.uk added the comment:
Hey, blokeley the same patch will apply cleanly against 3.2 / 3.3 so no worries.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11298
Michael Foord mich...@voidspace.org.uk added the comment:
And also issue 10764. This issue affects alternative implementations of Python.
--
nosy: +michael.foord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9878
Michael Foord mich...@voidspace.org.uk added the comment:
Actually I think these methods are going back in and staying deprecated, so
hold off for a bit.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11282
Changes by Michael Foord mich...@voidspace.org.uk:
--
assignee: docs@python - michael.foord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11282
Michael Foord mich...@voidspace.org.uk added the comment:
No, tests as top level modules work fine too. Importability is the only
requirement. (Projects themselves are not typically packages but contain
packages - so the wording needs to change slightly but I like the rest
Michael Foord [EMAIL PROTECTED] added the comment:
Made quite extensive changes to tokenize.py (with tests) for Py3k. This
migrates it to a 'bytes' API so that it can correctly decode Python
source files following PEP-0263.
--
nosy: +fuzzyman
Added file: http://bugs.python.org/file9735
Michael Foord [EMAIL PROTECTED] added the comment:
That was 'by discussion with wiser heads than I'. The existing module
has an old backwards compatibility interface called 'tokenize'. That can
be deprecated in 2.6.
As 'tokenize' is really the ideal name for the main entry point for the
module
1 - 100 of 1059 matches
Mail list logo
