Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
I have updated both the test and the implementation to address your feedback.
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Change by Pablo Galindo Salgado <pablog...@gmail.com>:
--
nosy: +pablogsal
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31800>
___
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
IMHO this change makes things a bit more consistent. In lots of places when a
tuple is returned, a `structseq` is used to improve readability on the returned
result. Some examples of this are:
* grp.struct_group
* os.termina
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
With the exception of string.FormatterItem, which is the change at hand.
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
New submission from Pablo Galindo Salgado <pablog...@gmail.com>:
Following PR for https://bugs.python.org/issue31786 time_sleep,
lock_acquire_parse_args and socket_parse_timeout should use
_PyTime_ROUND_TIMEOUT instead of _PyTime_ROUND_CEILING.
--
components: Library (Lib)
me
Change by Pablo Galindo Salgado <pablog...@gmail.com>:
--
keywords: +patch
pull_requests: +4001
stage: -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Change by Pablo Galindo Salgado <pablog...@gmail.com>:
--
pull_requests: +3997
stage: backport needed -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Change by Pablo Galindo Salgado <pablog...@gmail.com>:
--
keywords: +patch
pull_requests: +4447
stage: needs patch -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
I have prepared a patch (attached) with a possible implementation of the C
function that can filter traceback objects modifying the traceback chain. I can
make a PR if the patch looks good enough to start iterating over it. I
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
I have updated the PR with the requested changes.
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
Sorry about that. The context manager is "gc.Disabled()", which I admit is
probably a bad name. The documentation is an example of the "equivalent" Python
code as stated by Raymond in the f
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
Just to clarify the current situation: At this point, the contextmanager is
referred as "disabled" in the C code but is exported as "Disabled" to the
garbage collection module. The "gc_disabled&qu
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
I just realize that the link I provided is incorrect. This is the correct one
(also is the one that appears in this issue anyway):
https://github.com/python/cpython/pul
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
I have prepared a PR in GitHub with an initial implementation of the context
manager trying to fulfil the discussed requirements:
https://github.com/python/cpython/pull/3980
--
nosy: +pab
Change by Pablo Galindo Salgado <pablog...@gmail.com>:
--
keywords: +patch
pull_requests: +4192
stage: needs patch -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Change by Pablo Galindo Salgado <pablog...@gmail.com>:
--
keywords: +patch
pull_requests: +4284
stage: needs patch -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Change by Pablo Galindo Salgado <pablog...@gmail.com>:
--
pull_requests: +4645
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Change by Pablo Galindo Salgado <pablog...@gmail.com>:
--
keywords: +patch
pull_requests: +4646
stage: needs patch -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Change by Pablo Galindo Salgado <pablog...@gmail.com>:
--
keywords: +patch
pull_requests: +4644
stage: needs patch -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Change by Pablo Galindo Salgado <pablog...@gmail.com>:
--
keywords: +patch
pull_requests: +4091
stage: -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
This issue is fixed in the master branch (version 3.7.0 alpha 2). The issue was
fixed in this PR:
https://github.com/python/cpython/pull/1669
The cause is that async was not a proper keyword and the parser segfaults when
ch
Change by Pablo Galindo Salgado <pablog...@gmail.com>:
--
keywords: +patch
pull_requests: +4033
stage: needs patch -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.py
Change by Pablo Galindo Salgado <pablog...@gmail.com>:
--
keywords: +patch
pull_requests: +4137
stage: needs patch -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
I have tracked the issue down to the call inside the call to initscr in
_cursesmodule.c. The issue *seems* related to the fact that all processes are
sharing the same initialization of the curses internal stru
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
Also, it seems that calling initscr registers signal handlers for SIGTERM:
Without calling initscr:
...
rt_sigaction(SIGINT, {sa_handler=0x55d9351a9155, sa_mask=[],
sa_flags=SA_RESTORER, sa_restorer=0x7f7d22b36da0}, {sa_h
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
One open question is how to construct and pass through the struct "sched_param"
that “posix_spawnattr_setschedparam” needs.
--
___
Python tracker <rep...@bugs
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
Thanks! I have updated the PR and added tests.
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
I think that is the biggest argument towards using a tuple: that just setting
the priority is not enough (and also is decontextualized as different policies
have different priorities). On the other hand one could say that t
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
Regarding the rationale for when posix_spawn can be useful (from the RATIONALE
section of the man page):
The posix_spawn() function and its close relation posix_spawnp() have been
introduced to overcome the following per
Change by Pablo Galindo Salgado <pablog...@gmail.com>:
--
pull_requests: +6479
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
Notice that https://github.com/python/cpython/pull/6794 is already open to
remove posix_spawn from 3.7.
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Change by Pablo Galindo Salgado <pablog...@gmail.com>:
--
Removed message: https://bugs.python.org/msg316526
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
Some interesting benchmarks of posix spawn:
https://github.com/rtomayko/posix-spawn/blob/master/README.md
--
components: -Library (Lib)
priority: normal -> release blocker
versions: +P
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
Also this reading may be relevant/interesting:
https://about.gitlab.com/2018/01/23/how-a-fix-in-go-19-sped-up-our-gitaly-service-by-30x/
--
___
Python tracker <rep...@bugs.p
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
I originally removed it from the configure script in PR6794 but it was
reintroduced in commit 57009526f6a405e0ffe8c16012cce509b62cb577. Check the PR
for Greg's rationale.
--
___
Change by Pablo Galindo Salgado :
--
pull_requests: +7278
___
Python tracker
<https://bugs.python.org/issue33630>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
Serhiy, I am checking and the only temporary Python object (the result of
encoding/decoding) that is passed to C library function that I can find is in:
if (!PyArg_ParseTuple(file_action, "OiO"
Pablo Galindo Salgado added the comment:
Updated PR7735 with the checks for invalid parameters.
--
___
Python tracker
<https://bugs.python.org/issue33
Pablo Galindo Salgado added the comment:
What about:
"If tempdir is unset or None (the default value has not been modified) ..."
?
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.o
Pablo Galindo Salgado added the comment:
New failure on x86 Windows7 3.x:
http://buildbot.python.org/all/#/builders/58/builds/1000
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue30
Change by Pablo Galindo Salgado :
--
pull_requests: +7285
___
Python tracker
<https://bugs.python.org/issue25246>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
If we want to support older versions of glibc a temporary (and somewhat
inelegant) workaround is storing the temporaries in a list that the caller
passes and destroy the list after calling `posix_spawn
Pablo Galindo Salgado added the comment:
I have updated the PR with a workaround.
--
___
Python tracker
<https://bugs.python.org/issue33630>
___
___
Python-bug
New submission from Pablo Galindo Salgado :
The test `test_multiprocessing_spawn` is leaking memory according to the x86
Gentoo Refleaks 3.x buildbot:
x86 Gentoo Refleaks 3.x
http://buildbot.python.org/all/#/builders/1/builds/253
test_multiprocessing_spawn leaked [1, 2, 1] memory blocks
Change by Pablo Galindo Salgado :
--
pull_requests: +7298
___
Python tracker
<https://bugs.python.org/issue33630>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
Serhiy commented in the PR:
>__GLIBC__ and __GLIBC_MINOR__ give you the version of glibc used at >compile
>time. But can not the different version be dynamically linked at >run time?
Should we use the list approach always to av
Pablo Galindo Salgado added the comment:
In PR 7663 I am only fixing the race condition.
--
___
Python tracker
<https://bugs.python.org/issue33630>
___
___
Pytho
Pablo Galindo Salgado added the comment:
Should we merge PR6693 and PR6725 before fixing the memory problem?
--
___
Python tracker
<https://bugs.python.org/issue33
Pablo Galindo Salgado added the comment:
A separate PR is needed for the apparent reusing of freed memory in the
implementation of posix_spawn. I am currently looking into it.
--
___
Python tracker
<https://bugs.python.org/issue33
Pablo Galindo Salgado added the comment:
I have updated PR7685 to use the temporary list as per Serhiy comments.
--
___
Python tracker
<https://bugs.python.org/issue33
Pablo Galindo Salgado added the comment:
As I commented on GitHub, it seems that the race in the test (problem covered
in PR7663) disappears once the memory problem is fixed (PR33630). As is a race
condition I am not sure that this affirmation is true, but running 3 test
suites in parallel
Pablo Galindo Salgado added the comment:
I think this should be something that is not included in argparse itself. I can
imagine a scenario in which the manpage is accessible through `./python foo.py
--manpage` but the manpage is not installed systemwide. This will be very
confusing
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue33829>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
Could you make a PR correcting this bug? If you cannot I can do it instead. :)
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue33
Pablo Galindo Salgado added the comment:
Python++: Sorry, I still cannot understand exactly what is wrong. Could you
please redact a little paragraph explaining (1) what function/functions are you
using (and maybe a very short example), (2) what is not working and (3) what do
you expect
Change by Pablo Galindo Salgado :
--
title: example output error -> Error in the output of one example in the
httplib docs
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
>What would cause that confusion? This is not something that would
>change how ‘argparse’ parses its arguments, so I don't know what
>you're referring to.
The (possible) confusion is the existence of a manpage only available though
argparse (
Pablo Galindo Salgado added the comment:
Since dictionaries are ordered "ordered dictionary" can be a synonym of
"dictionary" and "OrderDict", right?
--
nosy: +pablogsal
___
Python tracker
<h
Pablo Galindo Salgado added the comment:
Well, technically a function can say that it returns a dictionary and this
dictionary will be ordered in 3.6> but is not important for the function return
value. If a function says that it returns a "ordered dictionary" I now (1) th
Pablo Galindo Salgado added the comment:
Just for clarification. My question in the PR was:
>I think these are not the only occurrences of method referring to a
>magic method. A quick grep reveals that there are more places where the
>construction the __something__ method happens.
Change by Pablo Galindo Salgado :
--
components: +Library (Lib)
versions: +Python 3.8
___
Python tracker
<https://bugs.python.org/issue33870>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
It seems that it was this commit:
https://github.com/python/cpython/commit/5619ab2db3a6c62ffaa55e8826cf67b7459fc484
--
___
Python tracker
<https://bugs.python.org/issue33
Pablo Galindo Salgado added the comment:
And this PR:
https://github.com/python/cpython/pull/698
--
___
Python tracker
<https://bugs.python.org/issue33
Pablo Galindo Salgado added the comment:
test_gdb is failing on the following buildbots:
x86 Gentoo Non-Debug
http://buildbot.python.org/all/#builders/99/builds/1095
AMD64 Debian PGO 3.x
http://buildbot.python.org/all/#builders/47/builds/1173
Gentoo Non-Debug with X 3.7
http
Change by Pablo Galindo Salgado :
--
Removed message: https://bugs.python.org/msg319670
___
Python tracker
<https://bugs.python.org/issue32962>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
Docs for sendfile in macOS:
https://www.unix.com/man-page/osx/2/sendfile/
--
___
Python tracker
<https://bugs.python.org/issue33
Pablo Galindo Salgado added the comment:
I can reproduce the issue on a i686 GNU/Linux Debian system:
>>> import os
>>> f = open('/tmp/temp', 'wb')
>>> l = os.writev(f.fileno(), [b'x' * 2**16] * 2**15)
Traceback (most recent call last):
File "",
Pablo Galindo Salgado added the comment:
I cannot reproduce this in 3.6.5:
>>>import sys
>>>import gc
>>>a = type(sys)('a')
>>>b = a.__dict__
>>>print(b['__name__'] is None)
False
>>>del a
>>>gc.collect()
>>>print(b['__n
New submission from Pablo Galindo Salgado :
I am not sure is a problem we can do something about but right know if you run
the refleak tests with low repetitions it reports leaks:
./python -m test test_list -R 1:1
Run tests sequentially
0:00:00 load avg: 0.66 [1/1] test_list
beginning 2
Change by Pablo Galindo Salgado :
--
title: False positives when running refleaks tests with -R 1:1 -> False
positives when running leak tests with -R 1:1
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Let's make the buildbots happier!
--
___
Python tracker
<https://bugs.python.org/issue33873>
___
___
Python-bugs-list m
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +7346
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
pull_requests: +7347
___
Python tracker
<https://bugs.python.org/issue33873>
___
___
Python-bugs-list mailing list
Unsub
New submission from Pablo Galindo Salgado :
It seems that since c489a767af46f33e73d96a5746e46a7365814db2 the AMD64
Windows10 buildbot for Python3.6 fails to compile. Error log:
Using "C:\Program Files (x86)\MSBuild\14.0\bin\\msbuild.exe" (found in the
registry)
Cannot locate M
Pablo Galindo Salgado added the comment:
http://buildbot.python.org/all/#/builders/31/builds/321
--
___
Python tracker
<https://bugs.python.org/issue33
Pablo Galindo Salgado added the comment:
Could http://buildbot.python.org/all/#/builders/90/builds/350 be related to
this?
--
___
Python tracker
<https://bugs.python.org/issue33
Change by Pablo Galindo Salgado :
--
pull_requests: +6883
___
Python tracker
<https://bugs.python.org/issue31368>
___
___
Python-bugs-list mailing list
Unsub
Change by Pablo Galindo Salgado :
--
pull_requests: +6884
___
Python tracker
<https://bugs.python.org/issue26826>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado <pablog...@gmail.com> added the comment:
@serhiy.storchaka Is the race condition/freed memory reusage in the test suite
or in the posix module?
--
nosy: +pablogsal
___
Python tracker <rep...@bugs.python.or
Pablo Galindo Salgado added the comment:
Buildbot AMD64 FreeBSD 10.x Shared 3.x is failing with the same problem:
Assertion failed: (_PyGCHead_REFS(gc) != 0), function visit_decref, file
Modules/gcmodule.c, line 277.
Fatal Python error: Aborted
--
nosy: +pablogsal
Pablo Galindo Salgado added the comment:
The test fails also on x86 Windows7 3.x:
http://buildbot.python.org/all/#/builders/58/builds/947
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue33
Pablo Galindo Salgado added the comment:
Same error in AMD64 Windows10 3.x:
http://buildbot.python.org/all/#/builders/3/builds/941
--
___
Python tracker
<https://bugs.python.org/issue33
New submission from Pablo Galindo Salgado :
test_gdb is currently failing on the following buildbots:
http://buildbot.python.org/all/#/builders/54/builds/465
http://buildbot.python.org/all/#/builders/66/builds/178
http://buildbot.python.org/all/#/builders/16/builds/1279
http
Pablo Galindo Salgado added the comment:
New changeset 58ed7307ea0b5c5aa052291ebc3030f314f938d8 by Pablo Galindo in
branch 'master':
bpo-33873: Fix bug in `runtest.py` and add checks for invalid `-R` parameters
(GH-7735)
https://github.com/python/cpython/commit
Pablo Galindo Salgado added the comment:
The process seems to use its own stderr and it cannot be captured from the
parent without modifying it AFAIK.
--
___
Python tracker
<https://bugs.python.org/issue33
Pablo Galindo Salgado added the comment:
I have modified the PR to avoid creating an extra pipe in the tracker (the pipe
is created as part of the test). To allow testing with the -R option:
./python -m test test_multiprocessing_fork -v -m test_semaphore_tracker_sigint
-R 3:3
I had
Pablo Galindo Salgado added the comment:
I have updated the PR implementing a PONG command in the semaphore and updating
the test. I have tested on the failing buildbots (gcc110.fsffrance.org) and it
works. Notice that a new pipe for the child to write was needed as the child
Pablo Galindo Salgado added the comment:
Maybe we should include a test that checks that if you provide an invalid file
the file descriptors are not leaked (it can be in a different PR, maybe).
--
___
Python tracker
<https://bugs.python.
Pablo Galindo Salgado added the comment:
The current status of json.tool also leaks a file descriptor if you use the
same filename or an invalid one (needs debug build to receive this error
message):
$ ./python -m json.tool invalid_file.dat nofile.dat
Expecting value: line 1 column 1 (char
Pablo Galindo Salgado added the comment:
@Rémi can you include a NEWS entry?
Also, indicate that your patch prevents a file descriptor to be leaked in the
cases indicated in my last message.
--
___
Python tracker
<https://bugs.python.
Pablo Galindo Salgado added the comment:
I think commit4ffe9c2b251f6e027b26250b7a2618e78d4edd22 from bpo-33718 should be
backported IMO:
bpo-33718: regrtest: use format_duration() to display failed tests (GH-7686)
https://github.com/python/cpython/commit
Pablo Galindo Salgado added the comment:
There are two problems in test_semaphore_tracker_sigint. One of the problems is
that if `should_die` is False, the code does not check
that no warning is raised (and the warning is being raised, so this
the error has pass silently.) The other problem
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +7436
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
What error do you get and what opera version are you using?
--
___
Python tracker
<https://bugs.python.org/issue34
Pablo Galindo Salgado added the comment:
I can use
opera -remote "openURL(https://google.com,new-window)"
without problems as per the opera documentation with the latest version:
$opera --version
53.0.2907.110
--
nosy: +pablogsal
Pablo Galindo Salgado added the comment:
Sorry, you are right! It seems that my Opera opened another tab with Google by
default and I was confused by that. Thanks for the context.
--
___
Python tracker
<https://bugs.python.org/issue34
Pablo Galindo Salgado added the comment:
New changeset 3cf1f154edb88c108877729ea09f4ac174697fea by Pablo Galindo (Bumsik
Kim) in branch 'master':
bpo-34019: Fix wrong arguments for Opera Browser (#8047)
https://github.com/python/cpython/commit/3cf1f154edb88c108877729ea09f4ac174697fea
Pablo Galindo Salgado added the comment:
In /Lib/test/test_urllib2_localnet.py there is an incorrect usage of
unittest.TestCase.fail (an extra comma makes it use two arguments instead of
one):
class BasicAuthTests(unittest.TestCase):
...
def test_basic_auth_success(self
Change by Pablo Galindo Salgado :
--
Removed message: https://bugs.python.org/msg320975
___
Python tracker
<https://bugs.python.org/issue34031>
___
___
Python-bug
New submission from Pablo Galindo Salgado :
In /Lib/test/test_urllib2_localnet.py there is an incorrect usage of
unittest.TestCase (an extra comma makes it use two arguments instead of one):
class BasicAuthTests(unittest.TestCase):
...
def test_basic_auth_success(self
1 - 100 of 4424 matches
Mail list logo
