Petr Viktorin added the comment:
Thinking more about Doc/data/stable_abi.dat, I don't think the rename is worth
it. The file is not meant to be used/edited by humans.
If someone needs the data for something other than running the Sphinx
extension, let me know. We should provide a proper data
Change by Petr Viktorin :
--
pull_requests: +30441
pull_request: https://github.com/python/cpython/pull/32415
___
Python tracker
<https://bugs.python.org/issue47
Change by Petr Viktorin :
--
pull_requests: +30440
pull_request: https://github.com/python/cpython/pull/32414
___
Python tracker
<https://bugs.python.org/issue47
Change by Petr Viktorin :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
This has been solved by the new theme. The Goolgle report linked above shows
“Passed” and “96” (out of 100).
It does show a few opportunities to improve, but many seem to indirectly
complain that the page is big.
I'm closing the issue.
--
nosy
Change by Petr Viktorin :
--
keywords: +patch
pull_requests: +30414
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/32365
___
Python tracker
<https://bugs.python.org/issu
Petr Viktorin added the comment:
New changeset d79f118d044e9b4244b5dfda35448d39202d7f56 by Petr Viktorin in
branch 'main':
bpo-47115: Document which parts of structs are in limited API/stable ABI
(GH-32196)
https://github.com/python/cpython/commit/d79f118d044e9b4244b5dfda35448d39202d7f56
Change by Petr Viktorin :
--
pull_requests: +30412
pull_request: https://github.com/python/cpython/pull/32365
___
Python tracker
<https://bugs.python.org/issue47
Petr Viktorin added the comment:
- PEP 570 (Python Positional-Only Parameters) is final
- The language spec was updated to mention it
- the FAQ entry was revised to not link to the PEP and be a self-contained
explanation
IMO the only thing left is to make searching for `/` yield the right
Petr Viktorin added the comment:
New changeset 079143df7e40c4d336cb5c385b166aa91058d050 by Petr Viktorin in
branch 'main':
bpo-47168: Mark files generated by `make regen-limited-abi` as generated
(GH-32195)
https://github.com/python/cpython/commit/079143df7e40c4d336cb5c385b166aa91058d050
New submission from Petr Viktorin :
malloc() returns memory that's "suitably aligned for any built-in type".
All of Python's allocation functions should do the same.
In bpo-27987 (PR-12850, PR-13336), the alignment was raised* to 16 bytes and
`long double`. This is OK f
Petr Viktorin added the comment:
> Ah, sorry, I could have described the issue better. It's not a problem with
> exporting, PyThread_get_thread_native_id() isn't available on Solaris (and
> possibly other platforms) at all.
Jakub, does this mean test_stable_abi_ctypes fails o
New submission from Petr Viktorin :
- PyThread_get_thread_native_id is only available when PY_HAVE_THREAD_NATIVE_ID
is defined. The test currently always expects it to be available.
- PyOS_CheckStack is only available when USE_STACKCHECK is defined (i.e. on
Windows). It should be exported
New submission from Petr Viktorin :
This issue groups together a few changes I'd like to make:
- Rename Doc/data/stable_abi.dat to *.csv, so it gets syntax highlighting. (The
only user of that file should be the Sphinx extension)
- Mark autogenerated files as such in .gitattributes
- Convert
Change by Petr Viktorin :
--
keywords: +patch
pull_requests: +30274
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/32195
___
Python tracker
<https://bugs.python.org/issu
Change by Petr Viktorin :
--
keywords: +patch
pull_requests: +30272
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/32196
___
Python tracker
<https://bugs.python.org/issu
Petr Viktorin added the comment:
So. According to PEP 384 (which added all structs in the stable ABI, except
Py_buffer), some structs are opaque and others have a few members exposed:
https://peps.python.org/pep-0384/#structures
I will split the latter into 1) structs that have a few fields
New submission from Petr Viktorin :
importlib.resources.files is documented [0] as returning
importlib.resources.abc.Traversable, which is an undocumented class (dead link)
now. It should be documented.
The [source] has helpful docstrings, but is missing some details. I'd like to
know
Petr Viktorin added the comment:
Thanks for the report! You're right that this is misleading. I'll clarify the
docs for this and other structs.
- struct PyTypeObject is part if the limited API.
- its fields and size are not part of the API or stable ABI
Petr Viktorin added the comment:
New changeset 48d926269963cfe7a49c0a4f34af4fe9b832399b by Miro Hrončok in
branch 'main':
bpo-45413: Define "posix_venv", "nt_venv" and "venv" sysconfig installation
schemes (GH-31034)
https://gi
Change by Petr Viktorin :
--
assignee: -> docs@python
components: +Documentation
nosy: +docs@python
___
Python tracker
<https://bugs.python.org/issu
Petr Viktorin added the comment:
The PR is merged and buildbots are green. Thank you to everyone who helped!
Now would be a good time to bikeshed wording in the documentation.
>From the PR:
> Would it be good to mention in the docs why load() takes only binary files?
> The
Petr Viktorin added the comment:
New changeset 591f6754b56cb7f6c31fce8c22528bdf0a99556c by Taneli Hukkinen in
branch 'main':
bpo-40059: Add tomllib (PEP-680) (GH-31498)
https://github.com/python/cpython/commit/591f6754b56cb7f6c31fce8c22528bdf0a99556c
--
nosy: +petr.viktorin
Petr Viktorin added the comment:
Steve, could you take a look at the PR discussion and chime in about how this
should be done?
--
___
Python tracker
<https://bugs.python.org/issue45
Petr Viktorin added the comment:
The current fix skips all of the tests, rather than just the parts that fail.
--
nosy: +petr.viktorin
resolution: fixed ->
status: closed -> open
___
Python tracker
<https://bugs.python.org/i
Petr Viktorin added the comment:
Thank you, Kumar & Victor, for fixing up the issue!
I meant to check the buildbots before closing the issue, but got side-tracked.
--
stage: patch review -> resolved
status: pending -> closed
___
Pyth
Petr Viktorin added the comment:
New changeset 2c228a7b8f89e9ed8d390370abd771d4993b79d8 by Petr Viktorin in
branch 'main':
bpo-46748: Don't import in public headers (GH-31553)
https://github.com/python/cpython/commit/2c228a7b8f89e9ed8d390370abd771d4993b79d8
Petr Viktorin added the comment:
OK, looking at it more carefully, it makes sense to do the change.
--
___
Python tracker
<https://bugs.python.org/issue46
Change by Petr Viktorin :
--
keywords: +patch
pull_requests: +29674
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/31553
___
Python tracker
<https://bugs.python.org/issu
Petr Viktorin added the comment:
So, this will break Cython and gevent, but (unlike the optimization work that
broke f_code/f_frame) it won't provide any value to users?
I don't see how that's a good idea.
--
___
Python tracker
<ht
Petr Viktorin added the comment:
I assume a PR review should be enough.
--
components: +Library (Lib) -Interpreter Core
___
Python tracker
<https://bugs.python.org/issue46
Petr Viktorin added the comment:
It is in C99, but in an optional header.
IMO, including the header in the internals is perfectly OK, but opting everyone
else in isn't very nice.
i.e. it would probably be OK to use `_Bool`, the actual C99 keyword that `bool`
is defined as. But that's ugly
Petr Viktorin added the comment:
Yes, stdbool.h is essentially a backport of C++'s bool type to C.
--
___
Python tracker
<https://bugs.python.org/issue46
New submission from Petr Viktorin :
In main, cpython/pystate.h newly includes stdbool.h, providing a definition for
`bool` that might be incompatible with other software.
See here: https://github.com/cmusphinx/sphinxbase/pull/90
Eric, is this necessary? Would an old-school `int` do
Petr Viktorin added the comment:
It's in public API, adding it to limited is still pending.
--
___
Python tracker
<https://bugs.python.org/issue46613>
___
___
Petr Viktorin added the comment:
New changeset 204946986feee7bc80b233350377d24d20fcb1b8 by Petr Viktorin in
branch 'main':
bpo-46613: Add PyType_GetModuleByDef to the public API (GH-31081)
https://github.com/python/cpython/commit/204946986feee7bc80b233350377d24d20fcb1b8
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
New changeset 8b8673fe940c4ebc4512bff5af180b66def3d1ae by Petr Viktorin in
branch '3.10':
[3.10] bpo-46433: _PyType_GetModuleByDef: handle static types in MRO (GH-30696)
(GH-31262)
https://github.com/python/cpython/commit
Petr Viktorin added the comment:
Just 3.10, after all. 3.9 doesn't have the function yet.
I did the backport, but I'd welcome a review by a fresh set of eyes!
--
versions: -Python 3.9
___
Python tracker
<https://bugs.python.org/issue46
Change by Petr Viktorin :
--
pull_requests: +29429
stage: backport needed -> patch review
pull_request: https://github.com/python/cpython/pull/31262
___
Python tracker
<https://bugs.python.org/issu
Petr Viktorin added the comment:
> I think we want the scheme to be static and accessible on all platforms, like
> the others. So it probably should be 'nt_venv' and 'posix_venv' with
> additional/improved logic to help apps determine when they need each.
Why? (This is a real qu
Petr Viktorin added the comment:
> IMO this PEP is outdated for a long time.
It is not. Even if it is, it should be marked as such, and that is not a
decision that should be done in this issue.
Please, don't break the rules because you think they're outdated.
> Well, if you ask me, I
Petr Viktorin added the comment:
Adding new C99 features needs a change in PEP 7
(https://www.python.org/dev/peps/pep-0007/#c-dialect)
--
nosy: +petr.viktorin
status: closed -> open
___
Python tracker
<https://bugs.python.org/issu
Petr Viktorin added the comment:
Almost. It's a bugfix so it needs backports to 3.10 & 3.9.
Thanks for the reminder!
I should get to them next week.
--
status: pending -> open
___
Python tracker
<https://bugs.python.org/
Petr Viktorin added the comment:
Since this is a user-visible change in 3.11, could you add a What's New entry?
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue42
Change by Petr Viktorin :
--
keywords: +patch
pull_requests: +29264
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/31081
___
Python tracker
<https://bugs.python.org/issu
New submission from Petr Viktorin :
_PyType_GetModuleByDef (added in bpo-42100)allows module state access
from slot methods (like tp_init or nb_add),
the main thing missing from PEP 573 (Module State Access from C
Extension Methods).
It's time to make it public.
The function itself can
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Petr Viktorin :
--
pull_requests: +29260
pull_request: https://github.com/python/cpython/pull/31076
___
Python tracker
<https://bugs.python.org/issue45
Petr Viktorin added the comment:
> I would hope that competent C programmers would know not to read or write to
> undocumented fields. But if they come from a Python background, that might
> not be obvious.
Tread carefully when changing decades-old API, documented or not. The docs
Change by Petr Viktorin :
--
nosy: +petr.viktorin
nosy_count: 2.0 -> 3.0
pull_requests: +29215
pull_request: https://github.com/python/cpython/pull/31032
___
Python tracker
<https://bugs.python.org/issu
Change by Petr Viktorin :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue44734>
___
___
Pyth
Petr Viktorin added the comment:
New changeset aa78287bc6d1c4fc07ee134642eb72db67b771a0 by Karolina Surma in
branch 'main':
bpo-44734: Fix floating point precision in test_turtle (GH-30910)
https://github.com/python/cpython/commit/aa78287bc6d1c4fc07ee134642eb72db67b771a0
Petr Viktorin added the comment:
> The first and last test should use assertAlmostEqual with a suitable
> tolerance (the default tolerance is probably fine).
The merged PR only added tolerance to the last test. On some architectures, the
first test still fails.
(No one is to
Petr Viktorin added the comment:
Embarassingly, it seems it bust needs regen-importlib, at least for 3.10
--
___
Python tracker
<https://bugs.python.org/issue45
Change by Petr Viktorin :
--
pull_requests: +29101
pull_request: https://github.com/python/cpython/pull/30922
___
Python tracker
<https://bugs.python.org/issue45
Petr Viktorin added the comment:
Yeah, that looks like it's for some long-forgotten compiler that didn't
implement `signed char` at all. 1994 was a fun time, apparently.
--
nosy: -miss-islington
___
Python tracker
<https://bugs.python.
Petr Viktorin added the comment:
> Is there a reason to not add these fields to PyTypeObject?
Can't say I haven't thought of that, but AFAIK it would mean breaking the C API
substantially. Even if not it'd be a PEP-sized change, IMO.
--
nosy: +petr.vikto
Petr Viktorin added the comment:
I guess at least there should be a warning about this in dataclasses docs?
The reproducer with dataclasses (which exhibits the same error on 3.10 and
3.11):
import dataclasses
@dataclasses.dataclass(slots=True)
class A:
pass
@dataclasses.dataclass
Petr Viktorin added the comment:
> Sharing objects between interpreters is bad
That's your opinion, I don't necessarily share it.
> and is causing complex bugs.
But converting static things (types, small ints) to heap is also causing bugs :(
Anyway, for this issue: is there
Change by Petr Viktorin :
--
keywords: +patch
pull_requests: +28894
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30696
___
Python tracker
<https://bugs.python.org/issu
New submission from Petr Viktorin :
I'm looking at the _PyType_GetModuleByDef optimization in
https://github.com/python/cpython/pull/25504/files -- previously I assumed it's
OK since it passed review.
But it doesn't look correct:
- in the `_PyType_HasFeature` assert, we should be looking
Petr Viktorin added the comment:
I'd post it to capi-sig, or to the existing thread on python-dev. But here's a
good place too, especially if you want feedback from a smaller group of people
first.
--
___
Python tracker
<https://bugs.python.
Petr Viktorin added the comment:
> can you just assign the task to a field on the exception other than __note__?
That might work, but I'm afraid of touching namespaces I don't own. If the
subclass is feasible, I'd rather
Petr Viktorin added the comment:
Thanks for looking into it!
> If you don't define derive the superclass constructor is used, which means
> you get something of type ExceptionGroup, not your subclass.
That might be fine in my case (for a MVP at least). Is there any other
Petr Viktorin added the comment:
Changing the existing functions is a no-go for backwards compatibility reasons.
I think the best way forward would be to add a new function, and then possibly
deprecate the old one if it's deemed dangerous.
If you want to push this forward, could you
New submission from Petr Viktorin :
I want to test a web application by crawling every reachable page. If an error
occurs, I need to keep track of the page the error occured at (and additional
info like what links were followed to get to the page, so a `__note__` string
isn't enough
Petr Viktorin added the comment:
If we have static types, that means there is a mechanism to share some objects
across interpreters.
And if that's the case, why can't small ints (like
sys.float_info.n_unnamed_fields) be static & shared as well?
--
nosy: +petr.vikt
Petr Viktorin added the comment:
This cannot be changed in 3.x, since the PyObject_DelAttr macro calls
PyObject_SetAttr(..., NULL), and the macro is expanded in all extensions that
use the stable ABI.
(Technically, it would be possible to add a PyObject_SetAttr *macro* that would
warn/fail
Petr Viktorin added the comment:
Another proposed alternative is to make these immortal, and share them.
There were some discussions about this, but no PEP to capture the pros/cons of
the alternatives and the decision.
--
nosy: +petr.viktorin
Petr Viktorin added the comment:
> The problem is that this change fixed another bug, well, see: bpo-44050.
> While a revert should fix win_py399_crash_reproducer.py, it will reintroduce
> bpo-44050 bug.
bpo-44050 is an attempt to fix a regression introduced in bpo-38858
Petr Viktorin added the comment:
Here's a patch, but testing it would require putting a file in the root
directory. I don't dare do that from the test suite. Is one-time manual testing
OK here?
--
___
Python tracker
<https://bugs.python.
Change by Petr Viktorin :
--
keywords: +patch
nosy: +petr.viktorin
nosy_count: 2.0 -> 3.0
pull_requests: +28660
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30456
___
Python tracker
<https://bugs.p
Petr Viktorin added the comment:
> It would perhaps be useful if the os.path.expanduser call was added in the
> cache_from_source() function in importlib?
No: that would mean Python would be doing work that the shell should do.
Possibly it would be duplicating the work. Possibly it
Petr Viktorin added the comment:
> Personally, I'd rather we not revert the original change.
Even in 3.10? Your PR looks pretty heavy for a bugfix release, and won't apply
cleanly to 3.10.
> Moving the data to _PyRuntimeState would save me some effort with related
> work I'm do
Petr Viktorin added the comment:
The docs for PyFrame_GetCode say it's returning an "int".
https://docs.python.org/3/c-api/reflection.html#c.PyFrame_GetCode
Same for PyFrame_GetBack. Are there more?
"Get the frame code." is not very clear. Could this link to
https://doc
Petr Viktorin added the comment:
Nice! It's starting to look reasonable, I'll try an implementation when I get
some focus time. (Sadly I can't promise it'll be this year.)
Just one detail:
> A flag probably can do the same. I have no preference, `ApplySpec` seems
> great to me.
I
Petr Viktorin added the comment:
I don't see how instantiating a metaclass with non-default tp_new would work if
you don't know some details about the specific metaclass. So IMO we can we
limit ourselves to scenarios where either:
1) the metaclass uses default tp_new, or
2) the code
Petr Viktorin added the comment:
That was a fix for GH-17350, which might need to be reverted as well.
Victor, could you take another look at GH-17350? I must admit I (still) don't
understand this change; what would break if it was reverted (along with the
fixup from bpo-44050
Petr Viktorin added the comment:
Interned strings were broken in GH-20058, see bpo-46006. Maybe that's also the
issue here?
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue46
Petr Viktorin added the comment:
I haven't forgotten this issue, but when I get to it it always leads to a
rabbit hole. Sometimes just chasing refleaks, but there are deeper issues as
well.
AFAICS, there's no way to call metatype.tp_new for such a class. I guess the
safest option
Petr Viktorin added the comment:
The current struct is also likely to continue covering most future uses.
If we decide to add PyBufferEx functions but continue providing the current
ones (with the current struct), most users won't be affected. (But it'll be a
bit more work for us than
Petr Viktorin added the comment:
Antoine has a good point. We can freeze the Py_buffer struct. If it needs to be
extended in the future, it'll need a new set of functions and names -- and
perhaps a versioning scheme. We'll know more about the problem when/if it comes
up
Petr Viktorin added the comment:
+1, PyUnicodeObject/PyASCIIObject is excluded from the limited API since Python
3.2, so it wasn't possible to use this macro.
--
___
Python tracker
<https://bugs.python.org/issue46
Petr Viktorin added the comment:
Sadly, the backport is non-trivial. I'm putting on my TODO list, but I doubt
I'll get to it soon :(
--
___
Python tracker
<https://bugs.python.org/issue45
Change by Petr Viktorin :
--
pull_requests: +28180
pull_request: https://github.com/python/cpython/pull/29956
___
Python tracker
<https://bugs.python.org/issue43
Petr Viktorin added the comment:
*docutils, not distutils
--
___
Python tracker
<https://bugs.python.org/issue27580>
___
___
Python-bugs-list mailing list
Unsub
Petr Viktorin added the comment:
The NUL check was around for a long time, available to be used (XKCD-1172
style) as a simple check against reading binary files. The change did break
tests of distutils.
Maybe it deserves a What's New entry?
--
nosy: +petr.viktorin
Petr Viktorin added the comment:
Now, is this a bugfix, or a new feature?
I lean toward calling it a bugfix and backporting to earlier versions.
--
___
Python tracker
<https://bugs.python.org/issue45
Petr Viktorin added the comment:
Yes. This is a minor bug in the deprecated distutils module.
--
resolution: -> wont fix
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Petr Viktorin :
--
resolution: -> fixed
status: -> closed
___
Python tracker
<https://bugs.python.org/issue34451>
___
___
Python-bugs-list
Petr Viktorin added the comment:
> YUV is a common color encoding system. It's used by the JPEG image format and
> MPEG video format for example.
As far as I understand it, the YUV/RGB conversion used by JPEG is not the same
as the one used by MPEG, and neither of those is the Rec 7
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
New changeset 8ed1495ad900dd815ff8fb97926da5312aaa23f9 by Eric Snow in branch
'main':
bpo-45783: Preserve file moves and deletions in the tests for the freeze tool.
(GH-29527)
https://github.com/python/cpython/commit/8ed1495ad900dd815ff8fb97926da5312aaa23f9
Petr Viktorin added the comment:
I think it's a good idea, but without the "will be disallowed in Python 3.13"
part -- we should tell people that it's discouraged, but there's not much point
in removing it.
But there's no consensus whether that's a good way to handle things, in
g
Change by Petr Viktorin :
--
keywords: +patch
nosy: +petr.viktorin
nosy_count: 7.0 -> 8.0
pull_requests: +27958
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/29578
___
Python tracker
<https://bugs.p
Petr Viktorin added the comment:
Wow! Thank you for the quick fix!
--
___
Python tracker
<https://bugs.python.org/issue45848>
___
___
Python-bugs-list mailin
Change by Petr Viktorin :
--
title: Pegen's nice error reporting crashes non-UTF-8 files -> Pegen's nice
error reporting crashes with non-UTF-8 files
___
Python tracker
<https://bugs.python.org/issu
New submission from Petr Viktorin :
Parsing a script with non-UTF-8 encoding and a missing close parenthesis, like
a file with the following 2 lines:
# encoding: ascii
(
... crashes with:
python: Parser/pegen.c:408: get_error_line: Assertion `p->tok->fp == NULL ||
p->tok->
Petr Viktorin added the comment:
I argued for keeping colorsys: RGB/HLS/HSV are useful in several fields.
Colorsys is a nice low-power battery to have around for e.g. picking a color
for highlighting any kind of output.
YIQ is the odd one out: it describes actual color, rather than
1 - 100 of 906 matches
Mail list logo
