[issue706406] fix bug #685846: raw_input defers signals

2010-08-18 Thread Ray.Allen
Ray.Allen added the comment: I seems this has been fixed already, at least on my python 2.7 on linux. -- nosy: +ysj.ray ___ Python tracker <http://bugs.python.org/issue706

[issue1524938] PEP MemoryError with a lot of available memory gc not called

2010-08-18 Thread Ray.Allen
Ray.Allen added the comment: How about calling gc.collect() explicitly in the loop? -- nosy: +ysj.ray ___ Python tracker <http://bugs.python.org/issue1524

[issue7330] PyUnicode_FromFormat segfault

2010-10-05 Thread Ray.Allen
Ray.Allen added the comment: I update the patch. Hope somebody could do a review. -- Added file: http://bugs.python.org/file19131/issue_7330.diff ___ Python tracker <http://bugs.python.org/issue7

[issue7330] PyUnicode_FromFormat segfault

2010-10-05 Thread Ray.Allen
Ray.Allen added the comment: I update the patch. Hope somebody could do a review. -- Added file: http://bugs.python.org/file19132/issue_7330.diff ___ Python tracker <http://bugs.python.org/issue7

[issue7330] PyUnicode_FromFormat segfault

2010-10-05 Thread Ray.Allen
Ray.Allen added the comment: Oooops! Sorry for re-submit the request... -- ___ Python tracker <http://bugs.python.org/issue7330> ___ ___ Python-bugs-list mailin

[issue6269] threading documentation makes no mention of the GIL

2010-10-26 Thread Ray.Allen
Ray.Allen added the comment: Agree with Jesse, the description in the patch is not quite correct. I think detailed description of the GIL has been given in C API documentation: http://docs.python.org/c-api/init.html#thread-state-and-the-global-interpreter-lock. How about just give this link

[issue10228] Refleak run of test_dbm fails when several dbm modules are available

2011-02-22 Thread Ray.Allen
Ray.Allen added the comment: It looks like because before the second time running of WhichDBTestCase.test_whichdb(), previous dumb files are not cleaned clearly, so the gdbm's open() doesn't create a new gdbm database but open an existing dumb database. In fact during the workin

[issue3783] dbm.sqlite proof of concept

2011-02-22 Thread Ray.Allen
Changes by Ray.Allen : -- versions: +Python 3.3 -Python 3.2 ___ Python tracker <http://bugs.python.org/issue3783> ___ ___ Python-bugs-list mailing list Unsub

[issue2159] dbmmodule inquiry function is performance prohibitive

2011-02-22 Thread Ray.Allen
Changes by Ray.Allen : -- nosy: +ysj.ray ___ Python tracker <http://bugs.python.org/issue2159> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue11287] Add context manager support to dbm modules

2011-02-22 Thread Ray.Allen
New submission from Ray.Allen : dbm objects, including gdbm, ndbm, dumb, should support context manager. That is, can be used with 'with' keyword, just like regular file objects. I'm working out a patch for this. -- components: Extension Modules messages: 129076 nosy: y

[issue10516] Add list.clear() and list.copy()

2011-02-23 Thread Ray.Allen
Ray.Allen added the comment: Please modify the patch so that it can be applied to current py3k trunk cleanly. (Notice that Lib/collections.py has been changed to a package in #11085). -- ___ Python tracker <http://bugs.python.org/issue10

[issue11287] Add context manager support to dbm modules

2011-02-24 Thread Ray.Allen
Ray.Allen added the comment: Here is the patch. -- keywords: +patch Added file: http://bugs.python.org/file20882/issue11287.diff ___ Python tracker <http://bugs.python.org/issue11

[issue11287] Add context manager support to dbm modules

2011-02-25 Thread Ray.Allen
Ray.Allen added the comment: Update: change unittest code following eric's comments. -- Added file: http://bugs.python.org/file20902/issue11287.diff ___ Python tracker <http://bugs.python.org/is

[issue11350] __setitem__()'s problem of dbm.dumb object pointed out by comments

2011-02-28 Thread Ray.Allen
New submission from Ray.Allen : By reading the Lib/dbm/dumb.py source, there seems to be an distinct problem which is pointed out in comments: the __setitem__() should call self._commit() in order to keep .dat file and .dir file consist. Here is a piece of comment found at the end of

[issue11350] __setitem__()'s problem of dbm.dumb object pointed out by comments

2011-03-01 Thread Ray.Allen
Ray.Allen added the comment: Here is a test case. First here is a patch which implements a simple builtin function "abort()" that calls exit(0) directly, it simulates the cases that Py_FatalError occurred or segment fault. Then run the following: import dbm.dumb as dumb db =

[issue10829] PyUnicode_FromFormatV() bugs with "%" and "%%" format strings

2011-03-02 Thread Ray.Allen
Ray.Allen added the comment: Hi, haypo, would you mind modify your newly added parse_format_flags() function so that it can diff the precision value of '%.0s' and '%s'(Currently both of them return precision as 0)? Because if used with string formatters(%s, %R, %S, %A,

[issue7330] PyUnicode_FromFormat segfault

2011-03-03 Thread Ray.Allen
Ray.Allen added the comment: Here is the updated patch: 1, Work with function parse_format_flags() which is introduced in issue10829, and the patch is simpler and more clear than before. 2, Change parse_format_flags() to set precision value to -1 in the case of '%s' in order to d

[issue7330] PyUnicode_FromFormat: implement width and precision for %s, %S, %R, %V, %U, %A

2011-03-07 Thread Ray.Allen
Ray.Allen added the comment: I noticed that after apply my last patch and running full unittest cases, some weird errors which I don't know the reasons occurred, for example: AttributeError: 'dict' object has no attribute 'get' and AttributeError: 'Queue

[issue2142] difflib.unified_diff(...) produces invalid patches

2011-03-09 Thread Ray.Allen
Ray.Allen added the comment: Updated patch which can apply to current py3k cleanly and with changes follow eric's review comments. -- Added file: http://bugs.python.org/file21067/issue_2142.diff ___ Python tracker <http://bugs.python.org/i

[issue2142] difflib.unified_diff(...) produces invalid patches

2011-03-12 Thread Ray.Allen
Ray.Allen added the comment: > I re-read the discussion on python-dev, where it was suggested to add a > keyword argument to get the old behavior. Have you considered it? IIUC, at the time of that discusstion, 3.2 is pre-beta so the suitable option is to add "\No newline etc&

[issue1635741] Interpreter seems to leak references after finalization

2011-03-12 Thread Ray.Allen
Ray.Allen added the comment: > Does the title of this issue accurately reflect the current status of the > Python interpreter? Yes, here is the running result on current 3.3 latest code: [37182 refs] [39415 refs] [41607 refs] [43799 refs] [45991 refs] [48183 refs] [50375 refs] This se

[issue2142] difflib.unified_diff(...) produces invalid patches

2011-03-14 Thread Ray.Allen
Ray.Allen added the comment: Yes there may be. Here is the updated patch: Add a new keyword argument to context_diff() and unified_diff() named "warn_no_newline_at_end". If true, emit "\ No newline etc". It defaults to True, set it to false to get the old behavior. I

[issue11580] Add width and precision formatters to PyBytes_FromFormatV()

2011-03-16 Thread Ray.Allen
New submission from Ray.Allen : By working on some PyUnicode_FromFormatV() related issue(#7330, #10829), I found some same problems with PyBytes_FromFormatV(): It doesn't support width formatter for %u, %i, %x, %d, %s, also it doesn't support %lld and %llu. Attached patch fix t

[issue11586] Python/pythonrun.c: get_codec_name() typo

2011-03-17 Thread Ray.Allen
New submission from Ray.Allen : I guess there is a typo in the source of this function: Python/pythonrun.c: get_codec_name() diff -r 48970d754841 Python/pythonrun.c --- a/Python/pythonrun.cThu Mar 17 17:06:27 2011 +0800 +++ b/Python/pythonrun.cThu Mar 17 22:11:15 2011 +0800

[issue11587] METH_KEYWORDS alone gives "METH_OLDARGS is no longer supported!"

2011-03-17 Thread Ray.Allen
Ray.Allen added the comment: Looks like just the problem of error msg. -- nosy: +ysj.ray ___ Python tracker <http://bugs.python.org/issue11587> ___ ___ Python-bug

[issue4492] httplib code thinks it closes connection, but does not

2011-03-17 Thread Ray.Allen
Changes by Ray.Allen : -- nosy: +ysj.ray ___ Python tracker <http://bugs.python.org/issue4492> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue11604] Have type(n,b,d) check for type(b[i]) is module

2011-03-18 Thread Ray.Allen
Ray.Allen added the comment: > I am only suggesting a check for module because the is the only mistake > I > remember anyone reporting. Passing a number as a base class gives a > > > similar message, but no one does that. And as far as I know, there is > no > way in g

[issue11608] GzipFile cannot be used for streaming

2011-03-20 Thread Ray.Allen
Ray.Allen added the comment: Looks like a duplicate issue of #9664 and #914340. And has been fixed in patch of #914340. -- nosy: +ysj.ray ___ Python tracker <http://bugs.python.org/issue11

[issue4492] httplib code thinks it closes connection, but does not

2011-03-20 Thread Ray.Allen
Ray.Allen added the comment: Another fix could be making HTTPResponse to hold a reference to the HTTPConnection object and call its close() at the time of a bad chunk length was received. This can close the connection as soon as possible

[issue9302] distutils API Reference: setup() and Extension parameters' description not correct.

2011-03-21 Thread Ray.Allen
Ray.Allen added the comment: I searched the distutils docs for such a parameter description table and find tow more on the distutils.core.setup() function descriptions. Reflected in my updated patch. -- title: distutils.core.Extension: list parameters documented as strings

[issue9523] Improve dbm modules

2011-03-21 Thread Ray.Allen
Ray.Allen added the comment: > I think the patch will not be suitable for 3.1 and 3.2 Yes, it changes some api(e.g keys()), which may introduces compatibility issues. > so there should be a doc patch to mention the limitations of the dbm API > (keys() > returning a list and al

[issue7330] PyUnicode_FromFormat: implement width and precision for %s, %S, %R, %V, %U, %A

2011-03-21 Thread Ray.Allen
Changes by Ray.Allen : Removed file: http://bugs.python.org/file21032/issue7330_3.diff ___ Python tracker <http://bugs.python.org/issue7330> ___ ___ Python-bugs-list m

[issue7330] PyUnicode_FromFormat: implement width and precision for %s, %S, %R, %V, %U, %A

2011-03-21 Thread Ray.Allen
Ray.Allen added the comment: Ooops! I found my last submitted patch is a wrong one. Here is the updated patch add doc entries about the changes. The test cases which assert error messages generated by PyUnicode_FromFormat() with "%.200s" formatters equality would failed due to

[issue11287] Add context manager support to dbm modules

2011-03-22 Thread Ray.Allen
Ray.Allen added the comment: patch updated. -- Added file: http://bugs.python.org/file21337/issue_11287.diff ___ Python tracker <http://bugs.python.org/issue11

[issue9523] Improve dbm modules

2011-03-23 Thread Ray.Allen
Ray.Allen added the comment: Updated patch: 1, Changes follows review comments: http://codereview.appspot.com/4185044/. Thanks eric! 2, Make Objects/dictobject.c:all_contained_in() a common useful limited api Object/abstract.c:_PyObject_AllContainedIn() for the purpose of re-usage in

[issue7330] PyUnicode_FromFormat: implement width and precision for %s, %S, %R, %V, %U, %A

2011-03-24 Thread Ray.Allen
Ray.Allen added the comment: By the way, as my simple tests, wprintf() with "%ls" does apply the width and precision formatters on units of characters. -- ___ Python tracker <http://bugs.python.

[issue7330] PyUnicode_FromFormat: implement width and precision for %s, %S, %R, %V, %U, %A

2011-03-24 Thread Ray.Allen
Ray.Allen added the comment: Sorry for having done that! I will remove old patches and leave a cleaner view. -- ___ Python tracker <http://bugs.python.org/issue7

[issue7330] PyUnicode_FromFormat: implement width and precision for %s, %S, %R, %V, %U, %A

2011-03-24 Thread Ray.Allen
Changes by Ray.Allen : Removed file: http://bugs.python.org/file20739/issue_7330.diff ___ Python tracker <http://bugs.python.org/issue7330> ___ ___ Python-bugs-list mailin

[issue7330] PyUnicode_FromFormat: implement width and precision for %s, %S, %R, %V, %U, %A

2011-03-24 Thread Ray.Allen
Changes by Ray.Allen : Removed file: http://bugs.python.org/file20786/issue_7330.diff ___ Python tracker <http://bugs.python.org/issue7330> ___ ___ Python-bugs-list mailin

[issue7330] PyUnicode_FromFormat: implement width and precision for %s, %S, %R, %V, %U, %A

2011-03-24 Thread Ray.Allen
Changes by Ray.Allen : Removed file: http://bugs.python.org/file20983/issue7330_2.diff ___ Python tracker <http://bugs.python.org/issue7330> ___ ___ Python-bugs-list m

[issue9523] Improve dbm modules

2011-03-24 Thread Ray.Allen
Ray.Allen added the comment: I tried to work out a doc patch for 3.2 to mention the limitation api: the missing methods compared with dict and the imperfect methods(keys(), items()) of collections.MutableMapping. Here is it. -- Added file: http://bugs.python.org/file21369

[issue11655] map() must not swallow exceptions from PyObject_GetIter

2011-03-24 Thread Ray.Allen
Ray.Allen added the comment: There maybe compatibility issues which prevent such behavior change. -- nosy: +ysj.ray ___ Python tracker <http://bugs.python.org/issue11

[issue11654] errors in atexit hooks don't change process exit code

2011-03-25 Thread Ray.Allen
Ray.Allen added the comment: Comparing to the atexit() in C, I think this is the wrong behavior. I's weird that error in atexit does't change process exit code while error in common python code does. There should be a fix. -- nosy

[issue11647] function decorated with a context manager can only be invoked once

2011-03-25 Thread Ray.Allen
Ray.Allen added the comment: Agreed with nick's idea, the implicitly recreation of the context managers would confuse users. How about removing the "generator must yield exactly one value" restriction of @contextlib.contextmanage? Then if I want a generator to be used as a

[issue11654] errors in atexit hooks don't change process exit code

2011-03-25 Thread Ray.Allen
Ray.Allen added the comment: A straight forward fix maybe making the interpreter exit code a static global variable and change it in Modules/atexitmodule.c:atexit_callfuncs() in the case of errors occurred. -- ___ Python tracker <h

[issue11647] function decorated with a context manager can only be invoked once

2011-03-25 Thread Ray.Allen
Ray.Allen added the comment: > > Agreed with nick's idea, the implicitly recreation of the context > > managers would confuse users. > Uh, why would it? That's exactly what I expect the decorator to do, and > I was astonished to discover that it *doesn't*. B

[issue8690] multiprocessing.dummy.Queue does not expose same interface as multiprocessing.Queue

2010-11-19 Thread Ray.Allen
Ray.Allen added the comment: +1 on make it identical to multiprossing.Queue. Since the documentation said: multiprocessing.dummy replicates the API of multiprocessing but is no more than a wrapper around the threading module. Does the word "replicates" implies that multipros

[issue10037] multiprocessing.pool processes started by worker handler stops working

2010-11-23 Thread Ray.Allen
Ray.Allen added the comment: Could you give an example code which can reproduce this issue? -- nosy: +ysj.ray ___ Python tracker <http://bugs.python.org/issue10

[issue7238] frame.f_lineno doesn't get updated after local trace function assigned to it

2010-11-24 Thread Ray.Allen
Ray.Allen added the comment: It's not a bug. What happens is like this: 1, You set trace function using sys.settrace(tracer). 2, When the following func() is called, tracer is called with a "call" event, so the trace function in PyThreadState is set to NULL since "sy

[issue8481] doc: ctypes no need to explicitly allocate writable memory with Structure

2010-11-24 Thread Ray.Allen
Ray.Allen added the comment: I think not only Structures but also other ctypes can be passed with byref() to functions expecting pointer to mutable memory. -- nosy: +ysj.ray ___ Python tracker <http://bugs.python.org/issue8

[issue9014] Incorrect documentation of the PyObject_HEAD macro

2010-11-24 Thread Ray.Allen
Ray.Allen added the comment: Additionally, I prefer move the discussion of Py_TRACE_REFS under the documentation of PyObject: http://docs.python.org/dev/py3k/c-api/structures.html?highlight=pyobject_head#PyObject, since they'are connected directly. The doc of PyObject_HEAD should only s

[issue9299] os.makedirs(): Add a keyword argument to suppress "File exists" exception

2010-11-28 Thread Ray.Allen
Ray.Allen added the comment: Thanks for Terry's addition to the patch! On my python3.2a3 on windows(also copied os.py and test_os.py to the installation), I only get the tow "os.link" errors. And this is because the python3.2a3 hasn't the "os.link" funct

[issue9299] os.makedirs(): Add a keyword argument to suppress "File exists" exception

2010-12-02 Thread Ray.Allen
Ray.Allen added the comment: Oh, yes, I missed that, too. I didn't pay attention to that. Thanks for pointing out it and fix it! -- ___ Python tracker <http://bugs.python.org/i

[issue9523] Improve dbm modules

2010-12-07 Thread Ray.Allen
Ray.Allen added the comment: Oh, yes. I noticed that the pep3119 defines return value of method MutableMapping.keys() as Set, as well as method items(). So the implementation of dumb.keys() and dump.items() are not correct since they all return lists while the class inherits MutableMapping

[issue10517] test_concurrent_futures crashes with "Fatal Python error: Invalid thread state for this thread"

2010-12-08 Thread Ray.Allen
Ray.Allen added the comment: Couldn't repro this on my debian 5. -- nosy: +ysj.ray ___ Python tracker <http://bugs.python.org/issue10517> ___ ___ Pytho

[issue9523] Improve dbm modules

2010-12-09 Thread Ray.Allen
Ray.Allen added the comment: Here is the updated patch, which fixed: 1. remove get() method of gdbm since issue6045 has already add it. 2. method keys() and items() of dbm object return set instead of list. Since pep3119 said keys() and items() should return collections.Set and set is a

[issue10516] Add list.clear() and list.copy()

2010-12-09 Thread Ray.Allen
Ray.Allen added the comment: eli, you should also add "New in version 3.3" to the doc of the tow new list methods. -- nosy: +ysj.ray ___ Python tracker <http://bugs.python.o

[issue10611] sys.exit() in a test causes a test run to die

2010-12-09 Thread Ray.Allen
Ray.Allen added the comment: Agreed. I think the "except Exception" in TestCase.run() should be "except BaseException", since BaseException could catch Exception, SystemExit, GeneratorExit, KeyboardInterrupt. The KeyboardInterrupt should be caught first. The remaining t

[issue10516] Add list.clear() and list.copy()

2010-12-10 Thread Ray.Allen
Ray.Allen added the comment: > That's good if it's so... can you explain why list_clear doesn't > guarantee that the list is empty? Why would XDECREF populate the list? > I don't quite understand it. Does this mean that durning the Py_DECREF progress the list

[issue10611] sys.exit() in a test causes a test run to die

2010-12-15 Thread Ray.Allen
Ray.Allen added the comment: > I'd like to fix all these issues by moving the exception handling into a > single method and unifying the reporting of failure / error / expected > failure / skip test. This will fix all these issues and nicely simplify the > implementation.

[issue9523] Improve dbm modules

2011-02-10 Thread Ray.Allen
Ray.Allen added the comment: Thanks eric for reviewing my patch! And thanks for you suggestions. I'm following them. > I don’t know if you should use a plain set or a collections.ItemsView here. > In dict objects, KeysView and ValuesView are set-like objects with added >

[issue7330] PyUnicode_FromFormat segfault

2011-02-10 Thread Ray.Allen
Changes by Ray.Allen : Removed file: http://bugs.python.org/file19131/issue_7330.diff ___ Python tracker <http://bugs.python.org/issue7330> ___ ___ Python-bugs-list mailin

[issue7330] PyUnicode_FromFormat segfault

2011-02-10 Thread Ray.Allen
Ray.Allen added the comment: Thanks haypo! Here is the updated patch, it add the tests about width modifiers and precision modifiers of %S, %R, %A. Besides I don't know how to add tests of %s, since when calling through ctypes, I could not get correct result value as python object

[issue7330] PyUnicode_FromFormat segfault

2011-02-10 Thread Ray.Allen
Ray.Allen added the comment: Here's the complete patch, added unittest for width modifier and precision modifier for '%s' formatter of PyUnicode_FromFormat() function. -- Added file: http://bugs.python.org/file20739/issue_7330.diff ___

[issue9523] Improve dbm modules

2011-02-12 Thread Ray.Allen
Ray.Allen added the comment: > > 1. Make keys(), values(), items() methods return view object for ndbm, gdbm > > and dumb objects. I following the codes in dictobject.c. > Did you have to copy the code? Isn’t it possible to somehow reuse it? I feel not so easy to reuse the co

[issue9523] Improve dbm modules

2011-02-12 Thread Ray.Allen
Changes by Ray.Allen : Added file: http://bugs.python.org/file20751/issue_9523.diff ___ Python tracker <http://bugs.python.org/issue9523> ___ ___ Python-bugs-list mailin

[issue7330] PyUnicode_FromFormat segfault

2011-02-13 Thread Ray.Allen
Changes by Ray.Allen : Removed file: http://bugs.python.org/file18305/issue_7330.diff ___ Python tracker <http://bugs.python.org/issue7330> ___ ___ Python-bugs-list mailin

[issue7330] PyUnicode_FromFormat segfault

2011-02-13 Thread Ray.Allen
Changes by Ray.Allen : Removed file: http://bugs.python.org/file19132/issue_7330.diff ___ Python tracker <http://bugs.python.org/issue7330> ___ ___ Python-bugs-list mailin

[issue7330] PyUnicode_FromFormat segfault

2011-02-13 Thread Ray.Allen
Changes by Ray.Allen : Removed file: http://bugs.python.org/file20731/issue_7330.diff ___ Python tracker <http://bugs.python.org/issue7330> ___ ___ Python-bugs-list mailin

[issue9523] Improve dbm modules

2011-02-13 Thread Ray.Allen
Changes by Ray.Allen : Removed file: http://bugs.python.org/file18402/issue8634.diff ___ Python tracker <http://bugs.python.org/issue9523> ___ ___ Python-bugs-list mailin

[issue9523] Improve dbm modules

2011-02-13 Thread Ray.Allen
Changes by Ray.Allen : Removed file: http://bugs.python.org/file19987/issue_9523.diff ___ Python tracker <http://bugs.python.org/issue9523> ___ ___ Python-bugs-list mailin

[issue9523] Improve dbm modules

2011-02-13 Thread Ray.Allen
Changes by Ray.Allen : Removed file: http://bugs.python.org/file20726/issue_9523.diff ___ Python tracker <http://bugs.python.org/issue9523> ___ ___ Python-bugs-list mailin

[issue1635741] Interpreter seems to leak references after finalization

2011-02-13 Thread Ray.Allen
Changes by Ray.Allen : -- nosy: +ysj.ray ___ Python tracker <http://bugs.python.org/issue1635741> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue3710] Reference leak in thread._local

2011-02-13 Thread Ray.Allen
Changes by Ray.Allen : -- nosy: +ysj.ray ___ Python tracker <http://bugs.python.org/issue3710> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue9523] Improve dbm modules

2011-02-16 Thread Ray.Allen
Ray.Allen added the comment: Thanks! Here is my updated patch: 1, Now the dbm view objects are the same as dict view objects, which are in conformity with collections.KeysView, ValuesView and ItemsView. 2, I register all these abcs explicitly because these abcs have not __subclasshook__

[issue9523] Improve dbm modules

2011-02-16 Thread Ray.Allen
Changes by Ray.Allen : Removed file: http://bugs.python.org/file20751/issue_9523.diff ___ Python tracker <http://bugs.python.org/issue9523> ___ ___ Python-bugs-list mailin

[issue7330] PyUnicode_FromFormat segfault

2011-02-17 Thread Ray.Allen
Ray.Allen added the comment: Thanks hyapo! > It looks like your patch fixes #10829: you should add tests for that, you can > just reuse the tests of my patch (attached to #10829). Sorry, but I think my patch doesn't fix #10829. It seems link another issue. And by applying my pa

[issue7330] PyUnicode_FromFormat segfault

2011-02-17 Thread Ray.Allen
Ray.Allen added the comment: > Do you mean combine step 3 and step 4 together? Currently step 3 is just to > compute the biggest width value and step 4 is to compute exact width and do > the real format work. Only by doing real format we can get the exact width of > a string.

[issue9523] Improve dbm modules

2011-02-18 Thread Ray.Allen
Ray.Allen added the comment: An updated patch, based on latest several reviews on http://codereview.appspot.com/4185044/ update: 1, Refactoring the common tests between test_dbm_gnu and test_dbm_ndbm. 2, Move the abc registering in Lib/dbm/ndbm.py and Lib/dbm/gnu.py. 3, Other changes pointed

[issue9523] Improve dbm modules

2011-02-18 Thread Ray.Allen
Changes by Ray.Allen : Removed file: http://bugs.python.org/file20771/issue_9523.diff ___ Python tracker <http://bugs.python.org/issue9523> ___ ___ Python-bugs-list mailin

[issue7330] PyUnicode_FromFormat segfault

2011-02-18 Thread Ray.Allen
Ray.Allen added the comment: > No you don't. You can copy a substring of the input string with Py_UNICODE_COPY: just pass a smaller length. Oh, yes, I got your meaning now. I'll follow this. > You can truncate the input char* on the call to PyUnicode_DecodeUTF8: Oh, what if

[issue7330] PyUnicode_FromFormat segfault

2011-02-18 Thread Ray.Allen
Ray.Allen added the comment: > Can you add tests for "%.s"? I would like to know if "%.s" is different than > "%s" :-) Oh sorry~~ I made an mistake. There is no bug here. I have attached tests that show that '%.s' is the same as '%s

[issue7330] PyUnicode_FromFormat segfault

2011-02-20 Thread Ray.Allen
Ray.Allen added the comment: > > > With your patch, "%.200s" truncates the input string to 200 *characters*, > > > but I think that it should truncate to 200 *bytes*, as printf does. > > > > Sorry, I don't understand. The result of PyUnicode_FromFo

[issue7330] PyUnicode_FromFormat segfault

2011-02-20 Thread Ray.Allen
Changes by Ray.Allen : Removed file: http://bugs.python.org/file20739/issue_7330.diff ___ Python tracker <http://bugs.python.org/issue7330> ___ ___ Python-bugs-list mailin

[issue11246] PyUnicode_FromFormat("%V") decodes the byte string from ISO-8859-1

2011-02-20 Thread Ray.Allen
Ray.Allen added the comment: Yes. The %V should be combination of %U and %s. Here is a patch which fixed this problem. -- ___ Python tracker <http://bugs.python.org/issue11

[issue11246] PyUnicode_FromFormat("%V") decodes the byte string from ISO-8859-1

2011-02-20 Thread Ray.Allen
Changes by Ray.Allen : -- keywords: +patch Added file: http://bugs.python.org/file20818/issue11246.diff ___ Python tracker <http://bugs.python.org/issue11

[issue10829] PyUnicode_FromFormatV() bugs with "%" and "%%" format strings

2011-02-21 Thread Ray.Allen
Ray.Allen added the comment: Hi, haypo, Your patch seems cannot be applied cleanly on current py3k trunk. And after modified your patch, test_unicode.py runs into Segmentation fault. Is there something wrong or some changes which could influence this bug had been already made since the patch

[issue10829] PyUnicode_FromFormatV() bugs with "%" and "%%" format strings

2011-02-21 Thread Ray.Allen
Changes by Ray.Allen : -- type: -> behavior ___ Python tracker <http://bugs.python.org/issue10829> ___ ___ Python-bugs-list mailing list Unsubscri

[issue10833] Replace %.100s by %s in PyErr_Format(): the arbitrary limit of 500 bytes is outdated

2011-02-21 Thread Ray.Allen
Ray.Allen added the comment: see also #7330, I'm implementing "%.100s" in that issue. -- nosy: +ysj.ray ___ Python tracker <http://bugs.pyt

[issue11246] PyUnicode_FromFormat("%V") decodes the byte string from ISO-8859-1

2011-02-21 Thread Ray.Allen
Ray.Allen added the comment: Thanks haypo! Here the updated patch, following your comments. -- type: -> behavior Added file: http://bugs.python.org/file20831/issue11246.diff ___ Python tracker <http://bugs.python.org/issu

[issue11246] PyUnicode_FromFormat("%V") decodes the byte string from ISO-8859-1

2011-02-21 Thread Ray.Allen
Changes by Ray.Allen : Removed file: http://bugs.python.org/file20818/issue11246.diff ___ Python tracker <http://bugs.python.org/issue11246> ___ ___ Python-bugs-list m

[issue11282] unittest document not keep consist with code

2011-02-21 Thread Ray.Allen
New submission from Ray.Allen : r88451: Remove unittest methods scheduled for removal in 3.3 This commit remove assertSameElements() and assertDictContainsSubset(). But shouldn't some modification be done in the unittest library documentation? I wonder if we should remove the docs abou

[issue9523] Improve dbm modules

2011-02-21 Thread Ray.Allen
Ray.Allen added the comment: Sine r88451 removed unittest's assertSameElements() method, I need to updated my patch to fit it. So here it is. -- Added file: http://bugs.python.org/file20832/issue9523.diff ___ Python tracker <http://bugs.py

[issue9523] Improve dbm modules

2011-02-21 Thread Ray.Allen
Changes by Ray.Allen : Removed file: http://bugs.python.org/file20783/issue_9523.diff ___ Python tracker <http://bugs.python.org/issue9523> ___ ___ Python-bugs-list mailin

[issue10829] PyUnicode_FromFormatV() bugs with "%" and "%%" format strings

2011-02-21 Thread Ray.Allen
Ray.Allen added the comment: > Well, the main problem is that there are 3 different codes to parse the > format string, and each code is different... Attached patch factorizes the > code: create one subfunction parse_format_flags(). It fixes also this issue > and prepares the

[issue8297] AttributeError message text should include module name

2010-04-03 Thread Ray.Allen
Ray.Allen added the comment: Yes, I agree with this feature request. And also the super(Class, obj) call should return a reasonable AttributeError message when the requested attribute is not found in one of Class's base classes, not just 'super' object has no

[issue8297] AttributeError message text should include module name

2010-04-03 Thread Ray.Allen
Ray.Allen added the comment: In fact, there are only three types of tp_getattro functions: 1.For type objects, it is type_getattro(), in case of AttributeError, this function give the message format: type object %(type)s has no attribute %(attr)s 2.For super objects, it is

[issue8297] AttributeError message text should include module name

2010-04-06 Thread Ray.Allen
Ray.Allen added the comment: This patch makes the AttributeError message generated from getting attributes from module object more helpful, that is, print the module name. Now the error message is: module object 'mod_name' has no attribute 'xxx' Instead of: &#

[issue8292] Incorrect condition test in platform.py

2010-04-07 Thread Ray.Allen
Ray.Allen added the comment: It seems that the "Lib/lib2to3/fixes/fix_filter.py" should have fixed all the "filter" problem in py3k, by adding a "list()" call to "filter()". It's werid this one still exists in standar library. Also I found other

[issue8336] PyObject_CallObject - Not "reference-count-neutral"

2010-04-08 Thread Ray.Allen
Ray.Allen added the comment: By looking into the source, I found PyObject_CallObject() is “reference-count-neutral” even the call is FAILED, because it will always call Py_DECREF(arg) in the end and in case of exception. -- nosy: +ysj.ray

  1   2   >