Changes by Richard Hansen rhan...@bbn.com:
Removed file:
http://bugs.python.org/file15729/unicode_escape_single_and_double_quotes.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7615
Changes by Richard Hansen rhan...@bbn.com:
Removed file: http://bugs.python.org/file15771/unicode_escape_reorg.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7615
Changes by Richard Hansen rhan...@bbn.com:
Removed file: http://bugs.python.org/file15774/unicode_escape_tests.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7615
Changes by Richard Hansen rhan...@bbn.com:
Removed file: http://bugs.python.org/file15775/raw_unicode_escape_tests.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7615
Richard Hansen rhan...@bbn.com added the comment:
Attaching updated unit tests. The tests now check to make sure that single and
double quotes are escaped.
--
Added file: http://bugs.python.org/file15809/unicode_escape_tests.patch
___
Python
Richard Hansen rhan...@bbn.com added the comment:
Attaching a minimal patch:
* unicode_escape now backslash-escapes single and double quotes
* raw_unicode_escape now unicode-escapes single and double quotes
* raw_unicode_escape now unicode-escapes backslashes
* removes pickle's escaping
Richard Hansen rhan...@bbn.com added the comment:
Attaching a patch for an issue discovered while looking at the code:
* The UTF-16 decode logic in the Unicode escape encoders no longer reads past
the end of the provided Py_UNICODE buffer if the last character's value is
between 0xD800
Richard Hansen rhan...@bbn.com added the comment:
Attaching a patch for another issue discovered while looking at the code:
* The Unicode escape encoders now check to make sure that the provided size
is nonnegative.
* C API documentation updated to make it clear that size must
Richard Hansen rhan...@bbn.com added the comment:
Attaching a patch that eliminates duplicate code:
* Merge unicodeescape_string(), PyUnicode_EncodeRawUnicodeEscape(), and
modified_EncodeRawUnicodeEscape() into one function called
_PyUnicode_EncodeCustomUnicodeEscape().
This patch is meant
Richard Hansen rhan...@bbn.com added the comment:
Any comments on the patches? I'd love to see at least patches 1-3 make it into
Python 2.7. :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7615
New submission from Richard Hansen rhan...@bbn.com:
The description of the unicode_escape codec says that it produces a
string that is suitable as Unicode literal in Python source code. [1]
Unfortunately, this is not true as it does not escape quotes. For example:
print u'a\'bc\'\'\'de
Richard Hansen rhan...@bbn.com added the comment:
If we change this, the encoder should quote both single and double
quotes - simply because it is not known whether the literal
will use single or double quotes.
Or document that single quotes are always escaped so that the user knows he/she
Richard Hansen rhan...@bbn.com added the comment:
I thought about raw_unicode_escape more, and there's a way to escape quotes:
use unicode escape sequences (e.g., ur'\u0027'). I've attached a new patch
that does the following:
* backslash-escapes single quotes when encoding
Richard Hansen rhan...@bbn.com added the comment:
Attached is a patch to the unicode unit tests. It adds tests for the following:
* unicode_escape escapes single quotes
* raw_unicode_escape escapes single quotes
* raw_unicode_escape escapes backslashes
--
Added file: http
Changes by Richard Hansen rhan...@bbn.com:
Removed file: http://bugs.python.org/file15742/unicode_escape_reorg.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7615
Richard Hansen rhan...@bbn.com added the comment:
Attaching updated unicode_escape_reorg.patch. This fixes two additional issues:
* don't call _PyString_Resize() on an empty string because there is only one
empty string instance, and that instance is returned when creating an empty
string
Changes by Richard Hansen rhan...@bbn.com:
Removed file: http://bugs.python.org/file15748/unicode_escape_reorg.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7615
Richard Hansen rhan...@bbn.com added the comment:
Attaching updated unicode_escape_reorg.patch. This addresses two additional
issues:
* removes pickle's workaround of raw-unicode-escape's broken escaping
* eliminates duplicated code (the raw escape encode function was copied with
only
Richard Hansen rhan...@bbn.com added the comment:
I believe this issue is ready to be bumped to the patch review stage.
Thoughts?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7615
Richard Hansen rhan...@bbn.com added the comment:
Does the last patch obsolete the first two? If so please delete the
obsolete ones.
Yes and no -- it depends on what the core Python developers want and are
comfortable with:
* unicode_escape_single_quotes.patch: Only escapes single
Changes by Richard Hansen rhan...@bbn.com:
Removed file: http://bugs.python.org/file15746/unicode_escape_tests.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7615
Richard Hansen rhan...@bbn.com added the comment:
Attaching updated unit tests for the unicode_escape codec. I removed the
raw_unicode_escape tests and will attach a separate patch for those.
--
Added file: http://bugs.python.org/file15774/unicode_escape_tests.patch
Richard Hansen rhan...@bbn.com added the comment:
Attaching updated unit tests for the raw_unicode_escape codec.
--
Added file: http://bugs.python.org/file15775/raw_unicode_escape_tests.patch
___
Python tracker rep...@bugs.python.org
http
Richard Hansen rhan...@bbn.com added the comment:
We'll need a patch that implements single and double quote escaping
for unicode_escape and a \u style escaping of quotes for the
raw_unicode_escape encoder.
OK, I'll remove unicode_escape_single_quotes.patch and update
Changes by Richard Hansen rhan...@bbn.com:
Removed file:
http://bugs.python.org/file15716/unicode_escape_single_quotes.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7615
Richard Hansen added the comment:
People might rely on the fact that contiguous implies suboffsets==NULL.
Cython (currently) relies on all-negatives being acceptable and equivalent to
suboffsets==NULL. See:
https://github.com/cython/cython/pull/367
http://thread.gmane.org
Richard Hansen added the comment:
(The following message is mostly off-topic but I think it is relevant to those
interested in this issue. This message is about the clarity of the
documentation regarding flag semantics, and what I think the flags should mean.)
Cython doesn't follow the spec
Richard Hansen added the comment:
Attached is a documentation patch that adds what I said in msg235141. I doubt
everyone will agree with the changes, but maybe it will be a useful starting
point.
(Despite not having an asterisk next to my username, I have signed the
contributor agreement
Changes by Richard Hansen rhan...@bbn.com:
Added file: http://bugs.python.org/file37954/doc_c-api_buffer.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23352
Changes by Richard Hansen rhan...@bbn.com:
Removed file: http://bugs.python.org/file37952/doc_c-api_buffer.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23352
Changes by Richard Hansen rhan...@bbn.com:
Added file: http://bugs.python.org/file37953/doc_c-api_buffer.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23352
Changes by Richard Hansen rhan...@bbn.com:
Removed file: http://bugs.python.org/file37953/doc_c-api_buffer.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23352
Richard Hansen added the comment:
When I compile and run the above (latest Cython from Git master), I
get:
()
()
With Cython version 0.20.1post0 I get:
foo.foo()
(-1,)
(-1,)
If you get the correct output from the latest Cython, it looks like
this issue has been fixed
Richard Hansen added the comment:
How might an application break with this change?
assert(view-suboffsets == NULL);
Fair point.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23352
Richard Hansen added the comment:
This leaves me +-0 for the change, with the caveat that applications
might break.
How might an application break with this change? Compared to the current
PyBuffer_IsContiguous(), the patched version is the same except it returns true
for a wider range
Richard Hansen added the comment:
My preference is to apply the patch, of course. There is a legitimate concern
that it will break existing code, but I think there are more points in favor of
applying the patch:
* there exists code that the current behavior is known to break
* it's easier
Changes by Richard Hansen rhan...@bbn.com:
--
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23352
___
___
Python-bugs-list
Richard Hansen added the comment:
The patch has an obvious syntax error :-)
Doh!
Other than that, adding a comment would be nice.
Agreed, will do.
Bonus points if you can write a test (3.x has infrastructure for that, see
Lib/test/test_buffer.py).
I'll take a look. Thanks
New submission from Richard Hansen:
According to
https://docs.python.org/2/c-api/buffer.html#the-new-style-py-buffer-struct if
the suboffsets member of Py_buffer is non-NULL and all members of the array are
negative, the buffer may be contiguous.
PyBuffer_IsContiguous() does not behave
New submission from Richard Hansen:
PyBuffer_ToContiguous() has an off-by-one error when copying a buffer it thinks
is non-contiguous.
To reproduce, put the following in foo.pyx and compile with Cython v0.21.2:
cpdef foo():
cdef unsigned char[:] v = bytearray(testing
Changes by Richard Hansen rhan...@bbn.com:
--
title: memoryview.to_bytes() and PyBuffer_ToContiguous() off-by-one error for
non-contiguous buffers - PyBuffer_ToContiguous() off-by-one error for
non-contiguous buffers
___
Python tracker rep
Changes by Richard Hansen rhan...@bbn.com:
--
versions: -Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23352
Changes by Richard Hansen rhan...@bbn.com:
--
versions: +Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23352
___
___
Python
Richard Hansen added the comment:
I've attached a new version of the patch. Suggestions for simplifying the test
code would be appreciated.
--
Added file: http://bugs.python.org/file37916/PyBuffer_IsContiguous_v2.patch
___
Python tracker rep
44 matches
Mail list logo
