[issue44096] Bad clang detection in configure script

2021-05-09 Thread Rishav Kundu
New submission from Rishav Kundu : Because autoconf detects `cc` before `clang` [1], this means that most of the checks in configure.ac that compare $CC to `clang` don’t work. This in turn means that things like LTO and PGO don’t work — the appropriate compiler options do not get set. I can

[issue44093] compiler detection on macOS seems to be incorrect

2021-05-09 Thread Rishav Kundu
New submission from Rishav Kundu : On macOS devices, the configure script seems to always detect gcc, even though Apple does not ship with gcc — the gcc binary is simply a wrapper around clang (probably llvm-gcc?) I believe the issue is with these lines. https://github.com/python/cpython

[issue43109] When using Apple Clang, --with-lto builds should not check for llvm-ar

2021-05-08 Thread Rishav Kundu
Change by Rishav Kundu : -- keywords: +patch nosy: +xrisk nosy_count: 2.0 -> 3.0 pull_requests: +24652 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25999 ___ Python tracker <https://bugs.python.org/i

[issue41303] perf_counter result does not count system sleep time in Mac OS

2020-08-06 Thread Rishav Kundu
Rishav Kundu added the comment: > perf_counter behavior during system suspend is undefined Does the same apply for time.monotonic? I would argue that the difference in behavior between Linux/macOS and Windows is unreasonable; given that time.monotonic exists for measuring time interv

[issue41303] perf_counter result does not count system sleep time in Mac OS

2020-08-06 Thread Rishav Kundu
Rishav Kundu added the comment: [1]: https://docs.python.org/3.8/library/time.html#time.clock_gettime [2]: https://developer.apple.com/documentation/kernel/1646199-mach_continuous_time effectively uses CLOCK_MONOTONIC_RAW on macOS. -- ___ Python

[issue41303] perf_counter result does not count system sleep time in Mac OS

2020-08-06 Thread Rishav Kundu
Rishav Kundu added the comment: While I agree that the behavior of perf_counter should be consistent across macOS/Linux and Windows wrt system suspend, you can already access those clocks by using time.clock_gettime [1] with appropriate clock IDs (CLOCK_MONOTONIC_RAW on macOS

[issue41303] perf_counter result does not count system sleep time in Mac OS

2020-08-04 Thread Rishav Kundu
Rishav Kundu added the comment: > Maybe a new clock is needed, clock which has a well defined behavior for > system suspend, on any platform. I’d like to work on this, if possible. Linux and macOS support seems to be straightforward. I will have to look into other platforms. What

[issue41303] perf_counter result does not count system sleep time in Mac OS

2020-08-04 Thread Rishav Kundu
Rishav Kundu added the comment: Wouldn’t using mach_continuous_time (and its equivalents on other platforms) wherever possible be preferable? Or would a different API that distinguishes between clocks that track during suspend versus those that not be a better idea? Given that at least macOS

[issue41303] perf_counter result does not count system sleep time in Mac OS

2020-08-03 Thread Rishav Kundu
Change by Rishav Kundu : -- keywords: +patch nosy: +xrisk nosy_count: 6.0 -> 7.0 pull_requests: +20862 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21719 ___ Python tracker <https://bugs.python.org/i

[issue41410] Opening a file in binary mode makes a difference on all platforms in Python 3

2020-08-02 Thread Rishav Kundu
Rishav Kundu added the comment: Submitted a PR. Please let me know if I missed something :) -- ___ Python tracker <https://bugs.python.org/issue41410> ___ ___

[issue41410] Opening a file in binary mode makes a difference on all platforms in Python 3

2020-08-02 Thread Rishav Kundu
Change by Rishav Kundu : -- keywords: +patch nosy: +xrisk nosy_count: 3.0 -> 4.0 pull_requests: +20844 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21701 ___ Python tracker <https://bugs.python.org/i