Robin Schreiber added the comment:
I have updated the patch to work again with the current version of the
_datetimemodule.
Regarding the suggestion of separating PEP3121 and PEP384. It might be true
that datetime and other modules do not benefit directly from PEP 384, however
it is still
Robin Schreiber added the comment:
Patch updated to work with current 3.4 Branch version of elementtree.
--
keywords: +patch
Added file: http://bugs.python.org/file28311/_elementtree_pep3121-384_v1.patch
___
Python tracker rep...@bugs.python.org
http
Robin Schreiber added the comment:
Updated patch to work with 3.4 Branch version of _struct.c
--
keywords: +patch
Added file: http://bugs.python.org/file28315/_struct_pep3121-384_v1.patch
___
Python tracker rep...@bugs.python.org
http
Robin Schreiber added the comment:
Updated parsermodule patch to work with 3.4 Branch version.
--
keywords: +patch
Added file: http://bugs.python.org/file28316/parser_pep3121-384_v1.patch
___
Python tracker rep...@bugs.python.org
http
Robin Schreiber added the comment:
Updated posixmodule to work with the 3.4 Branch version.
--
keywords: +patch
Added file: http://bugs.python.org/file28317/posix_pep3121-384_v1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
New submission from Robin Schreiber robin.schrei...@me.com:
Corresponding to my previous Issue #14732 I have now applied the Heap-Type
Refactoring from PEP 341 to the _csv module. As I will apply this refactoring
for almost every Standard Module, I will bundle my PEP3121 and PEP341
Robin Schreiber robin.schrei...@me.com added the comment:
I was of course referring to PEP 384. Sorry for the inconvenience.
--
title: PEP 341 Refactoring applied to _csv module - PEP 384 Refactoring
applied to _csv module
___
Python tracker rep
New submission from Robin Schreiber robin.schrei...@me.com:
I have now applied the Heap-Type Refactoring from PEP 384 to the curses_panel
module. Currently I still provide seperate patches for the PEP 3121 and PEP 384
refactoring. As mentioned in Issue #14935 I am planning to release single
Changes by Robin Schreiber robin.schrei...@me.com:
Added file: http://bugs.python.org/file25747/curses_panel_pep3121.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14936
Robin Schreiber robin.schrei...@me.com added the comment:
I have now also added the PEP3121 patch for the curses_panel module.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14936
New submission from Robin Schreiber robin.schrei...@me.com:
PEP 3121 suggests a new way of Module-initialization, where the module state is
being wrapped inside a dedicate struct, which can be accessed at runtime via
the PyState_FindModule method. For code outside the Init-method
Robin Schreiber robin.schrei...@me.com added the comment:
Added missing documentation. Also added documentation of PyState_FindModule()
which still happened to be missing.
--
Added file: http://bugs.python.org/file26046/PyState_add-remove_module_v2.patch
New submission from Robin Schreiber robin.schrei...@me.com:
Enhancement to the currently existing PyType_FromSpec() which creates and
returns a heap type from a given spec. PyType_FromSpecWithBases() works similar
to PyType_FromSpec(), however it sets the bases of the newly created heap type
Changes by Robin Schreiber robin.schrei...@me.com:
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15146
___
___
Python-bugs-list
Robin Schreiber robin.schrei...@me.com added the comment:
Added missing INCREF and DECREF inside the dealloc, and new methods of the
types.
--
Added file: http://bugs.python.org/file26381/csv_pep384_v1.patch
___
Python tracker rep...@bugs.python.org
New submission from Robin Schreiber robin.schrei...@me.com:
Changes proposed in PEP3121 and PEP384 applied to the curses module. As these
Changes do not alter behaviour of the specific modules, I would encourage to
see this enhancement as a bugfix and consequently include this into the
coming
New submission from Robin Schreiber robin.schrei...@me.com:
Changes proposed in PEP3121 and PEP384 have now been applied to the datetime
module!
--
components: Extension Modules
files: _datetimemodule_pep3121-384_v0.patch
keywords: patch
messages: 165805
nosy: Robin.Schreiber
priority
Changes by Robin Schreiber robin.schrei...@me.com:
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15389
___
___
Python-bugs-list
Robin Schreiber added the comment:
Fixed the dealloc-methods of the types, for proper type dereferencing.
--
Added file: http://bugs.python.org/file26797/csv_pep384_v2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14935
Changes by Robin Schreiber robin.schrei...@me.com:
--
versions: +Python 3.4 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14935
Robin Schreiber added the comment:
Fixed _dealloc methods. Also: Init now returns the previously initialized
module if available.
--
Added file:
http://bugs.python.org/file26803/_datetimemodule_pep3121-384_v1.patch
___
Python tracker rep
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the dbm module!
--
components: Extension Modules
files: _dbmmodule_pep3121-384_v0.patch
keywords: patch
messages: 168216
nosy: Robin.Schreiber
priority: normal
severity: normal
status
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the elementtree
module!
--
components: Extension Modules
files: _elementtree_pep3121-384_v0.patch
keywords: patch
messages: 168217
nosy: Robin.Schreiber
priority: normal
severity
Changes by Robin Schreiber robin.schrei...@me.com:
--
nosy: +effbot
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15651
___
___
Python-bugs-list
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the gdbm module!
--
components: Extension Modules
files: _gdbm_pep3121-384_v0.patch
keywords: patch
messages: 168219
nosy: Robin.Schreiber, anthony_baxter
priority: normal
severity
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the hashopenssl
module!
--
components: Extension Modules
files: _hashopenssl_pep3121-384_v0.patch
keywords: patch
messages: 168220
nosy: Robin.Schreiber, gstein
priority: normal
New submission from Robin Schreiber:
Changes proposed in PEP384 have now been applied to the bz2 module!
--
components: Extension Modules
files: _bz2_pep384_v0.patch
keywords: patch
messages: 168221
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 384
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the json module!
--
components: Extension Modules
files: _json_pep384_v0.patch
keywords: patch
messages: 168222
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title
Robin Schreiber added the comment:
Regarding the macro definition, I would be fine with changing it to
_hashlib_state.
The dance you have found inside the Init, makes shure that the very same module
is returned if Init is called twice or multiple times, before the Module is
unloaded. A month
Robin Schreiber added the comment:
Hey Antoine,
This comment describes exactly what I intended with the dance in issue15653.
For example the json testsuite issued multiple calls to the init function
before unloading and consequently clearing the module.
However it seems as if the behavior
Robin Schreiber added the comment:
Well, as I have changed the static type to a HeapType (as I am now using the
stable ABI from PEP 384 for this type), we have to start perfoming proper
reference counting with this object. This includes increfing the type in case a
new object of that type
Robin Schreiber added the comment:
Incidentally, I am deeply sorry for the C++-Style comments. I thought those
would be detected by the patchcheck.py.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15655
Robin Schreiber added the comment:
As subtype_dealloc decref'ed the HeapType I thought the dealloc method was the
most appropriate place to decrement the refcount of the type.
However you still agree that these types need to be recounted properly, don't
you? In that case, where would you place
Robin Schreiber added the comment:
I have now included the changes that Antoine suggested. The _Get_State was used
for debugging purposes and is, as I think, no longer necessary.
However we have yet to find a solution for the decref inside the dealloc
methods.
--
Added file:
http
Robin Schreiber added the comment:
Removed C++ comment and corresponding codesnipped. Also changed bad-style macro
definition.
--
Added file: http://bugs.python.org/file26818/_json_pep384_v1.patch
___
Python tracker rep...@bugs.python.org
http
New submission from Robin Schreiber:
Changes proposed in PEP3121 have now been applied to the locale module!
--
components: Extension Modules
files: _locale_pep3121_v0.patch
keywords: patch
messages: 168268
nosy: Robin.Schreiber, loewis
priority: normal
severity: normal
status: open
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the lsprof
module!
--
components: Extension Modules
files: _lsprof_pep3121-384_v0.patch
keywords: patch
messages: 168292
nosy: Robin.Schreiber
priority: normal
severity: normal
status
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the lzma module!
--
components: Extension Modules
files: _lzma_pep3121-384_v0.patch
keywords: patch
messages: 168294
nosy: Robin.Schreiber, nadeem.vawda
priority: normal
severity: normal
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the pickle
module!
--
components: Extension Modules
files: _pickle_pep3121-384_v0.patch
keywords: patch
messages: 168295
nosy: Robin.Schreiber
priority: normal
severity: normal
status
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the lsprof
module!
--
components: Extension Modules
files: _random_pep3121-384_v0.patch
keywords: patch
messages: 168297
nosy: Robin.Schreiber, rhettinger
priority: normal
severity
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the sre module!
--
components: Extension Modules
files: _sre_pep3121-384_v0.patch
keywords: patch
messages: 168298
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the ssl module!
--
components: Extension Modules
files: _ssl_pep3121-384_v0.patch
keywords: patch
messages: 168300
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the struct
module!
--
components: Extension Modules
files: _struct_pep3121-384_v0.patch
keywords: patch
messages: 168302
nosy: Robin.Schreiber
priority: normal
severity: normal
status
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the testbuffer
module!
--
components: Extension Modules
files: _testbuffer_pep3121-384_v0.patch
keywords: patch
messages: 168304
nosy: Robin.Schreiber
priority: normal
severity: normal
Changes by Robin Schreiber robin.schrei...@me.com:
--
nosy: +skrah -Robin.Schreiber
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15672
Changes by Robin Schreiber robin.schrei...@me.com:
--
nosy: +Robin.Schreiber
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15672
___
___
Python
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the testcapi
module!
--
components: Extension Modules
files: _testcapi_pep3121-384_v0.patch
keywords: patch
messages: 168305
nosy: Robin.Schreiber
priority: normal
severity: normal
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the thread
module!
--
components: Extension Modules
files: _thread_pep3121-384_v0.patch
keywords: patch
messages: 168306
nosy: Robin.Schreiber
priority: normal
severity: normal
status
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the array
module!
--
components: Extension Modules
files: array_pep3121-385_v0.patch
keywords: patch
messages: 168307
nosy: Robin.Schreiber
priority: normal
severity: normal
status
New submission from Robin Schreiber:
Changes proposed in PEP3121 have now been applied to the audioop module!
--
components: Extension Modules
files: audioop_pep3121_v0.patch
keywords: patch
messages: 168353
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP
New submission from Robin Schreiber:
Changes proposed in PEP3121 have now been applied to the binascii module!
--
components: Extension Modules
files: binascii_pep3121_v0.patch
keywords: patch
messages: 168354
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title
New submission from Robin Schreiber:
Changes proposed in PEP3121 have now been applied to the fpectl module!
--
components: Extension Modules
files: fpectl_pep3121_v0.patch
keywords: patch
messages: 168355
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the fpetest
module!
--
components: Extension Modules
files: fpetest_pep3121_v0.patch
keywords: patch
messages: 168357
nosy: Robin.Schreiber
priority: normal
severity: normal
status
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the itertools
module!
--
components: Extension Modules
files: itertools_pep3121-384_v0.patch
keywords: patch
messages: 168359
nosy: Robin.Schreiber, rhettinger
priority: normal
severity
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the md5 module!
--
components: Extension Modules
files: md5_pep3121-384_v0.patch
keywords: patch
messages: 168360
nosy: Robin.Schreiber, gregory.p.smith
priority: normal
severity: normal
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the mmap module!
--
components: Extension Modules
files: mmap_pep3121-384_v0.patch
keywords: patch
messages: 168361
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the nis module!
--
components: Extension Modules
files: nis_pep3121_v0.patch
keywords: patch
messages: 168362
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the operator
module!
--
components: Extension Modules
files: operator_pep3121-384_v0.patch
keywords: patch
messages: 168363
nosy: Robin.Schreiber
priority: normal
severity: normal
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the parser
module!
--
components: Extension Modules
files: parser_pep3121-384_v0.patch
keywords: patch
messages: 168364
nosy: Robin.Schreiber
priority: normal
severity: normal
status
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the posix
module!
--
components: Extension Modules
files: posix_pep3121-384_v0.patch
keywords: patch
messages: 168367
nosy: Robin.Schreiber
priority: normal
severity: normal
status
New submission from Robin Schreiber:
Changes proposed in PEP3121 have now been applied to the pwd module!
--
components: Extension Modules
files: pwd_pep3121_v0.patch
keywords: patch
messages: 168403
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the pyexpat
module!
--
components: Extension Modules
files: pyexpat_pep3121-384_v0.patch
keywords: patch
messages: 168404
nosy: Robin.Schreiber
priority: normal
severity: normal
status
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the readline
module!
--
components: Extension Modules
files: readline_pep3121-384_v0.patch
keywords: patch
messages: 168405
nosy: Robin.Schreiber
priority: normal
severity: normal
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the resource
module!
--
components: Extension Modules
files: resource_pep3121-384_v0.patch
keywords: patch
messages: 168406
nosy: Robin.Schreiber
priority: normal
severity: normal
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the select
module!
--
components: Extension Modules
files: select_pep3121-384_v0.patch
keywords: patch
messages: 168410
nosy: Robin.Schreiber
priority: normal
severity: normal
status
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the sha1 module!
--
components: Extension Modules
files: sha1_pep3121-384_v0.patch
keywords: patch
messages: 168411
nosy: Robin.Schreiber, gregory.p.smith
priority: normal
severity
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the sha256
module!
--
components: Extension Modules
files: sha256_pep3121-384_v0.patch
keywords: patch
messages: 168412
nosy: Robin.Schreiber, gregory.p.smith
priority: normal
severity
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the sha512
module!
--
components: Extension Modules
files: sha512_pep3121-384_v0.patch
keywords: patch
messages: 168413
nosy: Robin.Schreiber, gregory.p.smith
priority: normal
severity
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the signal
module!
--
components: Extension Modules
files: signal_pep3121-384_v0.patch
keywords: patch
messages: 168415
nosy: Robin.Schreiber
priority: normal
severity: normal
status
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the socket
module!
--
components: Extension Modules
files: socket_pep3121-384_v0.patch
keywords: patch
messages: 168416
nosy: Robin.Schreiber
priority: normal
severity: normal
status
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the termios
module!
--
components: Extension Modules
files: termios_pep3121-384_v0.patch
keywords: patch
messages: 168417
nosy: Robin.Schreiber
priority: normal
severity: normal
status
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the time module!
--
components: Extension Modules
files: time_pep3121-384_v0.patch
keywords: patch
messages: 168419
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the unicodedata
module!
--
components: Extension Modules
files: unicodedate_pep3121-384_v0.patch
keywords: patch
messages: 168420
nosy: Robin.Schreiber, effbot, lemburg, loewis
priority
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the zipimport
module!
--
components: Extension Modules
files: zipimport_pep3121-384_v0.patch
keywords: patch
messages: 168421
nosy: Robin.Schreiber
priority: normal
severity: normal
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the grp module!
--
components: Extension Modules
files: grp_pep3121-384_v0.patch
keywords: patch
messages: 168422
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the tkinter
module!
When running the test form inside Python.exe (tkinter._test()), the litte
test-window is rendered correctly. However there are still some error
messages popping up inside
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the decimal
module!
--
components: Regular Expressions
files: _decimal_pep3121-384_v0.patch
keywords: patch
messages: 168511
nosy: Robin.Schreiber, ezio.melotti, mrabarnett, skrah
Changes by Robin Schreiber robin.schrei...@me.com:
--
components: +Extension Modules -Regular Expressions
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15722
Robin Schreiber added the comment:
I have removed some redundant modulestate lookups and the testsuite now
executes the decimal tests as fast as before the patch is applied. (at least
for me).
May I ask how you tested the decimal performance?
Regarding the failing test:
It appears
New submission from Robin Schreiber:
This small patch prevents PyType_FromSpecWithBases, from setting the base(s)
attribute of the HeapType to NULL-values.
--
components: Interpreter Core
files: PyType_FromSpecWithBases_bases_fix.patch
keywords: patch
messages: 168570
nosy
New submission from Robin Schreiber:
Fixed wrong list-length comparison in PyState_FindModule.
--
components: Interpreter Core
files: PyState_FindModule_LE_fix.patch
keywords: patch
messages: 168572
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title
Changes by Robin Schreiber robin.schrei...@me.com:
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15726
___
___
Python-bugs-list
Changes by Robin Schreiber robin.schrei...@me.com:
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15725
___
___
Python-bugs-list
New submission from Robin Schreiber:
As with every type, that has been created and initialized, HeapTypes created
form PyType_FromSpecWithBases() have to pass through PyType_Ready(). Here the
function inherit_special might be called, which, among other things, does the
following:
3892
New submission from Robin Schreiber:
To create a HeapType from Structseq description, there is the helpful, yet
undocumented PyStructSequence_NewType Method, which can do just that.
Until now, this method solely allocates some generic TypeObject on which it
then performs
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the winapi
module!
--
components: Extension Modules
files: _winapi_pep3121-384_v0.patch
keywords: patch
messages: 168639
nosy: Robin.Schreiber, astrand, effbot, loewis
priority: normal
Robin Schreiber added the comment:
Forgot to change the macro definition...
--
Added file: http://bugs.python.org/file26922/_winapi_pep3121-384_v1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15733
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the spwd module!
--
components: Extension Modules
files: spwd_pep3121-384_v0.patch
keywords: patch
messages: 168641
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the ossaudio
module!
--
components: Extension Modules
files: ossaudiodev_pep3121-384_v0.patch
keywords: patch
messages: 168642
nosy: Robin.Schreiber
priority: normal
severity: normal
Robin Schreiber robin.schrei...@me.com added the comment:
Apparently this issue has not been dealt with for quite some time now. As a
prospective GSoC student, I still need to submit a patch to pass final
screening and I thought, that the needed patch here would be quite suitable
Robin Schreiber robin.schrei...@me.com added the comment:
I have now submitted a patch, which swapped out all the necessary calls. Tests
are all running as expected. I will now try to remove some backwards
compatibility code.
--
keywords: +patch
Added file: http://bugs.python.org
Changes by Robin Schreiber robin.schrei...@me.com:
Removed file: http://bugs.python.org/file25211/sqlite.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9303
Changes by Robin Schreiber robin.schrei...@me.com:
Added file: http://bugs.python.org/file25212/sqlite.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9303
New submission from Robin Schreiber robin.schrei...@me.com:
This patch presents my first try to apply the proposed Refactoring of PEP3121
to the csv module. I have identified three mutable global variables inside the
module, two of which are references to PyObjects. I have wrapped all of them
Robin Schreiber robin.schrei...@me.com added the comment:
The following script should fail before you have applied the bespoken patch: It
basically checks wether one of the global PyObjects inside the csv module is
being deleted after freeing the csv module.
--
Added file: http
Changes by Robin Schreiber robin.schrei...@me.com:
Added file: http://bugs.python.org/file25559/csv_pep3121_fix1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14732
Robin Schreiber added the comment:
I have in fact used abitype.py to produce all of my PEP 384 patches, however it
failed to work correctly in like 50% of all cases, and I had to complete the
rest of the patch by hand.I thought about correcting the abitype.py throughout
the GSOC, but I
Robin Schreiber added the comment:
I absolutely agree on mentioning the member names in the comments. :-)
In the example Martin gave in his PEP 3121, the PyInit does not perform any
INCREFs on the Variables that are referenced from inside the module state.
He therefore left out m_free
Robin Schreiber added the comment:
Updated the patch, corrected multiple syntax errors and missing INCREFS. Also
added the comments that include the members names. I am yet undecided regarding
the NULL-check for FindModule.
Apart from that I have tried to build some tests that prove
Robin Schreiber added the comment:
Antoine, regarding that the last pending problem with the patch is related to
the NULL checking of FindModule, I would be inclined to include your proposed
helper API. I see that issue18710 has not been included into the trunk yet, but
I think this is mostly
1 - 100 of 164 matches
Mail list logo
