STINNER Victor added the comment:
Oh no, I expected that the new way to build Python would also export
PyThread_get_thread_native_id() on Solaris. I reopen the issue.
Can you please specify your configure command? Can you check without Python if
the symbol is exported or not? If you use
Change by STINNER Victor :
--
nosy: -vstinner
___
Python tracker
<https://bugs.python.org/issue46372>
___
___
Python-bugs-list mailing list
Unsubscribe:
STINNER Victor added the comment:
> Freelists for object structs can now be disabled. A new configure option
> --without-freelists can be used to disable all freelists except empty tuple
> singleton. (Contributed by Christian Heimes in bpo-45522)
Can you please documen
STINNER Victor added the comment:
I just want to say that GOOGLE_ETERNAL_REFCOUNT_SUPPORT is a cool name :-D I
love "eternal refcount"!
--
___
Python tracker
<https://bugs.python.o
STINNER Victor added the comment:
> It appears the `multiprocessing`'s "spawn" mode doesn't actually use POSIX
> spawn, but instead uses fork+exec[1].
The documentation doesn't pretend to use posix_spawn(). It only says: "starts a
fresh python interpreter process"
STINNER Victor added the comment:
New changeset 7c770d3350813a82a639fcb3babae0de2b87aaae by Victor Stinner in
branch 'main':
bpo-46280: Fix tracemalloc_copy_domain() (GH-30591)
https://github.com/python/cpython/commit/7c770d3350813a82a639fcb3babae0de2b87aaae
STINNER Victor added the comment:
#389
Modules/_tracemalloc.c:1245: error: Null Dereference
pointer `traces2` last assigned on line 1243 could be null and is
dereferenced by call to `_Py_hashtable_destroy()` at line 1245, column 9.
1243. _Py_hashtable_t *traces2
Change by STINNER Victor :
--
nosy: +vstinner
nosy_count: 6.0 -> 7.0
pull_requests: +28789
pull_request: https://github.com/python/cpython/pull/30591
___
Python tracker
<https://bugs.python.org/issu
STINNER Victor added the comment:
commit b962544594c6a7c695330dd20fedffb3a1916ba6
Author: Miss Islington (bot) <31488909+miss-isling...@users.noreply.github.com>
Date: Sat Jan 8 17:08:20 2022 -0800
bpo-34602: Fix unportable test(1) operator in configure script (GH-30490)
(GH
Change by STINNER Victor :
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue45953>
___
___
Python-bugs-list mailing list
Unsubscribe:
STINNER Victor added the comment:
I didn't notice this issue recently, but I didn't pay attention this buildbot
worker neither. I close the issue.
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracke
STINNER Victor added the comment:
> I took as initialized to avoid undefined behavior rather than anything.
I don't get what you mean.
Can you please show me which functions initialize sockaddr_l2cap structures and
explain how the current code fills all members?
I don't know the code w
STINNER Victor added the comment:
Attached patch is an incomplete quick & dirty implementation to log all
interpreters in _Py_DumpTracebackThreads().
A better implementation should leave the current behavior unmodified, add a new
C function, and add all_interpreters=False param
STINNER Victor added the comment:
I created bpo-46368: "faulthandler: add the ability to dump all interpreters,
not only the current interpreter".
--
___
Python tracker
<https://bugs.python.o
New submission from STINNER Victor :
While debugging the sub-interpreter crash bpo-46070, I noticed that
faulthandler only logs the Python thread state of a single interpreter. When a
bug involves multiple interpreters, it is useful to log all interpreters.
--
components: Library
STINNER Victor added the comment:
pyobject_ob_interp.patch: Quick & dirty patch that I wrote to add
PyObject.ob_interp, store in which interpreter an object has been created.
--
Added file: https://bugs.python.org/file50560/pyobject_ob_interp.p
STINNER Victor added the comment:
Victor:
> (*) I made the GC state per-interpreter: commit
> 7247407c35330f3f6292f1d40606b7ba6afd5700 (Nov 20, 2019)
Eric Snow:
> FYI, this was done by me in an earlier comment which we ended up
reverting. Later you basically un.reverted that.
STINNER Victor added the comment:
It would be nice to add some tests.
--
___
Python tracker
<https://bugs.python.org/issue46070>
___
___
Python-bugs-list mailin
STINNER Victor added the comment:
New changeset 52937c26adc35350ca0402070160cf6dc838f359 by Victor Stinner in
branch '3.9':
bpo-46070: _PyGC_Fini() untracks objects (GH-30577) (GH-30580)
https://github.com/python/cpython/commit/52937c26adc35350ca0402070160cf6dc838f359
STINNER Victor added the comment:
I tested manually my fix GH-30580 using:
* (1) attached win_py399_crash_reproducer.py
* (2) https://bugs.python.org/issue46070#msg410447 mthod
Without my fix, I can easily reproduce the crash with (1) and (2).
With my fix, I can no longer reproduce
Change by STINNER Victor :
--
pull_requests: +28779
pull_request: https://github.com/python/cpython/pull/30580
___
Python tracker
<https://bugs.python.org/issue46
STINNER Victor added the comment:
New changeset 1a4d1c1c9b08e75e88aeac90901920938f649832 by Victor Stinner in
branch 'main':
bpo-46070: _PyGC_Fini() untracks objects (GH-30577)
https://github.com/python/cpython/commit/1a4d1c1c9b08e75e88aeac90901920938f649832
Change by STINNER Victor :
--
title: Some C-API symbols (e.g. Py_FrozenMain) are not always exported -> Some
C-API symbols (e.g. Py_FrozenMain) are not always exported on Unix
___
Python tracker
<https://bugs.python.org/issu
STINNER Victor added the comment:
> New changeset 6be848922bc0f4c632c255c39de82a45b6480286 by Victor Stinner in
> branch 'main':
> bpo-44133: Link Python executable with object files (GH-30556)
Sadly, Py_FrozenMain() is still missing on Windows. See:
https://github.com/python/cpy
STINNER Victor added the comment:
New changeset 6be848922bc0f4c632c255c39de82a45b6480286 by Victor Stinner in
branch 'main':
bpo-44133: Link Python executable with object files (GH-30556)
https://github.com/python/cpython/commit/6be848922bc0f4c632c255c39de82a45b6480286
STINNER Victor added the comment:
I merged my PR so the doc can be reviewed online at
https://docs.python.org/dev/whatsnew/3.11.html once it will be rendered ;-)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
STINNER Victor added the comment:
New changeset 0885999a8e5ffad3fae0302675ad0030e33a15af by Victor Stinner in
branch 'main':
bpo-46355: Document PyFrameObject and PyThreadState changes (GH-30558)
https://github.com/python/cpython/commit/0885999a8e5ffad3fae0302675ad0030e33a15af
STINNER Victor added the comment:
Sharing objects between multiple interpreters can cause complex bugs leading to
crashes: https://bugs.python.org/issue46070#msg410493 For this specific bug, I
wrote a workaround (GH-30577).
--
___
Python tracker
STINNER Victor added the comment:
This issue has a complex history.
(*) I made the GC state per-interpreter: commit
7247407c35330f3f6292f1d40606b7ba6afd5700 (Nov 20, 2019)
(*) This change triggered a _PyImport_FixupExtensionObject() bug in
sub-interpreter, I fixed it with commit
STINNER Victor added the comment:
Oh. I managed to write a simple fix which doesn't require to revert the whole
"per-interpreter GC" change: GH-30577.
--
___
Python tracker
<https://bugs.python.o
Change by STINNER Victor :
--
pull_requests: +28776
pull_request: https://github.com/python/cpython/pull/30577
___
Python tracker
<https://bugs.python.org/issue46
STINNER Victor added the comment:
When the crash occurs, the _sre.compile function is not destroyed in the
interpreter which created the function.
The crash is related to _sre.compile method. This method is created in
PyInit__sre() called by "import _sre".
On Windows, the _
STINNER Victor added the comment:
I wrote 3 scripts to reproduce the bug in a more reliable way. So I just have
to type "bisect" and it runs the test 12 times.
(1) bisect.bat:
---
@"C:\vstinner\python\3.9\PCbuild\amd64\python_d.exe" bisect.py
---
(2) bisect.py:
---
impo
STINNER Victor added the comment:
I modified PR 30565 (3.10) and PR 30566 (3.9) to fix the ABI. I added
_PyGC_GetState() which always use PyInterpreterState.gc of the main interpreter.
--
___
Python tracker
<https://bugs.python.org/issue46
STINNER Victor added the comment:
I prepared 3 pull requests to revert the commit
7247407c35330f3f6292f1d40606b7ba6afd5700:
* PR 30564: main branch
* PR 30565: 3.10 branch
* PR 30566: 3.9 branch
The problem is that the "Check if the ABI has changed" CI job fails in 3.9 and
3.1
Change by STINNER Victor :
--
pull_requests: +28769
pull_request: https://github.com/python/cpython/pull/30566
___
Python tracker
<https://bugs.python.org/issue46
Change by STINNER Victor :
--
pull_requests: +28768
pull_request: https://github.com/python/cpython/pull/30565
___
Python tracker
<https://bugs.python.org/issue46
Change by STINNER Victor :
--
pull_requests: +28767
pull_request: https://github.com/python/cpython/pull/30564
___
Python tracker
<https://bugs.python.org/issue46
Change by STINNER Victor :
--
pull_requests: +28766
pull_request: https://github.com/python/cpython/pull/30566
___
Python tracker
<https://bugs.python.org/issue36
Change by STINNER Victor :
--
pull_requests: +28765
pull_request: https://github.com/python/cpython/pull/30565
___
Python tracker
<https://bugs.python.org/issue36
Change by STINNER Victor :
--
pull_requests: +28764
pull_request: https://github.com/python/cpython/pull/30564
___
Python tracker
<https://bugs.python.org/issue36
STINNER Victor added the comment:
> Solves the "Make sure new member of socket address initialized." warning for
> the bluetooth sockaddr_l2cap usage.
You would to elaborate how you checked that all members of the socket address
are initialized? Which socketmodule.c functio
STINNER Victor added the comment:
> I don't know how we can stop people from using them though.
The first option is to promote helper functions to abstract access to the
PyFrameObject structure.
The second option is to make the whole structure opaque and enforce the usage
of hel
STINNER Victor added the comment:
It's unclear to me if the ability to read directly the PyFrameObject.f_lineno
member is a deliberate use case, or if we should enforce the usage of
PyFrame_GetLineNumber().
--
___
Python tracker
<ht
STINNER Victor added the comment:
> f_lineno: changed, use PyFrame_GetLineNumber()
Oh I was wrong, PyFrame_GetLineNumber() code is the same in Python 3.10. It was
already a bad idea to read directly the f_lineno member in Python 3.10:
PyFrame_GetLineNumber() should always be cal
New submission from STINNER Victor :
C extensions written for Python 3.10 and older which access directly to the
PyFrameObject.f_back member build successfully on Python 3.11, but they can
fail because f_back must not be read directly. f_back can be NULL even if the
frame has an outer frame
STINNER Victor added the comment:
> On Solaris (and most likely several other platforms),
> `PyThread_get_thread_native_id` is also not available.
Oh, I added an explicit test for that in my PR 30556.
> `Py_FrozenMain` should be added to stable ABI
I suggest to first fix the issu
Change by STINNER Victor :
--
keywords: +patch
pull_requests: +28759
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30558
___
Python tracker
<https://bugs.python.org/issu
New submission from STINNER Victor :
Python 3.11 made many changes in PyFrameObject and PyThreadState structures.
Code which accessed directly structure members doesn't build anymore. For
example, "frame->f_code" is now fails because PyFrameObject.f_code member is
done. I propos
Change by STINNER Victor :
--
pull_requests: +28757
pull_request: https://github.com/python/cpython/pull/30556
___
Python tracker
<https://bugs.python.org/issue44
STINNER Victor added the comment:
Paul Campbell: "The changes in the main branch gets me past this issue without
having to make additional changes."
Ok, nice. I close the issue.
I consider that building Python with clang is a new feature. I prefer to not
backport these chan
STINNER Victor added the comment:
> Seems it would go back to depending on some type nonstandard python macro to
> translate between the two during build.
In the internal C API, there are less concerns about writing portable code. We
expect users of this API to pay more attention t
STINNER Victor added the comment:
> Hi Victor, I was trying to compile with clang on Windows 10. I will try to
> pull your 3.11 changes and test. Sorry to cause so much churn. It looked to
> me like a simple issue that was missed, probably because whatever was trying
>
STINNER Victor added the comment:
If possible, I would prefer to not change 3.9 and 3.10 to avoid any risk of
introducing a *new* build error, while trying to support a new platform. I
don't think that we currently supporting build Python with clang on Windows yet
STINNER Victor added the comment:
Paul: Can you please try to build the main branch of Python with clang and tell
me if you still have the compiler warnings? If yes, can you please copy/paste
the compiler warnings?
Do you build Python on Windows or from another OS (cross-compilation
STINNER Victor added the comment:
Christian Heimes: "I set the release blocker flag for the ticket."
It's just a compiler warning, why marking it as a release blocker?
Anyway, it's now fixed.
--
priority: release blocker ->
___
P
STINNER Victor added the comment:
New changeset 08bc1bad11cad39f508bd662c9b28fcd9c995512 by Victor Stinner in
branch 'main':
bpo-46303: Fix fileutils.h compiler warnings (GH-30550)
https://github.com/python/cpython/commit/08bc1bad11cad39f508bd662c9b28fcd9c995512
STINNER Victor added the comment:
The memory leak has been fixed in 3.10 and main branches. Can this issue be
closed now?
--
components: +Interpreter Core
versions: +Python 3.10, Python 3.11
___
Python tracker
<https://bugs.python.org/issue46
STINNER Victor added the comment:
I marked bpo-46346 as a duplicate of this issue. Copy of the first message:
"""
I am getting these warnings:
C:\Users\gvanrossum\cpython\PC\_testconsole.c(70,38): warning C4013:
'_Py_get_osfhandle' undefined; assuming extern returnin
STINNER Victor added the comment:
Oh right, I introduced these warnings in bpo-46303. Let's continue the
discussion there.
--
dependencies: -_Py_stat and _Py_wstat using incorrect type for status argument
priority: release blocker ->
resolution: -> duplicate
stage: needs
Change by STINNER Victor :
--
pull_requests: +28751
pull_request: https://github.com/python/cpython/pull/30550
___
Python tracker
<https://bugs.python.org/issue46
STINNER Victor added the comment:
It seems like _Py_stat() and _Py_wstat() are only needed on non-Windows
platforms: only the _get_tcl_lib_path() function of Modules/_tkinter.c uses
_Py_stat(). I wrote PR 30539 to not define _Py_stat() and _Py_wstat() on
Windows
Change by STINNER Victor :
--
pull_requests: +28739
pull_request: https://github.com/python/cpython/pull/30539
___
Python tracker
<https://bugs.python.org/issue46
STINNER Victor added the comment:
Python.h indirectly (via fileutils.h) defines _Py_wstat() and _Py_stat()
functions which use the "struct stat*" type for 12 years:
commit 4e31443c4d2c1fb211a6ea90fc6a8fbd9ff81c97
Author: Victor Stinner
Date: Thu Oct 7 21:45:39 2010 +
STINNER Victor added the comment:
> While attempting to embed the full cpython source in my application, I found
> that during compilation on Windows, there was a compilation issue due to
> struct stat not being defined.
Do you get the error when building Python? Or on #include w
Change by STINNER Victor :
--
pull_requests: +28729
pull_request: https://github.com/python/cpython/pull/30528
___
Python tracker
<https://bugs.python.org/issue46
STINNER Victor added the comment:
New changeset ea1a54506b4ac38b712ba63ec884292025f16111 by Victor Stinner in
branch 'main':
bpo-46303: Move fileutils.h private functions to internal C API (GH-30484)
https://github.com/python/cpython/commit/ea1a54506b4ac38b712ba63ec884292025f16111
STINNER Victor added the comment:
> Serhiy: What do you think about -hh (and maybe —help-full) printing full help?
Do you know other projects which dump the full help into stdout when asking for
the "full help"?
For me, the best CLI is "git help", "git help init&
Change by STINNER Victor :
--
nosy: -vstinner
___
Python tracker
<https://bugs.python.org/issue46323>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by STINNER Victor :
--
nosy: -vstinner
___
Python tracker
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by STINNER Victor :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
STINNER Victor added the comment:
It's not the first time that private functions included by the public Python.h
are causing build errors event if these functions are not used. The previous
issue were functions for atomic operations. I solved this build error by moving
the whole private C
Change by STINNER Victor :
--
pull_requests: +28688
pull_request: https://github.com/python/cpython/pull/30484
___
Python tracker
<https://bugs.python.org/issue46
STINNER Victor added the comment:
This bug is hard to reproduce for different reasons:
* It occurs randomly: I need between 1 and 50 attempts to reproduce the bug
using win_py399_crash_reproducer.py
* So far, the bug was only reproduced on Windows.
* I failed to reproduce the crash
Change by STINNER Victor :
--
title: [subinterpreters] asyncio crash when importing _asyncio in
subinterpreter (Python 3.8 regression) -> [subinterpreters] crash when
importing _sre in subinterpreters in parallel (Python 3.9 regression)
___
Pyt
STINNER Victor added the comment:
The _sre crash has a complex history in the 3.9 branch:
* (1) 2019-11-20, commit 7247407c35330f3f6292f1d40606b7ba6afd5700: first CRASH!
The parent commit (488d02a24142948bfb1fafd19fa48e61fcbbabc5) doesn't crash.
* (2) 2019-11-22, commit
STINNER Victor added the comment:
The bpo-46295 was marked as a duplicate of this issue.
--
___
Python tracker
<https://bugs.python.org/issue15751>
___
___
Pytho
STINNER Victor added the comment:
In the 3.9 branch, the commit 4d2cfd354969590ba8e0af0447fd84f8b5e61952 fixed
the _asyncio extension. win_py399_crash_reproducer.py still branch on Windows
in the 3.9 branch. The code can be simplified with:
code = "import _sre"
Moreover,
STINNER Victor added the comment:
I reverted manually the commit 52d9d3b75441ae6038fadead89eac5eecdd34501 (in my
local Python 3.9 checkout): I confirm that the revert fix the
win_py399_crash_reproducer.py crash in Python 3.9.
--
___
Python
STINNER Victor added the comment:
> The problematic change could be (d0d29655ff) affecting import.c
This change is part of the 3.10 branch. For 3.9, git bisect tells me that it's
the following change:
commit 52d9d3b75441ae6038fadead89eac5eecdd34501
Author: Łukasz Langa
Date: Tue Oct 5
STINNER Victor added the comment:
Even with PR 30454, I can still reproduce the crash on Python 3.9 (randomly, it
takes a few attempts to reproduce the crash):
vstinner@DESKTOP-DK7VBIL C:\vstinner\python\3.9>python -X dev
win_py399_crash_reproducer.py
Running Debug|x64 interpreter...
e
STINNER Victor added the comment:
New changeset b127e70a8a682fe869c22ce04c379bd85a00db67 by Erlend Egeberg
Aasland in branch 'main':
bpo-46070: Fix asyncio initialisation guard (GH-30423)
https://github.com/python/cpython/commit/b127e70a8a682fe869c22ce04c379bd85a00db67
STINNER Victor added the comment:
"xoptions" name comes from sys._xoptions (Python) and PyConfig.xoptions (C).
Oh, sys._xoptions is a private API... but it's mentioned in the -X
documentation:
https://docs.python.org/3/using/cmdline.html#c
STINNER Victor added the comment:
My commit ea251806b8d11b30d2182af1e589caf88acf (interned strings)
introduced bpo-46006 "[subinterpreter] _PyUnicode_EqualToASCIIId() issue with
subinterpreters" regression.
To unblock the Python 3.11.0a4 release, I just reverted
STINNER Victor added the comment:
_PyUnicode_EqualToASCIIId() and type update_slot() functions are fixed in 3.10
and main branches. The regression is now fixed.
But the revert reintroduces the issue on subinterpreters, so I created
bpo-46283: "[subinterpreters] Unicode interned strings
New submission from STINNER Victor :
My commit ea251806b8d11b30d2182af1e589caf88acf made Unicode interned
strings per interpreter to avoid accessing the same Python object from two
different interpreters, to avoid race conditions on its reference count.
Problem: the change introduced
Change by STINNER Victor :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue46283>
___
___
Python-bugs-list mailing list
Unsubscribe:
STINNER Victor added the comment:
New changeset 72c260cf0c71eb01eb13100b751e9d5007d00b70 by Victor Stinner in
branch '3.10':
[3.10] bpo-46006: Revert "bpo-40521: Per-interpreter interned strings
(GH-20085)" (GH-30422) (GH-30425)
https://github.com/python/cpyt
STINNER Victor added the comment:
New changeset 72c260cf0c71eb01eb13100b751e9d5007d00b70 by Victor Stinner in
branch '3.10':
[3.10] bpo-46006: Revert "bpo-40521: Per-interpreter interned strings
(GH-20085)" (GH-30422) (GH-30425)
https://github.com/python/cpyt
Change by STINNER Victor :
--
pull_requests: +28640
pull_request: https://github.com/python/cpython/pull/30433
___
Python tracker
<https://bugs.python.org/issue40
Change by STINNER Victor :
--
pull_requests: +28639
pull_request: https://github.com/python/cpython/pull/30433
___
Python tracker
<https://bugs.python.org/issue46
STINNER Victor added the comment:
vstinner@apu$ python3
Python 3.10.1 (main, Dec 9 2021, 00:00:00) [GCC 11.2.1 20211203 (Red Hat
11.2.1-7)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> str_='''...
...
Change by STINNER Victor :
--
pull_requests: +28631
pull_request: https://github.com/python/cpython/pull/30425
___
Python tracker
<https://bugs.python.org/issue40
Change by STINNER Victor :
--
pull_requests: +28630
pull_request: https://github.com/python/cpython/pull/30425
___
Python tracker
<https://bugs.python.org/issue46
STINNER Victor added the comment:
New changeset 35d6540c904ef07b8602ff014e520603f84b5886 by Victor Stinner in
branch 'main':
bpo-46006: Revert "bpo-40521: Per-interpreter interned strings (GH-20085)"
(GH-30422)
https://github.com/python/cpyt
STINNER Victor added the comment:
New changeset 35d6540c904ef07b8602ff014e520603f84b5886 by Victor Stinner in
branch 'main':
bpo-46006: Revert "bpo-40521: Per-interpreter interned strings (GH-20085)"
(GH-30422)
https://github.com/python/cpyt
STINNER Victor added the comment:
IMO writing a complete rationale for running multiple interpreters in parallel
which require a whole PEP. I didn't write such PEP yet since there are still
non-trivial technical issues, especially the problem of static types: bpo-40601.
I don't have time
Change by STINNER Victor :
--
pull_requests: +28627
pull_request: https://github.com/python/cpython/pull/30422
___
Python tracker
<https://bugs.python.org/issue46
Change by STINNER Victor :
--
pull_requests: +28626
pull_request: https://github.com/python/cpython/pull/30422
___
Python tracker
<https://bugs.python.org/issue40
STINNER Victor added the comment:
> bpo-36356: Fix memory leak in _asynciomodule.c (GH-16598)
Python 3.8.0 is the first Python version containing this change. So it looks
like a Python 3.8 regression.
--
___
Python tracker
<
901 - 1000 of 34965 matches
Mail list logo