[issue13349] Non-informative error message in index() and remove() functions

Sean Ochoa added the comment: Working on issue as part of Python Bug Day, Oct 2012. -- nosy: +Sean.Ochoa ___ Python tracker <http://bugs.python.org/issue13

[issue13349] Non-informative error message in index() and remove() functions

Sean Ochoa added the comment: It seems that this has been fixed. Using simple tests from msg147215: ~/hg/cpython/working $ env-py3.3/bin/python Python 3.3.0 (default, Nov 3 2012, 15:28:29) [GCC 4.7.2] on linux Type "help", "copyright", "credits" or

[issue13349] Non-informative error message in index() and remove() functions

Sean Ochoa added the comment: After discussing with folks on the #python-dev tonight, I learned that I was testing with a list and I should've been using a set. I'm working on a patch now, and I'm almost ready to have it reviewed. -- ___

[issue13349] Non-informative error message in index() and remove() functions

Sean Ochoa added the comment: Ready for review. -- keywords: +patch Added file: http://bugs.python.org/file27884/issue-13349.patch ___ Python tracker <http://bugs.python.org/issue13

[issue13349] Non-informative error message in index() and remove() functions

Sean Ochoa added the comment: Tests updated for coverage and to use assertRaisesRegex. -- Added file: http://bugs.python.org/file27907/issue13349.patch.1 ___ Python tracker <http://bugs.python.org/issue13

[issue13349] Non-informative error message in index() and remove() functions

Sean Ochoa added the comment: >From Taggnostr on #python-dev: 1.) Use assertRaises+assertIn instead of assertRaisesRegex 2.) Add or change an existing test that you've already updated to use elements with a repr longer than 1

[issue13349] Non-informative error message in index() and remove() functions

Sean Ochoa added the comment: Truncating repr strings to 100chars will require the patch from #7330. After applying the patch from that issue, my tests work fine. -- ___ Python tracker <http://bugs.python.org/issue13

[issue13349] Non-informative error message in index() and remove() functions

Sean Ochoa added the comment: Updated patch after taking into account Ezio's (aka Taggnostr on #python-dev) latest feedback. -- Added file: http://bugs.python.org/file27940/issue13349.patch.2 ___ Python tracker <http://bugs.python.org/is

[issue13349] Non-informative error message in index() and remove() functions

Sean Ochoa added the comment: Updates after feedback from Serhiy. -- Added file: http://bugs.python.org/file27949/issue13349.patch.3 ___ Python tracker <http://bugs.python.org/issue13

[issue13349] Non-informative error message in index() and remove() functions

Sean Ochoa added the comment: Lib/test/test_array.py -- Moved index test (for this issue) to test_index (existing test method). -- Added remove test (for this issue) to test_remove (existing test method) Lib/test/test_deque.py -- Moved remove test (for this issue) to test_index (existing

[issue13349] Non-informative error message in index() and remove() functions

Sean Ochoa added the comment: Update based on Taggnostr's (Ezio on IRC, if I recall correctly) feedback from 11/12/2012 around 11:57 PST. * Added check for index result in positive tests. * Added assertIn check for remove result in positive tests. * Removed extra whitespace. * Form

[issue13349] Non-informative error message in index() and remove() functions

Sean Ochoa added the comment: * Fixed issue with test name in Lib/test/test_tuple.py * Fixed issue with test_remove in Lib/test/test_list.py to assertNotIn instead of assertIn for positive case. Confirmed with Ezio that issue #7330 will need to be fixed/approved before this issue can be

[issue7330] PyUnicode_FromFormat: implement width and precision for %s, %S, %R, %V, %U, %A

Changes by Sean Ochoa : -- nosy: +Sean.Ochoa ___ Python tracker <http://bugs.python.org/issue7330> ___ ___ Python-bugs-list mailing list Unsubscribe: