[issue13349] Non-informative error message in index() and remove() functions
Sean Ochoa added the comment: Update based on Taggnostr's (Ezio on IRC, if I recall correctly) feedback from 11/12/2012 around 11:57 PST. * Added check for index result in positive tests. * Added assertIn check for remove result in positive tests. * Removed extra whitespace. * Formatted comments to be more concise. -- Added file: http://bugs.python.org/file28265/issue13349.patch.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13349 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13349] Non-informative error message in index() and remove() functions
Sean Ochoa added the comment: * Fixed issue with test name in Lib/test/test_tuple.py * Fixed issue with test_remove in Lib/test/test_list.py to assertNotIn instead of assertIn for positive case. Confirmed with Ezio that issue #7330 will need to be fixed/approved before this issue can be closed. -- Added file: http://bugs.python.org/file28267/issue13349.patch.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13349 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7330] PyUnicode_FromFormat: implement width and precision for %s, %S, %R, %V, %U, %A
Changes by Sean Ochoa sean.m.oc...@gmail.com: -- nosy: +Sean.Ochoa ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7330 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13349] Non-informative error message in index() and remove() functions
Sean Ochoa added the comment: Lib/test/test_array.py -- Moved index test (for this issue) to test_index (existing test method). -- Added remove test (for this issue) to test_remove (existing test method) Lib/test/test_deque.py -- Moved remove test (for this issue) to test_index (existing test method). Lib/test/test_list.py -- Added test_remove instead of test_issue13349, and test_index as a new test method; both with positive tests and a negative test to for this issue. Lib/test/test_tuple.py -- Added test_remove instead of test_issue13349 as a new test method with a positive test and a negative test case for this issue to cover both items longer than 100chars and shorter items. Lib/test/test_xml_etree.py -- Added test_remove as a new test method to TreeBasicOperationTest testcase class instead of test_issue13349, with a positive test case and the negative test to cover this issue. -- Added file: http://bugs.python.org/file27975/issue13349.patch.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13349 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13349] Non-informative error message in index() and remove() functions
Sean Ochoa added the comment: Updates after feedback from Serhiy. -- Added file: http://bugs.python.org/file27949/issue13349.patch.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13349 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13349] Non-informative error message in index() and remove() functions
Sean Ochoa added the comment: Truncating repr strings to 100chars will require the patch from #7330. After applying the patch from that issue, my tests work fine. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13349 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13349] Non-informative error message in index() and remove() functions
Sean Ochoa added the comment: Updated patch after taking into account Ezio's (aka Taggnostr on #python-dev) latest feedback. -- Added file: http://bugs.python.org/file27940/issue13349.patch.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13349 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13349] Non-informative error message in index() and remove() functions
Sean Ochoa added the comment: From Taggnostr on #python-dev: 1.) Use assertRaises+assertIn instead of assertRaisesRegex 2.) Add or change an existing test that you've already updated to use elements with a repr longer than 100 chars. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13349 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13349] Non-informative error message in index() and remove() functions
Sean Ochoa added the comment: Tests updated for coverage and to use assertRaisesRegex. -- Added file: http://bugs.python.org/file27907/issue13349.patch.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13349 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13349] Non-informative error message in index() and remove() functions
Sean Ochoa added the comment: After discussing with folks on the #python-dev tonight, I learned that I was testing with a list and I should've been using a set. I'm working on a patch now, and I'm almost ready to have it reviewed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13349 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13349] Non-informative error message in index() and remove() functions
Sean Ochoa added the comment: Ready for review. -- keywords: +patch Added file: http://bugs.python.org/file27884/issue-13349.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13349 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13349] Non-informative error message in index() and remove() functions
Sean Ochoa added the comment: Working on issue as part of Python Bug Day, Oct 2012. -- nosy: +Sean.Ochoa ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13349 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13349] Non-informative error message in index() and remove() functions
Sean Ochoa added the comment: It seems that this has been fixed. Using simple tests from msg147215: ~/hg/cpython/working $ env-py3.3/bin/python Python 3.3.0 (default, Nov 3 2012, 15:28:29) [GCC 4.7.2] on linux Type help, copyright, credits or license for more information. [].index(list(range(1000))) Traceback (most recent call last): File stdin, line 1, in module ValueError: [0, 1, 2, 3, 4, 5, ... 995, 996, 997, 998, 999] is not in list [60649 refs] class Foo: pass ... [60679 refs] [].index(Foo()) Traceback (most recent call last): File stdin, line 1, in module ValueError: __main__.Foo object at 0x7f7fad31bc30 is not in list [60677 refs] -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13349 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
