New submission from Senthil Kumaran :
When pushed a change to 2.5 branch, I got an error, which I think has
to do with buildbot not available for 2.5 codeline.
It asked me to notify the tracker and here it is.
remote: state = method(*args, **kw)
remote: File "/data/buildbot/m
Senthil Kumaran added the comment:
Fixed in all the relevant code lines.
--
assignee: -> orsenthil
priority: release blocker ->
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python
Senthil Kumaran added the comment:
Fixed in 3.3 and 3.2.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
On Thu, Mar 17, 2011 at 05:15:09PM +, Skip Montanaro wrote:
> Should you be pushing anything to 2.5?
I think, there is a security release planned in 2011.
Also, see issue11442 which was the specific case for pushing to
Senthil Kumaran added the comment:
On Thu, Mar 17, 2011 at 05:16:43PM +, Skip Montanaro wrote:
> See Issue 11439.
Yes, that is relevant and applies probably to code in default and
other branches.
Just in case, this corner case in 2.5 does not overlooked (because it
does not happen in ot
Senthil Kumaran added the comment:
issue11442 is a security issue and I pushed to 2.5 for fixing that and
encountered this problem with buildbot. I think, we may/may not fix
this (buildbot issue) depending upon when the 2.5 release may be
planned
Changes by Senthil Kumaran :
--
nosy: +loewis
___
Python tracker
<http://bugs.python.org/issue11581>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue10486>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue8450>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue10860>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue8704>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
On Thu, Mar 17, 2011 at 06:30:51PM +, Jeff McNeil wrote:
> I went down the same path as AbstractHTTPHandler and added a Connection:
> close header.
This is fine for the moment, tough I wish that the TODO pending in
urllib.request with H
Senthil Kumaran added the comment:
Why should we have this file served on the web itself? Cannot it be on server
outside of www ( or any directory which is getting served). I would vote for
this.
--
nosy: +orsenthil
___
Python tracker
<h
Senthil Kumaran added the comment:
David, from you message I understand that Martin is planning to
release 2.5 via svn. If that is the case, whatever was pushed for
security fix to hg can remain as such and so that those can be
exported to svn.
The bugs related to buildbot and svn keyword
Senthil Kumaran added the comment:
Significant patch. Thanks. I looked at the review too. For the
Context Manager part, don't club it along with this one. We need to
test this thoroughly, after this is in shape, that can be addressed.
--
___
P
Senthil Kumaran added the comment:
Changing the description is a minor update. The term 'URL access module' seems
fine.
--
___
Python tracker
<http://bugs.python.o
Senthil Kumaran added the comment:
Since the reporter did not get back with more details (testing against curl or
a HEAD output to eliminate server issues), I am closing this issue.
--
resolution: -> invalid
status: pending -> closed
___
Senthil Kumaran added the comment:
Buildbots pass the tests again.
--
priority: release blocker ->
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue9740>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue3566>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
Victor - Issue9740 and Issue3566 talks about the need to have persistent
connection. 3.3 would be a good target to have this feature in.
Shall add the NEWS entry.
Nadeen Wadwa - Thanks for your patch. I committed the fix as part of another
bug (Issue3566
Changes by Senthil Kumaran :
--
Removed message: http://bugs.python.org/msg131456
___
Python tracker
<http://bugs.python.org/issue11563>
___
___
Python-bugs-list m
Senthil Kumaran added the comment:
Victor - Issue9740 and Issue3566 talks about the need to have persistent
connection. 3.3 would be a good target to have this feature in.
Shall add the NEWS entry.
Nadeem Vawda - Thanks for your patch. I committed the fix as part of another
bug (Issue3566
Senthil Kumaran added the comment:
I saw the partial fix suggested by the patch, but for some reason I
did not see ResourceWarning being shutup. Let's look at this again.
The warnings are all from the (old) ftp portion of the code..
--
___
P
Senthil Kumaran added the comment:
Ezio Melotti wrote:
> This is just nitpicking, but serving XHTML as text/html is wrong.
While, I thought this statement is correct and expected the Internet
media-type should be something else (application/xhtml+xml), but as
per w3c, it is not wrong
Senthil Kumaran added the comment:
Thanks again.
Agree to use of returning the block size to the returnhook callable.
But this is going be a deviation from the existing behavior which was
present to inform the user at regular intervals and did not bother to
provide any 'progressive
Senthil Kumaran added the comment:
Antoine Pitrou wrote:
> Can you clarify the issue?
URLopener which is an old class from the merge of urllib and urllib2
and it can be slowly and safely removed. If we go this line, then I
assume it has to have a DeprecationWarning before we remove it. Sho
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue4492>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
How about the patch attached in the issue11579
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue11
Senthil Kumaran added the comment:
No, it is not waiting for you, in fact it is waiting for me to commit
the portion which you have already contributed with some additional
code (DeprecationWarning).
But this bug does not end up here as there are other primitives which
may need cleanup and
Senthil Kumaran added the comment:
Yes, interesting that Content-Length is returned as a comma separated value of
ints.
Normally, this behavior is observed for other headers which can have multiple
values and urllib appends the subsequent values of the header for e.g.
Content-Type header
Senthil Kumaran added the comment:
Yes, this is good enough for a non-standard behavior.
However, I would be curious to know what curl did. Did it do something
on based on the value or sequence in which it was obtained or just
over-wrote it.
--
title: urlib{,2} returns a pair of
Senthil Kumaran added the comment:
Agree to removing of termios.ISIG so that we get a KeyBoardInterrupt exception
raised when CNTL-C is pressed. Looking at discussion more carefully, it does
not present any security risk.
Should this be fixed in 3.3 only with NEWS detailing the change in
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue11466>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
>> HTTPRedirectHandler behaviour can be changed
>> to only allow redirects to HTTP, HTTPS and FTP by checking the scheme
>> of the location URL (this seems to be a common practise in browsers)
This would be the way to go.
-
Senthil Kumaran added the comment:
>> why doesn't it have a "review" link?
Perhaps, as it is not against the 'default'?
Let's try my hg sandbox link which has a fix committed. Let's see if it gives
the review link.
--
hgrepos: +7
_
Changes by Senthil Kumaran :
Added file: http://bugs.python.org/file21374/c6a4d267fe88.diff
___
Python tracker
<http://bugs.python.org/issue11662>
___
___
Python-bug
Changes by Senthil Kumaran :
Added file: http://bugs.python.org/file21376/3c07ea6a176a.diff
___
Python tracker
<http://bugs.python.org/issue11662>
___
___
Python-bug
Senthil Kumaran added the comment:
Here is a more complete patch with tests. Please review this. Yes, it is
against the default branch (3.x codeline). We can backport this behavior to 2.x
codeline.
I have raised an URLError exception when the direct to invalid_schemes is
detected.
Also
Senthil Kumaran added the comment:
On Thu, Mar 24, 2011 at 05:32:42PM +, Guido van Rossum wrote:
> I still don't think we should raise URLError on the bad redirect; we
> should treat it the same as a missing URI/Location header, and it
> will raise HTTPError.
Agreed.
Changes by Senthil Kumaran :
Added file: http://bugs.python.org/file21388/ff71c4416cde.diff
___
Python tracker
<http://bugs.python.org/issue11662>
___
___
Python-bug
Senthil Kumaran added the comment:
+1 to removing of the spurious egg-info files. For the folks who are not aware
of the multitude 'packaging terms', egg-info files are the first step towards
the path leading to more confusion.
So cleaning up would be definitely better in th
+1 to the counter argument that "Unexpected Skips should not be marked as
failures".
Also, I like the following proposal of giving better messages on skips
useful.
On Sat, Mar 26, 2011 at 07:53:34AM +, Ezio Melotti wrote:
> It's also possible to provide better skip messages, e.g.:
> -test_wi
Senthil Kumaran added the comment:
I wonder if this is CentOS and RHEL specific. Unable to reproduce this on
Ubuntu.
--
nosy: +dmalcolm, orsenthil
___
Python tracker
<http://bugs.python.org/issue10
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue11736>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Fixed it in relevant branches. I had to add condition around the test to verify
that platform was win because this is unique to windows only. Thanks.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Senthil Kumaran added the comment:
Just for the explaination (as the report already closed), getheaders of
HTTPMessage object is available by subclassing all the way from rfc822.py
module. If you trace it through the debugger, you will come to know
Senthil Kumaran added the comment:
We need not base changes to html/parser.py on html5 spec, but rather make
changes based on the requirements on parsers which may rely on this library.
Like the tolerant mode was brought in issue1486713 for some practical reasons
and it was seen useful tor
Senthil Kumaran added the comment:
> So is the issue7311-3.diff patch fine?
Just that it allows unquoted attrs for unicode too.
My previous suggestion was not to allow unquoted attribute values, but as the
change is already made in 2.7 and discussion pointed out a portion in 4.1 spec
wh
Senthil Kumaran added the comment:
With the patch there is a new exception with specific msg being raised in
certain cases, so this may only pertain to 3.3
--
assignee: -> orsenthil
nosy: +orsenthil
versions: -Python 3.2
___
Python tracker
&l
Senthil Kumaran added the comment:
It should be noted that the bug surfaced in 2.7 and above due to changes made
as part of Issue8280.
--
assignee: -> orsenthil
resolution: -> fixed
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
This is fixed in all the codelines. Thanks for the patch, Santoso.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
Fixed in all the codelines. Thanks for the patch, Santoso.
--
assignee: -> orsenthil
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue11710>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
It is better to close this issue as it was a Server Error. Standard just says
that when there two headers with different values, combine them comma separated
as urllib2 does. Making special case exception for 'Content-Length' header
when the se
Senthil Kumaran added the comment:
Fixed this in all codelines. Thanks Santoso.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
What would be a 'meaning' __str__ or __unicode__ of urlparse.urlparse and how
would it be useful to you?
I would think that people would except a tuple, list or a ParsedResult for such
a call.
I cannot understand the rational behind the expect
Senthil Kumaran added the comment:
Tomasz,
I think, you misunderstood the purpose of urlparse library. urlparse is for
parsing the URL and into its components. The url could be a mailto:, svn+ssh or
http,https. The requirement for parsing comes when you are designing systems
which take up
Changes by Senthil Kumaran :
--
status: closed -> open
___
Python tracker
<http://bugs.python.org/issue4608>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
I have made the changes in 3.3,3.2,3.1 and 2.7 codeline. The behavior is
aligned with the 2.5 (and earlier) behaviors. I cannot change this 2.6 because
this is not a security issue to be back-ported. (rather it was misinterpreted
problem and resulted in
Senthil Kumaran added the comment:
Updated the NEWS entry.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue11236>
___
___
Python-
Senthil Kumaran added the comment:
Scott- which platform did you observe this? I can't reproduce this on the 2.7
code on Linux.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/is
Senthil Kumaran added the comment:
I had tried/tested against 3.x branch and did not find the problem. Later
realized that it was only again 2.7. Pushed in the changes and the tests. I
shall the tests only in 3.x codeline.
--
___
Python tracker
Senthil Kumaran added the comment:
Éric, ParseResult is a class which provides tuple for urlparse/unparse. People
should hardly (/never) use ParseResult directly. The original poster's concern
was to get something like geturl() from this class which was not suitable and
it shou
Senthil Kumaran added the comment:
Sijin, please go ahead and submit a patch. No one is working on this at the
moment.
--
nosy: +markm
___
Python tracker
<http://bugs.python.org/issue9
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue11943>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
I had wrapped skipUnless decorator for the wrong test (test_extractall
instead of test_extractall_symlinks) in the 3.x code. Corrected it
and waiting for next bb reports.
Thank you.
--
___
Python tracker
<h
Senthil Kumaran added the comment:
buildbots are green again.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue10761>
___
___
Python-
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue10946>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Hello Bernhard,
I tried to a POST of JPEG file, through urllib2 (which internally uses httplib)
and goes through the code that you pointed out and I don't face any problem. I
am able to POST binaries using httplib.
I am also surpris
Senthil Kumaran added the comment:
Added the flush_headers method and the test function. this issue can be closed
now. Thanks, Andrew Schaaf.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
I could reproduce the BadStatusLine exception using Vinay's server_test.py. I
see that the exception is triggered by logging package when it is trying to
http.client's getresponse() before it is ready. The previous commit
25298224cb25 was on h
Senthil Kumaran added the comment:
On Tue, May 10, 2011 at 09:12:58AM +, Vinay Sajip wrote:
> Either omitting the end_headers() call was always an error but
> previously undetected, or the requirement to always call
> end_headers() is new and this should be documented. I'm no
Senthil Kumaran added the comment:
On Tue, May 10, 2011 at 02:06:48PM +, Vinay Sajip wrote:
> @Senthil - are you planning to make the documentation change, or should I?
I shall do it, Vinay.
Thanks!
--
___
Python tracker
&l
Senthil Kumaran added the comment:
Hi Vinay,
Normally, when one uses send_response() call, it is most often followed with
(multiple) send_header() calls and I updated the documentation keeping that in
mind.
Just calling of send_response() without any send_header and end_headers was an
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
The bug was about sending Binary "data" via httplib. In the example you
wrote, you are sending a unicode "url" and experiencing a failure for
certain examples.
In the 2.7, the urls should be str type, we don't have function to
deal wi
Senthil Kumaran added the comment:
I looked at your message and the patch, seems okay for the case of testing if
the symlink is broken and performing the next steps. I shall commit it soon.
--
assignee: -> orsenthil
nosy: +orsenthil
___
Pyt
Senthil Kumaran added the comment:
Committed the fix. Thank you, Scott.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue11197>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
neologix, that is right. Importing uuid before importing the other modules does
not result in Seg Fault. Till the libc fix is available in Operating systems
and as a result in CPython, this is probably the only way to go for.
--
nosy: +orsenthil
Senthil Kumaran added the comment:
hello wrobell , I see that issue3754 has patches for more recent line of code
and issue 1597850 is related too. Would you like to test the patches in there?
If successful, this feature can be pushed further (and considered) for
inclusion.
--
nosy
Senthil Kumaran added the comment:
Code compatibility wise there is not much difference between Python3.2
and Python3.3. So you can do it for Python3.2 (in a bitbucket cpython
branch) and it is found stable, there are good chances that it will be
can be made in Python3.3 and future. I don&#
Senthil Kumaran added the comment:
Hi Ezio, the connection can be closed via the finally call as you do in the
patch. There are times when request object is re-used, but before the
connection is made. It may also help to understand how the code in the
packaging was invoking it.
If you run
Senthil Kumaran added the comment:
Fixed in r86514 (py3k) and r86515 (release31-maint).
--
assignee: -> orsenthil
resolution: -> fixed
stage: -> committed/rejected
___
Python tracker
<http://bugs.python.o
Changes by Senthil Kumaran :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue9991>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
Fixed in r86520 (py3k) and r86522 (release31-maint).
unquote happens at the first level inside Request class, _parse method.
Shall port to py2.7.
--
nosy: -BreamoreBoy
resolution: -> fixed
stage: patch review -> committed/re
Senthil Kumaran added the comment:
r86523(py3k) and r86524(release31-maint)
--
___
Python tracker
<http://bugs.python.org/issue9991>
___
___
Python-bugs-list m
Senthil Kumaran added the comment:
back-ported to release27-maint in r86554.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
I have doubts on the validity of this bug itself.
- First is, query and fragment are usually for the file being served from the
webserver, not on the directories. If there are characters such as '?' and '#'
in the directory names, which
Senthil Kumaran added the comment:
Fixed in r86580 (py3k), r86581 and r86582.
--
components: +Library (Lib)
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
BaseHTTPServer documentation explains that "Usually, this module isn’t used
directly, but is used as a basis for building functioning Web servers". Methods
are usually subclassed with desirable behaviors customized.
If you are using SocketServ
Senthil Kumaran added the comment:
What should it do? OP expected that it print the redirected url. I don't think
that's helpful by setting max_redirections to 0, when it can be achieved in
other ways.
Also, max_redirections is not exposed (as a parameter or arg) or a documented,
Senthil Kumaran added the comment:
On Sat, Nov 20, 2010 at 07:09:58PM +, Jeremy Thurgood wrote:
> There are two separate things here: the URL and the filesystem path.
> The bug is that the fragment and query parameters are stripped in
> translate_path(), but are *not* stri
Senthil Kumaran added the comment:
Fixed this revision 86640.
- Even though this is an internal optimization,I don't think back-porting is a
good idea, because it changes the behavior of certain methods like send_header
and end_headers
- Added the Documentation and other test scenario
Senthil Kumaran added the comment:
On Sun, Nov 21, 2010 at 12:12:08PM +, Jeremy Thurgood wrote:
> I see your point now, but I don't agree with it completely. It seems
> reasonable to allow query parameters to specify things like sort
> order for a directory listing or have
Senthil Kumaran added the comment:
On Sun, Nov 21, 2010 at 03:15:06PM +, R. David Murray wrote:
> Senthil, I didn't clearly express my concern about
> send_response_only. It doesn't look to me like, with buffering in
> place, that it *should* write directly, it looks to
Senthil Kumaran added the comment:
Fixed it in r86676 (py3k), r86677 ( release31-maint) and
r86678(release27-maint).
Wes: I fixed it at the much higher level in the urlparse itself, so that the
fixed url is sent to the httplib.
In issue2464, John had pointed out that according to STD 66
301 - 400 of 1788 matches
Mail list logo
