Serhiy Storchaka added the comment:
Sorry, I have not noticed your advice before I did commit (it took me a lot of
time). Should I now revert my changes to 2.7, 3.2 and 3.3?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Serhiy Storchaka added the comment:
This heapq.heappop does applied to a copy of self._queue. Copying done under a
lock.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16640
Serhiy Storchaka added the comment:
Serhiy: can you clarify this remark? Where do you see the OverflowError?
The current exception and message look fine to me, so maybe I'm
misunderstanding what you're talking about:
Sorry, I have been confused (and confuse you) by the variety of PyLong_As
Serhiy Storchaka added the comment:
Perhaps it was inherited from Python 2.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16640
___
___
Python
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +chris.jerdonek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16165
___
___
Python-bugs
Serhiy Storchaka added the comment:
Sorry, Chris.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16645
___
___
Python-bugs-list mailing list
Serhiy Storchaka added the comment:
Sorry, Chris. I have opened too many browser tabs. ;)
--
nosy: -chris.jerdonek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16165
Serhiy Storchaka added the comment:
What anyone can say about this doc changes?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16642
Serhiy Storchaka added the comment:
And if os.open were supplied in os.py:
@inspect.override_string_representation('mode',
'os.O_CREAT | os.O_RDWR')
def open(file, flags, mode=0o777, *, dir_fd=None):
Other use case is a sentinel default. foo(arg={}) looks better than
foo
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16809
___
___
Python
Serhiy Storchaka added the comment:
See also issue16074.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16812
Serhiy Storchaka added the comment:
See also issue16074.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13775
Serhiy Storchaka added the comment:
As I see, now 3.4 behavior differs from 3.3 behavior.
os.link('non-existent-name', 'new-name')
Traceback (most recent call last):
File stdin, line 1, in module
FileNotFoundError: [Errno 2] No such file or directory: 'non-existent-name'
os.symlink('long
Serhiy Storchaka added the comment:
I don't see a difference.
$ ./python -c 'import time; print(time.localtime())'
time.struct_time(tm_year=2012, tm_mon=12, tm_mday=29, tm_hour=19, tm_min=36,
tm_sec=35, tm_wday=5, tm_yday=364, tm_isdst=0)
$ ./python -c 'import datetime; print
Serhiy Storchaka added the comment:
pydoc could recognize this (if docstring.startswith(func.__name__ + '(') or
something like that), and display the given signature instead of the
introspected one.
Looks good for me.
--
___
Python tracker rep
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16642
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16641
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16165
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16640
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - works for me
stage: patch review - committed/rejected
status: open - closed
versions: +Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16485
Serhiy Storchaka added the comment:
I have added the test that the file was actually closed using external file (as
in test_close()).
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: works for me - fixed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16485
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16694
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16320
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12004
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16688
Serhiy Storchaka added the comment:
Fixed. Thank you for a patch, Matthew. I hope to see more your patches.
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15861
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16686
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16550
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16601
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16659
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16674
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11159
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16638
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16624
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16630
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16569
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11344
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15989
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9720
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8745
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15490
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10395
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6975
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15999
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6083
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16061
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15475
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13968
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15696
Serhiy Storchaka added the comment:
Same for u'' on 2.7. Completion list doesn't contain isdecimal and
isnumeric.
--
assignee: - serhiy.storchaka
nosy: +serhiy.storchaka
versions: +Python 2.7, Python 3.2, Python 3.3, Python 3.4
___
Python tracker
Serhiy Storchaka added the comment:
Here is a patch which fixes this issue. It is applicable for all version,
except uU can be removed from string of string prefix characters in 3.2.
--
nosy: +kbk
stage: - patch review
___
Python tracker rep
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file28491/idle_bytes_completion.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16819
Serhiy Storchaka added the comment:
Alexey, as I see, you have missed some Antoine's comments (and my comments
about whitespaces). Please, be more careful.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14373
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +serhiy.storchaka
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16741
Changes by Serhiy Storchaka storch...@gmail.com:
--
Removed message: http://bugs.python.org/msg178416
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16645
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16645
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: patch review - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1470548
Serhiy Storchaka added the comment:
Have you reviewed the patch? Is it good?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15861
___
___
Python
Serhiy Storchaka added the comment:
Catalin, are you going to continue?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8745
___
___
Python-bugs
Serhiy Storchaka added the comment:
What variant of patches should I commit? Or prepare other?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9720
Serhiy Storchaka added the comment:
I going speed up other cases for replace(), but for now I have only this patch.
Is it good? Should I apply it to 3.3 as there is a 3.3 regression?
--
keywords: +3.3regression
___
Python tracker rep
Serhiy Storchaka added the comment:
This is definitely non-trivial. 1-argument int() works with UserString because
__int__() method is defined for UserString (as __float__(), as __complex__()).
I.e. UserString looks as number-like for it. Unfortunately there is no way to
make a class
Serhiy Storchaka added the comment:
Please review. This function is very important for many applications (and it
hard to get right).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11344
Serhiy Storchaka added the comment:
As __ap__ says, it would be nice to have a comment.
Oh, I thought I had already done this.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16061
Serhiy Storchaka added the comment:
Antoine, how about this mosquito?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6975
___
___
Python-bugs
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16824
Serhiy Storchaka added the comment:
Fixed. Thank you, Stefan. I will be glad to see new bugs which you will found
with Cython.
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
type: compile error - behavior
___
Python
Serhiy Storchaka added the comment:
The fileno parameter was added in the changeset 8e062e572ea4. It was mentioned
in comments at the top of Modules/socketmodule.c, but not in the documentation
or docstrings (nor for _socket.socket, nor for socket.socket).
--
assignee: - docs@python
Serhiy Storchaka added the comment:
The cleanup of BYTESTR_DEPS and UNICODE_DEPS seems reasonable, but can you
explain the rationale behind removing the additional dependencies on
formatter_unicode.c?
This question already was asked by Antoine on IRC.
Because now Python/formatter_unicode.c
Serhiy Storchaka added the comment:
str_replace_1char.patch: why not implementing replace_1char_inplace() in
stringlib, with one version per character type (UCS1, UCS2, UCS4)?
Because there are no benefits to do it. All three versions (UCS1, UCS2, and
UCS4) have no any common code. The best
Serhiy Storchaka added the comment:
It has at least one potential use. On Windows socket.detach() returns a
socket handle but there is no documented way to close it -- os.close()
will not work. The only way to close it that I can see (without resorting
to ctypes) is with something like
Serhiy Storchaka added the comment:
I don't want to make a decision on the inclusion of this code. However, I will
undertake to maintain it. I'm going to fix one algorithmic bug in current
implementation and add C implementations for some methods which significantly
slowed in Python
Serhiy Storchaka added the comment:
There is one additional benefit. I have already implemented audioop module in
Python, and due to this it has found many bugs in the current C implementation
(issue16686).
--
___
Python tracker rep
Serhiy Storchaka added the comment:
Indeed. In any case, if this idiom is widely used, we can't hide this parameter
and should document it (and perhaps document this idiom).
If BDFL not want this parameter was made public, he would not have added it as
an keyword argument. However, may
Serhiy Storchaka added the comment:
This was fixed in 3.3 (the complex solution is not backportable), therefore
this is 3.2 only issue.
--
nosy: +haypo, serhiy.storchaka
stage: - patch review
versions: -Python 3.1
___
Python tracker rep
Serhiy Storchaka added the comment:
This was fixed in 3.3 (the complex solution is not backportable), therefore
this is 3.2 only issue.
--
nosy: +haypo, serhiy.storchaka
stage: - patch review
versions: -Python 3.1
___
Python tracker rep
Serhiy Storchaka added the comment:
At first sight the patch looks good, but test needed.
--
stage: patch review - test needed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9644
Serhiy Storchaka added the comment:
Please provide a full patch, doesn't split it on parts which should be applied
one over other. Test needed.
--
stage: patch review - test needed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Serhiy Storchaka added the comment:
This was implemented in issue11939 for Python 3.4 only.
--
nosy: +brian.curtin, serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10657
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: - patch review
versions: -Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16828
Serhiy Storchaka added the comment:
New changeset 3738d270c54a by Brian Curtin in branch 'default':
st_dev/st_rdev should be unsigned long as dwVolumeSerialNumber, which it is
set to, is a DWORD. This was fixed in #11939 and the overflow was
mentioned in #10657 and seen by me on some
Serhiy Storchaka added the comment:
I don't install Tcl/Tk 8.6 yet, but looks as pack info call returns a new
type of Tcl data (perhaps DictType) which doesn't detected in FromObj().
--
___
Python tracker rep...@bugs.python.org
http
Serhiy Storchaka added the comment:
Now the code is wrong on non-Windows without PY_LONG_LONG and with signed
st_dev.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11939
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16819
Serhiy Storchaka added the comment:
The simplest fix probably is just wrap self.tk.call() with str() (I have not
tested it yet). However the problem is more serious (tkinter doesn't support
fully even 8.5 and subtle bugs are possible) and I'll spend some more time on
its research
Serhiy Storchaka added the comment:
I'll wait for some time, perhaps a Christian wants to say something.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16320
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16541
Serhiy Storchaka added the comment:
But then will be problems with filenames containing .
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16829
Serhiy Storchaka added the comment:
Patch updated for current tip.
--
Added file: http://bugs.python.org/file28527/glob_recursive_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13968
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13968
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file28213/glob_recursive.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13968
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16761
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: patch review - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16630
Serhiy Storchaka added the comment:
v8 LGTM (except some trailing whitespaces).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16694
New submission from Serhiy Storchaka:
A long time Tcl got support first 64-bit integers, and then arbitrary size
integers. Python also supports arbitrary size integers. However Tkinter
supports only C long integers. For example, on 32-bit platform:
import tkinter
t = tkinter.Tk()
t.tk.call
New submission from Serhiy Storchaka:
st_dev field of stat() result was set as signed long or long long, but now it
is unsigned long on Windows (see issue11939). The proposed patch uses
appropriate conversion for it.
--
components: Extension Modules, Windows
files
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16841
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15239
301 - 400 of 25750 matches
Mail list logo
