Serhiy Storchaka added the comment:
Georg, now Tools/unicode/mkstringprep.py is broken in all Python 3 branches (it
not usable at all, under 3.2 it even raises SyntaxError). Do you object against
fixing it in 3.2 and 3.3?
--
nosy: +georg.brandl
Serhiy Storchaka added the comment:
If no one objects I will commit this next week.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13454
Serhiy Storchaka added the comment:
If no one objects I will commit this next week.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6975
Serhiy Storchaka added the comment:
OK. Perhaps I will prepare similar patches for ntpath and macpath.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6975
Serhiy Storchaka added the comment:
PyObject_CallMethodObjArgs takes a PyObject*, mustn't that be non-const for
reference counting to work?
Then refcounts.dat wrong.
PyDict_GetItemString already has const, just not in refcounts.dat. Fixed.
There are a lot of char* arguments
Serhiy Storchaka added the comment:
Can you please provide an example of data for which the tostring method fails?
I can't reproduce this on simple data.
import xml.etree.ElementTree as ET
ET.tostring(ET.XML('rootbq/bwerty/root'), method='text',
encoding='unicode')
'qwerty
Serhiy Storchaka added the comment:
I found such example. It happens when the data contains XML entity.
ET.tostring(ET.XML('rootaamp;/root'), method='text',
encoding='unicode')
Traceback (most recent call last):
File stdin, line 1, in module
File /home/serhiy/py/cpython/Lib/xml/etree
Serhiy Storchaka added the comment:
Here is a patch for 3.3+. 2.7 and 3.2 are not affected.
--
keywords: +patch
stage: needs patch - patch review
versions: +Python 3.4
Added file: http://bugs.python.org/file28666/etree_itertext.patch
___
Python
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15948
Serhiy Storchaka added the comment:
For better syntax error messages see issue1634034.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16917
Serhiy Storchaka added the comment:
Patch rewritten using recursion. Non-recursive version is not stack limited
(and a little faster), but recursive version is perhaps more understandable.
Some comments added.
--
Added file: http://bugs.python.org/file28672/posix_realpath_2.patch
Serhiy Storchaka added the comment:
dict(a = i for i in range(10))
+SyntaxError: invalid syntax - ')' expected
The () are ok, the message is misleading.
dict(a = i) is valid syntax, the compiler expects ) instead of invalid
for.
'name' here is a bit vague.
The compiler
Serhiy Storchaka added the comment:
Serhiy, I see you assigned this to yourself - would you like to submit a
patch?
Not right now. This is low priority for me too. But I want to see this feature
in 3.4.
--
___
Python tracker rep
New submission from Serhiy Storchaka:
import xml.etree.cElementTree as ET
ET.XML('rootempty //root').findtext('empty')
b''
--
components: XML
files: etree_finditer_empty.patch
keywords: patch
messages: 179580
nosy: eli.bendersky, serhiy.storchaka
priority: normal
severity: normal
Serhiy Storchaka added the comment:
I see yet one possible bug, using PyBytes_FromString() in list_join() on 3.2.
But I can't demonstrate an example.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16922
Serhiy Storchaka added the comment:
Some general notes. Nitpick: check foo() 0 is more used than foo() == 0. An
exception raised after failed close() can hide original exception raised
before. I left more specific comments on Rietveld.
Only a small part of the proposed changes may
Serhiy Storchaka added the comment:
Well, here is a patch which add short_empty_elements flag (as for XMLGenerator)
to write(), tostring() and tostringlist() methods of ElementTree.
--
stage: needs patch - patch review
___
Python tracker rep
Serhiy Storchaka added the comment:
Oh, I forgot press Push All My Drafts button.
Actually only patch for _cursesmodule.c looks safe at first glance (but curses
maintainer can decide better). You can split the patch on several patches, but
be very careful. You should research the entire
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file28678/etree_short_empty_elements.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14377
Serhiy Storchaka added the comment:
For poll() see issue8865.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16929
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +select.poll is not thread safe
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16929
Serhiy Storchaka added the comment:
Also, is it right to raise an exception in case of concurrent invocation?
It is right for poll() because it was not concurrently usable in previous
versions in any case. For epoll() it is an another issue
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15539
Serhiy Storchaka added the comment:
Here is a dirty patch which hacks unittest to search possible test overriding.
Just apply the patch and run regression tests.
--
Added file: http://bugs.python.org/file28689/checkTestOverriding.diff
___
Python
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file28690/test_overriding.txt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16748
Serhiy Storchaka added the comment:
Here is a patch which should fix creating a backup on Windows. Please test it.
If test_tools passes on Windows then I'll commit the patch, in contrary case
I'll just skip checking of backup on Windows.
--
stage: committed/rejected - patch review
Serhiy Storchaka added the comment:
I agree, the main problem is in the fact that expected token is not always
singular. And even most expected token is a little subjective. The better
solution will be to expect several possible tokens. This requires some parser
modification
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +amaury.forgeotdarc, belopolsky, meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16934
Serhiy Storchaka added the comment:
It is not so easy. The problem is that we have to determine the print command
by configuration line. A user may wish to change these settings, and some users
already changed them. The patch should not break them. For backward
compatibility we also have
Serhiy Storchaka added the comment:
Hmm, expected attribute is set when there is only one possible expected token
in PyParser_AddToken(). I don't understand why error messages are so misleading
for def f(*23): (here not only ')', but a name possible
Serhiy Storchaka added the comment:
At least one who want print filenames on non-default printer must edit that
line. In any case we can't break this in a bugfix release.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16829
Serhiy Storchaka added the comment:
Zack, can you please resend your agreement by email?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16624
Serhiy Storchaka added the comment:
Ben, can you please resend your agreement?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12004
Serhiy Storchaka added the comment:
I hope it will help buidbots.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15539
___
___
Python-bugs-list
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: patch review - commit review
type: behavior - enhancement
versions: -Python 2.7, Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4350
Changes by Serhiy Storchaka storch...@gmail.com:
--
components: +Tkinter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4350
___
___
Python-bugs
Serhiy Storchaka added the comment:
But all findtext tests are doctests and I want to keep the tests together. I
think there should be separated issue for converting ElementTree doctests to
unittests.
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
No surrounding %%s with quotes, nor changing to %%r doesn't work in all cases,
because Python and shell use different quoting schemas. The only solution is
using shlex.quote (which available only since 3.3). But even in this case we
should be careful
Serhiy Storchaka added the comment:
I have committed a very simple fix with shlex.quote (pipes.quote before 3.3).
This is not fully backward compatible, it can break user configuration if the
user had fixed this issue himself (and this fix is not perfect). But I
think it's quite unlikely
Serhiy Storchaka added the comment:
Here is a patch for 3.3+.
--
Added file: http://bugs.python.org/file28708/etree_finditer_empty-3.3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16922
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15539
Serhiy Storchaka added the comment:
Michael Birtwell, can you please submit a contributor form?
http://python.org/psf/contrib/contrib-form/
http://python.org/psf/contrib/
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16601
Serhiy Storchaka added the comment:
Why only 2.7 and 3.4?
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16398
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file28675/etree_finditer_empty-3.2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16922
Serhiy Storchaka added the comment:
Indeed. Patch updated.
--
Added file: http://bugs.python.org/file28711/etree_finditer_empty-3.2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16922
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file28268/sax_unicode_fn-2.7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11159
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file28268/sax_unicode_fn-2.7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11159
Serhiy Storchaka added the comment:
Ported tests for nonascii System-Id on 3.x.
If no one objects I'll commit this next week.
--
Added file: http://bugs.python.org/file28714/sax_unicode_fn-3.x.patch
___
Python tracker rep...@bugs.python.org
http
Serhiy Storchaka added the comment:
Patch updated (tostring() and tostringlist() refet to write() about
short_empty_elements parameter). Perhaps descriptions of encoding and method
parameters should not be repeated too?
Why do you force short_empty_elements to be keyword only?
Because
Serhiy Storchaka added the comment:
See also issue16535. I doubt that json should support decimals in this manner,
with special boolean parameter instead of general fabric function. Current
simlejson has too many special parameters.
--
nosy: +serhiy.storchaka
New submission from Serhiy Storchaka:
Perhaps almost all Doxygen comments in ElementTree module should be converted
to docstrings.
--
assignee: docs@python
components: Documentation, XML
messages: 179881
nosy: docs@python, eli.bendersky, serhiy.storchaka
priority: normal
severity
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1159051
Serhiy Storchaka added the comment:
I think Éric means different spaces, spaces in empty tags (empty / vs
empty/). I don't know what the standard says about this. It should a
separated issue.
As for line continuations in docs, in all cases where they are occurred, a
space used before
Serhiy Storchaka added the comment:
I don't really understand your algorithm. Why do you need a stack?
Before resolving the symlink we mark the path as unresolved symlink for
detecting infinite symlink loops. Before resolving the symlink we mark the path
as resolved symlink (and cache
Serhiy Storchaka added the comment:
Yes, this thing was doubted me too. I proceeded from the following
considerations.
1. Often system id is used for file operations and in this case you need to use
the file system encoding. Unfortunately Python 2 does not have
'surrogateescape' handler
Serhiy Storchaka added the comment:
Here is an alternative patch. It doesn't encode system id when it settled,
instead system id attribute can be bytes or an unicode and encoding/decoding
happened only a file opened.
--
Added file: http://bugs.python.org/file28722/sax_unicode_fn_alt
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16903
___
___
Python-bugs
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: docs@python - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16954
Serhiy Storchaka added the comment:
Patch updated. Fixed an error which Georg have found. Restored testing
XMLGenerator with StringIO as Antoine pointed. Now XMLGenerator tested for
StringIO, BytesIO and an user writer. Added tests for encoding.
--
keywords: -easy
Added file: http
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1470548
Serhiy Storchaka added the comment:
I should add a symlink loop detecting to _rlistdir() as Antoine advised me on
IRC.
--
stage: patch review - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13968
Serhiy Storchaka added the comment:
At the moment gzip can raise two errors on unexpected EOF: struct.error from
struct.unpack() or TypeError from ord(). Both bz2 and lzma raise EOFError in
such cases.
The proposed patch converts both truncated gzip errors to EOFError as for bz2
and lzma
Serhiy Storchaka added the comment:
In fact glob() is already protected against an endless recursion (in the same
way as Bash). The level of recursion is simply limited by the maximum length of
the path. So I did not change the implementation, I have just added a test for
symlink loop. I also
Serhiy Storchaka added the comment:
Yes, it's fixed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15539
___
___
Python-bugs-list mailing list
Serhiy Storchaka added the comment:
If no one objects, I'm going to commit this next week.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9290
Serhiy Storchaka added the comment:
Fixed. Thank you for report, Craig de Stigter.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9720
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15989
Serhiy Storchaka added the comment:
Changeset 525407d89277: Fix test_socket broken in previous commit (changeset
13e2e44db99d).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15989
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: serhiy.storchaka - docs@python
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16954
Serhiy Storchaka added the comment:
Here are updated to current codebase patches for 2.7 and 3.2. It seems that
all the rest of overflows are hypothetical bugs and do not appear on the
current supported platforms. Fix them is not necessary (rather for purity). If
no one can see visible bugs
Serhiy Storchaka added the comment:
Oh, I forgot to mention the issue number in commit messages. There are
changeset ad9b5c69b8b6 (for 3.3) and changeset 1f66fc397c8d (for default).
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
New submission from Serhiy Storchaka:
Charmap decoder can leak a reference in case of error.
--
components: Unicode
files: charmap_decode_leaks-3.3.patch
keywords: 3.3regression, patch
messages: 180018
nosy: ezio.melotti, serhiy.storchaka
priority: normal
severity: normal
stage: patch
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file28739/charmap_decode_leaks-3.4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16971
Serhiy Storchaka added the comment:
Fixed. Thank you for your answers, Martin.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14850
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14850
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16971
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
Fixed. Thank you for report, Bryan Oakley.
--
resolution: - fixed
stage: patch review - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15861
Changes by Serhiy Storchaka storch...@gmail.com:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15861
___
___
Python-bugs
Serhiy Storchaka added the comment:
Fixed in issue15861. Thank you for report, Clayton Darwin.
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11290
Serhiy Storchaka added the comment:
Tkinter as perhaps any other GUI library must be used only from one thread.
--
nosy: +serhiy.storchaka, terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6933
Serhiy Storchaka added the comment:
It should be self._getints(...) or None as in other methods.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6160
Serhiy Storchaka added the comment:
Can you please update the patch for the default branch tip? It looks too
outdated.
--
nosy: +serhiy.storchaka
versions: +Python 3.4 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
--
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15019
___
___
Python-bugs
Serhiy Storchaka added the comment:
In versions of Tk before 4.0, the set command accepted 4 arguments.
I think this is a new feature and can be applied only to 3.4. Agree with Jim
that for backward compatibility we should keep name index and arbitrary
number of arguments at least for one
Serhiy Storchaka added the comment:
For backward compatibility we must keep accepting arbitrary amount of arguments
at least a one release (with warnings).
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Serhiy Storchaka added the comment:
Enough difficult.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16971
___
___
Python-bugs-list mailing list
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +easy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15436
___
___
Python-bugs-list
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +easy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16643
___
___
Python-bugs-list
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +easy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16700
___
___
Python-bugs-list
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +easy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15984
___
___
Python-bugs-list
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +easy
versions: +Python 3.3, Python 3.4 -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7340
Serhiy Storchaka added the comment:
Fixed in r86838.
--
nosy: +serhiy.storchaka
resolution: - out of date
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7468
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: - needs patch
versions: +Python 3.2, Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9669
Changes by Serhiy Storchaka storch...@gmail.com:
--
components: +Regular Expressions
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9669
Serhiy Storchaka added the comment:
The Py_UNICODE* representation is deprecated since 3.3. New features can be
added only to 3.4.
--
nosy: +serhiy.storchaka
resolution: - rejected
status: open - pending
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Indeed, xml.dom.minidom.parseString() and xml.etree.ElementTree.fromstring()
accepts both bytes and strings, xml.dom.minidom.parse(),
xml.etree.ElementTree.parse() and even xml.sax.parse() accepts both byte and
text streams. Only xml.sax.parseString
Serhiy Storchaka added the comment:
It's interesting. The example behaves unstable on 3.3+ with C implementation of
picle, sometimes works, sometimes fails. With Python implementation and on 3.2
it works always. On 2.7 it fails always.
A difference between C and Python implementations
Serhiy Storchaka added the comment:
Already fixed in 3.3+.
--
keywords: +easy
nosy: +eli.bendersky, serhiy.storchaka
stage: - needs patch
type: - enhancement
versions: +Python 2.7, Python 3.2 -Python 2.6
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Here is a patch which include position number in the invalid bytes exception,
wrap it into SyntaxError, and adds tests for bytes and strings.
--
keywords: +patch
nosy: +serhiy.storchaka
stage: test needed - patch review
versions: +Python 3.4
Added
New submission from Serhiy Storchaka:
import codecs
codecs.escape_decode(r'\x1\x2\x3\x4\x5\x6\x7\x8\x9', 'replace')
(b'?\\x1?\\x2?\\x3?\\x4?\\x5?\\x6?\\x', 27)
codecs.escape_decode(r'\x1\x2\x3\x4\x5\x6\x7\x8\x9' * 1000, 'replace')
Segmentation fault
--
components: Interpreter Core
501 - 600 of 25750 matches
Mail list logo