Steve Dower added the comment:
> __assume(0) should be replaced with other function, inside the eval
> switch-case or in the inlined paths of callees. This is critical with PGO.
Out of interest, have you done other experiments confirming this? The reference
linked is talking about co
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 80c115385c01f456cdc6550543cf2112ae7a8161 by Steve Dower in branch
'3.9':
bpo-47103: Copy pgort140.dll into output directory when building PGInstrument
on Windows (GH-32083)
https://github.com/python/cpython/commit
Change by Steve Dower :
--
pull_requests: +30432
pull_request: https://github.com/python/cpython/pull/32407
___
Python tracker
<https://bugs.python.org/issue47
Steve Dower added the comment:
New changeset b0ec17b6d9e0fb61081b6d15a1b2a14b607851b7 by Steve Dower in branch
'3.10':
bpo-47103: Copy pgort140.dll into output directory when building PGInstrument
on Windows (GH-32083)
https://github.com/python/cpython/commit
Steve Dower added the comment:
Backport is blocked on issue47104 (or a randomly successful CI run, which seems
to occur occasionally).
--
versions: +Python 3.10, Python 3.9
___
Python tracker
<https://bugs.python.org/issue47
Change by Steve Dower :
--
assignee: -> steve.dower
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
Steve Dower added the comment:
New changeset 2390b2236d4b6ea96217478221d6f7d4b4f344f8 by Steve Dower in branch
'main':
bpo-47239: Fixes py.exe output when run in a virtual environment. (GH-32364)
https://github.com/python/cpython/commit/2390b2236d4b6ea96217478221d6f7d4b4f344f8
Change by Steve Dower :
--
pull_requests: +30413
pull_request: https://github.com/python/cpython/pull/32366
___
Python tracker
<https://bugs.python.org/issue47
Steve Dower added the comment:
PR posted, and here's some sample output with the change:
C:\> py.exe --list
* Active venv
-V:3.11 Python 3.11 (Store)
-V:3.10 Python 3.10 (Store)
-V:3.10-32 Python 3.10 (32-bit)
-V:3.9 Python 3.9 (64-
Change by Steve Dower :
--
keywords: +patch
pull_requests: +30411
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/32364
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
It's fine here. It affects the same part of the code.
--
___
Python tracker
<https://bugs.python.org/issue47239>
___
___
Pytho
Steve Dower added the comment:
Good catch, thanks!
--
___
Python tracker
<https://bugs.python.org/issue47239>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset 074da788028c1f1e867dc81698efdcdc263f2288 by Steve Dower in branch
'main':
bpo-47103: Copy pgort140.dll into output directory when building PGInstrument
on Windows (GH-32083)
https://github.com/python/cpython/commit
Steve Dower added the comment:
New changeset a4c7752f3e00b75fd1e4603458b8c77a9fa3d4cb by Jeremy Kloth in
branch '3.9':
bpo-47230: Silence compiler warnings on Windows from zlib 1.2.12 (GH-32337)
https://github.com/python/cpython/commit/a4c7752f3e00b75fd1e4603458b8c77a9fa3d4cb
Steve Dower added the comment:
New changeset 8bce3cb16df5b8ac06ac6b2cae177dd221780b2f by Jeremy Kloth in
branch '3.10':
bpo-47230: Silence compiler warnings on Windows from zlib 1.2.12 (GH-32337)
https://github.com/python/cpython/commit/8bce3cb16df5b8ac06ac6b2cae177dd221780b2f
Steve Dower added the comment:
Do we need to backport this?
--
___
Python tracker
<https://bugs.python.org/issue47230>
___
___
Python-bugs-list mailin
Steve Dower added the comment:
New changeset 944f09adfcc59f54432ac2947cf95f3465d90e1e by Jeremy Kloth in
branch 'main':
bpo-47230: Silence compiler warnings on Windows from zlib 1.2.12 (GH-32337)
https://github.com/python/cpython/commit/944f09adfcc59f54432ac2947cf95f3465d90e1e
Steve Dower added the comment:
> There is something fundamentally wrong with the way modules built into the
> interpreter DLL (python3x.dll) are loaded if anything in sys.path or the
> system PATH can cause an import to fail.
Probably there was also shadowing involved, since
Steve Dower added the comment:
It could also be something on your PATH interfering, as that particular
ImportError could be pretty deep in the load chain.
If none of the built-in options narrow it down enough, try
https://pypi.org/project/dlltracer/ as well. Its output takes a bit
Steve Dower added the comment:
This should be fixed in the docs and also in 3.11. Now that we've shipped
releases that include the frame, we should keep doing it.
If it's impossible to get a frame object in 3.11 (because it would deoptimize
all the work that's been done there), it should
Steve Dower added the comment:
New changeset 6066739ff7794e54c98c08b953a699cbc961cd28 by Zachary Ware in
branch 'main':
bpo-47194: Update zlib to v1.2.12 on Windows to resolve CVE-2018-25032
(GH-32241)
https://github.com/python/cpython/commit/6066739ff7794e54c98c08b953a699cbc961cd28
Steve Dower added the comment:
Done. Feel free to push directly to the repo, and bear in mind that changes may
be reflected in any version build at any point, which is why we use tags
(ahem... mostly... we've gotten it wrong before). Fourth field of the version
number is our private one, so
Steve Dower added the comment:
Erlend - would you be up for write permissions on the cpython-source-deps repo
so you can push the SQLite updates yourself.
As I've mentioned before, merging PRs into that repo isn't any easier than
doing it directly (since you also need to check file hashes
Change by Steve Dower :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Looks like that probably fixed it. Will let the buildbot run again to be sure:
https://buildbot.python.org/all/#/builders/729/builds/1191
https://buildbot.python.org/all/#/builders/730/builds/4322
--
___
Python
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset f3d5715492195fd2532fc1a5d73be07923cdf2e1 by Steve Dower in branch
'main':
bpo-46566: Make test_launcher more robust to a variety of installs (GH-32204)
https://github.com/python/cpython/commit/f3d5715492195fd2532fc1a5d73be07923cdf2e1
Steve Dower added the comment:
New changeset 2ab609dd614045f3b112ede0b0883339de784f2a by Steve Dower in branch
'main':
bpo-47171: Enable installing the py.exe launcher on Windows ARM64 (GH-32203)
https://github.com/python/cpython/commit/2ab609dd614045f3b112ede0b0883339de784f2a
Steve Dower added the comment:
The fix in PR 32204 also clears out VIRTUAL_ENV, so that may be enough. It's
running on buildbots to see whether it helps.
--
___
Python tracker
<https://bugs.python.org/issue47
Change by Steve Dower :
--
pull_requests: +30279
pull_request: https://github.com/python/cpython/pull/32204
___
Python tracker
<https://bugs.python.org/issue46
Steve Dower added the comment:
I'm still not convinced we should backport. Has anyone looked through to see
whether this will actually affect any high valued error codes today?
--
___
Python tracker
<https://bugs.python.org/issue46
Change by Steve Dower :
--
keywords: +patch
pull_requests: +30278
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/32203
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
Oh, I wonder if the VIRTUAL_ENV environment variable is interfering with search
(as it's meant to, but the tests weren't written expecting to be run inside a
venv).
--
___
Python tracker
<https://bugs.python.
New submission from Steve Dower :
Test failures: https://buildbot.python.org/all/#/builders/730/builds/4307
==
FAIL: test_filter_to_company (test.test_launcher.TestLauncher
Steve Dower added the comment:
New changeset d0c67ea0645b7ad37b867c167882a346a24de641 by Dong-hee Na in branch
'main':
bpo-46775: OSError should call winerror_to_errno unconditionally on Windows
(GH-32179)
https://github.com/python/cpython/commit/d0c67ea0645b7ad37b867c167882a346a24de641
New submission from Steve Dower :
Currently the launcher is not installed by the installer. We need to reenable
it.
--
assignee: steve.dower
components: Windows
messages: 416385
nosy: paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title
Steve Dower added the comment:
Are you saying this happens when you run "py.exe my-script.py"? Or only when
you run "my-script.py" (without the py.exe)?
--
___
Python tracker
<https://bug
Change by Steve Dower :
--
pull_requests: +30260
pull_request: https://github.com/python/cpython/pull/32183
___
Python tracker
<https://bugs.python.org/issue47
Change by Steve Dower :
--
pull_requests: +30259
pull_request: https://github.com/python/cpython/pull/32182
___
Python tracker
<https://bugs.python.org/issue47
Steve Dower added the comment:
Is this okay to backport? Correcting more winerror values means we'll get more
subclasses raised instead of OSError (though only for obscure cases, which
probably also aren't mapped, so I guess it's possible to prove that none will
actually change right now
Steve Dower added the comment:
New changeset 0dfabf9b4a58b835b61fc3d17784d4746f677e56 by Steve Dower in branch
'3.10':
bpo-47138: Ensure Windows docs build uses the same pinned version as other
platforms (GH-32161)
https://github.com/python/cpython/commit
Steve Dower added the comment:
It's in! Any new issues probably won't be found until the next release, so I'll
close this and we can open new bugs.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Pytho
Steve Dower added the comment:
New changeset bad86a621af61f383b9f06fe4a08f66245df99e2 by Steve Dower in branch
'main':
bpo-46566: Add new py.exe launcher implementation (GH-32062)
https://github.com/python/cpython/commit/bad86a621af61f383b9f06fe4a08f66245df99e2
Change by Steve Dower :
--
pull_requests: +30241
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/32163
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset 295114dcd32b3aad5453e5e15e9e1befa0e5ca01 by Steve Dower in branch
'main':
bpo-47138: Ensure Windows docs build uses the same pinned version as other
platforms (GH-32161)
https://github.com/python/cpython/commit
Change by Steve Dower :
--
nosy: +steve.dower
nosy_count: 4.0 -> 5.0
pull_requests: +30239
status: pending -> open
pull_request: https://github.com/python/cpython/pull/32161
___
Python tracker
<https://bugs.python.org/i
Steve Dower added the comment:
Did a basic test (with timeit and a work-internal library I already have) and
the native functionality is *slightly* faster than OpenSSL.
But I think it's worthwhile anyway, to help reduce our dependency on OpenSSL
Steve Dower added the comment:
I think this PR is "ready enough" to get in for broader testing, but in case
anyone wants to try it first, I've attached a build from my own machine.
You may need Programs & Features to remove any existing "Python Launcher"
before inst
Steve Dower added the comment:
Thanks for the report. This is a duplicate of issue47051 (and also no longer
applies to 3.11 because we've removed the CHM file completely and now ship all
the HTML files).
--
resolution: -> duplicate
stage: -> resolved
status: open -&g
Change by Steve Dower :
--
keywords: +patch
pull_requests: +30170
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/32083
___
Python tracker
<https://bugs.python.org/issu
New submission from Steve Dower :
Rather than trying to set up PATH properly, we should just copy pgort140.dll
into the build directory when building instrumented version.
This becomes more important for those (i.e. me) building and then manually
running the profile stage on a different
Steve Dower added the comment:
New changeset c62b944dfc98911a5050389fa6ac753e283fee1f by Russel Webber in
branch 'main':
bpo-31582: Created a new documentation section describing sys.path
initialization (GH-31082)
https://github.com/python/cpython/commit
Steve Dower added the comment:
New changeset fe010605f87f988ef1053e372d1c3898d2633d96 by Steve Dower in branch
'main':
bpo-47086: Remove dead link to old CHM documentation (GH-32075)
https://github.com/python/cpython/commit/fe010605f87f988ef1053e372d1c3898d2633d96
New submission from Steve Dower :
C:\> python3.11 -h
usage: (null) [option] ... [-c cmd | -m mod | file | -] [arg] ...
Options and arguments (and corresponding environment variables):
...
Should not show "(null)" there
Change by Steve Dower :
--
pull_requests: +30163
stage: commit review -> patch review
pull_request: https://github.com/python/cpython/pull/32075
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
This should work for you (luckily, this is about the simplest possible case):
import sys
import winreg
def get_help():
KEY = rf"Software\Python\PythonCore\{sys.winver}\Help\Main Python
Documentation"
try:
return winreg.
Steve Dower added the comment:
Posted my WIP as a draft PR. I'm still adding docs, tests and ironing out minor
issues, but the core functionality is there (as well as some added bonuses).
Feel free to review, and importantly to mark anywhere you'd like more
explanatory comments.
Currently
Change by Steve Dower :
--
keywords: +patch
pull_requests: +30152
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/32062
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset cd05d0a423d97be69f9de4650f68f89e99ad68d1 by neonene in branch
'main':
bpo-43166: Disable ceval.c optimizations for Windows debug builds (GH-32023)
https://github.com/python/cpython/commit/cd05d0a423d97be69f9de4650f68f89e99ad68d1
Steve Dower added the comment:
> Do you have any thoughts about distributing the docs in ePub format?
If Windows includes a reader for all supported versions, and it's easy
to build, sure. But I don't think the first bit is true.
Most people are going to be fairly comforta
Steve Dower added the comment:
The key is defined at
https://github.com/python/cpython/blob/main/Tools/msi/doc/doc.wxs#L17 and is
not set for a Store install at all. But we don't include the docs in that
either - go straight to the web
Steve Dower added the comment:
For the registry key, reading the default value from key
"HKCU\Software\Python\PythonCore\{sys.winver}\Help\Main Python Documentation"
(or HKLM - no need to worry about the Wow6432Node bit here) and passing it to
os.startfile() will work for
Steve Dower added the comment:
Good call on IDLE, I didn't even think to check there (there is a registry key
that points at the documentation if it was installed, which would be the best
approach for IDLE to use).
The makefiles don't urgently need to remove those references. If people
Steve Dower added the comment:
Backports have been merged
--
resolution: -> fixed
stage: backport needed -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 8db7610d1a7b1f90631bac26261338f27bd20727 by Jeremy Kloth in
branch '3.9':
bpo-44336: Prevent tests hanging on child process handles on Windows (GH-26578)
https://github.com/python/cpython/commit/8db7610d1a7b1f90631bac26261338f27bd20727
Steve Dower added the comment:
New changeset 8146e6b636905d9872140c990d93308ac20d13f0 by Jeremy Kloth in
branch '3.10':
bpo-44336: Prevent tests hanging on child process handles on Windows (GH-26578)
https://github.com/python/cpython/commit/8146e6b636905d9872140c990d93308ac20d13f0
Steve Dower added the comment:
Leaving this open and assigned to myself for a couple of days to deal with any
other fallout. In particular, I wasn't able to test the (minor) changes to the
publishing steps (e.g. GPG signing), so will have to wait for the next release
to see what works
Steve Dower added the comment:
New changeset 3751b6b030b4a3b88959b4f3c4ef2e58d325e497 by Steve Dower in branch
'main':
bpo-47086: Remove .chm from Windows installer and add HTML docs (GH-32038)
https://github.com/python/cpython/commit/3751b6b030b4a3b88959b4f3c4ef2e58d325e497
Steve Dower added the comment:
Jeremy - backports need to be done manually. Can I leave that with you and just
ping me on here when you're ready for a merge?
--
stage: -> backport needed
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset 19058b9f6271338bcc46b7d30fe79a83990cc35c by Jeremy Kloth in
branch 'main':
bpo-44336: Prevent tests hanging on child process handles on Windows (GH-26578)
https://github.com/python/cpython/commit/19058b9f6271338bcc46b7d30fe79a83990cc35c
Steve Dower added the comment:
"So close" being some months ago ;)
I need to retrigger address sanitiser so that it passes before merging, but
after that, I'll merge (and hopefully the backport is clean).
Copying Eryk Sun's comment here for posterity:
This would be less fragil
Steve Dower added the comment:
Doesn't seem to be any relevant changes in the repo between v3.10.2 and
v3.10.3, and the theme hasn't changed. Obviously the HTMLHelp tools haven't
changed in a decade or so, and the only difference in the build logs looks like
less errors in the later one
Change by Steve Dower :
--
keywords: +patch
pull_requests: +30128
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/32038
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
You're closer to this stuff than I am, so if you say it works for your
scenarios and it doesn't break the existing ones, I'll merge it.
Do we need to backport to 3.8 at this point?
--
___
Python tracker
<ht
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Steve Dower :
CHM is getting too hard to handle (see e.g. issue47051 for the latest issue),
so let's just bite the bullet and ship the HTML docs instead.
--
components: Windows
messages: 415701
nosy: paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
New submission from Steve Dower :
I guess for 3.11 we should just switch to loose HTML files and using the
default browser, rather than fighting with dead CHM tools.
No idea what may have caused this. Has anyone tried analysing the file for
unsupported JavaScript or something? I think that's
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset d0a91bd277d1122b41d59e8022b596e3b3ae24fe by Steve Dower in branch
'main':
bpo-47037: Test debug builds on Windows in CI so that native assertions are
noticed sooner (GH-31965)
https://github.com/python/cpython/commit
Steve Dower added the comment:
New changeset d190a9351be577a534a84fd1899f02a9f50f7276 by Christian Heimes in
branch 'main':
bpo-47037: Don't test for strftime('%4Y') on Windows (GH-31945)
https://github.com/python/cpython/commit/d190a9351be577a534a84fd1899f02a9f50f7276
Steve Dower added the comment:
Okay, that kind of makes sense.
If you try to uninstall 3.10.3 (either through Programs & Features, or through
the installer), how far can you get? Hopefully far enough that one of the
3.10.2 options will work, or possibly for a new 3.10.3 install to suc
Steve Dower added the comment:
Looks like you may have "cleaned up" your package cache at some point, which
means you can't uninstall the old version anymore.
Try getting the 3.10.2 installer and running it directly. If it's the right
one, you'll get Modify/Repair/Uninsta
Change by Steve Dower :
--
pull_requests: +30054
pull_request: https://github.com/python/cpython/pull/31965
___
Python tracker
<https://bugs.python.org/issue47
Steve Dower added the comment:
I think this is also a good enough reason to switch the GitHub CI back to a
debug build, rather than release, so that assert failures are caught before
they get merged. This is not the first time it's happened
Steve Dower added the comment:
This sounds more like recent installation changes on your machine. Have
you updated Visual Studio or something like that? Perhaps the debug UCRT
has gone missing.
I'm not aware of any recent compilation changes that would cause
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
> I just noticed the same. Is this intentional?
Honestly, no idea. I just copied how it was designed before, and had
nothing to do with the original venv implementation.
At a guess, I think virtualenv did everything with a patched site.py, so
w
Change by Steve Dower :
--
pull_requests: +30018
pull_request: https://github.com/python/cpython/pull/31927
___
Python tracker
<https://bugs.python.org/issue47
Change by Steve Dower :
--
pull_requests: +30017
pull_request: https://github.com/python/cpython/pull/31926
___
Python tracker
<https://bugs.python.org/issue47
Steve Dower added the comment:
New changeset 7c776521418676c074a483266339d31c950f516e by Steve Dower in branch
'main':
bpo-47032: Ensure Windows install builds fail correctly with a non-zero exit
code when part of the build fails (GH-31921)
https://github.com/python/cpython/commit
Steve Dower added the comment:
New changeset 708812085355c92f32e547d1f1d1f29aefbbc27e by Steve Dower in branch
'main':
bpo-46948: Fix launcher installer build failure due to first part of fix
(GH-31920)
https://github.com/python/cpython/commit/708812085355c92f32e547d1f1d1f29aefbbc27e
Change by Steve Dower :
--
keywords: +patch
pull_requests: +30012
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/31921
___
Python tracker
<https://bugs.python.org/issu
New submission from Steve Dower :
When changes are made under the Tools/msi directory, extra tests are run in
GitHub Actions to build the installer.
Apparently, these tests do not fail when the launcher installer fails to build.
They need to.
--
assignee: steve.dower
messages
Change by Steve Dower :
--
pull_requests: +30011
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/31920
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
The fix for this regressed the installer for the py.exe launcher, which breaks
our release builds.
I'm patching it now. It's going under the same issue number because it will be
needed for anyone applying this patch directly and then building the installer
Steve Dower added the comment:
Was there any reason/need to backport this?
--
___
Python tracker
<https://bugs.python.org/issue46907>
___
___
Python-bugs-list m
Steve Dower added the comment:
New changeset a8c728b8b742fd8ca5a225f79d99014794b8fdf3 by Mariusz Felisiak in
branch 'main':
bpo-46907: Update Windows installer to SQLite 3.38.1. (GH-31655)
https://github.com/python/cpython/commit/a8c728b8b742fd8ca5a225f79d99014794b8fdf3
1 - 100 of 5769 matches
Mail list logo
