Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 971ece8e1738b1107dda692cc44c6d8ddce384cd by Steve Dower in branch
'main':
bpo-46048: Fix parsing of single character lines in getpath readlines()
(GH-30048)
https://github.com/python/cpython/commit/971ece8e1738b1107dda692cc44c6d
Change by Steve Dower :
--
keywords: +patch
pull_requests: +28273
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/30048
___
Python tracker
<https://bugs.python.org/issu
New submission from Steve Dower :
The embeddable distro cannot import native modules.
This is because the '.' entry in the ._pth file is incorrect parsed by the new
getpath module (issue45582).
--
assignee: steve.dower
components: Interpreter Core
messages: 408300
nosy: lu
Steve Dower added the comment:
We'd also need to update the launcher to launch the executable with its name,
which it currently doesn't do. I was looking at this recently for some other
reason.
--
___
Python tracker
<https://bu
Steve Dower added the comment:
I'm going to need a decent amount of time to learn all of these components,
because I never use this OS, Tox, nor virtualenv :) I'll try and get to it, but
don't hold your breath. Luckily, Modules/getpath.py is much easier to follow
and modi
Steve Dower added the comment:
New changeset 3f398a77d37b5dfd51dabbc362d482a482fa885a by neonene in branch
'main':
bpo-45582: Fix test_embed failure during a PGO build on Windows (GH-30014)
https://github.com/python/cpython/commit/3f398a77d37b5dfd51dabbc362d482
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 3363e1cb05d0d19ed172ea63606d8cb6268747fc by Steve Dower in branch
'main':
bpo-46018: Ensure that math.expm1 does not raise on underflow (GH-29997)
https://github.com/python/cpython/commit/3363e1cb05d0d19ed172ea63606d8c
Steve Dower added the comment:
Lines 500-504 are the ones that trigger it. Apparently there are no tests in
that file for straight exp(), but the equivalent tests for those would return
0.0 and suppress ERANGE too.
--
___
Python tracker
<ht
Steve Dower added the comment:
I've also got no idea how to write a test for this, given that it's a very thin
wrapper around a platform's C runtime library. Our existing test discovered
when the library changed behaviour to start setting errno, which is probably
the
Steve Dower added the comment:
I considered just switching to <2.0, but wasn't sure if I would be breaking
some other unspoken behaviour there. But you're right, it's really just
detecting underflow vs. overflow, so that's a much simpler way to check.
I've
Change by Steve Dower :
--
keywords: +patch
pull_requests: +28220
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/29997
___
Python tracker
<https://bugs.python.org/issu
New submission from Steve Dower :
If a C runtime's math functions set errno to ERANGE, we assume it is a valid
underflow if fabs(result) < 1.0.
However, because expm1 includes a -1.0, it underflows towards -1.0. This fails
the above check, and so if a runtime's expm1() sets E
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 7778116c2f573edf320bd55301137a968e4339d8 by Steve Dower in branch
'main':
bpo-46015: Fixes calculation of sys.path in a venv on Windows (GH-29992)
https://github.com/python/cpython/commit/7778116c2f573edf320bd55301137a
Change by Steve Dower :
--
keywords: +patch
pull_requests: +28215
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/29992
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
+RM
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue46015>
___
___
Python-bugs-list mailing list
Unsub
New submission from Steve Dower :
Before, a venv would include the DLLs directory in sys.path. Since issue45582,
it does not, and so anything that relies on a standard library native module
cannot run.
--
assignee: steve.dower
components: Windows
messages: 408033
nosy: paul.moore
Steve Dower added the comment:
New changeset b0b30862796e97b3f0ee358bcc61d21f0cc98441 by Steve Dower in branch
'main':
bpo-45582: Write empty pybuilddir.txt on Windows to allow relocatable build
directories (GH-29979)
https://github.com/python/cpyt
Change by Steve Dower :
--
pull_requests: +28205
pull_request: https://github.com/python/cpython/pull/29979
___
Python tracker
<https://bugs.python.org/issue45
Steve Dower added the comment:
Yes, it's been fixed.
The debate about whether to test in CI with C assertions enabled or not can
continue somewhere else.
--
resolution: -> fixed
stage: test needed -> resolved
status: open -> closed
Steve Dower added the comment:
New changeset b7ef27bc084665ce58d89fc69530c6f9d2d37754 by Steve Dower in branch
'main':
bpo-45582: Ensure PYTHONHOME still overrides detected build prefixes (GH-29948)
https://github.com/python/cpython/commit/b7ef27bc084665ce58d89fc69530c6
Change by Steve Dower :
--
pull_requests: +28173
pull_request: https://github.com/python/cpython/pull/29948
___
Python tracker
<https://bugs.python.org/issue45
Steve Dower added the comment:
("2" and "3" are just arbitrary numbers... substitute however many Python
runtimes you actually have, or "N" and "N+1" if you prefer.)
--
___
Python trac
Steve Dower added the comment:
So if I've understood you, there are three Python installs on your machine. Two
of them are Windows builds, which are listed in the registry and discovered by
py.exe -0p. The third is the MSYS2 build, which is *not* listed in the registry
and is
Steve Dower added the comment:
Are you launching "py" from inside MSYS2? Or a regular prompt?
What does the output of "py -0p" show? (It should list all the discovered
installs)
We might need someone who understands how MSYS2 works h
Steve Dower added the comment:
They should all be under "-32" when in roaming appdata, because otherwise
having 32-bit and 64-bit installs side-by-side will conflict.
If these fields were newly added to distutils then should probably fix them to
match sysconfig. If they'r
Steve Dower added the comment:
New changeset af1db4eb555e02d2bff3476f99f7a653764203b0 by neonene in branch
'main':
bpo-45582: Fix getpath_isxfile() and test_embed on Windows (GH-29930)
https://github.com/python/cpython/commit/af1db4eb555e02d2bff3476f99f7a6
Steve Dower added the comment:
Not sure if Mark and Martin are part of an expert group, but neither are active
in this area these days.
For the original question, I have no idea why the command can't use a builtin
name, so hard to say whether we'd change it. A summary of why it&#x
Steve Dower added the comment:
@Ray I posted a PR that works fine on Windows, would you be able to try it on
Linux? The executables seem to have different names, so I'm a little concerned
about the change, but I think it should be al
Change by Steve Dower :
--
pull_requests: +28132
pull_request: https://github.com/python/cpython/pull/29908
___
Python tracker
<https://bugs.python.org/issue44
Change by Steve Dower :
--
pull_requests: -27916
___
Python tracker
<https://bugs.python.org/issue44844>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset 7d7c91a8e8c0bb04105a21a17d1061ffc1c04d80 by neonene in branch
'main':
bpo-45582: Add a NOT operator to the condition in getpath_isxfile (GH-29906)
https://github.com/python/cpython/commit/7d7c91a8e8c0bb04105a21a17d1061
Steve Dower added the comment:
It probably all needs straightening out:
* Microsoft Visual Studio 2015 *or later* can be used to build the project files
* Microsoft Visual C++ 14.3 is what we use to build the official releases for
the main branch (3.11)
* earlier branches may still be using
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset d9301703fb1086cafbd730c17e3d450a192485d6 by Crowthebird in branch
'main':
bpo-45816: Support building with VS 2022 (v143 toolset) on Windows (GH-29577)
https://github.com/python/cpython/commit/d9301703fb1086cafbd730c17e3d45
Steve Dower added the comment:
Unless someone can find an authoring bug under Tools/msi, I don't think we can
do anything about this. We rely on the built-in Windows support for adding and
removing these variables, and if that's broken, we can't do anything with our
current s
Steve Dower added the comment:
It's done! Those were some of the hardest memory leaks I've had to track down,
but it should be clear now.
As I mentioned in the commit message, this change attempts to preserve every
known quirk. However, I think these ought to be streamlined across
Steve Dower added the comment:
New changeset 99fcf1505218464c489d419d4500f126b6d6dc28 by Steve Dower in branch
'main':
bpo-45582: Port getpath[p].c to Python (GH-29041)
https://github.com/python/cpython/commit/99fcf1505218464c489d419d4500f1
Steve Dower added the comment:
An easy workaround for people encountering this is to set the PlatformToolset
environment variable to v143 before building:
$env:PlatformToolset = "v143"
(or in CMD: set PlatformToolset=v143)
Alternatively, you should be able to install the v1
Steve Dower added the comment:
Looks like it's gone through. Thanks!
--
nosy: -miss-islington
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10, Python 3.9
___
Python t
Steve Dower added the comment:
New changeset 734ed3538314c9651ae64d5e2e0e98aae3aec17b by David Federman in
branch 'main':
bpo-45931: Prevent Directory.Build.props/targets from leaking from directories
above the repo when building on Windows (GH-29854)
https://github.com/pyth
Steve Dower added the comment:
Basically unchanged on Debian/WSL as well.
There's a new conflict arisen, so I'll resolve that and then merge.
--
___
Python tracker
<https://bugs.python.o
Steve Dower added the comment:
Nice catch, thanks!
Did you start the CLA process already? (I personally would exempt this PR from
it as "not sufficiently creative", but I'm not sure I'm allowed to do that
anymore...)
--
__
Steve Dower added the comment:
It's one data point (well, statistics over 1000 points), but it looks like it's
actually a slight improvement in performance over the previous code on Windows
:)
before after
min 23.103 22.154
25% 25.069 23.59925
50% 25.8125 24.2715
75
Steve Dower added the comment:
New changeset db55f3fabafc046e4fca907210ced4ce16bf58d6 by Steve Dower in branch
'main':
bpo-44530: Reverts a change to the 'code.__new__' audit event (GH-29809)
https://github.com/python/cpython/commit/db55f3fabafc046e4fca
Change by Steve Dower :
--
assignee: -> steve.dower
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
Steve Dower added the comment:
Status update on this: I owe everyone a perf comparison of the before/after
with this change.
I don't particularly want to block on a regression unless it's significant
(honestly still have no idea what to expect), but open to others' thoughts
Steve Dower added the comment:
New changeset 133fb267f437f9bd568738d0e0e59e574fc82b02 by Miss Islington (bot)
in branch '3.9':
bpo-45901: Fixes argument passing when invoking .py files directly through the
Store package (GH-29799)
https://github.com/python/cpyt
Change by Steve Dower :
--
pull_requests: +28041
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/29809
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
Correction: the event is `code.__new__`
--
___
Python tracker
<https://bugs.python.org/issue44530>
___
___
Python-bugs-list mailin
Steve Dower added the comment:
This change modified the audit event 'code.__name__', which requires a
deprecation period (all events are public API, as per PEP 578).
We need to revert that part of the change. I don't think we need to add a new
event to report the qualnam
Steve Dower added the comment:
New changeset 4841e694ee1686f8c933ddfcb8c854915867ce17 by Steve Dower in branch
'main':
bpo-45901: Fixes argument passing when invoking .py files directly through the
Store package (GH-29799)
https://github.com/python/cpyt
Steve Dower added the comment:
This is because we use libffi as a DLL and you can't statically reference
dynamically loaded addresses on Windows.
You could change that format table to be initialised on first use, or resolve
the FFI type lazily. Or change ctypes to statically link l
Steve Dower added the comment:
For future reference, in case someone stumbles over this issue, here's how I
tested this change:
* set $env:IncludeUWP="true"
* did a regular PCbuild/build.bat
* generated a Store layout with "./python.bat PC/layout --preset-appx --copy
./o
Change by Steve Dower :
--
keywords: +patch
pull_requests: +28034
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/29799
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
Also, we should define $env:IncludeUWP="true" in the Windows PR tests. That
will build extra binaries every time (that we ship in the Windows Store) and
would catch this issue earlier.
--
___
Python track
Steve Dower added the comment:
Seems we lost the C++ handling in Include/cpython/initconfig.h:
#ifdef __cplusplus
extern "C" {
#endif
#ifdef __cplusplus
}
#endif
--
keywords: +easy (C)
versions: +Python 3.11
___
Python track
Steve Dower added the comment:
Looks like the fix for those errors is to specify the arguments to the linker
in PCbuild/pyproject.props
/OPT:REF,NOICF
/CGTHREADS:1 /PDBTHREADS:1 %(AdditionalOptions)
I don't particularly know what a good number of threads is for this. One seems
safe
Steve Dower added the comment:
New changeset 4c616911b69ce07fb35da1721506bfaba0998c30 by Steve Dower in branch
'main':
bpo-45506: Fix test_embed expecting to not find stdlib in source tree build
when stdlib has been installed. (GH-29649)
https://github.com/python/cpyt
Change by Steve Dower :
--
pull_requests: +27880
pull_request: https://github.com/python/cpython/pull/29649
___
Python tracker
<https://bugs.python.org/issue45
Steve Dower added the comment:
Hijacking this issue number for a related test failure I found: if you "make
install" Python and then run the test_embed tests from the build directory,
some will successfully find the stdlib under PREFIX and fail because they
expect to never fi
Steve Dower added the comment:
This is expected. The top-level exit() command only exists when the site module
is imported, which is not the default for embedded Python (you should specify
all the import paths explicitly, since they're going to be in your app rather
than found by sear
Steve Dower added the comment:
Could you post the errors?
--
___
Python tracker
<https://bugs.python.org/issue45816>
___
___
Python-bugs-list mailing list
Unsub
Steve Dower added the comment:
> -set pgo_job=-m test --pgo
> +set pgo_job=-c"pass"
This essentially disables PGO. You won't get anything valid or useful from
analysing its results if you don't give it a somewhat reasonable profile
(preferably one that exercises t
Steve Dower added the comment:
It's impossible for us to tell what's causing this without much more
information, but could you first try switching to Python 3.10? Even if we
figured it out, we wouldn't be fixing 3.7 at this stage.
If 3.10 still crashes, information about yo
Steve Dower added the comment:
I have tests passing now, so reviews would be appreciated.
There's definitely scope for optimising this algorithm both for speed and
clarity, but I'd prefer to get the main translation in first so that any
further changes have a reliable baseline (
Steve Dower added the comment:
> instead of manually defining RT_MANIFEST, try including "winresrc.h" in the
> resource definition files
I just wish it were documented... we can keep it in mind if another one of
these pops up.
--
__
Steve Dower added the comment:
New changeset 32d14b262d6d914f63485f8d6e7859df58cd2089 by Miss Islington (bot)
in branch '3.9':
bpo-45220: Ensure RT_MANIFEST is defined when compiling Windows resource files
(GH-29501)
https://github.com/python/cpyt
Steve Dower added the comment:
You're right. You probably need to uninstall and reinstall for the
subdirectories of WindowsApps.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
> Could it be possible that it might not be able to replace that link when it
> is currently in use?
That (or something like that) would be my suspicion. It's happened
before, though as Eryk Sun says the link itself does not remain in use
very long
Steve Dower added the comment:
I'm expecting another dumb error (on my part) or two in the PR, but I'm very
close to having this working.
Reviews would be appreciated! Bear in mind that I'm trying to match the current
(quirky) behaviour, rather than streamline anything by c
Steve Dower added the comment:
Can you look in your %LocalAppData%\Microsoft\WindowsApps folder and see
if the python*.exe files are there? You should be able to double-click
them to launch them.
That folder should be on your PATH so that they work everywhere, and it
should reflect what
Steve Dower added the comment:
If you open "Manage app execution aliases", do you see the entries for Python?
I've heard that they sometimes switch themselves off during updates, but nobody
seems to know why. Even if not, disabling and re-enabling them may help.
The execut
Steve Dower added the comment:
Marking this as fixed, because the fix is already checked in. Release
scheduling is a separate conversation, so keep an eye out for the next release.
--
resolution: -> fixed
stage: -> resolved
status: open -&g
Steve Dower added the comment:
Oh I think I know what happened. Because RT_MANIFEST wasn't defined, it was
added as a resource tagged with that as a string. So the manifest is still
embedded, just not under the right type constant, so it has no effect.
Yeah, I think we should do a
Steve Dower added the comment:
> I just installed it and can confirm that there's no embedded manifest in
> "C:\Program
> Files\WindowApps\PythonSoftwareFoundation.Python.3.9<...>\python.exe".
Strange, because when I inspect the files that I published, it'
Steve Dower added the comment:
> Did my accidental breakage of the resource files make it into the last 3.9
> release?
Turns out, no, it didn't. So this is something else.
When I get to work later today I'll take a look.
--
__
Steve Dower added the comment:
Oh, no, wait. Did my accidental breakage of the resource files make it into the
last 3.9 release? If so, we probably lost the manifest option to opt-in to
supporting long paths, and perhaps Windows 11 has decided to start honouring
that (Windows 10 ignored it
Steve Dower added the comment:
I wonder if the Windows 11 upgrade process disables this registry key when it's
set directly?
That's not something we can fix (I don't think?), so we may just have to list
it as an option.
If you can, check whether running a Repair of your
Steve Dower added the comment:
Since collections.abc is a module, it should work if you import it:
>>> import collections.abc
>>> collections.abc.Container
Submodules being implicitly imported is not part of any API guarantee, which
will be why somebody changed it withou
Steve Dower added the comment:
New changeset a56fbad85ea655631bce68d4c0f47f1a8b500abd by Steve Dower in branch
'main':
bpo-45220: Ensure RT_MANIFEST is defined when compiling Windows resource files
(GH-29501)
https://github.com/python/cpython/commit/a56fbad85ea655631bce68d4c0f47f
Change by Steve Dower :
--
pull_requests: +27750
pull_request: https://github.com/python/cpython/pull/29501
___
Python tracker
<https://bugs.python.org/issue45
Steve Dower added the comment:
FYI, adding a fix for this on issue45220
--
___
Python tracker
<https://bugs.python.org/issue45354>
___
___
Python-bugs-list m
Steve Dower added the comment:
New changeset 4d1cdd7006def053c815c354bd6f266b4850bd97 by Steve Dower in branch
'3.9':
bpo-45732: Update bundled Tcl/Tk on Windows to 8.6.12 (GH-29477)
https://github.com/python/cpython/commit/4d1cdd7006def053c815c354bd6f26
Change by Steve Dower :
--
pull_requests: +27746
pull_request: https://github.com/python/cpython/pull/29496
___
Python tracker
<https://bugs.python.org/issue45
Steve Dower added the comment:
New changeset 340ecafdf3bfb1377a1b8584addbb8e7bb423459 by Steve Dower in branch
'3.10':
bpo-45732: Update bundled Tcl/Tk on Windows to 8.6.12 (GH-29477)
https://github.com/python/cpython/commit/340ecafdf3bfb1377a1b8584addbb8
Change by Steve Dower :
--
pull_requests: +27742
pull_request: https://github.com/python/cpython/pull/29493
___
Python tracker
<https://bugs.python.org/issue45
Steve Dower added the comment:
New changeset bcc4e46832010469bb35a97c1d1e962a82ee7fd9 by Steve Dower in branch
'main':
bpo-45732: Update bundled Tcl/Tk on Windows to 8.6.12 (GH-29477)
https://github.com/python/cpython/commit/bcc4e46832010469bb35a97c1d1e96
Steve Dower added the comment:
> bpo-45220 removed the winuser.h include from the PC\*.rc files, so the
> RT_MANIFEST resource type macro isn't defined. It needs to be defined in the
> file or a common header. For example:
>
> #define RT_MANIFEST 24
Change by Steve Dower :
--
keywords: +patch
pull_requests: +27727
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/29477
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
I guess I've actually got to fix my build process now :)
--
___
Python tracker
<https://bugs.python.org/issue45732>
___
___
Steve Dower added the comment:
New changeset 5017306c8732b3ceda878db13088f8c2cf0c5e71 by Miss Islington (bot)
in branch '3.9':
bpo-45720: Drop references to shlwapi.dll on Windows (GH-29417)
https://github.com/python/cpython/commit/5017306c8732b3ceda878db13088f8
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 804ea41211b042fa20c3cd8c0457bbfa3873128a by Steve Dower in branch
'3.10':
bpo-45720: Drop references to shlwapi.dll on Windows (GH-29417)
https://github.com/python/cpython/commit/804ea41211b042fa20c3cd8c0457bb
Change by Steve Dower :
--
pull_requests: +27689
pull_request: https://github.com/python/cpython/pull/29435
___
Python tracker
<https://bugs.python.org/issue45
Steve Dower added the comment:
New changeset a4774f42e35861c4bb16928cffb011c2d8a285ac by Steve Dower in branch
'main':
bpo-45720: Drop references to shlwapi.dll on Windows (GH-29417)
https://github.com/python/cpython/commit/a4774f42e35861c4bb16928cffb011
Steve Dower added the comment:
FTR, I see about 1-1.5ms improvement (using timeit to do a check_call) out of
~32ms total startup time.
I also don't actually see gdi32 being transitively loaded as claimed in the
Twitter thread, even back to 3.8. So presumably there's something els
301 - 400 of 5794 matches
Mail list logo
