Tal Einat added the comment:
For one thing, the new diffs are still missing tests.
Tests should include, at the least:
1. *Safely* testing SafeTarFile against examples of problematic tarballs.
Perhaps from Jakub's collection of "sly" tarballs could be used, assuming those
could b
Tal Einat added the comment:
See new updated PR9213 for completing the _hashopenssl.c conversion.
--
___
Python tracker
<https://bugs.python.org/issue20
Change by Tal Einat :
--
pull_requests: +8645
___
Python tracker
<https://bugs.python.org/issue20182>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
Now just the collections module is left from this group.
Raymond, what would you like done with it WRT AC conversion, if at all?
--
___
Python tracker
<https://bugs.python.org/issue20
Change by Tal Einat :
--
pull_requests: +8607
___
Python tracker
<https://bugs.python.org/issue20180>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
New changeset d53f1cabe8837697df4acb70c9c6537461b5eeda by Tal Einat in branch
'3.7':
[3.7] bpo-34621: fix uuid.UUID (un)pickling compatbility with older Python
versions (<3.7) (GH-9133)
https://github.com/python/cpython/com
Tal Einat added the comment:
New changeset 54752533b2ed1c898ffe5ec2e795c6910ee46a39 by Tal Einat in branch
'master':
bpo-30977: rework code changes according to post-merge code review (GH-9106)
https://github.com/python/cpython/commit/54752533b2ed1c898ffe5ec2e795c6910ee46a39
Change by Tal Einat :
--
pull_requests: +8586
___
Python tracker
<https://bugs.python.org/issue30977>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
keywords: +patch
pull_requests: +8585
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34621>
___
___
Python-
Tal Einat added the comment:
The fix for issue30977 did fix the unpickling in older versions. It was only
applied to the master (i.e. 3.8) branch, though.
I've created issue34621 to deal with this separately.
--
___
Python tracker
<ht
New submission from Tal Einat :
This affects only 3.7, where the new SafeUUID enum was introduced.
This was fixed on the master branch (3.8) while implementing issue30977.
Fixing this should simply require defining similar __getstate__ and
__setstate__ methods as in 3.8
Tal Einat added the comment:
Testing similarly to Terry, this doesn't reproduce with a recent build of
master branch (3.8) on Ubuntu 16.04.
I'll be able to try a build of older versions with IDLE only in a few days.
--
___
Python tracker
<ht
Tal Einat added the comment:
I'm +1 on this optimization.
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue28307>
___
___
Python-bugs-list m
Change by Tal Einat :
--
pull_requests: +8560
___
Python tracker
<https://bugs.python.org/issue30977>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
Has this been discussed on python-dev? If so, what was the result?
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue32
Tal Einat added the comment:
Thanks for the suggestion and the original patch, Wouter!
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<https://bugs.python.org/i
Tal Einat added the comment:
New changeset 3e2b29dccc3ca9fbc418bfa312ad655782e250f2 by Tal Einat in branch
'master':
bpo-30977: make uuid.UUID use __slots__ (GH-9078)
https://github.com/python/cpython/commit/3e2b29dccc3ca9fbc418bfa312ad655782e250f2
Tal Einat added the comment:
We should decide on this.
I agree with Serhiy that in accordance with PEP 4, as long as Tix still works,
we should keep it.
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue31
Tal Einat added the comment:
See new PR which addresses pickle forward and backward compatibility.
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue30
Change by Tal Einat :
--
keywords: +patch
pull_requests: +8536
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue30977>
___
___
Python-
Change by Tal Einat :
--
keywords: +patch
pull_requests: +8478
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34548>
___
___
Python-
Change by Tal Einat :
--
assignee: taleinat
components: IDLE
nosy: taleinat, terry.reedy
priority: low
severity: normal
status: open
title: IDLE: Make TextView use the configured theme colors
versions: Python 2.7, Python 3.6, Python 3.7, Python 3.8
Tal Einat added the comment:
> 1. Yes. Always show. Fix delay at 80 until we decide on something better.
Done.
> 2. No. Max should be enough.
Done.
> I once printed over 500_000 short lines to see if scrolling remained
> responsive. It did. I could have set min
Tal Einat added the comment:
I've gone ahead and addressed all of the significant issues raised here:
* Squeezer is no longer an extension
* Expanding problematically large outputs prompts the user for confirmation
* "copy" and "view" moved to a right-click context menu
*
Tal Einat added the comment:
Lars, a huge +1 from me for your suggested approach and patch. I'd like to
work this into a review-ready PR.
The patch is a great step forward but still a ways from being ready for a PR:
It is missing tests entirely and there are still several important methods
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg324192
___
Python tracker
<https://bugs.python.org/issue1044>
___
___
Python-bugs-list mailin
Tal Einat added the comment:
I suggest marking this as a duplicate of #21109, which is more general and
includes most of the relevant discussion and patches.
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue1
Tal Einat added the comment:
I suggest marking this as a duplicate of #21109, which is more general and
includes most of the relevant discussion and patches.
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue17
Tal Einat added the comment:
Thanks for reporting this, Gabriel!
Thanks for the PR, Vladimir!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.o
Tal Einat added the comment:
New changeset 491740f116755e220135e596ec802ea3a0f65596 by Tal Einat in branch
'2.7':
[2.7] bpo-6700: Fix inspect.getsourcelines for module level frames/tracebacks
(GH-8864)
https://github.com/python/cpython/commit/491740f116755e220135e596ec802ea3a0f65596
Change by Tal Einat :
--
pull_requests: +8371
___
Python tracker
<https://bugs.python.org/issue6700>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
New changeset 91cb298f811961277fd4cc4a32211899d48bedcb by Tal Einat (Vladimir
Matveev) in branch 'master':
bpo-6700: Fix inspect.getsourcelines for module level frames/tracebacks
(GH-8864)
https://github.com/python/cpython/commit
Tal Einat added the comment:
Thanks for the report and initial patch, Alexey!
Thanks for the followup and final PR, Paul!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bug
Tal Einat added the comment:
New changeset 096329f0b2bf5e3f0a16363aa631d993ce078737 by Tal Einat (Paul
Ganssle) in branch 'master':
bpo-34454: fix .fromisoformat() methods crashing on inputs with surrogate code
points (GH-8862)
https://github.com/python/cpython/commit
Change by Tal Einat :
--
versions: +Python 2.7
___
Python tracker
<https://bugs.python.org/issue6700>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
versions: +Python 3.8 -Python 3.5
___
Python tracker
<https://bugs.python.org/issue6700>
___
___
Python-bugs-list mailing list
Unsub
Change by Tal Einat :
--
pull_requests: +8331
___
Python tracker
<https://bugs.python.org/issue34454>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
I agree this should probably be ignored for security-only branches. However,
AFAIK 2.7 is still in bugfix status, not security-only. If there's interest,
I'm happy to build with AMK's fix on 2.7 on Windows to see if it works, and if
so provide a PR
Tal Einat added the comment:
Michael, thanks for catching this and supplying a PR!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
New changeset 0e6e7a1e52a53090e33ebef13f8f1fbe9bec2375 by Tal Einat (Michael
Osipov) in branch 'master':
bpo-34419: selectmodule.c does not compile on HP-UX due to bpo-31938 (GH-8796)
https://github.com/python/cpython/commit
Tal Einat added the comment:
New changeset 0e6e7a1e52a53090e33ebef13f8f1fbe9bec2375 by Tal Einat (Michael
Osipov) in branch 'master':
bpo-34419: selectmodule.c does not compile on HP-UX due to bpo-31938 (GH-8796)
https://github.com/python/cpython/commit
Change by Tal Einat :
--
title: Squeezer - squeeze large output in IDLE -> Squeezer - squeeze large
output in IDLE's shell
___
Python tracker
<https://bugs.python.org/issue1
Tal Einat added the comment:
I'm back to working on this. I've made good progress: I'm nearly done with all
of the changes suggested here and ready for another PR review.
I'd like some opinions on a few things:
1. Should the tooltip-related configuration options be removed? There is one
Tal Einat added the comment:
We can just remove the "=None" in the docs for select.kqueue.control() to
conform with the rest of that doc.
We don't use the PEP 457 slash notation in the docs for select (or perhaps at
all?).
--
___
Pyth
Tal Einat added the comment:
In Python 3.8 this will have already been fixed (thanks to the recent
conversion of the select module to use Argument Clinic); see below output from
a recent build from the master branch.
Given that, is this worth fixing on 2.7 and <3.8?
Help on bu
Change by Tal Einat :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
> Should one open a different report for the clicks on the scrollbar ends, like
> in the script I put (independent of IDLE)?
Indeed. Please open a new issue with an appropriate title and attach your
example script and
Tal Einat added the comment:
New changeset 077059e0f086cf8c8b7fb9d1f053e38ddc743f59 by Tal Einat in branch
'master':
bpo-34047: IDLE: fix mousewheel scrolling direction on macOS (GH-8678)
https://github.com/python/cpython/commit/077059e0f086cf8c8b7fb9d1f053e38ddc743f59
Change by Tal Einat :
--
keywords: +patch
pull_requests: +8173
stage: test needed -> patch review
___
Python tracker
<https://bugs.python.org/issue34047>
___
_
Tal Einat added the comment:
Yes! Vlad's fix resolves the "sticks at bottom of file" bug for me on macOS.
It also resolves #2 in my list of additional bugs, regarding scrolling
direction.
With both 3.7.0 and current master, I still see additional bugs #1 and #3, i.e.
issue
Tal Einat added the comment:
I can confirm the these issues do *not* occur on my macOS setup when using
tcl/tk 8.6.8 built from source.
--
___
Python tracker
<https://bugs.python.org/issue34
Change by Tal Einat :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue33839>
___
___
Python-bugs-
Change by Tal Einat :
--
resolution: -> fixed
___
Python tracker
<https://bugs.python.org/issue33839>
___
___
Python-bugs-list mailing list
Unsubscrib
Tal Einat added the comment:
New changeset 87e59ac11ee074b0dc1bc864c74fac0660b27f6e by Tal Einat in branch
'master':
bpo-33839: refactor IDLE's tooltips & calltips, add docstrings and tests
(GH-7683)
https://github.com/python/cpython/commit/87e59ac11ee074b0dc1bc864c74fac0660b2
Tal Einat added the comment:
I tend to agree. ISTM that for users, understanding the error message and
passing a tuple is trivial, while realizing the performance benefit of using a
tuple rather than a list or set here is certainly non-trivial
Tal Einat added the comment:
Many thanks for the report and follow through, Vlad!
Thank you too, Kevin, for your help in resolving this.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracke
Tal Einat added the comment:
New changeset dd74369cb7b230b07ac3a031563406c8f2aae17f by Tal Einat in branch
'master':
bpo-34120: fix text viewer to call grab_release() only when needed (GH-8616)
https://github.com/python/cpython/commit/dd74369cb7b230b07ac3a031563406c8f2aae17f
Tal Einat added the comment:
New changeset 894940b1099677c1ca0aa527dbb935e47d3d591a by Tal Einat in branch
'2.7':
[2.7] bpo-34120: fix IDLE freezing after closing dialogs (GH-8603)
https://github.com/python/cpython/commit/894940b1099677c1ca0aa527dbb935e47d3d591a
Change by Tal Einat :
--
pull_requests: +8122
___
Python tracker
<https://bugs.python.org/issue34120>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue34312>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
After reading everything here, I'm not sure there's anything wrong or to be
improved with Python's Windows installers in this regard. All of the
installation errors reported here appear to be caused by external circumstances
breaking MSI installation in general
Change by Tal Einat :
--
pull_requests: +8120
___
Python tracker
<https://bugs.python.org/issue34120>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
New changeset 10ea9409ceb5da83cb380b610750551e26561044 by Tal Einat in branch
'master':
bpo-34120: fix IDLE freezing after closing dialogs (GH-8603)
https://github.com/python/cpython/commit/10ea9409ceb5da83cb380b610750551e26561044
Tal Einat added the comment:
Why remove the 2.7 version? This bug occurs with 2.7.15 on macOS.
--
___
Python tracker
<https://bugs.python.org/issue34
New submission from Tal Einat :
On macOS 10.13.5 (the latest available) with ActiveTcl 8.6.7 (the latest
available), I'm building Python from latest master (to be 3.8.0). I'm
consistently having IDLE crash almost immediately, just by opening any file for
editing. The crash results
Change by Tal Einat :
--
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue34120>
___
___
Python-bugs-list mailing list
Un
Change by Tal Einat :
--
versions: +Python 2.7
___
Python tracker
<https://bugs.python.org/issue34120>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
Adding grab_release() calls also resolves the issue. Tested on mac and win.
PR updated with this approach, IMO ready for review.
--
___
Python tracker
<https://bugs.python.org/issue34
Tal Einat added the comment:
Confirmed on macOS 10.13.5 with the new Python 2.7.15 64-bit from python.org
which bundles Tcl/Tk 8.6.8.
The same fix works: Removing the grab_set() calls fixes the freezing after
closing the about and config dialogs
Tal Einat added the comment:
I can confirm that removing .grab_set() calls fixes this issue on macOS 10.13.5
with Python 3.7.0 from python.org.
Searching for those calls in all of IDLE's code lead me to discover additional
similar issues, e.g. with the search dialog and the text viewer
Change by Tal Einat :
--
keywords: +patch
pull_requests: +8110
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue34120>
___
_
Tal Einat added the comment:
Perhaps we can use .update_idletasks() rather than .update()? That tends to
have less of a performance hit. My macOS setup is currently not working so I
can't test this myself.
Regarding the "MacWindowStyle" call, IDLE is backported to older versions
Tal Einat added the comment:
Understood. Thanks for making the time and effort to clarify!
--
___
Python tracker
<https://bugs.python.org/issue33083>
___
___
Tal Einat added the comment:
Should this be closed as resolved?
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue33204>
___
___
Python-bug
Change by Tal Einat :
--
resolution: -> out of date
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
>> accepting non-integral floats but not non-integral Decimals and Fractions.
> I don't think anyone is proposing to accept non-integral floats. non-integral
> floats are _already_ rejected with a ValueError. Did you mean "integral"
>
Tal Einat added the comment:
As a user, I would find Mark's suggestion very confusing, accepting
non-integral floats but not non-integral Decimals and Fractions.
I agree that ideally it should accept only integral inputs, including floats,
but deprecating the behavior for non-integral
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue1467929>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
Ah, sorry Eric, I misread that change as you assigning this to yourself.
--
versions: +Python 3.8 -Python 3.2, Python 3.3
___
Python tracker
<https://bugs.python.org/issue1467
Tal Einat added the comment:
Serhiy, that would be a good idea. A short mention of the issue with a link to
an external reference would also suffice IMO.
--
___
Python tracker
<https://bugs.python.org/issue33
Tal Einat added the comment:
Eric, would you like an update PR for this?
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue1467929>
___
___
Tal Einat added the comment:
Clarification: The given pattern is equivalent to that in my previous post,
assuming the latter is used with the re.VERBOSE flag.
--
___
Python tracker
<https://bugs.python.org/issue33
Tal Einat added the comment:
I suggest closing this as "wontfix".
This is a just an non-optimized regexp pattern leading to long run times. That
these are possible is a well-known trait of backtracking regular expression
engines in general, and ours in particular.
IMO
Tal Einat added the comment:
So we keep things consistent by supporting Decimal and Fraction inputs, but
raising ValueError if the value isn't a non-negative integer?
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue33
Tal Einat added the comment:
A comment here is all that is needed.
--
___
Python tracker
<https://bugs.python.org/issue29750>
___
___
Python-bugs-list mailin
Tal Einat added the comment:
Never mind, I won't have time for this any time soon, better if someone else
can do it.
--
___
Python tracker
<https://bugs.python.org/issue29
Tal Einat added the comment:
See additional discussion in the duplicate issue19979.
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue9
Tal Einat added the comment:
ISTM that the docs need to be fixed for both 3.7+ and for 3.6.
The signature is indeed awkward for 3.6, but it's too minor a detail to address
considering it's no longer relevant for 3.7 and later.
--
assignee: -> docs@python
components: +Documentat
Tal Einat added the comment:
This does indeed seem to be a duplicate of issue9226.
--
nosy: +taleinat
resolution: -> duplicate
stage: test needed -> resolved
status: pending -> closed
superseder: -> erroneous behavior when creating classes insi
Tal Einat added the comment:
Ivan, can you supply a PR or would you like someone else to do so?
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue6
Tal Einat added the comment:
My guess would be the docs for socket.recv()[1], which indeed don't mention
what the return value is after a socket has been closed, nor can I find that
info elsewhere on that page.
Those docs for socket generally avoid going into detail, including specifically
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue33092>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
Mark, since you have a working version of this, perhaps you can supply some
performance benchmark results to help in making a decision?
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue33
Tal Einat added the comment:
Thanks for the PR, Aaron!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 2.7, Python 3.6
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
New changeset c0f0a7669c73c0d444851dd4c5299de2479214cc by Tal Einat (Aaron Ang)
in branch 'master':
bpo-28677: Improve phrasing of when instance attribute is referenced (GH-6208)
https://github.com/python/cpython/commit/c0f0a7669c73c0d444851dd4c5299de2479214cc
Tal Einat added the comment:
New changeset ec02c58f5a6fdb06b769f53255fcb5d393812160 by Tal Einat (Miss
Islington (bot)) in branch '3.7':
bpo-28677: Improve phrasing of when instance attribute is referenced (GH-6208)
https://github.com/python/cpython/commit
Tal Einat added the comment:
-1 on adding this to os.path given the existence in pathlib.
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue33
Tal Einat added the comment:
I'm closing this as "wontfix".
Amjad, if you'd like to discuss this further, please bring it up on
python-ideas.
Serhiy, as the expert for the os.path module, FYI.
--
nosy: +serhiy.storchaka
___
Pyth
Change by Tal Einat :
--
resolution: -> wont fix
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue33102>
___
801 - 900 of 1433 matches
Mail list logo
