Tim Golden added the comment:
In thread_nt.h:EnterNonRecursiveMutex the millisecond version (here: 2148000)
of the seconds you passed in are converted to microseconds (so: 214800).
This is then passed to condvar.h:PyCOND_TIMEDWAIT which expects a long, whose
32-bit limit is 2147483647. So
Tim Golden added the comment:
Fixed in 3.4 and later; 3.3 is no longer accepting patches
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 3.4 -Python 3.3
___
Python tracker
<http://bugs.python.or
Tim Golden added the comment:
Closing, as no-one's come back after my -0 for 6 months.
--
resolution: -> wont fix
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.pyt
Tim Golden added the comment:
Zach -- you've done most of the work on the VS projects lately. Would you mind
having a look at this one to see if it's still relevant, please?
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.o
Tim Golden added the comment:
This is essentially superseded now by the work done over on distutils-sig and
by the PyPA. (Which has included considering the differeng terminology of
installation vs other paths on Windows vs Unix).
--
resolution: -> wont fix
stage: needs pa
Tim Golden added the comment:
The attached patch adds an example to the shutil documentation showing how to
use an onerror handler to reattempt the removal of a read-only file. It's
deliberately low-tech and simply removes the attribute and retries. If there's
some other obstacl
Changes by Tim Golden :
--
keywords: +patch
Added file: http://bugs.python.org/file35168/issue19643-doc.patch
___
Python tracker
<http://bugs.python.org/issue19
Tim Golden added the comment:
The attached patch uses DWORD (essentially: unsigned long) in
condvar.h:PyCOND_TIMEDWAIT.
Adding Kristjan as it was his code.
--
keywords: +patch
nosy: +kristjan.jonsson
Added file: http://bugs.python.org/file35169/issue20737.condvar.patch
Changes by Tim Golden :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue20737>
___
___
Python-bugs-list mailing list
Unsubscrib
Tim Golden added the comment:
I'm at least +0.5 on this: I rather like the idea of forcing these things out
into the open.
The reason I'm not +1 is the danger of relatively benign or trivial
warnings-turned-errors getting in the way of real, possibly critical,
d
Tim Golden added the comment:
eryksun: could you essay a patch? I'd be happy to review & apply it.
--
nosy: +tim.golden
___
Python tracker
<http://bugs.python.or
Tim Golden added the comment:
Thanks, Zach. Updated patch.
--
assignee: -> tim.golden
Added file: http://bugs.python.org/file35170/issue19643-doc.2.patch
___
Python tracker
<http://bugs.python.org/issu
Tim Golden added the comment:
Thanks. I'll hold off pushing until I've had a chance to run it on a
Unix system. I'm not 100% whether it will operate in the same way there.
--
___
Python tracker
<http://bugs.pyt
Tim Golden added the comment:
Thanks for the feedback, Kristjan. You're obviously correct in that we
can't account for timeouts greater than DWORD-size milliseconds and your
proposed solution looks reasonable.
However, I'd like to close off *this* particular issue which turns
Tim Golden added the comment:
Just to be clear: the change *I'm* proposing for this issue has nothing
to do with limiting the wait, artificially or otherwise. It's simply
undoing an unintended conversion from unsigned to signed and back again,
whicih currently causes any wait of
Changes by Tim Golden :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Tim Golden added the comment:
Updated patch with unsigned long applied throughout
--
Added file: http://bugs.python.org/file35173/issue20737.condvar.2.patch
___
Python tracker
<http://bugs.python.org/issue20
Tim Golden added the comment:
+1 for Kristjan's latest patch. And thanks for working this through, Kristjan:
I'd missed the fact that the microseconds conversion could itself overflow even
an unsigned long.
--
___
Python trac
Tim Golden added the comment:
s/Py_LONG_LONG/PY_LONG_LONG/
--
___
Python tracker
<http://bugs.python.org/issue20737>
___
___
Python-bugs-list mailing list
Unsub
Tim Golden added the comment:
What effect does your patch have on a VS2010 build? VS2010 is the official
toolset for current Python 3.x versions so any changes we make must support
that.
Also: does the same problem occur on the development branch?
(De-selecting 3.2 as it's in securit
Tim Golden added the comment:
I can confirm that the attached test.py times out after 2150 seconds (ie
30+ minutes) with your (tweaked) patch applied:
python test.py 2150
Running Debug|Win32 interpreter...
2014-05-08 10:33:53.670091
Expected to time out by 2014-05-08 11:09:43.670091
Timed Out
Tim Golden added the comment:
Attached project patch seems to build successfully on VS2010. It's possible
that this failed in some way on VS2008; AFAICT it hasn't been touched since
Brian first ported it two years ago.
Adding Zach Ware for a second opinion.
--
nosy: +zach.
Tim Golden added the comment:
Here's a patch against build_ssl which uses subprocess.check_output and very
slightly simplifies the output. It successfully finds ActivePerl and builds
from source; and uses the svn export files when it's not.
I've targetted the development branch
Tim Golden added the comment:
I've just looked at issue21141 which is a substantial rework of this
area. This change should be incorporated over there as well / instead.
--
___
Python tracker
<http://bugs.python.org/is
Tim Golden added the comment:
I'm at least +0 on this, not because I've ever been that bothered by the Perl
messages, but because it tidies things up a little smooths the way very
slightly for people trying to build Python on Windows and I'm always ready t
Tim Golden added the comment:
Thanks for the check. Committed to 3.4 & default
--
resolution: -> fixed
___
Python tracker
<http://bugs.python.org/
Changes by Tim Golden :
--
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue10752>
___
___
Pyth
Tim Golden added the comment:
Fixed. Thanks for the report
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Tim Golden added the comment:
Builds & tests ok here on a fresh checkout (of cpython & openssl-1.0.1g)
--
nosy: +tim.golden
___
Python tracker
<http://bugs.python.org
Tim Golden added the comment:
Steve -- re changes to PCBuild &c.: worth liaising with Zach Ware (and, to a
lesser extent, me) as he's been working through a number of things in that area
and I know has other ideas.
Just post a patch and nosy us both (zach.ware / tim.golden)
Obvi
Changes by Tim Golden :
--
assignee: -> tim.golden
___
Python tracker
<http://bugs.python.org/issue21652>
___
___
Python-bugs-list mailing list
Unsubscrib
Tim Golden added the comment:
Only if you have something better to put in its place! That commit was
fixing an existing problem; perhaps not your problem, but someone's. To
revert it would simply move the pain around.
I hope to be able to work on this fairly soon. If anyone else wan
Tim Golden added the comment:
+1
--
___
Python tracker
<http://bugs.python.org/issue10136>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.pyth
Tim Golden added the comment:
On 02/11/2012 21:00, Andrew Svetlov wrote:
> I guess to return sh if supported, cmd.exe for Windows.
FWIW the canonical approach on Windows is to return whatever %COMSPEC%
points to.
--
nosy: +tim.golden
___
Pyt
Tim Golden added the comment:
I've got a patch for this which applies cleanly to the 3.4 tip. I still need to
sort out the Windows issues (which I don't think will be difficult; it looks
like a test issue, not a code issue)
--
assignee: -&g
Tim Golden added the comment:
I'm planning to refactor the tests and the code very slightly. When I've
got a reworked patch I'll ping it back to you to ensure it matches your
intent. IIUC you're implementing comma-separated lists {abc,def} and
nested braces {a{b,c}d,efg}
Tim Golden added the comment:
Attached is a refactored version of Mathieu's patch which, when applied to tip,
passes all tests.
--
Added file: http://bugs.python.org/file27894/0003-reworked-issue9584.patch
___
Python tracker
<http://bugs.py
Tim Golden added the comment:
Something went wrong with that patch; it doesn't include all the changes to
test_glob. I'll upload a newer patch later.
--
___
Python tracker
<http://bugs.python.
Tim Golden added the comment:
Scratch that last comment: the patch does apply. I've tested it against Windows
& Ubuntu. If no one comes in with any objections I'll commit it within the next
day.
--
___
Python tracker
<http:
Tim Golden added the comment:
Must have been something I did. I'll revert the commit and re-test.
--
___
Python tracker
<http://bugs.python.org/issue9584>
___
___
Tim Golden added the comment:
Well even in the original [working] version, the scope of this change
was limited to glob.glob. os.listdir doesn't currently support any form
of expansion (at least not on Windows) and nor does os.makedirs. I don't
see any problem in restricting this cha
Tim Golden added the comment:
Sorry, I misunderstood the point you were making with the
os.listdir/makedirs examples. Fair point about backwards compatibility.
This may make this change untenable as no-one will want a series of
use_feature_xxx flags, one for each change we introduce to glob.glob
Changes by Tim Golden :
Removed file: http://bugs.python.org/file27894/0003-reworked-issue9584.patch
___
Python tracker
<http://bugs.python.org/issue9584>
___
___
Pytho
Tim Golden added the comment:
Given that this isn't going to go ahead in its current form, and will need
wider discussion on python-dev, I'm unassigning myself and I've removed the
flawed version of the patch which I'd posted.
--
Tim Golden added the comment:
I'm sorry, but I genuinely can't see what you're trying to say here. If you
believe that there's a bug in Python's standard library, can you show a
reproducible *Python* testcase for it, please (using the pywin32 modules if
that helps) a
Changes by Tim Golden :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue16458>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tim Golden added the comment:
On 13/11/2012 20:57, Karthk Rajagopalan wrote:
> I added test case using perl and python since it was easy to
> reproduce using perl socket module and show the issue happening with
> python's subprocess.py. There is definitely an action required in
&
Tim Golden added the comment:
Start here: http://docs.python.org/devguide/
In particular: http://docs.python.org/devguide/patch.html
--
___
Python tracker
<http://bugs.python.org/issue16
Tim Golden added the comment:
Karthk, if you can run up an up-to-date patch and a test I'm willing to review
and commit it, otherwise this one will lie quiet.
--
___
Python tracker
<http://bugs.python.org/is
Tim Golden added the comment:
Not Python, but Windows. See here:
http://msdn.microsoft.com/en-gb/library/windows/desktop/aa384187%28v=vs.85%29.aspx
--
nosy: +tim.golden
___
Python tracker
<http://bugs.python.org/issue16
Tim Golden added the comment:
Does the same problem obtain if you use os.putenv (which calls the crt
putenv under the covers)?
--
nosy: +tim.golden
___
Python tracker
<http://bugs.python.org/issue16
Tim Golden added the comment:
Sorry; late to the party. I'll try to take a look at the patches.
Basically I'm sympathetic to the problem (which seems quite
straightforwardly buggish) but I want to take a look around the issue f
Tim Golden added the comment:
This code is no longer present in subprocess.py now that issue14470 has been
applied.
--
nosy: +brian.curtin, tim.golden
resolution: -> out of date
stage: -> committed/rejected
status: open -> closed
_
Tim Golden added the comment:
Reopening because there is in fact a doc issue reamining.
--
assignee: -> tim.golden
resolution: out of date ->
stage: committed/rejected ->
status: closed -> open
___
Python tracker
<http://
Tim Golden added the comment:
I can't push from work; the (trivial) doc patch is attached. If no-one gets to
it, I'll push from home this evening.
--
Added file: http://bugs.python.org/file28688/doc.diff
___
Python tracker
<http://bu
Tim Golden added the comment:
My use case is the reloader or restarter. I've initially fallen foul of this
when using the cherrypy reloader (which does an execv by building from
sys.executable + sys.argv) but I also have web services running which I'd like
to restart remotely by fo
Tim Golden added the comment:
I can confirm that 2.7.2 hard-crashes as described on Windows. I'm not
sure if I have the wherewithal to build 2.7 on this laptop to see if
it's fixed in tip.
3.3 simply raises an IOError.
--
___
Python trac
Tim Golden added the comment:
Closing as "Works for me" in the absence of any clear proposal for docs
improvement.
--
resolution: -> works for me
stage: needs patch -> committed/rejected
status: open -> closed
___
Py
Tim Golden added the comment:
It doesn't work on Python 2.x either as delivered. Usually means you
have an external readline module installed.
--
nosy: +tim.golden
___
Python tracker
<http://bugs.python.org/is
Tim Golden added the comment:
I'm at best +0.25, but I don't have a problem with Ctrl-D exiting on
Windows, as it doesn't do anything else!
The thing is, though, that this is all handled within
myreadline.c:my_fgets which is a call into the system fgets which errors
out
Tim Golden added the comment:
Nope. Looks like a mistake. Confusingly, the header refers to VC++ 10.0
which is VS 2010 (I think). AFAICT a global s/2008/2010/ would be the
thing to do.
--
___
Python tracker
<http://bugs.python.org/issue19
Tim Golden added the comment:
I'll try to pick this one up over the next few days. Feel free to ping me if it
drops into silence!
--
assignee: -> tim.golden
___
Python tracker
<http://bugs.python.org
Tim Golden added the comment:
In reality (as I'm sure you can guess) it's just that no-one's got to
the point of fixing it. I did start off, but it's not a trivial fix and
clearly it got sidelined (with no-one shouting). Sometimes that's just
the way it is.
I'll
Tim Golden added the comment:
I was surprised that GetVersionEx would lie. But sure enough. Here:
http://social.msdn.microsoft.com/Forums/windowsdesktop/en-US/c471de52-611f-435d-ab44-56064e5fd7d5/windows-81-preview-getversionex-reports-629200
(Including a heartfelt comment by long-time Python
Tim Golden added the comment:
I've just installed a Win 8.1 VM and can (unsurprisingly) confirm the
report: The "ver" command shows 6.3.9600 while GetVersionEx and
consequently sys.getwindowsversion report 6.2.9200
We do use GetVersionEx in a few other places (timemodule.c,
Tim Golden added the comment:
platform.platform & platform.uname are also affected although they already use
"ver"-parsing in some circumstances so could presumably fallback to that
approach here as well.
--
nosy: +lemburg
___
Python
Tim Golden added the comment:
This was implemented after discussion in issue1115886:
http://bugs.python.org/issue1115886
and python-dev:
https://mail.python.org/pipermail/python-dev/2007-March/071557.html
In short, it could have gone either way and it went this way.
--
nosy
Changes by Tim Golden :
--
resolution: -> wont fix
stage: -> committed/rejected
___
Python tracker
<http://bugs.python.org/issue19191>
___
___
Python-bugs-
Tim Golden added the comment:
*cough* Somehow that didn't actually get pushed. Rebased against 2.7, 3.3 & 3.4
and pushed.
--
assignee: -> tim.golden
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
v
Tim Golden added the comment:
I don't feel strongly about this. However, ISTM that we work reasonably
hard to work with the vagaries of *nix toolchains so I don't see why an
unintrusive change like this shouldn't go in to support some corner
cases on th
Tim Golden added the comment:
Ok by me: build and tests all ok.
--
___
Python tracker
<http://bugs.python.org/issue17791>
___
___
Python-bugs-list mailin
Tim Golden added the comment:
Just picking this up. Considering testing... My current proposal is to add
junction point support to _winapi, initially for the sole purpose of testing
this change, but with a view to possibly supporting it formally via the os
module. Any better ideas
Tim Golden added the comment:
Sounds like a decent plan to me. Good luck with the buffer sizing!
--
___
Python tracker
<http://bugs.python.org/issue18314>
___
___
Tim Golden added the comment:
Just revisited this to see if I could close off. One thing occurred to me which
should have come up before: this situation will be aggravated by WOW64 file
redirection.
If I run 64-bit Python on 64-bit Windows I can successfully stat links in
%windir%\system32
Tim Golden added the comment:
I've looked this over and, basically, +1. We could argue the toss back and
forth over changes, but I think the changes do the right amount of
cruft-clearing and avoid the danger of being a mere reflection of one person's
aesthetic choices over another
Tim Golden added the comment:
Retargetted patch against current tip. If no-one objects I'll commit this in
the next day or two.
--
assignee: -> tim.golden
Added file: http://bugs.python.org/file32326/pcbuild.diff.2
___
Python tracke
Changes by Tim Golden :
--
nosy: -tim.golden
___
Python tracker
<http://bugs.python.org/issue11566>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Tim Golden :
--
nosy: -tim.golden
___
Python tracker
<http://bugs.python.org/issue6839>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Tim Golden :
--
nosy: -tim.golden
___
Python tracker
<http://bugs.python.org/issue14112>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Tim Golden :
--
nosy: -tim.golden
___
Python tracker
<http://bugs.python.org/issue6335>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Tim Golden :
--
nosy: -tim.golden
___
Python tracker
<http://bugs.python.org/issue2889>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Tim Golden :
--
nosy: -tim.golden
___
Python tracker
<http://bugs.python.org/issue6672>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Tim Golden :
--
nosy: -tim.golden
___
Python tracker
<http://bugs.python.org/issue16472>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tim Golden added the comment:
Just housekeeping some Windows calls: Antoine, your last comment suggests that
this is no longer an issue. I don't have a VirtualBox install to test, so can
you confirm whether this can be closed?
--
___
Python tr
Changes by Tim Golden :
--
nosy: -tim.golden
___
Python tracker
<http://bugs.python.org/issue949667>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Tim Golden :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue10179>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Tim Golden :
--
resolution: -> out of date
stage: -> committed/rejected
___
Python tracker
<http://bugs.python.org/issue10179>
___
___
Pyth
Tim Golden added the comment:
I'm running Win7 and have the same problem, with a fresh checkout and the eol
extension disabled. The attached (updated) patch does solve the issue. I can't
see any reason not to apply it, even if it's not needed in many cases.
--
A
Changes by Tim Golden :
--
resolution: -> wont fix
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Tim Golden added the comment:
I'm going to close this as won't fix: the underlying implementation is simply
calling GetFullPathName and removal of trailing spaces doesn't seem too
surprising a result. It is possible to manipulate such files using Windows'
special \\?\C:\
Changes by Tim Golden :
--
nosy: -tim.golden
___
Python tracker
<http://bugs.python.org/issue16632>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tim Golden added the comment:
normpath doesn't really buy anything here as abspath already has the same
effect (plus more). Patch attach removes normcase|path leaving only abspath.
--
___
Python tracker
<http://bugs.python.org/is
Tim Golden added the comment:
If no-one objects, I'll commit in a day or two.
--
Added file: http://bugs.python.org/file32328/issue14255.diff
___
Python tracker
<http://bugs.python.org/is
Tim Golden added the comment:
Santoso Wijaya: sorry for the delay. If you'd like to retarget your patch
against the tip, I'm happy to apply. At this stage, 3.3 and 3.4 seem the
appropriate branches.
--
assignee: -> tim.golden
versions: -Python 2.
Changes by Tim Golden :
--
nosy: -tim.golden
___
Python tracker
<http://bugs.python.org/issue14208>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Tim Golden :
--
nosy: -tim.golden
___
Python tracker
<http://bugs.python.org/issue16353>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Tim Golden :
--
nosy: -tim.golden
___
Python tracker
<http://bugs.python.org/issue18199>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Tim Golden :
--
nosy: -tim.golden
___
Python tracker
<http://bugs.python.org/issue14027>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Tim Golden :
--
assignee: -> tim.golden
___
Python tracker
<http://bugs.python.org/issue4905>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Tim Golden :
--
versions: +Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue4905>
___
___
Python-bugs-list mailing list
Unsub
301 - 400 of 607 matches
Mail list logo