Tres Seaver tsea...@agendaless.com added the comment:
This fix needs backporting to the 3.1 and 2.7 branches as well.
--
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10360
Tres Seaver tsea...@agendaless.com added the comment:
georg.brandl (2010-12-03 10:20):
Don't worry, it will be ported.
When? Why would it *not* be merged to the 2.7 and 3.1 branches at the
time the bug is closed? Delaying the port only increases the chance
that the fix will fall between
Tres Seaver tsea...@agendaless.com added the comment:
For the sake of completeness: the Zope2 trunk and its current stable
branch now no longer use the multifile module, thanks to the following
patch:
http://svn.zope.org/Zope/trunk/src/OFS/tests/testRanges.py?rev=110704r1=110402r2=110704
Tres Seaver tsea...@agendaless.com added the comment:
The attached patch adds Mark's examples to test_pickle as a failing test.
--
nosy: +tseaver
Added file: http://bugs.python.org/file17509/issue1692335-tests.patch
___
Python tracker rep
Tres Seaver tsea...@agendaless.com added the comment:
This bug exists in Python 2.6 and 3.1, which are still being maintained, AFAIK.
--
versions: +Python 2.6, Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1574217
New submission from Tres Seaver tsea...@agendaless.com:
Because application code which tests for the presence of
an object in a WeakSet may not be able to ensure that the
object is weak-referenceable, the set should just return
False for any object passed to '__contains__' which causes
'ref
Changes by Tres Seaver tsea...@agendaless.com:
--
components: +Library (Lib)
keywords: +patch
Added file: http://bugs.python.org/file19545/issue10360.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10360
Changes by Tres Seaver tsea...@agendaless.com:
Removed file: http://bugs.python.org/file19545/issue10360.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10360
Tres Seaver tsea...@agendaless.com added the comment:
A new version of the patch, which only traps TypeErrors raises
by ref(item). The test now ensures that hashing errors are
propagated, for compatibility with standard sets.
--
Added file: http://bugs.python.org/file19546/issue10360
Changes by Tres Seaver tsea...@agendaless.com:
Removed file: http://bugs.python.org/file19546/issue10360-redux.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10360
Tres Seaver tsea...@agendaless.com added the comment:
One more time, with feeling.
Sorry for the noise, the last patch was not against the 2.7 trunk.
--
Added file: http://bugs.python.org/file19547/issue10360-redux.patch
___
Python tracker rep
Tres Seaver tsea...@agendaless.com added the comment:
FTR, the patch applies cleanly to the py3k branch, too. (Michael
pointed out that the original code was copied directly from there).
--
___
Python tracker rep...@bugs.python.org
http
Changes by Tres Seaver tsea...@agendaless.com:
--
versions: +Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10360
___
___
Python-bugs
Tres Seaver tsea...@agendaless.com added the comment:
WeakKeyDictionary's __contains__:
def __contains__(self, key):
try:
wr = ref(key)
except TypeError:
return 0
return wr in self.data
New submission from Tres Seaver tsea...@agendaless.com:
2.7 has a new DeprecationWarning inside the build_ext command for code
which sets the 'compiler' to anything other than a string or None.
Because the warning occurs within property getter / setters, it needs
to boost the stacklevel
New submission from Tres Seaver tsea...@agendaless.com:
Import of the multifile module emits a DeprecationWarning, but the
warning is either incomplete:
- The documentation[1] states that the 'email' module is to be
preferred, but doesn't describe what APIs should be used from that
module
Tres Seaver tsea...@agendaless.com added the comment:
[T]here [may be] things you can do with multifile that you can't (yet)
do with the facilities from the email package. If so, these will most
likely be considered bugs in the email package.
Surely the presence of such a feature would
Tres Seaver tsea...@agendaless.com added the comment:
Could you do me a favor and add that use case the set of use cases in
the email wiki?
Done. The code in Zope which still uses 'multifile' is in the tests
for HTTP 'Range' support:
http://svn.zope.org/*checkout*/Zope/trunk/src/OFS
Tres Seaver tsea...@agendaless.com added the comment:
The fix for this bug breaks any code which worked with non-standard
schemes in 2.6.4 (by working around the issue). This kind of backward
incompatibility should be called out prominently in NEWS.txt (assuming
that such a fix is considered
Tres Seaver tsea...@agendaless.com added the comment:
I can confirm that the patch applies cleanly to the 2.6 branch, that the new
test fails before rebuilding, and that the test passes afterwards:
$ hg summary
parent: 41597:295c02a21979 tip
[svn r80597] Merged revisions 80596 via svnmerge
Changes by Tres Seaver tsea...@agendaless.com:
--
versions: +Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1574217
___
___
Python-bugs
Tres Seaver tsea...@agendaless.com added the comment:
I can confirm that:
- the patch applies cleanly to the release26-maint branch, with the
exception of the Misc/NEWS portion::
$ hg branch
release26-maint
$ ./python -E -tt Lib/test/regrtest.py test_file
test_file
1 test OK
Tres Seaver tsea...@agendaless.com added the comment:
I'm uploading a saner version of the speed test which uses timeit's support for
passing a callable as a statement: it is much easier to
see what the test is actually doing.
On my machine, running against the release26-maint branch, my
Tres Seaver tsea...@agendaless.com added the comment:
I don't have a host where I actually use netgroups in /etc/groups, and so can't
provoke the bug::
$ hg branch
release26-maint
$ make
...
$ ./python -E -tt Lib/test/regrtest.py test_grp
test_grp
1 test OK.
I can verify
Tres Seaver tsea...@agendaless.com added the comment:
The attached patch fixes the OP's use case on the Python side by re-ordering
the tests, such that always prevents the short-circuit from firing::
$ ./python
Python 2.6.5+ (release26-maint, Apr 29 2010, 21:24:12)
[GCC 4.3.3] on linux2
Tres Seaver tsea...@agendaless.com added the comment:
This patch tidies up the FilterWarnings tests to nomalize use of
'self.assertEquals' (matching the rest of the module) and make the
'test_always' assertions meaningful.
--
Added file: http://bugs.python.org/file17144/issue4180
Tres Seaver tsea...@agendaless.com added the comment:
This patch adds tests for the 'error', 'ignore', and 'always' filters being
applied *after* the default warning has been issued, and therefore the registry
populated. It causes failures for the 'error' and 'always' on both the Python
Tres Seaver tsea...@agendaless.com added the comment:
This patch replaces my earlier 'py_warnings' patch. It revamps the Python side
to check filters before deciding not to emit the warning based on the registry.
The new filter_after_default tests pass on the Python side with this patch
Tres Seaver tsea...@agendaless.com added the comment:
Updated patch against the trunk attached.
Note that I prefer unidiff myself, but was following a bit of guidance that
Guido (used to, anyway) prefer context diffs.
The updated speed test run against the stdlib with this patch shows only
Tres Seaver tsea...@agendaless.com added the comment:
The patch looks obviously correct to me.
I can confirm that the patch applies cleanly both to the trunk and to the
'release26-maint' branch, and that the 'test_gc' tests pass in both cases after
applying it and rebuilding.
--
nosy
Changes by Tres Seaver tsea...@agendaless.com:
--
versions: +Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4687
___
___
Python-bugs
Tres Seaver tsea...@agendaless.com added the comment:
This bug exists on Python 2.6, too.
It seems to me that the right solution here is to use both opened files as
context managers. See attached patch (made against the release26-maint branch).
The patch also cleans up the old-style
Changes by Tres Seaver tsea...@agendaless.com:
--
versions: +Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4265
___
___
Python-bugs
Tres Seaver tsea...@agendaless.com added the comment:
The patch doesn't apply cleanly to trunk. Attached is one which does.
--
Added file:
http://bugs.python.org/file17186/issue4265_shutil_copyfile-trunk.patch
___
Python tracker rep
Tres Seaver tsea...@agendaless.com added the comment:
The patch applies cleanly to the 2.6 branch, and with minimal fuzz to
the trunk. Exsting tests pass in both cases, as does the new test.
The added testcase seems plainly correct.
The first hunk of the diff to Lib/xml/dom/minidom.py
Tres Seaver tsea...@agendaless.com added the comment:
I can confirm that the patch applies cleanly to the release26-maint
branch, and that the updated test fails without the updated
implementation.
However, the entire approach seems wrong to me: the patched method
has just called 'request_path
Tres Seaver tsea...@agendaless.com added the comment:
BZ2File objects already support the context manager protocol on the trunk, as
of Antoine Pitrou's fix for http://bugs.python.org/issue3860
--
nosy: +tseaver
___
Python tracker rep
Tres Seaver tsea...@agendaless.com added the comment:
I can confirm that the patch applies with minimal fuzz to the
release26-maint branches and the trunk, and that the added tests fail
without the updated implementation in both cases.
Furthermore, Jim's original demo script emits it error
Tres Seaver tsea...@agendaless.com added the comment:
I'm afraid the patch no longer applies cleanly to the trunk, although
at least updating the docs should be easier now that they are converted
to ReStructuredText.
The tests in the patch for the new feature seem sensible.
--
nosy
Tres Seaver tsea...@agendaless.com added the comment:
I would be glad to write those tests, if you could explain the strategy you
have in mind more fully: since 'shutil.copyfile' performs the 'open' itself, I
couldn't figure out how to stub in such a mocked up file.
Does 'open' provide
Tres Seaver tsea...@agendaless.com added the comment:
This patch adds tests for the four edge cases (opening source fails, opening
dest fails, closing dest fails, closing source fails).
--
Added file:
http://bugs.python.org/file17229/issue4265-test_copyfile_exceptions.patch
Tres Seaver tsea...@agendaless.com added the comment:
Trying pthread_sigmask first, and falling back, seems like the right strategy
to me.
--
nosy: +tseaver
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8407
Tres Seaver tsea...@agendaless.com added the comment:
As long as we don't care about preserving backward compatibility, we
could indeed just change the behavior of 'request_path'. It isn't
documented as an API of the cookielib module, but it does have a
docstring which promises certain
Tres Seaver tsea...@agendaless.com added the comment:
I can only reiterate that Zope apps can call 'urllib.quote' dozens,
hundreds, even thousands of times on a single request: the
reason for the original bug report was that 'urllib.quote' was
showing up frequently on profiling output
Changes by Tres Seaver tsea...@agendaless.com:
--
nosy: -tseaver
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2091
___
___
Python-bugs-list
New submission from Tres Seaver:
A test of the 'persistent' package C extension segfaults under 3.3,
but completes successfully under 3.2. The C function being tested
is a wrapper around PyType_GenericNew:
static PyObject *
simple_new(PyObject *self, PyObject *type_object
Tres Seaver added the comment:
I can reproduce the bug against the 2.7 tip.
Reviewing the 2.7 patch:
- The 2.7 tip has 'Misc/ACKS' instead of 'Doc/ACKS.txt'.
- In 'Misc/ACKS', the line adding 'Chris McDonough' should add it in alpha
order.
- The remainder of the patch looks correct
Tres Seaver added the comment:
The latest 2.7 patch does not cause the following tests (from
issue 1692335) to pass:
http://bugs.python.org/file17509/issue1692335-tests.patch
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Tres Seaver added the comment:
Looks good to me.
--
nosy: +tseaver
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10211
___
___
Python-bugs-list
Tres Seaver added the comment:
Patch looks good to me. I would call it a bugfix, not a feature.
--
nosy: +tseaver
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10212
Changes by Tres Seaver tsea...@agendaless.com:
--
nosy: -tseaver
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8407
___
___
Python-bugs-list
Tres Seaver tsea...@users.sourceforge.net added the comment:
Sidnei da Silva had to put some straddling code in the Zope2 trunk to
workaround the 2.6 changes to asyncore / asynchat:
- http://svn.zope.org/Zope/?rev=91981view=rev
- http://svn.zope.org/Zope/?rev=92023view=rev
--
nosy
Tres Seaver tsea...@agendaless.com added the comment:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Guido van Rossum wrote:
ISTR that Zope has or had significant monkeypatches to at least one of
asyncore/asynchat. The resulting coupling between Zope and asyn* has
meant that the de-facto API
New submission from Tres Seaver tsea...@agendaless.com:
I'm working on cleaning up deprecations for Zope and related
packages under Python 2.6. The irony here is that I'm receiving
deprecation warnings for custom exception classes which had a 'message'
attribute long before the abortive
Changes by Tres Seaver <tsea...@agendaless.com>:
--
title: Include/opcode.h is modified during building -> permissions
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Changes by Tres Seaver <tsea...@agendaless.com>:
--
title: permissions -> Include/opcode.h is modified during building
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Tres Seaver added the comment:
ISTM that this issue should be re-opened, because it breaks out-of-tree
building from a pristine / read-only source tree. If they are "public"
headers, files like 'opcode.h' should be generated and checked in as part of
the release process, rather tha
57 matches
Mail list logo
