Vajrasky Kok added the comment:
See also: http://bugs.python.org/issue1311
--
nosy: +vajrasky
___
Python tracker
<http://bugs.python.org/issue20541>
___
___
Pytho
Vajrasky Kok added the comment:
The culprit:
diff -r b4e99bec0c8a Lib/test/test_codecs.py
--- a/Lib/test/test_codecs.py Fri Feb 07 10:10:55 2014 +0200
+++ b/Lib/test/test_codecs.py Fri Feb 07 17:14:12 2014 +0800
@@ -164,6 +164,8 @@
s = 10*(size*"a" + lineen
Changes by Vajrasky Kok :
Removed file: http://bugs.python.org/file33587/clinic_longobject.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bug
Vajrasky Kok added the comment:
Here is the updated patch for long object. A couple of functions that can not
be converted:
- long_new
It has custom processing before parsing arguments part.
- long_round
Not supported by clinic.
_ __trunc__, __floor__, __ceil__ all are mapped to long_long
Changes by Vajrasky Kok :
Removed file: http://bugs.python.org/file33944/clinic_gc_v2.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bug
Vajrasky Kok added the comment:
Here is the updated patch for gc module based on Zachary's review.
--
Added file: http://bugs.python.org/file33951/clinic_gc_v3.patch
___
Python tracker
<http://bugs.python.org/is
Vajrasky Kok added the comment:
About rlimit, I think we can use negative number for any member of the struct.
But the thing is I am not really sure whether it's okay or not. So it's better
on the safe side.
I'll finish longobject in
Changes by Vajrasky Kok :
Removed file: http://bugs.python.org/file33477/clinic_gc.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bugs-list m
Vajrasky Kok added the comment:
Here is the updated patch for gc module.
Some functions that can not be converted:
- set_threshold(threshold0, [threshold1, threshold2])
Don't know what default value to give to threshold1, threshold2.
static struct gc_generation generations[NUM_GENERA
Changes by Vajrasky Kok :
Removed file: http://bugs.python.org/file33931/issue20185_conglomerate_v3.diff
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Vajrasky Kok added the comment:
Here is the updated patch. I missed the 'unaryfunc' part. :) Yeah, it's weird.
I run clinic again and the dump buffer was getting smaller again.
--
Added file: http://bugs.python.org/file33943/issue20185_congl
Vajrasky Kok added the comment:
It works. I chose Christian Heimes' strategy because of:
char ** completion_matches (char *text, CPFunction *entry_func)
in
http://web.mit.edu/gnu/doc/html/rlman_2.html
--
___
Python tracker
<http://bugs.py
New submission from Vajrasky Kok:
On Fedora 20, I got this compiler warning:
/home/sky/Code/python/cpython3.4/Modules/readline.c: In function
‘flex_complete’:
/home/sky/Code/python/cpython3.4/Modules/readline.c:962:5: warning: passing
argument 1 of ‘completion_matches’ discards ‘const
Vajrasky Kok added the comment:
Zachary, "Looking again, that one is non-trivial, but still doable. You just
need a "this means an error happened" value to initialize rl to, and return
that value instead of NULL."
How do you give "this means an error happened" v
Vajrasky Kok added the comment:
Here is the patch addressing Zachary's review (Thanks!). There are some
Zachary's suggestions that I could not implement:
1. float_conjugate_impl,/* nb_float */
I think this should still be the real function (the parser), not the impl.
Vajrasky Kok added the comment:
"But there are some errors that really need two filenames, like copy(),
symlink(), and rename()."
I think *need* is too strong word in this case. I agree that two filenames is
better than none. But I don't see anything wrong from omitting file
Vajrasky Kok added the comment:
Here is the updated patch after Larry's commit to clinic. Everything is
included except codecsmodule.
--
Added file: http://bugs.python.org/file33895/issue20173_conglomerate.patch
___
Python tracker
Vajrasky Kok added the comment:
Here is the updated patch addressing Zachary's reviews (Thanks!). However,
there are some reviews that I could not implement.
1. "This is a good candidate for a custom return converter."
I can not synchronize struct rlimit and NULL return values.
Vajrasky Kok added the comment:
The converters argument in command line is still broken.
[sky@localhost cpython3.4]$ hg pull -u
pulling from http://hg.python.org/cpython
searching for changes
no changes found
[sky@localhost cpython3.4]$ ./python Tools/clinic/clinic.py --converters
Legacy
Vajrasky Kok added the comment:
Here is the patch to accommodate Serhiy's request. I added new test soutside
CommandLineTest. The fix always uses sys.stdout.encoding. The test_list_command
and test_list_command_verbose uses testtarnames now.
--
Added file:
http://bugs.pytho
Vajrasky Kok added the comment:
Here is the updated patch for float object based on Zachary and Serhiy's
reviews. Some methods that can not be converted are:
__getnewargs__, __round__, float_new.
So these files are ready for Python 3.4: resource, typeobject, listobject, and
floato
Vajrasky Kok added the comment:
I am doing clinic conversion for marshal module so I am adding myself to nosy
list to make sure both tickets are synchronized.
http://bugs.python.org/issue20185
--
nosy: +vajrasky
___
Python tracker
<h
Vajrasky Kok added the comment:
Here is the updated patch for marshal module based on Zachary's review.
--
Added file: http://bugs.python.org/file33769/clinic_marshal_v4.patch
___
Python tracker
<http://bugs.python.org/is
Vajrasky Kok added the comment:
Forgot to say that, in list module, anything is convertable except __getitem__.
--
___
Python tracker
<http://bugs.python.org/issue20
Vajrasky Kok added the comment:
Here is the updated patch for list module based on Zachary and Serhiy's reviews.
--
Added file: http://bugs.python.org/file33767/clinic_listobject_v4.patch
___
Python tracker
<http://bugs.python.org/is
Vajrasky Kok added the comment:
Here is the updated patch for type module based on Zachary's comment.
However, I can not convert this method.
{"__subclasshook__", object_subclasshook, METH_CLASS | METH_VARARGS,
object_subclasshook_doc},
static PyObject *
object_subclasshoo
Vajrasky Kok added the comment:
Status:
Modules/sha1module.c: done
Modules/sha256module.c: done
Modules/sha512module.c: done
Modules/md5module.c: done
All of them are ready for Python 3.4.
/* AC 3.5: optional positional arguments */
Modules/_codecsmodule
Vajrasky Kok added the comment:
Here is the updated patch for resource module based on Zachary's comment.
--
Added file: http://bugs.python.org/file33744/clinic_resource_v2.patch
___
Python tracker
<http://bugs.python.org/is
Vajrasky Kok added the comment:
Here is the updated patch for md5module after changes from Larry to clinic.
--
Added file: http://bugs.python.org/file33743/clinic_md5module_v3.patch
___
Python tracker
<http://bugs.python.org/issue20
Vajrasky Kok added the comment:
Here is the updated patch for sha512module after changes from Larry to clinic.
--
Added file: http://bugs.python.org/file33742/clinic_sha512module_v3.patch
___
Python tracker
<http://bugs.python.org/issue20
Vajrasky Kok added the comment:
How to handle this "problem" in Python maintenance releases (2.7, 3.3 and
soon-to-be 3.4) is being discussed here:
https://mail.python.org/pipermail/python-dev/2014-January/132101.html
In case, we are taking "backporting the full fix" road,
Vajrasky Kok added the comment:
Here is the updated patch for sha256module after changes from Larry to clinic.
--
Added file: http://bugs.python.org/file33739/clinic_sha256module_v3.patch
___
Python tracker
<http://bugs.python.org/issue20
Vajrasky Kok added the comment:
Here is the updated patch for sha1module after changes from Larry to clinic.
--
Added file: http://bugs.python.org/file33737/clinic_sha1module_v5.patch
___
Python tracker
<http://bugs.python.org/issue20
Vajrasky Kok added the comment:
I already have a patch addressing your concerns, Serhiy. But before I upload it
here, some questions:
1. "Yes, we can add unencodable tarinfo.linkname later. Just add tests for
external tar files." You mean, we need to create a tar file containing
u
Vajrasky Kok added the comment:
Larry said, "A proper fix for the "bug" will require changing the semantics of
the function.
It's inappropriate to do that in 2.7, 3.3, and (now that we're in beta) 3.4."
I think we can not have it all and need to be pragmatic in
Vajrasky Kok added the comment:
Larry said, "It behaves differently depending on whether "times" is passed by
position or by keyword."
And that is the bug. It should be the same no matter whether we send times
through positional or keyword. As Raymond has said earlier
Vajrasky Kok added the comment:
def repeat(object, times=-1): => it could break the code in the wild.
Current behaviour: repeat(object) -> unlimited, repeat(object, -1) -> 0
repetitions.
--
___
Python tracker
<http://bugs.python.or
Vajrasky Kok added the comment:
Here is the updated patch. I try to be conservative here, preserving the
current behaviour.
Negative times is same as zero.
Default value (which can be passed by omitting times) means unlimited.
I did not change the signature "repeat(object [,times])&quo
Vajrasky Kok added the comment:
Here is the updated patch based on Ezio's review. Sorry, for a long time, I
didn't notice you had reviewed my code, Ezio. Thanks for the review!
--
Added file:
http://bugs.python.org/file33679/fix_resource_warning_read_mime_type
Vajrasky Kok added the comment:
Serhiy said, "Why do you cast PyDict_Size(kwds) to int?"
Sorry, Serhiy! Today I just realized there is your review for this ticket. I
couldn't really remember but I think I got conversion warning if I did not
downcast it. Something about I sho
Vajrasky Kok added the comment:
Updated marshal patch. I just learned we don't need to release pybuffer (y*)
manually.
--
Added file: http://bugs.python.org/file33678/clinic_marshal_v3.patch
___
Python tracker
<http://bugs.python.org/is
Vajrasky Kok added the comment:
Here is the updated patch of codecsmodule, based on Larry's review. Thanks! I
didn't realize clinic releases pybuffer implicitly. I also turned
_codecs.Codecs to _codecs since all of these methods are module methods.
--
Added
Vajrasky Kok added the comment:
Here is the updated patch of md5module, based on Larry's review. Thanks!
--
Added file: http://bugs.python.org/file33652/clinic_md5module_v2.patch
___
Python tracker
<http://bugs.python.org/is
Vajrasky Kok added the comment:
Here is the updated patch of sha512module, based on Larry's review. Thanks!
--
Added file: http://bugs.python.org/file33650/clinic_sha512module_v2.patch
___
Python tracker
<http://bugs.python.org/is
Vajrasky Kok added the comment:
Here is the updated patch of sha256module, based on Larry's review. Thanks!
--
Added file: http://bugs.python.org/file33649/clinic_sha256module_v2.patch
___
Python tracker
<http://bugs.python.org/is
Vajrasky Kok added the comment:
Here is the updated patch of sha1module, based on Larry's review. Thanks!
--
Added file: http://bugs.python.org/file33646/clinic_sha1module_v4.patch
___
Python tracker
<http://bugs.python.org/is
Vajrasky Kok added the comment:
This is updated patch for marshal incorporating the fixes from clinic. Now, I
can use 'bytes' named argument and default value of marshal.version instead of
hardcoded number.
--
Added file: http://bugs.python.org/file33644/clinic_marsha
Vajrasky Kok added the comment:
Here is the patch for floatobject. I did not convert 2 sites. The first is the
round method which clinic explicitly does not support. The second one is the
new method. This is the snippet of new method:
float_new(PyTypeObject *type, PyObject *args, PyObject
Vajrasky Kok added the comment:
Thanks, Serhiy, for the pointer. Now, I am able to convert the method using
_PyEval_SliceIndex function.
Sorry, Larry. I used optional groups in __init__ because I didn't know about
unspecified.
Here is the updated patch for listobject. One thought
Vajrasky Kok added the comment:
Here is the patch for listobject. A couple of thoughts:
1. I can not convert this signature:
if (!PyArg_ParseTuple(args, "O|O&O&:index", &v,
_PyEval_SliceIndex, &start,
Vajrasky Kok added the comment:
>>> itertools.repeat.__doc__
'repeat(object, times=None)\nReturns an iterator which returns the object the
specified number of times.\n\nIf times is None, returns the object endlessly.'
>>> itertools.repeat('a', times=
Changes by Vajrasky Kok :
Added file:
http://bugs.python.org/file33610/fix_tarfile_list_print_lone_surrogate_v3.patch
___
Python tracker
<http://bugs.python.org/issue19
Changes by Vajrasky Kok :
Removed file:
http://bugs.python.org/file33608/fix_tarfile_list_print_lone_surrogate_v3.patch
___
Python tracker
<http://bugs.python.org/issue19
Vajrasky Kok added the comment:
Here is the patch addressing some of Serhiys concerns. Thanks for the review.
There are some things that I could not make it up:
1. The test for unencodable tarinfo.linkname is not done yet, because maybe it
is better to be done in a separate ticket. To make the
Changes by Vajrasky Kok :
--
title: Argument Clinic: self converters are not preserved when clonig functions
-> Argument Clinic: self converters are not preserved when cloning functions
___
Python tracker
<http://bugs.python.org/issu
Vajrasky Kok added the comment:
Here is the patch for longobject. There are two sites which I couldn't convert.
The first is the constructor which is complicated. The other one is __round__
which clinic explicitly does not support.
--
Added file: http://bugs.python.org/file
Changes by Vajrasky Kok :
Added file: http://bugs.python.org/file33562/clinic_typeobject.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bug
Changes by Vajrasky Kok :
Removed file: http://bugs.python.org/file33561/clinic_typeobject.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bug
Vajrasky Kok added the comment:
Here is the patch for typeobject. I didn't convert the new method. It's so
complicated. It counts whether how many arguments or keywords you pass. It
asserts the args before parsing the args. I don't think clinic supports this.
This is the code:
Vajrasky Kok added the comment:
Attached the patch to address Ezio Melotti's concern. Thanks for the review!
--
Added file:
http://bugs.python.org/file33558/parse_non_valid_json_float_with_unit_test_v2.patch
___
Python tracker
Vajrasky Kok added the comment:
Serhiy commented, "I think we should remove targetpath in all cases. Not only
when softlink is
extracted."
I already did that in my latest patch but I am a little bit wary of this
behaviour.
--
___
Pyth
Vajrasky Kok added the comment:
Ah, thanks for the review, Serhiy. My bad. There is no underlying bug of tar. I
was confused by the behaviour of tar which is converting the absolute path to
relative path.
So, adding '/home/user/dir/file' to tar when you are in '/home
Vajrasky Kok added the comment:
It happens on Python 3.3 and 3.4 as well. Tested on Fedora 20.
--
nosy: +vajrasky
versions: +Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.org/issue20
Vajrasky Kok added the comment:
With little modification:
class PID_converter(int_converter):
type = 'pid_t'
format_unit = '" _Py_PARSE_PID "'
It works. Thanks! But I got unnecessary empty string:
if (!PyArg_ParseTuple(args, "" _Py_PARSE_PID &quo
Vajrasky Kok added the comment:
So, as Guide said in
https://mail.python.org/pipermail/python-dev/2014-January/131675.html:
"In the sha1 example, however, accepting None and converting it to NULL
(without a reference leak, please :-) seems fine though."
I let the patches a
Vajrasky Kok added the comment:
s/Guide/Guido.
--
___
Python tracker
<http://bugs.python.org/issue20173>
___
___
Python-bugs-list mailing list
Unsubscribe:
Vajrasky Kok added the comment:
Here is the patch for Python/marshal.c.
A couple of issues:
1. I can not have bytes as argument.
bytes: Py_buffer -> not possible
So I changed it to byte.
2. I can not give default value, marshal.version, to argument.
version: int(c_defa
Vajrasky Kok added the comment:
Here is the patch for Modules/gcmodule.c.
--
Added file: http://bugs.python.org/file33477/clinic_gc.patch
___
Python tracker
<http://bugs.python.org/issue20
Changes by Vajrasky Kok :
Removed file: http://bugs.python.org/file33474/clinic_codecsmodule.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Pytho
Changes by Vajrasky Kok :
Added file: http://bugs.python.org/file33475/clinic_resource.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bug
Vajrasky Kok added the comment:
Here is the patch for Modules/resource.c.
However, I can not convert this method signature:
if (!PyArg_ParseTuple(args, _Py_PARSE_PID "i|(OO):prlimit",
&pid, &resource, &curobj, &maxobj))
_Py_PARSE_P
New submission from Vajrasky Kok:
Enable SELinux (by default it is already enabled). Then load tipc module.
# modprobe tipc
Then using whatever account, execute Lib/test/test_socket.py. You'll get:
FAILED (errors=1, skipped=4)
Traceback (most recent call last):
File "Lib/test/test
New submission from Vajrasky Kok:
testRecvIntoArray is same as testRecvIntoBytearray.
testRecvFromIntoArray is same as testRecvFromIntoBytearray.
Attached the patch to fix the tests.
--
components: Tests
files: fix_recv_from_into_array_test_socket.patch
keywords: patch
messages
New submission from Vajrasky Kok:
>>> import socket
>>> r, w = socket.socketpair()
>>> w.send(b'X' * 1024)
1024
>>> buffer = bytearray()
>>> r.recvfrom_into(buffer)
python: /home/sky/Code/python/cpython3.4/Modules/socketmodule.c:2867:
Changes by Vajrasky Kok :
Added file: http://bugs.python.org/file33445/clinic_codecsmodule.patch
___
Python tracker
<http://bugs.python.org/issue20173>
___
___
Python-bug
Changes by Vajrasky Kok :
Removed file: http://bugs.python.org/file33443/clinic_codecsmodule.patch
___
Python tracker
<http://bugs.python.org/issue20173>
___
___
Pytho
Vajrasky Kok added the comment:
Here is the patch for _codecs module.
--
Added file: http://bugs.python.org/file33443/clinic_codecsmodule.patch
___
Python tracker
<http://bugs.python.org/issue20
Vajrasky Kok added the comment:
Yes, this issue bothers me. Currently _sha1.sha1 constructor will use NULL (not
None) value if used without parameters: _sha1.sha1()
_sha1.sha1(None) will throw error while _sha1.sha1() won't.
So for NULL (not None) default value, the generated signature
Vajrasky Kok added the comment:
This feature is for Python 3.5. I think, we will not commit anything to Python
3.5 until Python 3.4 branch is created (in other world, released). So, be
patient. :)
--
nosy: +vajrasky
___
Python tracker
<h
Vajrasky Kok added the comment:
Here is the updated patch addressing Giampaolo's concern.
--
Added file: http://bugs.python.org/file33404/fix_error_message_getspall_v2.patch
___
Python tracker
<http://bugs.python.org/is
Vajrasky Kok added the comment:
Here is the patch for md5. It got the same issue as sha1. After being
clinic-ed, the constructor accepts None value happily.
--
Added file: http://bugs.python.org/file33403/clinic_md5module.patch
___
Python tracker
Vajrasky Kok added the comment:
Here is the patch for sha512. It got the same issue as sha1. After being
clinic-ed, the constructor accepts None value happily.
--
Added file: http://bugs.python.org/file33402/clinic_sha512module.patch
___
Python
Vajrasky Kok added the comment:
Here is the patch for sha256. It got the same issue as sha1. After being
clinic-ed, the constructor accepts None value happily.
--
Added file: http://bugs.python.org/file33401/clinic_sha256module.patch
___
Python
Vajrasky Kok added the comment:
>Rule 1: Argument Clinic handles all argument parsing for you. Your "impl"
>function should never call PyArg_ParseTuple or PyArg_ParseTupleAndKeywords.
Ah, got it. Here is the third patch. Everything works fine except for the issue
whether
Vajrasky Kok added the comment:
This is the current behaviour of sha1 constructor. It rejects None value.
>>> import _sha1
>>> _sha1.sha1()
<_sha1.sha1 object at 0x7f7fa7f0dea0>
>>> _sha1.sha1(None)
Traceback (most recent call last):
File "", l
Vajrasky Kok added the comment:
Added md5 module to this ticket.
--
title: Misleading docs for sha1, sha256, sha512 modules -> Misleading docs for
sha1, sha256, sha512, md5 modules
Added file: http://bugs.python.org/file33399/fix_doc_sha_module_v2.pa
Vajrasky Kok added the comment:
But METH_O makes the update method does not work.
>>> _sha1.sha1().update(b'a')
Traceback (most recent call last):
File "", line 1, in
SystemError: new style getargs format but argument is not a tuple
But if you change METH_O to
New submission from Vajrasky Kok:
Misleading doc number 1:
>>> import _sha1
>>> _sha1.sha1.__doc__
'Return a new SHA1 hash object; optionally initialized with a string.'
>>> _sha1.sha1('cutecat')
Traceback (most recent call last):
File &qu
Vajrasky Kok added the comment:
Okay, this is my second attempt. I want to get METH_VARGS but I always get
METH_O for positional parameters. Is there any way to circumvent this? The
documentation does not cover this.
--
Added file: http://bugs.python.org/file33374/clinic_sha1module_v2
Vajrasky Kok added the comment:
An example how to convert keyword argument would be very helpful. I searched
the example from existing code but nothing shows up.
--
___
Python tracker
<http://bugs.python.org/issue20
Vajrasky Kok added the comment:
Okay, here is my first attempt. I only worked on one file
(Modules/sha1module.c). I need to see whether I hit the mark or not. If yes, I
can do the other files as well. Anyway, handling the keyword argument was kinda
tough. There was no example so I had to
Vajrasky Kok added the comment:
Thanks for the review. Attached the patch to address Marc-Andre Lemburg's
concern.
--
Added file: http://bugs.python.org/file4/deprecate_platform_dist_v2.patch
___
Python tracker
<http://bugs.python.org/i
Vajrasky Kok added the comment:
Here is the patch to deprecate platform.dist and platform.linux_distribution.
--
nosy: +vajrasky
Added file: http://bugs.python.org/file33324/deprecate_platform_dist.patch
___
Python tracker
<http://bugs.python.
Vajrasky Kok added the comment:
Jakub Wilk, yeah, I missed that one.
Jason Gerard DeRose, thanks for the additional information.
Anyway, I already "persuaded" Ruby developers to specialize the message,
although it's only for creating symlink.
https://bugs.ruby-lang.org/iss
Vajrasky Kok added the comment:
The quopri_codec uses binascii.b2a_qp method.
>>> binascii.b2a_qp('\r\n\n\n\n')
'\r\n\r\n\r\n\r\n'
The logic in b2a_qp when dealing with newlines is check whether the first line
uses \r\n or \n.
If it uses \r\n, then all rema
Vajrasky Kok added the comment:
Okay, sorry guys. The python 2.7 lzma binding is Fedora specific one. I already
submitted bug there: https://bugzilla.redhat.com/show_bug.cgi?id=1048581
--
resolution: -> invalid
status: pending -> open
___
Changes by Vajrasky Kok :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue19885>
___
___
Python-bugs-list mailing list
Unsubscrib
Vajrasky Kok added the comment:
Thanks, Eric! Attached the patch to address Eric's concern.
--
Added file:
http://bugs.python.org/file33296/unused_variable_in_factory_py_v2.patch
___
Python tracker
<http://bugs.python.org/is
New submission from Vajrasky Kok:
There is unused variable t in Lib/sqlite3/test/factory.py.
def CheckSqliteRowAsTuple(self):
"""Checks if the row object can be converted to a tuple"""
self.con.row_factory = sqlite.Row
row = self.con.
Vajrasky Kok added the comment:
The patch does not fix it. It becomes like this:
open(...)
Open file and return a stream. Raise IOError upon failure.
It's not just help(open) has problem, help(sqlite3.connect) got it as well:
connect(...)
check_same_thread, factory, cached_state
101 - 200 of 574 matches
Mail list logo
