Vajrasky Kok added the comment:
Forgot to say that, in list module, anything is convertable except __getitem__.
--
___
Python tracker
<http://bugs.python.org/issue20
Vajrasky Kok added the comment:
Here is the updated patch for marshal module based on Zachary's review.
--
Added file: http://bugs.python.org/file33769/clinic_marshal_v4.patch
___
Python tracker
<http://bugs.python.org/is
Vajrasky Kok added the comment:
I am doing clinic conversion for marshal module so I am adding myself to nosy
list to make sure both tickets are synchronized.
http://bugs.python.org/issue20185
--
nosy: +vajrasky
___
Python tracker
<h
Vajrasky Kok added the comment:
Here is the updated patch for float object based on Zachary and Serhiy's
reviews. Some methods that can not be converted are:
__getnewargs__, __round__, float_new.
So these files are ready for Python 3.4: resource, typeobject, listobject, and
floato
Vajrasky Kok added the comment:
Here is the patch to accommodate Serhiy's request. I added new test soutside
CommandLineTest. The fix always uses sys.stdout.encoding. The test_list_command
and test_list_command_verbose uses testtarnames now.
--
Added file:
http://bugs.pytho
Vajrasky Kok added the comment:
The converters argument in command line is still broken.
[sky@localhost cpython3.4]$ hg pull -u
pulling from http://hg.python.org/cpython
searching for changes
no changes found
[sky@localhost cpython3.4]$ ./python Tools/clinic/clinic.py --converters
Legacy
Vajrasky Kok added the comment:
Here is the updated patch addressing Zachary's reviews (Thanks!). However,
there are some reviews that I could not implement.
1. "This is a good candidate for a custom return converter."
I can not synchronize struct rlimit and NULL return values.
Vajrasky Kok added the comment:
Here is the updated patch after Larry's commit to clinic. Everything is
included except codecsmodule.
--
Added file: http://bugs.python.org/file33895/issue20173_conglomerate.patch
___
Python tracker
Vajrasky Kok added the comment:
"But there are some errors that really need two filenames, like copy(),
symlink(), and rename()."
I think *need* is too strong word in this case. I agree that two filenames is
better than none. But I don't see anything wrong from omitting file
Vajrasky Kok added the comment:
Here is the patch addressing Zachary's review (Thanks!). There are some
Zachary's suggestions that I could not implement:
1. float_conjugate_impl,/* nb_float */
I think this should still be the real function (the parser), not the impl.
Vajrasky Kok added the comment:
Zachary, "Looking again, that one is non-trivial, but still doable. You just
need a "this means an error happened" value to initialize rl to, and return
that value instead of NULL."
How do you give "this means an error happened" v
New submission from Vajrasky Kok:
On Fedora 20, I got this compiler warning:
/home/sky/Code/python/cpython3.4/Modules/readline.c: In function
‘flex_complete’:
/home/sky/Code/python/cpython3.4/Modules/readline.c:962:5: warning: passing
argument 1 of ‘completion_matches’ discards ‘const
Vajrasky Kok added the comment:
It works. I chose Christian Heimes' strategy because of:
char ** completion_matches (char *text, CPFunction *entry_func)
in
http://web.mit.edu/gnu/doc/html/rlman_2.html
--
___
Python tracker
<http://bugs.py
Vajrasky Kok added the comment:
Here is the updated patch. I missed the 'unaryfunc' part. :) Yeah, it's weird.
I run clinic again and the dump buffer was getting smaller again.
--
Added file: http://bugs.python.org/file33943/issue20185_congl
Changes by Vajrasky Kok :
Removed file: http://bugs.python.org/file33931/issue20185_conglomerate_v3.diff
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Vajrasky Kok added the comment:
Here is the updated patch for gc module.
Some functions that can not be converted:
- set_threshold(threshold0, [threshold1, threshold2])
Don't know what default value to give to threshold1, threshold2.
static struct gc_generation generations[NUM_GENERA
Changes by Vajrasky Kok :
Removed file: http://bugs.python.org/file33477/clinic_gc.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bugs-list m
Vajrasky Kok added the comment:
About rlimit, I think we can use negative number for any member of the struct.
But the thing is I am not really sure whether it's okay or not. So it's better
on the safe side.
I'll finish longobject in
Vajrasky Kok added the comment:
Here is the updated patch for gc module based on Zachary's review.
--
Added file: http://bugs.python.org/file33951/clinic_gc_v3.patch
___
Python tracker
<http://bugs.python.org/is
Changes by Vajrasky Kok :
Removed file: http://bugs.python.org/file33944/clinic_gc_v2.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bug
Vajrasky Kok added the comment:
Here is the updated patch for long object. A couple of functions that can not
be converted:
- long_new
It has custom processing before parsing arguments part.
- long_round
Not supported by clinic.
_ __trunc__, __floor__, __ceil__ all are mapped to long_long
Changes by Vajrasky Kok :
Removed file: http://bugs.python.org/file33587/clinic_longobject.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bug
Vajrasky Kok added the comment:
The culprit:
diff -r b4e99bec0c8a Lib/test/test_codecs.py
--- a/Lib/test/test_codecs.py Fri Feb 07 10:10:55 2014 +0200
+++ b/Lib/test/test_codecs.py Fri Feb 07 17:14:12 2014 +0800
@@ -164,6 +164,8 @@
s = 10*(size*"a" + lineen
Vajrasky Kok added the comment:
See also: http://bugs.python.org/issue1311
--
nosy: +vajrasky
___
Python tracker
<http://bugs.python.org/issue20541>
___
___
Pytho
Vajrasky Kok added the comment:
> Your test method didn't start with 'test_', so it didn't get run.
Ah sorry about that. This is the updated patch. It fixed the problem and passed
all test.
--
Added file:
http://bugs.python.org/file33987/fix_serialization_mes
Vajrasky Kok added the comment:
It's weird. When I make clean and configure again and make again, the error
warning message disappear. Prior to that, I could confirm, I was in this block:
#ifdef HAVE_RL_COMPLETION_MATCHES
#define completion_matches(x, y) \
rl_completion_match
Vajrasky Kok added the comment:
Actually, I am thinking of this approach (cloning the message just after
entering the flatten method):
diff -r b541ecd32115 Lib/email/generator.py
--- a/Lib/email/generator.pyFri Feb 07 16:11:17 2014 -0800
+++ b/Lib/email/generator.pySat Feb 08 15:55:01
Vajrasky Kok added the comment:
Here is the updated patch for gc module based on Zachary's review.
--
Added file: http://bugs.python.org/file33988/clinic_gc_v4.patch
___
Python tracker
<http://bugs.python.org/is
Changes by Vajrasky Kok :
Removed file: http://bugs.python.org/file33954/clinic_longobject_v2.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Pytho
Vajrasky Kok added the comment:
Here is the updated patch for long object based on Zachary's review.
--
Added file: http://bugs.python.org/file33989/clinic_longobject_v3.patch
___
Python tracker
<http://bugs.python.org/is
Changes by Vajrasky Kok :
Removed file: http://bugs.python.org/file33951/clinic_gc_v3.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bug
Vajrasky Kok added the comment:
Here is the ultimate patch for this bug. The doc fix is based on Larry's
writing: https://mail.python.org/pipermail/python-dev/2014-January/132156.html
I made sure the patch could be compiled by Sphinx and displayed nicely. I added
test and comment in the
Vajrasky Kok added the comment:
> So why check specifically for 8bit and base64?
I was in hurry when creating this patch. I think that was part of the debug
code. This patch was created with the purpose to illuminate the culprit of this
bug. And it served its purpose.
After uploading t
Vajrasky Kok added the comment:
Now, that we have fixed this bug in Python 3.4 with this commit
http://hg.python.org/cpython/rev/081a9d8ba3c7, what should we do with the bug
in Python 3.3?
Use my patch (omitting filenames)?
Keep the status quo (one filename)? If yes, close this ticket as
Vajrasky Kok added the comment:
Yeah, you are right, Serhiy. I check the behaviour of GNU tar command line. It
always replaces the target no matter what kind of file source and target are.
--
___
Python tracker
<http://bugs.python.org/issue19
Changes by Vajrasky Kok :
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue20589>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Vajrasky Kok:
>From
>http://docs.python.org/3.4/library/asyncio-task.html#example-future-with-run-until-complete
there is an example code:
import asyncio
@asyncio.coroutine
def slow_operation(future):
yield from asyncio.sleep(1)
future.set_result('Fut
Vajrasky Kok added the comment:
The patch also fixed some typos.
s/Future in done/Future is done/
--
Added file:
http://bugs.python.org/file34112/shut_off_resource_warning_run_forever_asyncio_example.patch
___
Python tracker
<h
Changes by Vajrasky Kok :
Removed file:
http://bugs.python.org/file34111/shut_off_resource_warning_run_forever_asyncio_example.patch
___
Python tracker
<http://bugs.python.org/issue20
New submission from Vajrasky Kok:
ethan@amiau:~/Documents/code/python/cpython3.4$ cat
Lib/test/test_asyncio/tests.txt
test_asyncio.test_base_events
test_asyncio.test_events
test_asyncio.test_futures
test_asyncio.test_locks
test_asyncio.test_proactor_events
test_asyncio.test_queues
Vajrasky Kok added the comment:
The second is the permanent fix so we don't need to add new test to tests.txt
every time we want to add new test to asyncio test bundle.
--
Added file:
http://bugs.python.org/file34115/permanent_fix_for_executing_test_asyncio_in_bundle.
Vajrasky Kok added the comment:
This is the preliminary patch for this bug.
The bug happens because AddressFamily.AF_UNSPEC is 0. Then you have this if
condition:
getattr(object, name, None) or homecls.__dict__[name]
I'll contemplate whether we should add unit test for this o
Vajrasky Kok added the comment:
I just realized that Enum member could be None. I'll think how to improve this
patch.
--
___
Python tracker
<http://bugs.python.org/is
Vajrasky Kok added the comment:
Here is the second preliminary patch. I'll think about the way to avoid
dependency to socket module.
--
Added file:
http://bugs.python.org/file34119/pydoc_display_enum_member_value_0.patch
___
Python tracker
Vajrasky Kok added the comment:
Here is the second patch, avoiding dependency to socket.AddressFamily (though
it adds dependency to enum library) in test.
--
Added file:
http://bugs.python.org/file34120/pydoc_display_enum_member_value_0_v2.patch
Vajrasky Kok added the comment:
Thanks for the review, Serhiy! Here is the patch addressing Serhiy's concern.
--
Added file:
http://bugs.python.org/file34126/pydoc_display_enum_member_value_0_v3.patch
___
Python tracker
<http://bugs.py
New submission from Vajrasky Kok:
We can run the whole asyncio tests by using this command:
./python -m test.test_asyncio
But this way depends on the Lib/test/test_asyncio/tests.txt which contains all
the tests that need to be executed. The problem is the core developer may
forget to modify
Vajrasky Kok added the comment:
> It is slowing down. I think we now only have some documentation updates left.
What about this one? http://bugs.python.org/issue20668 (Remove dependency on
tests.txt when running test_asyncio suite)
It has been lgtm-ed by Guido and asked by him to be added
Vajrasky Kok added the comment:
Here is the preliminary patch to address Serhiy's concern. I added some
regression tests as well. Give me a time to think how to refactor the code
(especially the test).
--
Added file:
http://bugs.python.org/file34152/fix_tarfile_overwrites_symli
Vajrasky Kok added the comment:
Here is the patch that is considerate towards Windows for Python 3.4. I'll fix
the patch for Python 2.7 later.
--
Added file: http://bugs.python.org/file34198/add_unit_test_os_chown_v2.patch
___
Python tracker
Changes by Vajrasky Kok :
Removed file: http://bugs.python.org/file33266/add_unit_test_os_chown.patch
___
Python tracker
<http://bugs.python.org/issue20069>
___
___
Pytho
Vajrasky Kok added the comment:
Okay, here is my attempt to rewrite the test using local web server. I copied
and modified the code from Lib/test/test_socketserver.py. The website
mueblesmoraleda can not be accessed so I could only guess what the intention of
this test was.
I am not sure
New submission from Vajrasky Kok:
For pragmatic and philosophical reasons, I would argue that we should add chown
to pathlib library.
--
components: Library (Lib)
files: add_chown_to_pathlib.patch
keywords: patch
messages: 212245
nosy: pitrou, vajrasky
priority: normal
severity: normal
New submission from Vajrasky Kok:
Line 994 of Lib/test/test_statistics.py:
def test_decimal_mismatched_infs_to_nan(self):
# Test adding Decimal INFs with opposite sign returns NAN.
inf = Decimal('inf')
data = [1, 2, inf, 3, -inf, 4]
with decimal.lo
Changes by Vajrasky Kok :
Added file:
http://bugs.python.org/file34229/fix_shadowed_test_in_test_statistics.patch
___
Python tracker
<http://bugs.python.org/issue20
Changes by Vajrasky Kok :
Removed file:
http://bugs.python.org/file34228/fix_shadowed_test_in_test_statistics.patch
___
Python tracker
<http://bugs.python.org/issue20
Vajrasky Kok added the comment:
>From http://hg.python.org/cpython/rev/1a1a9d6fb278
+t1 = TESTFN
+#t1 = writeTmp(1, ['A\nB\r\nC\rD+IKw-'], mode='wb')
+self.addCleanup(safe_unlink, TESTFN)
You left out the debugging statement.
And this English sta
Vajrasky Kok added the comment:
Pragmatic reasons:
I use chown moderately often. Usually as root, I want to change the uid of the
files after generating a bunch of files. But I almost never changed gid.
I am in two mind whether I should add lchown as well or not (just like lchmod)
and make
New submission from Vajrasky Kok:
# Bug demo
TEXT_LINES = [
b'cutecat\n',
b'promiscuousbonobo\n',
]
TEXT = b''.join(TEXT_LINES)
import bz2
filename = '/tmp/demo.bz2'
with open(filename, 'wb') as f:
f.write(bz2.compress(TEXT))
with bz
Vajrasky Kok added the comment:
Just curious, why the exact number of bytes returned is unspecified in bz2 (in
other words, n argument is ignored)? gzip uses n argument.
--
___
Python tracker
<http://bugs.python.org/issue20
Vajrasky Kok added the comment:
Here is the patch.
--
keywords: +patch
nosy: +vajrasky
Added file: http://bugs.python.org/file36967/better_err_listfuncs_trace.patch
___
Python tracker
<http://bugs.python.org/issue22
Vajrasky Kok added the comment:
Here is the preliminary patch. It's a thin wrapper of strsignal.
Some issues and things:
1. About Benjamin Peterson's request, what is the name of the dictionary
supposed to be? Is everyone okay with Benjamin's suggestion?
2. About George Brandl&
Vajrasky Kok added the comment:
Thanks, Berker Peksag, for the review. Here is the updated patch with the test.
--
Added file: http://bugs.python.org/file37068/better_err_listfuncs_trace_v2.patch
___
Python tracker
<http://bugs.python.org/issue22
Vajrasky Kok added the comment:
Here is the patch based on R. David Murray's review. Thanks!
Thanks also for the work of Cormac O'Brien.
--
Added file: http://bugs.python.org/file37096/add_unit_test_os_chown_v6.patch
___
Python trac
Vajrasky Kok added the comment:
Here is the latest patch which executes unittest.main inside __main__ based on
R. David Murray's review. Thanks!
--
Added file: http://bugs.python.org/file37540/add_unit_test_os_chown_v7.patch
___
Python tr
New submission from Vajrasky Kok:
Got this warning when compiling Python on Mac:
building '_scproxy' extension
gcc -Wno-unused-result -Wsign-compare -g -O0 -Wall -Wstrict-prototypes
-Werror=declaration-after-statement -I./Include -I. -IInclude
-I/usr/local/include -I/Users/sky/C
New submission from Vajrasky Kok:
On my OS X Yosemite 10.10.3, I got this warning when compiling
Modules/_ctypes/libffi_osx/ffi.c.
gcc -Wno-unused-result -Wsign-compare -g -O0 -Wall -Wstrict-prototypes
-Werror=declaration-after-statement -I_ctypes/darwin
-I/Users/sky/Code/python/cpython
New submission from Vajrasky Kok:
On my OSX Yosemite 10 with GCC 4.2.1 Compatible Apple LLVM 6.1.0
(clang-602.0.53), I fail to build time module.
Failed to build these modules:
time
Here is the patch to fix the compile error.
--
components: Macintosh
files
Vajrasky Kok added the comment:
Here is the error message:
building 'time' extension
gcc -Wno-unused-result -Wsign-compare -g -O0 -Wall -Wstrict-prototypes
-Werror=declaration-after-statement -I./Include -I. -IInclude
-I/usr/local/include -I/Users/sky/Code/python/cpython/Include
-I
New submission from Vajrasky Kok:
I got this warning when compiling sqlite3 module.
gcc -Wno-unused-result -Wsign-compare -g -O0 -Wall -Wstrict-prototypes
-Werror=declaration-after-statement -DMODULE_NAME="sqlite3"
-DSQLITE_OMIT_LOAD_EXTENSION=1 -IModules/_sqlite -I/usr/include -I./
Vajrasky Kok added the comment:
Here is the patch.
--
keywords: +patch
nosy: +vajrasky
Added file: http://bugs.python.org/file39844/addCleanupClass.patch
___
Python tracker
<http://bugs.python.org/issue24
Vajrasky Kok added the comment:
"According to my (non-expert) reading of the code, the test skips (or is
supposed to skip) unless group count of uid is > 1.
The group membership of the buildbot user this worker runs as is only
'buildbot' and on that basis wouldn't a ski
Vajrasky Kok added the comment:
"The group here is not the group of buildbot user. The group here refers to all
groups in the system." -> I retract back this statement.
--
___
Python tracker
<http://bugs.pytho
Vajrasky Kok added the comment:
The only way I can reproduce this in Linux (still downloading FreeBSD Current),
is to remove user from the group before (I did it in different terminal)
executing os.chown method to that specific group id.
I am thinking to add more information in the exception
501 - 574 of 574 matches
Mail list logo
