Vinay Sajip added the comment:
New changeset dde9fdbe453925279ac3d2a6a72102f6f9ef247c by Vinay Sajip in branch
'master':
bpo-33165: Added stacklevel parameter to logging APIs. (GH-7424)
https://github.com/python/cpython/commit/dde9fdbe453925279ac3d2a6a72102f6f9ef247c
Change by Vinay Sajip :
--
keywords: +patch
pull_requests: +7049
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Vinay Sajip added the comment:
New changeset 1df877caad584135263ef94d83a28251e162e643 by Vinay Sajip (Miss
Islington (bot)) in branch '3.6':
bpo-32519: Removed misleading sentence from EnvBuilder documentation. (GH-7296)
(GH-7299)
https://github.com/python/cpython/commit
Vinay Sajip added the comment:
New changeset 283e12f91db1a5290f2ddbddee406797fec39d2e by Vinay Sajip (Miss
Islington (bot)) in branch '3.7':
bpo-32519: Removed misleading sentence from EnvBuilder documentation. (GH-7296)
(#7300)
https://github.com/python/cpython/commit
Vinay Sajip added the comment:
New changeset 461ad598d12eba7754181402e00bb7cfc7f1d9cf by Vinay Sajip (Miss
Islington (bot)) in branch '3.6':
bpo-33400: Removed references to RFC3339 and ISO8601 from the logging
documentation. (GH-7297) (GH-7303)
https://github.com/python/cpython/commit
Vinay Sajip added the comment:
New changeset 4b6691e40f004bf3a08b1843620f5f6028d2b79d by Vinay Sajip (Miss
Islington (bot)) in branch '3.7':
bpo-33400: Removed references to RFC3339 and ISO8601 from the logging
documentation. (GH-7297) (GH-7302)
https://github.com/python/cpython/commit
Change by Vinay Sajip :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Vinay Sajip :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Vinay Sajip added the comment:
New changeset 23cee80cfade1a9019c52b3a17d8e5c1b5db17e2 by Vinay Sajip in branch
'master':
bpo-33400: Removed references to RFC3339 and ISO8601 from the logging
documentation. (GH-7297)
https://github.com/python/cpython/commit
Vinay Sajip added the comment:
New changeset c0d341d49b3ffc8b0037e501c246271be9c69f55 by Vinay Sajip in branch
'master':
bpo-32519: Removed misleading sentence from EnvBuilder documentation. (GH-7296)
https://github.com/python/cpython/commit/c0d341d49b3ffc8b0037e501c246271be9c69f55
Change by Vinay Sajip :
--
pull_requests: +6926
___
Python tracker
<https://bugs.python.org/issue33400>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Vinay Sajip :
--
keywords: +patch
pull_requests: +6925
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32519>
___
___
Py
Change by Vinay Sajip :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Vinay Sajip added the comment:
New changeset 6e3ca645e71dd021fead5a70dc06d9b663612e3a by Vinay Sajip (Timo
Furrer) in branch 'master':
bpo-33606: improve logging performance when logger is disabled (GH-7285)
https://github.com/python/cpython/commit/6e3ca645e71dd021fead5a70dc06d9b663612e3a
Vinay Sajip added the comment:
The check in handle() should remain, because there are some scenarios where
handle is called directly (e.g. when receiving events over a socket and
dispatching to handlers). So the change would just be to add an additional
check in isEnabledFor
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
Because the specs allow certain decisions to be taken "by mutual consent", I'm
not sure anyone can be really happy. Perhaps I should just state what the
format actually is, as per msg316662, refer to RFC 3339 and leav
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
New changeset eb8516becc267caeb0ca6f9c41e805d1ba1caaa3 by Vinay Sajip (Miss
Islington (bot)) in branch '3.7':
bpo-33400: Clarified documentation to indicate no strict adherence to ISO 8601.
(GH-6702) (GH-6704)
https://github.com/
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
Yes, sorry, Ned, I've been snowed under with other work recently :-(
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
New submission from Vinay Sajip <vinay_sa...@yahoo.co.uk>:
If a logger is disabled (by setting it's disabled attribute to True), the check
for this is done late in the dispatch of the logging event - during the
handle() call - rather than isEnabledFor(), which would short-circui
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
> I just wanted to say thanks to Steve for at least taking the time to open the
> issues to ask if we would consider accepting the proposed changes.
Sure, and I probably come across as somewhat tetchy in my responses. That'
Change by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<https://bu
Change by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<https://bu
Change by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<https://bu
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
> The solution recommended in the logging cookbook does not do the same thing
> as I have proposed.
Perhaps not, but it appears to adequately address your first point:
> Many logging aggregation and indexing systems r
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
> Are you planning to remove the predefined filename templates
No. They work fine as is for most people, from what I can tell.
> it still has the limitation that when a logging file is active for writing
> log events, t
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
> A "batteries included" JSON log formatter would be a useful enhancement.
See
https://docs.python.org/3/howto/logging-cookbook.html#implementing-structured-logging
I don't propose to implement your suggestion.
You'
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
> Python logging is not multi-process safe.
Covered in
https://docs.python.org/3/howto/logging-cookbook.html#logging-to-a-single-file-from-multiple-processes
You can certainly arrange to have the pid in the filename without
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
> The logging library has a small set of predefined filename templates and no
> way is provided to override them.
What about
https://docs.python.org/3/library/logging.handlers.html#logging.handlers.BaseRotatingHandler.
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
New changeset eb5abdc70815c4207829551ede4a7dc302d56c19 by Vinay Sajip (Miss
Islington (bot)) in branch '3.6':
bpo-33400: Clarified documentation to indicate no strict adherence to ISO 8601.
(GH-6703)
https://github.com/python/c
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
New changeset c4994dc00d9828a99510f3851da93b0e1c18361d by Vinay Sajip in branch
'master':
bpo-33400: Clarified documentation to indicate no strict adherence to ISO 8601.
(GH-6702)
https://github.com/python/cpython/
Change by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
keywords: +patch
pull_requests: +6394
stage: -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
You can already roll your own, see
https://docs.python.org/3/library/logging.handlers.html#baserotatinghandler
--
resolution: -> not a bug
stage: -> resolved
status: op
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
> However, it seems that someone already thought about it before and started
> implementing this mechanism
That someone was me. I decided that a single module-level factory was good
enough but failed to delete the things
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
> I have two types of loggers, one for experiment results ("data") and another
> for general information
In what way is the behaviour of the two types of logger different? I'm
concerned that this
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
The logRecordFactory attribute was added but never used and is part of an
internal API (the Manager isn't documented, on purpose). Why do you need a
manager-specific factory?
--
___
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
The existing LoggerAdapter functionality has been around since Jan 2008, and it
seems that no one in that time has raised this as a must-have. In summary:
1. If you want to pass different kwargs in every time, use a logger.
2.
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
This is not a bug, so I have closed the PR and am closing the issue. You might
expect extras to be merged, but you can either pass extras in the constructor
(as you have observed) or by subclassing LoggerAdapter and over
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
> Vinay, should this back-ported to 3.6?
Yes, I think it should be.
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
"Seems wrong to me" is not a sufficient reason for changing things in this
area. The pyvenv.cfg file is intended to be parsed by the interpreter's C code
as well as by Python code, so its format needs to be kept as si
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
I don't think a strong enough case has been made for adding this enhancement.
--
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracker <rep.
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
Yes, the patch needs improving as per the suggestion in msg288493 (not had the
time since to do any work on it), followed by a review of the changes.
--
___
Python tracke
Change by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
resolution: not a bug -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> enhancement
___
Python tracker <rep...@bugs.python.org>
<https:/
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
New changeset 292fce9934280867ca9a65870495f83fca37751e by Vinay Sajip in branch
'2.7':
bpo-32212: Updated logging documentation to make parameter names more
consistent with source. (GH-4765) (GH-4768)
https://github.com/python/c
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
New changeset 63868181a904c844d8d01e3badfdd5b134acc5fa by Vinay Sajip in branch
'3.6':
bpo-32212: Updated logging documentation to make parameter names more
consistent with source. (GH-4765) (GH-4767)
https://github.com/python/c
Change by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
pull_requests: +4671
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32212>
___
Change by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
pull_requests: +4670
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32212>
___
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
New changeset a9f8df646aac7fc94ced0aefd1ed2c8566d14d10 by Vinay Sajip in branch
'master':
bpo-32212: Updated logging documentation to make parameter names more
consistent with source. (GH-4765)
https://github.com/python/cpython/
Change by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
keywords: +patch
pull_requests: +4668
stage: needs patch -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
basicConfig() provides default behaviour for simple cases. If you don't like
the defaults it provides, you can choose your own configuration code to do
exactly what you want.
--
___
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
I don't have a problem with tweaking the documentation where discrepancies are
found between source and doc for keyword arguments, but in both the examples
you give, the arguments are positional, not keyword. Therefore in my o
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
> Maybe I misunderstand.
I think you do misunderstand. The level of the handler created by basicConfig
doesn't have any level set, so it will process any message it is asked to
handle. This is working as
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
> I guess it's reasonable, I'll see whether we can use the workaround you
> proposed.
OK, please post your findings here.
> (Could a fix on virtualenv's side help?)
Probably not, as it's not behaving unexpectedly. It
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
Is it OK if I close this? It's not really a bug, nor a case that's been
designed for (a stdlib module supporting specific external packages is very
unusual - pip support via ensurepip is perhaps the one exception I can think
of).
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
> I don't understand why things would be different when nesting?
Specifically because venv keeps "a pointer" to the Python environment it was
created from. Usually that's a system Python. If a venv ("
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
The problem for venv is that it's tied to the running interpreter, which is (in
the case you mention) the one from the outer virtualenv. Unlike virtualenv,
venv does not provide a mechanism to restart itself with a different
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
Can you explain why virtualenv and venv need to be mixed in this way, other
than as an academic exercise? If you use -m venv for both inner and outer
venvs, then it seems to work as expected.
I'm planning to close this as &quo
Change by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<https://bu
Change by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<https://bu
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
New changeset b071a5e838a0e84c4e8a60448fbd40e8a7e5c882 by Vinay Sajip (Miss
Islington (bot)) in branch '3.6':
bpo-30904: Removed duplicated Host: header. (GH-4465) (#4468)
https://github.com/python/cpython/
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
New changeset 65dffe58dd062385024eacbe75a0fa59ec12a993 by Vinay Sajip (Miss
Islington (bot)) in branch '3.6':
bpo-30989: Sort in TimedRotatingFileHandler only when needed. (GH-2812)
(GH-4466)
https://github.com/python/cpython/
Change by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
resolution: -> not a bug
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<https://bu
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
New changeset e96ba183c43ad6633b5d014b3dc57433e2802faf by Vinay Sajip in branch
'master':
bpo-30904: Removed duplicated Host: header. (#4465)
https://github.com/python/cpython/commit/e96ba183c43ad6633b5d014b3dc57433e2
Change by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
keywords: +patch
pull_requests: +4398
stage: -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
> What is the best way to silence logging in subprocesses?
Are you referring to the output shown in msg305601? If it's caused by logging
statements, the best way would be either to pipe stderr to /dev/null or to
change th
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
New changeset afad147b59fe84b12317f7340ddd2deeecb22321 by Vinay Sajip (Lovesh
Harchandani) in branch 'master':
bpo-30989: Sort in TimedRotatingFileHandler only when needed. (GH-2812)
https://github.com/python/cpython/
Change by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
versions: +Python 3.7
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue30904>
___
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
> I've triggered it which is why I looked for the problem and offered the
> defensive patch.
That's why I asked for a small example which used logging as documented and
demonstrated a problem. You haven't done that.
>
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
Matthew Patton: you don't appear to have read the documentation correctly. The
formatException() method's exc_info positional parameter is expected to be a
normal exception tuple, not just any truthy value. This is clearly
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
As Raymond has said: though it might appear reasonable to add a TRACE level
from the numerous examples that Victor has given, in practice it is hard enough
to know when a particular level should be applied. Victor says "we nee
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
This is not an issue that needs fixing; the current behaviour is by design. The
documentation states about exc_info:
"There are two keyword arguments in kwargs which are inspected: exc_info which,
if it does not evalua
Vinay Sajip <vinay_sa...@yahoo.co.uk> added the comment:
New changeset 90f1d989594f3340c5ffaa2cf9cef1876ac6bb89 by Vinay Sajip (Sorin
Sbarnea) in branch 'master':
bpo-25351: avoid activate failure on strict shells (GH-3804)
https://github.com/python/cpython/
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<https://bu
Vinay Sajip added the comment:
No, that's OK - leave it as is, I'll consider it when next visiting the area.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bu
Vinay Sajip added the comment:
New changeset 6ea56d2ebcae69257f8dd7af28c357b25bf394c3 by Vinay Sajip (Preston
Landers) in branch 'master':
bpo-31080: Allowed logging.config.fileConfig() to accept both args and kwargs.
(GH-2979)
https://github.com/python/cpython/commit
Vinay Sajip added the comment:
Yes, seems reasonable, but don't change Misc/NEWS directly in your patch - this
is now done using the "blurb" tool. Installed into a Python 3 environment using
"pip install blurb".
--
___
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bu
Vinay Sajip added the comment:
New changeset adfe3440f65dfd6cf4463db6cd02cdc78e77ce17 by Vinay Sajip (favll)
in branch 'master':
bpo-31084: QueueHandler now formats messages correctly. (GH-2954)
https://github.com/python/cpython/commit/adfe3440f65dfd6cf4463db6cd02cdc78e77ce17
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
stage: -> needs patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30842>
___
_
Vinay Sajip added the comment:
Note that the activate script currently also works with /bin/sh (using .
venv-dir/bin/activate) but pushd and popd are not supported there, and
introducing them would presumably break this script on /bin/sh
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bu
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bu
Vinay Sajip added the comment:
New changeset 2543f50033208c1a8df04999082b11aa09e82a04 by Vinay Sajip in branch
'master':
bpo-30522: Implemented a method to allow setting a logging.StreamHander's
stream. (GH-2921)
https://github.com/python/cpython/commit
Vinay Sajip added the comment:
New changeset 78c18a9b9a1445f7c755929917a790ba02b4a5e0 by Vinay Sajip (Avram
Lubkin) in branch 'master':
bpo-30962: Added caching to Logger.isEnabledFor() (GH-2752)
https://github.com/python/cpython/commit/78c18a9b9a1445f7c755929917a790ba02b4a5e0
Vinay Sajip added the comment:
This needs further thought as to how to implement. For example, readlink -f
isn't supported on OS X. If a patch were available which works across
platforms, that would potentially speed up resolution of this issue
Vinay Sajip added the comment:
> Which third-party libraries?
> It is my code in my file.
If a feature is added to logging, anyone can use it. If people put
style-specific loggers in libraries they write, and other people then use those
libraries, then there may be a need for them to
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
pull_requests: +2975
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30522>
___
Vinay Sajip added the comment:
> You only have to make sure they do not use this logger without knowing about
> new format, which can be done in various ways (like prefixing the name of the
> logger, for example).
That's the problem, right there. I don't think the ways
Vinay Sajip added the comment:
This seems reasonable, but scripts written to venvs by e.g. pip hard-code the
path to the venv, and this is a stumbling block to relocatability. There is no
reason to use the activate scripts except under interactive use - a script
installed in a venv should
Vinay Sajip added the comment:
How about this as an API?
def setStream(self, stream):
"""
Sets the StreamHandler's stream to the specified value,
if it is different.
Returns the old stream, if the stream was changed, or None
Vinay Sajip added the comment:
New changeset 0653fba51c03d20fa4381ba0836acd17fd05b04b by Vinay Sajip in branch
'master':
bpo-30862: Updated Logger.setLevel documentation. (GH-2604)
https://github.com/python/cpython/commit/0653fba51c03d20fa4381ba0836acd17fd05b04b
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
pull_requests: +2672
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30862>
___
Vinay Sajip added the comment:
As RDM says, this behaviour is as designed. The logger's setLevel documentation
says:
"Sets the threshold for this logger to lvl. Logging messages which are less
severe than lvl will be ignored. When a logger is created, the level is set to
NOTSET (which c
Vinay Sajip added the comment:
New changeset 9ba3aa4d02a110d1a1ea464a8aff3be7dd9c63c3 by Vinay Sajip (Erik
Bray) in branch 'master':
bpo-30353: Fix pass by value for structs on 64-bit Cygwin/MinGW (GH-1559)
https://github.com/python/cpython/commit/9ba3aa4d02a110d1a1ea464a8aff3be7dd9c63c3
Vinay Sajip added the comment:
You haven't clearly stated what you expect to happen vs. what happens. I don't
believe there is a bug here:
$ python3.6
Python 3.6.1+ (heads/3.6:2ee91c8, May 28 2017, 14:14:12)
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", &
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
assignee: -> vinay.sajip
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http:/
Vinay Sajip added the comment:
New changeset 6260d9f2039976372e0896d517b3c06e606eb169 by Vinay Sajip in branch
'master':
bpo-30520: Implemented pickling for loggers. (#1956)
https://github.com/python/cpython/commit/6260d9f2039976372e0896d517b3c06e606eb169
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
pull_requests: +2027
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30520>
___
Vinay Sajip added the comment:
I am not sure it is a good idea to support pickling of loggers, as they are
singletons and generally aren't supposed to be instantiated other than by
calling logging.getLogger(name). What's the use case for pickling them, giving
that (as you say) just the name
Vinay Sajip added the comment:
Patch LGTM now, perhaps others will concur?
--
nosy: +eryksun
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
601 - 700 of 2016 matches
Mail list logo
