Vinay Sajip added the comment:
> If the user is operating in a virtual environment they are ring fenced and,
> presumably, don't wish any other versions of python to be used
I'm not sure that's true. I have a number of tools which rely on specific
libraries and so I have created
Vinay Sajip added the comment:
> Do I need to create a pull request for this?
Yes, creating a PR is part of the current workflow since we moved to GitHub.
Though that's not the reason why it's not been progressed - on my part, at
least, it's due to not having had time to think thro
Vinay Sajip added the comment:
> How can this be true?
Perhaps it didn't make the cut for that specific release? Seems to be in the
3.5 branch OK.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.or
Vinay Sajip added the comment:
New changeset 55ace65eba587fe3cf3759a43cccf85214651971 by Vinay Sajip (Jim
Fasarakis-Hilliard) in branch 'master':
Closes bpo-30168: indent methods in Logger Class (#1295)
https://github.com/python/cpython/commit/55ace65eba587fe3cf3759a43cccf85214651971
Vinay Sajip added the comment:
Also getting values I'm not sure how to interpret:
$ ./python -m test.regrtest -R : test_logging
Run tests sequentially
0:00:00 [1/1] test_logging
beginning 9 repetitions
123456789
.
test_logging leaked [-164, 164, -164, 0] references, sum=-164
Vinay Sajip added the comment:
I can't reproduce this on the master branch, with the latest checkout. Was this
the branch your failure occurred on?
$ ./python -m test.regrtest -vuall test_venv
== CPython 3.7.0a0 (heads/master:f60c9e5, Apr 21 2017, 07:19:01) [GCC 5.4.0
20160609]
== Linux
Vinay Sajip added the comment:
I just did a git pull, then:
$ make distclean
$ ./configure --with-pydebug
$ make EXTRA_CFLAGS="-DPy_REF_DEBUG -DPy_TRACE_REFS"
$ ./python
Python 3.7.0a0 (heads/master:8f5cdfa, Apr 20 2017, 16:41:52)
[GCC 5.4.0 20160609] on linux
Type "he
Vinay Sajip added the comment:
New changeset ae0915e42d8cd96e5ced1fc442ea078b4a59e82d by Vinay Sajip in branch
'3.5':
Closes bpo-29939: suppress compiler warnings in _ctypes_test (#1039)
https://github.com/python/cpython/commit/ae0915e42d8cd96e5ced1fc442ea078b4a59e82d
--
status: open
Vinay Sajip added the comment:
New changeset d0d575a6db8cb3b2a720be9f404af3d754da9a5d by Vinay Sajip in branch
'3.6':
bpo-29939: suppress compiler warnings in _ctypes_test (#1038)
https://github.com/python/cpython/commit/d0d575a6db8cb3b2a720be9f404af3d754da9a5d
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
pull_requests: +1192
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29939>
___
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
pull_requests: +1191
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29939>
___
Vinay Sajip added the comment:
> and provides no straightforward API for me to reconfigure its logger.
As far as I know, you just need to do something which configures a Flask
logger, then call logging.config.dictConfig() with a suitable configuration
which doesn't disable existing logg
Vinay Sajip added the comment:
Added relevant "needs backport" tags to PR, will get to it soon. Reopening till
then.
--
status: closed -> open
___
Python tracker <rep...@bugs.python.org>
<http://bugs
Vinay Sajip added the comment:
Should be fixed by 164d30e.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Vinay Sajip added the comment:
In the OP, the error is caused by `open` being unavailable, which is a builtin.
According to what Serhiy says, this error would be after step 6 in his list, so
`sys` wouldn't be available either, and nor perhaps would any other builtins.
As some termination
Vinay Sajip added the comment:
I would like to close this issue now, without making changes. Will do in one
day, unless someone pipes up.
--
resolution: -> not a bug
status: open -> pending
___
Python tracker <rep...@bugs.python.o
Vinay Sajip added the comment:
I would prefer to keep things as they are - which is conforming to the
preferences expressed in ISO 8601, and preserving backwards compatibility. I
agree that a period has some advantages, but I went with what the standard said
as closely as I could. I'm
Vinay Sajip added the comment:
It's not exactly a decimal point, more a "decimal mark" as per ISO 8601. From
the Wikipedia article for the standard at
"https://en.wikipedia.org/wiki/ISO_8601#Times -
"However, a fraction may only be added to the lowes
Vinay Sajip added the comment:
Yes, this is on my radar. I'm planning to make some changes to this file in
response to bpo-22273, and will stick in a (void) in to get rid of the warning.
--
___
Python tracker <rep...@bugs.python.org>
Vinay Sajip added the comment:
New changeset 1b038e073807ecb6fd176edaf3386a8e3205416e by Vinay Sajip
(Коренберг Марк) in branch 'master':
bpo-29808: SysLogHandler: Do not fail if initial connect to syslog failed
(#663) (#663)
https://github.com/python/cpython/commit
Vinay Sajip added the comment:
New changeset 46e81d3345b979f835740a228857906dca0f59c0 by Vinay Sajip in branch
'3.6':
bpo-29808: Do not fail in SysLogHandler constructor if syslog isn't available.
(#696)
https://github.com/python/cpython/commit/46e81d3345b979f835740a228857906dca0f59c0
Vinay Sajip added the comment:
New changeset e59af55c28b657cdf57c71a7b0837c9e9f4b2a31 by Vinay Sajip in branch
'3.5':
bpo-29808: Do not fail in SysLogHandler constructor if syslog isn't available.
(#695)
https://github.com/python/cpython/commit/e59af55c28b657cdf57c71a7b0837c9e9f4b2a31
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
pull_requests: +569
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29808>
___
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
pull_requests: +570
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29808>
___
Vinay Sajip added the comment:
Sorry, I was a bit too hasty closing the issue.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bu
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
nosy: +ned.deily
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29804>
___
_
Vinay Sajip added the comment:
I don't think it's a regression. It's catching an error that was there, but
wasn't tested for before.
If it should be a release blocker - that should not be for any reversion of the
change to the test, but for implementing the pass-by-value functionality
Vinay Sajip added the comment:
> Nothing special. Just try to create SysLogHandler when syslog server is down.
Which specific syslog configuration? UDP listener, Unix socket listener, or
both?
--
___
Python tracker <rep...@bugs.python.org&
Vinay Sajip added the comment:
Can you provide a short script which demonstrates exactly the problem you're
trying to solve?
--
nosy: +vinay.sajip
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Vinay Sajip added the comment:
The test checks that a structure passed by value is indeed passed by value -
something that is architecture-dependent, as calling conventions differ across
architectures.
If the test fails, this indicates that the structure isn't being passed by
value
Vinay Sajip added the comment:
This is not a bug - logging is formatting the message as per the specified
format string. It then prepends the priority and sends the result to the
socket. What you are seeing is just how systemd/journald interpret the message
that's sent.
--
resolution
Vinay Sajip added the comment:
> Perhaps it should instead use two specific flags, TYPEFLAG_HASBITFIELD and
> TYPEFLAG_HASUNION
This seems better at first sight. It's not making any suitability decisions
(apart from doing the unrolling), and the meaning of these flags will be less
vo
Vinay Sajip added the comment:
> It occurs to me that in the 1st pass, it also needs to propagate the
> non-argument flag from any field that has it set.
So does that mean disallowing a structure which contains a union? What about if
the final structure is large enough to require p
Vinay Sajip added the comment:
> We need more feedback on this suggested flag, especially to stay consistent
> with CFFI if possible.
Undoubtedly, more feedback would be very helpful. I'm not sure using this flag
impacts on consistency with CFFI particularly, since it's an in
Vinay Sajip added the comment:
Just a thought - the TYPEFLAG_NONARGTYPE needs to be copied from the base class
if set there, right?
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Vinay Sajip added the comment:
Thanks for the comments. Using your suggestions simplifies things quite a bit.
Still finding my way around :-)
> Regarding structs with bitfields and unions, we could add an stgdict flag to
> prevent passing them as arguments in the Unix X86_
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
nosy: +vinay.sajip
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue16575>
___
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
nosy: +vinay.sajip
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue16576>
___
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
nosy: +vinay.sajip
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26628>
___
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
nosy: +vinay.sajip
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue28686>
___
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
nosy: +vinay.sajip
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue28129>
___
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bu
Vinay Sajip added the comment:
> sys.is_finalizing()
Good to know. Is the "sys" binding guaranteed to be around even when other
builtins like "open" aren't available? In order to handle things "nicely"
during shutdown, what guarantees can logging code rely
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
stage: needs patch -> patch review
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Vinay Sajip added the comment:
Patch attached, including tests. If it looks halfway sensible, I can work up a
PR.
--
Added file: http://bugs.python.org/file46660/fix-22273-02.diff
___
Python tracker <rep...@bugs.python.org>
<http://bugs.p
Vinay Sajip added the comment:
New changeset 3cc5817cfaf5663645f4ee447eaed603d2ad290a by GitHub in branch
'3.6':
Fixed bpo-29565: Corrected ctypes passing of large structs by value on Windows
AMD64. (#168) (#220)
https://github.com/python/cpython/commit
Vinay Sajip added the comment:
New changeset 8fa7e22134ac9626b2188ff877f6aeecd3c9e618 by GitHub in branch
'3.5':
Fixed bpo-29565: Corrected ctypes passing of large structs by value on Windows
AMD64. (#168) (#221)
https://github.com/python/cpython/commit
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
pull_requests: +185
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29565>
___
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
pull_requests: +184
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29565>
___
Vinay Sajip added the comment:
Calling logging.shutdown() when you know you're about to exit should eliminate
some of the issues.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Vinay Sajip added the comment:
> The logging module should be be enhanced to handle more nicely such error
> during Python finalization.
How does a particular piece of logging package code know it's being called
during Python finalization? This sort of problem (exceptions
Vinay Sajip added the comment:
I'm learning a bit about Linux calling conventions :-)
But it also works when a 16-byte array is followed by 2 ints; if the two ints
are removed, then it fails again.
ctypes sets elements up in the first case to be a FFI_TYPE_POINTER slot
followed by two slots
Vinay Sajip added the comment:
Possibly also relevant: #16575 and
https://github.com/libffi/libffi/issues/33
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Vinay Sajip added the comment:
Thanks for spelling it out for me, that's helpful. But I'm still confused about
a couple of things: I can't find classify_argument in the Python source tree
other than in
Modules/_ctypes/libffi_osx/x86/x86-ffi64.c
Is that the file you referred to as ffi64.c? I
Vinay Sajip added the comment:
New changeset a86339b83fbd0932e0529a3c91935e997a234582 by GitHub in branch
'master':
Fixed bpo-29565: Corrected ctypes passing of large structs by value on Windows
AMD64. (#168)
https://github.com/python/cpython/commit/a86339b83fbd0932e0529a3c91935e997a234582
Vinay Sajip added the comment:
New changeset a86339b83fbd0932e0529a3c91935e997a234582 by GitHub in branch
'master':
Fixed bpo-29565: Corrected ctypes passing of large structs by value on Windows
AMD64. (#168)
https://github.com/python/cpython/commit/a86339b83fbd0932e0529a3c91935e997a234582
Vinay Sajip added the comment:
I've not marked it "patch review" as the patch isn't complete. Just wanted to
see if anyone can reproduce/explain the working on Windows/failing on Linux.
--
___
Python tracker <rep...@bugs.pyth
Vinay Sajip added the comment:
> I think we can special-case small arrays in PyCStructUnionType_update_stgdict
Is that definitely the right place? And is doing it only for small arrays going
to be enough? Currently, PyCStructUnionType_update_stgdict does
dict = PyType_stgdict(d
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
nosy: +vinay.sajip
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue22273>
___
Vinay Sajip added the comment:
PR submitted.
--
stage: needs patch -> patch review
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.or
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
pull_requests: +133
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29565>
___
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
pull_requests: +132
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue20160>
___
Vinay Sajip added the comment:
When adding the fix for #20160 I had added a test involving passing a struct by
value to a Python callback. I modified that test to update the struct in the
callback, and check that the passed-in struct hadn't changed.
def test_callback_large_struct(self
Vinay Sajip added the comment:
Just trying to confirm my understanding - in both this issue and #22273, the
example struct has a single array member. Is the problem confined just to how
ctypes describes arrays in structs/unions to libffi? The comment on #22273
seems to suggest so
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bu
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bu
Vinay Sajip added the comment:
> Any idea how we get a CPython dev to look at this patch?
Well, I'm one of them, so ... :-)
I will commit it soon, given that Thomas Nyberg has also given his feedback. It
was just waiting for your comme
Vinay Sajip added the comment:
I don't see the point - your proposed solution only works if the log file is
completely empty at rollover time, but if the file contains a few bytes from an
earlier "short" log message, it might seem just as wasteful of a backup slot as
if it had zer
Vinay Sajip added the comment:
Other scripts (activate, activate.csh, activate.csh) support this environment
variable already. This patch updates Activate.ps1 to respect the variable - can
you confirm if this change works for you?
--
assignee: -> vinay.sajip
keywords: +patch
st
Vinay Sajip added the comment:
> No, we cannot consider these changes under any circumstances for 2.7 because
> ...
Well, it would change import behaviour in a backwards-incompatible way,
wouldn't it?
--
___
Python tracker <rep...@bugs.p
Vinay Sajip added the comment:
There's nothing particular about logging here, is there? Any of the 2.7 stdlib
modules will exhibit similar behaviour, since that __future__ import is not in
general defined in the stdlib modules, other than in the test suite
Vinay Sajip added the comment:
Patch uploaded herewith.
--
assignee: -> vinay.sajip
stage: -> patch review
Added file: http://bugs.python.org/file46283/issue-24875-01.diff
___
Python tracker <rep...@bugs.python.org>
<http://
Vinay Sajip added the comment:
I see why I couldn't reproduce the problem - there's no pip installed in the
site-packages of the Pythons I was testing with, so the problem didn't show up.
Mark, can you apply the version of EnvBuilder.create that I posted in a message
above and see
Vinay Sajip added the comment:
I've added a patch, can you confirm if it resolves the issue?
--
assignee: -> vinay.sajip
keywords: +patch
stage: -> patch review
Added file: http://bugs.python.org/file46278/issue-29213-01.diff
___
Python t
Vinay Sajip added the comment:
Just a sanity check ... I can't reproduce the issue with the latest versions of
Python (I haven't made any changes to the venv code):
On Python 3.5:
vinay@ubuntu:~/projects/python/3.5$ ./python
Python 3.5.3rc1+ (3.5:d9a64d00a439, Jan 13 2017, 10:26:23)
[GCC
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
assignee: -> vinay.sajip
resolution: -> fixed
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bu
Vinay Sajip added the comment:
It seems simpler to do it all in EnvBuilder.create:
def create(self, env_dir):
"""
Create a virtual environment in a directory.
:param env_dir: The target directory to create an environment in.
&quo
Vinay Sajip added the comment:
Changesets:
3.5 d6ae934da199
3.6 8f77c4f93806
default 7afe82ad34e7
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Vinay Sajip added the comment:
I've pushed the changes, but due to some SMTP problem this issue wasn't updated
by Roundup:
remote: SMTPServerDisconnected: Connection unexpectedly closed: timed out
remote: error: changegroup.roundup hook raised an exception: Connection
unexpectedly closed
Vinay Sajip added the comment:
If we do this, the activate script will have LF (POSIX) line endings on
Windows. Will this work for things like cygwin, Git-bash etc?
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Vinay Sajip added the comment:
Although we don't currently have binaries under venv/scripts, that might change
in the future. The logic could be changed to:
with open(srcfile, 'rb') as f:
data = f.read()
if not srcfile.endswith('.exe'):
try:
data
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
resolution: -> fixed
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.
Vinay Sajip added the comment:
OK, will apply to 3.5 -> default.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29220>
___
Vinay Sajip added the comment:
> The fix should be applied to 3.5.
Are you sure?
$ python3.5
Python 3.5.2 (default, Nov 17 2016, 17:05:23)
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.
Vinay Sajip added the comment:
> I think that even with empty name the output contains extra separators
Not sure what you mean - please clarify with an example.
> I would add an indentation for the second "if" ... or even use multiple
> returns for the sake of microopti
Vinay Sajip added the comment:
This change was due to fixing #27937. Since yours is not a common use case, and
since the workaround works for you, I propose not to change things back.
--
assignee: -> vinay.sajip
status: open -> pending
___
Vinay Sajip added the comment:
Thanks for the improvements to my patch. The 03-version looks good to me.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Vinay Sajip added the comment:
I'm fine with removing the loop, as there are only ever going to be the two
cases - so Berker's suggestion would seem to cover both doctest and unittest
cases.
--
___
Python tracker <rep...@bugs.python.org>
Vinay Sajip added the comment:
> including the SysLogHandlerTest, which wasn't reported
Sorry, I appear to have lost the ability to read :-(
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.or
Vinay Sajip added the comment:
I've added a patch that should handle these errors (including the
SysLogHandlerTest, which wasn't reported, but I think the same logic applies).
To simulate failure during setup, uncomment one or more of the lines which says
# raise ValueError('dummy error
Vinay Sajip added the comment:
> Would that make sense to move the server.start() part out of setUp() and in
> its own method
My preference would be to just catch the error in SocketHandlerTest.setUp() and
leave things in a tidy state (e.g. .server and .sock_hdlr set to None)
Vinay Sajip added the comment:
I'm closing this on the basis that I don't believe there's a bug here, but you
can of course re-open if you have evidence to the contrary.
--
resolution: -> not a bug
status: open -> closed
___
Python tracke
Vinay Sajip added the comment:
> To reproduce the test_logging cleanup problem, insert skipTest() in setUp()
My understanding is that skipTest would normally be raised in the test method
itself or as a decorator to it, and not in setUp() itself. (It wouldn't make
sense to, as that would s
Vinay Sajip added the comment:
Evan, thanks for looking at this. Would you like to submit a completed
contributor form?
https://www.python.org/psf/contrib/contrib-form/
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.p
Vinay Sajip added the comment:
> Have a look at the sample.py program.
It fails on Python 3.4.3 on my Linux system (just renamed to mp_sample.py):
python3 mp_sample.py
starting (without multiprocessing pool)...
worker process 0
worker process 3
worker process 4
worker process 6
worker proc
Vinay Sajip added the comment:
It may be that _thread.RLock objects were pickleable before 3.6 but aren't now,
and if so, then this is unrelated to logging except by coincidence.
Why do you want to pickle the *handler*? It's not especially designed for
sending over the wire, and that's
Changes by Vinay Sajip <vinay_sa...@yahoo.co.uk>:
--
resolution: -> fixed
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.
Vinay Sajip added the comment:
I'll close this - as indicated in my comment, there's no need for this
enhancement, as the already available "extra" parameter performs the same
function.
--
resolution: -> wont fix
status: open -> closed
__
Vinay Sajip added the comment:
> I tried making a Framework build of Python with the environment variable
> removed entirely, but I'm not experienced enough with builds on a Mac to know
> what I need to do to create a proper build.
Given Jason's comment above, it's probably bes
701 - 800 of 2016 matches
Mail list logo
