[issue36440] more helpful diagnostics for parser module

2019-04-06 Thread Xavier Combelle


Change by Xavier Combelle :


--
nosy:  -xcombelle

___
Python tracker 
<https://bugs.python.org/issue36440>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36256] parser module fails on legal input

2019-03-12 Thread Xavier Combelle


Xavier Combelle  added the comment:

never used the parser module nor lib2to3. Does they have any advantage over 
ast.parse and ast module ?

--

___
Python tracker 
<https://bugs.python.org/issue36256>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28962] Crash when throwing an exception with a malicious __hash__ override

2016-12-22 Thread Xavier Combelle

Xavier Combelle added the comment:

To my knowledge it is not the kind of arbitrary code which could segfault 
python code. It is far different for example that the fact by using bytecode 
magic you can segfault the interpreter, as this last case is explicitly warned 
in documentation.

--
nosy: +xcombelle

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue28962>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26363] __builtins__ propagation is misleading described in exec and eval documentation

2016-12-01 Thread Xavier Combelle

Xavier Combelle added the comment:

not an inconsisties but in the eval documentaion nothing specify that the 
builtins propagate between levels updates

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26363>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26363] __builtins__ propagation is misleading described in exec and eval documentation

2016-12-01 Thread Xavier Combelle

Xavier Combelle added the comment:

Hi Julien,

You are fully right that it is the builtin module dictionnary which is inserted 
in eval or exec context.

However, if a "__builtins__" entry is passed to eval or exec, this builtin 
module dictionnary is modified hence the following work: 

>>> d={"tata":"tata"}
>>> print(eval("tata",{'__builtins__':d}))
tata

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26363>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26363] __builtins__ propagation is misleading described in exec and eval documentation

2016-11-29 Thread Xavier Combelle

Xavier Combelle added the comment:

It is not the dictionary of builtin module, which is inserted in , but the 
current __builtin__ global which happen to be normally the dictionnary of 
builtin. Hence in the following code, the builtins propagation works has 
expected.

>>> eval("""eval('spam("hello 
>>> world")',{})""",{"__builtins__":{"eval":eval,"spam":print}})
hello world

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26363>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26415] Excessive peak memory consumption by the Python parser

2016-08-15 Thread Xavier Combelle

Xavier Combelle added the comment:

Looks that there is two bug as partial solution of the main bug which is reduce 
memory consumption of the parser:
- The compression thing
- the reducing of heap fragmentation
Could each sub bug have it's own bug tracker and mark them blocking for the 
main bug ?

A. Skrobov Can you describe the big picture of your patch, without I don't 
understand the logic of your modifications.

--
nosy: +xcombelle

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26415>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12345] Add math.tau

2016-08-13 Thread Xavier Combelle

Xavier Combelle added the comment:

Python will really follow the tau sort joke ? I never saw it mentioned in any 
serious math or programming document. All the github search result looks like 
people who are in this joke (kind of).


The page http://tauday.com/state-of-the-tau list very little use of tau in 
relevant domains, the most relevant to our discussion would be the including of 
tau in modula-2 standard library.

I don't see how the introduction of the unknown tau constant in python programs 
will make them clearer or better to the targeted public who will read them.

I must confess however that 2*pi occurs frequently in formula and these formula 
would be simplified if tau was used. However an honest and non partisan web 
site would list all the use of pi without 2 where the formula would be more 
complicated. I don't see that so I'm still not convinced.

I know that Guido van Rossum is the Benevolent dictator for life of python, but 
as I understand it until this point, the dictator position was used after all 
argument took place and not before.

--
nosy: +xcombelle

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue12345>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

2016-08-10 Thread Xavier Combelle

Xavier Combelle added the comment:

The DFA is generated by other part of existing cpython code ? If it's the case 
looks like you did a great job.

--
nosy: +xcombelle

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26526>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25571] Improve the lltrace feature with the Py_Debug mode

2016-07-20 Thread Xavier Combelle

Xavier Combelle added the comment:

I made some comment on code in review.

A thing that worry me that there is zero automated test.

In my opinion the minimal should be to test the expected output.

A nice to have would be a test for the write_contents function of 
makeopcodetranslations.py

--
nosy: +xcombelle

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue25571>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26363] __builtins__ propagation is misleading described in exec and eval documentation

2016-02-15 Thread Xavier Combelle

New submission from Xavier Combelle:

According to my experiment in code, the current behavior of python3.5 is 
different that the document says. If I understand well the purpose of this 
behavior is to propagate the __builtins__ global constant if globals has not 
one.

In
https://docs.python.org/3.6/library/functions.html#eval

it is written  "If the globals dictionary is present and lacks ‘__builtins__’, 
the current globals are copied into globals before expression is parsed." only 
the __builtins__ looks copied not all the globals


In
https://docs.python.org/3.6/library/functions.html#exec
It is written:
"If the globals dictionary does not contain a value for the key __builtins__, a 
reference to the dictionary of the built-in module builtins is inserted under 
that key." it looks like it is not a reference to the built-in module builtin, 
but a reference to __builtin__ global

--
title: builtins propagation is misleading described in exec and eval 
documentation -> __builtins__ propagation is misleading described in exec and 
eval documentation
versions: +Python 3.5

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26363>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26363] builtins propagation is misleading described in exec and eval documentation

2016-02-15 Thread Xavier Combelle

Changes by Xavier Combelle <xavier.combe...@gmail.com>:


--
assignee: docs@python
components: Documentation
nosy: docs@python, xcombelle
priority: normal
severity: normal
status: open
title: builtins propagation is misleading described in exec and eval 
documentation

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26363>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18595] zipfile: symlinks etc.

2015-10-07 Thread Xavier Combelle

Xavier Combelle added the comment:

about the readlink functionnality, I would like to point that it might lead to 
security issues see for example 
https://security.stackexchange.com/questions/73718/how-zip-symlink-works

At least, the standard read should not do it by default.

--
nosy: +xcombelle

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue18595>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20891] PyGILState_Ensure on non-Python thread causes fatal error

2014-03-13 Thread Xavier Combelle

Changes by Xavier Combelle xavier.combe...@gmail.com:


--
nosy: +xcombelle

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20891
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3849] FUD in documentation for urllib.urlopen()

2014-03-11 Thread Xavier Combelle

Changes by Xavier Combelle xavier.combe...@gmail.com:


--
nosy: +xcombelle

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3849
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20197] Support WebP image format detection in imghdr module

2014-03-10 Thread Xavier Combelle

Changes by Xavier Combelle xavier.combe...@gmail.com:


--
nosy: +xcombelle

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20197
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19024] Document asterisk (*), splat or star operator

2013-09-30 Thread Xavier Combelle

Changes by Xavier Combelle xavier.combe...@gmail.com:


--
nosy: +xcombelle

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19024
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com