Xavier de Gaye added the comment:
> I found that there were three other mails raising this same
> NNTPDataError('line too long') in the 40 last mails.
Cannot reproduce it. These three exceptions must have been NNTPProtocolError
instead, caused by the initi
Xavier de Gaye added the comment:
The patch:
1) Increases _MAXLINE to 4096.
2) Reverts issue 16040 and that is not correct, please ignore that part.
The changes made in issue 16040 limit the amount of data read by readline() and
does not close the nntp session when the server sends a message
Xavier de Gaye added the comment:
It seems that the comment placed above the definition of _MAXLINE in the
nntplib module is not correct:
"RFC 3977 limits NNTP line length to 512 characters, including CRLF. We
have selected 2048 just to be on the safe side."
The 512 characters li
Xavier de Gaye added the comment:
Thanks for the patch. See my comments in Rietveld.
I think we can skip the 'step' command.
For the tests, can you use the existing run_pdb() method and trigger the
signals from within the code being executed with 'os.kill(os.getpid(),
Xavier de Gaye added the comment:
The patch fixes also the following errors in test_warnings:
==
FAIL: test_nonascii (test.test_warnings.CEnvironmentVariableTests
Xavier de Gaye added the comment:
Forgot the issue number in the commit message for the default branch, the
corresponding changeset is 80a041d39c20.
--
___
Python tracker
<http://bugs.python.org/issue26
Changes by Xavier de Gaye :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Xavier de Gaye added the comment:
> I'd be in favor of temporarily skipping the affected tests with a message
> that points back to here until we have a permanent solution.
I am working on it.
--
___
Python tracker
<http://b
Xavier de Gaye added the comment:
Closing as invalid, it is useful to have the test failing on platforms that do
not have CODESET and detect that too many modules are imported on startup. For
Android, this problem is fixed in issue 28596.
--
resolution: -> not a bug
stage: com
New submission from Xavier de Gaye:
These failures happen now that issue 28596 has been fixed and that
locale.getpreferredencoding(False) returns 'UTF-8'.
==
FAIL: test_strcoll_with
Xavier de Gaye added the comment:
Closing the issue. Thanks for the patch Chi Hsuan Yen.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Xavier de Gaye:
test_nonascii has been implemented in issue 16182.
The error message:
==
FAIL: test_nonascii (test.test_readline.TestReadline
Xavier de Gaye added the comment:
issue #28996: wcscoll is broken on Android and test_locale fails
issue #28997: test_readline.test_nonascii fails on Android
--
dependencies: +test_readline.test_nonascii fails on Android, wcscoll is broken
on Android and test_locale fails
Xavier de Gaye added the comment:
This patch defines a _MAXBYTES limit of 100 Mb. The limit is checked upon
reading one line and also upon reading the multi-lines of the response to a
user command.
--
Added file: http://bugs.python.org/file45939/nntplib_maxbytes.patch
Xavier de Gaye added the comment:
Both strcoll() and strxfrm() are broken (character 'à' unicode code point is
'e0'):
>>> import locale
>>> locale.setlocale(locale.LC_ALL, 'en_US.UTF-8')
'C.UTF-8'
>>> locale.strcoll('\u00e
Xavier de Gaye added the comment:
Here is a patch that skips test_strcoll_with_diacritic and
test_strxfrm_with_diacritic.
--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file45942/test_locale_strcoll.pa
Xavier de Gaye added the comment:
I responded to your last review Serhiy, but the psf mail system reports a
delivery failure, so you may have missed the notification as well as the other
reviewers.
--
___
Python tracker
<http://bugs.python.
Xavier de Gaye added the comment:
> If sender sends a lot of empty lines and file is not None, LF or CRLF is
> stripped from lines
Oh, I missed that. Maybe give a weight of 4 to 8 bytes or even more to a line,
this value being added to the bytes count whether the line is empty or not.
Xavier de Gaye added the comment:
> For me, it prints this: (includes “te” with an umlaut)
I got this same result when testing on Android with the interactive interpreter.
See the content of the 'completer' list below, when run with
tracing_the_completer.patch:
On linux:
Xavier de Gaye added the comment:
FWIW on Android we have:
>>> readline.__doc__ and "libedit" in readline.__doc__
False
>>> getattr(readline, "set_pre_input_hook", None)
--
___
Python track
Xavier de Gaye added the comment:
Checking that the the problem is indeed an encoding problem on Android with
readline.set_pre_input_hook(): with tracing_the_completer_2.patch that replaces
'\xEB' with 'A', the test now succeeds and prints:
test_nonascii (test.test_r
Changes by Xavier de Gaye :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Xavier de Gaye added the comment:
Martin in response to your last review, I still hold to my opinion stated in
msg283294 but this should not prevent this high priority issue to progress. Can
you propose another patch.
--
___
Python tracker
<h
Xavier de Gaye added the comment:
The test is ok on Android when LANG=en_US.UTF-8.
When LANG is not set, the check made by the first statement in test_nonascii()
should skip the test but fails to skip it on Android as Py_EncodeLocale()
always encode to utf8 whatever the locale (same as with
Changes by Xavier de Gaye :
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue28997>
___
___
Python-bugs-list mai
Xavier de Gaye added the comment:
No, the patch prevents posix.flock() to be defined on Android API 24 with
android-ndk-r13. But I plan to change it so that the test is skipped when posix
does not have the F_LOCK attribute as this problem is not worth a change in the
build machinery. It makes
Xavier de Gaye added the comment:
These changes break the darwin platform, socket.if_nameindex() is not defined
anymore. On Darwin, 'net/if.h' requires that 'sys/socket.h' be included
beforehand (see the autoconf documentation).
--
__
Changes by Xavier de Gaye :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Xavier de Gaye:
android-ndk-r14 introduces "Unified Headers" [1] and is planned to be released
late january/early february 2017 [2].
__ANDROID_API__ is not anymore defined in 'android/api-level.h' that is
currently included by Include/pyport.h, and is
Xavier de Gaye added the comment:
issue #29040: building Android with android-ndk-r14
--
dependencies: +building Android with android-ndk-r14
___
Python tracker
<http://bugs.python.org/issue26
Xavier de Gaye added the comment:
Thanks for the review Victor.
I have created issue 29040: building Android with android-ndk-r14.
--
___
Python tracker
<http://bugs.python.org/issue28
Xavier de Gaye added the comment:
New patch.
Please use autoreconf before running the patch (autoreconf instead of autoconf
because the description of HAVE_LOCKF has been updated).
--
title: configure links with lockf and F_LOCK is not declared in Android API 24
-> lockf()
Xavier de Gaye added the comment:
> Seems that indicates future Python versions will require at least NDK r14 to
> build?
Yes.
--
___
Python tracker
<http://bugs.python.org/i
Changes by Xavier de Gaye :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Xavier de Gaye added the comment:
With your patch Martin, test_nonascii is skipped on Android when LANG is not
set and the issue is fixed.
> Just to clarify, is the problem that Python (correctly) assumes UTF-8
> encoding on Android, but Readline does not unless you tweak the envir
Xavier de Gaye added the comment:
Thanks for waiting for a run of the patch on Android.
Indeed, test_input_tty_non_ascii fails with this patch on Android when LANG is
not set and is ok when LANG=en_US.UTF-8. As you are suggesting, the test is ok
when skipping the Readline half of the test
Changes by Xavier de Gaye :
--
versions: +Python 3.6
___
Python tracker
<http://bugs.python.org/issue26851>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xavier de Gaye added the comment:
Latest patch committed with the following simplification: BASECFLAGS and
LDFLAGS are now set for armv7 at the same place, as suggested by Martin in
msg271518.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Xavier de Gaye added the comment:
In the code review Victor asked the following question:
> I'm a little bit surprised that you need to pass so much options which are
> specific to the platform. GCC doesn't have a generic option "hello, please
> compile for my archite
Xavier de Gaye added the comment:
issue #28833: cross compilation of third-party extension modules
--
dependencies: +byte-compile fails for cross-builds, cross compilation of
third-party extension modules
___
Python tracker
<http://bugs.python.
Xavier de Gaye added the comment:
> Just tried. With my packaging scripts, CPython on ARM is compiled with
> -mfloat-abi=softfp -mfpu=vfpv3-d16 while libffi not. test_ctypes pass as
> usual.
This works as expected, '-mfloat-abi=softfp' and the default '-mfloat-abi=so
Xavier de Gaye added the comment:
Removing issues from the dependencies list:
issue #22747: Interpreter fails in initialize on systems where
HAVE_LANGINFO_H is undefined
This issue is fixed for Android.
issue #26859: unittest fails with "Start directory is not importable&
New submission from Xavier de Gaye:
This happens on Android for a non-root user. One test in test_logging fails.
Multiple tests fail in test_socketserver with identical backtraces, only the
first one is listed here
New submission from Xavier de Gaye:
==
ERROR: test_module_funcs (test.test_curses.TestCurses)
Test module-level functions
--
Traceback (most recent call last
Xavier de Gaye added the comment:
test_logging fails also with the following backtrace:
==
FAIL: test_output (test.test_logging.UnixSocketHandlerTest
New submission from Xavier de Gaye:
==
[1633/2616]
ERROR: test_link (test.test_os.LinkTests)
--
Traceback (most recent call last):
File
Xavier de Gaye added the comment:
To reproduce the test_logging cleanup problem, insert skipTest() in setUp():
diff -r 4a97fa319bf7 Lib/test/test_logging.py
--- a/Lib/test/test_logging.py Fri Jan 06 09:52:19 2017 +0100
+++ b/Lib/test/test_logging.py Fri Jan 06 16:39:38 2017 +0100
@@ -1440,6
Xavier de Gaye added the comment:
The test_logging cleanup problem induces another problem. When test_lib2to3 is
run after the failing test_logging then test_lib2to3 fails with:
==
FAIL
Xavier de Gaye added the comment:
The code review of your first patch still applies to your last patch.
--
___
Python tracker
<http://bugs.python.org/issue22
Xavier de Gaye added the comment:
> My understanding is that skipTest would normally be raised in the test method
> itself or as a decorator to it, and not in setUp() itself.
Agreed. Would that make sense to move the server.start() part out of setUp()
and in its own method that wo
New submission from Xavier de Gaye:
==
[339/2616]
ERROR: test_link_size (test.test_tarfile.Bz2WriteTest)
--
Traceback (most recent call last
New submission from Xavier de Gaye:
This happens on Android for a non-root user. Multiple tests fail in
test_socketserver with identical backtraces, only the first one is listed here.
==
[905/2616]
ERROR
Xavier de Gaye added the comment:
I have split this issue, issue 29184 is for fixing the tests on
test_socketserver and this issue is for fixing the tests on test_logging.
--
assignee: xdegaye ->
title: skip tests using socketserver.UnixStreamServer when bind() raises
PermissionEr
Xavier de Gaye added the comment:
> Do you want to take this on, or do you want me to look at it?
I would be very grateful if you would handle that :)
But if you cannot spare the time, I can give it a try.
One point I forgot to mention is that DatagramHandlerTest and SysLogHandlerTest
a
New submission from Xavier de Gaye:
==
ERROR: test_tarfile_vs_tar
(distutils.tests.test_archive_util.ArchiveUtilTestCase)
--
Traceback (most recent call last
Xavier de Gaye added the comment:
issue #29176: /tmp does not exist on Android and is used by
curses.window.putwin()
issue #29177: skip tests of test_logging when bind() raises PermissionError
(non-root user on Android)
issue #29180: skip tests that raise PermissionError in test_os (non-root
Changes by Xavier de Gaye :
--
nosy: +lars.gustaebel
___
Python tracker
<http://bugs.python.org/issue29181>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xavier de Gaye :
Added file: http://bugs.python.org/file46194/issue-29177-03.patch
___
Python tracker
<http://bugs.python.org/issue29177>
___
___
Python-bug
Xavier de Gaye added the comment:
issue-29177-02.diff is a modified version of the previous patch that uses
support.unlink() instead of os.remove() to handle the failure occuring for a
non-existent file
when the test is skipped because of Permission denied. With this patch
test_logging is ok
Xavier de Gaye added the comment:
Patch attached.
--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file46195/test_distutils.patch
___
Python tracker
<http://bugs.python.org/issu
Xavier de Gaye added the comment:
Patch attached.
--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file46199/test_tarfile.patch
___
Python tracker
<http://bugs.python.org/issu
Xavier de Gaye added the comment:
Patch attached.
--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file46200/test_os.patch
___
Python tracker
<http://bugs.python.org/issu
Xavier de Gaye added the comment:
Patch attached.
--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file46201/test_socketserver.patch
___
Python tracker
<http://bugs.python.org/issu
Xavier de Gaye added the comment:
> Why os.link() is failed? If hard links are not supported on Android,
> shouldn't os.link be not implemented?
Android has a restrictive security model based on SELinux [1].
With the Android adb shell on the emulator at API level 24:
$ >foo
$
Xavier de Gaye added the comment:
> If test_os is the only user of the helper, I'd say let's keep it in
> Lib/test/test_os.py for now.
I agree with that concern.
support.os_link() is also used by a patch in issue 29181, and I am planning to
modify the changes made by issue 2
Xavier de Gaye added the comment:
Re-opening the issue for a more generic change that skips the tests when
PermissionError is raised instead of when they are run by an Android non-root
user as this is done currently after the previously pushed changes.
--
resolution: fixed ->
st
Xavier de Gaye added the comment:
Thanks for this interesting suggestion Serhiy. I propose to use
supported_operation() as the name of the helper() generator.
I will update the patches accordingly in issues #29180, #29181 and #29184, and
re-open issue 28764
Xavier de Gaye added the comment:
> re-open issue 28764.
Oops, no issue 28764 is not relevant here.
--
___
Python tracker
<http://bugs.python.org/issu
Xavier de Gaye added the comment:
New patch following Serhiy's suggestion in msg285008.
--
Added file: http://bugs.python.org/file46231/issue28759-01.patch
___
Python tracker
<http://bugs.python.org/is
Xavier de Gaye added the comment:
New patch following Serhiy's suggestion in msg285008.
--
Added file: http://bugs.python.org/file46232/issue29180_01.patch
___
Python tracker
<http://bugs.python.org/is
Xavier de Gaye added the comment:
New patch following Serhiy's suggestion in msg285008.
--
Added file: http://bugs.python.org/file46233/issue29181_01.patch
___
Python tracker
<http://bugs.python.org/is
Xavier de Gaye added the comment:
New patch following Serhiy's suggestion in msg285008.
--
Added file: http://bugs.python.org/file46234/issue29184_01.patch
___
Python tracker
<http://bugs.python.org/is
Xavier de Gaye added the comment:
Trying to track the 'char * text' pointer that is returned to Python by
readline in rlhandler() and using gdb 'set follow-fork-mode child' and 'set
detach-on-fork off' to stop (with a breakpoint in rlhandler) in the child
spawned
Changes by Xavier de Gaye :
--
assignee: xdegaye ->
___
Python tracker
<http://bugs.python.org/issue28997>
___
___
Python-bugs-list mailing list
Unsubscrib
Xavier de Gaye added the comment:
'supported_operation':
* The intent in using 'supported' was that the context manager could possibly
be extended later.
* 'operation' is the terminology used in the GNU libc documentation [1].
I will replace 'supported_o
Changes by Xavier de Gaye :
Added file: http://bugs.python.org/file46266/ncurses.patch
___
Python tracker
<http://bugs.python.org/issue29176>
___
___
Python-bugs-list m
Xavier de Gaye added the comment:
The test suite runner in the test.libregrtest.main module calls
tempfile.gettempdir() and mkstemp_curses.patch uses the same logic to fix the
problem on Android where the tests that I run use TMPDIR=/data/local/tmp on
Android API 24.
As a side note, when the
Xavier de Gaye added the comment:
Please go ahead and start the discussion on Python-Dev.
--
assignee: xdegaye ->
___
Python tracker
<http://bugs.python.org/issu
Xavier de Gaye added the comment:
This new patch skips the second test when hard links fail on the platform under
test.
--
Added file: http://bugs.python.org/file46269/test_distutils_2.patch
___
Python tracker
<http://bugs.python.org/issue29
Xavier de Gaye added the comment:
can_symlink() is needed by test_posixpath and other tests, new patch.
--
Added file: http://bugs.python.org/file46271/test_distutils_3.patch
___
Python tracker
<http://bugs.python.org/issue29
Xavier de Gaye added the comment:
The changes made in issue #28174 fix the problem for the Android x86 platform
and for the armv7 platform at Android API level 24, but the problem is still
there on the armv7 platform at Android API level 21
Xavier de Gaye added the comment:
Skipping those tests on Android has already been proposed with the existing
patches in this issue.
The reason why the changes made by issue 28174 fix only partly the problem
should be understood.
--
___
Python
Xavier de Gaye added the comment:
Current status:
---
Available using the pyona build system [1]:
* Cross compilation of Python for a given Android API level and architecture
with android-ndk-r13b.
* Cross compilation of third party extension modules (currently as a patch
Xavier de Gaye added the comment:
PEP 538 [1] coerces the C locale to UTF-8 by setting the locale environment
variables (LC_ALL, LANG). The PEP has an implementation at issue 28180 as
pep538_coerce_legacy_c_locale_v3.diff, and the patch fixes test_nonascii when
run on the Android emulators
Xavier de Gaye added the comment:
pep538_coerce_legacy_c_locale_v3.diff fixes issue 28997 on Android (api 21 and
24). This issue is raised because there is an inconsistency between Python on
Android that considers the locale encoding to be always UTF-8 and GNU Readline
that does not accept
Xavier de Gaye added the comment:
> I think we should wait for the resolution of PEP 538 and of issue 28684
s/issue 28684/issue 28180/
--
___
Python tracker
<http://bugs.python.org/issu
Xavier de Gaye added the comment:
issue #28180: sys.getfilesystemencoding() should default to utf-8
--
dependencies: +sys.getfilesystemencoding() should default to utf-8
___
Python tracker
<http://bugs.python.org/issue26
Xavier de Gaye added the comment:
With input-readline.v3.patch, test_builtin runs with success on Android api 21.
With pep538_coerce_legacy_c_locale_v4.diff that implements PEP 538 in issue
28180, and with input-readline.v3.patch modified to have 'readline_enc
Xavier de Gaye added the comment:
Please try:
make CFLAGS_NODIST=-std=gnu99
--
nosy: +xdegaye
___
Python tracker
<http://bugs.python.org/issue29267>
___
___
Pytho
Xavier de Gaye added the comment:
The rationale supporting this change is sound and the patch LGTM.
--
nosy: +xdegaye
___
Python tracker
<http://bugs.python.org/issue29
Xavier de Gaye added the comment:
> On Android, setlocale(CATEGORY, "") does not look for the locale environment
> variables (LANG, ...) but sets the 'C' locale instead
FWIW the source code of setlocale() on bionic (Android libc) is at
https://android.googlesource.co
Xavier de Gaye added the comment:
See also msg286365.
--
nosy: +xdegaye
resolution: -> third party
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Xavier de Gaye added the comment:
I have left some comments on Rietveld after a partial code review.
IMO for reasons of repeatability and easier maintenance [1], all the tests
should be run with the pty set in a known mode, whether canonical or raw, and a
test involving pty.spawn() should
Changes by Xavier de Gaye :
--
nosy: +xdegaye
___
Python tracker
<http://bugs.python.org/issue29400>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xavier de Gaye added the comment:
> About performances: it's fine to add anything to maybe_call_line_trace(), it
> cannot impact performances when tracing is not used.
I do not agree, Python debuggers are already really really slow. They should
not have to process 'instructi
Xavier de Gaye added the comment:
> The motivation for this suggestion was that for tracers that *are* interested
> in instructions, it *might* be simpler to get two calls, one of 'line', and
> one of 'instruction'. Maybe it's a bad idea though.
Thanks
Changes by Xavier de Gaye :
--
assignee: xdegaye ->
___
Python tracker
<http://bugs.python.org/issue28833>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Xavier de Gaye :
--
assignee: xdegaye ->
___
Python tracker
<http://bugs.python.org/issue29180>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Xavier de Gaye :
--
assignee: xdegaye ->
___
Python tracker
<http://bugs.python.org/issue29181>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Xavier de Gaye :
--
assignee: xdegaye ->
___
Python tracker
<http://bugs.python.org/issue29184>
___
___
Python-bugs-list mailing list
Unsubscrib
801 - 900 of 1492 matches
Mail list logo
