Xiang Zhang added the comment:
Sorry, it's #39057
--
___
Python tracker
<https://bugs.python.org/issue32408>
___
___
Python-bugs-list mailing list
Unsubscr
Xiang Zhang added the comment:
I think this issue has already been solved by #39507. The time difference is:
before:
time python3 -c 'import urllib.request;
urllib.request.proxy_bypass_environment("1.1.1.1")'
real0m0.912s
user0m0.902s
sys 0m0.010s
aft
Change by Xiang Zhang :
--
resolution: -> out of date
stage: test needed -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
@Ezio, at least for my config they are all ASCII digits. But still I don't
think there is any rush to change current behaviour.
--
___
Python tracker
<https://bugs.python.org/is
Xiang Zhang added the comment:
I can't understand the rational for rejecting localized digits though I don't
know who will use them in practise. I'd rather fix it until there is a real
problem with it.
--
nosy: +xiang.zhang
___
Xiang Zhang added the comment:
New changeset d8ca2354ed30c12b9ce37c4535222b700a727b32 by Xiang Zhang (Taine
Zhao) in branch 'master':
bpo-34953: Implement `mmap.mmap.__repr__` (GH-9891)
https://github.com/python/cpython/commit/d8ca2354ed30c12b9ce37c4535222b
Change by Xiang Zhang :
--
components: +Extension Modules -Interpreter Core
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9 -Python 3.8
___
Python tracker
<https://bugs.python.or
Change by Xiang Zhang :
--
assignee: -> docs@python
components: +Documentation -Demos and Tools
nosy: +docs@python
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8, Python 3.9
___
Py
Xiang Zhang added the comment:
New changeset 038503e08ac5b10601b95d5adc2c2cab7be10163 by Xiang Zhang (Krishna
Oza) in branch 'master':
bpo-38391: Fixing a typo for Py_DECREF (GH-16616)
https://github.com/python/cpython/commit/038503e08ac5b10601b95d5adc2c2cab7be10163
-
Change by Xiang Zhang :
--
components: +Extension Modules -Interpreter Core
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 2.7, Python 3.7, Python 3.8, Python 3.9
___
Python tracke
Xiang Zhang added the comment:
New changeset 68d8c122972d7a49627b983af4ccbfad9f5ade17 by Xiang Zhang in branch
'2.7':
[2.7] bpo-38168: Fix a possbile refleak in setint() of mmapmodule.c (GH-16136)
(GH-16176)
https://github.com/python/cpython/commit/68d8c122972d7a49627b983af4ccbf
Change by Xiang Zhang :
--
pull_requests: +15786
pull_request: https://github.com/python/cpython/pull/16176
___
Python tracker
<https://bugs.python.org/issue38
Xiang Zhang added the comment:
>It may be better to apply it even to the developed version. There is nothing
>wrong with creating the tee iterator in one thread and using it the other
>thread. Or using the tee iterators with external locking. I afraid that PR
>15567 can break
Change by Xiang Zhang :
--
components: +Tests
resolution: -> rejected
stage: patch review -> resolved
status: open -> closed
type: -> enhancement
___
Python tracker
<https://bugs.python
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
title: Adding a unit test of unicode in test_unicode.py -> Adding tests for
PyUnicode_AsUTF8 and PyUnicode_AsUTF8AndSize
___
Py
Xiang Zhang added the comment:
New changeset 5623ac87bbe5de481957eca5eeae06347612fbeb by Xiang Zhang (Hai Shi)
in branch 'master':
bpo-37476: Adding tests for asutf8 and asutf8andsize (GH-14531)
https://github.com/python/cpython/commit/5623ac87bbe5de481957eca5eeae06
Change by Xiang Zhang :
--
versions: -Python 3.5
___
Python tracker
<https://bugs.python.org/issue37606>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
In Py3, you should use `python -m test test_dtrace` to run the test suite.
--
nosy: +xiang.zhang
resolution: -> not a bug
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.5
_
Change by Xiang Zhang :
--
type: -> enhancement
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issue37476>
___
___
Python-bugs-list mai
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
title: Fix a type error in ctypes.rst -> Fix a wrong exception type in ctypes
documentation
versions: +Python 2.7, Python 3.7, Python 3.8
Xiang Zhang added the comment:
New changeset f6cdd3ff687ebbf8209d793a18a042ea495c4aeb by Xiang Zhang (Hai Shi)
in branch 'master':
bpo-37513: Change ValueError to TypeError in an example in ctypes doc (GH-14615)
https://github.com/python/cpyt
Xiang Zhang added the comment:
Should be TypeError. It's changed from ValueError to TypeError in
https://bugs.python.org/issue1831.
--
nosy: +xiang.zhang
___
Python tracker
<https://bugs.python.org/is
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
New changeset aeecf380660ea459d85bb5f59d76bb54f757b5be by Xiang Zhang (Hai Shi)
in branch 'master':
bpo-37441: Fix wrong PyErr_SetImportErrorSubclass signature in doc (GH-14453)
https://github.com/python/cpython/commit/aeecf380660ea459d85bb5f59d76bb
Xiang Zhang added the comment:
unicode.org doesn't list "丗" as numeric so I think there is nothing we can do.
--
resolution: -> not a bug
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https:/
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
New changeset 92330c0b6d6c253c41a133cc50caea4853c7e311 by Xiang Zhang
(Manjusaka) in branch 'master':
bpo-35497: add versionadded tag for EPOLLEXCLUSIVE (GH-11162)
https://github.com/python/cpython/commit/92330c0b6d6c253c41a133cc50caea
Change by Xiang Zhang :
--
assignee: -> docs@python
components: +Documentation -Library (Lib)
nosy: +docs@python, xiang.zhang
versions: +Python 3.8
___
Python tracker
<https://bugs.python.org/issu
Xiang Zhang added the comment:
> I don't think to make selector be a public property is a good idea. It will
> break the whole system integrity.
If exposing a private property is not a good idea, another choice may be
construct a selector with a customized I/O multiplexer
Xiang Zhang added the comment:
What about version 3.6?
--
nosy: +xiang.zhang
___
Python tracker
<https://bugs.python.org/issue35470>
___
___
Python-bugs-list m
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: behavior -> enhancement
___
Python tracker
<https://bugs.python
Xiang Zhang added the comment:
New changeset 4fb0b8bc25c52aae8dcb4353e69c1c88999a9a53 by Xiang Zhang in branch
'master':
bpo-33106: change dbm key deletion error for readonly file from KeyError to
dbm.error (#6295)
https://github.com/python/cpyt
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
New changeset aa39c1ab6de6d3fb0204741efdde9b7eed25b093 by Xiang Zhang
(Lysandros Nikolaou) in branch '2.7':
[2.7] bpo-32804: Include the context parameter in urlretrieve documentation
(GH-10203)
https://github.com/python/cpyt
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
New changeset b08746bfdf64e55ce33516f2065fa2aa4f51be95 by Xiang Zhang in branch
'master':
bpo-35062: Fix parsing _io.IncrementalNewlineDecoder's *translate* argument.
(GH-10217)
https://github.com/python/cpython/commit/b08746bfdf64e55ce33516f20
Change by Xiang Zhang :
--
keywords: +patch
pull_requests: +9534
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Xiang Zhang added the comment:
New changeset 163eca34c48f1b25e1504e37f4656773fd0fdc78 by Xiang Zhang in branch
'master':
bpo-34672: fix a compiler warning in timemodule.c (GH-10176)
https://github.com/python/cpython/commit/163eca34c48f1b25e1504e37f4656773fd0fdc78
-
Change by Xiang Zhang :
--
pull_requests: +9499
___
Python tracker
<https://bugs.python.org/issue34672>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Xiang Zhang :
io.IncrementalNewlineDecoder gets a *translate* bitwise struct field, but it
could be assigned arbitrary int value. This leads to inconsistent behaviour,
evens are evaluated to False and odds to True.
>>> io.IncrementalNewlineDecoder(encodi
Change by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<https://bugs.python.org/issue35056>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
Just find the same problem while investigating io.
--
nosy: +xiang.zhang
stage: patch review -> needs patch
versions: +Python 3.8
___
Python tracker
<https://bugs.python.org/issu
Xiang Zhang added the comment:
Thanks all. :-)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
New changeset 56a4a3aa555b3abc756cf837eddac4c0bf545db7 by Xiang Zhang in branch
'2.7':
[2.7] bpo-34748: link to :ref:`partial-objects` in functools.partial doc.
(GH-9809)
https://github.com/python/cpython/commit/56a4a3aa555b3abc756cf837eddac4
Change by Xiang Zhang :
--
pull_requests: +9386
___
Python tracker
<https://bugs.python.org/issue34748>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
New changeset 83a07652e0033f0d9994ae7634b91d6581c56b00 by Xiang Zhang (Andrei
Petre) in branch 'master':
bpo-34748: link to :ref:`partial-objects` in functools.partial doc. (GH-9809)
https://github.com/python/cpyt
Xiang Zhang added the comment:
I carefully read both the two PRs. The first one, easy to understand. The
second one, I spend some time to figure out why the test doesn't crash, why we
need to have reference count checks in two places and make some experiments to
test in different cases
Xiang Zhang added the comment:
I don't like the idea to display the contents in the repr, no matter entire or
clipped. I think it's not suitable and for contents, just read the object
manually. For me, a closed status plus the constructor arguments is a good
choice.
-
Change by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<https://bugs.python.org/issue34979>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
My PR https://github.com/python/cpython/pull/127 has tried to solve some
restrictions of the current netrc library. It's somewhat outdated since no
reviewer for a long time. As you can see there are also other libraries
suffering from the restric
Xiang Zhang added the comment:
I have catched using `is` to do string equality check in our codebase by
linters before. Not all my colleagues know what's not suitable here.
The only common and suitable case I can think of is programmers are exploring
CPython internals, like
Change by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<https://bugs.python.org/issue34763>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
It's not right to replace with statement by manually calling __enter__ and
__exit__. If there is any exception after __enter__ and before __exit__,
__exit__ method will be skipped. That's not wh
Change by Xiang Zhang :
--
nosy: +inada.naoki, pitrou
___
Python tracker
<https://bugs.python.org/issue34608>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Xiang Zhang :
--
type: crash -> behavior
___
Python tracker
<https://bugs.python.org/issue34505>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Xiang Zhang :
--
nosy: +davin, pitrou
___
Python tracker
<https://bugs.python.org/issue34563>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
It looks to me pure Python implementation could not handle such cases. Put
aside other possible bugs, threading.Condition.wait re-acquire the lock using
threading.Condition._acquire_restore which could be interrupted and not able to
acquire the lock. So it
Xiang Zhang added the comment:
I'm -1 on this change. I think the workaround is easy and direct.
--
___
Python tracker
<https://bugs.python.org/is
Change by Xiang Zhang :
--
resolution: -> duplicate
stage: needs patch -> resolved
status: open -> closed
superseder: -> itertools.tee not thread-safe; can segfault interpreter when
wrapped iterator releases GIL
___
Python tra
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
New changeset 3fe89dac42809a7741d50ebf595be98833b79b97 by Xiang Zhang (Louis
Sautier) in branch 'master':
bpo-34434: Update doc for bool(), float() and int() arguments (GH-8834)
https://github.com/python/cpython/commit/3fe89dac42809a7741d50ebf595be9
Xiang Zhang added the comment:
I could. But currently I don't have a good idea how to fix it elegantly. If
anyone else makes a PR, I'm willing to review it.
--
stage: -> needs patch
versions: +Python 3.8
___
Python tr
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
New changeset a2eefa67542c25617a58c03a27c17fd48e2a0856 by Xiang Zhang (Alexey
Izbyshev) in branch 'master':
bpo-34503: Fix refleak in PyErr_SetObject() (GH-8934)
https://github.com/python/cpython/commit/a2eefa67542c25617a58c03a27c17fd48e2a0856
-
Xiang Zhang added the comment:
I miss that. So this change seems to be user transparent and make more sense
then.
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue23
Xiang Zhang added the comment:
I'm afraid this could break old codes so not sure it's worth or not. I've seen
code like `SIGTERM = 15; signal.signal(SIGTERM, handler)`. I won't be surprised
to see a handcraft SIG_DFL/IGN.
--
nosy: +xiang.zhang
versions: +Py
Change by Xiang Zhang :
--
nosy: +rhettinger
___
Python tracker
<https://bugs.python.org/issue34497>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
Why not just bytes(buf[:4]) before passing?
--
nosy: +xiang.zhang
___
Python tracker
<https://bugs.python.org/issue34465>
___
___
Change by Xiang Zhang :
--
nosy: +vinay.sajip
___
Python tracker
<https://bugs.python.org/issue34334>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
So this is a dupliate of #34087 and we can close it?
--
nosy: +inada.naoki, xiang.zhang
___
Python tracker
<https://bugs.python.org/issue34
Change by Xiang Zhang :
--
nosy: +vstinner, xiang.zhang
___
Python tracker
<https://bugs.python.org/issue34486>
___
___
Python-bugs-list mailing list
Unsub
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Xiang Zhang :
New changeset 032e85f3fb6d2e6668d4e860b40525ed6cb8dd69 by Xiang Zhang (Zackery
Spytz) in branch '2.7':
bpo-34491: Add missing Py_DECREF() in _bsddb's DB_join() (GH-8909)
https://github.com/python/cpython/commit/032e85f3fb6d2e6668d4e860b
Xiang Zhang added the comment:
Ahh, the infinite iterator could also releases GIL in `PyIter_Next`.
--
___
Python tracker
<https://bugs.python.org/issue34
Xiang Zhang added the comment:
It seems to me the problem is tee objects might encounter race conditions while
`PyIter_Next` in `teedataobject_getitem` releases GIL. Other threads then
might get into the same branch since `tdo->numread` haven't been updated yet.
NULL slots are g
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
New changeset 95f9e14e33b713f35f5368acf7be56750bbdb5a8 by Xiang Zhang in branch
'2.7':
[2.7] bpo-30411: Use --git-dir instead of -C to make git work under version
below 1.8.5. (GH-8744) (GH-8838)
https://github.com/python/cpyt
Change by Xiang Zhang :
--
pull_requests: +8313
___
Python tracker
<https://bugs.python.org/issue30411>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
New changeset 4c8555773a801f957297132a92c0acb382d640e4 by Xiang Zhang in branch
'master':
bpo-30411: Use --git-dir instead of -C to make git work under version below
1.8.5. (GH-8744)
https://github.com/python/cpyt
Change by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<https://bugs.python.org/issue34410>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<https://bugs.python.org/issue30717>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Xiang Zhang :
--
keywords: +patch
pull_requests: +8227
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue30411>
___
___
Py
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
New changeset 2fc46979b8c802675ca7fd51c6f2108a305001c8 by Xiang Zhang (Sergey
Fedoseev) in branch 'master':
bpo-34151: Improve performance of some list operations (GH-8332)
https://github.com/python/cpython/commit/2fc46979b8c802675ca7fd51c6f210
Change by Xiang Zhang :
--
resolution: rejected -> not a bug
___
Python tracker
<https://bugs.python.org/issue34310>
___
___
Python-bugs-list mailing list
Un
Xiang Zhang added the comment:
I could not find the specific commit you mentioned on master branch. Maybe you
are on a customized branch(what is master-dirty)?
--
nosy: +xiang.zhang
___
Python tracker
<https://bugs.python.org/issue34
Xiang Zhang added the comment:
I'm +1 for INADA's change, but not more examples trying to distinguish every
detail difference.
--
___
Python tracker
<https://bugs.python.o
Xiang Zhang added the comment:
Why accessing the result outside of with block? The pool is terminated while
exiting the block before the work is done.
--
___
Python tracker
<https://bugs.python.org/issue34
Change by Xiang Zhang :
--
nosy: +davin, pitrou, xiang.zhang
___
Python tracker
<https://bugs.python.org/issue34140>
___
___
Python-bugs-list mailing list
Unsub
Xiang Zhang added the comment:
One thing worth a try here maybe turn `len` to `operator.length_hint`. But I am
not sure it's a good idea and just a mention here.
--
nosy: +xiang.zhang
versions: -Python 2.7, Python 3.4, Python 3.5, Python 3.6, Pytho
Change by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<https://bugs.python.org/issue34132>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Xiang Zhang :
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue34084>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Xiang Zhang :
--
title: possible free statically allocated string -> possible free statically
allocated string in compiler when easter egg on
___
Python tracker
<https://bugs.python.org/issu
New submission from Xiang Zhang :
While reviewing PR8222, I found `err_ret->text` is assigned a not malloced
string, but it will finally get freed in `err_input`.
--
keywords: easy
messages: 321381
nosy: serhiy.storchaka, xiang.zhang
priority: normal
severity: normal
status: o
Change by Xiang Zhang :
--
nosy: +davin, pitrou, xiang.zhang
___
Python tracker
<https://bugs.python.org/issue30256>
___
___
Python-bugs-list mailing list
Unsub
Change by Xiang Zhang :
--
nosy: +vinay.sajip
___
Python tracker
<https://bugs.python.org/issue33978>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
> Note: the doc doesn't say that the function must only be called once, nor
> document the (current) new Python 3.7 restriction (must only be called once):
But the doc says:
This is a no-op when called for a second time (without calling
Py
Change by Xiang Zhang :
--
nosy: +christian.heimes
___
Python tracker
<https://bugs.python.org/issue33936>
___
___
Python-bugs-list mailing list
Unsubscribe:
1 - 100 of 1629 matches
Mail list logo