[issue29759] Deadlock in multiprocessing.pool.Pool on terminate

2017-03-08 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +davin versions: -Python 3.3, Python 3.4 ___ Python tracker <http://bugs.python.org/issue29759> ___ ___ Python-bugs-list mailin

[issue29756] Improve documentation for list methods that compare items by equality

2017-03-08 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +468 ___ Python tracker <http://bugs.python.org/issue29756> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29756] Improve documentation for list methods that compare items by equality

2017-03-08 Thread Xiang Zhang
Xiang Zhang added the comment: +1 for jsoh. Actually the behaviour is documented in https://docs.python.org/3/reference/expressions.html#value-comparisons. So a single 'a is b' or 'a == b' is not complete. I would like to use 'equal to' which implies '

[issue29758] Previously-working SWIG code fails in Python 3.6

2017-03-08 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +haypo, serhiy.storchaka ___ Python tracker <http://bugs.python.org/issue29758> ___ ___ Python-bugs-list mailing list Unsub

[issue29619] st_ino (unsigned long long) is casted to long long in posixmodule.c:_pystat_fromstructstat

2017-03-07 Thread Xiang Zhang
Xiang Zhang added the comment: Any reason our _Py_stat_struct on Windows uses a signed type to represent st_ino? -- nosy: +eryksun, steve.dower ___ Python tracker <http://bugs.python.org/issue29

[issue29568] undefined parsing behavior with the old style string formatting

2017-03-07 Thread Xiang Zhang
Changes by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue26915] Test identity first in membership operation of ItemsView, ValuesView and Sequence in collections.abc

2017-03-07 Thread Xiang Zhang
Changes by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue24329] __qualname__ and __slots__

2017-03-07 Thread Xiang Zhang
Changes by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue26915] Test identity first in membership operation of ItemsView, ValuesView and Sequence in collections.abc

2017-03-07 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +454 ___ Python tracker <http://bugs.python.org/issue26915> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28856] %b format for bytes does not support objects that follow the buffer protocol

2017-03-07 Thread Xiang Zhang
Xiang Zhang added the comment: Isn't this a discussed behaviour that is explicitly documented in PEP 461? -- ___ Python tracker <http://bugs.python.org/is

[issue28856] %b format for bytes does not support objects that follow the buffer protocol

2017-03-07 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +449 ___ Python tracker <http://bugs.python.org/issue28856> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28856] %b format for bytes does not support objects that follow the buffer protocol

2017-03-07 Thread Xiang Zhang
Changes by Xiang Zhang : -- components: +Interpreter Core stage: test needed -> patch review versions: +Python 3.5, Python 3.6, Python 3.7 ___ Python tracker <http://bugs.python.org/issu

[issue28728] test_host_resolution in test_socket fails

2017-03-06 Thread Xiang Zhang
Changes by Xiang Zhang : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue28728> ___

[issue29744] memmap behavior changed

2017-03-06 Thread Xiang Zhang
Changes by Xiang Zhang : -- stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue29744> ___ ___ Python-bugs-list

[issue29739] zipfile raises wrong exception for some incorrect passwords

2017-03-06 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +serhiy.storchaka ___ Python tracker <http://bugs.python.org/issue29739> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28728] test_host_resolution in test_socket fails

2017-03-06 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +440 ___ Python tracker <http://bugs.python.org/issue28728> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27577] Make implementation and doc of tuple and list more compliant

2017-03-06 Thread Xiang Zhang
Changes by Xiang Zhang : -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue27577> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue27577] Make implementation and doc of tuple and list more compliant

2017-03-06 Thread Xiang Zhang
Xiang Zhang added the comment: This issue doesn't make any sense once #29695 is applied. So close. -- resolution: -> fixed stage: -> resolved ___ Python tracker <http://bugs.python.

[issue29700] readline memory corruption when sys.stdin fd >= FD_SETSIZE for select()

2017-03-06 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +xiang.zhang ___ Python tracker <http://bugs.python.org/issue29700> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29714] can't interpolate byte string with \x00 before replacement identifier

2017-03-06 Thread Xiang Zhang
Xiang Zhang added the comment: I think no. String is not affected now and its code uses related macros so I don't think it could suffer possible regression. -- ___ Python tracker <http://bugs.python.org/is

[issue29714] can't interpolate byte string with \x00 before replacement identifier

2017-03-06 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks for the report, Nick! -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue29714] can't interpolate byte string with \x00 before replacement identifier

2017-03-06 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +412 ___ Python tracker <http://bugs.python.org/issue29714> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26915] Test identity first in membership operation of ItemsView, ValuesView and Sequence in collections.abc

2017-03-06 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +411 ___ Python tracker <http://bugs.python.org/issue26915> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29714] can't interpolate byte string with \x00 before replacement identifier

2017-03-05 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +407 ___ Python tracker <http://bugs.python.org/issue29714> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29714] can't interpolate byte string with \x00 before replacement identifier

2017-03-05 Thread Xiang Zhang
Xiang Zhang added the comment: The problem is now _PyBytes_FormatEx uses strchr to sniff %. It should use memchr instead. -- assignee: -> xiang.zhang nosy: +xiang.zhang ___ Python tracker <http://bugs.python.org/issu

[issue29657] os.symlink: FileExistsError shows wrong message

2017-03-05 Thread Xiang Zhang
Xiang Zhang added the comment: I agree with Eryk. The error message is misleading. When I see it, I take it as source -> destination. I think we should make the error message clearer, or document it in the OSError documentation. -- ___ Pyt

[issue24329] __qualname__ and __slots__

2017-03-05 Thread Xiang Zhang
Xiang Zhang added the comment: PR made. :-) -- ___ Python tracker <http://bugs.python.org/issue24329> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24329] __qualname__ and __slots__

2017-03-05 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +405 ___ Python tracker <http://bugs.python.org/issue24329> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28728] test_host_resolution in test_socket fails

2017-03-02 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +343 ___ Python tracker <http://bugs.python.org/issue28728> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26867] test_ssl test_options fails on ubuntu 16.04

2017-02-28 Thread Xiang Zhang
Changes by Xiang Zhang : -- resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 2.7 ___ Python tracker <http://bugs.python.or

[issue26867] test_ssl test_options fails on ubuntu 16.04

2017-02-28 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +311 ___ Python tracker <http://bugs.python.org/issue26867> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-02-28 Thread Xiang Zhang
Changes by Xiang Zhang : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-02-28 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +310 ___ Python tracker <http://bugs.python.org/issue28598> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29676] verbose output of test_cprofile

2017-02-28 Thread Xiang Zhang
New submission from Xiang Zhang: Recently when I run the test suite test_cprofile always produces some verbose info but won't fail. This is not the case before. I am not sure this is a bug or not. git bisect tells me https://github.com/python/cpython/c

[issue7769] SimpleXMLRPCServer.SimpleXMLRPCServer.register_function as decorator

2017-02-28 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks everyone involved! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.o

[issue7769] SimpleXMLRPCServer.SimpleXMLRPCServer.register_function as decorator

2017-02-27 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks Raymond. I would like to keep the example style another issue, not this one. :-) And I hope someone is willing to review the PR. -- assignee: -> xiang.zhang stage: needs patch -> patch review versions: +Python 3.7 -Pyth

[issue29661] Typo in the docstring of timeit.Timer.autorange

2017-02-27 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks Raymond! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue29661] Typo in the docstring of timeit.Timer.autorange

2017-02-27 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +302 ___ Python tracker <http://bugs.python.org/issue29661> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29661] Typo in the docstring of timeit.Timer.autorange

2017-02-27 Thread Xiang Zhang
Xiang Zhang added the comment: Of course that is okay. I didn't do what you propose since I thought it's somewhat superfluous, what is returned is mentioned below. I choose 'calculate' when I see 'Automatically determine how many times to call timeit

[issue29662] Fix wrong indentation of timeit.Timer's documenation

2017-02-26 Thread Xiang Zhang
Changes by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue29662] Fix wrong indentation of timeit.Timer's documenation

2017-02-26 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +293 ___ Python tracker <http://bugs.python.org/issue29662> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29662] Fix wrong indentation of timeit.Timer's documenation

2017-02-26 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +292 ___ Python tracker <http://bugs.python.org/issue29662> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29662] Fix wrong indentation of timeit.Timer's documenation

2017-02-26 Thread Xiang Zhang
Changes by Xiang Zhang : -- versions: +Python 3.6, Python 3.7 ___ Python tracker <http://bugs.python.org/issue29662> ___ ___ Python-bugs-list mailing list Unsub

[issue29662] Fix wrong indentation of timeit.Timer's documenation

2017-02-26 Thread Xiang Zhang
Changes by Xiang Zhang : -- assignee: xiang.zhang components: Documentation nosy: xiang.zhang priority: normal severity: normal stage: patch review status: open title: Fix wrong indentation of timeit.Timer's documenation ___ Python tracker

[issue29661] Typo in the docstring of timeit.Timer.autorange

2017-02-26 Thread Xiang Zhang
Changes by Xiang Zhang : -- assignee: -> xiang.zhang nosy: +xiang.zhang stage: -> patch review versions: +Python 3.7 ___ Python tracker <http://bugs.python.org/i

[issue29661] Typo in the docstring of timeit.Timer.autorange

2017-02-26 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +291 ___ Python tracker <http://bugs.python.org/issue29661> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29376] threading._DummyThread.__repr__ raises AssertionError

2017-02-26 Thread Xiang Zhang
Changes by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue29376] threading._DummyThread.__repr__ raises AssertionError

2017-02-26 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +289 ___ Python tracker <http://bugs.python.org/issue29376> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29376] threading._DummyThread.__repr__ raises AssertionError

2017-02-26 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +290 ___ Python tracker <http://bugs.python.org/issue29376> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29652] Fix evaluation order of keys/values in dict comprehensions

2017-02-26 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +xiang.zhang ___ Python tracker <http://bugs.python.org/issue29652> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29657] os.symlink: FileExistsError shows wrong message

2017-02-26 Thread Xiang Zhang
Xiang Zhang added the comment: I concur the current message is misleading. OSError makes the string "file1 -> file2". This also affects other methods calling `path_error2()` such as os.link(). -- nosy: +xiang.zhang versions: +Python 3.

[issue29650] abstractmethod does not work when deriving from Exception

2017-02-25 Thread Xiang Zhang
Xiang Zhang added the comment: Yes. This is the case for builtin types which usually get their own __new__ methods. See #5996. -- dependencies: +abstract class instantiable when subclassing dict nosy: +xiang.zhang versions: +Python 3.5, Python 3.7

[issue29549] Improve docstring for str.index

2017-02-22 Thread Xiang Zhang
Xiang Zhang added the comment: Lisa, could you make a PR? It could let more developers see your patch. -- nosy: +xiang.zhang stage: needs patch -> patch review ___ Python tracker <http://bugs.python.org/issu

[issue29553] Argparser does not display closing parentheses in nested mutex groups

2017-02-22 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +paul.j3 ___ Python tracker <http://bugs.python.org/issue29553> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29619] st_ino (unsigned long long) is casted to long long in posixmodule.c:_pystat_fromstructstat

2017-02-22 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +xiang.zhang versions: -Python 3.3, Python 3.4 ___ Python tracker <http://bugs.python.org/issue29619> ___ ___ Python-bugs-list m

[issue29376] threading._DummyThread.__repr__ raises AssertionError

2017-02-22 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +197 ___ Python tracker <http://bugs.python.org/issue29376> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10938] Provide links to system specific strftime/ptime docs

2017-02-22 Thread Xiang Zhang
Xiang Zhang added the comment: I agree with Berker and Jim here. I think the current doc is clear enough so mark this as rejected. :-( -- nosy: +xiang.zhang resolution: -> rejected stage: patch review -> resolved status: open -> closed _

[issue28624] Make the `cwd` argument to `subprocess.Popen` accept a `PathLike`

2017-02-21 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +xiang.zhang ___ Python tracker <http://bugs.python.org/issue28624> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29589] test_asyncio & test_multiprocessing_forkserver failed

2017-02-21 Thread Xiang Zhang
Xiang Zhang added the comment: Hmm, it seems not Python's fault. I can't reproduce the failure either. So I am going to close this issue. -- resolution: -> works for me stage: test needed -> resolved status: open -> closed ___ Py

[issue7769] SimpleXMLRPCServer.SimpleXMLRPCServer.register_function as decorator

2017-02-21 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +194 ___ Python tracker <http://bugs.python.org/issue7769> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27660] Replace size_t with Py_ssize_t as the type of local variable in list_resize

2017-02-21 Thread Xiang Zhang
Xiang Zhang added the comment: New changeset 4cee049f5b6864066b8315e9b54de955e5487dfc by GitHub in branch 'master': bpo-27660: remove unnecessary overflow checks in list_resize (GH-189) https://github.com/python/cpython/commit/4cee049f5b6864066b8315e9b54de9

[issue27660] Replace size_t with Py_ssize_t as the type of local variable in list_resize

2017-02-21 Thread Xiang Zhang
Changes by Xiang Zhang : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue29347] Python could crash while creating weakref for a given object

2017-02-20 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks for your confirmation Saida! :-) -- ___ Python tracker <http://bugs.python.org/issue29347> ___ ___ Python-bugs-list mailin

[issue27660] Replace size_t with Py_ssize_t as the type of local variable in list_resize

2017-02-20 Thread Xiang Zhang
Xiang Zhang added the comment: Sorry, I have the commit bit and know what to do with a commit. So I assign it to myself and wait someone approve the PR on GitHub. -- assignee: Mariatta -> xiang.zhang stage: patch review -> commit review ___

[issue27660] Replace size_t with Py_ssize_t as the type of local variable in list_resize

2017-02-20 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks for your time Raymond. :-) I applied your suggestions in the PR. -- ___ Python tracker <http://bugs.python.org/issue27

[issue29602] complex() on object with __complex__ function loses sign of zero imaginary part

2017-02-20 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +mark.dickinson ___ Python tracker <http://bugs.python.org/issue29602> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29596] Unfinished sentense in howto/clinic.rst

2017-02-20 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +larry stage: -> needs patch ___ Python tracker <http://bugs.python.org/issue29596> ___ ___ Python-bugs-list mailing list Un

[issue29595] Expose max_queue_size in ThreadPoolExecutor

2017-02-20 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +xiang.zhang ___ Python tracker <http://bugs.python.org/issue29595> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29589] test_asyncio & test_multiprocessing_forkserver failed

2017-02-20 Thread Xiang Zhang
Xiang Zhang added the comment: Hi Dima, can you stably reproduce the failures? Or try with the latest 3.6 code? -- nosy: +xiang.zhang stage: -> test needed ___ Python tracker <http://bugs.python.org/issu

[issue27660] Replace size_t with Py_ssize_t as the type of local variable in list_resize

2017-02-19 Thread Xiang Zhang
Xiang Zhang added the comment: I opened a PR on GitHub for this issue. Hope Raymond you could review it some time. -- versions: +Python 3.7 -Python 3.6 ___ Python tracker <http://bugs.python.org/issue27

[issue27660] Replace size_t with Py_ssize_t as the type of local variable in list_resize

2017-02-19 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +155 ___ Python tracker <http://bugs.python.org/issue27660> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29347] Python could crash while creating weakref for a given object

2017-02-19 Thread Xiang Zhang
Xiang Zhang added the comment: Although no feedback from Saida, but IMHO the problem is solved so I close it now. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue29347] Python could crash while creating weakref for a given object

2017-02-19 Thread Xiang Zhang
Xiang Zhang added the comment: New changeset 9a4577a4bb23888fed2cf192cf1a4c95ce5c26f8 by GitHub in branch '3.6': bpo-29347: Fix possibly dereferencing undefined pointers when creating weakref objects (#128) (#186) https://github.com/python/cpyt

[issue29347] Python could crash while creating weakref for a given object

2017-02-19 Thread Xiang Zhang
Xiang Zhang added the comment: New changeset 7c95a94c3ab41e4296e94335d66b2400ad16f052 by GitHub in branch '3.5': bpo-29347: Fix possibly dereferencing undefined pointers when creating weakref objects (#128) (#188) https://github.com/python/cpyt

[issue29347] Python could crash while creating weakref for a given object

2017-02-19 Thread Xiang Zhang
Xiang Zhang added the comment: New changeset 7131a73f9655cfd325c798385905326f57b94640 by GitHub in branch '2.7': bpo-29347: Fix possibly dereferencing undefined pointers when creating weakref objects (#128) (#187) https://github.com/python/cpyt

[issue29562] test_getgroups of test_posix fails (on OS X 10.10)

2017-02-19 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +ned.deily, ronaldoussoren ___ Python tracker <http://bugs.python.org/issue29562> ___ ___ Python-bugs-list mailing list Unsub

[issue29347] Python could crash while creating weakref for a given object

2017-02-19 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +154 ___ Python tracker <http://bugs.python.org/issue29347> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29347] Python could crash while creating weakref for a given object

2017-02-19 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +153 ___ Python tracker <http://bugs.python.org/issue29347> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29347] Python could crash while creating weakref for a given object

2017-02-19 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +152 ___ Python tracker <http://bugs.python.org/issue29347> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29347] Python could crash while creating weakref for a given object

2017-02-19 Thread Xiang Zhang
Xiang Zhang added the comment: New changeset d0e8212ed70445cc3d48b0d4ae7c9cb480004010 by GitHub in branch 'master': bpo-29347: Fix possibly dereferencing undefined pointers when creating weakref objects (#128) https://github.com/python/cpython/commit/d0e8212ed70445cc3d48b0d4ae7c9c

[issue29559] Detect mouse over lines on canvas while mouse button is down

2017-02-19 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +gpolo, serhiy.storchaka ___ Python tracker <http://bugs.python.org/issue29559> ___ ___ Python-bugs-list mailing list Unsub

[issue29347] Python could crash while creating weakref for a given object

2017-02-15 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +90 ___ Python tracker <http://bugs.python.org/issue29347> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29347] Python could crash while creating weakref for a given object

2017-02-15 Thread Xiang Zhang
Xiang Zhang added the comment: Ping. -- ___ Python tracker <http://bugs.python.org/issue29347> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28806] Improve the netrc library

2017-02-15 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +89 ___ Python tracker <http://bugs.python.org/issue28806> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29568] undefined parsing behavior with the old style string formatting

2017-02-15 Thread Xiang Zhang
Xiang Zhang added the comment: Or even not fix it in develop branch. -- ___ Python tracker <http://bugs.python.org/issue29568> ___ ___ Python-bugs-list mailin

[issue29568] undefined parsing behavior with the old style string formatting

2017-02-15 Thread Xiang Zhang
Xiang Zhang added the comment: The documentation[1] explicitly states using % to do string format could be error-prone and recommends using str.format(). So +1 on no change in maintenance branches. [1] https://docs.python.org/3/library/stdtypes.html#printf-style-string-formatting

[issue29536] test_hashlib failure on Ubuntu 16.04

2017-02-14 Thread Xiang Zhang
Xiang Zhang added the comment: I am using 16.10 but I can't reproduce the failures. Sachin can you reliably reproduce the failures? And one thing interesting is that all the failed test cases need the network source to be enabled but your command doesn't do that, it's better

[issue29513] os.scandir(str) reference leak (test_os refleak)

2017-02-09 Thread Xiang Zhang
Xiang Zhang added the comment: > If PyObject_New(ScandirIterator, &ScandirIteratorType) fails the path should > be cleaned up by Argument Clinic. Ohh yes. My stupid. Then both LGTM. -- stage: patch review -> commit review ___ Python t

[issue29513] os.scandir(str) reference leak (test_os refleak)

2017-02-09 Thread Xiang Zhang
Xiang Zhang added the comment: 3.6 LGTM. 3.7 is technically right to me. But it looks to me AC shouldn't call path_cleanup in .c.h. It always do nothing. -- ___ Python tracker <http://bugs.python.org/is

[issue29438] use after free in key sharing dict

2017-02-07 Thread Xiang Zhang
Xiang Zhang added the comment: I left one review about the comment on Rietvied last patch. :-) -- ___ Python tracker <http://bugs.python.org/issue29438> ___ ___

[issue29438] use after free in key sharing dict

2017-02-07 Thread Xiang Zhang
Xiang Zhang added the comment: > if (was_shared && (cached = CACHED_KEYS(tp)) != NULL && cached != > ((PyDictObject *)dict)->ma_keys) +1 on this and I think the deletion should also use if ((cached = CACHED_KEYS(tp) != NULL) -- _

[issue29466] pickle does not serialize Exception __cause__ field

2017-02-06 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +serhiy.storchaka ___ Python tracker <http://bugs.python.org/issue29466> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29458] random.seed version=1 behavior

2017-02-05 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +haypo, mark.dickinson, rhettinger ___ Python tracker <http://bugs.python.org/issue29458> ___ ___ Python-bugs-list mailin

[issue29457] strftime('%x') does not use my locale

2017-02-05 Thread Xiang Zhang
Xiang Zhang added the comment: I doubt the info belongs to datetime module documentation. When you encounter locale related problems maybe it's better for you to refer locale module documentation, and it mentions this behaviour https://docs.python.org/3/library/locale.html#background-de

[issue29456] bug in unicodedata.normalize: u1176

2017-02-05 Thread Xiang Zhang
Xiang Zhang added the comment: How about the third character's range? The code seems assuming it's [11a7..11c3] while the spec is [11a8..11c2]? >>> unicodedata.normalize("NFC", "\u1100\u1175\u11a7") '기' while

[issue29405] improve csv.Sniffer().sniff() behavior

2017-02-05 Thread Xiang Zhang
Xiang Zhang added the comment: I am fine with any version (both are simple and not the hardest part to understand in the logic). :-) I have no opinion on which is better. -- ___ Python tracker <http://bugs.python.org/issue29

[issue29405] improve csv.Sniffer().sniff() behavior

2017-02-05 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks Milt. I committed with my change not because it's better, but I want to make the change small so others won't get unfamiliar with the new code. :-) -- resolution: -> fixed stage: commit review -> resolved status

[issue29454] Shutting down consumer on a remote queue

2017-02-05 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +davin type: -> behavior ___ Python tracker <http://bugs.python.org/issue29454> ___ ___ Python-bugs-list mailing list Un

[issue29453] Remove reference to undefined dictionary ordering in Tutorial

2017-02-05 Thread Xiang Zhang
Changes by Xiang Zhang : -- assignee: docs@python -> serhiy.storchaka ___ Python tracker <http://bugs.python.org/issue29453> ___ ___ Python-bugs-list mai

[issue29453] Remove reference to undefined dictionary ordering in Tutorial

2017-02-05 Thread Xiang Zhang
Xiang Zhang added the comment: David, actually I have the same thoughts as Jim. Ordered ordinary dicts is not a feature but ordered **kwargs is in 3.6. They seems not the same thing. -- ___ Python tracker <http://bugs.python.org/issue29

<    2   3   4   5   6   7   8   9   10   11   >