Changes by Xiang Zhang :
--
nosy: +davin
versions: -Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.org/issue29759>
___
___
Python-bugs-list mailin
Changes by Xiang Zhang :
--
pull_requests: +468
___
Python tracker
<http://bugs.python.org/issue29756>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
+1 for jsoh. Actually the behaviour is documented in
https://docs.python.org/3/reference/expressions.html#value-comparisons.
So a single 'a is b' or 'a == b' is not complete. I would like to use 'equal
to' which implies '
Changes by Xiang Zhang :
--
nosy: +haypo, serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue29758>
___
___
Python-bugs-list mailing list
Unsub
Xiang Zhang added the comment:
Any reason our _Py_stat_struct on Windows uses a signed type to represent
st_ino?
--
nosy: +eryksun, steve.dower
___
Python tracker
<http://bugs.python.org/issue29
Changes by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Xiang Zhang :
--
pull_requests: +454
___
Python tracker
<http://bugs.python.org/issue26915>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
Isn't this a discussed behaviour that is explicitly documented in PEP 461?
--
___
Python tracker
<http://bugs.python.org/is
Changes by Xiang Zhang :
--
pull_requests: +449
___
Python tracker
<http://bugs.python.org/issue28856>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
components: +Interpreter Core
stage: test needed -> patch review
versions: +Python 3.5, Python 3.6, Python 3.7
___
Python tracker
<http://bugs.python.org/issu
Changes by Xiang Zhang :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28728>
___
Changes by Xiang Zhang :
--
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue29744>
___
___
Python-bugs-list
Changes by Xiang Zhang :
--
nosy: +serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue29739>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
pull_requests: +440
___
Python tracker
<http://bugs.python.org/issue28728>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue27577>
___
___
Python-bugs-list mailing list
Unsubscrib
Xiang Zhang added the comment:
This issue doesn't make any sense once #29695 is applied. So close.
--
resolution: -> fixed
stage: -> resolved
___
Python tracker
<http://bugs.python.
Changes by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<http://bugs.python.org/issue29700>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
I think no. String is not affected now and its code uses related macros so I
don't think it could suffer possible regression.
--
___
Python tracker
<http://bugs.python.org/is
Xiang Zhang added the comment:
Thanks for the report, Nick!
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Xiang Zhang :
--
pull_requests: +412
___
Python tracker
<http://bugs.python.org/issue29714>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
pull_requests: +411
___
Python tracker
<http://bugs.python.org/issue26915>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
pull_requests: +407
___
Python tracker
<http://bugs.python.org/issue29714>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
The problem is now _PyBytes_FormatEx uses strchr to sniff %. It should use
memchr instead.
--
assignee: -> xiang.zhang
nosy: +xiang.zhang
___
Python tracker
<http://bugs.python.org/issu
Xiang Zhang added the comment:
I agree with Eryk. The error message is misleading. When I see it, I take it as
source -> destination. I think we should make the error message clearer, or
document it in the OSError documentation.
--
___
Pyt
Xiang Zhang added the comment:
PR made. :-)
--
___
Python tracker
<http://bugs.python.org/issue24329>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
pull_requests: +405
___
Python tracker
<http://bugs.python.org/issue24329>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
pull_requests: +343
___
Python tracker
<http://bugs.python.org/issue28728>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 2.7
___
Python tracker
<http://bugs.python.or
Changes by Xiang Zhang :
--
pull_requests: +311
___
Python tracker
<http://bugs.python.org/issue26867>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Xiang Zhang :
--
pull_requests: +310
___
Python tracker
<http://bugs.python.org/issue28598>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Xiang Zhang:
Recently when I run the test suite test_cprofile always produces some verbose
info but won't fail. This is not the case before. I am not sure this is a bug
or not. git bisect tells me
https://github.com/python/cpython/c
Xiang Zhang added the comment:
Thanks everyone involved!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.o
Xiang Zhang added the comment:
Thanks Raymond. I would like to keep the example style another issue, not this
one. :-) And I hope someone is willing to review the PR.
--
assignee: -> xiang.zhang
stage: needs patch -> patch review
versions: +Python 3.7 -Pyth
Xiang Zhang added the comment:
Thanks Raymond!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Xiang Zhang :
--
pull_requests: +302
___
Python tracker
<http://bugs.python.org/issue29661>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
Of course that is okay. I didn't do what you propose since I thought it's
somewhat superfluous, what is returned is mentioned below. I choose 'calculate'
when I see 'Automatically determine how many times to call timeit
Changes by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Xiang Zhang :
--
pull_requests: +293
___
Python tracker
<http://bugs.python.org/issue29662>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
pull_requests: +292
___
Python tracker
<http://bugs.python.org/issue29662>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
versions: +Python 3.6, Python 3.7
___
Python tracker
<http://bugs.python.org/issue29662>
___
___
Python-bugs-list mailing list
Unsub
Changes by Xiang Zhang :
--
assignee: xiang.zhang
components: Documentation
nosy: xiang.zhang
priority: normal
severity: normal
stage: patch review
status: open
title: Fix wrong indentation of timeit.Timer's documenation
___
Python tracker
Changes by Xiang Zhang :
--
assignee: -> xiang.zhang
nosy: +xiang.zhang
stage: -> patch review
versions: +Python 3.7
___
Python tracker
<http://bugs.python.org/i
Changes by Xiang Zhang :
--
pull_requests: +291
___
Python tracker
<http://bugs.python.org/issue29661>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Xiang Zhang :
--
pull_requests: +289
___
Python tracker
<http://bugs.python.org/issue29376>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
pull_requests: +290
___
Python tracker
<http://bugs.python.org/issue29376>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<http://bugs.python.org/issue29652>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
I concur the current message is misleading.
OSError makes the string "file1 -> file2". This also affects other methods
calling `path_error2()` such as os.link().
--
nosy: +xiang.zhang
versions: +Python 3.
Xiang Zhang added the comment:
Yes. This is the case for builtin types which usually get their own __new__
methods. See #5996.
--
dependencies: +abstract class instantiable when subclassing dict
nosy: +xiang.zhang
versions: +Python 3.5, Python 3.7
Xiang Zhang added the comment:
Lisa, could you make a PR? It could let more developers see your patch.
--
nosy: +xiang.zhang
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issu
Changes by Xiang Zhang :
--
nosy: +paul.j3
___
Python tracker
<http://bugs.python.org/issue29553>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
nosy: +xiang.zhang
versions: -Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.org/issue29619>
___
___
Python-bugs-list m
Changes by Xiang Zhang :
--
pull_requests: +197
___
Python tracker
<http://bugs.python.org/issue29376>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
I agree with Berker and Jim here. I think the current doc is clear enough so
mark this as rejected. :-(
--
nosy: +xiang.zhang
resolution: -> rejected
stage: patch review -> resolved
status: open -> closed
_
Changes by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<http://bugs.python.org/issue28624>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
Hmm, it seems not Python's fault. I can't reproduce the failure either. So I am
going to close this issue.
--
resolution: -> works for me
stage: test needed -> resolved
status: open -> closed
___
Py
Changes by Xiang Zhang :
--
pull_requests: +194
___
Python tracker
<http://bugs.python.org/issue7769>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
New changeset 4cee049f5b6864066b8315e9b54de955e5487dfc by GitHub in branch
'master':
bpo-27660: remove unnecessary overflow checks in list_resize (GH-189)
https://github.com/python/cpython/commit/4cee049f5b6864066b8315e9b54de9
Changes by Xiang Zhang :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Xiang Zhang added the comment:
Thanks for your confirmation Saida! :-)
--
___
Python tracker
<http://bugs.python.org/issue29347>
___
___
Python-bugs-list mailin
Xiang Zhang added the comment:
Sorry, I have the commit bit and know what to do with a commit. So I assign it
to myself and wait someone approve the PR on GitHub.
--
assignee: Mariatta -> xiang.zhang
stage: patch review -> commit review
___
Xiang Zhang added the comment:
Thanks for your time Raymond. :-) I applied your suggestions in the PR.
--
___
Python tracker
<http://bugs.python.org/issue27
Changes by Xiang Zhang :
--
nosy: +mark.dickinson
___
Python tracker
<http://bugs.python.org/issue29602>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
nosy: +larry
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue29596>
___
___
Python-bugs-list mailing list
Un
Changes by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<http://bugs.python.org/issue29595>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
Hi Dima, can you stably reproduce the failures? Or try with the latest 3.6 code?
--
nosy: +xiang.zhang
stage: -> test needed
___
Python tracker
<http://bugs.python.org/issu
Xiang Zhang added the comment:
I opened a PR on GitHub for this issue. Hope Raymond you could review it some
time.
--
versions: +Python 3.7 -Python 3.6
___
Python tracker
<http://bugs.python.org/issue27
Changes by Xiang Zhang :
--
pull_requests: +155
___
Python tracker
<http://bugs.python.org/issue27660>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
Although no feedback from Saida, but IMHO the problem is solved so I close it
now.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Xiang Zhang added the comment:
New changeset 9a4577a4bb23888fed2cf192cf1a4c95ce5c26f8 by GitHub in branch
'3.6':
bpo-29347: Fix possibly dereferencing undefined pointers when creating weakref
objects (#128) (#186)
https://github.com/python/cpyt
Xiang Zhang added the comment:
New changeset 7c95a94c3ab41e4296e94335d66b2400ad16f052 by GitHub in branch
'3.5':
bpo-29347: Fix possibly dereferencing undefined pointers when creating weakref
objects (#128) (#188)
https://github.com/python/cpyt
Xiang Zhang added the comment:
New changeset 7131a73f9655cfd325c798385905326f57b94640 by GitHub in branch
'2.7':
bpo-29347: Fix possibly dereferencing undefined pointers when creating weakref
objects (#128) (#187)
https://github.com/python/cpyt
Changes by Xiang Zhang :
--
nosy: +ned.deily, ronaldoussoren
___
Python tracker
<http://bugs.python.org/issue29562>
___
___
Python-bugs-list mailing list
Unsub
Changes by Xiang Zhang :
--
pull_requests: +154
___
Python tracker
<http://bugs.python.org/issue29347>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
pull_requests: +153
___
Python tracker
<http://bugs.python.org/issue29347>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
pull_requests: +152
___
Python tracker
<http://bugs.python.org/issue29347>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
New changeset d0e8212ed70445cc3d48b0d4ae7c9cb480004010 by GitHub in branch
'master':
bpo-29347: Fix possibly dereferencing undefined pointers when creating weakref
objects (#128)
https://github.com/python/cpython/commit/d0e8212ed70445cc3d48b0d4ae7c9c
Changes by Xiang Zhang :
--
nosy: +gpolo, serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue29559>
___
___
Python-bugs-list mailing list
Unsub
Changes by Xiang Zhang :
--
pull_requests: +90
___
Python tracker
<http://bugs.python.org/issue29347>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
Ping.
--
___
Python tracker
<http://bugs.python.org/issue29347>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
pull_requests: +89
___
Python tracker
<http://bugs.python.org/issue28806>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
Or even not fix it in develop branch.
--
___
Python tracker
<http://bugs.python.org/issue29568>
___
___
Python-bugs-list mailin
Xiang Zhang added the comment:
The documentation[1] explicitly states using % to do string format could be
error-prone and recommends using str.format(). So +1 on no change in
maintenance branches.
[1]
https://docs.python.org/3/library/stdtypes.html#printf-style-string-formatting
Xiang Zhang added the comment:
I am using 16.10 but I can't reproduce the failures. Sachin can you reliably
reproduce the failures? And one thing interesting is that all the failed test
cases need the network source to be enabled but your command doesn't do that,
it's better
Xiang Zhang added the comment:
> If PyObject_New(ScandirIterator, &ScandirIteratorType) fails the path should
> be cleaned up by Argument Clinic.
Ohh yes. My stupid. Then both LGTM.
--
stage: patch review -> commit review
___
Python t
Xiang Zhang added the comment:
3.6 LGTM. 3.7 is technically right to me. But it looks to me AC shouldn't call
path_cleanup in .c.h. It always do nothing.
--
___
Python tracker
<http://bugs.python.org/is
Xiang Zhang added the comment:
I left one review about the comment on Rietvied last patch. :-)
--
___
Python tracker
<http://bugs.python.org/issue29438>
___
___
Xiang Zhang added the comment:
> if (was_shared && (cached = CACHED_KEYS(tp)) != NULL && cached !=
> ((PyDictObject *)dict)->ma_keys)
+1 on this and I think the deletion should also use
if ((cached = CACHED_KEYS(tp) != NULL)
--
_
Changes by Xiang Zhang :
--
nosy: +serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue29466>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
nosy: +haypo, mark.dickinson, rhettinger
___
Python tracker
<http://bugs.python.org/issue29458>
___
___
Python-bugs-list mailin
Xiang Zhang added the comment:
I doubt the info belongs to datetime module documentation. When you encounter
locale related problems maybe it's better for you to refer locale module
documentation, and it mentions this behaviour
https://docs.python.org/3/library/locale.html#background-de
Xiang Zhang added the comment:
How about the third character's range? The code seems assuming it's
[11a7..11c3] while the spec is [11a8..11c2]?
>>> unicodedata.normalize("NFC", "\u1100\u1175\u11a7")
'기'
while
Xiang Zhang added the comment:
I am fine with any version (both are simple and not the hardest part to
understand in the logic). :-) I have no opinion on which is better.
--
___
Python tracker
<http://bugs.python.org/issue29
Xiang Zhang added the comment:
Thanks Milt. I committed with my change not because it's better, but I want to
make the change small so others won't get unfamiliar with the new code. :-)
--
resolution: -> fixed
stage: commit review -> resolved
status
Changes by Xiang Zhang :
--
nosy: +davin
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue29454>
___
___
Python-bugs-list mailing list
Un
Changes by Xiang Zhang :
--
assignee: docs@python -> serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue29453>
___
___
Python-bugs-list mai
Xiang Zhang added the comment:
David, actually I have the same thoughts as Jim. Ordered ordinary dicts is not
a feature but ordered **kwargs is in 3.6. They seems not the same thing.
--
___
Python tracker
<http://bugs.python.org/issue29
601 - 700 of 1629 matches
Mail list logo