New submission from Zachary Ware:
Here's a patch for test_imaplib.py that converts test_main into load_tests.
--
components: Tests
files: test_imaplib_discovery.diff
keywords: patch
messages: 183294
nosy: brett.cannon, ezio.melotti, zach.ware
priority: normal
severity: normal
status
New submission from Zachary Ware:
Just subclassing issues in this one.
--
components: Tests
files: test_index_discovery.diff
keywords: patch
messages: 183299
nosy: brett.cannon, ezio.melotti, zach.ware
priority: normal
severity: normal
status: open
title: Fix test discovery
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10967
___
___
Python-bugs-list
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8273
___
___
Python-bugs-list
Zachary Ware added the comment:
I got to looking over my patch here again, and thought of another possible fix.
I'm not sure which is uglier, though :)
The problem is that most of the test cases are created using a custom subclass
of unittest.TestCase which takes extra constructor arguments
Changes by Zachary Ware zachary.w...@gmail.com:
Added file: http://bugs.python.org/file29308/test_robotparser_discovery.v3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17066
Zachary Ware added the comment:
Here's a pair of patches for 3.x and 2.7. The 3.x patch is actually targeted
at default; it has a couple extra instances of ``SkipTest`` that are converted
to :exc:`SkipTest` in the patch.
--
keywords: +patch
versions: +Python 3.3
Added file: http
Changes by Zachary Ware zachary.w...@gmail.com:
Added file: http://bugs.python.org/file29319/issue17329-2.7.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17329
Zachary Ware added the comment:
In the patches, the description of SkipTest is copied directly from the
docstring in Lib/unittest/case.py with a bit of markup added. It mentions
TestResult.skip(), which doesn't exist. I wonder if that was meant to be
TestCase.skipTest()?
--
type
Zachary Ware added the comment:
Fair points. I had originally put it in the section you suggested, but then
decided that it better fit in a new section of its own under Classes and
functions as that section describes in depth the API of unittest. But then,
it also makes sense to move
New submission from Zachary Ware:
I have found Doc/make.bat to be very useful, but I have hit a few of its
limitations now and then. Thus, I have made extensive modifications to bring
it much closer to the way Doc/Makefile works. Among the things changed in the
attached patch:
- Use pushd
Zachary Ware added the comment:
Doc/make.bat assumes that this issue has already been resolved:
if %PYTHON% EQU set PYTHON=..\pcbuild\python
Even with '_d' appended, as it should be, that does not work for 3.x.
I think that line should be @rem'ed out until it does work.
Does anyone mind
Zachary Ware added the comment:
In issue17386, I have offered a patch to Doc/make.bat which makes using
make.bat on Windows very, very nearly the same as using make on UNIX. With
such a patch applied, it would be trivial to rewrite section 7.6.1 with
instructions that apply equally well
Zachary Ware added the comment:
Sure can. This one should do it, at least for anyone with 3.3 installed.
--
Added file: http://bugs.python.org/file29358/win_doc_make_minipatch.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Zachary Ware added the comment:
Here's an updated version in the form of a patch.
Features include:
- Ensure things are done in the right directory with pushd/popd
- Allow setting environment variables (for the life of the script) with:
make test PYTHON=..\PCbuild\python.exe
- Emulate
Zachary Ware added the comment:
Richard Oudkerk added the comment:
+1
Thank you :)
To use Tools/builbot/*.bat doesn't the current directory have to be the main
directory of the repository? Then I see no point in the -C argument: just
set the correct directory automatically
Zachary Ware added the comment:
Terry J. Reedy added the comment:
One must run external.bat if one is to subsequently build from the vs
gui with *most* of the external dependencies. I think the command to
run it should be 'external', not 'ready'. 'External' means get the
external dependencies
Zachary Ware added the comment:
I agree that, long-term, test_robotparser should probably be rewritten with
less magic. Short-term, though, I think it would be good to get a temporary
fix for discovery in place since this is the only test file that completely
blows up discovery before
Zachary Ware added the comment:
Applying the minipatch makes the big patch fail to apply, so here's an update.
Also changed in this version of the patch:
- README.txt is updated. Not all the changes directly relate to this patch,
but there were some needed updates in there anyway
Changes by Zachary Ware zachary.w...@gmail.com:
Removed file: http://bugs.python.org/file29417/win_doc_make.v2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17386
Changes by Zachary Ware zachary.w...@gmail.com:
Added file: http://bugs.python.org/file29418/win_doc_make.v2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17386
Zachary Ware added the comment:
I was recently bitten by this issue. I've reviewed Terry's patch on Rietveld,
and have tested it myself some. It seems to get the job done without getting
in the way.
--
nosy: +zach.ware
___
Python tracker rep
Zachary Ware added the comment:
It does, in fact. Here's a patch.
--
Added file: http://bugs.python.org/file29419/issue10652.v2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10652
New submission from Zachary Ware:
This patch converts test_main() to load_tests(*args) due to test_main doing a
lot of namespace manipulation on all the test classes. There are a lot of
subclassing issues that discovery doesn't like, hence throwing away the second
argument passed
New submission from Zachary Ware:
With support.suppress_crash_popup(), we can stop skipping
test_sys.SysModuleTest.test_recursionlimit_fatalerror on Windows.
--
components: Tests
files: test_sys_unskip.diff
keywords: patch
messages: 184765
nosy: ezio.melotti, zach.ware
priority: normal
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6858
___
___
Python-bugs-list
New submission from Zachary Ware zachary.w...@gmail.com:
I was looking through the documentation source files for things I might be able
to fix, and stumbled across XXX Add a bit on the difference between tuples and
lists. in Doc\tutorial\datastructures.rst. So I took a stab at adding some
Zachary Ware zachary.w...@gmail.com added the comment:
Perhaps an added line at the end, something like 'Of course, should you need an
immutable list, tuples are quite handy for that, too.'?
--
___
Python tracker rep...@bugs.python.org
http
Zachary Ware zachary.w...@gmail.com added the comment:
I'll go with foolhardy, or just green :P. I wasn't aware that this topic was
quite as contentious as it seems to be.
I agree that tuples and lists are similar. I was trying to keep my wording at
here's another way to look at things
Zachary Ware zachary.w...@gmail.com added the comment:
Ezio's version looks pretty good to me. About the only quibble I can think of
is the removal of the example uses; they still apply and do help the point.
Just tacking on Classic examples of tuples include (x, y) coordinate pairs
New submission from Zachary Ware zachary.w...@gmail.com:
A couple months ago, I had never before heard of function annotations and came
across a function that had them (I don't remember where or what it was). I
spent a fair bit of time searching fruitlessly to figure out what the heck
Zachary Ware zachary.w...@gmail.com added the comment:
Thanks for the review :). Replied and here's the updated patch.
--
Added file: http://bugs.python.org/file25708/annotations_tutorial.v2.patch
___
Python tracker rep...@bugs.python.org
http
New submission from Zachary Ware zachary.w...@gmail.com:
See: http://hg.python.org/cpython/file/d31e83497c5a/Doc/library/sqlite3.rst#l708
PEP 246 is headed by:
Rejection Notice
I'm rejecting this PEP. Something much better is about to happen;
it's too early to say exactly what
Zachary Ware zachary.w...@gmail.com added the comment:
I just tested on Python 3.2, and found something interesting; it seems a ^Z
character on a line that has other input read in as a character. Also, other
input after an EOF on its own means you still have to do two more EOFs to end
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14187
___
___
Python-bugs-list
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15102
___
___
Python-bugs-list
New submission from Zachary Ware zachary.w...@gmail.com:
I found a very very minor typo in the docstring of tkinter.ttk.Treeview.exists:
Returns True if the specified item is present in the *three*
I assume that should be tree. The attached patch removes the h.
Thanks!
--Note
New submission from Zachary Ware zachary.w...@gmail.com:
Adding the search plugin for the 3.2 docs to Firefox and then searching from it
returns results from the 3.3 dev docs, despite everything saying it should be
for searching Python v3.2.2 documentation.
If my understanding of how it all
Zachary Ware added the comment:
Terry J. Reedy added the comment:
The problem is that this permissiveness does not apply to subsidiary files
discovered from and run by a main file, even though it should. The current
workaround is to explicitly set use_resources for the benefit of subsidiary
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18441
___
___
Python-bugs-list
New submission from Zachary Ware:
Here is an initial attempt at adding resource management/guarding to unittest,
a la test.support.requires.
The patch adds 6 new names to unittest.__all__; one function called
'registerResource' which explains itself, one function and one decorator
(require
Zachary Ware added the comment:
(Apologies for the delay in replies, my available time evaporated without
notice...)
Antoine Pitrou wrote:
Does registerResource() mutate some kind of global per-process state? This
doesn't sound like a good idea.
It's not the greatest of ideas, no; but I
Zachary Ware added the comment:
Antoine Pitrou wrote:
I've committed a fix to 2.7 (I hope it's really a fix, since I don't know how
to test it).
I'll let Benjamin and Barry decide whether to backport to 2.6 and 3.2.
As for 3.1, it's pretty much dead.
That fix does work, but it should
Zachary Ware added the comment:
Here's a new patch; test_json.__main__ now uses an absolute import rather than
trying to use a relative one. Also, Makefile.pre.in is fixed (thank you, Ned!).
--
Added file: http://bugs.python.org/file31190/test_json_discovery.v2-3.3.diff
Zachary Ware added the comment:
That's a much better solution, thank you, Serhiy. Here's a new patch.
test.support is no longer changed at all, but regrtest.py still is; the extra
reference to the tests still causes issues, so it is removed.
--
Added file:
http://bugs.python.org
Zachary Ware added the comment:
A lot of this discussion has flown a rather unfortunate distance over my head,
especially since I've barely had time to follow it. But it looks to me
like--given the number of other places that do the same thing as operator.index
currently does--there needs
Zachary Ware added the comment:
How about this?
--
Added file: http://bugs.python.org/file31385/issue18326.v2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18326
Zachary Ware added the comment:
Ping!
Anyone able to do a review of this patch? It still applies cleanly to default
(or even 3.3, if this qualifies as a bug rather than a new feature).
--
___
Python tracker rep...@bugs.python.org
http
Zachary Ware added the comment:
Ping!
The buildbots still seem to be failing, are my proposed fixes acceptable? Both
patches still apply cleanly.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17883
Zachary Ware added the comment:
How about a combination of the two? It's still short, but gets the point
across without assuming the reader knows exactly what 'keyword-only argument'
or requiring further reading, while introducing the term and providing the link
for deeper understanding
Changes by Zachary Ware zachary.w...@gmail.com:
--
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17326
___
___
Python-bugs
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18702
___
___
Python-bugs-list
Zachary Ware added the comment:
I took a stab at the doc changes, attached here and including Barry's patch.
--
components: +Library (Lib)
type: - enhancement
versions: +Python 3.4
Added file: http://bugs.python.org/file31575/16662_with_doc.diff
New submission from Zachary Ware:
Since test.support was moved into its own package, support.open_urlresource has
been unable to work. It expects __file__ dir/data to exist, but since
__file__ dir is now Lib/test/support instead of Lib/test, it doesn't unless
someone creates it manually
Zachary Ware added the comment:
Here's an alternative fix, which just makes open_urlresource look one directory
higher than where __file__ lives.
--
Added file: http://bugs.python.org/file31638/fix_support_open_urlresource.diff
___
Python tracker
Zachary Ware added the comment:
Having thought about this more, I think I agree that this is the wrong approach
to the issue and that a more general ability to add command line options to
unittest would be better. Closing this issue.
--
resolution: - rejected
status: open - closed
Zachary Ware added the comment:
Perhaps it would be best to either combine SuppressCoreFiles and
suppress_crash_popup, or provide a new construct that does so since both are
used in almost every place one is used. Also, test_daemon_threads_fatal_error
in test_threading should be using
Zachary Ware added the comment:
Issue17326 can now be closed as a duplicate of this issue.
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19130
Zachary Ware added the comment:
Here's a patch that combines Valerie's patch with a merged suppress_crash_popup
and SuppressCoreFiles called SuppressCrashReport.
Tests ok on Windows; I haven't been able to test on Unix yet.
--
Added file: http://bugs.python.org/file31987/issue18948
Zachary Ware added the comment:
I had missed this issue before; issue16968 tracks the same thing.
There are a couple of issues that the committed patch doesn't address. Namely,
the file still uses test_main, and there is no thread or process reaping when
running the file via discovery
New submission from Zachary Ware:
Full title: Update PCbuild/readme.txt to be more accurate, more descriptive,
more complete, less repetitive, more audience-aware, and all around, hopefully,
better.
What started as a simple patch to fix the supported Windows versions list, the
legacy build
Zachary Ware added the comment:
Here's the patched file for easier review.
--
Added file: http://bugs.python.org/file32149/patched_pcbuild_readme.txt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19273
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19229
___
___
Python-bugs-list
Zachary Ware added the comment:
Oops, forgot to provide the [1] link...
[1] https://mail.python.org/pipermail/python-dev/2013-October/129477.html
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19259
Zachary Ware added the comment:
Even after reading through #15061, I still wonder why _compare_digest is in
_operator at all. It makes even less sense to me to put a Python
implementation in operator; shouldn't the Python implementation be in the
module that actually uses it?
Branching from
Zachary Ware added the comment:
Thanks, Tim! There are a couple minor things I'd like to get into a new patch
before it's committed (there are a couple tabs that should be spaces, and I'd
like to add a very short note to the Sub-Projects header about sub-projects
being contained in .vcxproj
Zachary Ware added the comment:
Here's the new patch, a few tabs converted, a few trailing spaces removed, and
one sentence added to the Sub-projects section description.
--
Added file: http://bugs.python.org/file32336/pcbuild_readme.v2.diff
Zachary Ware added the comment:
This patch will only apply to tip. There would need to be some changes to
backport to 3.3 and I haven't actually looked at 2.7, but I expect it would
require extensive changes that probably wouldn't be worth it. There are a few
factual errors in 3.3
New submission from Zachary Ware:
As discussed in issue19273, here are a pair of patches that correct factual
errors in PCbuild/readme.txt in both 2.7 and 3.3.
The 3.3 patch makes the following changes:
- Remove Win2k mentions, it is not supported (Tcl nmake command also adjusted)
- MSVCRT9
Changes by Zachary Ware zachary.w...@gmail.com:
Added file: http://bugs.python.org/file32357/pcbuild_readme-2.7.diff-w
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19391
Changes by Zachary Ware zachary.w...@gmail.com:
Added file: http://bugs.python.org/file32355/pcbuild_readme-3.3.diff-w
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19391
Zachary Ware added the comment:
The 2.7 patch makes the following changes:
- python30.dll - python27.dll
- remove (see below) from _bsddb and _sqlite3 which have nothing to see below
- bz2.vcproj isn't as magical as it made out to be, and it can clean itself
- nasmw - nasm
- Remove untrue part
New submission from Zachary Ware:
Here's a patch that builds _testembed on Windows and adjusts test_capi to not
skip EmbeddingTests on Windows. The .vcxproj is based on _freeze_importlib,
with when to build settings lifted from _testimportmultiple.
The patch also adjusts
Changes by Zachary Ware zachary.w...@gmail.com:
Added file: http://bugs.python.org/file32416/test_capi_cleanup-3.3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19440
New submission from Zachary Ware:
Here's a patch to clean up test_capi a little bit; it removes a __future__
import, converts from test_main to unittest.main, and makes use of subtests to
run each _testcapi function.
I'll post a separate patch for 3.3; there's just enough difference between
Zachary Ware added the comment:
Adding to Vajrasky's report, the same commit also adds 3 warnings when building
on Windows:
..\Objects\unicodeobject.c(10588): warning C4018: '' : signed/unsigned
mismatch [P:\Projects\OSS\Python\cpython\PCbuild\pythoncore.vcxproj]
..\Objects\unicodeobject.c
New submission from Zachary Ware:
Here's a patch to remove the compiler warning raised during the clean step on
the Windows buildbots. The warning is about the fact that ssl.vcxproj doesn't
have an NMakeCleanCommandLine command; the patch adds such a command that
simply echos OpenSSL must
Changes by Zachary Ware zachary.w...@gmail.com:
Removed file: http://bugs.python.org/file30080/2.7_rt.bat_tcltk_fix.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17883
Changes by Zachary Ware zachary.w...@gmail.com:
Removed file: http://bugs.python.org/file30156/issue17883.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17883
Changes by Zachary Ware zachary.w...@gmail.com:
Removed file: http://bugs.python.org/file30196/issue17883-tmp-test.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17883
Zachary Ware added the comment:
Buildbots are still hanging on test_ttk_guionly and failing test_tcl and both
patches still apply cleanly.
Is there anything I can do to help move this forward again?
--
___
Python tracker rep...@bugs.python.org
http
Zachary Ware added the comment:
I was rather off about kill_python, wasn't I?
Anyway, I've finally gotten another version put together that I'd like to get
comments on. Major differences between this patch and the previous one, in no
particular order:
- Add a 'configure.bat' script
Zachary Ware added the comment:
Defaulting to opening a browser window sounds great to me. In those cases
where there is no network access, though, I think we should keep a fallback
help.txt, and I think the Sphinx text rendering is about the simplest and
easiest fallback we can get. Shall
Zachary Ware added the comment:
Any comments? Christian, I'd especially like to hear from you since it looks
like you were the original author of Doc/make.bat (issue1472).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Zachary Ware added the comment:
You seem to end your subroutines (or whatever they are called) using goto
end rather than exit /b. Since popd follows the end label, does this
mean that you get a popd after calling each subroutine?
Yes.
Is this intended and can it cause unmatched pushd
New submission from Zachary Ware:
Here's a patch for test_tarfile.py discovery.
There are a couple of inheritance issues resolved; CommonReadTest (and its
children, MiscReadTest and StreamReadTest) are changed simply to avoid running
the tests in CommonReadTest on their own--they pass
New submission from Zachary Ware:
Just inheritance issues in this one. The patch removes _BaseYearTest as its
only use was as a unittest.TestCase subclass to inherit from, which caused the
discovery issues.
--
components: Tests
files: test_time_discovery.diff
keywords: patch
messages
New submission from Zachary Ware:
Inheritance issues again. This one has some magic in test_main to create the C
and Python tests programmatically which I felt was best left alone, so the
patch simply converts test_main into a load_tests which ignores its arguments.
--
components
New submission from Zachary Ware:
test_sqlite.py simply imports and runs tests from sqlite3.test, the patch
converts test_main to load_tests to do the same.
--
components: Tests
files: test_sqlite_discovery.diff
keywords: patch
messages: 186528
nosy: brett.cannon, ezio.melotti
Zachary Ware added the comment:
Ping.
Version 4 still applies cleanly, and with issue16935 fixed, it works properly.
The fix for test_socket is looking like it could use the ReapedSuite from this
patch, so would anyone mind looking at this one again and committing if it's
qualified?
Thanks
Changes by Zachary Ware zachary.w...@gmail.com:
Added file: http://bugs.python.org/file29779/test_tarfile_discovery.v2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17689
New submission from Zachary Ware:
(Copied the nosy list from issue17484)
The new test module fails on Windows due to the lack of termios and pwd
modules. Here's a patch that fixes things. I suspect the skip condition on
UnixGetpassTest could be changed to check 'termios' rather than os.name
Zachary Ware added the comment:
The new tests fail on Windows, see for example
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/1763/steps/test/logs/stdio
It can be fixed on Windows by moving the `s.bind(('127.0.0.1', 0))` line above
the `self.assertIn('laddr', repr
Zachary Ware added the comment:
Buildbots look happy (with test_getpass, anyway) and my machine is happy too.
Thanks for the commit :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17699
Zachary Ware added the comment:
Here's a new patch to address Ezio's review comments, including more updates to
Doc/README.txt, the addition of an 'htmlview' target to make.bat, and
documentation of the 'htmlview' target in the Makefile usage message.
--
Added file: http
Zachary Ware added the comment:
Zachary, I suppose Modules/_operator.c is a rename of Modules/operator.c.
Could you generate your patch using hg diff --git so that history isn't
lost here?
Of course; I thought I already had, but apparently I messed that up a bit. v11
is in the proper
Zachary Ware added the comment:
Here's another new version of the patch, addressing Ezio's review comments and
a few things I found after giving operator.py a closer look myself.
Things changed in operator.py in this version:
- all ``__func__ = func`` assignments are moved to the end, after
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: -Arfrever, brett.cannon, eric.araujo, ezio.melotti, jcea, meador.inge,
pitrou, serhiy.storchaka, zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16694
Changes by Zachary Ware zachary.w...@gmail.com:
Removed file: http://bugs.python.org/file28327/operator.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16694
Changes by Zachary Ware zachary.w...@gmail.com:
Removed file: http://bugs.python.org/file28328/py_operator.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16694
101 - 200 of 2723 matches
Mail list logo
