Changes by Zachary Ware zachary.w...@gmail.com:
--
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22613
___
___
Python-bugs
New submission from Zachary Ware:
From docs@:
Hello,
First, I want to thank you for the useful and clear documentation of Python.
Beeing a fanatic reader of it, sometimes I encounter some mistake (or it seems
to me it is such). If this could bring some help, you will find in the attached
Zachary Ware added the comment:
After the last round of changes, the buildbots appear to be mostly happy. If
anybody else wants to backport the changes, I'd be happy to review and commit,
but I'll leave the backporting itself to whoever wants to do it. In the
meantime, closing the issue
Zachary Ware added the comment:
It grafted very easily, so it turns out to be yes :)
--
versions: +Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20221
Changes by Zachary Ware zachary.w...@gmail.com:
--
assignee: - zach.ware
resolution: - fixed
stage: patch review - resolved
status: open - closed
versions: +Python 3.5 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Zachary Ware added the comment:
Superseded by #22644 (and done, anyway).
--
assignee: - zach.ware
resolution: - fixed
stage: - resolved
status: open - closed
superseder: - Update Windows installers to OpenSSL 1.0.1j
type: - security
___
Python
Zachary Ware added the comment:
Done, as long as the buildbots stay happy with it.
--
assignee: - zach.ware
components: +Installation, Windows
resolution: - fixed
stage: - resolved
status: open - closed
type: - security
___
Python tracker rep
Zachary Ware added the comment:
Sure; here's a patch. I suspect we may want to try giving Sphinx some
different options to clean up the output a bit, but I'm not experienced enough
with Sphinx to have any specific suggestions.
--
Added file: http://bugs.python.org/file36975
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22677
___
___
Python-bugs-list
Zachary Ware added the comment:
I finally made it back to this and committed a tweaked version of your patch.
Thanks for the report and patch!
--
resolution: - fixed
stage: needs patch - resolved
status: open - closed
___
Python tracker rep
Zachary Ware added the comment:
I'm ambivalent on per-version externals dirs by now; I've since found it much
easier to maintain hg-shared repos per branch. I'll go ahead with this shortly
on all three branches, unless there are objections to it on 2.7 and 3.4.
--
versions: +Python
Zachary Ware added the comment:
Basically, after:
hg clone h.p.o/cpython default
hg share default 3.4
hg share default 2.7
hg -R 3.4 update 3.4
hg -R 2.7 update 2.7
the 2.7, 3.4, and default directories are separate working copies created from
the same history, each at a different revision
Zachary Ware added the comment:
There's no change from the status quo on that front: the only change
is that the $(externalsDir) VS variable becomes ..\externals instead
of ..\... Is there an open issue for versioning the tcltk[64] dirs
Zachary Ware added the comment:
I'd say so.
--
stage: - resolved
status: pending - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22177
Zachary Ware added the comment:
This is fairly wild speculation on my part, but I think Python is likely at the
bottom of the suspect list for whose bug this is, after (in order):
1) your own code
2) matplotlib
3) Tcl/Tk
I would suggest trying to come up with the shortest reproducer you can
Changes by Zachary Ware zachary.w...@gmail.com:
Added file: http://bugs.python.org/file37060/issue17896-2.7.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17896
Changes by Zachary Ware zachary.w...@gmail.com:
Removed file: http://bugs.python.org/file30113/move_externals.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17896
Zachary Ware added the comment:
I don't think we're on the same page here, Terry, so here's some patches and a
wall of text to hopefully make me clearer.
In particular, I don't understand what you mean by merge multiple tcltk
directories in isolated build directories, as the merge
Changes by Zachary Ware zachary.w...@gmail.com:
Added file: http://bugs.python.org/file37059/issue17896-3.4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17896
Zachary Ware added the comment:
Thanks, Ezio!
--
assignee: - zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22173
___
___
Python-bugs
Zachary Ware added the comment:
Ok, I've imported nasm-2.11.06 to:
http://svn.python.org/projects/external/nasm-2.11.06
I'll work on a patch for default and see what (if anything) will need to change
in the openssl checkout.
--
___
Python
Zachary Ware added the comment:
Fairly simple patch for default.
--
keywords: +patch
Added file: http://bugs.python.org/file37089/issue17717-default.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17717
Zachary Ware added the comment:
It doesn't look like import locale can fail (import _locale can, but
locale.py has emulation that would work with this patch).
LGTM.
--
stage: patch review - commit review
versions: -Python 3.6
___
Python tracker
Zachary Ware added the comment:
The patches for 2.7 and 3.4 were more trivial than for default, and I was
pretty confident in the patch for default, so I went ahead and committed. I
did switch around which end of PATH our copy of NASM was added to, to make it
easier for someone to override
Changes by Zachary Ware zachary.w...@gmail.com:
--
components: +Build
nosy: +tim.golden
stage: - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17717
Zachary Ware added the comment:
Thanks for tracking it down, Ned!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18604
___
___
Python-bugs-list
Zachary Ware added the comment:
Thanks for the test, Terry. Committed.
--
assignee: - zach.ware
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17896
Zachary Ware added the comment:
Good point, David. Jeremy, Trent, you're the only other Windows buildbot
operators as far as I know; feel free to clean up the old externals locations
as you like.
Also, sorry to make it a bit hairier to operate, but I think this is a big
enough improvement
Zachary Ware added the comment:
Aaron, what version of Python are you using on what version of Windows? Also,
32 or 64 bit on both?
I can't reproduce this with any Python 3.3.6 or newer on 64-bit Windows 8.1.
--
___
Python tracker rep
Zachary Ware added the comment:
I haven't built 3.3.0 again yet to try to reproduce with it, but there
have been enough bug and security fixes in the more recent 3.3
releases that I'd strongly advise updating on general principle and
seeing if this issue goes away. If not to 3.4.2, at least
Zachary Ware added the comment:
I have had a chance to build 3.3.0 and I was able to reproduce the bug with it,
so it is in fact fixed in later versions.
--
resolution: - out of date
stage: - resolved
status: open - closed
___
Python tracker rep
Zachary Ware added the comment:
Sorry, I haven't had a chance to get back to this one.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19949
Zachary Ware added the comment:
Mark, did you test your latest patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
___
___
Python-bugs
Zachary Ware added the comment:
Steve, I was actually just minutes away from committing the same fix in the
opposite direction when I got the notification of your commit. Nick will
correct me if I'm wrong but I think PyOS_CheckStack was supposed to stay in
pythonrun.c, especially since it's
Zachary Ware added the comment:
In that case, it would be good to make sure it still applies and passes the
tests. Last time I tried it didn't, and I was called away before I could
leave a note to that effect (for which I am sorry). However, I don't have
a strong enough opinion on this issue
Zachary Ware added the comment:
Another round of review posted on Rietveld. I'll try to get the VS2015 preview
downloaded today and give some more feedback after using it.
Just one inconsequential note on python3.diff: the 'lib' command in
python3dll.vcxproj could use a '/nologo' flag
Zachary Ware added the comment:
After a debug build with VS2015, my biggest concern is this:
..\PC\bdist_wininst\install.rc(19): fatal error RC1015: cannot open include
file 'afxres.h'. [P:\ath\to\cpython\PCbuild\bdist_wininst.vcxproj]
There's also a slew of new warnings, mostly C4456
Zachary Ware added the comment:
This is still causing a somewhat serious warning on Windows, see [1] for
example. The condition warned about affects every platform.
It took me some time to make sense of that function, but I think I finally
understand what's going on. I think Steve's
Zachary Ware added the comment:
Definitely not 2.7, since it's still on VS2008 and would require so many
changes for this to matter that it's just not an issue; I'm not sure on 3.4.
Is cabinet.lib available (and have everything we need) for MSVC10 and SDK 7.1
(which are the important targets
Changes by Zachary Ware zachary.w...@gmail.com:
--
stage: - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22938
___
___
Python-bugs-list
Changes by Zachary Ware zachary.w...@gmail.com:
--
components: -Windows
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22938
___
___
Python-bugs
Zachary Ware added the comment:
Note that pickling of the pure Python version of methodcaller works as expected:
Python 3.4.2 (default, Nov 20 2014, 12:40:10)
[GCC 4.8.3] on linux
Type help, copyright, credits or license for more information.
import sys
sys.modules['_operator'] = None
Zachary Ware added the comment:
Try the following in Command Prompt:
cd /D C:\Users\kyle\Downloads python -c import io;print io.__file__
The result should be C:\Python27\lib\io.pyc. If it's not, rename the file
that you do get back.
--
nosy: +zach.ware
resolution: - not a bug
Zachary Ware added the comment:
No problem, glad it was an easy one :)
--
stage: - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22967
Zachary Ware added the comment:
I'd prefer to just reimplement itemgetter and attrgetter to make them picklable
rather than adding pickling methods to them; see attached patch.
I also posted a few comments, but I just went ahead and addressed them myself
in this patch. I'm not qualified
Changes by Zachary Ware zachary.w...@gmail.com:
Removed file: http://bugs.python.org/file37319/issue22955.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22955
Changes by Zachary Ware zachary.w...@gmail.com:
Added file: http://bugs.python.org/file37320/issue22955.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22955
Zachary Ware added the comment:
Sorry Steve, I haven't been on Windows since my last review to give it
another try. And, of course, somewhere in the 5 seconds between shutting
down from Gentoo and turning back on for Windows last night, my laptop
decided that POSTing was just too much effort
Zachary Ware added the comment:
Sorry, but there's nothing we can do about it; that will be a Tk issue. I'd
suggest discussing it with the Tcl/Tk developers, see http://wiki.tcl.tk/1020
--
nosy: +zach.ware
resolution: - third party
stage: - resolved
status: open - closed
Zachary Ware added the comment:
Serhiy: functools.partial is a somewhat less than ideal comparison. The
pure-Python version is not picklable, the Python and C versions return
different things (the Python version is a function returning a function, the C
version is a regular class and returns
Zachary Ware added the comment:
Serhiy Storchaka added the comment:
Reimplementations of the pure-Python itemgetter and attrgetter to
automatically pickleable Python classes have a disadvantage. It makes
the pickling incompatible between Python and C versions. This means
that itemgetter
Zachary Ware added the comment:
I don't know near enough to comment on this one. If you feel confident in it,
I'd say go ahead.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22733
Zachary Ware added the comment:
Not sure why I was added here, but...
I agree with David, we need to see the python-dev discussion to its finish
before we make any more changes to any of our private copies of libffi. I hope
to get some experimental results from Windows written up and posted
Zachary Ware added the comment:
To clarify a bit, there's very little re-compiling, but everything that
references the pythoncore project (every extension) is re-linked. There's no
way around that short of not including the hg revision (which I won't accept
:), but the re-linking only takes
Zachary Ware added the comment:
Hmmm, what are sections 3 and 4? Are you building from the VS GUI or
Command Prompt?
From Command Prompt in a clean checkout, running PCbuild\build.bat -d -e
(debug build) should take several minutes. The same again should be quick,
and then just PCbuild
Zachary Ware added the comment:
On testing, you are correct, Mark. Sorry for the premature close.
How does this patch look to you, Steve?
--
assignee: - zach.ware
keywords: +patch
resolution: not a bug -
stage: resolved -
status: closed - open
type: - behavior
Added file: http
New submission from Zachary Ware:
The Argument Clinic conversion of the binascii module left hexlify and
unhexlify with bad docstrings:
hexlify(...)
b2a_hex($module, data, /)
--
Hexadecimal representation of binary data.
The return value
Zachary Ware added the comment:
Thanks for the (very quick!) review, Serhiy.
--
assignee: - zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23280
New submission from Zachary Ware:
Larry, in #22120 msg224817, you said:
Since IIUC there's no code in 3.4 that uses an unsigned integer return
converter, I'm not backporting the fix.
Modules/binascii.c does have one use of an unsigned integer return, resulting
in the only not-something-new
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +steve.dower
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23246
___
___
Python-bugs-list
Zachary Ware added the comment:
The .EXE is very strange, but the fix was simple enough. Thanks for the report.
--
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23256
Zachary Ware added the comment:
I got the 1.0.1l sources prepared and committed to svn.python.org 12 days ago,
but got pulled away from it before I had a chance to build and test it. Steve,
Tim, if one of you has a chance to test it out before I do, please don't
hesitate.
Note
Changes by Zachary Ware zachary.w...@gmail.com:
--
resolution: - not a bug
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23355
Zachary Ware added the comment:
I'm not seeing any problem with any section 4.1. If you can provide a direct
link to the problem and a description of it, please reopen the issue.
--
nosy: +zach.ware
resolution: - not a bug
stage: - resolved
status: open - closed
Zachary Ware added the comment:
_posixsubprocess should not be compiled on Windows, as it will not work and
has the potential to completely screw up subprocess on Windows. This
appears to be a bug in subprocess32's setup.py, and thus does not apply to
Python itself at all. I agree with Victor
Zachary Ware added the comment:
I don't even know what pgen is or why I'd want to build it...
pgen is the parser generator, taking Grammar/Grammar as input and generating
Include/graminit.h and Python/graminit.c. Only useful when you're changing
Python's grammar, but without the ability
Zachary Ware added the comment:
This one could use a NEWS entry, and possibly what's new as well.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23437
Zachary Ware added the comment:
Thanks, Steve!
--
assignee: - steve.dower
stage: - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23461
Zachary Ware added the comment:
Rather than add a variable to sys that will be empty 99% of the time, I think
I'd rather stick a '__command__' constant in the __main__ module namespace when
running with '-c' (think of '__file__'). You could then get at it elsewhere
with 'from __main__ import
Zachary Ware added the comment:
The patch is way out of date, pgen.vcxproj needs to be updated to match the
rest of our projects.
If nobody else takes this over (and it is low priority for a reason!), I'll get
back to it eventually.
--
nosy: +steve.dower
Zachary Ware added the comment:
What does the diff to importlib.h look like? Does it look like a real change
to importlib or is it something innocuous like a change in whitespace or the
path separator in the heading?
--
components: +Build, Windows
nosy: +tim.golden, zach.ware
Zachary Ware added the comment:
Ah ha. Do you have the hg eol extension enabled? If not, you
probably should; it makes for far fewer headaches on Windows, and
should make this issue go away.
We should probably try to mitigate the problem anyway; Steve, how hard
would it be to change the 'see
Zachary Ware added the comment:
The other option would be to change _freeze_importlib to force it to
use \n instead of \r\n; I'm not sure which change would be harder to
do.
Paul: fair enough; I've just found that keeping eol enabled reduces
headaches due to line endings to almost nothing, just
Zachary Ware added the comment:
Our original explanation accounts for the 31 projects rebuilding.
I'll get the patch committed later tonight (hopefully).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23154
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23593
___
___
Python-bugs-list
Zachary Ware added the comment:
Terry J. Reedy added the comment:
Sorry. That has to be py -3 ... unless you have configured 'py' to
run 3.x, or py -m idlelib.idle ... for 2.7.
Any reason not to add idlelib.__main__ to 2.7? It works the same in either
version, as far as I can tell
Changes by Zachary Ware zachary.w...@gmail.com:
--
resolution: - not a bug
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23610
Zachary Ware added the comment:
Paul Moore added the comment:
Note that in spite of the name, the process should also work for Python
3.2 and 3.3, which also use VS2008 (but I haven't tested that explicitly).
Just 3.2; 3.3 was the first version to use VS2010
Zachary Ware added the comment:
Tim Golden added the comment:
The problem is that this isn't an area I'm particularly familiar with
(either in Python nor in Windows) so I need time to ramp up my awareness
of what Steve's proposing plus then assessing the change. I'll try...
but I rather hope
Zachary Ware added the comment:
The problem is, the interpreter can't know what you meant to do, so it can only
point out what it can't compile. We did recently add a special case for print
without parentheses, but adding special cases for everything is just not
feasible. Besides, where
Zachary Ware added the comment:
That may be for the best.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20323
___
___
Python-bugs-list mailing
Zachary Ware added the comment:
(My last comment was aimed at Larry's comment about abandoning two-pass...)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20323
Zachary Ware added the comment:
STINNER Victor added the comment:
Note: The binary (in debug mode) moved from PCbuild\python_d.exe to
PCbuild\win32\python_d.exe
There ought to be a 'python.bat' in the root of the source tree that
will always point to the last-built python[_d].exe, which may
Changes by Zachary Ware zachary.w...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21741
Zachary Ware added the comment:
Unfortunately, I don't have any ideas. Mark, is this still happening? If so,
I think your real solution is going to be to install VS2015 CTP 6 (and later
the real thing, in whatever the free flavor is). Same for #23449
Zachary Ware added the comment:
Same patch, with diff to python3.def to make it available.
--
Added file: http://bugs.python.org/file38967/23903_with_python3.def.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23903
Zachary Ware added the comment:
Thanks for the patch!
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23938
___
___
Python-bugs
Zachary Ware added the comment:
Thanks for the patch!
--
nosy: +zach.ware
versions: -Python 3.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23730
Zachary Ware added the comment:
Steve, Andrew, does either of you want to take care of this or shall I give it
a shot? I'm figuring on using the patch here and re-adding PyCFunction_New as
it had been.
--
___
Python tracker rep...@bugs.python.org
Zachary Ware added the comment:
Here's an updated patch for clean application. Larry, could you give this a
look?
--
Added file: http://bugs.python.org/file38969/issue20586.v3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Zachary Ware added the comment:
I left a comment on Rietveld. Also, the test doesn't pass on Windows:
test test_unittest failed -- Traceback (most recent call last):
File C:\Data\code\CPython\hg.python.org\devinabox\cpython\lib\unittest\test\t
est_discovery.py, line 677
Zachary Ware added the comment:
That's a fair point. So to make my plan work, we'd really need a good
way to differentiate CTRL_C_EVENT and 0. If anybody has any good
ideas on that, I still like my plan. If not, I'm afraid I have to
agree that os.kill will need to go down as doomed by Windows
Zachary Ware added the comment:
Thanks Larry
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
versions: -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20586
Zachary Ware added the comment:
I think what I'd rather do is deprecate the use of os.kill (on Windows) with a
signal other than CTRL_C_EVENT and CTRL_BREAK_EVENT, document very clearly that
os.kill is strictly for sending signals, and add os.terminate to implement
TerminateProcess
New submission from Zachary Ware:
For example:
_winapi_CreateFile_impl(PyModuleDef *module, LPCTSTR file_name, DWORD
desired_access, DWORD share_mode, LPSECURITY_ATTRIBUTES security_attributes,
DWORD creation_disposition, DWORD flags_and_attributes, HANDLE template_file
Zachary Ware added the comment:
As an aside: Pam, I got a bounce notice from the email that Rietveld tried to
send you. It claims that your email account is disabled, though I suspect that
might be it's way of saying it thinks Rietveld is spam (since it tries to send
in the reviewer's name
Zachary Ware added the comment:
Will do in the morning.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23944
___
___
Python-bugs-list mailing
Zachary Ware added the comment:
Ahh. Not quite, though; that change just changed the way unittest reports the
results on non-Mac platforms. The problem is actually here:
https://hg.python.org/cpython/file/default/Lib/ctypes/test/test_macholib.py#l34
We need a patch to try that import
Changes by Zachary Ware zachary.w...@gmail.com:
--
stage: - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24003
___
___
Python-bugs-list
Zachary Ware added the comment:
Here's a new patch that actually applies, and has a couple of improvements.
I'd greatly appreciate some review on this; I'm planning on committing before
beta1 anyway.
--
nosy: +paul.moore, steve.dower, tim.golden
priority: normal - high
Added file
1001 - 1100 of 2723 matches
Mail list logo
