Zachary Ware added the comment:
The attached patch fixes the warnings and doesn't appear to break anything
obvious.
The first 4 are fixed by reverting Alexandre's change from '#if SIZEOF_SIZE_T'
to 'if (sizeof(size_t)'.
The last one is different from the original 5th warning, and is fixed
Zachary Ware added the comment:
Looks like Martin took care of it in 730d89d66b38. Thanks, Martin!
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
type: - enhancement
___
Python tracker rep...@bugs.python.org
http
Zachary Ware added the comment:
I suspect you pulled at just the wrong time and caught e39db21df580, which
Alexandre has already reverted in 2a1de922651a.
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +alexandre.vassalotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19779
___
___
Python
Zachary Ware added the comment:
Hmmm, that's odd; I can't reproduce on Windows 7 from 2a1de922651a, but I can
from e39db21df580.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19779
New submission from Zachary Ware:
The attached patch turns running kill_python(_d).exe into a PreBuildEvent in
pythoncore.vcxproj. This should guarantee that kill_python(_d).exe is always
run to guarantee no zombie pythons in the background can prevent overwriting
the Python dll
Zachary Ware added the comment:
Nope, your patch looks good, I just haven't gotten it committed yet :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19588
Zachary Ware added the comment:
Thanks for the patch, Julian!
--
assignee: - zach.ware
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19588
Zachary Ware added the comment:
This seems to have broken 64-bit Windows:
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/3472/steps/test/logs/stdio
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.3/builds/1288/steps/test/logs/stdio
http
Zachary Ware added the comment:
Thanks for the test, Tim :)
--
assignee: - zach.ware
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19788
Changes by Zachary Ware zachary.w...@gmail.com:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3158
___
___
Python-bugs
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19828
___
___
Python-bugs-list
Zachary Ware added the comment:
As long as the buildbots stay happy, this test is back to actually testing.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http
Changes by Zachary Ware zachary.w...@gmail.com:
--
keywords: +easy
stage: - needs patch
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19845
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19845
___
___
Python-bugs-list
Zachary Ware added the comment:
Thanks for the report; I could have sworn I had submitted a patch for this
several months ago, but it seems like I didn't and had completely forgotten
about it.
--
assignee: docs@python - zach.ware
resolution: - fixed
stage: needs patch - committed
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19866
___
___
Python-bugs-list
Zachary Ware added the comment:
Francis, would you like to work on a patch for this? The change should go in
Tools/msi/msi.py, if I'm not mistaken.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19866
Zachary Ware added the comment:
Here's a new patch based on Jeremy's that addresses all of my review comments
and includes the update to Tcl/Tk 8.6.1.
Also, I'll be attaching a patch to tix-8.4.3.x which allows it to be built in
debug configuration and removes many warnings about unrecognized
Changes by Zachary Ware zachary.w...@gmail.com:
--
stage: - patch review
type: - enhancement
Added file: http://bugs.python.org/file32998/issue15968_tix.svndiff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15968
Zachary Ware added the comment:
Committed on 3.3 and default; I'd still like some extra eyes on the 2.7 patch
before I commit it.
--
assignee: - zach.ware
versions: -Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http
Zachary Ware added the comment:
Fixed, thanks for the patch!
--
assignee: - zach.ware
nosy: +zach.ware
resolution: - fixed
stage: - committed/rejected
status: open - closed
versions: +Python 3.3
___
Python tracker rep...@bugs.python.org
http
Changes by Zachary Ware zachary.w...@gmail.com:
Added file: http://bugs.python.org/file33070/test_dis_1333982-3.4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19938
New submission from Zachary Ware:
Here's a pair of patches which re-enable test_bug_1333982 in test_dis on 3.3
and 3.4; the major changes in 3.4 necessitate separate patches. The patches
also replace test_main with unittest.main which made trying to get the test to
work much less annoying
Zachary Ware added the comment:
Left a comment on Rietveld; mostly LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19928
___
___
Python
Zachary Ware added the comment:
The real issue here is that the test used to determine whether -S was passed or
not is outdated: instead of checking sys.flags.no_site, it checks whether
'site' is in sys.modules. This is no longer a valid test, since site's side
effects are contained within
Zachary Ware added the comment:
I suspect you may have a file shadowing the standard library's types.py; you
can test with the following command:
python -c import types;print(types.__file__)
If the output from that is not C:\Python33\lib\types.py, then you have
another file shadowing
Zachary Ware added the comment:
People are bitten by this kind of thing all the time, but usually only once ;)
--
resolution: rejected - invalid
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19947
Zachary Ware added the comment:
Here's a new 2.7 patch. It addresses Serhiy's review comments and doesn't
change test_xpickle, which I will be opening a new issue for.
--
Added file:
http://bugs.python.org/file33080/skiptest_not_return_or_pass.v5-2.7.diff
New submission from Zachary Ware:
The attached patch moves test_xpickle away from using alternately defined empty
TestCases to skip the backward compatibility tests to using a skip decorator.
Also, several disabled tests are moved from defining empty tests to setting the
test name to None
Zachary Ware added the comment:
I missed the comments on test_bsddb; I'll either post a new patch here or open
a new issue depending on how big that diff becomes.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19572
Zachary Ware added the comment:
This patch includes Serhiy's suggestions. Oops!
--
Added file:
http://bugs.python.org/file33082/skiptest_not_return_or_pass.v6-2.7.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19572
Zachary Ware added the comment:
Fixed that last comment in the commit. Thank you for all the reviews, Serhiy!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http
Zachary Ware added the comment:
This was failing the Windows buildbots; the object addresses have capital
letters instead of lower case. I'm sorry, I should have caught that at review.
--
___
Python tracker rep...@bugs.python.org
http
Zachary Ware added the comment:
Looking more closely, there's not much that looks like it really should be
tested if explicitly called with -S, so perhaps the toplevel skip is still best
after all. Any other thoughts?
Attached patch fixes `python -S Lib/test` and cleans up an unused import
Zachary Ware added the comment:
Fixed. Thank you Vajrasky for raising the issue, and David for the much better
wording.
--
assignee: - zach.ware
resolution: - fixed
stage: - committed/rejected
status: open - closed
versions: +Python 3.3
New submission from Zachary Ware:
The attached patch adds a CustomBuildStep to python.vcxproj which creates a
'python.bat' script in the root of the source tree for quicker and easier
invocation for testing purposes, and to make the Windows Python developer
experience a little closer
Zachary Ware added the comment:
This is a little odd, since it seems that that buildbot doesn't have a sound
card (according to _have_soundcard), but succeeded in playing a
sound...although without an ear in the room, we have no way to tell if a sound
was played or not. I'm thinking it may
Zachary Ware added the comment:
I'll get it committed shortly, thanks Christian.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19987
Changes by Zachary Ware zachary.w...@gmail.com:
--
assignee: - zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19987
___
___
Python-bugs
Zachary Ware added the comment:
The revised test passes on that buildbot on 3.3 and 3.x; the 2.7 build is
having permissions issues (and seems to have been for some time). Closing the
issue.
Thanks for pointing it out and approving the rewrite, Christian!
--
resolution: - fixed
New submission from Zachary Ware:
This patch makes extensive changes to test_decimal, with the ultimate goal of
making `python -m unittest discover Lib/test/ test_*.py` not choke on
test_decimal (see issue16748). Trying to do so uncovered a few other issues,
such as some tests not properly
Changes by Zachary Ware zachary.w...@gmail.com:
--
dependencies: +Clean up/refactor/make discoverable test_decimal, Fix test
discovery for test_codecmaps*.py, Fix test discovery for
test_concurrent_futures.py, Support ./python -m unittest in test_socket
Zachary Ware added the comment:
Stefan Krah wrote:
In any case, I would prefer a patch without stylistic changes.
Elimination of return is a personal preference, so are the
whitespace changes.
The returns were removed in #19572, to reduce false positives in searching for
silently skipped
Zachary Ware added the comment:
Thanks for the report and patch!
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20005
Zachary Ware added the comment:
The problem on Windows at least is that the skips for the 'fork' and
'forkserver' start methods aren't firing due to setUpClass being improperly set
up in MultiProcessingCmdLineMixin: it's not decorated as a classmethod and the
'u' is lower-case instead
Changes by Zachary Ware zachary.w...@gmail.com:
Added file: http://bugs.python.org/file33216/skip_tests_ctypes.v3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19493
Zachary Ware added the comment:
Here's a new patch addressing your review comment, Serhiy. It also addresses
some failures on Windows in test_values: Win_ValuesTestCase depends on 'pydll'
being defined in the module toplevel and shadowing ctypes.pydll; this
definition was removed some years
Zachary Ware added the comment:
The patch looks good to me, but I can't claim to know enough about pickle to
say whether the tests are correct. Alexandre or Antoine?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19648
Zachary Ware added the comment:
Thanks for the removal patch, Ajitesh!
Julian, are you still working on implementing the tests on default?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19683
Zachary Ware added the comment:
Alright, sounds good.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19683
___
___
Python-bugs-list mailing list
Changes by Zachary Ware zachary.w...@gmail.com:
--
versions: +Python 3.4 -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19683
Zachary Ware added the comment:
I'd prefer to keep the change to test_wintypes, simply because I was rather
surprised to find an extra test being run on Windows.
As for the pydll/pythonapi issue, any thoughts from Amaury, Meador, or
Alexander? The relevant change that removed the definition
Zachary Ware added the comment:
Any objections to proceeding with this?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17202
___
___
Python-bugs
Zachary Ware added the comment:
It's only taken me 6 months, but I'm looking at this issue again :)
Ed, basically the only reason I used setUpModule was because it was a very
direct translation from test_main to setUpModule--only the name and signature
changed, the skip and initialization
New submission from Zachary Ware:
The attached patch refactors tkinter._fix's main logic into a function called
'fix_environ' which is called unconditionally on import, and adds a function
'unfix_environ' to undo the effects of fix_environ. fix/unfix_environ are then
used in all test files
Zachary Ware added the comment:
I like that idea, though I'm a bit wary of messing around is sys.modules. Is
there another way to unload a module that I'm not aware of?
Here's a new patch that does that.
--
Added file: http://bugs.python.org/file33235/suppress_environ_warning.v2.diff
Zachary Ware added the comment:
I think the minimum bound for dt could stand to be relaxed very slightly,
here's some results from my 64-bit Win7 box running 32-bit Python:
3.4.0b1 (default:eae6966d9734+, Dec 21 2013, 15:47:14) [MSC v.1600 32 bit
(Intel)]
sys.getwindowsversion(major=6, minor
Zachary Ware added the comment:
That's weird. I ran the same test on the same computer with an installed
64-bit 3.3.2, and got the same results (70+% failure). I just ran the same
test on a different computer (32-bit Windows 7), and also got the same results
with both 3.4.0b1+ and 3.3.2
Zachary Ware added the comment:
See also issues #9949 and #15411.
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20055
Zachary Ware added the comment:
Some refactoring of the tests is certainly acceptable. If there are some tests
that can be merged together, it is fine to do so; also for removing ones that
don't make any sense (it's not like they've ever tested anything anyway :)).
We don't have anyone
Zachary Ware added the comment:
Here's a much better patch to 3.4.
--
Added file: http://bugs.python.org/file33269/test_dis_1333982-3.4.v2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19938
Zachary Ware added the comment:
Committed; thanks for the review, Serhiy! I made similar changes to the 3.3
patch before committing.
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep
Zachary Ware added the comment:
Looks good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20070
___
___
Python-bugs-list mailing list
Zachary Ware added the comment:
Interestingly, it doesn't look like pydoc's fault:
P:\ath\to\cpython\PCbuild\python_d.exe -ISc import
sys;print(sys.version);print(open.__doc__[:75]);print('pydoc' in sys.modules)
3.4.0b1 (default:94a04b8b3a12, Dec 26 2013, 09:27:14) [MSC v.1600 32 bit
(Intel
Zachary Ware added the comment:
The patch looks good to me (aside from extra whitespace on the blank lines in
methodobject.c, and I agree with Serhiy about s/brackets/parens/). Also, I
like the suggestion of using __text_signature__ instead of '(...)'. However,
just to avoid any possible
Zachary Ware added the comment:
Here's a patch for 3.4, and some sample verbose output[1] from the AMD64 Win7
buildbot (which runs buildbot as a service, and thus has no gui available).
[1]
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%20custom/builds/40/steps/test/logs/stdio
New submission from Zachary Ware:
For previous discussion, see issue1.
To summarize, time on Windows is far from straight-forward, and currently for
t1 = time.monotonic()
time.sleep(0.5)
t2 = time.monotonic()
dt = t2-t1
dt may end up as very slightly smaller than 0.5 (0.499003017485
Zachary Ware added the comment:
Martin v. Löwis wrote:
As a further datapoint, it would be good to find out whether any of you has
NTP enabled, and if so, against what time server. To find out, open the clock
settings (Datums- und Uhrzeiteinstellungen ändern), and go to NTP tab
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19143
___
___
Python-bugs-list
Changes by Zachary Ware zachary.w...@gmail.com:
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18604
Zachary Ware added the comment:
I ran the same test on all of the Windows buildbots, with the following results:
x86 XP-4:
http://buildbot.python.org/all/builders/x86%20XP-4%20custom/builds/33/steps/test/logs/stdio
monotonic: good
time: good
clock/perf_counter: 10 failures
x86 Windows7
http
Zachary Ware added the comment:
I'll take a stab at this one, but I may make you rue the day you said you'd
review until your eyes bleed ;)
Here's a partial patch to PC/winreg.c, converting only the CloseKey function
just to make sure I have some basic idea of what I'm doing.
(Also
Zachary Ware added the comment:
To possibly ease review (and for keeping track of what I'm doing), I'm linking
hg.python.org/sandbox/zware#issue20172 where I'll try to do a commit per
converted function.
--
hgrepos: +216
___
Python tracker rep
Changes by Zachary Ware zachary.w...@gmail.com:
--
assignee: - docs@python
components: +Documentation
nosy: +docs@python, larry
stage: - patch review
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20200
Zachary Ware added the comment:
Thanks, Larry. Conversion proceeds apace in winreg.c, but I have a couple
questions.
1) Since the comment above CConverter.format_unit says all custom converters
should use 'O' instead of defining format_unit, there must be another way to
do this:
/*[python
Zachary Ware added the comment:
A, much better. An empty subclass doesn't do quite the right thing, but
`class REGSAM_converter(int_converter): type = 'REGSAM'` does the trick (see
http://hg.python.org/sandbox/zware/rev/5af08aa49631).
Thanks, Larry!
(Next will probably be trying to get
Changes by Zachary Ware zachary.w...@gmail.com:
Added file: http://bugs.python.org/file33411/f2192566eefd.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20172
Changes by Zachary Ware zachary.w...@gmail.com:
Removed file: http://bugs.python.org/file33367/issue20172.partial.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20172
Zachary Ware added the comment:
Here's the complete patch for PC/winreg.c. One clinic/signature/pydoc issue
I've noticed:
help(winreg.HKEYType.Close)
Help on method_descriptor:
Close(...)--- No signature
Close() --- Extra
Closes
Zachary Ware added the comment:
PC/winsound.c went pretty quick and easy.
--
Added file: http://bugs.python.org/file33412/issue20172.winsound.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20172
Zachary Ware added the comment:
How are you compiling to get that warning? I've never seen it, and none of the
Windows buildbots do either. Also, which version of Python are you compiling
on which version of Windows?
--
nosy: +zach.ware
stage: - test needed
versions: -Python 2.7
Zachary Ware added the comment:
Here's msvcrt.
--
Added file: http://bugs.python.org/file33415/issue20172.msvcrt.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20172
Zachary Ware added the comment:
I second this request. Every PyArg_ParseTupleAndKeywords-using function in
_winapi has a keyword argument overlapped which is stuffed into a C variable
use_overlapped, while the local variable overlapped is used for an
Overlapped object, which makes for a big
Zachary Ware added the comment:
And here is the patch to _winapi.c.
--
Added file: http://bugs.python.org/file33439/issue20172._winapi.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20172
Zachary Ware added the comment:
Sandbox repo updated. It is currently using an older version of clinic;
running current clinic on the winreg.c in the tip of the sandbox produces this
traceback:
Traceback (most recent call last):
File Tools\clinic\clinic.py, line 2981, in module
Zachary Ware added the comment:
Thanks for the report!
--
assignee: docs@python - zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20253
Zachary Ware added the comment:
Looks good to me, with Berker and David's comments addressed. Here's an
alternate approach I came up with, since about.rst already links to bugs.rst,
which already contains most of what I think we want to get across here. I'm
good with either route, really
Zachary Ware added the comment:
Done, thanks Georg!
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
type: - enhancement
versions: +Python 2.7, Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http
Zachary Ware added the comment:
This could be taken a step further, following the lead of the whitespace fixing
checks and just run clinic on files that need it.
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
New submission from Zachary Ware:
Doc/using/windows still mentions DOS, Windows 3.x, and Python 2.1, and that's
just in the first short section. This is a catch-all issue for making sure
that page is up to date.
--
assignee: docs@python
components: Documentation, Windows
keywords
New submission from Zachary Ware:
The Python on Windows faq could use some TLC. For instance, cx_Freeze should
be mentioned in the faq about creating an executable (and py2exe should either
mention that it doesn't quite support 3.x yet, or just be removed until it
does), and the embedding
Zachary Ware added the comment:
Just confirmed that this patch fixes the traceback I was getting from winreg in
#20172, but this has a new oddity:
help(winreg)
...
ConnectRegistry(computer_name=object object at 0x0190E148, key=object
object at 0x0190E148)
...
Every param of every
Zachary Ware added the comment:
Actually, I can reproduce on tip with just this patch applied; os.chmod shows
it. And I was wrong, params that have a default are correct, it's just ones
without.
--
___
Python tracker rep...@bugs.python.org
http
Zachary Ware added the comment:
Georg already opened an issue with a patch about providing a little more
information in unexpected exceptions, see issue20235.
--
nosy: +zach.ware
superseder: - Argument Clinic: support for simple expressions
Zachary Ware added the comment:
About cloning:
Cloned functions still expect their own impl function. In current winreg,
OpenKey and OpenKeyEx literally are the same function by two names; is the best
approach for this to define winreg_OpenKeyEx_impl as `return
winreg_OpenKey_impl(module
Zachary Ware added the comment:
The nested scope trick makes me happy. There are still a lot of cases in the
conversions I've worked on where a variable had to be renamed due to having
documented a different name for the parameter, but in the vast majority of
those cases the new name makes
Changes by Zachary Ware zachary.w...@gmail.com:
Added file: http://bugs.python.org/file33504/8cf882d09d3f.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20172
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20287
___
___
Python-bugs-list
Changes by Zachary Ware zachary.w...@gmail.com:
Removed file: http://bugs.python.org/file33411/issue20172.winreg.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20172
401 - 500 of 2723 matches
Mail list logo
