[issue20560] tkFileFilter.c: ostypeCount not initialized?

2014-04-22 Thread Zachary Ware
Zachary Ware added the comment: Terry, could you try this again with a fresh build of Tcl/Tk 8.5.15? Update your 2.7 to 2b8d9276ad5b or beyond and run Tools/buildbot/external.bat again, it should take care of it. -- nosy: +zach.ware ___ Python

[issue17160] test_urllib2net fails

2014-04-22 Thread Zachary Ware
Zachary Ware added the comment: This was already fixed, just not before 2.7.6 was released. -- nosy: +zach.ware status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17160

[issue17160] test_urllib2net fails

2014-04-22 Thread Zachary Ware
Zachary Ware added the comment: Actually, that's not quite right. It was fixed in 2.7.6, then changes to the website broke it again and it has been fixed again since then. Either way, it ain't broke right now ;) -- ___ Python tracker rep

[issue21335] Update importlib.__init__ to reset _frozen_importlib's loader to SourceFileLoader

2014-04-23 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- title: Update importlib.__init__ to reset _frozen_imnportlib's loader to SourceFileLoader - Update importlib.__init__ to reset _frozen_importlib's loader to SourceFileLoader ___ Python tracker rep

[issue17386] Bring Doc/make.bat as close to Doc/Makefile as possible

2014-04-23 Thread Zachary Ware
Zachary Ware added the comment: Having looked at this again, the current patch is just far bigger than it needs to be and tries to do too much, not to mention being rather out of date now. So, here's a much less ambitious, much simpler patch with many fewer ways it can go wrong (but also

[issue9764] Tools/buildbot/external.bat should download and built tix

2014-04-23 Thread Zachary Ware
Zachary Ware added the comment: This is fixed in 3.5, PCbuild/tix.vcxproj builds Tix in Debug and Release modes. -- nosy: +zach.ware resolution: - fixed stage: needs patch - resolved status: open - closed versions: +Python 3.5 -Python 3.2 ___ Python

[issue9765] tcl-8 vs tcl8

2014-04-23 Thread Zachary Ware
Zachary Ware added the comment: PCbuild/tix.vcxproj explicitly sets TCL_DIR and TK_DIR in the command line used to build Tix, using the paths used by the rest of the solution and the Tools/buildbot scripts; would the attached patch now be acceptable (for 3.5 only)? -- nosy

[issue9765] tcl-8 vs tcl8

2014-04-23 Thread Zachary Ware
Zachary Ware added the comment: Done, thanks! -- assignee: - zach.ware resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9765

[issue21337] Add tests for Tix

2014-04-23 Thread Zachary Ware
New submission from Zachary Ware: We should have some tests for Tix, which currently has none. The Windows buildbots will be able to run the tests, but Tix is not guaranteed to be available elsewhere. -- components: Tests, Tkinter keywords: easy messages: 217089 nosy: zach.ware

[issue21344] save scores or ratios in difflib get_close_matches

2014-04-24 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- stage: - patch review versions: -Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21344

[issue21344] save scores or ratios in difflib get_close_matches

2014-04-24 Thread Zachary Ware
Zachary Ware added the comment: Russell Ballestrini wrote: Determine if docstrings are enough to document the new function. No, Doc/library/difflib.rst will need an update. (Btw, I removed 2.7 from versions because 2.7 is not open to new features, bugs and security-critical enhancements only

[issue21346] typos in test_itertools.py

2014-04-24 Thread Zachary Ware
New submission from Zachary Ware: Fixed, thanks for the patch! changeset 90450:1beb3e0507fa 2.7 Issue #21346: Fix typos in test_itertools. Patch by Brian Kearns. changeset 90451:901b9afc918e 3.4 Issue #21346: Fix typo, make message consistent in test_itertools. Pointed out by Brian Kearns

[issue21349] crash in winreg SetValueEx with memoryview

2014-04-25 Thread Zachary Ware
New submission from Zachary Ware: The new test fails with the patch applied: == ERROR: test_setvalueex_with_memoryview (__main__.LocalWinregTests) -- Traceback

[issue21352] improve indexing

2014-04-25 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- versions: -Python 3.1, Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21352

[issue21314] Document '/' in signatures

2014-04-29 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- keywords: +easy stage: - needs patch status: - open type: - enhancement versions: +Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21314

[issue21402] tkinter.ttk._val_or_dict assumes tkinter._default_root exists

2014-04-30 Thread Zachary Ware
Zachary Ware added the comment: Can you provide an example of when this happens? Note that tkinter.ttk._val_or_dict is a private function and should not be called by user code. -- nosy: +gpolo, serhiy.storchaka, zach.ware stage: - test needed type: crash - behavior

[issue18604] Consolidate gui available checks in test.support

2014-04-30 Thread Zachary Ware
Zachary Ware added the comment: If there are no objections forthcoming, I'll try to get this applied to 3.4/3.5 later this week, then look into backporting to 2.7. -- assignee: - zach.ware components: +Tests, Tkinter versions: +Python 3.5 Added file: http://bugs.python.org/file35121

[issue19962] Create a 'python.bat' script to invoke interpreter from source root

2014-04-30 Thread Zachary Ware
Zachary Ware added the comment: Thanks for the up-vote, Tim :) -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19962

[issue21411] Enable Treat Warning as Error on 32-bit Windows

2014-05-01 Thread Zachary Ware
New submission from Zachary Ware: Python 3.4 and 3.5 both compile without warnings on 32-bit Windows, so we should turn on Treat Warning as Error (/WX option to cl.exe). Setting that property in pyproject.props sets it for all projects, and the setting does not affect Makefile projects so

[issue21439] Numerous minor issues in Language Reference

2014-05-05 Thread Zachary Ware
New submission from Zachary Ware: Reported by Feliks Kluzniak on docs@: Hello! I have been reading the Language Reference Manual in order to teach myself Python 3. I noticed several minor errors, and a much larger number of linguistic or editorial infelicities. I have listed them all

[issue21439] Numerous minor issues in Language Reference

2014-05-05 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- nosy: +docs@python ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21439 ___ ___ Python-bugs-list

[issue21366] Document that return in finally overwrites prev value

2014-05-05 Thread Zachary Ware
Zachary Ware added the comment: How's this, or is it too much? -- keywords: +patch nosy: +zach.ware Added file: http://bugs.python.org/file35154/issue21366.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21366

[issue21366] Document that return in finally overwrites prev value

2014-05-05 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- stage: - patch review type: behavior - enhancement versions: +Python 3.4, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21366

[issue18604] Consolidate gui available checks in test.support

2014-05-05 Thread Zachary Ware
Zachary Ware added the comment: Thanks Ned. Unfortunately, I don't have a Mac to test on, so I can't help much with figuring out what's going on. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18604

[issue18314] Have os.unlink remove junction points

2014-05-05 Thread Zachary Ware
Zachary Ware added the comment: Just skimming, I noticed something about replacing calloc() with PyMem_RawAlloc; note that there is now PyMem_Calloc or PyMem_RawCalloc that you should be able to use if you prefer. See #21233. -- nosy: +zach.ware

[issue21442] Win32 compiler warning in PyBytes_Concat

2014-05-05 Thread Zachary Ware
New submission from Zachary Ware: Issue #21377 introduced a compiler warning on Windows: ..\Objects\bytesobject.c(2824): warning C4018: '' : signed/unsigned mismatch [P:\ath\to\cpython\PCbuild\pythoncore.vcxproj] -- components: Build, Windows messages: 217942 nosy: haypo, nikratio

[issue21393] Python/random.c: close hCryptProv at exit

2014-05-05 Thread Zachary Ware
Zachary Ware added the comment: LGTM, Tim. -- nosy: +zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21393 ___ ___ Python-bugs-list

[issue21440] Use support.rmtree in test_zipfile

2014-05-05 Thread Zachary Ware
Zachary Ware added the comment: I don't see the intermittent failures (this machine may well just be too slow). The patch looks good and doesn't cause failures, though, so +1 from me. -- ___ Python tracker rep...@bugs.python.org http

[issue21442] Win32 compiler warning in PyBytes_Concat

2014-05-06 Thread Zachary Ware
Zachary Ware added the comment: Declaring oldsize as Py_ssize_t instead of size_t at Objects/bytesobject.c:2812 takes care of the warning, but I'm not comfortable saying that's a correct change. -- ___ Python tracker rep...@bugs.python.org http

[issue21442] Win32 compiler warning in PyBytes_Concat

2014-05-06 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- nosy: +tim.golden ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21442 ___ ___ Python-bugs-list

[issue21366] Document that return in finally overwrites prev value

2014-05-06 Thread Zachary Ware
Zachary Ware added the comment: Done. Thanks pointing out just how redundant that parenthetical was (I don't know how that slipped through my brain...), David. And thank you Jon for the report! -- resolution: - fixed stage: patch review - resolved status: open - closed versions

[issue21442] Win32 compiler warning in PyBytes_Concat

2014-05-06 Thread Zachary Ware
Zachary Ware added the comment: I should have looked a little harder, thanks Tim! -- assignee: - zach.ware resolution: - fixed stage: needs patch - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue10752] build_ssl.py is relying on unreliable behaviour of os.popen

2014-05-06 Thread Zachary Ware
Zachary Ware added the comment: Still relevant, insofar as having Perl available is relevant. That is, you only need Perl available if you're using vanilla OpenSSL sources, not if you're using sources pulled from svn.python.org (which most people should do, I would think). I have never had

[issue19643] shutil rmtree fails on readonly files in Windows

2014-05-06 Thread Zachary Ware
Zachary Ware added the comment: I'm good with just adding an example to the docs, along the lines of Paul's del_rw. I think it would be better to use a more conservative example though, something like: def readonly_handler(rm_func, path, exc_info): if issubclass(exc_info[0

[issue19643] shutil rmtree fails on readonly files in Windows

2014-05-07 Thread Zachary Ware
Zachary Ware added the comment: Fair point, Paul. Patch looks good to me, Tim, barring a couple of nits pointed out on Rietveld. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19643

[issue19643] shutil rmtree fails on readonly files in Windows

2014-05-07 Thread Zachary Ware
Zachary Ware added the comment: LGTM! -- stage: - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19643 ___ ___ Python-bugs-list

[issue18492] Allow all resources if not running under regrtest.py

2014-05-07 Thread Zachary Ware
Zachary Ware added the comment: Here's a new and better patch. This patch keeps the regrtest_run global in support and moves the regrtest-or-not check into is_resource_enabled to make is_resource_enabled, requires, and requires_resource consistent with each other and in a way that still

[issue21141] Don't mention Perl in Windows build output

2014-05-09 Thread Zachary Ware
Zachary Ware added the comment: Committed. Thanks for the review, Martin, and for the votes of confidence Tim and Antoine! -- assignee: - zach.ware resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep

[issue10752] build_ssl.py is relying on unreliable behaviour of os.popen

2014-05-09 Thread Zachary Ware
Zachary Ware added the comment: The patch looks good to me (only tested on a Perl-less machine, though). It applies cleanly on 3.4, which I think is worth committing. It still merges forward cleanly to default, post-#21141. I suspect it would even apply fairly cleanly to 2.7, but I'm

[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds

2014-05-09 Thread Zachary Ware
Zachary Ware added the comment: Here's all the patch that should be necessary to do the upgrade. Running test_ssl on 2.7 with 1.0.1g I do have a failure: == ERROR: test_socketserver (test.test_ssl.ThreadedTests) Using

[issue21452] make_buildinfo.exe with VS2013 fails due ill-formed IntDir path

2014-05-09 Thread Zachary Ware
Zachary Ware added the comment: Your patch looks fine to me, Tim. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21452 ___ ___ Python-bugs-list

[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds

2014-05-09 Thread Zachary Ware
Zachary Ware added the comment: Thanks, Steve. Nick, I assume 1.0.1g is the target version? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462

[issue21506] Windows MSI installer should mklink (symlink) python.exe to python2.7.exe

2014-05-14 Thread Zachary Ware
Zachary Ware added the comment: A similar thought I've had is to add a feature to the PEP397 launcher, allowing it to figure out Python version from a suffix on its executable name and add symlinks to it for each installed version of Python. That way PATH wouldn't need to be modified to make

[issue21534] 404 on documentation download links

2014-05-19 Thread Zachary Ware
New submission from Zachary Ware: docs@ has received several reports from people unable to download documentation from docs.python.org/[23]/download.html since the release of 3.4.1rc1 and 2.7.7rc1. -- assignee: docs@python components: Documentation messages: 218792 nosy

[issue20035] Clean up Tcl library discovery in Tkinter on Windows

2014-05-21 Thread Zachary Ware
Zachary Ware added the comment: Ping. I still want to get this in, but not without a proper review. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20035

[issue20035] Clean up Tcl library discovery in Tkinter on Windows

2014-05-22 Thread Zachary Ware
Zachary Ware added the comment: Thank you, Serhiy; those are exactly the kinds of things I don't know enough about and had concerns about. I'll take another stab and see if I can come up with anything better. Suggestions welcome :) -- ___ Python

[issue21534] 404 on documentation download links

2014-05-22 Thread Zachary Ware
Zachary Ware added the comment: Reports continue to pour in on docs@, 25 reports for 2.7.7rc1 and 3.4.1 so far by my count. Is there anything I can do to help on this? It looks to me like the files just haven't been uploaded, but I don't know where exactly they should be uploaded to, nor do

[issue21534] 404 on documentation download links

2014-05-22 Thread Zachary Ware
Zachary Ware added the comment: You're right, Ned; 3.4.1 is working for me now, but 2.7.7rc1 is still broken. (Sorry for not checking again!) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21534

[issue21439] Numerous minor issues in Language Reference

2014-05-27 Thread Zachary Ware
Zachary Ware added the comment: A few comments on the committed patch. The quoted diff is trimmed to just the hunks I have comments on. On Tue, May 27, 2014 at 12:21 AM, raymond.hettinger python-check...@python.org wrote: diff --git a/Doc/reference/compound_stmts.rst b/Doc/reference

[issue21439] Numerous minor issues in Language Reference

2014-05-27 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- stage: test needed - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21439

[issue11468] Improve unittest basic example in the doc

2014-05-27 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- nosy: +zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11468 ___ ___ Python-bugs-list

[issue21592] Make statistics.median run in linear time

2014-05-28 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- nosy: +steven.daprano stage: - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21592

[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds

2014-05-29 Thread Zachary Ware
Zachary Ware added the comment: Steve or Tim, did one of you want to commit this since you can run a clean test? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462

[issue14097] Improve the introduction page of the tutorial

2014-05-29 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- nosy: +zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14097 ___ ___ Python-bugs-list

[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds

2014-05-30 Thread Zachary Ware
Zachary Ware added the comment: Go ahead and commit; it will be up to Benjamin to cherry-pick it to his release branch (or to ask you to do it). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462

[issue14097] Improve the introduction page of the tutorial

2014-05-30 Thread Zachary Ware
Zachary Ware added the comment: How's this for a 2.7 backport? The least direct part of the backport is the section on division; I pretty much had to completely rewrite the paragraph in 2.x terms and I'm not certain that I took the best approach. -- stage: commit review - patch

[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds

2014-05-30 Thread Zachary Ware
Zachary Ware added the comment: Looks like the AMD64 buildbot isn't happy with OpenSSL 1.0.1g: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%202.7/builds/1223/steps/compile/logs/stdio Here's my best stab-in-the-dark guess at fixing what's wrong; I don't have the ability

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

2014-06-02 Thread Zachary Ware
Zachary Ware added the comment: As for what's actually wrong here, Hirokazu Yamamoto's diagnosis in msg123615 (adjusted for 2.7) is correct. Either of the last two patches I posted should work to fix this issue, but they're both just band-aids rather than a real, once-and-for-all fix. #20035

[issue21623] build ssl failed use vs2010 express

2014-06-02 Thread Zachary Ware
Zachary Ware added the comment: The first error makes no sense to me. What version of OpenSSL are you building? How did you invoke the Python build (command line, or through the VS GUI)? As for the second error, all of the VS-generated files in PCbuild have a UTF-8 BOM, which is what

[issue21623] build ssl failed use vs2010 express

2014-06-02 Thread Zachary Ware
Zachary Ware added the comment: The cause of the second error should be fixed now. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21623

[issue21623] build ssl failed use vs2010 express

2014-06-02 Thread Zachary Ware
Zachary Ware added the comment: I will note that VC++ 2010 Express is what I use on one of my usual machines, and don't recall ever having this issue. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21623

[issue21533] built-in types dict docs - construct dict from iterable, not iterator

2014-06-02 Thread Zachary Ware
Zachary Ware added the comment: LGTM. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21533 ___ ___ Python-bugs-list mailing list Unsubscribe

[issue18492] Allow all resources if not running under regrtest.py

2014-06-02 Thread Zachary Ware
Zachary Ware added the comment: You convinced me too, Serhiy :). Committed, without the regrtest_run flag. Thanks for review. -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org

[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds

2014-06-02 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- stage: - resolved ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ ___ Python-bugs-list

[issue21427] installer not working

2014-06-03 Thread Zachary Ware
Zachary Ware added the comment: Nosy-ing the Windows installer experts; I haven't had any problems with this and am not familiar with the MSI library or tool. -- nosy: +loewis, steve.dower ___ Python tracker rep...@bugs.python.org http

[issue21427] installer not working

2014-06-03 Thread Zachary Ware
Zachary Ware added the comment: Martin v. Löwis wrote: I never got to test this out of lack of a 32-bit Windows installation, apparently, it doesn't work. It does work on my 32-bit machine, though; I have had no issues installing 32-bit Python 3.3 or 3.4 on 32-bit Windows 7 Pro. If there's

[issue19980] Improve help('non-topic') response

2014-06-03 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- nosy: +zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19980 ___ ___ Python-bugs-list

[issue21623] build ssl failed use vs2010 express

2014-06-03 Thread Zachary Ware
Zachary Ware added the comment: Mo Jia wrote: @Zachary Ware , don't change anything after clone from the repo. What i do is just cd python src dir and runing : Tools\buildbot\build.bat . the openssl verison is 1.0.1g . Seem the external.bat don't build openssl . I see the readme

[issue21344] save scores or ratios in difflib get_close_matches

2014-06-03 Thread Zachary Ware
Zachary Ware added the comment: Absent Tim's satisfaction regarding a use-case, I'm closing the issue. Russell, if you do package this up for pypi and it does become popular (for some definition of 'popular' :), feel free to reopen this issue or open a new one. -- resolution

[issue21427] installer not working

2014-06-03 Thread Zachary Ware
Zachary Ware added the comment: Here's the log, and some notes: Starting state: - Python 3.3.5 installed to P:\Python33 - Python 3.4.1 installed to P:\Python34 - py[w].exe present in C:\Windows State after Python 3.4.1 uninstalled by python-3.4.1.msi (and manually removed P:\Python34 which

[issue21416] argparse should accept bytes arguments as originally passed

2014-06-03 Thread Zachary Ware
Zachary Ware added the comment: The type parameter of ArgumentParser is a callable that will be called with the value of some member of sys.argv, it does *not* specify what the returned type will be. You can just use os.fsencode as the type argument: import os import argparse p

[issue21665] 2.7.7 ttk widgets not themed

2014-06-05 Thread Zachary Ware
Zachary Ware added the comment: I can confirm this on the current 2.7 branch and, oddly, on a fresh build of v2.7.6. This looks like it was caused by the way Tcl/Tk was compiled, specifically the 'COMPILERFLAGS=-DWINVER=0x0500' and 'OPTS=noxp' options which are supposed to be for Win2k

[issue21671] CVE-2014-0224: OpenSSL upgrade to 1.0.1h on Windows required

2014-06-05 Thread Zachary Ware
Zachary Ware added the comment: 2.7, 3.4, and default should be updated; should we do anything for 3.1-3.3 since they will not get any further installers? -- nosy: +loewis, steve.dower, zach.ware ___ Python tracker rep...@bugs.python.org http

[issue21661] setuptools documentation: typo

2014-06-05 Thread Zachary Ware
Zachary Ware added the comment: Thanks for the report and patch! -- nosy: +zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21661

[issue18292] Idle: test AutoExpand.py

2014-06-05 Thread Zachary Ware
Zachary Ware added the comment: Terry J. Reedy added the comment: Whoops. Zach, did you catch that by reading the checkin, running the test, or seeing a buildbot problem. Is not the first, what symptom on what system revealed the omission? Buildbots; there were several red 2.7 bots and I

[issue21665] 2.7.7 ttk widgets not themed

2014-06-05 Thread Zachary Ware
Zachary Ware added the comment: Are you sure you didn't swap that; OPTS=noxp for Tk and no OPTS for the other two? OPTS=noxp would do nothing for Tcl and Tix (and might cause errors, I'm not sure), and not giving OPTS=noxp along with WINVER=0x0500 would definitely have caused an error

[issue21682] Refleak in idle_test test_autocomplete

2014-06-06 Thread Zachary Ware
New submission from Zachary Ware: The recently added test_autocomplete seems to be hanging onto a reference somewhere that it shouldn't be, see below. This output was obtained by running `python -m test -R :: -uall test_idle`. I tracked it down to test_autocomplete with hg bisect

[issue21665] 2.7.7 ttk widgets not themed

2014-06-06 Thread Zachary Ware
Zachary Ware added the comment: Tix was finally added to the pcbuild solution for 3.5 a couple months ago, until that point it was never built on the buildbots. If my understanding of history is correct, build_tkinter.py has never been used regularly, but was an initial push towards building

[issue21683] Add Tix to the Windows buildbot scripts

2014-06-06 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- assignee: zach.ware components: Build, Tkinter, Windows nosy: steve.dower, zach.ware priority: normal severity: normal stage: needs patch status: open title: Add Tix to the Windows buildbot scripts versions: Python 2.7, Python 3.4

[issue18910] IDle: test textView.py

2014-06-08 Thread Zachary Ware
Zachary Ware added the comment: The changeset Benjamin backed out is pretty much fine, just needs the requires('gui') to be at the top of setUpModule instead of at toplevel. That does mean the whole module is constructed and then thrown away without doing anything, but it at least runs

[issue21682] Refleak in idle_test test_autocomplete

2014-06-08 Thread Zachary Ware
Zachary Ware added the comment: Terry, did you mean to push Saimadhav's patch? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21682

[issue21671] CVE-2014-0224: OpenSSL upgrade to 1.0.1h on Windows required

2014-06-08 Thread Zachary Ware
Zachary Ware added the comment: So installers are out for 3.1-3.3; should we still update the externals script and pyproject properties for those branches anyway? If not, this issue should be ready to close. -- stage: - commit review status: open - pending type: - security

[issue21671] CVE-2014-0224: OpenSSL upgrade to 1.0.1h on Windows required

2014-06-08 Thread Zachary Ware
Zachary Ware added the comment: Good enough for me. -- resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21671

[issue21683] Add Tix to the Windows buildbot scripts

2014-06-08 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file35538/issue21683.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21683

[issue21683] Add Tix to the Windows buildbot scripts

2014-06-08 Thread Zachary Ware
Zachary Ware added the comment: Tix should be built on the 2.7 and 3.4 buildbots now; it already has been on 3.x. -- resolution: - fixed stage: needs patch - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http

[issue21688] Improved error msg for make.bat htmlhelp

2014-06-09 Thread Zachary Ware
Zachary Ware added the comment: Could you give me the exact message you get currently? If it's just 'C:\Program' is not recognized as an internal or external command, operable program or batch file., that's a different issue than if the whole path to hhc.exe is displayed. Otherwise, I like

[issue21706] Add base for enumerations (Functional API)

2014-06-10 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- nosy: +barry, eli.bendersky, ethan.furman ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21706

[issue21688] Improved error msg for make.bat htmlhelp

2014-06-10 Thread Zachary Ware
Zachary Ware added the comment: Fixed! I tweaked the message a bit and added errorlevel setting before committing. Thanks for the report and patch! -- assignee: - zach.ware resolution: - fixed stage: - resolved status: open - closed versions: +Python 3.4

[issue20035] Clean up Tcl library discovery in Tkinter on Windows

2014-06-10 Thread Zachary Ware
Zachary Ware added the comment: Ok, here's another attempt which should address both points you raised, Serhiy. I don't have an East-Asian Windows install to test on (and wouldn't be able to read anything to do the test, anyway!), but I did test with a prefix containing East-Asian characters

[issue21711] Remove site-python support

2014-06-11 Thread Zachary Ware
Zachary Ware added the comment: Seems fine on Windows (especially since it doesn't look like site-python ever meant anything on Windows in the first place)! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21711

[issue21727] Ambiguous sentence explaining `cycle` in itertools documentation

2014-06-11 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- nosy: +rhettinger versions: -Python 3.1, Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21727

[issue21713] a mistype comment in PC/pyconfig.h

2014-06-11 Thread Zachary Ware
Zachary Ware added the comment: Fixed, thanks for the report! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21713 ___ ___ Python-bugs-list

[issue21713] a mistype comment in PC/pyconfig.h

2014-06-11 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- assignee: - zach.ware type: compile error - enhancement versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21713

[issue21741] Convert most of the test suite to using unittest.main()

2014-06-12 Thread Zachary Ware
New submission from Zachary Ware: Attached is a quick-and-dirty script that converts a large chunk of the test suite away from support.run_unittest and test_main to unittest test discovery and unittest.main. Several files are marked as 'do not touch' due to various issues that the script

[issue21741] Convert most of the test suite to using unittest.main()

2014-06-13 Thread Zachary Ware
Zachary Ware added the comment: Here's a diff against 3.4 produced by the script. Warning: it's rather large. $ hg diff --stat [...] 162 files changed, 199 insertions(+), 942 deletions(-) -- keywords: +patch Added file: http://bugs.python.org/file35616/issue21741.diff

[issue21745] Devguide: mention requirement to install Visual Studio SP1 on Windows

2014-06-13 Thread Zachary Ware
Zachary Ware added the comment: Fixed, thanks for the patch! -- assignee: docs@python - zach.ware resolution: - fixed stage: - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21745

[issue21745] Devguide: mention requirement to install Visual Studio SP1 on Windows

2014-06-13 Thread Zachary Ware
Zachary Ware added the comment: I'm not sure; I expect your change to be live within a day, probably sooner. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21745

[issue21719] Returning Windows file attribute information via os.stat()

2014-06-13 Thread Zachary Ware
Zachary Ware added the comment: Not sure what you were going for on the version, Jim; you added 3.4, but this is a new feature for 3.5. -- versions: -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21719

[issue19493] Report skipped ctypes tests as skipped

2014-06-13 Thread Zachary Ware
Zachary Ware added the comment: Committed; thanks for the review, Serhiy. -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19493

[issue21719] Returning Windows file attribute information via os.stat()

2014-06-13 Thread Zachary Ware
Zachary Ware added the comment: Ben Hoyt wrote: I'm replying to the code review here as when I tried to reply on bugs.python.org/review I got a Python exception, AttributeError: NoneType has no attribute something or other. Generally when you get that you can just hit back and try again

<    3   4   5   6   7   8   9   10   11   12   >