hai shi added the comment:
> You always can use PyObject_CallMethod(). It is not a method called in tight
> loop for which the overhead of calling method is significant.
Thanks, serhiy. You are right.
To PR19069, it's fine to use `PyList_SetSlice` or `PyObject_CallMethod`.
We don
New submission from hai shi :
Do we need add PyList_Remove() in C level? same thing like list.remove().
As victor comment in:
https://github.com/python/cpython/pull/19069#discussion_r491893466.
--
components: C API
messages: 377566
nosy: shihai1991, vstinner
priority: normal
severity
Change by hai shi :
--
keywords: +patch
nosy: +shihai1991
nosy_count: 3.0 -> 4.0
pull_requests: +21424
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22360
___
Python tracker
<https://bugs.python.org/i
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41832>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +21401
pull_request: https://github.com/python/cpython/pull/22360
___
Python tracker
<https://bugs.python.org/issue39
hai shi added the comment:
Hi, petr. Can you help me merge this PR to 3.9 too?
--
___
Python tracker
<https://bugs.python.org/issue41726>
___
___
Python-bug
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41797>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41798>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40288>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +21274
pull_request: https://github.com/python/cpython/pull/22219
___
Python tracker
<https://bugs.python.org/issue39
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41736>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41739>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
title: Update the refcounts.dat of `PyType_FromModuleAndSpec` -> Update
refcounts info of PyType_FromModuleAndSpec in refcounts.dat
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
keywords: +patch
pull_requests: +21196
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22112
___
Python tracker
<https://bugs.python.org/issu
New submission from hai shi :
`PyType_FromModuleAndSpec` in docs doesn't show the info:`Return value: New
reference.`
--
assignee: docs@python
components: Documentation
messages: 376432
nosy: docs@python, petr.viktorin, shihai1991
priority: normal
severity: normal
status: open
hai shi added the comment:
+1
--
___
Python tracker
<https://bugs.python.org/issue41692>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.pyth
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41713>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41692>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
Hm, Looks like we need check the double free risk of `Py_DECREF()`.
--
___
Python tracker
<https://bugs.python.org/issue41
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41654>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41625>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41631>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
keywords: +patch
pull_requests: +21058
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21948
___
Python tracker
<https://bugs.python.org/issu
New submission from hai shi :
After the EOL of python2, the shebang of tools should be ported from python2 to
python3.
some files like:
https://github.com/python/cpython/blob/master/Objects/typeslots.py#L1
--
messages: 375855
nosy: shihai1991
priority: normal
severity: normal
status
hai shi added the comment:
related bpo: bpo-41073
--
___
Python tracker
<https://bugs.python.org/issue41618>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from hai shi :
In order to resolve bpo41073, we want to extend `PyType_GetSlot()` to accept
static types. But there have another question we should be considered: How many
slots should be exposed in `PyType_GetSlot()`.
petr's opinion from PR-21931:I would not want to e
Change by hai shi :
--
pull_requests: +21044
pull_request: https://github.com/python/cpython/pull/21931
___
Python tracker
<https://bugs.python.org/issue41
Change by hai shi :
--
pull_requests: +21022
pull_request: https://github.com/python/cpython/pull/21902
___
Python tracker
<https://bugs.python.org/issue1635
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41551>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +21015
pull_request: https://github.com/python/cpython/pull/21896
___
Python tracker
<https://bugs.python.org/issue1635
hai shi added the comment:
oh, sorry, missing a word: I suggest this bpo.->I suggest close this bpo.
--
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
If someone wants to continue the effort in libregrtest, I suggest to open a new
issue.
+1. And if there have any other test cases blocked by test.support, I suggest
this bpo.
--
___
Python tracker
<ht
hai shi added the comment:
> Py_Finalize() calls _PyUnicode_ClearInterned() which clears interned strings.
> Which strings are still alive after Py_Finalize()?
Yes.especially those encodings, interpreter leaks much encodings refcount after
Py_Finalize(). I am not sure they are corner
Change by hai shi :
--
nosy: +paul.j3, rhettinger
___
Python tracker
<https://bugs.python.org/issue41534>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
There will have many unicode strs releaks when we calling `Py_Initialize()`
again after `Py_Finalize()`: interned will be cleared in `Py_Finalize()`, but
those unicodes str will still alive all the time.
Q: How to solve the probleam?
A: MAYBE we need share the
hai shi added the comment:
Hi, victor:
About https://bugs.python.org/issue40275#msg369214, shall we continue to
improve the libregretest?
1. Running test cases sequential: you have use a mechanism to unload the
modules which load in the running test cases stage:
https://github.com/python
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40949>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +20944
pull_request: https://github.com/python/cpython/pull/21811
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
> Hai Shi: Would you mind to investigate this issue?
Oh, sure, I will check the test cases again.
--
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
# Confusing, especially now that PR #s are catching up to issue #s.
Maybe we need redefine the matching rule(I am not sure about it).
--
versions: +Python 3.10 -Python 3.9
___
Python tracker
<https://bugs.python.
hai shi added the comment:
Hi, terry. When creating the new test helpers, the docs have been updated.
such as:
https://docs.python.org/3.10/library/test.html#module-test.support.os_helper
--
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20927
pull_request: https://github.com/python/cpython/pull/21785
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20922
pull_request: https://github.com/python/cpython/pull/21771
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20917
pull_request: https://github.com/python/cpython/pull/21772
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20908
pull_request: https://github.com/python/cpython/pull/21764
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20895
pull_request: https://github.com/python/cpython/pull/21743
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20870
pull_request: https://github.com/python/cpython/pull/21727
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
>I haven't checked to see what's documented. I'm sure we'd accept a patch that
>improves the documentation if it's lacking.
+1
--
nosy: +shihai1991
___
Python tracker
<
hai shi added the comment:
What's change for the performance benchmark?
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41340>
___
___
Change by hai shi :
--
pull_requests: +20746
pull_request: https://github.com/python/cpython/pull/21605
___
Python tracker
<https://bugs.python.org/issue1635
Change by hai shi :
--
pull_requests: +20600
pull_request: https://github.com/python/cpython/pull/21452
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20599
pull_request: https://github.com/python/cpython/pull/21451
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20598
pull_request: https://github.com/python/cpython/pull/21450
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20597
pull_request: https://github.com/python/cpython/pull/21449
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20596
pull_request: https://github.com/python/cpython/pull/21448
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20561
pull_request: https://github.com/python/cpython/pull/21412
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
keywords: +patch
pull_requests: +20543
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21395
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
pull_requests: +20470
pull_request: https://github.com/python/cpython/pull/21317
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20467
pull_request: https://github.com/python/cpython/pull/21315
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20466
pull_request: https://github.com/python/cpython/pull/21314
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
> You'll probably need some table like typeslots.inc to record which sub-slots
> struct each slot belongs to.
Looks like it's a good way to solve this probleam, Let me try it ;)
--
___
Python
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue38980>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
> bpo-17162 added PyType_GetSlot(), but static types were not discussed there.
Thanks to correct my info. I paste this bpo just Larry have mentioned the
static type in PyType_GetSlot() :)
--
___
Python tracker
<
Change by hai shi :
--
pull_requests: +20371
pull_request: https://github.com/python/cpython/pull/21219
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
I create a PR in: https://github.com/shihai1991/cpython/pull/13/commits.
Looks like It works.
If we extend PyType_GetSlot() to accept non-heaptype, we need find a way to
judge the max slot of non-heaptype.
--
___
Python
hai shi added the comment:
historical discuss: bpo17162
--
___
Python tracker
<https://bugs.python.org/issue41073>
___
___
Python-bugs-list mailing list
Unsub
Change by hai shi :
--
pull_requests: +20328
pull_request: https://github.com/python/cpython/pull/21169
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
nosy: +shihai1991
nosy_count: 5.0 -> 6.0
pull_requests: +20327
pull_request: https://github.com/python/cpython/pull/21169
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
> My PR of bpo-40799 fix this issue.
Thanks victor for your work, I closed my PR ;)
--
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
> Python 2 is EOL, so I think this issue should be closed.
+1, if someone need create a PR, we can reopen it again.
--
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
pull_requests: +20325
pull_request: https://github.com/python/cpython/pull/21167
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue4>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40799>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +20310
pull_request: https://github.com/python/cpython/pull/21151
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20253
pull_request: https://github.com/python/cpython/pull/21087
___
Python tracker
<https://bugs.python.org/issue1635
hai shi added the comment:
Hi, victor. If you have much bpo need to manage, I could take a look in this
week :)
--
___
Python tracker
<https://bugs.python.org/issue41
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41073>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue1944>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41034>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41036>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +20135
pull_request: https://github.com/python/cpython/pull/20957
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41006>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue36346>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40987>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
> Coverage jobs are still run with my changes.
> https://codecov.io/gh/python/cpython is still updated.
Copy that, thanks.
--
___
Python tracker
<https://bugs.python.org/i
hai shi added the comment:
> Attached PR skips these jobs on pull requests.
I am not familiar with travis ci. coverage jobs can tell us how many features
need add unit tests. Can we use other CI services to do this job? MAYBE in
checks gate or something other services l
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40993>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
Thanks for your report. I am not catch this segfault in my python compiler. I
test your example in:
Python 3.8.3 (v3.8.3:6f8c832)
Python 3.9.0b3 (v3.9.0b3-dirty:b484871)
Python 3.10.0a0 (heads/master-dirty:1c209e3)
--
nosy: +shihai1991
Change by hai shi :
--
nosy: +shihai1991
nosy_count: 12.0 -> 13.0
pull_requests: +20067
pull_request: https://github.com/python/cpython/pull/20824
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
LGTM. It's a lightweight patch :)
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue37910>
___
___
Pytho
hai shi added the comment:
Thanks, Dong-hee Na.
--
___
Python tracker
<https://bugs.python.org/issue40966>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
keywords: +patch
pull_requests: +20043
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/20850
___
Python tracker
<https://bugs.python.org/issu
New submission from hai shi :
Looks like `classname` in PyErr_NewException() is redundant:
https://github.com/python/cpython/blob/master/Python/errors.c#L1082
--
components: Interpreter Core
messages: 371438
nosy: shihai1991
priority: normal
severity: normal
status: open
title: Remove
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40925>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +20042
pull_request: https://github.com/python/cpython/pull/20849
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20019
pull_request: https://github.com/python/cpython/pull/20824
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
I propose to start updating tests to use directly support.import_helper and
support.os_helper. Hai: do you want to work on that? Maybe start by focusing on
import_helper (but if you modify a test, check for also symbols imported from
os_helper).
> of course
Change by hai shi :
--
pull_requests: +19993
pull_request: https://github.com/python/cpython/pull/20797
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +19990
pull_request: https://github.com/python/cpython/pull/20794
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +19964
pull_request: https://github.com/python/cpython/pull/20765
___
Python tracker
<https://bugs.python.org/issue40
201 - 300 of 700 matches
Mail list logo