[issue23895] [PATCH] python socket module fails to build on Solaris when -zignore is in LDFLAGS
Changes by Andrew Stormont : -- title: python socket module fails to build on Solaris when -zignore is in LDFLAGS -> [PATCH] python socket module fails to build on Solaris when -zignore is in LDFLAGS ___ Python tracker <http://bugs.python.org/issue23895> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23895] python socket module fails to build on Solaris when -zignore is in LDFLAGS
Andrew Stormont added the comment: Bump. -- status: open -> languishing ___ Python tracker <http://bugs.python.org/issue23895> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23895] python socket module fails to build on Solaris when -zignore is in LDFLAGS
Andrew Stormont added the comment: Bump. -- ___ Python tracker <http://bugs.python.org/issue23895> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23895] python socket module fails to build on Solaris when -zignore is in LDFLAGS
Andrew Stormont added the comment: The -z ignore option is actually exposing issues that could cause a problem at runtime. If the socket module were imported and libsocket/libnsl hadn't already been loaded (i.e pulled in by the loader as a dependency of another module) the loader would fail due to unresolved symbols. This problem would not effect Linux because all of the socket stuff is in libc, which is not the case on Solaris. Today it doesn't cause a problem because most other things are already pulling in libsocket and libnsl before the socket module is loaded, but there's no guarantee that will always be the case. For the sake of correctness it should be fixed, and I would suggest later making -z ignore the default on Solaris. I will see if I can find somebody else to review the patch. -- ___ Python tracker <http://bugs.python.org/issue23895> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23895] PATCH: python socket module fails to build on Solaris when -zignore is in LDFLAGS
Andrew Stormont added the comment: Bump. Would be nice to get this included in python 2.7.11. I also have a similar fix for the multiprocessing module but I won't bother submitting it if it will get ignored. -- status: open -> languishing ___ Python tracker <http://bugs.python.org/issue23895> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23895] PATCH: python socket module fails to build on Solaris when -zignore is in LDFLAGS
New submission from Andrew Stormont: The socket module fails to build when -zignore is in LDFLAGS. This option changes the linker behaviour so it will only resolve against the libraries linked in explicitly instead of doing resolution recursively against their dependencies too. -- components: Build files: solaris-socket-zignore.diff keywords: patch messages: 240325 nosy: andy_js priority: normal severity: normal status: open title: PATCH: python socket module fails to build on Solaris when -zignore is in LDFLAGS type: compile error versions: Python 2.7 Added file: http://bugs.python.org/file38877/solaris-socket-zignore.diff ___ Python tracker <http://bugs.python.org/issue23895> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17925] asynchat.async_chat.initiate_send : del deque[0] is not safe
Andrew Stormont added the comment: I think you mean: self.producer_fifo.extendleft([data, first]) Instead of: self.producer_fifo.extendleft([first, data]) No? -- ___ Python tracker <http://bugs.python.org/issue17925> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17925] asynchat.async_chat.initiate_send : del deque[0] is not safe
Andrew Stormont added the comment: Great. Everybody's happy now, surely? -- ___ Python tracker <http://bugs.python.org/issue17925> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17925] asynchat.async_chat.initiate_send : del deque[0] is not safe
Andrew Stormont added the comment: What about changing: self.producer_fifo.appendleft(first) self.producer_fifo.appendleft(data) To self.producer_fifo.extendleft([data, first]) Assuming deque's extendleft is actually thread safe. -- ___ Python tracker <http://bugs.python.org/issue17925> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17925] asynchat.async_chat.initiate_send : del deque[0] is not safe
Andrew Stormont added the comment: Looks like a reasonable fix to me. What needs to be done to get this integrated? -- nosy: +andy_js ___ Python tracker <http://bugs.python.org/issue17925> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
