[issue41756] Do not always use exceptions to return result from coroutine

2021-05-05 Thread Andrew Svetlov
Change by Andrew Svetlov : -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue41756> ___ ___ Pyth

[issue44011] Borrow asyncio ssl implementation from uvloop

2021-05-03 Thread Andrew Svetlov
Change by Andrew Svetlov : -- pull_requests: +24529 pull_request: https://github.com/python/cpython/pull/25846 ___ Python tracker <https://bugs.python.org/issue44

[issue44011] Borrow asyncio ssl implementation from uvloop

2021-05-03 Thread Andrew Svetlov
Change by Andrew Svetlov : -- pull_requests: +24526 pull_request: https://github.com/python/cpython/pull/25842 ___ Python tracker <https://bugs.python.org/issue44

[issue44011] Borrow asyncio ssl implementation from uvloop

2021-05-02 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset 5fb06edbbb769561e245d0fe13002bab50e2ae60 by Andrew Svetlov in branch 'master': bpo-44011: New asyncio ssl implementation (#17975) https://github.com/python/cpython/commit/5fb06edbbb769561e245d0fe13002bab50e2ae60

[issue44011] Borrow asyncio ssl implementation from uvloop

2021-05-02 Thread Andrew Svetlov
Change by Andrew Svetlov : -- keywords: +patch pull_requests: +24507 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17975 ___ Python tracker <https://bugs.python.org/issu

[issue44011] Borrow asyncio ssl implementation from uvloop

2021-05-02 Thread Andrew Svetlov
New submission from Andrew Svetlov : There is a PR created a long time ago. Finally, I've ported tests for it also. The documentation doesn't mention new ssh_shutdown_timeout parameter yet. The latest changes from https://github.com/MagicStack/uvloop/pull/385 can be applied separately

[issue37179] asyncio loop.start_tls() provide support for TLS in TLS

2021-04-13 Thread Andrew Svetlov
Andrew Svetlov added the comment: Thanks for the reminder. You are correct, the mentioned PR should set _SSLProtocolTransport._start_tls_compatible to True -- ___ Python tracker <https://bugs.python.org/issue37

[issue43736] asyncio create_task() odd behavior

2021-04-06 Thread Andrew Svetlov
Andrew Svetlov added the comment: 1. Please consider `await` as a 'yield point': the point where the current task may be suspended to get other tasks a chance to be executed. It can be any `await`, not necessarily waiting for a task. Just a point where asyncio event loop gives a chance

[issue42703] Asyncio Event Documentation Links Incorrect

2020-12-23 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue42703] Asyncio Event Documentation Links Incorrect

2020-12-23 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset d90ff376813843310a6f9ccc96551fa1521e8fef by Matt Fowler in branch 'master': BPO-42703: Fix incorrect documentation links for asyncio.Event (GH-23881) https://github.com/python/cpython/commit/d90ff376813843310a6f9ccc96551fa1521e8fef

[issue42682] awaiting a wrapped asyncio.Task multiple times gives long, repeative tracebacks

2020-12-23 Thread Andrew Svetlov
Andrew Svetlov added the comment: The traceback contains frames from asyncio internal machinery, that's why the traceback is long. IFIAK Python standard library never filters such calls, asyncio is not an exception. On the other hand, well-known pytest library supports `__tracebackhide__

[issue31904] Python should support VxWorks RTOS

2020-12-17 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset ba760f3710eccdfae2b680a5f94fe0160ddb1536 by pxinwr in branch 'master': bpo-31904: Skip some asyncio tests on VxWorks (#23815) https://github.com/python/cpython/commit/ba760f3710eccdfae2b680a5f94fe0160ddb1536 -- nosy: +asvetlov

[issue38323] asyncio: MultiLoopWatcher has a race condition (test_asyncio: test_close_kill_running() hangs on AMD64 RHEL7 Refleaks 3.x)

2020-12-16 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset 66d3b589c44fcbcf9afe1e442d9beac3bd8bcd34 by Chris Jerdonek in branch 'master': bpo-38323: Add guard clauses in MultiLoopChildWatcher. (#22756) https://github.com/python/cpython/commit/66d3b589c44fcbcf9afe1e442d9beac3bd8bcd34

[issue42644] logging.disable('WARN') breaks AsyncIO

2020-12-16 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.7 ___ Python tracker <https://bugs.python.or

[issue42644] logging.disable('WARN') breaks AsyncIO

2020-12-16 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset b32d8b4f9bcd2e7d11240b6b9de0262cf8f5e09d by Matthias Bussonnier in branch 'master': bpo-42644: Validate values in logging.disable() (#23786) https://github.com/python/cpython/commit/b32d8b4f9bcd2e7d11240b6b9de0262cf8f5e09d

[issue42644] logging.disable('WARN') breaks AsyncIO

2020-12-16 Thread Andrew Svetlov
Change by Andrew Svetlov : -- type: crash -> behavior ___ Python tracker <https://bugs.python.org/issue42644> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue42644] logging.disable('WARN') breaks AsyncIO

2020-12-16 Thread Andrew Svetlov
Change by Andrew Svetlov : -- components: +Library (Lib) -asyncio ___ Python tracker <https://bugs.python.org/issue42644> ___ ___ Python-bugs-list mailin

[issue42644] logging.disable('WARN') breaks AsyncIO

2020-12-15 Thread Andrew Svetlov
Andrew Svetlov added the comment: Reporting what? Please elaborate. -- ___ Python tracker <https://bugs.python.org/issue42644> ___ ___ Python-bugs-list mailin

[issue42636] shielded task exception never retrieved when outer task cancelled

2020-12-14 Thread Andrew Svetlov
Andrew Svetlov added the comment: Thanks for the report. I didn't test but looks like `outer.exception()` call can suppress the message about not retrieved exception. -- ___ Python tracker <https://bugs.python.org/issue42

[issue42306] wrong exception handling in case asyncio.shiled usage

2020-12-14 Thread Andrew Svetlov
Andrew Svetlov added the comment: Sorry, this issue is not reproduced on 3.8-3.9, 3.7 is in security mode. The issue doesn't belong to the security set. Closing. -- resolution: -> out of date stage: -> resolved status: open -> closed _

[issue26582] asyncio documentation links to wrong CancelledError

2020-12-04 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue26582] asyncio documentation links to wrong CancelledError

2020-12-04 Thread Andrew Svetlov
Andrew Svetlov added the comment: Moreover, the issue is outdated. asyncio.CancelledError is not an alias of concurrent.futures.CancelledError starting from Python 3.8 Unfortunately, we should make this not 100% backward compatible change. -- nosy: +asvetlov

[issue42538] AsyncIO strange behaviour

2020-12-02 Thread Andrew Svetlov
Andrew Svetlov added the comment: I understand the issue as the following: 1. You don't save the result of `asyncio.create_task()` somewhere. The task object is dereferenced and thus you see a warning. 2. With PYTHONASYNCIODEBUG on the task is referenced also by internal debug structure

[issue42526] Exceptions in asyncio.Server callbacks are not retrievable

2020-12-01 Thread Andrew Svetlov
Andrew Svetlov added the comment: You can use try/except in handler() and dispatch the exception whatever you want. It doesn't require a new asyncio version, debug-only flag, etc. -- ___ Python tracker <https://bugs.python.org/issue42

[issue40800] asyncio.sleep(0) should "yield" back to the event loop, but it doesn't behave as expected

2020-12-01 Thread Andrew Svetlov
Andrew Svetlov added the comment: Agree, not a bug. -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue42526] Exceptions in asyncio.Server callbacks are not retrievable

2020-12-01 Thread Andrew Svetlov
Andrew Svetlov added the comment: This is a deliberate decision. An exception in handling one client connection should not break another connected client. -- ___ Python tracker <https://bugs.python.org/issue42

[issue42392] remove the deprecated 'loop' parameter asyncio API

2020-11-30 Thread Andrew Svetlov
Andrew Svetlov added the comment: Thanks for your help! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue42392] remove the deprecated 'loop' parameter asyncio API

2020-11-29 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset 86150d39c888579b65841f4391d054b7b3eff9f2 by Yurii Karabas in branch 'master': bpo-42392: Remove deprecated loop parameter from docs (GH-23552) https://github.com/python/cpython/commit/86150d39c888579b65841f4391d054b7b3eff9f2

[issue41879] Outdated description of async iterables in documentation of async for statement

2020-11-28 Thread Andrew Svetlov
Andrew Svetlov added the comment: You are right. -- ___ Python tracker <https://bugs.python.org/issue41879> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41818] Lib/pty.py major revision

2020-11-28 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset 74311aeb45b52cc145d27d9fca99f01874d6882d by Soumendra Ganguly in branch 'master': bpo-41818: Fix test_master_read() so that it succeeds on all platforms that either raise OSError or return b"" upon reading from master (GH-23

[issue41879] Outdated description of async iterables in documentation of async for statement

2020-11-28 Thread Andrew Svetlov
Andrew Svetlov added the comment: Both mentioned links have the correct code. They use sync __aiter__ and async __anext__ -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker <https://bug

[issue42489] Wrong method signature in python Documentation

2020-11-28 Thread Andrew Svetlov
Change by Andrew Svetlov : -- assignee: -> docs@python components: +Documentation -macOS nosy: +docs@python resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10, Python 3.8 ___ Python tra

[issue41562] StreamReaderProtocol inheritance

2020-11-28 Thread Andrew Svetlov
Andrew Svetlov added the comment: Fixing a non-broken thing is not a world-class idea, I think. -- ___ Python tracker <https://bugs.python.org/issue41

[issue34215] streams.py:IncompleteReadError message is unclear when expected is None

2020-11-28 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue34215] streams.py:IncompleteReadError message is unclear when expected is None

2020-11-28 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset df6c8bcffef3380869c8f76317610ce452880b25 by Miss Islington (bot) in branch '3.9': bpo-34215: Clarify IncompleteReadError message when "expected" is None (GH-21925) (GH-23539) https://github.com/python/cpyt

[issue42489] Wrong method signature in python Documentation

2020-11-28 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset d41ec65ab7411e877ca33d05e8c900feca530635 by Zackery Spytz in branch 'master': bpo-42489: Fix the signature for list.sort() in the tutorial (GH-23538) https://github.com/python/cpython/commit/d41ec65ab7411e877ca33d05e8c900feca530635

[issue34215] streams.py:IncompleteReadError message is unclear when expected is None

2020-11-28 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset 4498e98a6bdf017d3b65fa679baf4c797909beb6 by Miss Islington (bot) in branch '3.8': bpo-34215: Clarify IncompleteReadError message when "expected" is None (GH-21925) (#23540) https://github.com/python/cpyt

[issue41756] Do not always use exceptions to return result from coroutine

2020-11-28 Thread Andrew Svetlov
Andrew Svetlov added the comment: Can we close the issue? -- nosy: +asvetlov ___ Python tracker <https://bugs.python.org/issue41756> ___ ___ Python-bugs-list m

[issue34215] streams.py:IncompleteReadError message is unclear when expected is None

2020-11-28 Thread Andrew Svetlov
Change by Andrew Svetlov : -- versions: +Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue34215> ___ ___ Python-bugs-list mailin

[issue34215] streams.py:IncompleteReadError message is unclear when expected is None

2020-11-28 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset 8085f742f4adfbc85f13fc734dfab036aa23acfb by Zackery Spytz in branch 'master': bpo-34215: Clarify IncompleteReadError message when "expected" is None (GH-21925) https://github.com/python/cpython/commit/8085f742f4adfbc85f13fc734dfab0

[issue41241] Unnecessary Type casting in 'if condition'

2020-11-28 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38599] Deprecate creation of asyncio object when the loop is not running

2020-11-28 Thread Andrew Svetlov
Andrew Svetlov added the comment: Fixed by #42392 -- resolution: -> fixed stage: patch review -> resolved status: open -> closed superseder: -> remove the deprecated 'loop' parameter asyncio API versions: +Python 3.10 -Python 3.9 __

[issue42392] remove the deprecated 'loop' parameter asyncio API

2020-11-28 Thread Andrew Svetlov
Change by Andrew Svetlov : -- title: remove the 'loop' parameter from __init__ in all classes in asyncio.locks -> remove the deprecated 'loop' parameter asyncio API ___ Python tracker <https://bugs.python.org/issu

[issue42347] loop.call_exception_handler documentation is lacking

2020-11-28 Thread Andrew Svetlov
Andrew Svetlov added the comment: Partially addressed by https://github.com/python/cpython/pull/21735 -- ___ Python tracker <https://bugs.python.org/issue42

[issue42466] asyncio loop.getaddrinfo raises RuntimeError

2020-11-28 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> wont fix stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue42466> ___ ___

[issue42392] remove the 'loop' parameter from __init__ in all classes in asyncio.locks

2020-11-28 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset e4fe303b8cca525e97d44e80c7e53bdab9dd9187 by Yurii Karabas in branch 'master': bpo-42392: Remove loop parameter from asyncio.tasks and asyncio.subprocess (GH-23521) https://github.com/python/cpython/commit

[issue41818] Lib/pty.py major revision

2020-11-27 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset f5a19ead4ba8c81cc27d5a530f830f4709ce240e by Soumendra Ganguly in branch 'master': bpo-41818: Make test_openpty() avoid unexpected success due to number of rows and/or number of columns being == 0. (GH-23526) https://github.com/python/cpython

[issue42466] asyncio loop.getaddrinfo raises RuntimeError

2020-11-26 Thread Andrew Svetlov
Andrew Svetlov added the comment: Because it did work in a gray area. The finalization logic has slightly changed, some tricks that were working before now fails. Sure, other undocumented tricks start working :) The rule of thumb: please stop and close the asyncio loop before exiting

[issue42466] asyncio loop.getaddrinfo raises RuntimeError

2020-11-26 Thread Andrew Svetlov
Andrew Svetlov added the comment: Because you have `test.start()` and immediately finish the script. The interpreted goes to *shutdown* state and implicitly waits for `test.join()` because the test thread is not a daemon. -- ___ Python tracker

[issue41332] connect_accepted_socket() missing from AbstractEventLoop

2020-11-26 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 -Python 3.5, Python 3.6, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.or

[issue41332] connect_accepted_socket() missing from AbstractEventLoop

2020-11-26 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset e3ef4d7f653976ac0ccacc4e3fde06bf0e0f139b by Alex Grönholm in branch 'master': bpo-41332: Added missing connect_accepted_socket() to AbstractEventLoop (GH-21533) https://github.com/python/cpython/commit/e3ef4d7f653976ac0ccacc4e3fde06bf0e0f139b

[issue41562] StreamReaderProtocol inheritance

2020-11-26 Thread Andrew Svetlov
Andrew Svetlov added the comment: You are right, but the existing inheritance is also correct (while a little redundant). Sorry, I don't think we should do anything: don't fix if not broken. -- resolution: -> not a bug stage: -> resolved status: open -&g

[issue42347] loop.call_exception_handler documentation is lacking

2020-11-26 Thread Andrew Svetlov
Andrew Svetlov added the comment: Pull Request is welcome! -- ___ Python tracker <https://bugs.python.org/issue42347> ___ ___ Python-bugs-list mailing list Unsub

[issue42413] Replace custom exceptions for timeouts with TimeoutError

2020-11-26 Thread Andrew Svetlov
Andrew Svetlov added the comment: Pull Request https://github.com/python/cpython/pull/23520/ applies the discussed change to both asyncio and concurrent.futures. I did the minimally invasive change, libraries still use `asyncio.TimeoutError` and `concurrent.futures.TimeoutError` internally

[issue42413] Replace custom exceptions for timeouts with TimeoutError

2020-11-26 Thread Andrew Svetlov
Change by Andrew Svetlov : -- pull_requests: +22404 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23520 ___ Python tracker <https://bugs.python.org/issu

[issue42413] Replace custom exceptions for timeouts with TimeoutError

2020-11-26 Thread Andrew Svetlov
Change by Andrew Svetlov : -- components: +Library (Lib), asyncio ___ Python tracker <https://bugs.python.org/issue42413> ___ ___ Python-bugs-list mailin

[issue42413] Replace custom exceptions for timeouts with TimeoutError

2020-11-26 Thread Andrew Svetlov
Change by Andrew Svetlov : -- title: Replace custom exception socket.timeout with TimeoutError -> Replace custom exceptions for timeouts with TimeoutError ___ Python tracker <https://bugs.python.org/issu

[issue42466] asyncio loop.getaddrinfo raises RuntimeError

2020-11-26 Thread Andrew Svetlov
Andrew Svetlov added the comment: Your snippet exits just after starting. `getaddrinfo()` is called at the interpreter shutdown state. I'm not sure that do you expect to get here. We can put some effort and raise an error with another message but cannot make the example working. I suggest

[issue42392] remove the 'loop' parameter from __init__ in all classes in asyncio.locks

2020-11-25 Thread Andrew Svetlov
Andrew Svetlov added the comment: A few functions in `tasks.py` a left and documentation should be updated. -- ___ Python tracker <https://bugs.python.org/issue42

[issue42392] remove the 'loop' parameter from __init__ in all classes in asyncio.locks

2020-11-25 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset f533cb80cbbb7acdf9ce1978cfba095ce5eeedaa by Yurii Karabas in branch 'master': bpo-42392: Remove loop parameter from asyncio.streams (GH-23517) https://github.com/python/cpython/commit/f533cb80cbbb7acdf9ce1978cfba095ce5eeedaa

[issue39529] Deprecate get_event_loop()

2020-11-25 Thread Andrew Svetlov
Andrew Svetlov added the comment: I think the deprecation of `set_event_loop()` is a good idea. The function is not required by `asyncio.run()` implementation. -- ___ Python tracker <https://bugs.python.org/issue39

[issue28468] Add platform.freedesktop_os_release()

2020-11-25 Thread Andrew Svetlov
Andrew Svetlov added the comment: Don't get me wrong. I don't want to put my vote in this hot discussion but mention my use case. test.support can solve my need. On another hand, very many Python batteries exist to solve third-party needs and are not required by CPython itself. So I'm +0

[issue41818] Lib/pty.py major revision

2020-11-25 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset 87f7ab5359bc12eeb858272b7bd58e132cb9c176 by Andrew Svetlov in branch 'master': bpo-41818: test_openpty succeed on Gentoo, don't expect to fail on this platform (GH-23514) https://github.com/python/cpython/commit

[issue28468] Add platform.freedesktop_os_release()

2020-11-25 Thread Andrew Svetlov
Andrew Svetlov added the comment: I just needed such functionality for PTY tests: https://github.com/python/cpython/pull/23514 -- nosy: +asvetlov ___ Python tracker <https://bugs.python.org/issue28

[issue41818] Lib/pty.py major revision

2020-11-25 Thread Andrew Svetlov
Andrew Svetlov added the comment: https://github.com/python/cpython/pull/23514 has the fix, waiting for all buildbots finish before pressing "Merge" button. Gentoo bots are green. -- ___ Python tracker <https://bugs.python.o

[issue41818] Lib/pty.py major revision

2020-11-25 Thread Andrew Svetlov
Change by Andrew Svetlov : -- pull_requests: +22401 pull_request: https://github.com/python/cpython/pull/23514 ___ Python tracker <https://bugs.python.org/issue41

[issue41818] Lib/pty.py major revision

2020-11-25 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset c13d89955d9a2942c6355d6839d7096323244136 by Soumendra Ganguly in branch 'master': bpo-41818: Updated tests for the standard pty library (GH-22962) https://github.com/python/cpython/commit/c13d89955d9a2942c6355d6839d7096323244136

[issue42392] remove the 'loop' parameter from __init__ in all classes in asyncio.locks

2020-11-25 Thread Andrew Svetlov
Andrew Svetlov added the comment: > Should I create a separate issue for every PR or they all can be done in the > scope of this PR (we can update issue title to match what was done)? Up to you, I don't think it really matters. -- ___

[issue42392] remove the 'loop' parameter from __init__ in all classes in asyncio.locks

2020-11-24 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement ___ Python tracker <https://bugs.python

[issue42392] remove the 'loop' parameter from __init__ in all classes in asyncio.locks

2020-11-24 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset 0ec34cab9dd4a7bcddafaeeb445fae0f26afcdd1 by Yurii Karabas in branch 'master': bpo-42392: Remove loop parameter form asyncio locks and Queue (#23420) https://github.com/python/cpython/commit/0ec34cab9dd4a7bcddafaeeb445fae0f26afcdd1

[issue42445] Assertion in run_coroutine_threadsafe

2020-11-24 Thread Andrew Svetlov
Andrew Svetlov added the comment: "got Future attached to a different loop" means exactly what it says: you create a future object in one loop but awaits it in the different one. This is a programming error. Most likely the error in your script, not in mqtt and definitely not

[issue42445] Assertion in run_coroutine_threadsafe

2020-11-23 Thread Andrew Svetlov
Andrew Svetlov added the comment: Transferring the loop instance between threads is not safe. You should create a loop and after that call run_forever() in the same thread. Or, even better, call asynxio.run() in a thread. -- ___ Python tracker

[issue15450] Allow dircmp.subdirs to behave well under subclassing

2020-11-23 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 -Python 3.4 ___ Python tracker <https://bugs.python.or

[issue15450] Allow dircmp.subdirs to behave well under subclassing

2020-11-23 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset 2f2f9d0b5c96e68ed91cddd6673860ee752eb49c by Nick Crews in branch 'master': bpo-15450: Allow subclassing of dircmp (GH-23424) (#23424) https://github.com/python/cpython/commit/2f2f9d0b5c96e68ed91cddd6673860ee752eb49c -- nosy: +asvetlov

[issue42413] Replace custom exception socket.timeout with TimeoutError

2020-11-21 Thread Andrew Svetlov
Andrew Svetlov added the comment: Thus using bare TimeoutError in asyncio is safe, isn't it? This is good news! -- ___ Python tracker <https://bugs.python.org/issue42

[issue42413] Replace custom exception socket.timeout with TimeoutError

2020-11-21 Thread Andrew Svetlov
Andrew Svetlov added the comment: I know that I just create OSError() with errno set to None. My question is: has the standard library such code examples already? In other words, how many third-party code will be broken by catching OSError with errno=None

[issue42413] Replace custom exception socket.timeout with TimeoutError

2020-11-21 Thread Andrew Svetlov
Andrew Svetlov added the comment: Perhaps it is a good compromise. OSError-derived class without errno looks getter to me that different incompatible TimeoutError classes. How many exceptions inherited from OSError have no errno set? Do we have a precedent in stdlib at all already

[issue42413] Replace custom exception socket.timeout with TimeoutError

2020-11-21 Thread Andrew Svetlov
Andrew Svetlov added the comment: In futures and asyncio TimeoutError has no errno. I'm not sure should we care but I consider it as a show stopper. On another hand, two distinct timeout classes confuse people. I had many conversions about this during the aiohttp support. asyncio can raise

[issue42395] aclosing was not added to __all__ in contextlib

2020-11-20 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue42411] respect cgroups limits when trying to allocate memory

2020-11-20 Thread Andrew Svetlov
Andrew Svetlov added the comment: Could you explain the proposal? How "+X:UseContainerSupport" behaves for Java? Sorry, I did not use Java for ages and don't follow the modern Java best practices. >From my understanding, without the Docker the allocation of `bytearray(80 *

[issue42392] remove the 'loop' parameter from __init__ in all classes in asyncio.locks

2020-11-19 Thread Andrew Svetlov
Andrew Svetlov added the comment: Perfect! We have a consensus now and waiting for a champion who propose a Pull Request. -- ___ Python tracker <https://bugs.python.org/issue42

[issue42392] remove the 'loop' parameter from __init__ in all classes in asyncio.locks

2020-11-18 Thread Andrew Svetlov
Andrew Svetlov added the comment: Perhaps Kyle is right, I had a misunderstanding with `get_running_loop()` vs `_get_running_loop()`. The last version seems good except for the rare chance of race condition. The safe code can look like: global_lock = threading.Lock() like GIL def

[issue42085] Add dedicated slot for sending values

2020-11-18 Thread Andrew Svetlov
Andrew Svetlov added the comment: Is anything left to do? -- ___ Python tracker <https://bugs.python.org/issue42085> ___ ___ Python-bugs-list mailing list Unsub

[issue42392] remove the 'loop' parameter from __init__ in all classes in asyncio.locks

2020-11-18 Thread Andrew Svetlov
Andrew Svetlov added the comment: Despite the fact that asyncio.get_running_loop() never returns None but raises RuntimeError (and maybe other tiny cleanups), I can live with the proposal. It doesn't make a system worse at least and backward compatible. We can return to the idea of raising

[issue42392] remove the 'loop' parameter from __init__ in all classes in asyncio.locks

2020-11-18 Thread Andrew Svetlov
Andrew Svetlov added the comment: My initial thought was protecting the Lock (and other primitives) creation when a loop is not running. Yuri insists that Lock can be created without a loop. Technically it is possible, sure. But the lock is tightly coupled with a loop instance. In other

[issue42396] Add a whatsnew entry about async contextlib.nullcontext

2020-11-17 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 ___ Python tracker <https://bugs.python.or

[issue42395] aclosing was not added to __all__ in contextlib

2020-11-17 Thread Andrew Svetlov
Change by Andrew Svetlov : -- versions: +Python 3.10 ___ Python tracker <https://bugs.python.org/issue42395> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42392] remove the 'loop' parameter from __init__ in all classes in asyncio.locks

2020-11-17 Thread Andrew Svetlov
Andrew Svetlov added the comment: This was on my to-do list but I very much appreciate if somebody champions this issue. I should finish sslproto PR first. -- ___ Python tracker <https://bugs.python.org/issue42

[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

2020-11-12 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 ___ Python tracker <https://bugs.python.or

[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

2020-11-12 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset f37628eb7117f222de24a6931aa7639e668cb7b0 by Jakub Stasiak in branch '3.8': [3.8] bpo-42237: Fix os.sendfile() on illumos (GH-23154). (GH-23246) https://github.com/python/cpython/commit/f37628eb7117f222de24a6931aa7639e668cb7b0

[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

2020-11-12 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset fd4ed57674c675e05bd5d577dd5047a333c76c78 by Jakub Stasiak in branch 'master': bpo-42237: Fix os.sendfile() on illumos (GH-23154) https://github.com/python/cpython/commit/fd4ed57674c675e05bd5d577dd5047a333c76c78 -- nosy: +asvetlov

[issue6225] Fixing several minor bugs in Tkinter.Canvas and one in Misc._configure

2020-11-11 Thread Andrew Svetlov
Andrew Svetlov added the comment: I believe, yes -- status: pending -> open ___ Python tracker <https://bugs.python.org/issue6225> ___ ___ Python-bugs-lis

[issue42085] Add dedicated slot for sending values

2020-11-11 Thread Andrew Svetlov
Andrew Svetlov added the comment: Thank you Victor for the report! -- ___ Python tracker <https://bugs.python.org/issue42085> ___ ___ Python-bugs-list mailin

[issue42085] Add dedicated slot for sending values

2020-11-11 Thread Andrew Svetlov
Andrew Svetlov added the comment: PR for the fix is created: https://github.com/python/cpython/pull/23237 -- ___ Python tracker <https://bugs.python.org/issue42

[issue42085] Add dedicated slot for sending values

2020-11-11 Thread Andrew Svetlov
Change by Andrew Svetlov : -- pull_requests: +22135 pull_request: https://github.com/python/cpython/pull/23237 ___ Python tracker <https://bugs.python.org/issue42

[issue42085] Add dedicated slot for sending values

2020-11-11 Thread Andrew Svetlov
Andrew Svetlov added the comment: Investigating. The test leaks a future instance. -- ___ Python tracker <https://bugs.python.org/issue42085> ___ ___ Python-bug

[issue42140] asyncio.wait function creates futures set two times

2020-11-11 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 ___ Python tracker <https://bugs.python.or

[issue42183] Stack overflow error with asyncio.all_tasks and wait_for

2020-11-10 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.7 ___ Python tracker <https://bugs.python.or

[issue42183] Stack overflow error with asyncio.all_tasks and wait_for

2020-11-10 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset 42d873c63aa9d160c132be4a34599531574db12c by Andrew Svetlov in branch 'master': bpo-42183: Fix a stack overflow error for asyncio Task or Future repr() (GH-23020) https://github.com/python/cpython/commit/42d873c63aa9d160c132be4a34599531574db12c

[issue41543] contextlib.nullcontext doesn't work with async context managers

2020-11-09 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 ___ Python tracker <https://bugs.python.or

  1   2   3   4   5   6   7   8   9   10   >