Anton Grübel added the comment:
Even it is a private method, it is essential, when you use
Snapshot.filter_traces(). Creating a Filter without implementing this method
will just result in a runtime error.
https://github.com/python/cpython/blob/029cb4a6adacb650dbfc8ea71d2875ab771fe92e/Lib
Change by Anton Grübel :
--
keywords: +patch
pull_requests: +26042
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27527
___
Python tracker
<https://bugs.python.org/issu
New submission from Anton Grübel :
during some work on typeshed I found the BaseFilter class in tracemalloc and it
totally looks like and is used as a typical abstract class.
I will also directly create the PR :) if you think I'm missing something, I'm
happy to hear some other thoughts
Anton Grübel added the comment:
I'm still super happy to had the chance to contribute a bit to Python and it
will be available already in version 3.10 <3
Thanks Serhiy & Lukasz!
--
___
Python tracker
<https://bugs.python.org/
Anton Grübel added the comment:
I know that :) , it is just weird to do also do the type check on an empty
string, which can be replaced with str directly, but as far as I know it is
usually better to use isinstance instead of type.
--
___
Python
