Change by Ashley Whetter :
--
nosy: +AWhetter
nosy_count: 6.0 -> 7.0
pull_requests: +27389
pull_request: https://github.com/python/cpython/pull/21296
___
Python tracker
<https://bugs.python.org/issu
Change by Ashley Whetter :
--
keywords: +patch
pull_requests: +20445
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21296
___
Python tracker
<https://bugs.python.org/issu
New submission from Ashley Whetter :
Many of the fixers cause the tool to report a file as both unchanged and
modified.
For example when checking a file with the following contents:
```
s = "str"
```
using the following command: `python -m lib2to3 -f unicode unicode_test.py`
The
Ashley Whetter added the comment:
Yes I'm happy to make those changes as part of this.
So clarify what needs to change in PR 16567:
1) Include a note in the docs for `inited` that outlines that if it is imported
into the local scope, it will not be updated by calls to `init()`. Only
Change by Ashley Whetter :
--
keywords: +patch
pull_requests: +17050
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16575
___
Python tracker
<https://bugs.python.org/issu
Ashley Whetter added the comment:
Ah you're right. I was trying to install in the same way as previous versions.
I didn't realise that calling prepare_*.bat was a separate step now.
Sorry about that.
--
stage: -> resolved
status: open ->
New submission from Ashley Whetter :
get_externals.bat downloads and extracts libffi to a versioned directory (much
like the other external libraries). See
https://github.com/python/cpython/blob/v3.8.0/PCbuild/get_externals.bat#L55
However the binary release is downloaded to an unversioned
Ashley Whetter added the comment:
Maybe updating the dictionaries isn't right at all.
I think if you were experienced enough you would have the intuition that
mutable attributes like this are not going to change in your local scope if you
import them into it. But relying on this knowledge
Ashley Whetter added the comment:
I've just realised that this issue was specific to tp_clear on a module and not
on objects. tp_clear on modules has already been fixed in
https://bugs.python.org/issue33622.
I think this is closable
Ashley Whetter added the comment:
I've attached a reproduction case. Here's the setup.py that I used:
```
from distutils.core import Extension, setup
extension = Extension("breaky", ["breaky.c"])
setup(
name="tp_clear",
version="0.1.0",
10 matches
Mail list logo