[issue23469] Delete Misc/*.wpr files

2021-12-14 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue23469] Delete Misc/*.wpr files

2021-12-14 Thread Berker Peksag
Berker Peksag added the comment: New changeset d46d08d9474cb00b697dbdbb12cc7ce8f8ddfcec by Kumar Aditya in branch 'main': bpo-23469: Delete Wing IDE configuration files (GH-30067) https://github.com/python/cpython/commit/d46d08d9474cb00b697dbdbb12cc7ce8f8ddfcec

[issue23469] Delete Misc/*.wpr files

2021-12-07 Thread Berker Peksag
Change by Berker Peksag : -- stage: resolved -> status: closed -> open versions: +Python 3.11 -Python 3.4, Python 3.5 ___ Python tracker <https://bugs.python.org/i

[issue2771] Test issue

2021-11-08 Thread Berker Peksag
Change by Berker Peksag : -- nosy: -berker.peksag ___ Python tracker <https://bugs.python.org/issue2771> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20408] memoryview() constructor documentation error

2021-05-25 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.11 -Python 3.8 ___ Python tracker <https://bugs.python.or

[issue20408] memoryview() constructor documentation error

2021-05-25 Thread Berker Peksag
Berker Peksag added the comment: New changeset 8accb8c8ccf371021cba5a2b91f5b7c711fa8149 by Miss Islington (bot) in branch '3.9': bpo-20408: Fix memoryview() signature in docs (GH-24431) https://github.com/python/cpython/commit/8accb8c8ccf371021cba5a2b91f5b7c711fa8149

[issue20408] memoryview() constructor documentation error

2021-05-25 Thread Berker Peksag
Berker Peksag added the comment: New changeset 05f8ad0c745016cd8b5bdbda4336688b80f45fd7 by Miss Islington (bot) in branch '3.10': bpo-20408: Fix memoryview() signature in docs (GH-24431) https://github.com/python/cpython/commit/05f8ad0c745016cd8b5bdbda4336688b80f45fd7

[issue20408] memoryview() constructor documentation error

2021-05-25 Thread Berker Peksag
Berker Peksag added the comment: New changeset d18e5dae914b1db49b25ed7729c07a535d1f0c52 by Mariusz Felisiak in branch 'main': bpo-20408: Fix memoryview() signature in docs (GH-24431) https://github.com/python/cpython/commit/d18e5dae914b1db49b25ed7729c07a535d1f0c52

[issue44079] [sqlite3] remove superfluous statement weak ref list from connection object

2021-05-19 Thread Berker Peksag
Berker Peksag added the comment: https://github.com/ghaering/pysqlite/commit/33f99be6be5ad7d69767ff172441f1a860416e82 states the following: - Use a list of weak references of statements in the Connection class to keep track of all statements used with this connection

[issue44106] [sqlite3] don't use politicians in examples/docs

2021-05-19 Thread Berker Peksag
Berker Peksag added the comment: New changeset e57bef1b73abb8e89d927053bd7e4fdbf44687bf by Miss Islington (bot) in branch '3.10': bpo-44106: Purge unused sqlite3 doc includes (GH-26234) https://github.com/python/cpython/commit/e57bef1b73abb8e89d927053bd7e4fdbf44687bf

[issue44106] [sqlite3] don't use politicians in examples/docs

2021-05-19 Thread Berker Peksag
Berker Peksag added the comment: New changeset 5b5a10c8740aa5e9fd68a10d9cb23b0e7d61ce98 by Miss Islington (bot) in branch '3.9': bpo-44106: Purge unused sqlite3 doc includes (GH-26234) https://github.com/python/cpython/commit/5b5a10c8740aa5e9fd68a10d9cb23b0e7d61ce98

[issue42862] Use functools.lru_cache iso. _sqlite.Cache in sqlite3 module

2021-05-19 Thread Berker Peksag
Berker Peksag added the comment: > Or is it ok to call gc.collect() in the test suite? It is but in this case I'd say it's a bit weird that we need to call it. Unfortunately, I don't have much time to investigate it at the moment. -- ___ Pyt

[issue44106] [sqlite3] don't use politicians in examples/docs

2021-05-19 Thread Berker Peksag
Berker Peksag added the comment: New changeset 3185bc9d3f38ce9d814aecf8104f1d6953c2d8ff by Miss Islington (bot) in branch '3.10': bpo-44106: Improve sqlite3 example database contents (GH-26027) https://github.com/python/cpython/commit/3185bc9d3f38ce9d814aecf8104f1d6953c2d8ff

[issue44106] [sqlite3] don't use politicians in examples/docs

2021-05-19 Thread Berker Peksag
Berker Peksag added the comment: New changeset db20afe6c43ad585577589131bf658ce7ebe6bd2 by Miss Islington (bot) in branch '3.9': bpo-44106: Improve sqlite3 example database contents (GH-26027) https://github.com/python/cpython/commit/db20afe6c43ad585577589131bf658ce7ebe6bd2

[issue30593] Document that sqlite3.Cursor.executescript disregards isolation_level

2021-05-19 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue30593] Document that sqlite3.Cursor.executescript disregards isolation_level

2021-05-19 Thread Berker Peksag
Berker Peksag added the comment: New changeset 1f483c0c1b5a9fd1062bacc2aeba6bb0e9b7 by Miss Islington (bot) in branch '3.10': bpo-30593: Doc'ed that executescript() disregards isolation level (GH-26220) https://github.com/python/cpython/commit/1f483c0c1b5a9fd1062bacc2aeba6bb0e9b7

[issue30593] Document that sqlite3.Cursor.executescript disregards isolation_level

2021-05-19 Thread Berker Peksag
Berker Peksag added the comment: New changeset 76ed53ca7bf0d4a43099d9401af5fe9f75689885 by Miss Islington (bot) in branch '3.9': bpo-30593: Doc'ed that executescript() disregards isolation level (GH-26220) https://github.com/python/cpython/commit/76ed53ca7bf0d4a43099d9401af5fe9f75689885

[issue35889] sqlite3.Row doesn't have useful repr

2021-05-19 Thread Berker Peksag
Berker Peksag added the comment: Let's close it as rejected. Thank you everyone for your input. -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43350] [sqlite3] Active statements are reset twice in _pysqlite_query_execute()

2021-05-10 Thread Berker Peksag
Berker Peksag added the comment: Serhiy is right. Without a proper research on why it was added in the first place, simply removing the second call won't make code any better and it may introduce regressions (we've already introduced two in 3.10) Maybe doing some digging in pysqlite commits

[issue44047] [sqlite3] remove unused argument from _pysqlite_seterror()

2021-05-07 Thread Berker Peksag
Berker Peksag added the comment: Thank you! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement ___ Python tracker <https://bugs.python

[issue43851] Optimise SQLite builds on macOS and Windows

2021-04-28 Thread Berker Peksag
Berker Peksag added the comment: As long as we don't introduce behavior changes between SQLite versions in mainstream Linux distributions and macOS/Windows (i.e. an application should continue working in Linux, macOS, Windows), it sounds good to me. Maybe it's worth checking what compile

[issue43934] Minimal version of SQLite3 - 3.26 ?

2021-04-24 Thread Berker Peksag
Berker Peksag added the comment: Thank you for taking your time to improve the sqlite3 module! -- ___ Python tracker <https://bugs.python.org/issue43

[issue43934] Minimal version of SQLite3 - 3.26 ?

2021-04-24 Thread Berker Peksag
Berker Peksag added the comment: This would make sqlite3 module unusable for many users. We have already increased the minimal required version in 3.10 and am opposed to do this change. I also don't understand what part of msg370266 made you think that this is a reasonable change. The gist

[issue43852] [sqlite3] Improve tuple creation

2021-04-23 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.11 -Python 3.10 ___ Python tracker <https://bugs.python.or

[issue43852] [sqlite3] Improve tuple creation

2021-04-23 Thread Berker Peksag
Berker Peksag added the comment: New changeset e9194ea6eaa18299d6ccbd3555ce150fab0c6184 by Erlend Egeberg Aasland in branch 'master': bpo-43852: Improve tuple creation in sqlite3 (GH-25421) https://github.com/python/cpython/commit/e9194ea6eaa18299d6ccbd3555ce150fab0c6184

[issue43296] [sqlite3] Fix sqlite3_value_blob() usage

2021-04-14 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43296] [sqlite3] Fix sqlite3_value_blob() usage

2021-04-14 Thread Berker Peksag
Berker Peksag added the comment: New changeset 5cb601f956886b32641f818b5da347cc86a43db2 by Erlend Egeberg Aasland in branch 'master': bpo-43296: Handle sqlite3_value_blob() errors (GH-24674) https://github.com/python/cpython/commit/5cb601f956886b32641f818b5da347cc86a43db2

[issue43505] [sqlite3] Explicitly initialise and shut down sqlite3

2021-04-14 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43505] [sqlite3] Explicitly initialise and shut down sqlite3

2021-04-14 Thread Berker Peksag
Berker Peksag added the comment: New changeset def919342facf7f53a3a5f0e9f4b1889d323956d by Erlend Egeberg Aasland in branch 'master': bpo-43505: Explicitly initialize and shutdown sqlite3 (GH-25404) https://github.com/python/cpython/commit/def919342facf7f53a3a5f0e9f4b1889d323956d

[issue43505] [sqlite3] Explicitly initialise and shut down sqlite3

2021-04-14 Thread Berker Peksag
Berker Peksag added the comment: Making SQLITE_OMIT_AUTOINIT the default behavior would pretty much break every application that use SQLite, but since the PR is small enough and uses the interface in the correct way, I don't see a strong reason to reject

[issue20364] Rename & explain sqlite3.Cursor.execute 'parameters' param

2021-04-14 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10, Python 3.9 -Python 2.7, Python 3.3, Python 3.4 ___ Python tracker <https://bugs.python.or

[issue20364] Rename & explain sqlite3.Cursor.execute 'parameters' param

2021-04-14 Thread Berker Peksag
Berker Peksag added the comment: New changeset 95e4431804587a0c9d464bb7b3d5f3057bbeaccd by Miss Islington (bot) in branch '3.9': bpo-20364: Improve sqlite3 placeholder docs (GH-25003) https://github.com/python/cpython/commit/95e4431804587a0c9d464bb7b3d5f3057bbeaccd

[issue20364] Rename & explain sqlite3.Cursor.execute 'parameters' param

2021-04-14 Thread Berker Peksag
Berker Peksag added the comment: New changeset 3386ca0b36327afeef8d7eff277b2aed1030c08d by Erlend Egeberg Aasland in branch 'master': bpo-20364: Improve sqlite3 placeholder docs (GH-25003) https://github.com/python/cpython/commit/3386ca0b36327afeef8d7eff277b2aed1030c08d -- nosy

[issue43265] [sqlite3] Improve backup error handling

2021-04-14 Thread Berker Peksag
Berker Peksag added the comment: Thank you. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43265] [sqlite3] Improve backup error handling

2021-04-14 Thread Berker Peksag
Berker Peksag added the comment: New changeset c1ae7419975f7d664320f66ea3acc8663bbf76cf by Erlend Egeberg Aasland in branch 'master': bpo-43265: Improve sqlite3.Connection.backup error handling (GH-24586) https://github.com/python/cpython/commit/c1ae7419975f7d664320f66ea3acc8663bbf76cf

[issue43752] [sqlite3] Fetching an empty value from date column raises ValueError

2021-04-14 Thread Berker Peksag
Berker Peksag added the comment: Thank you for the report and reproducer, Mariusz and thank you for the PR, Erlend. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bug

[issue43752] [sqlite3] Fetching an empty value from date column raises ValueError

2021-04-14 Thread Berker Peksag
Berker Peksag added the comment: New changeset 6f1e8ccffa5b1272a36a35405d3c4e4bbba0c082 by Erlend Egeberg Aasland in branch 'master': bpo-43752: Fix sqlite3 regression for zero-sized blobs with converters (GH-25228) https://github.com/python/cpython/commit

[issue43597] robotparser should support specifying SSL context

2021-04-06 Thread Berker Peksag
Berker Peksag added the comment: I'm not opposing to the idea, but what's the practical use case here? I haven't seen a case where you needed to pass a custom SSLContext in order to fetch the robots.txt file. -- nosy: +berker.peksag versions: -Python 3.6, Python 3.7, Python 3.8

[issue43094] sqlite3 signature discrepancies between documentation and implementation

2021-03-26 Thread Berker Peksag
Berker Peksag added the comment: > Berker, I started drafting a PEP. Would you be interested in helping? Of course! I may be not be able to respond to you quickly in the next few weeks, though. -- ___ Python tracker <https://bugs.pyth

[issue43444] [sqlite3] Move MODULE_NAME def from setup.py to module.h

2021-03-13 Thread Berker Peksag
Berker Peksag added the comment: New changeset 2256a2876b5214a5a7492bf78bd86cf8beb690bf by Erlend Egeberg Aasland in branch 'master': bpo-43444: Move sqlite3 MODULE_NAME from setup.py to module.h (GH-24801) https://github.com/python/cpython/commit/2256a2876b5214a5a7492bf78bd86cf8beb690bf

[issue43444] [sqlite3] Move MODULE_NAME def from setup.py to module.h

2021-03-13 Thread Berker Peksag
Berker Peksag added the comment: Thank you! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43446] Wrong character in footnote

2021-03-09 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.6, Python 3.7 ___ Python tracker <https://bugs.python.or

[issue43446] Wrong character in footnote

2021-03-09 Thread Berker Peksag
Berker Peksag added the comment: New changeset da602560a4816c88dcf4d75b3e4eea56c8d3bbc2 by Miss Islington (bot) in branch '3.9': bpo-43446: Fix markup in sqlite3 footnote (GH-24806) https://github.com/python/cpython/commit/da602560a4816c88dcf4d75b3e4eea56c8d3bbc2

[issue43446] Wrong character in footnote

2021-03-09 Thread Berker Peksag
Berker Peksag added the comment: New changeset e89380765df8f0f02c90ad417e164d1597bd0b05 by Miss Islington (bot) in branch '3.8': bpo-43446: Fix markup in sqlite3 footnote (GH-24806) https://github.com/python/cpython/commit/e89380765df8f0f02c90ad417e164d1597bd0b05

[issue43446] Wrong character in footnote

2021-03-09 Thread Berker Peksag
Berker Peksag added the comment: New changeset 62a03cd490f81c0fb01eaceb31aa8a4c7800ed0e by Kamil Turek in branch 'master': bpo-43446: Fix markup in sqlite3 footnote (GH-24806) https://github.com/python/cpython/commit/62a03cd490f81c0fb01eaceb31aa8a4c7800ed0e -- nosy: +berker.peksag

[issue43396] Use more descriptive variable names in sqlite3 docs

2021-03-04 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 ___ Python tracker <https://bugs.python.or

[issue43396] Use more descriptive variable names in sqlite3 docs

2021-03-04 Thread Berker Peksag
Berker Peksag added the comment: New changeset 213c155a460b8dd9e43901e4d61aa088cbac4221 by Miss Islington (bot) in branch '3.8': bpo-43396: Normalise naming in sqlite3 doc examples (GH-24746) https://github.com/python/cpython/commit/213c155a460b8dd9e43901e4d61aa088cbac4221

[issue43396] Use more descriptive variable names in sqlite3 docs

2021-03-04 Thread Berker Peksag
Berker Peksag added the comment: New changeset 374ee449331bc95d18c37f5032aaea1448462e58 by Miss Islington (bot) in branch '3.9': bpo-43396: Normalise naming in sqlite3 doc examples (GH-24746) https://github.com/python/cpython/commit/374ee449331bc95d18c37f5032aaea1448462e58

[issue43396] Use more descriptive variable names in sqlite3 docs

2021-03-04 Thread Berker Peksag
Berker Peksag added the comment: New changeset 40d1b831ecd1b5b6a4fce9a908a6e61b50b360a0 by Erlend Egeberg Aasland in branch 'master': bpo-43396: Normalise naming in sqlite3 doc examples (GH-24746) https://github.com/python/cpython/commit/40d1b831ecd1b5b6a4fce9a908a6e61b50b360a0

[issue43396] Use more descriptive variable names in sqlite3 docs

2021-03-04 Thread Berker Peksag
Berker Peksag added the comment: LGTM! -- resolution: not a bug -> stage: resolved -> needs patch status: closed -> open title: Non-existent method sqlite3.Connection.fetchone() used in docs -> Use more descriptive variable names in sqlite3 docs type: -> enhan

[issue43396] Non-existent method sqlite3.Connection.fetchone() used in docs

2021-03-04 Thread Berker Peksag
Berker Peksag added the comment: No problem and thank you for taking time to report! I'd be happy to merge a PR that renames c to cur in the documentation (I counted four instances.) We can then reopen and retarget this isssue. -- resolution: -> not a

[issue43396] Non-existent method sqlite3.Connection.fetchone() used in docs

2021-03-04 Thread Berker Peksag
Berker Peksag added the comment: https://github.com/python/cpython/blame/e161ec5dd7ba9355eb06757b9304019ac53cdf69/Doc/library/sqlite3.rst#L74-L76 is not a standalone snippet. It uses the cursor object created at https://github.com/python/cpython/blame/e161ec5dd7ba9355eb06757b9304019ac53cdf69

[issue43396] Non-existent method sqlite3.Connection.fetchone() used in docs

2021-03-04 Thread Berker Peksag
Berker Peksag added the comment: Could you please post the full snippet? c is already set to a cursor at https://github.com/python/cpython/blame/e161ec5dd7ba9355eb06757b9304019ac53cdf69/Doc/library/sqlite3.rst#L56: c = conn.cursor() And the following example works fine: >>&g

[issue43369] [sqlite3] Handle out-of-memory errors in sqlite3_column_*()

2021-03-04 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43369] [sqlite3] Handle out-of-memory errors in sqlite3_column_*()

2021-03-04 Thread Berker Peksag
Berker Peksag added the comment: New changeset e161ec5dd7ba9355eb06757b9304019ac53cdf69 by Erlend Egeberg Aasland in branch 'master': bpo-43369: sqlite3_column_{text,blob} failures now raise MemoryError (GH-24723) https://github.com/python/cpython/commit

[issue43368] Empty bytestrings are not longer returned on SQLite.

2021-03-03 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43368] Empty bytestrings are not longer returned on SQLite.

2021-03-03 Thread Berker Peksag
Berker Peksag added the comment: New changeset 3b4b2cf418707c79f96689e401e3c703c0fdd4d2 by Mariusz Felisiak in branch 'master': bpo-43368: Fix fetching empty bytes in sqlite3 (GH-24706) https://github.com/python/cpython/commit/3b4b2cf418707c79f96689e401e3c703c0fdd4d2

[issue43251] [sqlite3] sqlite3_column_name() failures should raise MemoryError

2021-02-28 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement ___ Python tracker <https://bugs.python

[issue43251] [sqlite3] sqlite3_column_name() failures should raise MemoryError

2021-02-28 Thread Berker Peksag
Berker Peksag added the comment: New changeset 2183d06bc8a481098d62a4ebed8d6982b3d1602a by Erlend Egeberg Aasland in branch 'master': bpo-43251: sqlite3_column_name() failures now raise MemoryError (GH-24609) https://github.com/python/cpython/commit/2183d06bc8a481098d62a4ebed8d6982b3d1602a

[issue43294] [sqlite3] unused variables in Connection begin, commit, and rollback

2021-02-26 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43294] [sqlite3] unused variables in Connection begin, commit, and rollback

2021-02-26 Thread Berker Peksag
Berker Peksag added the comment: New changeset 5e48e836883ac577acd69c7b9bdfe5c439cef47f by Erlend Egeberg Aasland in branch 'master': bpo-43294: Remove unused variables in pysqlite_connection_*() (GH-24658) https://github.com/python/cpython/commit/5e48e836883ac577acd69c7b9bdfe5c439cef47f

[issue43314] [sqlite3] remove pre SQLite 3.7.7 support code

2021-02-25 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43314] [sqlite3] remove pre SQLite 3.7.7 support code

2021-02-25 Thread Berker Peksag
Berker Peksag added the comment: New changeset 3150754f91fc1d15e3888e22c065672838a9c069 by Erlend Egeberg Aasland in branch 'master': bpo-43314: Remove SQLITE_OPEN_URI ifdef (GH-24637) https://github.com/python/cpython/commit/3150754f91fc1d15e3888e22c065672838a9c069

[issue43290] [sqlite3] remove legacy code from pysqlite_step

2021-02-25 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43290] [sqlite3] remove legacy code from pysqlite_step

2021-02-25 Thread Berker Peksag
Berker Peksag added the comment: New changeset 91ea37c84af2dd5ea92802a4c2adad47861ac067 by Erlend Egeberg Aasland in branch 'master': bpo-43290: Remove workaround from pysqlite_step() (GH-24638) https://github.com/python/cpython/commit/91ea37c84af2dd5ea92802a4c2adad47861ac067

[issue43269] [sqlite3] Clean up function scoping

2021-02-21 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43269] [sqlite3] Clean up function scoping

2021-02-21 Thread Berker Peksag
Berker Peksag added the comment: New changeset 38b6c2acd4bba666bd64779c42b9d91cbee19274 by Erlend Egeberg Aasland in branch 'master': bpo-43269: Remove redundant extern keywords (GH-24605) https://github.com/python/cpython/commit/38b6c2acd4bba666bd64779c42b9d91cbee19274

[issue43269] [sqlite3] Clean up function scoping

2021-02-20 Thread Berker Peksag
Berker Peksag added the comment: New changeset bf838a6e7eec2063a17c7c33dfa94afeef116f36 by Erlend Egeberg Aasland in branch 'master': bpo-43269: Clean up sqlite3 file scope (GH-24578) https://github.com/python/cpython/commit/bf838a6e7eec2063a17c7c33dfa94afeef116f36

[issue43265] [sqlite3] Improve backup error handling

2021-02-20 Thread Berker Peksag
Change by Berker Peksag : Removed file: https://bugs.python.org/file49823/DOC-20200420-WA ___ Python tracker <https://bugs.python.org/issue43265> ___ ___ Python-bug

[issue43265] [sqlite3] Improve backup error handling

2021-02-20 Thread Berker Peksag
Berker Peksag added the comment: > 3.9, I presume? Yes, I was going too fast :) -- ___ Python tracker <https://bugs.python.org/issue43265> ___ ___ Python-

[issue43265] [sqlite3] Improve backup error handling

2021-02-20 Thread Berker Peksag
Berker Peksag added the comment: I'd even consider a cryptic error message a minor usability bug and backport it to at least 3.10. -- ___ Python tracker <https://bugs.python.org/issue43

[issue43265] Improve sqlite3 backup error handling

2021-02-19 Thread Berker Peksag
Berker Peksag added the comment: I'm not sure about 1) because if target == source it means a user error. OperationalError is usually used for non-user errors. 3) sounds good to me if that part is already covered by tests and they passed

[issue43258] Prevent needless allocation of sqlite3 aggregate function context

2021-02-19 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43258] Prevent needless allocation of sqlite3 aggregate function context

2021-02-19 Thread Berker Peksag
Berker Peksag added the comment: New changeset 2bb0bf4dd8c0bd4d23eb04afce1a58e07982 by Erlend Egeberg Aasland in branch 'master': bpo-43258: Make sqlite3 callback functions static (GH-24574) https://github.com/python/cpython/commit/2bb0bf4dd8c0bd4d23eb04afce1a58e07982

[issue43258] Prevent needless allocation of sqlite3 aggregate function context

2021-02-19 Thread Berker Peksag
Berker Peksag added the comment: New changeset 979b23cbe44071b056ff524c0aa20e5d9794b5b0 by Erlend Egeberg Aasland in branch 'master': bpo-43258: Don't allocate sqlite3 aggregate context for empty queries (GH-24569) https://github.com/python/cpython/commit

[issue43249] sqlite3_column_bytes() should be called after sqlite3_column_blob()

2021-02-18 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43249] sqlite3_column_bytes() should be called after sqlite3_column_blob()

2021-02-18 Thread Berker Peksag
Berker Peksag added the comment: New changeset cc96231f0a59cc7393943064800ecb6c18892662 by Erlend Egeberg Aasland in branch 'master': bpo-43249: Improve scoping in _pysqlite_fetch_one_row() (GH-24565) https://github.com/python/cpython/commit/cc96231f0a59cc7393943064800ecb6c18892662

[issue43249] sqlite3_column_bytes() should be called after sqlite3_column_blob()

2021-02-18 Thread Berker Peksag
Berker Peksag added the comment: New changeset 47feb1feb28631b6647699b7633109aa85340966 by Erlend Egeberg Aasland in branch 'master': bpo-43249: sqlite3_column_bytes() must follow sqlite_column_blob() (GH-24562) https://github.com/python/cpython/commit

[issue43249] sqlite3_column_bytes() should be called after sqlite3_column_blob()

2021-02-18 Thread Berker Peksag
Berker Peksag added the comment: Good catch! Sounds good to me but I'd say designing APIs relying on call order is bad too :) -- ___ Python tracker <https://bugs.python.org/issue43

[issue28179] Segfault in test_recursionlimit_fatalerror

2021-02-17 Thread Berker Peksag
Berker Peksag added the comment: Yes, this indeed seems to be fixed by issue 42500 and can be closed now. Nice detective work, thank you! -- stage: needs patch -> resolved status: pending -> closed ___ Python tracker <https://bugs.p

[issue40956] Use Argument Clinic in sqlite3

2021-02-10 Thread Berker Peksag
Berker Peksag added the comment: New changeset ea46579067fd2d4e164d6605719ffec690c4d621 by Erlend Egeberg Aasland in branch 'master': bpo-40956: Fix segfault when Connection.backup is called without target (GH-24503) https://github.com/python/cpython/commit

[issue43094] sqlite3 signature discrepancies between documentation and implementation

2021-02-10 Thread Berker Peksag
Berker Peksag added the comment: The problem is that sqlite3 isn't the only module where there are discrepancies between documentation and implementation. If we are going to change public sqlite3 APIs in to be positional-only, I'd prefer writing a PEP and fix all modules once and for all

[issue43059] sqlite3: Externally developed?

2021-01-30 Thread Berker Peksag
Berker Peksag added the comment: Yes, version attributes should be deprecated and properly documented in Doc/whatsnew/3.10.rst before removal. I remember we broke Mailman when we removed a dunder attribute from the mail package. Thank you for the PR! -- resolution: -> fixed st

[issue43059] sqlite3: Externally developed?

2021-01-30 Thread Berker Peksag
Berker Peksag added the comment: New changeset de76ce540ed013a31d4c80bca2587a2dd7c23652 by Miss Islington (bot) in branch '3.8': bpo-43059: Remove reference to legacy external sqlite3 repository (GH-24364) https://github.com/python/cpython/commit/de76ce540ed013a31d4c80bca2587a2dd7c23652

[issue43059] sqlite3: Externally developed?

2021-01-30 Thread Berker Peksag
Berker Peksag added the comment: New changeset 926ca51be4b9b80c41a647bbc2fb9c40ff108ff0 by Miss Islington (bot) in branch '3.9': bpo-43059: Remove reference to legacy external sqlite3 repository (GH-24364) https://github.com/python/cpython/commit/926ca51be4b9b80c41a647bbc2fb9c40ff108ff0

[issue43059] sqlite3: Externally developed?

2021-01-30 Thread Berker Peksag
Berker Peksag added the comment: New changeset e60344364245a23a7a1b25d5ebce6833652a656c by L in branch 'master': bpo-43059: Remove reference to legacy external sqlite3 repository (GH-24364) https://github.com/python/cpython/commit/e60344364245a23a7a1b25d5ebce6833652a656c

[issue42916] Support for DICOM image file format in imghdr module

2021-01-24 Thread Berker Peksag
Berker Peksag added the comment: Copying my comment from GitHub: > I think DICOM is too specific to be added to the stdlib. I'd prefer > improving documentation of imghdr.tests to make adding custom file > types clearer. -- nosy: +berk

[issue40956] Use Argument Clinic in sqlite3

2021-01-13 Thread Berker Peksag
Berker Peksag added the comment: New changeset a330365ca5ae836075f306334ab648bf23471481 by Erlend Egeberg Aasland in branch 'master': bpo-40956: Fix sqlite3.Cursor.fetchmany() default value (GH-24214) https://github.com/python/cpython/commit/a330365ca5ae836075f306334ab648bf23471481

[issue42862] Use functools.lru_cache iso. _sqlite.Cache in sqlite3 module

2021-01-12 Thread Berker Peksag
Berker Peksag added the comment: We can always reopen GH-24135 and merge it even if we revert this one for some reason :) -- ___ Python tracker <https://bugs.python.org/issue42

[issue42862] Use functools.lru_cache iso. _sqlite.Cache in sqlite3 module

2021-01-12 Thread Berker Peksag
Berker Peksag added the comment: I don't see any reason to merge GH-24135 if we are going to remove cache.[ch] in this issue. I was -0 before but since Raymond gave his +1, you can count me as +1 too. -- ___ Python tracker <ht

[issue24464] "sqlite3_enable_shared_cache" deprecation warning when compiling with macOS system SQLite3

2021-01-09 Thread Berker Peksag
Berker Peksag added the comment: New changeset d16f6176abdecbb7ab231dc78beccfaa095beff6 by Erlend Egeberg Aasland in branch 'master': bpo-24464: Fix sqlite3.enable_shared_cache() deprecation wrapper (GH-24170) https://github.com/python/cpython/commit/d16f6176abdecbb7ab231dc78beccfaa095beff6

[issue42847] Normalise file encodings in Lib/sqlite3/test/

2021-01-06 Thread Berker Peksag
Berker Peksag added the comment: iso-8859-1 is still commonly used in some parts of Nordic countries, but I don't see a reason not to change it here :) Thank you, Erlend! -- components: +Tests -Library (Lib) type: -> enhancement ___ Pyt

[issue42847] Normalise file encodings in Lib/sqlite3/test/

2021-01-06 Thread Berker Peksag
Berker Peksag added the comment: New changeset deab1e54ff1695cdbe87f8db3d2c382d8e78330f by Erlend Egeberg Aasland in branch 'master': bpo-42847: Normalise Lib/sqlite3/test/* file encodings (GH-24147) https://github.com/python/cpython/commit/deab1e54ff1695cdbe87f8db3d2c382d8e78330f

[issue40823] Don't use obsolete unittest.makeSuite() in sqlite3 tests

2021-01-06 Thread Berker Peksag
Berker Peksag added the comment: Thank you! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement ___ Python tracker <https://bugs.python

[issue40823] Don't use obsolete unittest.makeSuite() in sqlite3 tests

2021-01-06 Thread Berker Peksag
Berker Peksag added the comment: New changeset 849e339a925fb398be31e566c31b99ce6cdb6006 by Erlend Egeberg Aasland in branch 'master': bpo-40823: Use loadTestsFromTestCase() iso. makeSuite() in sqlite3 tests (GH-20538) https://github.com/python/cpython/commit

[issue38413] Remove or change "Multithreading" section

2021-01-06 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed type: -> behavior ___ Python tracker <https://bugs.python.org/issue38413> ___ ___ Python-bugs-list

[issue38413] Remove or change "Multithreading" section

2021-01-06 Thread Berker Peksag
Berker Peksag added the comment: New changeset 49c150f1f16398a4e77e051244f27adc5ac7b47b by Vladimir in branch '3.9': bpo-38413: Remove outdated section about multithreading in sqlite3 (GH-23159) https://github.com/python/cpython/commit/49c150f1f16398a4e77e051244f27adc5ac7b47b

[issue14014] codecs.StreamWriter.reset contract not fulfilled

2021-01-05 Thread Berker Peksag
Change by Berker Peksag : -- assignee: -> docs@python components: -Unicode nosy: +docs@python -vstinner ___ Python tracker <https://bugs.python.org/issu

[issue14014] codecs.StreamWriter.reset contract not fulfilled

2021-01-05 Thread Berker Peksag
Change by Berker Peksag : -- assignee: lemburg -> components: +Documentation nosy: +vstinner resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 -Python 3.8 ___ Python tra

[issue14014] codecs.StreamWriter.reset contract not fulfilled

2021-01-05 Thread Berker Peksag
Berker Peksag added the comment: New changeset a3ca6747f50efa2fe59caf516a26b0fd1912b8e8 by Miss Islington (bot) in branch '3.9': bpo-14014: Clarify StreamWriter.reset() documentation (GH-13716) https://github.com/python/cpython/commit/a3ca6747f50efa2fe59caf516a26b0fd1912b8e8

  1   2   3   4   5   6   7   8   9   10   >