[issue38731] bad input crashes py_compile library

2020-07-25 Thread Berker Peksag


Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10, Python 3.9

___
Python tracker 
<https://bugs.python.org/issue38731>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38731] bad input crashes py_compile library

2020-07-25 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 949cf93f8ee27c37650483458f0aa3e295011ef6 by Miss Islington (bot) 
in branch '3.8':
bpo-38731: Fix NameError in command-line interface of py_compile (GH-21617)
https://github.com/python/cpython/commit/949cf93f8ee27c37650483458f0aa3e295011ef6


--

___
Python tracker 
<https://bugs.python.org/issue38731>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38731] bad input crashes py_compile library

2020-07-25 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 2024d7aca100c3faa9c6730aba3de5f0528750be by Berker Peksag in 
branch '3.9':
bpo-38731: Fix NameError in command-line interface of py_compile (GH-21617)
https://github.com/python/cpython/commit/2024d7aca100c3faa9c6730aba3de5f0528750be


--

___
Python tracker 
<https://bugs.python.org/issue38731>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38731] bad input crashes py_compile library

2020-07-25 Thread Berker Peksag


Change by Berker Peksag :


--
pull_requests: +20759
pull_request: https://github.com/python/cpython/pull/21617

___
Python tracker 
<https://bugs.python.org/issue38731>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38731] bad input crashes py_compile library

2020-07-25 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset daff39070e7ea71b0ba49d9150ac7a210a125682 by Gregory Schevchenko 
in branch 'master':
bpo-38731: Add --quiet option to py_compile CLI (GH-17134)
https://github.com/python/cpython/commit/daff39070e7ea71b0ba49d9150ac7a210a125682


--

___
Python tracker 
<https://bugs.python.org/issue38731>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40456] Complete adding silent mode for py_compile

2020-07-25 Thread Berker Peksag


Berker Peksag  added the comment:

This is a duplicate of issue 38731. The inline patch in msg373791 is incorrect. 
I'll fix the error in maintenance releases by partially reverting commit 
2e33ecd7c9b0cac3efc6fcbdd4547fd086b4e2d1.

--
nosy: +berker.peksag
resolution:  -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder:  -> bad input crashes py_compile library

___
Python tracker 
<https://bugs.python.org/issue40456>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31844] HTMLParser: undocumented not implemented method

2020-07-16 Thread Berker Peksag


Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue31844>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31844] HTMLParser: undocumented not implemented method

2020-07-16 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset d4d127f1c6e586036104e4101f5af239fe7dc156 by Berker Peksag in 
branch 'master':
bpo-31844: Move whatsnew note to 3.10.rst (GH-21504)
https://github.com/python/cpython/commit/d4d127f1c6e586036104e4101f5af239fe7dc156


--

___
Python tracker 
<https://bugs.python.org/issue31844>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31844] HTMLParser: undocumented not implemented method

2020-07-16 Thread Berker Peksag


Change by Berker Peksag :


--
pull_requests: +20644
stage: test needed -> patch review
pull_request: https://github.com/python/cpython/pull/21504

___
Python tracker 
<https://bugs.python.org/issue31844>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31844] HTMLParser: undocumented not implemented method

2020-07-16 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset e34bbfd61f405eef89e8aa50672b0b25022de320 by Berker Peksag in 
branch 'master':
bpo-31844: Remove _markupbase.ParserBase.error() (GH-8562)
https://github.com/python/cpython/commit/e34bbfd61f405eef89e8aa50672b0b25022de320


--

___
Python tracker 
<https://bugs.python.org/issue31844>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40784] test_sqlite: CheckFuncDeterministic() fails with SQLite 3.32

2020-05-28 Thread Berker Peksag


Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
type:  -> behavior

___
Python tracker 
<https://bugs.python.org/issue40784>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40784] test_sqlite: CheckFuncDeterministic() fails with SQLite 3.32

2020-05-28 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset c610d970f5373b143bf5f5900d4645e6a90fb460 by Erlend Egeberg 
Aasland in branch 'master':
bpo-40784: Fix sqlite3 deterministic test (GH-20448)
https://github.com/python/cpython/commit/c610d970f5373b143bf5f5900d4645e6a90fb460


--
nosy: +berker.peksag

___
Python tracker 
<https://bugs.python.org/issue40784>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

2020-05-28 Thread Berker Peksag


Berker Peksag  added the comment:

+1 for dropping support for < 3.7.15 in master. We should fix or skip tests in 
maintenance branches.

--
stage:  -> needs patch
type:  -> enhancement

___
Python tracker 
<https://bugs.python.org/issue40810>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39652] sqlite3 bug handling column names that contain square braces

2020-03-11 Thread Berker Peksag


Berker Peksag  added the comment:

https://github.com/ghaering/pysqlite/commit/f3d452f2daeb432b8ad89fa4f087164bfd6ddc12
 should probably give more context than that huge svnmerge commit :)

(Removed older Python versions since even if decide to change the behavior from 
2006, it may break third-party programs that are relying on it.)

--
versions:  -Python 2.7, Python 3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 
<https://bugs.python.org/issue39652>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30566] punycode codec raises IndexError in decode_generalized_number()

2020-02-24 Thread Berker Peksag


Berker Peksag  added the comment:

Thanks for the report and for the initial patch!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.7, Python 3.8, Python 3.9 -Python 3.6

___
Python tracker 
<https://bugs.python.org/issue30566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30566] punycode codec raises IndexError in decode_generalized_number()

2020-02-24 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset daef21ce7dfd3735101d85d6ebf7554187c33ab8 by Miss Islington (bot) 
in branch '3.8':
bpo-30566: Fix IndexError when using punycode codec (GH-18632)
https://github.com/python/cpython/commit/daef21ce7dfd3735101d85d6ebf7554187c33ab8


--

___
Python tracker 
<https://bugs.python.org/issue30566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30566] punycode codec raises IndexError in decode_generalized_number()

2020-02-24 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 55be9a6c09d4415f50b14212ce22eccefa83ca64 by Miss Islington (bot) 
in branch '3.7':
bpo-30566: Fix IndexError when using punycode codec (GH-18632)
https://github.com/python/cpython/commit/55be9a6c09d4415f50b14212ce22eccefa83ca64


--

___
Python tracker 
<https://bugs.python.org/issue30566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30566] punycode codec raises IndexError in decode_generalized_number()

2020-02-24 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset ba22e8f174309979d90047c5dc64fcb63bc2c32e by Berker Peksag in 
branch 'master':
bpo-30566: Fix IndexError when using punycode codec (GH-18632)
https://github.com/python/cpython/commit/ba22e8f174309979d90047c5dc64fcb63bc2c32e


--

___
Python tracker 
<https://bugs.python.org/issue30566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30566] punycode codec raises IndexError in decode_generalized_number()

2020-02-23 Thread Berker Peksag


Change by Berker Peksag :


--
keywords: +patch
nosy: +berker.peksag
nosy_count: 3.0 -> 4.0
pull_requests: +17998
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18632

___
Python tracker 
<https://bugs.python.org/issue30566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37539] CheckCommitCursorReset regression sqlite3 test fails with old sqlite3

2020-02-23 Thread Berker Peksag


Berker Peksag  added the comment:

Thank you for the report and for the patch!

The minimum supported SQLite 3 version in Python 3 is 3.7.2 as declared at 
https://github.com/python/cpython/blob/9f37872e307734666a7169f7be6e3370d3068282/setup.py#L1364
 

While it's still 3.0.8 in Python 2.7 
(https://github.com/python/cpython/blob/249706c1fbce04125d81bd9993e6c010ae30f8e4/setup.py#L1175),
 I think we can live without the patch as Python 2.7 is now officially dead.

Of course, we can still apply it if one of our 2.7 buildbots were failing due 
to an ancient version of SQLite 3.

--
resolution:  -> wont fix
stage:  -> resolved
status: open -> closed
type:  -> behavior
versions:  -Python 3.8, Python 3.9

___
Python tracker 
<https://bugs.python.org/issue37539>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2771] Test issue

2020-02-22 Thread Berker Peksag


Change by Berker Peksag :


--
nosy: +berker.peksag, brett.cannon
nosy_count: 8.0 -> 10.0
pull_requests: +17979
pull_request: https://github.com/python/cpython/pull/18614

___
Python tracker 
<https://bugs.python.org/issue2771>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2771] Test issue

2020-02-22 Thread Berker Peksag


Change by Berker Peksag :


--
nosy:  -brett.cannon

___
Python tracker 
<https://bugs.python.org/issue2771>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35950] io.BufferedReader.writabe is False, but io.BufferedReader.truncate does not raise OSError

2020-02-21 Thread Berker Peksag


Change by Berker Peksag :


--
nosy: +berker.peksag

___
Python tracker 
<https://bugs.python.org/issue35950>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35950] io.BufferedReader.writabe is False, but io.BufferedReader.truncate does not raise OSError

2020-02-20 Thread Berker Peksag


Change by Berker Peksag :


--
pull_requests: +17956
pull_request: https://github.com/python/cpython/pull/18586

___
Python tracker 
<https://bugs.python.org/issue35950>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39514] http://sphinx.pocoo.org/

2020-02-03 Thread Berker Peksag


Berker Peksag  added the comment:

My PR has been merged and I've verified that the link is now point to 
https://www.sphinx-doc.org/. Closing this as 'fixed'.

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue39514>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39496] Inelegant loops in Modules/_sqlite/cursor.c

2020-02-01 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 78c7183f470b60a39ac2dd0ad1a94d49d1e0b062 by Alex Henrie in branch 
'master':
bpo-39496: Remove redundant checks from _sqlite/cursor.c (GH-18270)
https://github.com/python/cpython/commit/78c7183f470b60a39ac2dd0ad1a94d49d1e0b062


--
nosy: +berker.peksag

___
Python tracker 
<https://bugs.python.org/issue39496>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39496] Inelegant loops in Modules/_sqlite/cursor.c

2020-02-01 Thread Berker Peksag


Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue39496>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39514] http://sphinx.pocoo.org/

2020-02-01 Thread Berker Peksag


Berker Peksag  added the comment:

https://github.com/python/docsbuild-scripts/pull/83

--

___
Python tracker 
<https://bugs.python.org/issue39514>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39514] http://sphinx.pocoo.org/

2020-01-31 Thread Berker Peksag


Berker Peksag  added the comment:

Thanks for the report. The link has already been fixed in 
https://github.com/python/python-docs-theme/commit/fc9f203dd79587c8aed2b822cf7401518cd65bb5
 I think it will be fixed once the new version of the theme is released.

We can discuss the details over at python/python-docs-theme. Closing this issue 
for now.

--
nosy: +berker.peksag, zach.ware
resolution:  -> out of date
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue39514>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39497] Unused variable script_str in pysqlite_cursor_executescript

2020-01-30 Thread Berker Peksag


Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
type: performance -> 

___
Python tracker 
<https://bugs.python.org/issue39497>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39497] Unused variable script_str in pysqlite_cursor_executescript

2020-01-30 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 1f44e775df8e7ec3ca60a1135cb3279f8b9dca3e by Alex Henrie in branch 
'master':
bpo-39497: Remove unused variable from pysqlite_cursor_executescript (GH-18271)
https://github.com/python/cpython/commit/1f44e775df8e7ec3ca60a1135cb3279f8b9dca3e


--
nosy: +berker.peksag

___
Python tracker 
<https://bugs.python.org/issue39497>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39494] Extra null terminators in keyword arrays in sqlite module

2020-01-29 Thread Berker Peksag


Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
type: resource usage -> 

___
Python tracker 
<https://bugs.python.org/issue39494>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39494] Extra null terminators in keyword arrays in sqlite module

2020-01-29 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 188bb5b1e868eecf2342195dc45caa332ac3b6c7 by Alex Henrie in branch 
'master':
bpo-39494: Remove extra null terminators from kwlist vars (GH-18267)
https://github.com/python/cpython/commit/188bb5b1e868eecf2342195dc45caa332ac3b6c7


--
nosy: +berker.peksag

___
Python tracker 
<https://bugs.python.org/issue39494>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39309] Please delete my account

2020-01-26 Thread Berker Peksag


Change by Berker Peksag :


--
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue39309>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12915] Add inspect.locate and inspect.resolve

2020-01-25 Thread Berker Peksag


Berker Peksag  added the comment:

FTR, Django has a similar helper:

from django.utils.module_loading import import_string

ValidationError = import_string('django.core.exceptions.ValidationError')

https://docs.djangoproject.com/en/3.0/ref/utils/#django.utils.module_loading.import_string

--

___
Python tracker 
<https://bugs.python.org/issue12915>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39309] Please delete my account

2020-01-25 Thread Berker Peksag


Berker Peksag  added the comment:

I can remove OP's User role and change their user name etc. to make it 
anonymize as much as possible. I cannot get into the server so perhaps Ernest 
can delete the account.

--
nosy: +EWDurbin, berker.peksag

___
Python tracker 
<https://bugs.python.org/issue39309>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36654] Add example to tokenize.tokenize

2020-01-25 Thread Berker Peksag


Berker Peksag  added the comment:

Wow, I managed to make typos in all three commits!

PR 12947 has some discussion about why adding these examples would be a good 
idea as we now have two different APIs for unicode and bytes input.

Thanks for the PR, Windson.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9 -Python 3.5, Python 3.6

___
Python tracker 
<https://bugs.python.org/issue36654>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36654] Add example to tokenize.tokenize

2020-01-25 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 6dbd843dedc9e05c0e3f4714294837f0a83deebe by Berker Peksag (Miss 
Islington (bot)) in branch '3.7':
bpo-36654: Add examples for using tokenize module programmatically (GH-12947)
https://github.com/python/cpython/commit/6dbd843dedc9e05c0e3f4714294837f0a83deebe


--

___
Python tracker 
<https://bugs.python.org/issue36654>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36654] Add example to tokenize.tokenize

2020-01-25 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 1cf0df4f1bcc38dfd70a152af20cf584de531ea7 by Berker Peksag (Miss 
Islington (bot)) in branch '3.8':
bpo-36654: Add examples for using tokenize module programmatically (GH-18187)
https://github.com/python/cpython/commit/1cf0df4f1bcc38dfd70a152af20cf584de531ea7


--

___
Python tracker 
<https://bugs.python.org/issue36654>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36654] Add example to tokenize.tokenize

2020-01-25 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 4b09dc79f4d08d85f2cc945563e9c8ef1e531d7b by Berker Peksag 
(Windson yang) in branch 'master':
bpo-36654: Add examples for using tokenize module programmically (#12947)
https://github.com/python/cpython/commit/4b09dc79f4d08d85f2cc945563e9c8ef1e531d7b


--
nosy: +berker.peksag

___
Python tracker 
<https://bugs.python.org/issue36654>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15243] Misleading documentation for __prepare__

2020-01-25 Thread Berker Peksag


Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.7, Python 3.8, Python 3.9 -Python 3.5, Python 3.6

___
Python tracker 
<https://bugs.python.org/issue15243>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15243] Misleading documentation for __prepare__

2020-01-25 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 548685e364af3d366d3aef924b2077ee6f8d13dc by Berker Peksag (Miss 
Islington (bot)) in branch '3.7':
bpo-15243: Document __prepare__ as classmethod (GH-17124)
https://github.com/python/cpython/commit/548685e364af3d366d3aef924b2077ee6f8d13dc


--

___
Python tracker 
<https://bugs.python.org/issue15243>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15243] Misleading documentation for __prepare__

2020-01-25 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 321491a536c378227f9d574703f7c06f89c67dcf by Berker Peksag (Miss 
Islington (bot)) in branch '3.8':
bpo-15243: Document __prepare__ as classmethod (GH-17124)
https://github.com/python/cpython/commit/321491a536c378227f9d574703f7c06f89c67dcf


--

___
Python tracker 
<https://bugs.python.org/issue15243>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15243] Misleading documentation for __prepare__

2020-01-25 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 7de617455ed788e6730c40cf854c4b72b0432194 by Berker Peksag 
(alclarks) in branch 'master':
bpo-15243: Document __prepare__ as classmethod (GH-17124)
https://github.com/python/cpython/commit/7de617455ed788e6730c40cf854c4b72b0432194


--

___
Python tracker 
<https://bugs.python.org/issue15243>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39366] Remove deprecated nntplib method

2020-01-22 Thread Berker Peksag


Berker Peksag  added the comment:

Thanks for the PR! I'm glad these previously deprecated functions are now gone.

--
components: +Library (Lib)
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
type:  -> enhancement

___
Python tracker 
<https://bugs.python.org/issue39366>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39366] Remove deprecated nntplib method

2020-01-22 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 1f0f102dec506fd06f912b74dd2be64a7fba0d3f by Berker Peksag 
(Dong-hee Na) in branch 'master':
bpo-39366: Remove xpath() and xgtitle() methods of NNTP (GH-18035)
https://github.com/python/cpython/commit/1f0f102dec506fd06f912b74dd2be64a7fba0d3f


--
nosy: +berker.peksag

___
Python tracker 
<https://bugs.python.org/issue39366>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34480] _markupbase.py fails with UnboundLocalError on invalid keyword in marked section

2020-01-05 Thread Berker Peksag


Berker Peksag  added the comment:

> _markupbase.py is internal, so it should be safe to remove
> ParserBase.error() and the code that calls it as suggested in #31844

Should I reopen https://github.com/python/cpython/pull/8562 then?

--

___
Python tracker 
<https://bugs.python.org/issue34480>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38731] bad input crashes py_compile library

2019-11-07 Thread Berker Peksag


Change by Berker Peksag :


--
nosy: +berker.peksag
stage:  -> needs patch
type: crash -> behavior
versions: +Python 3.9

___
Python tracker 
<https://bugs.python.org/issue38731>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29553] Argparser does not display closing parentheses in nested mutex groups

2019-08-30 Thread Berker Peksag


Berker Peksag  added the comment:

Yes, we can. Thank you for the backport, Raymond :)

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue29553>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29553] Argparser does not display closing parentheses in nested mutex groups

2019-08-30 Thread Berker Peksag


Berker Peksag  added the comment:

da27d9b9dc44913ffee8f28d9638985eaaa03755 needs to be manually backported to 3.8.

--
stage: patch review -> backport needed
versions: +Python 3.8 -Python 2.7, Python 3.5

___
Python tracker 
<https://bugs.python.org/issue29553>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29553] Argparser does not display closing parentheses in nested mutex groups

2019-08-25 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 31ea447ffe591736af1d7a3178c0f7ca3eb50d70 by Berker Peksag (Miss 
Islington (bot)) in branch '3.7':
bpo-29553: Fix ArgumentParser.format_usage() for mutually exclusive groups 
(GH-14976)
https://github.com/python/cpython/commit/31ea447ffe591736af1d7a3178c0f7ca3eb50d70


--

___
Python tracker 
<https://bugs.python.org/issue29553>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29553] Argparser does not display closing parentheses in nested mutex groups

2019-08-25 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset da27d9b9dc44913ffee8f28d9638985eaaa03755 by Berker Peksag 
(Flavian Hautbois) in branch 'master':
bpo-29553: Fix ArgumentParser.format_usage() for mutually exclusive groups 
(GH-14976)
https://github.com/python/cpython/commit/da27d9b9dc44913ffee8f28d9638985eaaa03755


--

___
Python tracker 
<https://bugs.python.org/issue29553>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36993] zipfile: tuple IndexError on extract

2019-06-01 Thread Berker Peksag


Berker Peksag  added the comment:

@alter-bug-tracer, could you please create test files for the cases Serhiy has 
just mentioned?

--

___
Python tracker 
<https://bugs.python.org/issue36993>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36976] email: AttributeError

2019-06-01 Thread Berker Peksag


Change by Berker Peksag :


--
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed
superseder:  -> Certain Malformed email causes email.parser to throw 
AttributeError

___
Python tracker 
<https://bugs.python.org/issue36976>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36992] zipfile: AttributeError on extract (LZMA)

2019-06-01 Thread Berker Peksag


Berker Peksag  added the comment:

This is a duplicate of issue 36991 and will be fixed by the same PR.

--
nosy: +berker.peksag
resolution: not a bug -> duplicate
superseder:  -> zipfile: AttributeError on extract

___
Python tracker 
<https://bugs.python.org/issue36992>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36993] zipfile: tuple IndexError on extract

2019-06-01 Thread Berker Peksag


Change by Berker Peksag :


--
keywords: +patch
pull_requests: +13611
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/13727

___
Python tracker 
<https://bugs.python.org/issue36993>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36993] zipfile: tuple IndexError on extract

2019-06-01 Thread Berker Peksag


Berker Peksag  added the comment:

This report is valid. Serhiy has improved error reporting of the extra field in 
feccdb2a249a71be330765be77dee57121866779.

counts can indeed be an empty tuple:

elif ln == 0:
counts = ()

If I'm reading section 4.5.3 of 
https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT correctly, I think 
we need to raise BadZipFile if ln == 0.

--
components: +Library (Lib)
nosy: +berker.peksag, serhiy.storchaka
resolution: not a bug -> 
stage: resolved -> needs patch
status: closed -> open
type:  -> behavior
versions:  -Python 3.6

___
Python tracker 
<https://bugs.python.org/issue36993>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14014] codecs.StreamWriter.reset contract not fulfilled

2019-05-31 Thread Berker Peksag


Change by Berker Peksag :


--
pull_requests: +13603
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/13716

___
Python tracker 
<https://bugs.python.org/issue14014>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34763] Python lacks 0x4E17

2019-05-31 Thread Berker Peksag


Berker Peksag  added the comment:

Tools/unicode/makeunicodedata.py looks at Unihan database for the fields 
kAccountingNumeric, kOtherNumeric, and kPrimaryNumeric in 
Unihan_NumericValues.txt:


https://github.com/python/cpython/blob/549e55a3086d04c13da9b6f33214f6399681292a/Tools/unicode/makeunicodedata.py#L1107-L1119

And as of Unicode version 12.0.0, 0x4E17 isn't listed as numeric there:

...
U+4E00  kPrimaryNumeric 1
U+4E03  kPrimaryNumeric 7
U+4E07  kPrimaryNumeric 1
U+4E09  kPrimaryNumeric 3
...

Is there another way to get this information by using one of the fields shown at

http://www.unicode.org/cgi-bin/GetUnihanData.pl?codepoint=4E17

--
nosy: +berker.peksag
versions: +Python 3.9 -Python 3.7

___
Python tracker 
<https://bugs.python.org/issue34763>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12202] Check status returns in msilib.SummaryInformation.GetProperty()

2019-05-31 Thread Berker Peksag


Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 2.7, Python 3.7

___
Python tracker 
<https://bugs.python.org/issue12202>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12202] Check status returns in msilib.SummaryInformation.GetProperty()

2019-05-31 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 549e55a3086d04c13da9b6f33214f6399681292a by Berker Peksag 
(Zackery Spytz) in branch 'master':
bpo-12202: Properly check MsiSummaryInfoGetProperty() calls in msilib (GH-13711)
https://github.com/python/cpython/commit/549e55a3086d04c13da9b6f33214f6399681292a


--

___
Python tracker 
<https://bugs.python.org/issue12202>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32628] Add configurable DirectoryIndex to http.server

2019-05-31 Thread Berker Peksag


Berker Peksag  added the comment:

Thank you for the report and for the patch!

What's your use case? I understand the need for it for httpd, but as someone 
who uses http.server daily, I can't think of a use case that I'd find this 
feature useful. Note that even the example in your message and the test in the 
patch use artificial file names :)

Handler.directory_index.append("index.htmlx") API doesn't look good to me. It 
would be nice to subclass it, but that would make http.server less usable 
(especially if you run it via "python -m http.server")

I suggest closing this as 'rejected' (sorry!)

--
nosy: +berker.peksag

___
Python tracker 
<https://bugs.python.org/issue32628>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12178] csv writer doesn't escape escapechar

2019-05-31 Thread Berker Peksag


Change by Berker Peksag :


--
pull_requests: +13597
pull_request: https://github.com/python/cpython/pull/13710

___
Python tracker 
<https://bugs.python.org/issue12178>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33361] readline() + seek() on codecs.EncodedFile breaks next readline()

2019-05-31 Thread Berker Peksag


Berker Peksag  added the comment:

Thank you for the report, Diego and thank you for the patch, Ammar!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 2.7, Python 3.4, Python 3.5, Python 3.6

___
Python tracker 
<https://bugs.python.org/issue33361>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33361] readline() + seek() on codecs.EncodedFile breaks next readline()

2019-05-31 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset a6dc5d4e1c9ef465dc1f1ad95c382aa8e32b178f by Berker Peksag (Miss 
Islington (bot)) in branch '3.7':
bpo-33361: Fix bug with seeking in StreamRecoders (GH-8278)
https://github.com/python/cpython/commit/a6dc5d4e1c9ef465dc1f1ad95c382aa8e32b178f


--

___
Python tracker 
<https://bugs.python.org/issue33361>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33361] readline() + seek() on codecs.EncodedFile breaks next readline()

2019-05-31 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset a6ec1ce1ac05b1258931422e96eac215b6a05459 by Berker Peksag (Ammar 
Askar) in branch 'master':
bpo-33361: Fix bug with seeking in StreamRecoders (GH-8278)
https://github.com/python/cpython/commit/a6ec1ce1ac05b1258931422e96eac215b6a05459


--
nosy: +berker.peksag

___
Python tracker 
<https://bugs.python.org/issue33361>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36271] '_io.TextIOWrapper' object has no attribute 'mode'

2019-05-30 Thread Berker Peksag


Berker Peksag  added the comment:

Thank you for the report. This is a duplicate of issue 32655.

--
nosy: +berker.peksag
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed
superseder:  -> File mode should be a constant

___
Python tracker 
<https://bugs.python.org/issue36271>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32655] File mode should be a constant

2019-05-30 Thread Berker Peksag


Berker Peksag  added the comment:

Changing the value of mode also changes its repr. This seems like a bug to me. 
It's probably too late to change TextIOWrapper.__repr__(). I think this needs 
to be discussed on python-dev first.

>>> f = open("README.rst")
>>> f
<_io.TextIOWrapper name='README.rst' mode='r' encoding='UTF-8'>
>>> f.writable()
False
>>> f.mode = "w"
>>> f.writable()
False
>>> f
<_io.TextIOWrapper name='README.rst' mode='w' encoding='UTF-8'>

There's an commented-out code in the initial checkin:

https://github.com/python/cpython/commit/4fa88fa0ba35e25ad9be66ebbdaba9aca553dc8b#diff-b67be9e0a41447de808ba3b7099a44a8R2341

/*{"mode", (getter)TextIOWrapper_mode_get, NULL, NULL},
*/

TextIOWrapper.__repr__() was updated to include 'mode' in 
https://github.com/python/cpython/commit/a4815caa7ccf21aa994d0e0eec66873072f0e352

See issue 36271 for a related report. The OP was confused because we don't set 
mode manually in gzip.open() and bz2.open() (as opposed to what we do in 
io.open() and tokenize.open())

--
nosy: +berker.peksag, pitrou
stage:  -> test needed
versions: +Python 3.9 -Python 3.7

___
Python tracker 
<https://bugs.python.org/issue32655>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35950] io.BufferedReader.writabe is False, but io.BufferedReader.truncate does not raise OSError

2019-05-30 Thread Berker Peksag


Change by Berker Peksag :


--
keywords: +patch
pull_requests: +13577
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/13689

___
Python tracker 
<https://bugs.python.org/issue35950>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22454] Adding the opposite function of shlex.split()

2019-05-29 Thread Berker Peksag


Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue22454>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22640] Add silent mode for py_compile

2019-05-28 Thread Berker Peksag


Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8 -Python 3.5

___
Python tracker 
<https://bugs.python.org/issue22640>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22640] Add silent mode for py_compile

2019-05-28 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 2e33ecd7c9b0cac3efc6fcbdd4547fd086b4e2d1 by Berker Peksag 
(Joannah Nanjekye) in branch 'master':
bpo-22640: Add silent mode to py_compile.compile() (GH-12976)
https://github.com/python/cpython/commit/2e33ecd7c9b0cac3efc6fcbdd4547fd086b4e2d1


--

___
Python tracker 
<https://bugs.python.org/issue22640>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36991] zipfile: AttributeError on extract

2019-05-28 Thread Berker Peksag


Berker Peksag  added the comment:

The OP's report is valid and they already stated that the file is malformed. 
More importantly, this can be reproduced with a valid ZIP file as well.

The correct behavior is to get RuntimeError in this case.

_check_compression() needs to be called before _get_decompressor().

There is no issue when getting the compressor object because 
_check_compression() is called inside _writecheck().

--
components: +Library (Lib)
nosy: +berker.peksag, serhiy.storchaka
resolution: not a bug -> 
stage: resolved -> patch review
status: closed -> open

___
Python tracker 
<https://bugs.python.org/issue36991>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36991] zipfile: AttributeError on extract

2019-05-28 Thread Berker Peksag


Change by Berker Peksag :


--
pull_requests: +13532
pull_request: https://github.com/python/cpython/pull/13632

___
Python tracker 
<https://bugs.python.org/issue36991>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27860] Improvements to ipaddress module

2019-05-27 Thread Berker Peksag


Change by Berker Peksag :


--
nosy:  -berker.peksag

___
Python tracker 
<https://bugs.python.org/issue27860>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8138] wsgiref.simple_server.SimpleServer claims to be multithreaded

2019-05-24 Thread Berker Peksag


Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 3.7

___
Python tracker 
<https://bugs.python.org/issue8138>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8138] wsgiref.simple_server.SimpleServer claims to be multithreaded

2019-05-24 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 14738ff83d852c95a0cf33e5c90a85860a9c5620 by Berker Peksag in 
branch 'master':
bpo-8138: Initialize wsgiref's SimpleServer as single-threaded (GH-12977)
https://github.com/python/cpython/commit/14738ff83d852c95a0cf33e5c90a85860a9c5620


--

___
Python tracker 
<https://bugs.python.org/issue8138>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36948] NameError in urllib.request.URLopener.retrieve

2019-05-21 Thread Berker Peksag


Berker Peksag  added the comment:

Thanks!

--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue36948>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36948] NameError in urllib.request.URLopener.retrieve

2019-05-21 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 2725cb01d7cbf5caecb51cc20d97ba324b09ce96 by Berker Peksag in 
branch 'master':
bpo-36948: Fix test_urlopener_retrieve_file on Windows (GH-13476)
https://github.com/python/cpython/commit/2725cb01d7cbf5caecb51cc20d97ba324b09ce96


--

___
Python tracker 
<https://bugs.python.org/issue36948>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36948] NameError in urllib.request.URLopener.retrieve

2019-05-21 Thread Berker Peksag


Berker Peksag  added the comment:

Thank you for the heads up, David. Could you please take a look at PR 13476?

--

___
Python tracker 
<https://bugs.python.org/issue36948>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36948] NameError in urllib.request.URLopener.retrieve

2019-05-21 Thread Berker Peksag


Change by Berker Peksag :


--
pull_requests: +13388
stage: resolved -> patch review

___
Python tracker 
<https://bugs.python.org/issue36948>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36948] NameError in urllib.request.URLopener.retrieve

2019-05-21 Thread Berker Peksag


Change by Berker Peksag :


--
status: closed -> open

___
Python tracker 
<https://bugs.python.org/issue36948>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34580] sqlite doc: clarify the scope of the context manager

2019-05-19 Thread Berker Peksag


Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 3.6

___
Python tracker 
<https://bugs.python.org/issue34580>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34580] sqlite doc: clarify the scope of the context manager

2019-05-19 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 205c1f0e36e00e6e7cb7fbabaab4f52732859f9e by Berker Peksag (Miss 
Islington (bot)) in branch '3.7':
bpo-34580: Update sqlite3 examples to call close() explicitly (GH-9079)
https://github.com/python/cpython/commit/205c1f0e36e00e6e7cb7fbabaab4f52732859f9e


--

___
Python tracker 
<https://bugs.python.org/issue34580>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34580] sqlite doc: clarify the scope of the context manager

2019-05-19 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 287b84de939db47aa8c6f30734ceb8aba9d1db29 by Berker Peksag 
(Xtreak) in branch 'master':
bpo-34580: Update sqlite3 examples to call close() explicitly (GH-9079)
https://github.com/python/cpython/commit/287b84de939db47aa8c6f30734ceb8aba9d1db29


--

___
Python tracker 
<https://bugs.python.org/issue34580>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29183] Unintuitive error handling in wsgiref when a crash happens in write() or close()

2019-05-19 Thread Berker Peksag


Change by Berker Peksag :


--
components: +Library (Lib)
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.7, Python 3.8 -Python 2.7, Python 3.4, Python 3.5, Python 
3.6

___
Python tracker 
<https://bugs.python.org/issue29183>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29183] Unintuitive error handling in wsgiref when a crash happens in write() or close()

2019-05-19 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset f393e8eb463d60ce559982613429568c518ab8d9 by Berker Peksag (Miss 
Islington (bot)) in branch '3.7':
bpo-29183: Fix double exceptions in wsgiref.handlers.BaseHandler (GH-12914)
https://github.com/python/cpython/commit/f393e8eb463d60ce559982613429568c518ab8d9


--

___
Python tracker 
<https://bugs.python.org/issue29183>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29183] Unintuitive error handling in wsgiref when a crash happens in write() or close()

2019-05-19 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset 7c59362a15dfce538512ff1fce4e07d33a925cfb by Berker Peksag in 
branch 'master':
bpo-29183: Fix double exceptions in wsgiref.handlers.BaseHandler (GH-12914)
https://github.com/python/cpython/commit/7c59362a15dfce538512ff1fce4e07d33a925cfb


--
nosy: +berker.peksag

___
Python tracker 
<https://bugs.python.org/issue29183>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36948] NameError in urllib.request.URLopener.retrieve

2019-05-19 Thread Berker Peksag


Berker Peksag  added the comment:

Thanks! Apparently, backport to 3.7 isn't needed, so I just closed PR 13422.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue36948>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36567] DOC: manpage directive doesn't create hyperlink

2019-05-19 Thread Berker Peksag


Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue36567>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36948] NameError in urllib.request.URLopener.retrieve

2019-05-19 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset c661b30f89ffe7a7995538d3b1649469b184bee4 by Berker Peksag 
(Xtreak) in branch 'master':
bpo-36948: Fix NameError in urllib.request.URLopener.retrieve (GH-13389)
https://github.com/python/cpython/commit/c661b30f89ffe7a7995538d3b1649469b184bee4


--
nosy: +berker.peksag

___
Python tracker 
<https://bugs.python.org/issue36948>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36962] Cant sort ModuleInfo instances

2019-05-19 Thread Berker Peksag


Berker Peksag  added the comment:

I agree with Eric that this use case can be easily covered by using sorted(..., 
key=...).

I suggest closing this as 'rejected'.

--
nosy: +berker.peksag

___
Python tracker 
<https://bugs.python.org/issue36962>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36567] DOC: manpage directive doesn't create hyperlink

2019-05-18 Thread Berker Peksag

Berker Peksag  added the comment:


New changeset eab99650799699f766c2660f4cfa8ff3f9e8457f by Berker Peksag 
(Batuhan Ta┼čkaya) in branch 'master':
bpo-36567: Use manpages_url to create links for man pages (GH-13339)
https://github.com/python/cpython/commit/eab99650799699f766c2660f4cfa8ff3f9e8457f


--
nosy: +berker.peksag

___
Python tracker 
<https://bugs.python.org/issue36567>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36865] FileInput does not allow 'rt' mode, but all its existing delegates do

2019-05-12 Thread Berker Peksag


Berker Peksag  added the comment:

Thank you for the report and the PR!

I think accepting 'rt' mode is a good idea. However, it's a new feature and it 
can only go into 3.8.

It seems to me that the root cause of the issue is that the fileinput module 
wasn't properly converted to support Python 3. Perhaps we could change 'r' to 
'rt' in FileInput.__init__() or hook_compressed() to make it work properly, so 
the example in issue 5758 would work as expected without changing any user code:

# test.py

import fileinput

for line in fileinput.FileInput(openhook=fileinput.hook_compressed):
print(line.rstrip())


$ ./python.exe test.py mike.txt mike.txt.gz
Hello from Mike.
This is the second line.
Why did the robot cross the road?
Hello from Mike.
This is the second line.
Why did the robot cross the road?

--
nosy: +serhiy.storchaka

___
Python tracker 
<https://bugs.python.org/issue36865>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34916] Add create_window_function() to sqlite3.Connection

2019-05-11 Thread Berker Peksag


Berker Peksag  added the comment:

Issue 35360 will cover updating our Windows and macOS installers. I'm 
retargeting this issue to add a create_window_function() method to the 
Connection object. I already have a WIP branch and am going to submit a PR 
later this weekend.

--
assignee:  -> berker.peksag
components: +Extension Modules
nosy: +berker.peksag
stage:  -> needs patch
title: include sqlite-3.25+ (with window functions) -> Add 
create_window_function() to sqlite3.Connection
type: behavior -> enhancement
versions: +Python 3.8

___
Python tracker 
<https://bugs.python.org/issue34916>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35398] SQLite incorrect row count for UPDATE

2019-05-11 Thread Berker Peksag


Change by Berker Peksag :


--
nosy: +berker.peksag

___
Python tracker 
<https://bugs.python.org/issue35398>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

2019-05-10 Thread Berker Peksag


Berker Peksag  added the comment:

> I looked at other examples: they are nice but far from a "real application".

You can use the same argument for pretty much every example in the stdlib 
documentation :)

wsgiref is a low level module, users should use projects like WebOb instead. 
Also, a complete example would need to contain basic routing and middleware 
support (which is not easy to implement correctly)

> Would you mind to elaborate? I don't understand what you mean by "naming 
> convention" here, sorry.

For example, the response() callable in the example is explicitly documented as 
start_response() in PEP :

https://www.python.org/dev/peps/pep-/#the-start-response-callable

You can read PEP  for more details.

> Do you mean that app() must not return FileWrapper? How do you return file 
> content in that case?
> Maybe FileWrapper API should be clarified? It's surprising to read Python 3.8 
> mentioning compatibility with Python 2.1 :-)

The whole point of the API was to support both __getitem__ and __iter__ 
protocols at the same time without breaking user code. I've already deprecated 
the support for __getitem__ protocol (84a13fbda0d79789e3c9efcc9f64752261ce1e8d) 
because it wasn't working as expected (it ignores its 'index' argument)

Its only valid use case is to read a file chunk by chunk by using its blksize 
argument, but there are much better ways to achieve the same thing (use 
os.sendfile() or nginx :))

> Which kind of exceptions do you expect? The example checks if the file exists 
> for example.

I'm talking about exceptions that can be raised by the application code, such 
as the one that I've mentioned (i.e. mimetypes) in my earlier comment.

Sorry, but it's not really a good example to put into documentation and it 
would be much better if we could save our bikeshedding bandwidth to other 
issues :)

--

___
Python tracker 
<https://bugs.python.org/issue36345>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30262] Don't expose sqlite3 Cache and Statement

2019-05-09 Thread Berker Peksag


Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8 -Python 3.7

___
Python tracker 
<https://bugs.python.org/issue30262>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30262] Don't expose sqlite3 Cache and Statement

2019-05-09 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset e6576248e5174ca5daa362cfd610c07e7eb3a2ae by Berker Peksag (Aviv 
Palivoda) in branch 'master':
bpo-30262: Don't expose private objects in sqlite3 (GH-1440)
https://github.com/python/cpython/commit/e6576248e5174ca5daa362cfd610c07e7eb3a2ae


--

___
Python tracker 
<https://bugs.python.org/issue30262>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30271] Make sqlite3 statement cache optional

2019-05-09 Thread Berker Peksag


Change by Berker Peksag :


--
resolution:  -> rejected

___
Python tracker 
<https://bugs.python.org/issue30271>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   3   4   5   6   7   8   9   10   >