Changes by Collin Winter coll...@gmail.com:
--
nosy: -collinwinter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15079
___
___
Python-bugs-list
Collin Winter coll...@gmail.com added the comment:
I assume I was added to this thread since I wrote the functional module, so
I'll give my take in that capacity. IMO Python doesn't need a more general
version of partial(); indeed, I question the need for partial() as it is today.
Querying
Changes by Collin Winter coll...@gmail.com:
--
nosy: -collinwinter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9285
___
___
Python-bugs-list
Changes by Collin Winter coll...@gmail.com:
--
nosy: -collinwinter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2636
___
___
Python-bugs-list
Collin Winter coll...@gmail.com added the comment:
I have no interest in forward-porting the patch, closing accordingly. At least
there will be a record of this patch for anyone interested in getting a free
10% performance boost for their Python 2.x or 3.[012] systems.
--
assignee
Collin Winter coll...@gmail.com added the comment:
I have provided justification in the original patch submission. Without this
patch, we were unable to cleanly apply gcc's feedback-directed optimization
system to Python. FDO yields significant performance improvements
Collin Winter coll...@gmail.com added the comment:
This wasn't so much a feature request as a request for review. I had already
implemented the necessary changes and provided a patch.
We found this change necessary when working on Unladen Swallow
Collin Winter coll...@gmail.com added the comment:
I don't know that the variables are Python-specific. We used these variables to
build various Python modules statically against the versions of openssl and
sqlite maintained in Google's internal third-party repository.
--
assignee
Collin Winter coll...@gmail.com added the comment:
Christian: yes, that sounds fine.
--
assignee: collinwinter -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1625576
Changes by Collin Winter coll...@gmail.com:
--
nosy: +collinwinter, jyasskin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1731717
___
___
Python
Collin Winter coll...@gmail.com added the comment:
I tried making this work early last year as part of Unladen Swallow, and even
though I got it working and it does speed up certain builtin calls, it didn't
move overall application performance at all. I believe this was due to cache
effects
Changes by Collin Winter coll...@gmail.com:
--
nosy: +collinwinter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8566
___
___
Python-bugs-list
Collin Winter coll...@gmail.com added the comment:
Antoine: yes, this optimization is already implemented in the Unladen JIT.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1518
Collin Winter coll...@gmail.com added the comment:
I ran this patch against Unladen Swallow's slowspitfire template
benchmark, which does more int-string conversions than any of our other
benchmarks. When run against Python trunk r74737, I get these results:
slowspitfire:
Min: 0.888772
Collin Winter coll...@gmail.com added the comment:
FYI, Unladen Swallow includes several regex benchmark suites: a port of
V8's regex benchmarks (regex_v8); some of the regexes used when tuning
the existing sre engine 7-8 years ago (regex_effbot); and a
regex_compile benchmark that tests
Changes by Collin Winter coll...@gmail.com:
--
components: +Interpreter Core
nosy: +collinwinter, jyasskin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6643
New submission from Collin Winter coll...@gmail.com:
The attached patch fixes a number of tests to work when -OO is given to
Python. The majority of these tests are docstring-related, either doctests
or making assertions about __doc__, with a handful of tests testing that
assert statements
New submission from Collin Winter coll...@gmail.com:
This patch makes regrtest.py echo back the contents of sys.flags at the
beginning of a test run. Unladen Swallow has found this useful for
verifying that the regrtest.py settings in the Makefile and in our
Buildbot configs are interacting
Collin Winter coll...@gmail.com added the comment:
Standalone bytecode-modifying tools almost never check that they're
outputting correct bytecode. http://code.activestate.com/recipes/277940/
makes no attempt to check what version of Python it's running under;
running it under Unladen Swallow
Collin Winter coll...@gmail.com added the comment:
As another data point, Unladen Swallow had to take explicit steps to
deal with this dead code when compiling bytecode to machine code. Since
Python's compiler isn't smart enough to ignore code following a return
or raise in the same suite
Collin Winter coll...@gmail.com added the comment:
On Wed, Jun 3, 2009 at 2:36 AM, Marc-Andre Lemburg
rep...@bugs.python.org wrote:
Marc-Andre Lemburg m...@egenix.com added the comment:
All this is assuming the speed-up is important enough to bother. Has
anyone run a comparison benchmark
Changes by Collin Winter coll...@gmail.com:
--
nosy: +collinwinter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6133
___
___
Python-bugs-list
Collin Winter coll...@gmail.com added the comment:
On Fri, May 29, 2009 at 3:45 PM, Martin v. Löwis rep...@bugs.python.org wrote:
py s =
py s.join is s.join
False
Every time you read it, you get a new object. Not what I would call a
constant. If you don't see how this matters, try
def
Changes by Collin Winter coll...@gmail.com:
--
nosy: +collinwinter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6132
___
___
Python-bugs-list
Collin Winter coll...@gmail.com added the comment:
Fixed in r72930 (trunk), r72931 (2.6), r72942 (py3k).
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http
Collin Winter coll...@gmail.com added the comment:
Bug-fix patch attached. Alexandre, can you take a look? Feel free to
bounce it back if you don't have time.
I'll port to 2.6 and py3k once this is reviewed for trunk.
--
keywords: +26backport, easy, patch
nosy: +alexandre.vassalotti
Changes by Collin Winter coll...@gmail.com:
--
status: pending - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5866
___
___
Python-bugs
Collin Winter coll...@gmail.com added the comment:
Fixed the len(d) == 1 size regression. Final performance of the patch
relative to trunk:
Using Unladen Swallow's perf.py -b pickle,pickle_dict on trunk:
pickle:
Min: 2.238 - 1.895: 18.08% faster
Avg: 2.241 - 1.898: 18.04% faster
Significant (t
Collin Winter coll...@gmail.com added the comment:
Applied in r72792 (trunk), r72793 (py3k), r72808 (release26-maint).
--
assignee: - collinwinter
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http
New submission from Collin Winter coll...@gmail.com:
Lib/pickletools.py incorrectly thinks POP_MARK was part of protocol 0;
POP_MARK was only added with the introduction of protocol 1 in r7753.
This mistake led me down a dead end while fixing another pickling issue.
Alexandre, can you double
Collin Winter coll...@gmail.com added the comment:
Daniel, did you have any comments on this patch? If not, I'll go ahead
and commit it and close both of these issues.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6032
Collin Winter coll...@gmail.com added the comment:
I've posted a patch in issue 6032 (didn't see this one); I'd be
interested in any comments on the approach taken there.
--
nosy: +collinwinter
___
Python tracker rep...@bugs.python.org
http
Collin Winter coll...@gmail.com added the comment:
Daniel Diniz reviewed in the other issue.
Fixed in r72777 (trunk), r72778 (py3k).
--
assignee: - collinwinter
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
Collin Winter coll...@gmail.com added the comment:
Applied as r72777 (trunk), r72778 (py3k).
--
assignee: - collinwinter
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6032
Collin Winter coll...@gmail.com added the comment:
Daniel, which patch? freelists2.patch or unialloc4.patch? If these are
targeted py3k (judging by the Versions selector above), none of
Unladen Swallow's benchmarks work under 3k (we're focusing on 2.x
Changes by Collin Winter coll...@gmail.com:
--
nosy: +collinwinter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6042
___
___
Python-bugs-list
New submission from Collin Winter coll...@gmail.com:
Currently (r72673), test_urllib2_localnet leaks references. This is due
to state implicitly shared between tests. The attached patch fixes this
by removing the shared state.
The problem is also present in py3k. I'll port the patch once I
Collin Winter coll...@gmail.com added the comment:
Yes, this is a patch for issue 6002 (sorry, didn't find it). I haven't
seen any refleaks from issue 1208304, but I was only looking at this one
particular failure (since it was showing up in Unladen Swallow's refleak
builds
New submission from Collin Winter coll...@gmail.com:
Currently (r72643), regrtest.py -R:: says that a test passed even if it
leaked references:
trunk collinwinter$ ./python.exe Lib/test/regrtest.py -R::
test_urllib2_localnet
test_urllib2_localnet
beginning 9 repetitions
123456789
Changes by Collin Winter coll...@gmail.com:
Added file: http://bugs.python.org/file13986/refleak.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6024
Changes by Collin Winter coll...@gmail.com:
Removed file: http://bugs.python.org/file13985/refleak.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6024
Collin Winter coll...@gmail.com added the comment:
Applied in r72658 (trunk) and r72660 (py3k).
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6024
Collin Winter coll...@gmail.com added the comment:
2009/5/4 Tarek Ziadé rep...@bugs.python.org@psf.upfronthosting.co.za:
About the patch:
is there a particular reason why you have changed the call to
'set_library' into calls to 'add_library' in build_ext in your patch ?
Yes. It seems like
Changes by Collin Winter coll...@gmail.com:
--
nosy: +collinwinter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5794
___
___
Python-bugs-list
Collin Winter coll...@gmail.com added the comment:
Interestingly, it only fails with protocol 0:
v = ([],)
v[0].append(v)
import pickle,cPickle
cPickle.loads(pickle.dumps(v, 0))
Traceback (most recent call last):
File stdin, line 1, in module
cPickle.UnpicklingError: unpickling stack
Collin Winter coll...@gmail.com added the comment:
Committed as r71408 (trunk) and r71638 (py3k).
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5665
Collin Winter coll...@gmail.com added the comment:
Yes, I'm porting them. I got started, but got distracted by other things
since there were a lot of conflicts in the merge
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5665
Collin Winter coll...@gmail.com added the comment:
If no-one has any objections to the xpickle resource included in the
latest version of the patch, I'd like to commit this soon so that we can
be more confident in the other changes I have queued up. If I no-one
objects, I'll commit this sometime
Collin Winter coll...@gmail.com added the comment:
Ok if it doesn't take too long to run the tests (which may imply
implementing something like Raymond's suggestion of randomizing test
order, if you haven't already done so).
I did something similar: if you don't pass the -uxpickle flag
Changes by Collin Winter coll...@gmail.com:
--
nosy: +collinwinter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3873
___
___
Python-bugs-list
Collin Winter coll...@gmail.com added the comment:
I've added a microbenchmark to perf.py called pickle_list. Running that
on this change (perf.py -r -b pickle_list):
pickle_list:
Min: 1.126 - 0.888: 26.86% faster
Avg: 1.154 - 0.906: 27.43% faster
Significant (t=115.404547, a=0.95)
That's
Collin Winter coll...@gmail.com added the comment:
I've made test_xpickle support Python 2.4 because it uses Python 2.4,
2.5 and 2.6 to check that we haven't broken backwards compatibility with
those versions.
I made AbstractCompatTests use cPickle because that's what I've been
changing :) I
Collin Winter coll...@gmail.com added the comment:
test_xpickle currently takes over three minutes on my MacBook Pro to
test compatibility with Python 2.4, 2.5 and 2.6, and adding tests for
the pickle module will at least double that, if not push it well above
10 minutes. That's why I recommend
Collin Winter coll...@gmail.com added the comment:
Updated the patch to include a regrtest xpickle resource, which
restricts if the backwards compat tests will be run. For normal
development, the existing tests should be fine; you only need these
tests if you're mucking with the pickle output
Collin Winter coll...@gmail.com added the comment:
FYI, I just added a pickle_dict microbenchmark to perf.py. Using this
new microbenchmark, I see these results (perf.py -r -b pickle_dict):
pickle_dict:
Min: 2.092 - 1.341: 56.04% faster
Avg: 2.126 - 1.360: 56.37% faster
Significant (t
Collin Winter coll...@gmail.com added the comment:
Amaury, I can't reproduce the issue you're seeing with empty dicts.
Here's what I'm doing:
dhcp-172-19-19-199:trunk collinwinter$ ./python.exe
Python 2.7a0 (trunk:71100M, Apr 3 2009, 14:40:49)
[GCC 4.0.1 (Apple Inc. build 5490)] on darwin
Changes by Collin Winter coll...@gmail.com:
--
components: Extension Modules
files: cpickle_writes.patch
keywords: needs review, patch
nosy: alexandre.vassalotti, collinwinter
severity: normal
status: open
title: Add a simple pickle optimizer to cPickle
type: performance
versions
New submission from Collin Winter coll...@gmail.com:
Bah, hit enter too soon.
--
resolution: - invalid
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5681
New submission from Collin Winter coll...@gmail.com:
This patch simplifies cPickle's complicated internal buffering system.
The new version uses a single buffer closer to the Pickler object,
flushing to a file object only when necessary. This avoids the overhead
of several indirection layers
Changes by Collin Winter coll...@gmail.com:
--
nosy: +collinwinter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5634
___
___
Python-bugs-list
Changes by Collin Winter coll...@gmail.com:
--
nosy: +collinwinter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3675
___
___
Python-bugs-list
Changes by Collin Winter coll...@gmail.com:
--
nosy: +collinwinter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2389
___
___
Python-bugs-list
New submission from Collin Winter coll...@gmail.com:
The attached patch adds another version of cPickle.c's batch_dict(),
batch_dict_exact(), which is specialized for type(x) is dict. This
provides a nice performance boost when pickling objects that use
dictionaries:
Pickle:
Min: 2.216 - 1.858
New submission from Collin Winter coll...@gmail.com:
The attached patch adds another version of cPickle.c's batch_list(),
batch_list_exact(), which is specialized for type(x) is list. This
provides a nice performance boost when pickling objects that use
lists. This is similar to the approach
Collin Winter coll...@gmail.com added the comment:
On Thu, Apr 2, 2009 at 12:20 PM, Antoine Pitrou rep...@bugs.python.org wrote:
Antoine Pitrou pit...@free.fr added the comment:
By the way, could the same approach be applied to lists and sets as well?
Certainly; see http://bugs.python.org
Collin Winter coll...@gmail.com added the comment:
No, we haven't started looking at other serialization formats yet.
Marshal will probably be my next target, with json being a lower
priority. There were enough instances of low-hanging fruit in cPickle
that I didn't go looking at the other
Collin Winter coll...@gmail.com added the comment:
Antoine: pickletester.py:test_newobj_generic() appears to test dict
subclasses, though in a roundabout-ish way. I don't know of any tests
for dict subclasses in the C level sense (ie, PyDict_Check() vs
PyDict_CheckExact()). I can add more
New submission from Collin Winter coll...@gmail.com:
The attached patch adds more tests for pickling:
- Add tests for the module-level load() and dump() functions.
- Add tests for cPickle's internal data structures, stressing workloads
with many gets/puts.
- Add tests for the Pickler
Collin Winter coll...@gmail.com added the comment:
Do you know of anyone actively working on Windows support? If not, I say
close it as won't fix.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1714451
New submission from Collin Winter coll...@gmail.com:
Add the ability to control the random seed used by regrtest.py -r. This
patch adds a --randseed option, and makes regrtest.py -r indicate what
random seed it's using so that that value can later be fed back to
--randseed. This option is useful
Changes by Collin Winter coll...@gmail.com:
Removed file: http://bugs.python.org/file13446/randseed.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5588
Collin Winter coll...@gmail.com added the comment:
The if rand_seed: bit was a relic from a previous iteration; fixed.
The only reason I didn't use randrange() is that I didn't see it; fixed.
--
Added file: http://bugs.python.org/file13448/randseed.patch
Collin Winter coll...@gmail.com added the comment:
Committed as r70672 (trunk) and r70673 (py3k). Thanks for the quick review.
--
resolution: - accepted
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5588
New submission from Collin Winter coll...@gmail.com:
If you pass LIBS to ./configure (as in LIBS=-lgcov ./configure),
distutils ignores this when building extension modules, which breaks
when using certain gcc options which require certain libraries (I'm
thinking of -fprofile-generate
Collin Winter coll...@gmail.com added the comment:
The patch attached to issue 5060 seems very tightly focused on a problem
with gcc FDO. This is a more general patch that solves the problem of
distutils ignoring LIBS.
--
___
Python tracker rep
New submission from Collin Winter coll...@gmail.com:
This patch adds SSL_ROOT, SQLITE_INC and SQLITE_LIB environment
variables used to inject additional libraries/headers for building the
sqlite, hashlib and ssl modules. We've found this very useful for
building these modules against
Changes by Collin Winter coll...@gmail.com:
--
nosy: +collinwinter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5557
___
___
Python-bugs-list
New submission from Collin Winter coll...@gmail.com:
(Tarek, I've been told you're the new distutils maintainer. Feel free to
unassign this if that isn't the case.)
The test distutils uses to decide whether it needs to recompile an
existing .o file when building extension modules is too
Changes by Collin Winter coll...@gmail.com:
--
nosy: +collinwinter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2636
___
___
Python-bugs-list
Collin Winter coll...@gmail.com added the comment:
Jeffrey: updated the patch to address your concerns.
Martin: I'm not sure I completely understand it either, though it seems
similar to issue4477. In the course of developing this patch, I tried
also #ifdef'ing out all usages
Changes by Collin Winter coll...@gmail.com:
Removed file: http://bugs.python.org/file13168/no_py3k_warning.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5362
Collin Winter coll...@gmail.com added the comment:
Bah, forgot to run autoreconf. Fixed.
Added file: http://bugs.python.org/file13184/no_py3k_warning.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5362
Changes by Collin Winter coll...@gmail.com:
Removed file: http://bugs.python.org/file13183/no_py3k_warning.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5362
New submission from Collin Winter coll...@gmail.com:
The attached patch adds a --with-py3k-warnings option to configure.
Passing --without-py3k-warnings disables all Py3k compatibility warnings
(the default is to keep the warnings). For production deployments where
performance is more important
Collin Winter coll...@gmail.com added the comment:
Committed as r69811.
--
resolution: - accepted
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5176
Collin Winter coll...@gmail.com added the comment:
On Fri, Feb 13, 2009 at 3:23 PM, Collin Winter coll...@gmail.com wrote:
On Fri, Feb 13, 2009 at 10:37 AM, Antoine Pitrou rep...@bugs.python.org
wrote:
Before committing I want to know what to do with the new jump opcodes,
with respect
Collin Winter coll...@gmail.com added the comment:
I don't see the changes to the lnotab format being a roadblock; just
mention it in NEWS. Likewise, the pure-Python compiler package shouldn't
be a high priority; your changes to that package look good enough.
I'm seeing encouraging speed-ups
Collin Winter coll...@gmail.com added the comment:
On Fri, Feb 13, 2009 at 10:37 AM, Antoine Pitrou rep...@bugs.python.org wrote:
Antoine Pitrou pit...@free.fr added the comment:
Hello Collin,
Thanks for taking a look.
I don't see the changes to the lnotab format being a roadblock; just
Collin Winter coll...@gmail.com added the comment:
Updated the patch to use only PyString_CheckExact(); added a test for
the behaviour of string subclasses wrt the % operator.
There's a very slight performance hit when using % with numbers, but
it's so small as to be statistically insignificant
Changes by Collin Winter coll...@gmail.com:
Removed file: http://bugs.python.org/file12962/faster_modulo.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5176
Changes by Collin Winter coll...@gmail.com:
--
nosy: +collinwinter, jyasskin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4751
___
___
Python
New submission from Collin Winter coll...@gmail.com:
This patch speeds up the string formatting % operator by avoiding the
unnecessary indirection in PyNumber_Remainder(). This particularly
benefits templating systems that do a lot of string formatting via %.
Performance tested with gcc 4.3.1
Changes by Collin Winter coll...@gmail.com:
--
nosy: +collinwinter, jyasskin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5084
___
___
Python
Changes by Collin Winter coll...@gmail.com:
--
nosy: +collinwinter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2459
___
___
Python-bugs-list
Changes by Collin Winter coll...@gmail.com:
--
nosy: +collinwinter, jyasskin
type: feature request - performance
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1518
Collin Winter coll...@gmail.com added the comment:
Another data point: I've tested this patch applied to trunk on Core 2
Duo and Opteron 8214 HE machines using both gcc 4.0.3 and 4.3.1, and I'm
seeing mixed results. Pybench with warp 1 is between ~1.5% slower and
~1% faster, depending on gcc
Collin Winter coll...@gmail.com added the comment:
Looks like this was re-applied in r59943 and r59944. Thanks for taking
care of this, Amaury.
--
nosy: +collinwinter, jyasskin
resolution: accepted - fixed
status: open - closed
___
Python tracker rep
Collin Winter coll...@gmail.com added the comment:
I've backported condbranches-plus.patch to trunk, and I'm getting these
results:
PyBench: 1.84-2.21% faster
2to3: 3.83% faster
Spitfire: 6.13-6.23% faster
PyBench was run with -w=1; 2to3 is translating its entire source
directory five times
Collin Winter coll...@gmail.com added the comment:
On Tue, Jan 13, 2009 at 3:25 PM, Antoine Pitrou rep...@bugs.python.org wrote:
Antoine Pitrou pit...@free.fr added the comment:
Hello,
I've backported condbranches-plus.patch to trunk, and I'm getting these
results:
Thanks!
PyBench
Changes by Collin Winter coll...@gmail.com:
--
nosy: +collinwinter, jyasskin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1479611
___
___
Python
1 - 100 of 174 matches
Mail list logo