Dino Viehland added the comment:
Doh, sorry about that link, this one goes to a specific commit:
https://github.com/facebookincubator/cinder/blob/6863212ada4b569c15cd95c4e7a838f254c8ccfb/Python/ceval.c#L6642
I do think a new opcode is a good way to go, and that could just be emitted
New submission from Dino Viehland :
The idea here is to add a new flag to the vectorcall nargs that indicates the
call is being awaited: _Py_AWAITED_CALL_MARKER. This flag will allow the
callee to know that it's being eagerly evaluated. When the call is eagerly
evaluated the callee can
Change by Dino Viehland :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue30533>
___
___
Pyth
Dino Viehland added the comment:
New changeset c2bb29ce9ae4adb6a8123285ad3585907cd4cc73 by Weipeng Hong in
branch 'main':
bpo-30533: Add docs for `inspect.getmembers_static` (#29874)
https://github.com/python/cpython/commit/c2bb29ce9ae4adb6a8123285ad3585907cd4cc73
Change by Dino Viehland :
--
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.11 -Python 3.9
___
Python tracker
<https://bugs.python.org/i
Dino Viehland added the comment:
New changeset af8c8caaf5e07c02202d736a31f6a2f7e27819b8 by Weipeng Hong in
branch 'main':
bpo-30533:Add function inspect.getmembers_static that does not call properties
or dynamic properties. (#20911)
https://github.com/python/cpython/commit
Dino Viehland added the comment:
@vstinner - The fix doesn't change the behavior of _PyType_Lookup and instead
just fixes a previous unrelated bug. The condition will typically ever be hit
once (at startup) as it's very unlikely that versions will wrap, so there
should be no performance
Dino Viehland added the comment:
I think the issue here is that in assign_version_tag there's this code:
if (type->tp_version_tag == 0) {
// Wrap-around or just starting Python - clear the whole cache
type_cache_clear(cache, 1);
return 1;
}
the retur
Dino Viehland added the comment:
And it looks like we have an entry with a 0 version, but with a valid name:
(type_cache_entry) $3 = {
version = 0
name = 0x000100ec44f0
value = NULL
}
--
___
Python tracker
<https://bugs.python.
Dino Viehland added the comment:
It's probably worth having an assert that the version tag is valid, that'll
make it easier to see what's going wrong in the cache hit case. We should have
the version tag being 0 now when it's not valid. I may not be able to debug it
anymore tonight
Dino Viehland added the comment:
Looking!
--
___
Python tracker
<https://bugs.python.org/issue43636>
___
___
Python-bugs-list mailing list
Unsubscribe:
Dino Viehland added the comment:
Setup a micro-benchmark, foo.c:
#define PY_SSIZE_T_CLEAN
#include
#include
#include
int
main(int argc, char *argv[])
{
wchar_t *program = Py_DecodeLocale(argv[0], NULL);
if (program == NULL) {
fprintf(stderr, "Fatal error: cannot d
Change by Dino Viehland :
--
keywords: +patch
pull_requests: +23572
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/24804
___
Python tracker
<https://bugs.python.org/issu
New submission from Dino Viehland :
The common case going through _PyType_Lookup is to have a cache hit. There's
some small tweaks which can make this a little cheaper:
1) the name field identity is used for a cache hit, and is kept alive by the
cache. So there's no need to read the hash
Dino Viehland added the comment:
New changeset 6e799be0a18d0bb5bbbdc77cd3c30a229d31dfb4 by Max Bernstein in
branch 'master':
bpo-42199: Fix bytecode_helper assertNotInBytecode (#23031)
https://github.com/python/cpython/commit/6e799be0a18d0bb5bbbdc77cd3c30a229d31dfb4
--
nosy
Dino Viehland added the comment:
I think there's other cases of performance related features being hidden under
an ifdef. Computed gotos show up that way, although probably more because it's
a compiler extension that's not supported everywhere. Pymalloc is also very
similar
Dino Viehland added the comment:
New changeset 52268941f37e3e27bd01792b081877ec3bc9ce12 by Matthias Braun in
branch 'master':
bpo-26067: Do not fail test_shutil / chown when gid/uid cannot be resolved
(#19032)
https://github.com/python/cpython/commit/52268941f37e3e27bd01792b081877ec3bc9ce12
Dino Viehland added the comment:
I like that idea, let me see if I can find a way to do that. This is a little
bit different in that it's implicitly trying to find a module, and supports
dotting through non-packages as well, but maybe there's a way to leverage
importlib and still keep
Dino Viehland added the comment:
Sorry, publish may not necessarily be the best term. When you do "from foo
import bar" and foo is a package Python will set the bar module onto the foo
module. That leads to the common mistake of doing "import foo" and then
"foo.ba
Dino Viehland added the comment:
My actual scenario involves a custom module loader where the modules are
published are completely immutable (it ends up publishing an object which isn't
a subtype of module). It can still have normal Python modules as a child which
aren't immutable, so
Dino Viehland added the comment:
It's related to bpo-39336. If you have an immutable package which doesn't
allow it's children to be published on it when following the chain of packages
it ends up not arriving at the final module.
But you can also hit it if you end up doing the patch
Change by Dino Viehland :
--
pull_requests: +17722
pull_request: https://github.com/python/cpython/pull/18347
___
Python tracker
<https://bugs.python.org/issue17
Change by Dino Viehland :
--
keywords: +patch
pull_requests: +17721
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/18347
___
Python tracker
<https://bugs.python.org/issu
New submission from Dino Viehland :
The fix for bpo-17636 added support for falling back to sys.modules when a
module isn't directly present on the module. But mock doesn't have the same
behavior - it'll try the import, and then try to get the value off the object.
If it's
Dino Viehland added the comment:
I guess the update to lib.pyproj probably just makes the files show up when
opening the solution in Visual Studio then.
--
___
Python tracker
<https://bugs.python.org/issue39
Dino Viehland added the comment:
New changeset 0cd5bff6b7da3118d0c5a88fc2b80f80eb7c3059 by Dino Viehland in
branch 'master':
bpo-39459: include missing test files in windows installer
https://github.com/python/cpython/commit/0cd5bff6b7da3118d0c5a88fc2b80f80eb7c3059
Dino Viehland added the comment:
Nope, thank you for pointing that out. I've updated them now with PR 18241
--
___
Python tracker
<https://bugs.python.org/issue39
Change by Dino Viehland :
--
pull_requests: +17621
pull_request: https://github.com/python/cpython/pull/18241
___
Python tracker
<https://bugs.python.org/issue39
Dino Viehland added the comment:
I've added the files to the makefile and AMD64 Fedora Stable Clang Installed
3.x was passing.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracke
Change by Dino Viehland :
--
pull_requests: +17590
pull_request: https://github.com/python/cpython/pull/18211
___
Python tracker
<https://bugs.python.org/issue39
Dino Viehland added the comment:
Ahh, that's probably it Brett, I didn't know that was there, thanks!
--
___
Python tracker
<https://bugs.python.org/issue39
Dino Viehland added the comment:
The curious thing about this is other tests in CircularImportTests are
importing packages from test.test_import.data in the exact same way.
--
___
Python tracker
<https://bugs.python.org/issue39
Dino Viehland added the comment:
One more data point: Backporting this change to Python 3.6 (I just happened to
have it applied there already, so I haven't tried it on 3.7 or 3.8) has no
crash and no hangs in multiprocessing on Linux. So something definitely
changed in multiproessing which
Change by Dino Viehland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Dino Viehland added the comment:
New changeset 9b6fec46513006d7b06fcb645cca6e4f5bf7c7b8 by Dino Viehland in
branch 'master':
bpo-39336: Allow packages to not let their child modules be set on them (#18006)
https://github.com/python/cpython/commit/9b6fec46513006d7b06fcb645cca6e4f5bf7c7b8
Dino Viehland added the comment:
With either fix, or with both, on Linux I still see this hang at shutdown.
Victor mentioned the fact that he had to hit Ctrl-C on Linux to see this, and I
have to do the same thing. Then with the fixes in place the original test case
still hangs on shutdown
Dino Viehland added the comment:
https://github.com/python/cpython/pull/18038 is a partial fix for this. I
think it fixes the crash at shutdown, although I'm still seeing a hang on
master on Linux which is different then earlier versions of Python. I seem to
have a really bogus stack
Change by Dino Viehland :
--
pull_requests: +17437
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/18038
___
Python tracker
<https://bugs.python.org/issu
Dino Viehland added the comment:
And here's a variation which doesn't involve any instances from the module:
import _struct
class C:
def __init__(self):
self.pack = _struct.pack
def __del__(self):
self.pack('I', -42)
_struct.x = C
Dino Viehland added the comment:
This is a relatively simple repro of the underlying problem:
import _struct
s = _struct.Struct('i')
class C:
def __del__(self):
s.pack(42, 100)
_struct.x = C()
It's a little bit different in that it is actually causing the module to
attempt
Dino Viehland added the comment:
It seems problematic that_PyInterpreterState_ClearModules runs before all
instances from a module have been cleared. If PyState_FindModule is no longer
able to return module state then there's no way for a module to reliably work
at shutdown other than
Change by Dino Viehland :
--
nosy: +eelizondo -dino.viehland
___
Python tracker
<https://bugs.python.org/issue38076>
___
___
Python-bugs-list mailing list
Unsub
Dino Viehland added the comment:
I think the warning shouldn't be too bad. It looks like ImportWarnings are
filtered by default already, and the extra overhead of raising a warning in
this case probably is nothing compared to the actual work in loading the module
Change by Dino Viehland :
--
keywords: +patch
pull_requests: +17406
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/18006
___
Python tracker
<https://bugs.python.org/issu
Change by Dino Viehland :
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue39336>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Dino Viehland :
I'm trying to create a custom module type for a custom loader where the
returned modules are immutable. But I'm running into an issue where the
immutable module type can't be used as a module for a package. That's because
the import machinery calls
Dino Viehland added the comment:
Adding the getter/setters seems perfectly reasonable to me, and I agree they
should be underscore prefixed as well.
--
___
Python tracker
<https://bugs.python.org/issue38
Dino Viehland added the comment:
@BTaskaya Seems done, I'll go ahead and close it
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/i
Change by Dino Viehland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Dino Viehland added the comment:
New changeset 3368f3c6ae4140a0883e19350e672fd09c9db616 by Dino Viehland (Eddie
Elizondo) in branch 'master':
bpo-38140: Make dict and weakref offsets opaque for C heap types (#16076)
https://github.com/python/cpython/commit
Change by Dino Viehland :
--
stage: patch review -> resolved
___
Python tracker
<https://bugs.python.org/issue38176>
___
___
Python-bugs-list mailing list
Un
Change by Dino Viehland :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue38176>
___
___
Python-bugs-list
Change by Dino Viehland :
--
keywords: +patch
pull_requests: +15768
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16158
___
Python tracker
<https://bugs.python.org/issu
Change by Dino Viehland :
--
assignee: -> dino.viehland
nosy: +dino.viehland
___
Python tracker
<https://bugs.python.org/issue38176>
___
___
Python-bugs-lis
Dino Viehland added the comment:
New changeset f919054e539a5c1afde1b31c9fd7a8f5b2313311 by Dino Viehland in
branch 'master':
bpo-38116: Convert select module to PEP-384 (#15971)
https://github.com/python/cpython/commit/f919054e539a5c1afde1b31c9fd7a8f5b2313311
Change by Dino Viehland :
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue38140>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dino Viehland :
--
assignee: -> dino.viehland
nosy: +dino.viehland
___
Python tracker
<https://bugs.python.org/issue38152>
___
___
Python-bugs-lis
Change by Dino Viehland :
--
keywords: +patch
pull_requests: +15676
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16053
___
Python tracker
<https://bugs.python.org/issu
Change by Dino Viehland :
--
assignee: -> dino.viehland
___
Python tracker
<https://bugs.python.org/issue38138>
___
___
Python-bugs-list mailing list
Un
New submission from Dino Viehland :
This makes it impossible to port certain types to the stable ABI and remove
statics from the interpreter.
--
assignee: dino.viehland
components: Interpreter Core
messages: 352167
nosy: dino.viehland, eric.snow
priority: normal
severity: normal
Change by Dino Viehland :
--
pull_requests: +15608
pull_request: https://github.com/python/cpython/pull/15975
___
Python tracker
<https://bugs.python.org/issue38
Dino Viehland added the comment:
Remove statics to make more compatible with subinterpreters.
--
components: +Interpreter Core -Extension Modules
title: Make ast module PEP-384 compatible -> Remove statics from ast.c
___
Python tracker
<
Change by Dino Viehland :
--
keywords: +patch
pull_requests: +15604
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15971
___
Python tracker
<https://bugs.python.org/issu
New submission from Dino Viehland :
Remove static PyTypeObject* definitions and move static data to _selectstate to
help improve compatibility w/ subinterpreters and re-use by alternate
implementations.
--
assignee: dino.viehland
components: Extension Modules
messages: 351913
nosy
Change by Dino Viehland :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue38113>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dino Viehland :
--
keywords: +patch
pull_requests: +15592
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15957
___
Python tracker
<https://bugs.python.org/issu
New submission from Dino Viehland :
Remove various static state from the ast module and make it PEP-384 compatible.
This will help make it be more compatible w/ subinterpreters and make it
re-usable by 3rd party implementations.
--
assignee: dino.viehland
components: Extension
Dino Viehland added the comment:
Sorry, it seemed like a perfectly reasonable change when I was looking at the
PR!
--
___
Python tracker
<https://bugs.python.org/issue36
Dino Viehland added the comment:
New changeset 88bdb9280b251d753f1b1c8d9183de0fff003622 by Dino Viehland (Serhiy
Storchaka) in branch 'master':
bpo-36781: Optimize sum() for bools. (#13074)
https://github.com/python/cpython/commit/88bdb9280b251d753f1b1c8d9183de0fff003622
--
nosy
Dino Viehland added the comment:
There's several different reasons why these changes are beneficial. It'll help
make the modules more compatible with PEP 554 in the future, enable more code
re-use across Python VMs, reduce code maintenance going forward, and may also
help with performance
Dino Viehland added the comment:
New changeset 9669931e5e76cf4b6ae6d3d66e699b5fd6ffe931 by Dino Viehland (Jeroen
Demeyer) in branch 'master':
bpo-36971: add subsections in C API "Common Object Structures" page (#13446)
https://github.com/python/cpyt
Dino Viehland added the comment:
New changeset c6bbcd258302b4b9b3d4f3c39bb5f7ff0120ec67 by Dino Viehland (Neil
Schemenauer) in branch 'master':
bpo-37725: have "make clean" remove PGO task data (#15033)
https://github.com/python/cpython/commit/c6bbcd258302b4b9b3d4f3c39bb5f7
Change by Dino Viehland :
--
keywords: +patch
pull_requests: +15456
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15805
___
Python tracker
<https://bugs.python.org/issu
New submission from Dino Viehland :
Make struct module PEP-384 compatible
--
assignee: dino.viehland
components: Extension Modules
messages: 351524
nosy: dino.viehland, eric.snow
priority: normal
severity: normal
status: open
title: Make struct module PEP-384 compatible
versions
Change by Dino Viehland :
--
keywords: +patch
pull_requests: +15450
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15798
___
Python tracker
<https://bugs.python.org/issu
New submission from Dino Viehland :
Make random module PEP-384 compatible
--
assignee: dino.viehland
components: Extension Modules
messages: 351509
nosy: dino.viehland, eric.snow
priority: normal
severity: normal
status: open
title: Make random module PEP-384 compatible
versions
Change by Dino Viehland :
--
keywords: +patch
pull_requests: +15445
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15792
___
Python tracker
<https://bugs.python.org/issu
New submission from Dino Viehland :
Make zlib PEP-384 compatible
--
components: Extension Modules
messages: 351501
nosy: dino.viehland, eric.snow
priority: normal
severity: normal
status: open
title: Make zlib PEP-384 compatible
versions: Python 3.9
New submission from Dino Viehland :
Make the pwd module PEP-384 compatible
--
assignee: dino.viehland
components: Extension Modules
messages: 351495
nosy: dino.viehland, eric.snow
priority: normal
severity: normal
status: open
title: Make pwd module PEP-384 compatible
versions: Python
Change by Dino Viehland :
--
keywords: +patch
pull_requests: +15443
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15790
___
Python tracker
<https://bugs.python.org/issu
Change by Dino Viehland :
--
keywords: +patch
pull_requests: +15441
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15788
___
Python tracker
<https://bugs.python.org/issu
Change by Dino Viehland :
--
assignee: dino.viehland
components: Extension Modules
nosy: dino.viehland, eric.snow
priority: normal
severity: normal
status: open
title: Make grp module PEP-384 compatible
versions: Python 3.9
___
Python tracker
Change by Dino Viehland :
--
keywords: +patch
pull_requests: +15438
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15785
___
Python tracker
<https://bugs.python.org/issu
Change by Dino Viehland :
--
components: Extension Modules
nosy: dino.viehland, eric.snow
priority: normal
severity: normal
status: open
title: Make termios PEP-384 compatible
type: enhancement
versions: Python 3.9
___
Python tracker
<ht
Change by Dino Viehland :
--
keywords: +patch
pull_requests: +15433
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15780
___
Python tracker
<https://bugs.python.org/issu
Change by Dino Viehland :
--
assignee: dino.viehland
components: Extension Modules
nosy: dino.viehland, eric.snow
priority: normal
severity: normal
status: open
title: Make _posixsubprocess PEP-384 compatible
versions: Python 3.9
___
Python tracker
Dino Viehland added the comment:
New changeset 992347d7376765fe3f4fc958fb1be193ba21f6c3 by Dino Viehland
(Mickaël Schoentgen) in branch 'master':
bpo-26185: Fix repr() on empty ZipInfo object (#13441)
https://github.com/python/cpython/commit/992347d7376765fe3f4fc958fb1be193ba21f6c3
Dino Viehland added the comment:
The 20MB of savings is actually the amount of byte code that exists in the IG
code base. I was just measuring the web site code, and not the other various
Python code in the process (e.g. no std lib code, no 3rd party libraries,
etc...). The IG code base
Dino Viehland added the comment:
Well given that we're one day away from 3.8 Beta 1 I'm not going to rush this
in :) In particular the discussion has made me wonder if I can also do more
with sharing strings using the legacy unicode strings (which I don't believe
will require any runtime
Dino Viehland added the comment:
In the Instagram case there's about 20mb of byte code total and there are 3-4
dozen worker processes running per server. The byte code also represents the
second largest section of memory as far as serialized code objects are
concerned, the only larger one
Dino Viehland added the comment:
Sure, but immutable/const is almost always a language level guarantee. The
only case where that's not true is when you have OS/hardware level memory
protection and that doesn't apply to any of Python's existing byte codes.
So from a Python perspective, code
Change by Dino Viehland :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue37001>
___
___
Pyth
Dino Viehland added the comment:
New changeset 415406999d7c09af9f3dcacfb4578b9e97b2ce77 by Dino Viehland in
branch 'master':
bpo-37001: Makes symtable.symtable have parity with compile for input (#13483)
https://github.com/python/cpython/commit/415406999d7c09af9f3dcacfb4578b9e97b2ce77
Dino Viehland added the comment:
The PR actually checks that the buffer is read-only (this was also a concern
that Mark Shannon had). And the Python buffer protocol says that you need to
consistently hand out read-only buffers. So while someone could create a
buffer and mutate it outside
Change by Dino Viehland :
--
keywords: +patch
pull_requests: +13395
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue37001>
___
___
Py
New submission from Dino Viehland :
This is another catch of using PyType_FromSpec (similar to
https://bugs.python.org/issue26979 but also completely different).
Because PyType_FromSpec produces a heap type it gets the Py_TPFLAGS_HEAPTYPE
flag set on the newly produced type. To enforce
New submission from Dino Viehland :
symtable is useful when combined with compile() to AST to understand what the
names bind to. But symtable.symtable() doesn't accept a bytes object, while
compile does. Ultimately these feed down to the same API, and could easily
lead to subtle mismatches
Dino Viehland added the comment:
New changeset ccb7ca728e09b307f9e9fd36ec40353137e68a3b by Dino Viehland (Max
Bernstein) in branch 'master':
bpo-36929: Modify io/re tests to allow for missing mod name (#13392)
https://github.com/python/cpython/commit/ccb7ca728e09b307f9e9fd36ec40353137e68a3b
Change by Dino Viehland :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue36839>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dino Viehland :
--
keywords: +patch
pull_requests: +13093
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
1 - 100 of 134 matches
Mail list logo
