[issue42506] Unexpected output when running test_format

2020-11-30 Thread Dong-hee Na


Dong-hee Na  added the comment:

Thank you ZackerySpytz!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue42506>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42506] Unexpected output when running test_format

2020-11-30 Thread Dong-hee Na


Dong-hee Na  added the comment:


New changeset 96545924780da34afc457bc22a869096af985ebf by Zackery Spytz in 
branch 'master':
bpo-42506: Fix unexpected output in test_format (GH-23564)
https://github.com/python/cpython/commit/96545924780da34afc457bc22a869096af985ebf


--
nosy: +corona10

___
Python tracker 
<https://bugs.python.org/issue42506>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42299] Remove formatter module

2020-11-25 Thread Dong-hee Na


Dong-hee Na  added the comment:

@terry.reedy @vstinner

Thank you, Terry and Victor, and goodbye formatter module!

--
nosy: +vstinner
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue42299>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42299] Remove formatter module

2020-11-25 Thread Dong-hee Na


Dong-hee Na  added the comment:


New changeset be319c0c108e308fb7ed6ec9522e969fdffd1253 by Dong-hee Na in branch 
'master':
bpo-42299: Remove formatter module (GH-23476)
https://github.com/python/cpython/commit/be319c0c108e308fb7ed6ec9522e969fdffd1253


--

___
Python tracker 
<https://bugs.python.org/issue42299>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42299] Remove formatter module

2020-11-24 Thread Dong-hee Na


Dong-hee Na  added the comment:

@christian.heimes

Thank you Christian

I also discuss this issue on python-dev and everybody agree with removing this 
module.

I will remove this module ;)

--

___
Python tracker 
<https://bugs.python.org/issue42299>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42299] Remove formatter module

2020-11-24 Thread Dong-hee Na


Change by Dong-hee Na :


--
title: Add test_formatter (or remove deprecated formatter module?) -> Remove 
formatter module

___
Python tracker 
<https://bugs.python.org/issue42299>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42299] Add test_formatter (or remove deprecated formatter module?)

2020-11-23 Thread Dong-hee Na


Change by Dong-hee Na :


--
pull_requests: +22368
pull_request: https://github.com/python/cpython/pull/23476

___
Python tracker 
<https://bugs.python.org/issue42299>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42299] Add test_formatter (or remove deprecated formatter module?)

2020-11-23 Thread Dong-hee Na


Dong-hee Na  added the comment:

> If so, the patch, aDo we still want to remove formatted

IMHO, 3.10 is a good time to remove formatter

--
nosy: +corona10

___
Python tracker 
<https://bugs.python.org/issue42299>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42427] Use the errno attribute of OSError instead of args[0]

2020-11-21 Thread Dong-hee Na


Change by Dong-hee Na :


--
nosy: +corona10

___
Python tracker 
<https://bugs.python.org/issue42427>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1635741] Py_Finalize() doesn't clear all Python objects at exit

2020-11-20 Thread Dong-hee Na


Dong-hee Na  added the comment:


New changeset a6109ef68d421712ba368ef502c4789e8de113e0 by Erlend Egeberg 
Aasland in branch 'master':
bpo-1635741: Convert _sre types to heap types and establish module state (PEP 
384) (GH-23393)
https://github.com/python/cpython/commit/a6109ef68d421712ba368ef502c4789e8de113e0


--

___
Python tracker 
<https://bugs.python.org/issue1635741>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1635741] Py_Finalize() doesn't clear all Python objects at exit

2020-11-19 Thread Dong-hee Na


Change by Dong-hee Na :


--
pull_requests: +22294
pull_request: https://github.com/python/cpython/pull/23402

___
Python tracker 
<https://bugs.python.org/issue1635741>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1635741] Py_Finalize() doesn't clear all Python objects at exit

2020-11-19 Thread Dong-hee Na


Change by Dong-hee Na :


--
pull_requests: +22293
pull_request: https://github.com/python/cpython/pull/23401

___
Python tracker 
<https://bugs.python.org/issue1635741>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1635741] Py_Finalize() doesn't clear all Python objects at exit

2020-11-19 Thread Dong-hee Na


Dong-hee Na  added the comment:


New changeset cfeb5437a8910e28726422a14a93a36584e32238 by Christian Heimes in 
branch 'master':
bpo-1635741: Port _struct to multiphase initialization (GH-23398)
https://github.com/python/cpython/commit/cfeb5437a8910e28726422a14a93a36584e32238


--

___
Python tracker 
<https://bugs.python.org/issue1635741>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42042] sphinx3 renders diffrently docs.python.org for 3.10

2020-11-13 Thread Dong-hee Na


Dong-hee Na  added the comment:


New changeset 0f4dd87a31130b245ec4c6ded9fd6f247e700c0d by Dong-hee Na in branch 
'3.9':
[3.9] bpo-42042: Use ids attribute instead of names attribute (GH-22739) 
(GH-23265)
https://github.com/python/cpython/commit/0f4dd87a31130b245ec4c6ded9fd6f247e700c0d


--

___
Python tracker 
<https://bugs.python.org/issue42042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42042] sphinx3 renders diffrently docs.python.org for 3.10

2020-11-13 Thread Dong-hee Na


Change by Dong-hee Na :


--
nosy: +lukasz.langa
versions: +Python 3.8, Python 3.9

___
Python tracker 
<https://bugs.python.org/issue42042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42042] sphinx3 renders diffrently docs.python.org for 3.10

2020-11-13 Thread Dong-hee Na


Change by Dong-hee Na :


--
pull_requests: +22162
pull_request: https://github.com/python/cpython/pull/23265

___
Python tracker 
<https://bugs.python.org/issue42042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42042] sphinx3 renders diffrently docs.python.org for 3.10

2020-11-13 Thread Dong-hee Na


Dong-hee Na  added the comment:


New changeset 09490a109faaee9cc393b52742a8575c116c56ba by Dong-hee Na in branch 
'master':
bpo-42042: Use ids attribute instead of names attribute (GH-22739)
https://github.com/python/cpython/commit/09490a109faaee9cc393b52742a8575c116c56ba


--

___
Python tracker 
<https://bugs.python.org/issue42042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42242] Backport SQLite trace API v2

2020-11-02 Thread Dong-hee Na


Dong-hee Na  added the comment:

We often submit the backported patch by using the backport label from the 
origin PR.
(https://github.com/python/cpython/pull/19581)

So please discuss the backporting on bpo-40318

--
nosy: +corona10
resolution:  -> duplicate
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue42242>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42241] Backport SQLite trace API v2

2020-11-02 Thread Dong-hee Na


Dong-hee Na  added the comment:

We often submit the backported patch by using the backport label from the 
origin PR.
(https://github.com/python/cpython/pull/19581)

So please discuss about the bacporting on bpo-40318

--
nosy: +corona10
resolution:  -> duplicate
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue42241>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37483] Add PyObject_CallOneArg()

2020-11-01 Thread Dong-hee Na


Change by Dong-hee Na :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue37483>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37483] Add PyObject_CallOneArg()

2020-11-01 Thread Dong-hee Na


Dong-hee Na  added the comment:


New changeset 7feb54a6348f6220b2798686c812f110b53d by Dong-hee Na in branch 
'master':
bpo-37483: Add PyObject_CallOneArg() in the What's New in Python 3.9 (GH-23062)
https://github.com/python/cpython/commit/7feb54a6348f6220b2798686c812f110b53d


--

___
Python tracker 
<https://bugs.python.org/issue37483>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37483] Add PyObject_CallOneArg()

2020-10-31 Thread Dong-hee Na


Change by Dong-hee Na :


--
nosy: +corona10
nosy_count: 4.0 -> 5.0
pull_requests: +21981
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/23062

___
Python tracker 
<https://bugs.python.org/issue37483>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40956] Use Argument Clinic in sqlite3

2020-10-31 Thread Dong-hee Na


Dong-hee Na  added the comment:

@erlendaasland

Thank you erlendaasland for working on GH-22484.
This time was a good time to review my AC knowledge ;)

--

___
Python tracker 
<https://bugs.python.org/issue40956>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40956] Use Argument Clinic in sqlite3

2020-10-31 Thread Dong-hee Na


Dong-hee Na  added the comment:


New changeset 7d210271579ae31f43b32f73c2aff5bc4fe0d27f by Erlend Egeberg 
Aasland in branch 'master':
bpo-40956: Convert _sqlite3 module level functions to Argument Clinic (GH-22484)
https://github.com/python/cpython/commit/7d210271579ae31f43b32f73c2aff5bc4fe0d27f


--

___
Python tracker 
<https://bugs.python.org/issue40956>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42195] Inconsistent __args__ between typing.Callable and collections.abc.Callable

2020-10-30 Thread Dong-hee Na


Dong-hee Na  added the comment:

@gvanrossum

Sorry, Not this time. I just add myself to observe how to solve this issue.

Maybe Batuhan is the proper member to handle this issue.

Just question to this issue.
Since GenericAlias does not have a Py_TPFLAGS_BASETYPE flag, IMHO we have to 
add Py_TPFLAGS_BASETYPE to type declaration and this behavior does not occur 
any regression?

--

___
Python tracker 
<https://bugs.python.org/issue42195>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42042] sphinx3 renders diffrently docs.python.org for 3.10

2020-10-30 Thread Dong-hee Na


Dong-hee Na  added the comment:

> but likely for the beta/release candidate phases.

I think so too

--

___
Python tracker 
<https://bugs.python.org/issue42042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42208] Using logging or warnings during Python finalization does crash Python

2020-10-30 Thread Dong-hee Na


Change by Dong-hee Na :


--
nosy: +corona10

___
Python tracker 
<https://bugs.python.org/issue42208>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42042] sphinx3 renders diffrently docs.python.org for 3.10

2020-10-30 Thread Dong-hee Na


Dong-hee Na  added the comment:

@pablogsal

Since this is the developer guide of 3.10.
I would like to suggest as release bloker, if you don't agree you can change it 
;)

--
nosy: +pablogsal

___
Python tracker 
<https://bugs.python.org/issue42042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42042] sphinx3 renders diffrently docs.python.org for 3.10

2020-10-30 Thread Dong-hee Na


Change by Dong-hee Na :


--
priority: normal -> release blocker

___
Python tracker 
<https://bugs.python.org/issue42042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42202] Optimize function annotation

2020-10-30 Thread Dong-hee Na


Change by Dong-hee Na :


--
nosy: +serhiy.storchaka

___
Python tracker 
<https://bugs.python.org/issue42202>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42202] Optimize function annotation

2020-10-30 Thread Dong-hee Na


Dong-hee Na  added the comment:

@serhiy race condition sorry ;)

--

___
Python tracker 
<https://bugs.python.org/issue42202>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42202] Optimize function annotation

2020-10-30 Thread Dong-hee Na


Dong-hee Na  added the comment:

I like the 1st option which uses a tuple

--
nosy: +corona10 -serhiy.storchaka

___
Python tracker 
<https://bugs.python.org/issue42202>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42195] Inconsistent __args__ between typing.Callable and collections.abc.Callable

2020-10-30 Thread Dong-hee Na


Change by Dong-hee Na :


--
nosy: +corona10

___
Python tracker 
<https://bugs.python.org/issue42195>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42172] Typo in test library for test_socket.py

2020-10-30 Thread Dong-hee Na


Dong-hee Na  added the comment:

merged! Thank you for working on this!! @adkhunt ;)

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue42172>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42172] Typo in test library for test_socket.py

2020-10-30 Thread Dong-hee Na


Change by Dong-hee Na :


--
versions:  -Python 3.8, Python 3.9

___
Python tracker 
<https://bugs.python.org/issue42172>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42172] Typo in test library for test_socket.py

2020-10-30 Thread Dong-hee Na


Dong-hee Na  added the comment:


New changeset d6238ba82d07e8e0783b692f37dc4b7c8617294b by Akashkumar D Khunt in 
branch 'master':
bpo-42172: Correct typo for test_socket.py  (GH-23013)
https://github.com/python/cpython/commit/d6238ba82d07e8e0783b692f37dc4b7c8617294b


--

___
Python tracker 
<https://bugs.python.org/issue42172>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42172] Typo in test library for test_socket.py

2020-10-27 Thread Dong-hee Na


Change by Dong-hee Na :


--
versions: +Python 3.10, Python 3.9

___
Python tracker 
<https://bugs.python.org/issue42172>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42171] Add PEP 573 to the stable ABI

2020-10-27 Thread Dong-hee Na


Dong-hee Na  added the comment:

> I'd like to add it anyway.
Nice ;)

--
nosy: +corona10

___
Python tracker 
<https://bugs.python.org/issue42171>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42172] Typo in test library for test_socket.py

2020-10-27 Thread Dong-hee Na


Dong-hee Na  added the comment:

@adkhunt
Do you want to submit the patch for this?
If you want, please ping me on your PR

--
nosy: +corona10

___
Python tracker 
<https://bugs.python.org/issue42172>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42161] Remove private _PyLong_Zero and _PyLong_One variables

2020-10-26 Thread Dong-hee Na


Change by Dong-hee Na :


--
nosy: +corona10

___
Python tracker 
<https://bugs.python.org/issue42161>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42147] Micro optimization for longrange iteration if step is 1

2020-10-26 Thread Dong-hee Na


Dong-hee Na  added the comment:

I close this issue with rejected status.
Thank you serhiy, pablogsal and Inada-san for discussion ;)

--
resolution:  -> rejected
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue42147>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42147] Micro optimization for longrange iteration if step is 1

2020-10-26 Thread Dong-hee Na


Dong-hee Na  added the comment:

I will close this issue by tomorrow with rejected ;)

--

___
Python tracker 
<https://bugs.python.org/issue42147>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42147] Micro optimization for longrange iteration if step is 1

2020-10-26 Thread Dong-hee Na


Dong-hee Na  added the comment:

> Sometimes the work of the core developer is to say "No" to his own code.

Thank you for the careful sentence.
For clear the air, I never think that my patch should be accepted.
This is why I always get reviews from other core devs and I always accept the 
review result.
(You may know my a lot of rejected PR ;))

but for the future record, we always record why someone tried this and why 
rejected(e.g why not worthed to do it)
so this is the reason why I talked about why I tried this optimization.

In the future, if someone submits a similar patch we can give this issue to 
them.

--

___
Python tracker 
<https://bugs.python.org/issue42147>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42151] Pure Python xml.etree.ElementTree is missing default attribute values

2020-10-25 Thread Dong-hee Na


Change by Dong-hee Na :


--
nosy: +corona10

___
Python tracker 
<https://bugs.python.org/issue42151>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42147] Micro optimization for longrange iteration if step is 1

2020-10-25 Thread Dong-hee Na


Dong-hee Na  added the comment:

Sorry for the offtopic

@methane

Looks like Inada san is the right expression. ;)

> But China and Korea don't reverse name.

This is a very intereting fact, the national system of Korea are using 
surname-given name order or printing with a distinc section.

A good example is the passport,
surname: Na
givenname: Dong-hee


But the education of Korea teaches to use given-surname order when going abroad 
;)
So I always use the given-surname order when I have to write my name in English.

--

___
Python tracker 
<https://bugs.python.org/issue42147>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42147] Micro optimization for longrange iteration if step is 1

2020-10-25 Thread Dong-hee Na


Dong-hee Na  added the comment:

@pablogsal, @serhiy.storchaka

> I would advise against having more branching, especially for code that is 
> rare:

About bpo-41902, I believe those patches affect all range objects which is 
created with step is one .

I believe the usage of creation of range object with range(start), range(start, 
stop) is more than range(start, stop, step) unless there is significant proof 
that users prefer to create with range(start, stop, step)

So I think that those patches are worth to do it.

but PR 22971 is only affecting to longrange iteration.
it means if there no worth to optimize range(start), range(start, stop) when 
the start and stop is big number, this issue could be rejected.

And if the patch is rejected, I would like to suggest write a comment on the 
codeline for the future contributors why we decided to not optimizing this.

--

___
Python tracker 
<https://bugs.python.org/issue42147>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42147] Micro optimization for longrange iteration if step is 1

2020-10-25 Thread Dong-hee Na


Dong-hee Na  added the comment:

s / will not effort / will not be affected

--

___
Python tracker 
<https://bugs.python.org/issue42147>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42147] Micro optimization for longrange iteration if step is 1

2020-10-25 Thread Dong-hee Na


Dong-hee Na  added the comment:

@methane

To be more precise, [[] for _ in range(1)] will not effort this patch 
because range(1) does not create longrangeiter object.
This patch will affect to if the number is veeery large.

On the other hand, GH-22479 is affect to all index API() whether the number is 
large or small.

p.s by the way, Naoki is the last name or first name? ;)

--

___
Python tracker 
<https://bugs.python.org/issue42147>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42147] Micro optimization for longrange iteration if step is 1

2020-10-25 Thread Dong-hee Na


Dong-hee Na  added the comment:

if somebody try to sum very large value with range.
sum(range(1 << 1000, (1 << 1000) + 100))
it can be affected by this patch.

--

___
Python tracker 
<https://bugs.python.org/issue42147>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42145] test_io is leaking references

2020-10-25 Thread Dong-hee Na


Change by Dong-hee Na :


--
nosy: +shihai1991

___
Python tracker 
<https://bugs.python.org/issue42145>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42147] Micro optimization for longrange iteration if step is 1

2020-10-25 Thread Dong-hee Na


Dong-hee Na  added the comment:

s/
I approach as same case that step=1 is quite a lot usecase until user designate 
step value.
/My assumtion is that step=1 is quite often usecase until user designate step 
value.

--

___
Python tracker 
<https://bugs.python.org/issue42147>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42147] Micro optimization for longrange iteration if step is 1

2020-10-25 Thread Dong-hee Na


Dong-hee Na  added the comment:

At bpo-41092, we decide not to optimize mulitply operation itself.

I approach as same case that step=1 is quite a lot usecase until user designate 
step value.

If range with longobject is not that much use case, I can agree with your 
opinion

--

___
Python tracker 
<https://bugs.python.org/issue42147>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42147] Micro optimization for longrange iteration if step is 1

2020-10-25 Thread Dong-hee Na


Change by Dong-hee Na :


--
keywords: +patch
pull_requests: +21886
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/22971

___
Python tracker 
<https://bugs.python.org/issue42147>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42147] Micro optimization for longrange iteration if step is 1

2020-10-25 Thread Dong-hee Na


New submission from Dong-hee Na :

This is a similar case with https://bugs.python.org/issue41902
A quite possible usecase when the user use range with big number

./python -m pyperf compare_to longrange_master.json longrange_opt.json
Mean +- std dev: [longrange_master] 6.45 us +- 0.09 us -> [longrange_opt] 5.72 
us +- 0.07 us: 1.13x faster (-11%)

--
assignee: corona10
components: Interpreter Core
files: bench_longrange.py
messages: 379578
nosy: corona10, methane, vstinner
priority: normal
severity: normal
status: open
title: Micro optimization for longrange iteration if step is 1
type: performance
versions: Python 3.10
Added file: https://bugs.python.org/file49539/bench_longrange.py

___
Python tracker 
<https://bugs.python.org/issue42147>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42132] Use specs instead of just __loader__ in C code

2020-10-24 Thread Dong-hee Na


Change by Dong-hee Na :


--
nosy: +corona10

___
Python tracker 
<https://bugs.python.org/issue42132>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40841] Provide mimetypes.sniff API as stdlib

2020-10-23 Thread Dong-hee Na


Dong-hee Na  added the comment:

@gvanrossum, @taleinat

I've already provided the mimesniffing through PyPI ;)
https://pypi.org/project/mimesniff/

The interface is similar to imghdr.what :)

--

___
Python tracker 
<https://bugs.python.org/issue40841>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40841] Provide mimetypes.sniff API as stdlib

2020-10-23 Thread Dong-hee Na


Dong-hee Na  added the comment:

I close this issue as rejected!

During the sprint, I could hear a lot of opinions from core devs including 
Guido, Tal, and Christian.

The overall conclusion for me is not to add this time.
if the mimetypes module is extracted from stdlib to pypi package, we can 
discuss to add this feature at that time!

Thank you everyone for the discussion!

--
nosy: +christian.heimes, taleinat
resolution:  -> rejected
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue40841>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16094] Tuple extraction in a lambda isn't supported by 2to3

2020-10-23 Thread Dong-hee Na


Change by Dong-hee Na :


--
resolution:  -> wont fix
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue16094>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42057] peephole optimizer bug relating to JUMP_IF_NOT_EXC_MATCH

2020-10-22 Thread Dong-hee Na


Dong-hee Na  added the comment:


New changeset b52432cb8cd7f5f1fc71ea3b7c0ea11573d504f0 by Mark Shannon in 
branch 'master':
bpo-42057: Add regression test to master. (GH-22893)
https://github.com/python/cpython/commit/b52432cb8cd7f5f1fc71ea3b7c0ea11573d504f0


--
nosy: +corona10

___
Python tracker 
<https://bugs.python.org/issue42057>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42111] Make the xxlimited module an example of best extension module practices

2020-10-22 Thread Dong-hee Na


Dong-hee Na  added the comment:

I am +1 on this idea.

--

___
Python tracker 
<https://bugs.python.org/issue42111>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42111] Make the xxlimited module an example of best extension module practices

2020-10-22 Thread Dong-hee Na


Change by Dong-hee Na :


--
nosy: +corona10

___
Python tracker 
<https://bugs.python.org/issue42111>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42115] Caching infrastructure for the evaluation loop: specialised opcodes

2020-10-22 Thread Dong-hee Na


Change by Dong-hee Na :


--
nosy: +corona10

___
Python tracker 
<https://bugs.python.org/issue42115>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41052] Opt out serialization/deserialization for heap type

2020-10-21 Thread Dong-hee Na


Dong-hee Na  added the comment:

> It would be better to fix copyreg._reduce_ex() instead of disabling pickling 
> for these types one by one

I agree :)

--

___
Python tracker 
<https://bugs.python.org/issue41052>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41902] Micro optimization for range.index if step is 1

2020-10-20 Thread Dong-hee Na


Change by Dong-hee Na :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue41902>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41902] Micro optimization for range.index if step is 1

2020-10-20 Thread Dong-hee Na


Dong-hee Na  added the comment:


New changeset c0f22fb8b3006936757cebb959cee94e285bc503 by Dong-hee Na in branch 
'master':
bpo-41902: Micro optimization for range.index if step is 1 (GH-22479)
https://github.com/python/cpython/commit/c0f22fb8b3006936757cebb959cee94e285bc503


--

___
Python tracker 
<https://bugs.python.org/issue41902>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42087] Remove pre-AIX 6.1 dead code paths

2020-10-20 Thread Dong-hee Na


Change by Dong-hee Na :


--
nosy: +corona10, vstinner

___
Python tracker 
<https://bugs.python.org/issue42087>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40671] Convert _hashlib to PEP 489 multiphase initialization

2020-10-19 Thread Dong-hee Na


Change by Dong-hee Na :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue40671>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42042] sphinx3 renders diffrently docs.python.org for 3.10

2020-10-17 Thread Dong-hee Na


Dong-hee Na  added the comment:

Okay this is the theme bug.
https://github.com/python/python-docs-theme/pull/57

--

___
Python tracker 
<https://bugs.python.org/issue42042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42042] sphinx3 renders diffrently docs.python.org for 3.10

2020-10-17 Thread Dong-hee Na


Change by Dong-hee Na :


--
title: docs.python.org for 3.10 missing the new refererence record. -> sphinx3 
renders diffrently docs.python.org for 3.10

___
Python tracker 
<https://bugs.python.org/issue42042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42042] docs.python.org for 3.10 missing the new refererence record.

2020-10-17 Thread Dong-hee Na


Dong-hee Na  added the comment:

One more regression is that
code background highlight is not applied after sphinx version3

See
https://docs.python.org/3.10/c-api/dict.html#c.PyDict_Next
https://docs.python.org/3.9/c-api/dict.html#c.PyDict_Next

--
stage: patch review -> 

___
Python tracker 
<https://bugs.python.org/issue42042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42042] docs.python.org for 3.10 missing the new refererence record.

2020-10-17 Thread Dong-hee Na


Change by Dong-hee Na :


--
nosy: +Mariatta

___
Python tracker 
<https://bugs.python.org/issue42042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42042] docs.python.org for 3.10 missing the new refererence record.

2020-10-17 Thread Dong-hee Na


Change by Dong-hee Na :


--
keywords: +patch
pull_requests: +21702
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/22739

___
Python tracker 
<https://bugs.python.org/issue42042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42042] docs.python.org for 3.10 missing the new refererence record.

2020-10-17 Thread Dong-hee Na


Dong-hee Na  added the comment:

sphinx2
(Pdb) par[0].attributes
{'ids': ['c._PyObject_New'], 'classes': [], 'names': ['c._PyObject_New'], 
'dupnames': [], 'backrefs': [], 'first': False}

sphinx3
(Pdb) par[0].attributes
{'ids': ['c._PyObject_New'], 'classes': [], 'names': [], 'dupnames': [], 
'backrefs': [], 'is_multiline': True}

We are using the names attribute for annotation.

--

___
Python tracker 
<https://bugs.python.org/issue42042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42042] docs.python.org for 3.10 missing the new refererence record.

2020-10-17 Thread Dong-hee Na


Dong-hee Na  added the comment:

This is the regression bug caused by sphinx==3.2.1
If we roll back the sphinx version(2.4.4), it is okay.
I am investigating what causes this issue.

--

___
Python tracker 
<https://bugs.python.org/issue42042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42021] Fix possible ref. leaks in _sqlite3 module initialisation

2020-10-15 Thread Dong-hee Na


Dong-hee Na  added the comment:


New changeset 644e94272a89196801825cb69a56377bf62d256a by Erlend Egeberg 
Aasland in branch 'master':
bpo-42021: Fix possible ref leaks during _sqlite3 module init (GH-22673)
https://github.com/python/cpython/commit/644e94272a89196801825cb69a56377bf62d256a


--
nosy: +corona10

___
Python tracker 
<https://bugs.python.org/issue42021>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42042] docs.python.org for 3.10 missing the new refererence record.

2020-10-15 Thread Dong-hee Na


New submission from Dong-hee Na :

For example
https://docs.python.org/3.10/c-api/bool.html?highlight=pydict_new#c.PyDict_New

should display 

`Return value: New reference.`

but not, this looks like a regression bug.

other version display `Return value: New reference.` very well.

--
assignee: docs@python
components: Documentation
messages: 378677
nosy: corona10, docs@python, vstinner
priority: normal
severity: normal
status: open
title: docs.python.org for 3.10 missing the new refererence record.
versions: Python 3.10

___
Python tracker 
<https://bugs.python.org/issue42042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32793] smtplib: duplicated debug message

2020-10-13 Thread Dong-hee Na


Dong-hee Na  added the comment:

@ZackerySpytz Thank you for work :)

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue32793>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32793] smtplib: duplicated debug message

2020-10-13 Thread Dong-hee Na


Dong-hee Na  added the comment:


New changeset 76b1913daf883b6592815d139f62f3a7fbe3c322 by Dong-hee Na in branch 
'3.8':
[3.8] bpo-32793: Fix a duplicate debug message in smtplib (GH-15341) (GH-22683)
https://github.com/python/cpython/commit/76b1913daf883b6592815d139f62f3a7fbe3c322


--

___
Python tracker 
<https://bugs.python.org/issue32793>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40956] Use Argument Clinic in sqlite3

2020-10-13 Thread Dong-hee Na


Dong-hee Na  added the comment:

> Also, see the comment from Victor here: 
> https://github.com/python/cpython/pull/22478#issuecomment-702201260

Okay got it

--

___
Python tracker 
<https://bugs.python.org/issue40956>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32793] smtplib: duplicated debug message

2020-10-13 Thread Dong-hee Na


Change by Dong-hee Na :


--
versions:  -Python 3.7

___
Python tracker 
<https://bugs.python.org/issue32793>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32793] smtplib: duplicated debug message

2020-10-13 Thread Dong-hee Na


Change by Dong-hee Na :


--
pull_requests: +21655
pull_request: https://github.com/python/cpython/pull/22683

___
Python tracker 
<https://bugs.python.org/issue32793>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32793] smtplib: duplicated debug message

2020-10-13 Thread Dong-hee Na


Dong-hee Na  added the comment:

3.7 only can be applied security fix.

https://cpython-devguide.readthedocs.io/#branchstatus

--
nosy: +corona10

___
Python tracker 
<https://bugs.python.org/issue32793>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40956] Use Argument Clinic in sqlite3

2020-10-13 Thread Dong-hee Na


Dong-hee Na  added the comment:

What's the purpose of using AC, did the change improve performance?
It can make hard to track the code history.

--
nosy: +corona10

___
Python tracker 
<https://bugs.python.org/issue40956>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41972] bytes.find consistently hangs in a particular scenario

2020-10-13 Thread Dong-hee Na


Change by Dong-hee Na :


--
nosy: +corona10

___
Python tracker 
<https://bugs.python.org/issue41972>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41971] multiple tests in test_tools fail since Python 3.9

2020-10-08 Thread Dong-hee Na


Change by Dong-hee Na :


--
nosy: +corona10

___
Python tracker 
<https://bugs.python.org/issue41971>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41922] Use PEP 590 vectorcall to speed up calls to reversed()

2020-10-03 Thread Dong-hee Na


Dong-hee Na  added the comment:

Thank you Victor!

--
resolution: fixed -> 
stage: resolved -> patch review
status: closed -> open

___
Python tracker 
<https://bugs.python.org/issue41922>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41922] Use PEP 590 vectorcall to speed up calls to reversed()

2020-10-03 Thread Dong-hee Na


Change by Dong-hee Na :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue41922>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41922] Use PEP 590 vectorcall to speed up calls to reversed()

2020-10-03 Thread Dong-hee Na


Change by Dong-hee Na :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue41922>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41922] Use PEP 590 vectorcall to speed up calls to reversed()

2020-10-03 Thread Dong-hee Na


Dong-hee Na  added the comment:


New changeset d646e91f5c4f4b76f96494103d440ed0b6257425 by Dong-hee Na in branch 
'master':
bpo-41922: Use PEP 590 vectorcall to speed up reversed() (GH-22523)
https://github.com/python/cpython/commit/d646e91f5c4f4b76f96494103d440ed0b6257425


--

___
Python tracker 
<https://bugs.python.org/issue41922>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41922] Use PEP 590 vectorcall to speed up calls to reversed()

2020-10-03 Thread Dong-hee Na


Change by Dong-hee Na :


--
keywords: +patch
pull_requests: +21529
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/22523

___
Python tracker 
<https://bugs.python.org/issue41922>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41922] Use PEP 590 vectorcall to speed up calls to reversed()

2020-10-03 Thread Dong-hee Na


Change by Dong-hee Na :


--
assignee:  -> corona10

___
Python tracker 
<https://bugs.python.org/issue41922>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41922] Use PEP 590 vectorcall to speed up calls to reversed()

2020-10-03 Thread Dong-hee Na


New submission from Dong-hee Na :

reversed is also a very well-used type.
if shows 10+ percent performance improvement from baseline and this metric.
And this improvement looks acceptable from viewing builtin types which are 
applied PEP 590 (frozenset, list, set, dict)  

reversed creation + for loop
Mean +- std dev: [reversed_master] 157 ns +- 4 ns -> [reversed_opt] 139 ns +- 2 
ns: 1.13x faster (-11%)

reversed creation
Mean +- std dev: [reversed2_master] 118 ns +- 2 ns -> [reversed2_opt] 101 ns +- 
2 ns: 1.18x faster (-15%)

--
components: Interpreter Core
files: bench_reversed.py
messages: 377889
nosy: corona10, pablogsal, vstinner
priority: normal
severity: normal
status: open
title: Use PEP 590 vectorcall to speed up calls to reversed()
type: performance
versions: Python 3.10
Added file: https://bugs.python.org/file49488/bench_reversed.py

___
Python tracker 
<https://bugs.python.org/issue41922>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7946] Convoy effect with I/O bound threads and New GIL

2020-10-02 Thread Dong-hee Na


Change by Dong-hee Na :


--
nosy: +corona10

___
Python tracker 
<https://bugs.python.org/issue7946>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41902] Micro optimization for range.index if step is 1

2020-10-02 Thread Dong-hee Na


Dong-hee Na  added the comment:

@vstinner @pablo @mark

On my local machine (without cpu isolation),
PR 22480 does not affect performance issues.

import pyperf

runner = pyperf.Runner()
runner.timeit(name="bench long divide",
  stmt="""
for i in range(1, 256):
a = 1 // i
""")

but I think that my benchmark does not cover the worst case.

I need to set up the CPU isolation environment but my resource is limited.
(I need a Linux machine with sufficient permission but not)


PR 22479 and PR 22480 has two sides of assumption.

PR 22479: PyNumber_FloorDivide is a heavy operation if the user thinks that 
this is an unnecessary operation it should be avoided.
(In this case divide by one)
PR 22480: PyNumber_FloorDivide should process handle unnecessary operations 
smartly.


In conclusion, I'd like to +1 on mark's decision.
- PR 22480: even though the divisor value is one, if the dividend is not 
qualified from PyLong_CheckExact it will not get an optimization path.
So it will not cover all the 'divide by one' case and it can cause performance 
issues.
- PR 22480: Always optimized if the user does not set a specific step value and 
this will be same effect on PR 22492.

--

___
Python tracker 
<https://bugs.python.org/issue41902>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41902] Micro optimization for range.index if step is 1

2020-10-01 Thread Dong-hee Na


Change by Dong-hee Na :


--
pull_requests: +21509
pull_request: https://github.com/python/cpython/pull/22492

___
Python tracker 
<https://bugs.python.org/issue41902>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41902] Micro optimization for range.index if step is 1

2020-10-01 Thread Dong-hee Na


Dong-hee Na  added the comment:

Mean +- std dev: [master-compute] 317 ns +- 3 ns -> [bpo-41902-compute] 287 ns 
+- 6 ns: 1.11x faster (-10%)

--

___
Python tracker 
<https://bugs.python.org/issue41902>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41902] Micro optimization for range.index if step is 1

2020-10-01 Thread Dong-hee Na


Dong-hee Na  added the comment:

I found another optimal case and this looks more practical usecase than 
range.index

--
Added file: https://bugs.python.org/file49485/bench_range_compute_item.py

___
Python tracker 
<https://bugs.python.org/issue41902>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41902] Micro optimization for range.index if step is 1

2020-10-01 Thread Dong-hee Na


Dong-hee Na  added the comment:

> s there reason to believe that range.index is performed often enough that 
> it's worth the extra code and maintenance cost here?

There are at least 3 reasons
1. pointer comparaition optimization quite common usecase in CPython codebase. 
e.x) list.count
2. if you create the range object, step = 1 which is singleton object is quite 
high percentage use case.
   - range(100) -> step = 1
   - range(-100, 100) -> step =1
   - range(-100, 100, 2) -> step != 1
3. fast path code does not cost high difficulty maintainence for this case but 
can bring 12% performance enhancement.

--

___
Python tracker 
<https://bugs.python.org/issue41902>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41902] Micro optimization for range.index if step is 1

2020-10-01 Thread Dong-hee Na


Dong-hee Na  added the comment:

PR 22479 and PR 22480 are different approaches.

I (and Victor) want to check which approach might be better.

PR 22480 would affect overall long division performance
PR 22479 assumes that step=1 case is very often (e.g range(100), range(-100, 
100))

--

___
Python tracker 
<https://bugs.python.org/issue41902>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41902] Micro optimization for range.index if step is 1

2020-10-01 Thread Dong-hee Na


Change by Dong-hee Na :


--
pull_requests: +21498
pull_request: https://github.com/python/cpython/pull/22480

___
Python tracker 
<https://bugs.python.org/issue41902>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   3   4   5   6   7   8   9   10   >