[issue45774] Detect SQLite in configure.ac

2022-04-05 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue45774>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45847] Port module setup to PY_STDLIB_MOD() macro and addext()

2022-04-02 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

Anthony: you should be able to build the _tkinter by manually specifying the 
compiler and linker flags using the `TCLTK_CFLAGS` and `TCLTK_LIBS` environment 
variables. AFAICS, the flags provided by pkgconfig in Ubuntu 20.04 should work 
well in 18.04 (possibly with minor adjustments; I didn't check).

--

___
Python tracker 
<https://bugs.python.org/issue45847>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46907] Update Windows and MacOS installer to SQLite 3.38.2

2022-03-31 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

Great, thanks :)

--

___
Python tracker 
<https://bugs.python.org/issue46907>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46907] Update Windows and MacOS installer to SQLite 3.38.2

2022-03-31 Thread Erlend E. Aasland

Erlend E. Aasland  added the comment:

> Erlend - would you be up for write permissions on the cpython-source-deps 
> repo so you can push the SQLite updates yourself.

Yep, I’m fine with that.

--

___
Python tracker 
<https://bugs.python.org/issue46907>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46907] Update Windows and MacOS installer to SQLite 3.38.2

2022-03-29 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

Let's hold these PRs a couple of weeks in case more patch releases appear. IMO 
we can hold it until a week or two before the beta phase kicks in.

--

___
Python tracker 
<https://bugs.python.org/issue46907>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

2022-03-29 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

> The C++20 "module" keyword is "contextual keyword". It's only a keyword if 
> the first line if a file contains "module".

Great! No changes needed. Thanks for investigating.

--

___
Python tracker 
<https://bugs.python.org/issue39355>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue47019] Fatal Python Error in sqlite3 Python 3.10

2022-03-15 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

Maybe related: bpo-20891

--

___
Python tracker 
<https://bugs.python.org/issue47019>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue47019] Fatal Python Error in sqlite3 Python 3.10

2022-03-15 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

FYI, PyGILState_Ensure may be called by a thread as many times as you want, and 
it has been so for a very long time.

--

___
Python tracker 
<https://bugs.python.org/issue47019>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue47019] Fatal Python Error in sqlite3 Python 3.10

2022-03-15 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

See also Petrs msg400205:

> [...] I recommend that any function passed to SQLite (and only those) should
>  - be named `*_callback`, for clarity
>  - acquire the GIL at the very start
>  - release the GIL at the very end

--

___
Python tracker 
<https://bugs.python.org/issue47019>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue47019] Fatal Python Error in sqlite3 Python 3.10

2022-03-15 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

See also bpo-44304

--
nosy: +pablogsal

___
Python tracker 
<https://bugs.python.org/issue47019>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue47019] Fatal Python Error in sqlite3 Python 3.10

2022-03-15 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

All callbacks triggered from external libraries must protect Python C API 
calls. You may call it offending, but that is the reality; a callback may 
trigger at any point in time, so we need to make sure the GIL is held before 
calling any Py API. That is also the case for the destructor.

--

___
Python tracker 
<https://bugs.python.org/issue47019>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue47019] Fatal Python Error in sqlite3 Python 3.10

2022-03-15 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

> If you connect with check_same_thread=False, I believe the issue may still 
> present itself on 3.11+

Nope, works swell on my Mac. Do you see this on Linux with latest 3.11?

--

___
Python tracker 
<https://bugs.python.org/issue47019>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46907] Update Windows and MacOS installer to SQLite 3.38.1

2022-03-15 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
resolution:  -> fixed
stage: patch review -> resolved
status: pending -> closed

___
Python tracker 
<https://bugs.python.org/issue46907>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46907] Update Windows and MacOS installer to SQLite 3.38.1

2022-03-15 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

Closing this tonight, unless someone objects.

--
status: open -> pending

___
Python tracker 
<https://bugs.python.org/issue46907>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46907] Update Windows and MacOS installer to SQLite 3.38.1

2022-03-15 Thread Erlend E. Aasland

Erlend E. Aasland  added the comment:

Updating to SQLite 3.37 was backported because of a data corruption bug that 
was fixed. AFAIK, there’s nothing like that in 3.38. I would prefer waiting to 
see if more patch releases appear. (That was also my intent, given how many 
patch releases we saw with 3.35; I’ll start using the dont-merge label from now 
on.)

--

___
Python tracker 
<https://bugs.python.org/issue46907>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue47019] Fatal Python Error in sqlite3 Python 3.10

2022-03-15 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

> My recommended fix is to call sqlite3_close() within 
> Py_BEGIN_ALLOW_THREADS/Py_END_ALLOW_THREADS, and manually Py_DECREF all 
> connection-related functions afterward.

3.11 already drops the GIL before sqlite3_close_v2(); backporting this change 
to 3.10 results in the following assertion error:

$ ./python.exe sqlite3_fatal_python_error.py  
Assertion failed: (!_PyMem_IsPtrFreed(tstate->interp)), function 
is_tstate_valid, file ceval.c, line 155.

--

___
Python tracker 
<https://bugs.python.org/issue47019>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue47019] Fatal Python Error in sqlite3 Python 3.10

2022-03-15 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

> A perfect repro has been attached, should be run on Linux.

FTR, the repo works on macOS 12.2.1 as well:

$ python3.10 ./sqlite3_fatal_python_error.py
Fatal Python error: PyThreadState_Get: the function must be called with the 
GIL held, but the GIL is released (the current Python thread state is NULL)
Python runtime state: initialized

Thread 0x0001126e7600 (most recent call first):
  File 
"/Users/erlendaasland/src/cpython-build/./sqlite3_fatal_python_error.py", line 
52 in 
zsh: abort  python3.10 ./sqlite3_fatal_python_error.py

--

___
Python tracker 
<https://bugs.python.org/issue47019>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue47019] Fatal Python Error in sqlite3 Python 3.10

2022-03-15 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

I'm removing 3.11 from the versions field:


$ python3.11 sqlite3_fatal_python_error.py
Exception ignored in: 
Traceback (most recent call last):
  File 
"/Users/erlendaasland/src/cpython-build/sqlite3_fatal_python_error.py", line 
10, in __del__
self.close()

sqlite3.ProgrammingError: SQLite objects created in a thread can only be 
used in that same thread. The object was created in thread id 123145443913728 
and this is thread id 4506211840.

--
versions:  -Python 3.11

___
Python tracker 
<https://bugs.python.org/issue47019>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45979] Fix Tkinter tests with old Tk

2022-03-15 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
nosy: +erlendaasland

___
Python tracker 
<https://bugs.python.org/issue45979>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46983] test_sqlite3: test_trace_too_much_expanded_sql() failed on AMD64 Arch Linux Usan 3.x

2022-03-11 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

The change that introduced this regression was reverted in GH-31788

--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue46983>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45138] [sqlite3] expand bound values in traced statements when possible

2022-03-09 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
pull_requests: +29892
pull_request: https://github.com/python/cpython/pull/31788

___
Python tracker 
<https://bugs.python.org/issue45138>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45138] [sqlite3] expand bound values in traced statements when possible

2022-03-09 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
pull_requests: +29888
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/31783

___
Python tracker 
<https://bugs.python.org/issue45138>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45138] [sqlite3] expand bound values in traced statements when possible

2022-03-09 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

Ah, one of my very first contributions, bpo-40318, comes back to haunt me:

In bpo-40318, we migrated from the old SQLite trace API (sqlite3_trace) to 
SQLite trace v2 API (sqlite3_trace_v2). GH-19581, which introduced this change, 
introduced a bug: the old trace API _implicitly_ expanded bound parameters; the 
new trace API does not. However, there was no tests for this behaviour, so the 
regression was unnoticed[^1].

So, this bpo is actually a bug fix; not a feature. It should be backported to 
3.10, which contains the regression.

I'm preparing a fix for GH-28240, and I'll prepare a 3.10 backport including 
both GH-2840 and its upcoming fix.


[^1]: There has been no bug reports regarding this change in behaviour, so it 
seems to have gone under most people's radar.

--

___
Python tracker 
<https://bugs.python.org/issue45138>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45138] [sqlite3] expand bound values in traced statements when possible

2022-03-09 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

Reopening bco. broken buildbots.

--
status: closed -> open

___
Python tracker 
<https://bugs.python.org/issue45138>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46878] [sqlite3] remove "non-standard" from docstrings

2022-03-08 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
pull_requests: +29867
pull_request: https://github.com/python/cpython/pull/31754

___
Python tracker 
<https://bugs.python.org/issue46878>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46878] [sqlite3] remove "non-standard" from docstrings

2022-03-08 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
pull_requests: +29866
pull_request: https://github.com/python/cpython/pull/31753

___
Python tracker 
<https://bugs.python.org/issue46878>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46933] Make pwd module optional for wasm32-emscripten and wasi

2022-03-07 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
nosy: +erlendaasland
nosy_count: 1.0 -> 2.0
pull_requests: +29854
pull_request: https://github.com/python/cpython/pull/31737

___
Python tracker 
<https://bugs.python.org/issue46933>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45847] Port module setup to PY_STDLIB_MOD() macro and addext()

2022-03-07 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

Solved: Ubuntu is fine, we just need to treat LIBS and LDFLAGS with care in 
configure.ac. GH-31698 is updated with a fix.

--

___
Python tracker 
<https://bugs.python.org/issue45847>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45847] Port module setup to PY_STDLIB_MOD() macro and addext()

2022-03-07 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

FTR:

$ strings /lib/x86_64-linux-gnu/libtcl8.6.so | grep -E "\"
Tcl_Init
$ strings /lib/x86_64-linux-gnu/libtk8.6.so | grep -E "\"
Tk_Init

--

___
Python tracker 
<https://bugs.python.org/issue45847>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45847] Port module setup to PY_STDLIB_MOD() macro and addext()

2022-03-07 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

> GH-31698 sort'a works given that pkg-config provides us with correct info. 
> Sadly it doesn't for Ubuntu [...]

Hm, looking more closely at Ubuntu (20.4), I see that the pkg-config files is 
actually correct. I'll have to debug this further; perhaps there is an easy way 
out :)

--

___
Python tracker 
<https://bugs.python.org/issue45847>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45847] Port module setup to PY_STDLIB_MOD() macro and addext()

2022-03-07 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

FYI, tested GH-31698 on Debian 10.3, and it works swell there.

--

___
Python tracker 
<https://bugs.python.org/issue45847>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45847] Port module setup to PY_STDLIB_MOD() macro and addext()

2022-03-07 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

Regarding _tkinter (Tcl/Tk):

Based on discussion on Discourse 
(https://discuss.python.org/t/simplifying-tcl-tk-detection/14066), my current 
plan is to just use pkg-config, and drop the rest of the autodetect hackery. 
GH-31698 sort'a works given that pkg-config provides us with correct info. 
Sadly it doesn't for Ubuntu:

```
$ grep lib /usr/lib/x86_64-linux-gnu/pkgconfig/tcl8.6.pc
libdir=/usr/lib/x86_64-linux-gnu
Requires.private: zlib >= 1.2.3
Libs: -L${libdir} -ltcl8.6 -ltclstub8.6
$ ls -ld /usr/lib/x86_64-linux-gnu/{tcl,tk}*
drwxr-xr-x 2 root root 4096 Mar  6 23:59 /usr/lib/x86_64-linux-gnu/tcl8.6
lrwxrwxrwx 1 root root   19 Feb 23  2019 /usr/lib/x86_64-linux-gnu/tclConfig.sh 
-> tcl8.6/tclConfig.sh
lrwxrwxrwx 1 root root   21 Feb 23  2019 
/usr/lib/x86_64-linux-gnu/tclooConfig.sh -> tcl8.6/tclooConfig.sh
drwxr-xr-x 2 root root 4096 Mar  6 23:59 /usr/lib/x86_64-linux-gnu/tk8.6
lrwxrwxrwx 1 root root   17 Feb 23  2019 /usr/lib/x86_64-linux-gnu/tkConfig.sh 
-> tk8.6/tkConfig.sh
```

As you can see, the linker is given the wrong search path, so `AC_LINK_IFELSE` 
fails:

```
$ grep -A4 "gcc.*tcl" config.log
configure:12380: gcc -o conftest  -I/usr/include/tcl8.6  -ltk8.6 -ltkstub8.6 
-ltcl8.6 -ltclstub8.6  conftest.c -lpthread -ldl  >&5
/usr/bin/ld: /tmp/ccMuHSnh.o: in function `main':
conftest.c:(.text+0xb): undefined reference to `Tcl_Init'
/usr/bin/ld: conftest.c:(.text+0x16): undefined reference to `Tk_Init'
collect2: error: ld returned 1 exit status
```

I haven't checked Debian yet, but they may have the same problem.

Plan B:
1. try to push a fix upstream
2. add temporarily hack for Ubuntu/Debian in autoconf
3. remove hack in a year or two

Plan C
1. try to push a fix upstream
2. leave the current hackery as it is and wait another year or two

--

___
Python tracker 
<https://bugs.python.org/issue45847>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45847] Port module setup to PY_STDLIB_MOD() macro and addext()

2022-03-05 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
pull_requests: +29818
pull_request: https://github.com/python/cpython/pull/31698

___
Python tracker 
<https://bugs.python.org/issue45847>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45828] [sqlite3] use unraisable exceptions in callbacks

2022-03-04 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue45828>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46874] [sqlite3] optimise user-defined functions

2022-03-03 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue46874>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45373] ./configure --enable-optimizations should enable LTO

2022-03-03 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
nosy: +erlendaasland

___
Python tracker 
<https://bugs.python.org/issue45373>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46907] Update Windows and MacOS installer to SQLite 3.38.0.

2022-03-03 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

Steve, would you mind updating the cpython sources repo? (No hurry; let's see 
if a patch release surfaces first.)

--

___
Python tracker 
<https://bugs.python.org/issue46907>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46907] Update Windows and MacOS installer to SQLite 3.38.0.

2022-03-03 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

+1 for SQLite 3.38.0.

--

___
Python tracker 
<https://bugs.python.org/issue46907>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46889] enable sqlite math functions on macos

2022-03-02 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

FTR, here's 3.10 and 3.11 on my Mac, using the official Python.org installers:

$ python3.10
Python 3.10.2 (v3.10.2:a58ebcc701, Jan 13 2022, 14:50:16) [Clang 13.0.0 
(clang-1300.0.29.30)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import sqlite3
>>> cx = sqlite3.connect(":memory:")
>>> cx.execute("select sin('1')").fetchone()
(0.8414709848078965,)

$ python3.11
Python 3.11.0a5 (v3.11.0a5:c4e4b91557, Feb  3 2022, 14:54:01) [Clang 13.0.0 
(clang-1300.0.29.30)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import sqlite3
>>> cx = sqlite3.connect(":memory:")
>>> cx.execute("select sin('1')").fetchone()
(0.8414709848078965,)

--
status: open -> pending

___
Python tracker 
<https://bugs.python.org/issue46889>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46889] enable sqlite math functions on macos

2022-03-02 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

Duplicate of bpo-42686.

--
status: pending -> open

___
Python tracker 
<https://bugs.python.org/issue46889>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46889] enable sqlite math functions on macos

2022-03-02 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

Suggesting to close as "not a bug".

--
resolution:  -> not a bug
status: open -> pending

___
Python tracker 
<https://bugs.python.org/issue46889>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46889] enable sqlite math functions on macos

2022-03-02 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

This is not needed. Quoting 
https://sqlite.org/compile.html#enable_math_functions:

This option is automatically added to the Makefile by the configure script 
on unix platforms, unless the --disable-math option is used.

--
nosy: +erlendaasland

___
Python tracker 
<https://bugs.python.org/issue46889>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

2022-03-01 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue43853>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46878] [sqlite3] remove "non-standard" from docstrings

2022-02-28 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
keywords: +patch
pull_requests: +29735
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/31612

___
Python tracker 
<https://bugs.python.org/issue46878>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46878] [sqlite3] remove "non-standard" from docstrings

2022-02-28 Thread Erlend E. Aasland


New submission from Erlend E. Aasland :

Several sqlite3 methods are "marked" as non-standard in their docstrings. This 
is an historic artefact which (I assume) implies that a method is not a part of 
the DB-API defined by PEP 249. Questions regarding the "non-standard" strings 
arise from time to time, as the meaning is not immediately obvious.

The question surfaced in a code review in October 2021[^1], and again in a more 
recent PR[^2].

Suggesting to purge "non-standard" from all docstrings once and for all to 
avoid more confusion.

[^1]: https://github.com/python/cpython/pull/28463#discussion_r724371832
[^2]: https://github.com/python/cpython/pull/26728#discussion_r815523101

--
messages: 414186
nosy: Jelle Zijlstra, erlendaasland
priority: normal
severity: normal
status: open
title: [sqlite3] remove "non-standard" from docstrings
versions: Python 3.11

___
Python tracker 
<https://bugs.python.org/issue46878>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

2022-02-28 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
pull_requests: +29732
pull_request: https://github.com/python/cpython/pull/31609

___
Python tracker 
<https://bugs.python.org/issue46541>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46748] Python.h includes stdbool.h

2022-02-27 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

Can we close this?

--
nosy: +erlendaasland
status: open -> pending

___
Python tracker 
<https://bugs.python.org/issue46748>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46874] [sqlite3] optimise user-defined functions

2022-02-27 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
keywords: +patch
pull_requests: +29727
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/31604

___
Python tracker 
<https://bugs.python.org/issue46874>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46874] [sqlite3] optimise user-defined functions

2022-02-27 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
assignee:  -> erlendaasland

___
Python tracker 
<https://bugs.python.org/issue46874>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46874] [sqlite3] optimise user-defined functions

2022-02-27 Thread Erlend E. Aasland


New submission from Erlend E. Aasland :

Currently, the `step` method of user-defined functions is looked up using 
`PyObject_GetAttrString`. Using an interned string and `PyObject_GetAttr`, we 
can speed up this a little bit.

--
components: Library (Lib)
messages: 414151
nosy: erlendaasland
priority: normal
severity: normal
status: open
title: [sqlite3] optimise user-defined functions
versions: Python 3.11

___
Python tracker 
<https://bugs.python.org/issue46874>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

2022-02-25 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
pull_requests: +29709
pull_request: https://github.com/python/cpython/pull/31586

___
Python tracker 
<https://bugs.python.org/issue43853>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46634] [sqlite3] speed up cursor.execute*()

2022-02-17 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

The change proposed in GH-31127 was included in GH-31351. Closing this.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue46634>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46767] [Doc] sqlite3 Cursor.execute() return value is unspecified

2022-02-16 Thread Erlend E. Aasland

Erlend E. Aasland  added the comment:

Quoting the docs:

> This is a nonstandard shortcut that creates a cursor object by calling the
> cursor() method, calls the cursor’s execute() method with the parameters
> given, and returns the cursor.

There is already a backlink (or back reference) to the Connection.cursor() 
method, which again has a backlink to the Cursor class. What would you suggest 
to make things clearer?

How about the following rewording:

"[...] and returns the newly created cursor object".

(IMO this is too verbose; I'm fine with the current docs.)

--
nosy: +erlendaasland

___
Python tracker 
<https://bugs.python.org/issue46767>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

2022-02-15 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
nosy: +erlendaasland
nosy_count: 5.0 -> 6.0
pull_requests: +29500
pull_request: https://github.com/python/cpython/pull/31351

___
Python tracker 
<https://bugs.python.org/issue46541>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46355] [C API] Document PyFrameObject and PyThreadState changes and explain how to port code to Python 3.11

2022-02-11 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
nosy: +erlendaasland
nosy_count: 4.0 -> 5.0
pull_requests: +29448
pull_request: https://github.com/python/cpython/pull/31288

___
Python tracker 
<https://bugs.python.org/issue46355>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46725] Unpacking without parentheses is allowed since 3.9

2022-02-11 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

+1 (what Jelle said)

--
nosy: +erlendaasland

___
Python tracker 
<https://bugs.python.org/issue46725>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46433] _PyType_GetModuleByDef optimization is incorrect

2022-02-11 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

> Do you plan to make the function public? It would be nice!

See https://github.com/python/cpython/pull/31081

--

___
Python tracker 
<https://bugs.python.org/issue46433>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

2022-02-11 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

> There will be huge changes for this issue as this keyword has been used in a 
> lot of places.

For external extension modules, it should be sufficient to change only the 
exposed headers; that is Include/*.h and Include/cpython/*.h. We should also 
change the AC tool, since that may be used by external projects.

--

___
Python tracker 
<https://bugs.python.org/issue39355>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

2022-02-11 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
Removed message: https://bugs.python.org/msg413055

___
Python tracker 
<https://bugs.python.org/issue39355>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39355] The Python library will not compile with a C++2020 compiler because the code uses the reserved “module” keyword

2022-02-11 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

> There will be huge changes for this issue as this keyword has been used in a 
> lot of places.

It should be sufficient to change only the exposed headers; that is Include/*.h 
and Include/cpython/*.h. We should also change the AC tool, since that may be 
used by external projects.

--
nosy: +erlendaasland

___
Python tracker 
<https://bugs.python.org/issue39355>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42698] Deadlock in pysqlite_connection_dealloc()

2022-02-11 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

> Any update on this?

I was unable to reproduce this last time we visited this issue, but I'll give 
it another try.

> If there is no immediate plan to make this change you may close the issue :)

I do not want to close it until I can a) either prove that it is _not_ an 
issue, or b) prove that it _is_ an issue _and_ we've got a fix :)

--

___
Python tracker 
<https://bugs.python.org/issue42698>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45490] [C API] PEP 670: Convert macros to functions in the Python C API

2022-02-10 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

I made a list of macros that reuse their argument some time around 
February/March 2021. (Each macro is squashed into a single line for some reason 
I can't remember.) See attachment, or check out the gist version:

https://gist.github.com/erlend-aasland/a7ca3cff95b136e272ff5b03447aff21

--
Added file: https://bugs.python.org/file50616/macros-that-reuse-args.txt

___
Python tracker 
<https://bugs.python.org/issue45490>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46662] Lib/sqlite3/dbapi2.py: convert_timestamp function failed to correctly parse timestamp

2022-02-08 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
nosy: +lemburg

___
Python tracker 
<https://bugs.python.org/issue46662>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46662] Lib/sqlite3/dbapi2.py: convert_timestamp function failed to correctly parse timestamp

2022-02-08 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

The sqlite3 timestamp converter is buggy, as already noted in the docs[^1]. 
Adding timezone support is out of the question[^2][^3][^4][^5], but fixing it 
to be able to discard any attached timezone info _may_ be ok; at first sight, I 
don't see how this could break existing applications (like, for example adding 
time zone support could do). I need to think it through. In the meanwhile, I 
suggest taking a look at the linked issues.


[^1]: 
https://docs.python.org/3/library/sqlite3.html#default-adapters-and-converters
[^2]: bpo-19065
[^3]: bpo-26651
[^4]: bpo-45858
[^5]: 
https://discuss.python.org/t/fixing-sqlite-timestamp-converter-to-handle-utc-offsets/10985

--

___
Python tracker 
<https://bugs.python.org/issue46662>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46657] Add mimalloc memory allocator

2022-02-07 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
nosy: +erlendaasland

___
Python tracker 
<https://bugs.python.org/issue46657>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46634] [sqlite3] speed up cursor.execute*()

2022-02-04 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
keywords: +patch
pull_requests: +29306
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/31127

___
Python tracker 
<https://bugs.python.org/issue46634>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46634] [sqlite3] speed up cursor.execute*()

2022-02-04 Thread Erlend E. Aasland

New submission from Erlend E. Aasland :

`pysqlite_connection_execute_impl()` and friends (executemany, executescript) 
goes all the way through the Call API just to call 
`pysqlite_connection_cursor_impl`. We can same a lot of calls by calling the 
cursor _impl function directly; after all, it does live in the same file scope 
as the callers.

A quick bench (sqlitesynth) shows a small speedup:

Mean +- std dev: [main] 9.55 us +- 0.25 us -> [patched] 9.32 us +- 0.23 us: 
1.02x faster



(Side effect: will get rid of _Py_IDENTIFIER(cursor) in sqlite3)

--
components: Extension Modules
messages: 412503
nosy: erlendaasland
priority: normal
severity: normal
status: open
title: [sqlite3] speed up cursor.execute*()
versions: Python 3.11

___
Python tracker 
<https://bugs.python.org/issue46634>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46200] Discourage logging f-strings due to security considerations

2022-02-04 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
nosy:  -erlendaasland

___
Python tracker 
<https://bugs.python.org/issue46200>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46433] _PyType_GetModuleByDef optimization is incorrect

2022-02-04 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

Right, this of course affects 3.10 and 3.9. Let me know if you want me to do 
the backports :)


(Updating version field for this ticket)

--
versions: +Python 3.10, Python 3.9

___
Python tracker 
<https://bugs.python.org/issue46433>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46433] _PyType_GetModuleByDef optimization is incorrect

2022-02-03 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

It looks like this can be closed. Petr?

--
status: open -> pending

___
Python tracker 
<https://bugs.python.org/issue46433>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46374] Assertion failed in ceval.c

2022-01-30 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

Did GH-30633 fix this? Is there further work to be done?

--
nosy: +erlendaasland
status: open -> pending

___
Python tracker 
<https://bugs.python.org/issue46374>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

2022-01-30 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
pull_requests: +29211
pull_request: https://github.com/python/cpython/pull/31030

___
Python tracker 
<https://bugs.python.org/issue43853>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43916] Check that new heap types cannot be created uninitialised: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2022-01-27 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

FYI: There are only two bug-fix releases left for 3.9.

--

___
Python tracker 
<https://bugs.python.org/issue43916>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43916] Check that new heap types cannot be created uninitialised: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2022-01-27 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
title: Mark static types newly converted to heap types as immutable: add 
Py_TPFLAGS_DISALLOW_INSTANTIATION type flag -> Check that new heap types cannot 
be created uninitialised: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

___
Python tracker 
<https://bugs.python.org/issue43916>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2022-01-27 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
versions: +Python 3.9 -Python 3.10

___
Python tracker 
<https://bugs.python.org/issue43916>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43916] Mark static types newly converted to heap types as immutable: add Py_TPFLAGS_DISALLOW_INSTANTIATION type flag

2022-01-27 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

> Can we close this issue? Or is there a remaining task?

3.9 is still affected; we should fix those types first.

--

___
Python tracker 
<https://bugs.python.org/issue43916>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46471] use global singletons for single byte bytes objects in deepfreeze

2022-01-23 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

Can we close this, or are you expecting more changes?

--
nosy: +erlendaasland
status: open -> pending

___
Python tracker 
<https://bugs.python.org/issue46471>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-22 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

Previously, this failure was more sporadic; now it happens almost every single 
run on the Azure CI. Has there been updates on the Azure CI lately?

--

___
Python tracker 
<https://bugs.python.org/issue41682>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46212] Avoid temporary `varargs` tuple creation in argument passing

2022-01-21 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

> AFAIK we have committed _PyArg_UnpackKeywordsWithVararg on 3.11 alpha, so I 
> think it should be fine.

I see, so no ABI worries then.

--

___
Python tracker 
<https://bugs.python.org/issue46212>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24905] Allow incremental I/O to blobs in sqlite3

2022-01-20 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

If you are ok with the proposed API in GH-30680, I'll mark it as ready for 
review.

--

___
Python tracker 
<https://bugs.python.org/issue24905>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46433] _PyType_GetModuleByDef optimization is incorrect

2022-01-19 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
nosy: +erlendaasland

___
Python tracker 
<https://bugs.python.org/issue46433>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24905] Allow incremental I/O to blobs in sqlite3

2022-01-18 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

PR without mapping protocol and context manager submitted: GH-30680. I've also 
changed the open API to reflect that of apsw.

--

___
Python tracker 
<https://bugs.python.org/issue24905>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24905] Allow incremental I/O to blobs in sqlite3

2022-01-18 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
pull_requests: +28878
pull_request: https://github.com/python/cpython/pull/30680

___
Python tracker 
<https://bugs.python.org/issue24905>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46402] Enhance sqlite3 to avoid implicit creation?

2022-01-18 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

Closing this. Thanks, Ned and Eric!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue46402>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46428] 3.11.0a3 vs 3.11.0a4

2022-01-18 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
nosy: +iritkatriel

___
Python tracker 
<https://bugs.python.org/issue46428>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46402] Enhance sqlite3 to avoid implicit creation?

2022-01-18 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

> BTW, I'm fine with this being closed, since the functionality I wanted is 
> available and documented.

Great. I was considering closing it as soon as the backports have landed (I had 
to manually fix them bco. make suspicious failures).

--

___
Python tracker 
<https://bugs.python.org/issue46402>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46402] Enhance sqlite3 to avoid implicit creation?

2022-01-18 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
pull_requests: +28872
pull_request: https://github.com/python/cpython/pull/30672

___
Python tracker 
<https://bugs.python.org/issue46402>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46402] Enhance sqlite3 to avoid implicit creation?

2022-01-18 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
pull_requests: +28871
pull_request: https://github.com/python/cpython/pull/30671

___
Python tracker 
<https://bugs.python.org/issue46402>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46402] Enhance sqlite3 to avoid implicit creation?

2022-01-18 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

I created GH-30660 in order to try to enhance the docs. Ned and Eric, would you 
mind taking a look at the PR?

--

___
Python tracker 
<https://bugs.python.org/issue46402>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46402] Enhance sqlite3 to avoid implicit creation?

2022-01-18 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
keywords: +patch
pull_requests: +28861
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/30660

___
Python tracker 
<https://bugs.python.org/issue46402>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46417] [subinterpreters] Clear static types in Py_Finalize()

2022-01-18 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
nosy: +erlendaasland

___
Python tracker 
<https://bugs.python.org/issue46417>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46402] Enhance sqlite3 to avoid implicit creation?

2022-01-17 Thread Erlend E. Aasland

Erlend E. Aasland  added the comment:

I guess we could do more to promote that trick in the docs. It’s quite useful.

--

___
Python tracker 
<https://bugs.python.org/issue46402>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46402] Enhance sqlite3 to avoid implicit creation?

2022-01-17 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

OTOH, implementing an API similar to apsw (adding a flags keyword) would make 
it easier for users to switch between that and the stdlib sqlite3.

--

___
Python tracker 
<https://bugs.python.org/issue46402>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46402] Enhance sqlite3 to avoid implicit creation?

2022-01-17 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

IMO, the URI "API" is not very pythonic; I have to look up the format every 
time I'm using it.

OTOH, introducing flags, or keywords, for every option will add a lot of code.

--

___
Python tracker 
<https://bugs.python.org/issue46402>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46402] Enhance sqlite3 to avoid implicit creation?

2022-01-17 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

See also bpo-24887.

--

___
Python tracker 
<https://bugs.python.org/issue46402>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46402] Enhance sqlite3 to avoid implicit creation?

2022-01-17 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

FYI, you can already do this using the URI option:

cx = sqlite3.connect("file:test.db?mode=rw", uri=True)

--

___
Python tracker 
<https://bugs.python.org/issue46402>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46314] Stray RESUME opcode for unused lambda

2022-01-12 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

> This fixes the problems I was seeing, thanks.

Good; removing release blocker status. Keeping this open until Mark has added a 
NEWS item.

--
nosy: +erlendaasland
priority: release blocker -> 

___
Python tracker 
<https://bugs.python.org/issue46314>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46331] 3.11: tracing revisits class line after class docstring

2022-01-12 Thread Erlend E. Aasland


Change by Erlend E. Aasland :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue46331>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46249] [sqlite3] move set lastrowid out of the query loop and enable it for executemany()

2022-01-11 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

> You don't know on which cursor the last row was inserted [...]

SQLite has no concept of cursors :)

> It also seems that the function really only works for INSERTs and
> not for UPDATEs.

Yes, hence it's name: sqlite3_last_insert_rowid() !

> I'd suggest to deprecate the cursor.lastrowid attribute and
> instead point people to the much more useful [...]

Yes, I think mentioning the RETURNING ROWID trick in the sqlite3 docs is a very 
nice improvement. Mentioning the last_insert_rowid SQL function is probably 
also worth consideration.

I'm reluctant to deprecate cursor.lastrowid, though. ATM, I'm leaning towards 
just keeping the current behaviour.

> But this is your call :-)

I hear you are saying that, but strictly speaking I'm _not_ the sqlite3 module 
maintainer; I'm just a very eager contributor :)

--

___
Python tracker 
<https://bugs.python.org/issue46249>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46249] [sqlite3] move set lastrowid out of the query loop and enable it for executemany()

2022-01-11 Thread Erlend E. Aasland


Erlend E. Aasland  added the comment:

> OTOH, the SQLite API is tied to the _connection_ object, so it may not make 
> sense to align it with lastrowid which is a _cursor_ attribute.

That came out weird; let's try again:

The SQLite API is tied to the _connection_ object, so it may not make sense to 
force that behaviour onto lastrowid which is a _cursor_ attribute.

--

___
Python tracker 
<https://bugs.python.org/issue46249>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   3   4   5   6   7   8   9   >