[issue1602742] itemconfigure returns incorrect text property of text items
Francisco Martín Brugué added the comment: Hi, just a question: the status of this issue is pending but it seems to be already resolved/duplicated. Means that this issue can be closed? Thansk in advance! -- nosy: +francismb status: pending -> open ___ Python tracker <http://bugs.python.org/issue1602742> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21422] int << 0: return the number unmodified
Francisco Martín Brugué added the comment: > > What we want to test is that the return value is of type 'int', which is what > Victor's test checks. > Thank you for the explanations! for 2.7.6 type(2 << 62) is and type(2 << 61) is (I suppose it's analogous in a 32 bit machine around type(2 << 30) so I just wanted to test on that limits). Is that still relevant? or is too much detail and we should stop here. Regards, francis -- ___ Python tracker <http://bugs.python.org/issue21422> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21422] int << 0: return the number unmodified
Francisco Martín Brugué added the comment: I Victor you were so fast, I started with one patch also in bool (at least the place was right). The problem is that I was getting some extrage (for me at least). As far I hat: def test_shifted_true(self): with self.assertRaises(ValueError): True << -1 self.assertIs(True << 0, 1) self.assertIs(True << 1, 2) self.assertEqual(True << 63, 1 << 63) self.assertIs(True << 63, 1 << 63) And I'm getting: == FAIL: test_shifted_true (test.test_bool.BoolTest) -- Traceback (most recent call last): File "/home/ci/Prog/cpython/src/Lib/test/test_bool.py", line 349, in test_shifted_true self.assertIs(True << 63, 1 << 63) AssertionError: 9223372036854775808 is not 9223372036854775808 -- That's: ./python --version Python 3.5.0a0 >>> type(True<<63) >>> type(1<<63) hg tip changeset: 90664:4e33c343a264 What I'm doing wrong? That's: ./python --version Python 3.5.0a0 >>> type(True<<63) >>> type(1<<63) hg tip changeset: 90664:4e33c343a264 What I was doing wrong? Thanks in advance! francis -- ___ Python tracker <http://bugs.python.org/issue21422> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21422] int << 0: return the number unmodified
Francisco Martín Brugué added the comment: Hi, sorry if it's trivial but shouldn't we add a 'shifted_true' test some were to make sure that this behavior change gets noticed next time? def test_shifted_true(self): self.assertEqual(True << 0, 1) self.assertEqual(True << 1, 2) -- nosy: +francismb ___ Python tracker <http://bugs.python.org/issue21422> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14019] Unify tests for str.format and string.Formatter
Francisco Martín Brugué added the comment: The formatter module was deprecated in Python 3.4 and is scheduled for removal in Python 3.6. See [1] and [2]. --- [1] https://docs.python.org/3/library/formatter.html#module-formatter [2] https://docs.python.org/3/whatsnew/3.4.html#deprecated -- ___ Python tracker <http://bugs.python.org/issue14019> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6839] zipfile can't extract file
Francisco Martín Brugué added the comment: A small question related to: "zipfile_276_filename_mismatch_v3.patch" --- a/zipfile.pyWed Apr 30 11:44:38 2014 +++ b/zipfile.pyWed Apr 30 15:10:38 2014 @@ -970,10 +970,10 @@ if fheader[_FH_EXTRA_FIELD_LENGTH]: zef_file.read(fheader[_FH_EXTRA_FIELD_LENGTH]) -if fname != zinfo.orig_filename: -raise BadZipfile, \ +if self.debug and fname != zinfo.orig_filename: +print( \ 'File name in directory "%s" and header "%s" differ.' % ( -zinfo.orig_filename, fname) +zinfo.orig_filename, fname)) Shouldn't a change from raising an exception to a print be somewhere documented? Thanks -- nosy: +francismb ___ Python tracker <http://bugs.python.org/issue6839> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19856] shutil.move() can't move a directory in non-empty directory on Windows
Francisco Martín Brugué added the comment: And finally the test runs: 1) The original. No new tests, no new patch. == CPython 2.7.6 (default, Nov 10 2013, 19:24:18) [MSC v.1500 32 bit (Intel)] == Windows-7-6.1.7601-SP1 little-endian == c:\users\brugue\appdata\local\temp\test_python_5444 Testing with flags: sys.flags(debug=0, py3k_warning=0, division_warning=0, division_new=0, inspect=0, interactive=0, optimize=0, dont_write_bytecode=0, no_user_site=0, no_site=0, ignore_environment=0, tabcheck=0, verbose=0, unicode=0, bytes_warning=0, hash_randomization=0) test_shutil test_copystat_handles_harmless_chflags_errors (test.test_shutil.TestShutil) ... skipped 'requires os.chflags, EOPNOTSUPP & ENOTSUP' test_copytree_simple (test.test_shutil.TestShutil) ... ok test_copytree_with_exclude (test.test_shutil.TestShutil) ... ok test_make_archive (test.test_shutil.TestShutil) ... ok test_make_archive_cwd (test.test_shutil.TestShutil) ... ok test_make_archive_owner_group (test.test_shutil.TestShutil) ... ok test_make_tarball (test.test_shutil.TestShutil) ... ok test_make_zipfile (test.test_shutil.TestShutil) ... ok test_on_error (test.test_shutil.TestShutil) ... ok test_register_archive_format (test.test_shutil.TestShutil) ... ok test_rmtree_dont_delete_file (test.test_shutil.TestShutil) ... ok test_rmtree_errors (test.test_shutil.TestShutil) ... ok test_tarfile_root_owner (test.test_shutil.TestShutil) ... skipped 'Requires grp and pwd support' test_tarfile_vs_tar (test.test_shutil.TestShutil) ... skipped 'Need the tar command to run' test_destinsrc_false_negative (test.test_shutil.TestMove) ... ok test_destinsrc_false_positive (test.test_shutil.TestMove) ... ok test_dont_move_dir_in_itself (test.test_shutil.TestMove) ... ok test_existing_file_inside_dest_dir (test.test_shutil.TestMove) ... ok test_move_dir (test.test_shutil.TestMove) ... ok test_move_dir_other_fs (test.test_shutil.TestMove) ... ok test_move_dir_to_dir (test.test_shutil.TestMove) ... ok test_move_dir_to_dir_other_fs (test.test_shutil.TestMove) ... ok test_move_file (test.test_shutil.TestMove) ... ok test_move_file_other_fs (test.test_shutil.TestMove) ... ok test_move_file_to_dir (test.test_shutil.TestMove) ... ok test_move_file_to_dir_other_fs (test.test_shutil.TestMove) ... ok test_move_dir_caseinsensitive (test.test_shutil.TestCopyFile) ... ok test_w_dest_close_fails (test.test_shutil.TestCopyFile) ... ok test_w_dest_open_fails (test.test_shutil.TestCopyFile) ... ok test_w_source_close_fails (test.test_shutil.TestCopyFile) ... ok test_w_source_open_fails (test.test_shutil.TestCopyFile) ... ok -- Ran 31 tests in 0.359s OK (skipped=3) 1 test OK. 2) New tests, no new patch: == CPython 2.7.6 (default, Nov 10 2013, 19:24:18) [MSC v.1500 32 bit (Intel)] == Windows-7-6.1.7601-SP1 little-endian == c:\users\brugue\appdata\local\temp\test_python_5724 Testing with flags: sys.flags(debug=0, py3k_warning=0, division_warning=0, division_new=0, inspect=0, interactive=0, optimize=0, dont_write_bytecode=0, no_user_site=0, no_site=0, ignore_environment=0, tabcheck=0, verbose=0, unicode=0, bytes_warning=0, hash_randomization=0) test_shutil test_copystat_handles_harmless_chflags_errors (test.test_shutil.TestShutil) ... skipped 'requires os.chflags, EOPNOTSUPP & ENOTSUP' test_copytree_simple (test.test_shutil.TestShutil) ... ok test_copytree_with_exclude (test.test_shutil.TestShutil) ... ok test_make_archive (test.test_shutil.TestShutil) ... ok test_make_archive_cwd (test.test_shutil.TestShutil) ... ok test_make_archive_owner_group (test.test_shutil.TestShutil) ... ok test_make_tarball (test.test_shutil.TestShutil) ... ok test_make_zipfile (test.test_shutil.TestShutil) ... ok test_on_error (test.test_shutil.TestShutil) ... ok test_register_archive_format (test.test_shutil.TestShutil) ... ok test_rmtree_dont_delete_file (test.test_shutil.TestShutil) ... ok test_rmtree_errors (test.test_shutil.TestShutil) ... ok test_tarfile_root_owner (test.test_shutil.TestShutil) ... skipped 'Requires grp and pwd support' test_tarfile_vs_tar (test.test_shutil.TestShutil) ... skipped 'Need the tar command to run' test_destinsrc_false_negative (test.test_shutil.TestMove) ... ok test_destinsrc_false_positive (test.test_shutil.TestMove) ... ok test_dont_move_dir_in_itself (test.test_shutil.TestMove) ... ok test_existing_file_inside_dest_dir (test.test_shutil.TestMove) ... ok test_move_dir (test.test_shutil.TestMove) ... ok test_move_dir_altsep_to_dir (test.test_shutil.TestMove) ... ERROR test_move_dir_other_fs (test.test_shutil.TestMove) ... ok test_move_dir_sep_to_dir (test.test_shutil.TestMove) ... ok test_move_dir_to_dir (test.test_shutil.TestMove) ... ok test_move_dir_to_dir_other_fs (test.test_shutil.TestMove) ... ok test_move_file (test.test_shutil.TestMove) ... ok test_move_file_other_fs (test.test_shutil.TestM
[issue19856] shutil.move() can't move a directory in non-empty directory on Windows
Francisco Martín Brugué added the comment:
I've applied the patch manually to 2.7. Then I've done the tests again (notice
test_A traceback):
test_A:
>>> import os, shutil
>>> os.makedirs('foo')
>>> os.makedirs('bar/foo')
>>> shutil.move('foo/', 'bar/')
Traceback (most recent call last):
File "", line 1, in
shutil.move('foo/', 'bar/')
File "D:\programs\Python27\lib\shutil.py", line 292, in move
raise Error, "Destination path '%s' already exists" % real_dst
Error: Destination path 'bar/foo' already exists
test_B:
>>> os.makedirs('foo')
>>> os.makedirs('bar/foo')
>>> shutil.move('foo', 'bar/')
Traceback (most recent call last):
File "", line 1, in
shutil.move('foo', 'bar/')
File "D:\programs\Python27\lib\shutil.py", line 292, in move
raise Error, "Destination path '%s' already exists" % real_dst
Error: Destination path 'bar/foo' already exists
test_C:
>>> os.makedirs('foo')
>>> os.makedirs('bar/foo')
>>> shutil.move('foo\\', 'bar/')
Traceback (most recent call last):
File "", line 1, in
shutil.move('foo\\', 'bar/')
File "D:\programs\Python27\lib\shutil.py", line 292, in move
raise Error, "Destination path '%s' already exists" % real_dst
Error: Destination path 'bar/foo' already exists
--
Added file:
http://bugs.python.org/file34028/shutil_move_dir_altsep_python27.patch
___
Python tracker
<http://bugs.python.org/issue19856>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19856] shutil.move() can't move a directory in non-empty directory on Windows
Francisco Martín Brugué added the comment:
First I've reviewed #msg205585 again (no patch applied). Notice that Traceback
was not accurate:
test_A:
>>> os.makedirs('foo')
>>> os.makedirs('bar/foo')
>>> shutil.move('foo/', 'bar/')
Traceback (most recent call last):
File "", line 1, in
shutil.move('foo/', 'bar/')
File "D:\programs\Python27\lib\shutil.py", line 291, in move
raise Error, "Destination path '%s' already exists" % real_dst
Error: Destination path 'bar/' already exists
test_B:
>>> os.makedirs('foo')
>>> os.makedirs('bar/foo')
>>> shutil.move('foo', 'bar/')
Traceback (most recent call last):
File "", line 1, in
shutil.move('foo', 'bar/')
File "D:\programs\Python27\lib\shutil.py", line 291, in move
raise Error, "Destination path '%s' already exists" % real_dst
Error: Destination path 'bar/foo' already exists
test_C:
>>> os.makedirs('foo')
>>> os.makedirs('bar/foo')
>>> shutil.move('foo\\', 'bar/')
Traceback (most recent call last):
File "", line 1, in
shutil.move('foo\\', 'bar/')
File "D:\programs\Python27\lib\shutil.py", line 291, in move
raise Error, "Destination path '%s' already exists" % real_dst
Error: Destination path 'bar/foo' already exists
--
___
Python tracker
<http://bugs.python.org/issue19856>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19856] Possible bug in shutil.move() on Windows
Francisco Martín Brugué added the comment:
Just feedback on windows7. I tried the tests inside IDLE and done 'Run Module'
(F5) (deleting the directories between tests):
test_A:
import os, shutil
os.makedirs('foo')
os.makedirs('bar/boo')
shutil.move('foo/', 'bar/')
test_B:
import os, shutil
os.makedirs('foo')
os.makedirs('bar/boo')
shutil.move('foo', 'bar/')
and finally test_C:
import os, shutil
os.makedirs('foo')
os.makedirs('bar/boo')
shutil.move('foo\\', 'bar/')
... and got the same traceback:
Python 2.7.6 (default, Nov 10 2013, 19:24:18) [MSC v.1500 32 bit (Intel)] on
win32
Type "copyright", "credits" or "license()" for more information.
>>> RESTART
>>>
Traceback (most recent call last):
File "D:\temp\test.py", line 4, in
shutil.move('foo/','bar/')
File "D:\programs\Python27\lib\shutil.py", line 291, in move
raise Error, "Destination path '%s' already exists" % real_dst
Error: Destination path 'bar/' already exists
>>>
--
nosy: +francismb
___
Python tracker
<http://bugs.python.org/issue19856>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19904] Add 128-bit integer support to struct
Francisco Martín Brugué added the comment: > If performance is the reason for the feature: My impression is that > the goal of the struct module is not necessarily top performance. I'm not sure if it applies but on #19905 (message 205345 [1]) is said its a dependency for that issue [1] http://bugs.python.org/issue19905#msg205345 -- nosy: +francismb ___ Python tracker <http://bugs.python.org/issue19904> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19866] tests aifc, sunau and wave failures on a fresh Win64 installation
Francisco Martín Brugué added the comment: On 12/03/2013 07:21 PM, Zachary Ware wrote: > > Zachary Ware added the comment: > > Francis, would you like to work on a patch for this? The change should go in > Tools/msi/msi.py, if I'm not mistaken. > > -- > > ___ > Python tracker > <http://bugs.python.org/issue19866> > ___ > please go ahead -- ___ Python tracker <http://bugs.python.org/issue19866> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19866] tests aifc, sunau and wave failures on a fresh Win64 installation
Changes by Francisco Martín Brugué : Added file: http://bugs.python.org/file32943/failed_test_wave.txt ___ Python tracker <http://bugs.python.org/issue19866> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19866] tests aifc, sunau and wave failures on a fresh Win64 installation
Changes by Francisco Martín Brugué : Added file: http://bugs.python.org/file32942/failed_test_sunau.txt ___ Python tracker <http://bugs.python.org/issue19866> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19866] tests aifc, sunau and wave failures on a fresh Win64 installation
New submission from Francisco Martín Brugué: I've just installed Cpython 2.7.6 32bit on Windows64, run the tests [1] and some of them failed. Some of them seems related to audiodata not beeing installed. .\python.exe Lib\test\regrtest.py -v == CPython 2.7.6 (default, Nov 10 2013, 19:24:18) [MSC v.1500 32 bit (Intel)] == Windows-7-6.1.7601-SP1 little-endian == c:\users\brugue\appdata\local\temp\test_python_1388 Testing with flags: sys.flags(debug=0, py3k_warning=0, division_warning=0, division_new=0, inspect=0, interactive=0, optimize=0, dont_write_bytecode=0, no_user_site=0, no_site=0, ignore_environment=0, tabcheck=0, verbose=0, unicode=0, bytes_warning=0, hash_randomization=0) ... test_aifc ... == ERROR: test_close (test.test_aifc.AifcPCM8Test) -- Traceback (most recent call last): File "D:\programs\Python27\lib\test\audiotests.py", line 148, in test_close with open(self.sndfilepath, 'rb') as testfile: IOError: [Errno 2] No such file or directory: 'audiodata\\pluck-pcm8.aiff' ... and more... FAILED (errors=30) ... test_sunau == ERROR: test_close (test.test_sunau.SunauPCM8Test) -- Traceback (most recent call last): File "D:\programs\Python27\lib\test\audiotests.py", line 148, in test_close with open(self.sndfilepath, 'rb') as testfile: IOError: [Errno 2] No such file or directory: 'audiodata\\pluck-pcm8.au' ... Exception AttributeError: "Au_read instance has no attribute '_file'" in > ignored Exception AttributeError: "Au_read instance has no attribute '_file'" in > ignored Exception AttributeError: "Au_read instance has no attribute '_file'" in > ignored Exception AttributeError: "Au_read instance has no attribute '_file'" in > ignored Exception AttributeError: "Au_read instance has no attribute '_file'" in > ignored Exception AttributeError: "Au_read instance has no attribute '_file'" in > ignored Exception AttributeError: "Au_read instance has no attribute '_file'" in > ignored Exception AttributeError: "Au_read instance has no attribute '_file'" in > ignored Exception AttributeError: "Au_read instance has no attribute '_file'" in > ignored Exception AttributeError: "Au_read instance has no attribute '_file'" in > ignored Exception AttributeError: "Au_read instance has no attribute '_file'" in > ignored Exception AttributeError: "Au_read instance has no attribute '_file'" in > ignored Exception AttributeError: "Au_read instance has no attribute '_file'" in > ignored Exception AttributeError: "Au_read instance has no attribute '_file'" in > ignored Exception AttributeError: "Au_read instance has no attribute '_file'" in > ignored test test_sunau failed -- multiple errors occurred ... and more ... ... FAILED (errors=25) ... test_wave ... == ERROR: test_close (test.test_wave.WavePCM8Test) -- Traceback (most recent call last): File "D:\programs\Python27\lib\test\audiotests.py", line 148, in test_close with open(self.sndfilepath, 'rb') as testfile: IOError: [Errno 2] No such file or directory: 'audiodata\\pluck-pcm8.wav' ... FAILED (errors=20) ... See attached files -- components: Windows files: failed_test_aifc.txt messages: 205059 nosy: francismb priority: normal severity: normal status: open title: tests aifc, sunau and wave failures on a fresh Win64 installation versions: Python 2.7 Added file: http://bugs.python.org/file32941/failed_test_aifc.txt ___ Python tracker <http://bugs.python.org/issue19866> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19626] test_email and Lib/email/_policybase.py failures with -OO
Francisco Martín Brugué added the comment: small correction: a fresh clone, then: ./configure --with-pydebug make -j4 ./python -OO -m test -v test_email -- ___ Python tracker <http://bugs.python.org/issue19626> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19626] test_email and Lib/email/_policybase.py failures with -OO
Francisco Martín Brugué added the comment: Actual tip: changeset: 87276:2012e85638d9 date: Tue Nov 19 11:43:38 2013 -0800 It's a fresh clone, then: make clean ./configure --with-pydebug make -j4 ./python -OO -m test -v test_email == CPython 3.4.0a4+ (default:2012e85638d9, Nov 19 2013, 22:40:39) [GCC 4.7.2] == Linux-3.2.0-4-amd64-x86_64-with-debian-7.2 little-endian == /home/ci/Prog/cpython_test/cpython/build/test_python_30828 Testing with flags: sys.flags(debug=0, inspect=0, interactive=0, optimize=2, dont_write_bytecode=0, no_user_site=0, no_site=0, igno re_environment=0, verbose=0, bytes_warning=0, quiet=0, hash_randomization=1, isolated=0) [1/1] test_email test_b_case_ignored (test__encoded_words.TestDecode) ... ok and so on Ran 1516 tests in 8.313s OK (skipped=1) 1 test OK. -- nosy: +francismb status: pending -> open ___ Python tracker <http://bugs.python.org/issue19626> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18288] Idle 2.7: Run Module does not set __file__
Francisco Martín Brugué added the comment: >From Idle editor window (F5): >>> Traceback (most recent call last): File "/home/ci/Prog/mypy/tem2.py", line 1, in print(__file__) NameError: name '__file__' is not defined >>> -- ___ Python tracker <http://bugs.python.org/issue18288> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18288] Idle 2.7: Run Module does not set __file__
Francisco Martín Brugué added the comment: On Debian: * Command line 2.7.3 ~/Prog/mypy$ python2.7 tem2.py tem2.py ~/Prog/mypy$ python2.7 -m tem2 /home/ci/Prog/mypy/tem2.py * IDLE 2.7.3 >>> print(__file__) Traceback (most recent call last): File "", line 1, in print(__file__) NameError: name '__file__' is not defined >>> >>> import tem2 tem2.pyc >>> -- nosy: +francismb ___ Python tracker <http://bugs.python.org/issue18288> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14264] Comparison bug in distutils2.version
Francisco Martín Brugué added the comment: What the status of this issue?: the changeset http://hg.python.org/distutils2/rev/1e0ca4594a2a mentioned in msg155480 seems to add tests (but it hasn't been add to the issue explicitly). Can the issue be closed? -- nosy: +francismb ___ Python tracker <http://bugs.python.org/issue14264> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7267] format method: c presentation type broken
Francisco Martín Brugué added the comment: Adding a test that triggers the issue, let me know if is enough. -- keywords: +patch Added file: http://bugs.python.org/file29554/issue7267.patch ___ Python tracker <http://bugs.python.org/issue7267> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7267] format method: c presentation type broken
Francisco Martín Brugué added the comment:
In 2.7.3 >>>
>>> u'{0:c}'.format(127)
u'\x7f'
>>> u'{0:c}'.format(128)
Traceback (most recent call last):
File "", line 1, in
u'{0:c}'.format(128)
UnicodeDecodeError: 'ascii' codec can't decode byte 0x80 in position 0: ordinal
not in range(128)
>>> u'{0:c}'.format(255)
Traceback (most recent call last):
File "", line 1, in
u'{0:c}'.format(255)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xff in position 0: ordinal
not in range(128)
>>> u'{0:c}'.format(256)
u'\x00'
>>> u'{0:c}'.format(257)
u'\x01'
--
nosy: +francismb
___
Python tracker
<http://bugs.python.org/issue7267>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13802] IDLE Prefernces/Fonts: use multiple alphabets in examples
Francisco Martín Brugué added the comment: Hi Terry, just take/put away some ... (they're not in a special order nor preference, just some that could 'see' in the browser). -- keywords: +patch nosy: +francismb Added file: http://bugs.python.org/file29553/issue13802.patch ___ Python tracker <http://bugs.python.org/issue13802> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15392] Create a unittest framework for IDLE
Changes by Francisco Martín Brugué : -- nosy: +francismb ___ Python tracker <http://bugs.python.org/issue15392> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17267] datetime.time support for '+' and 'now'
Francisco Martín Brugué added the comment: Hi Joar, just a detail: is there a reason for the asymmetric check for timedelta isinstance (and raising NotImplemented)? And BTW. isn't a double check for the __sub__ case (or have I missed something)? +def __add__(self, other): +"Add a time and a timedelta" +if not isinstance(other, timedelta): +return NotImplemented vs. … +def __sub__(self, other): +"Subtract a time and a timedelta." +if isinstance(other, timedelta): +return self + -other +return NotImplemented regards, francis -- nosy: +francismb ___ Python tracker <http://bugs.python.org/issue17267> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16098] Bisect optimization in heapq.nsmallest is never used
Francisco Martín Brugué added the comment: I've to say that I also ran into that by following coverage numbers and as a newbie is not so easy to see what Raymond told. IMHO that information could be put as a comment. Regards francis -- nosy: +francismb ___ Python tracker <http://bugs.python.org/issue16098> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13990] Benchmarks: 2to3 failures on the py3 side
Francisco Martín Brugué added the comment: > So the tests failed but the benchmarks finished without issue? Yes. But the apparent diff is that I've used 2.6.8 If the benchmarks run without errors then I'm satisfied, else we figure out what this fails ever or we have a already translated copy kept in a lib3 directory to prevent problems. The actual trunk revision for 2to3 from: https://svn.python.org/projects/sandbox/trunk/2to3/ is Revision 88981: /sandbox/trunk/2to3 the README.txt says: 2to3: r72994 from http://svn.python.org/projects/sandbox/trunk/2to3 I've just updated to that version but nothing changed: same errors (and a new test test_formfeed (lib2to3.tests.test_parser.TestDriver) that was ok) cheers, francis -- ___ Python tracker <http://bugs.python.org/issue13990> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13990] Benchmarks: 2to3 failures on the py3 side
Francisco Martín Brugué added the comment: The box is a debian (wheezy): ci@random:~/Prog/cpython/benchmarks/py2$ uname -a Linux random 3.2.0-3-amd64 #1 SMP Mon Jul 23 02:45:17 UTC 2012 x86_64 GNU/Linux The source repository dir: ci@random:~/Prog/cpython/benchmarks/py2$ dir lib LICENSE.txt make_perf3.sh performance perf.py perf.pyc README.txt test_perf.py Then: ci@random:~/Prog/cpython/benchmarks/py2$ cd .. ci@random:~/Prog/cpython/benchmarks$ mkdir benchmarks_py3k ci@random:~/Prog/cpython/benchmarks$ dir benchmarks_py3k py2 ci@random:~/Prog/cpython/benchmarks$ cd benchmarks_py3k/ ci@random:~/Prog/cpython/benchmarks/benchmarks_py3k$ ci@random:~/Prog/cpython/benchmarks/benchmarks_py3k$ /usr/bin/python2.6 -V Python 2.6.8 ci@random:~/Prog/cpython/benchmarks/benchmarks_py3k$ PYTHON=/usr/bin/python2.6 ../py2/make_perf3.sh ../py2 RefactoringTool: Skipping implicit fixer: buffer RefactoringTool: Skipping implicit fixer: idioms ... RefactoringTool: Warnings/messages while refactoring: RefactoringTool: ### In file lib/2to3/example.py ### RefactoringTool: Line 371: You should use a for loop here RefactoringTool: Line 372: You should use a for loop here RefactoringTool: Line 373: You should use a for loop here RefactoringTool: Line 374: You should use a for loop here RefactoringTool: Line 375: You should use a for loop here RefactoringTool: ### In file lib/2to3/example.py ### RefactoringTool: Line 393: You should use 'hasattr(foo, '__call__')' here. RefactoringTool: Line 394: You should use 'operator.contains(foo, bar)' here. RefactoringTool: Skipping implicit fixer: buffer ... RefactoringTool: lib/mako/test/templates/subdir/foo/modtest.html.py ci@random:~/Prog/cpython/benchmarks/benchmarks_py3k$ python3 -V Python 3.2.3 python3 perf.py -f -b 2to3 `which python3` `which python3` Running 2to3... INFO:root:Running /usr/bin/python3 lib/2to3/2to3 -f all lib/2to3/lib2to3/refactor.py INFO:root:Running `['/usr/bin/python3', 'lib/2to3/2to3', '-f', 'all', 'lib/2to3/lib2to3/refactor.py']` 1 time INFO:root:Running /usr/bin/python3 lib/2to3/2to3 -f all lib/2to3/lib2to3/refactor.py INFO:root:Running `['/usr/bin/python3', 'lib/2to3/2to3', '-f', 'all', 'lib/2to3/lib2to3/refactor.py']` 1 time Report on Linux random 3.2.0-3-amd64 #1 SMP Mon Jul 23 02:45:17 UTC 2012 x86_64 Total CPU cores: 4 ### 2to3 ### 0.616038 -> 0.624039: 1.01x slower And further: ci@random:~/Prog/cpython/benchmarks/benchmarks_py3k$ dir lib performance perf.py cd lib/2to3 ci@random:~/Prog/cpython/benchmarks/benchmarks_py3k/lib/2to3$ dir 2to3 example.py HACKING lib2to3 README scripts test.py ci@random:~/Prog/cpython/benchmarks/benchmarks_py3k/lib/2to3$ python3 test.py 2> testsResult2.txt -- Added file: http://bugs.python.org/file27184/testsResult2.txt ___ Python tracker <http://bugs.python.org/issue13990> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13990] Benchmarks: 2to3 failures on the py3 side
Francisco Martín Brugué added the comment: The actual tip for me is: ci@random:~/Prog/cpython/benchmarks/py2$ hg tip changeset: 164:61768f86170c tag: tip user:Brett Cannon date:Fri Aug 31 18:58:24 2012 -0400 summary: Allow for the specification of a base directory for either interpreter -- ___ Python tracker <http://bugs.python.org/issue13990> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13990] Benchmarks: 2to3 failures on the py3 side
Francisco Martín Brugué added the comment: Just info: I still can reproduce that. (It's maybe just something wrong with my setup?) -- Added file: http://bugs.python.org/file27183/testsResult.txt ___ Python tracker <http://bugs.python.org/issue13990> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5765] stack overflow evaluating eval("()" * 30000)
Francisco Martín Brugué added the comment: Just curiosity: how relate the magic numbers 10 and 2000 in test_compiler_recursion_limit to recursion_depth and recursion_limit Thanks! -- nosy: +francismb ___ Python tracker <http://bugs.python.org/issue5765> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14466] Rip out mq instructions
Francisco Martín Brugué added the comment: Just for the record: Thanks to the old mq workflow in the devguide I've learned about them and I'm now using it all the time to send and manage the patches. The only thing is that one should first use the “qqueue” functionality (see “hg help qqueue”) and then in a "qqueue" all the old devguide stuff (hg qdiff, hg qpush, hg qpop, and so on...). I agree that for a beginner the actual workflow maybe easier. -- nosy: +francismb ___ Python tracker <http://bugs.python.org/issue14466> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13579] string.Formatter doesn't understand the a conversion specifier
Francisco Martín Brugué added the comment: The patch is updated. Please let me know. And as Éric noticed the NEWS entry could be: Issue #13579: string.Formatter now understands the "a" conversion specifier. Thanks! -- Added file: http://bugs.python.org/file25425/issue13579_910a4b12c796.patch ___ Python tracker <http://bugs.python.org/issue13579> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13579] string.Formatter doesn't understand the !a conversion specifier
Francisco Martín Brugué added the comment: Ok, I've updated the patch. The NEWS entry could be: Issue #13579: string.Formatter now understands the !a conversion specifier. (not in the patch because AFAIN it makes the merge easier) Let me know if that's in the line you want. Thank you! -- Added file: http://bugs.python.org/file24909/issue13579_0554183066b5.patch ___ Python tracker <http://bugs.python.org/issue13579> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13579] string.Formatter doesn't understand the !a conversion specifier
Francisco Martín Brugué added the comment: > However, I have not actually applied and run test_string.py. I've applied the issue13579_4720cc9e.patch to the changeset 0554183066b5 and applies without errors for me. -- ___ Python tracker <http://bugs.python.org/issue13579> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14183] Test coverage for packaging.install and packaging.pypi.wrapper
Francisco Martín Brugué added the comment: I've updated the patch. Let me know if something has to be changed. -- Added file: http://bugs.python.org/file24727/issue14183_fbb9847b8f43.patch ___ Python tracker <http://bugs.python.org/issue14183> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14183] Test coverage for packaging.install and packaging.pypi.wrapper
Francisco Martín Brugué added the comment: Nadeem: > - Don't use spaces around the '=' sign when used to indicate a > keyword argument or a default parameter value. ok, "code formating" is not working as expected (at least for lambdas...) Éric : > If you grep packaging tests for XXX|TODO|FIXME, you’ll find 22 > entries. Fixing those may not have an impact on coverage numbers, > but will definitely improve things. > There are also XXX notes in the code itself, > open bugs on this tracker, and some dozen more in my todo lists. I've, at least one of your wishes under the radar: 14140 but right now I lack of the time for it and I prefer to get the open issues where I'm helping closed or rejected first (otherwise these is too much open “fronts” :) ). That one was just curiosity: I've tried with coverage against the whole stdlib and then sorted things in ascending coverage % order and took one: Lib/packaging/pypi/wrapper :) . After looking a bit I came to the default parameter of 'get_infos' ... Cheers, francis -- ___ Python tracker <http://bugs.python.org/issue14183> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14183] Test coverage for packaging.install and packaging.pypi.wrapper
Francisco Martín Brugué added the comment:
Hi Éric,
> - # Test that the isntalled raises an exception if the project does not
> + # Test that the installed raises an exception if the project does not
> It took me many seconds to find the change :)
The editor told me :)
>
> +def test_installation_get_infos_with_ClientWrapper(self):
> +# Test the use of get_infos default index
> Hm, I don’t like the method name, and don’t really understand from the
> comment what it is exactly that you’re testing (I’m not very familiar with
> p7g.pypi).
All the test with get_infos use the index=something. The default is for that
parameter is None. If that ocurrs than ClientWrapper will be used.
You're right, is not interesting here. May be a new name could be
test_installation_get_infos_with_default_index ... or what you wish :)
>
> -install.install_dists = lambda x, y=None: None
> +install.install_dists = lambda x, y = None: None
> PEP 8: Never put spaces in a function (or lambda) signature.
I cannot find that exactly in pep8. Are you saying is now OK or it was
OK? (if it was OK then the editor pep8 has a bug because that was
changed when saving)
> Let me remark that even if we get to 100% line coverage, or even 100%
> branch coverage, that won’t mean that we have covered everything.
I'm aware of that but it's a good exercise to learn something about the package.
> Two personal anecdotes to illustrate my point. In one project, I had > a
> branch covered but actually untested, because I used a ternary
> operator (something like “flags = 0 if case_sensitive else re.I”).
Pairwise Testing could help :) but of course getting all combinations tested
can be impossible.
> Another project was a Pylons web app; I had full coverage, and then I
> tried using non-ASCII and saw that my app was incomplete.
Well if "non-ASCII" was part of the specification then is a bug in the
implementation but if not then is a feature :P
> So I think that full code coverage is mainly useful in a new project,
> where you can have 100% all the time and use that metric to avoid
> adding code without sufficient tests. For a codebase like distutils2 > that’s
> half legacy, half new stuff, it’s harder to achieve that,
> and maybe less useful than working on other things.
> If you grep packaging tests for XXX|TODO|FIXME, you’ll find 22
> entries. Fixing those may not have an
> impact on coverage numbers, but will definitely improve things.
> There are also XXX notes in the code itself,
> open bugs on this tracker, and some dozen more in my todo lists. For >
> example, packaging.database is supposed to
> handle zipped eggs, but does it? I really appreciate your
> contributions, and think that you know enough of the code
> now to take on a larger bug if you want to. :)
>
Well I wanted to try with more line coverage (packging.run) and I got to a
point where I have to ask about (just adding another XXX and I prefer to ask
first before opening a bug): I'm getting 0 or None as return value for help
(and the behavior is different from the command
line or from subprocess and directly calling main).
-8<-8<-8<-8<-8<-
diff -r e67b3a9bd2dc Lib/packaging/tests/test_run.py
--- a/Lib/packaging/tests/test_run.py Sat Mar 03 02:38:37 2012 +0100
+++ b/Lib/packaging/tests/test_run.py Sat Mar 03 18:01:35 2012 +0100
@@ -2,6 +2,7 @@
import os
import sys
+import logging
from io import StringIO
from packaging import install
@@ -9,6 +10,7 @@
from packaging.run import main
from test.script_helper import assert_python_ok
+from test.support import captured_stdout, captured_stderr
# setup script that uses __file__
setup_using___file__ = """\
@@ -67,6 +69,16 @@
self.assertGreater(out, b'')
self.assertEqual(err, b'')
+# from main directly
+args = ('--help',)
+with captured_stdout() as out, captured_stderr() as err:
+status = main(args)
+self.assertGreater(out.getvalue(), '')
+self.assertEqual(err.getvalue(), '')
+# XXX shouldn't be 0 (no error) to be consistent with the above?
+# notice also that the all the messages are in stdout not error
+self.assertEqual(status, None)
+
def test_list_commands(self):
status, out, err = assert_python_ok('-m', 'packaging.run', 'run',
'--list-commands')
@@ -84,6 +96,23 @@
# TODO test that custom commands don't break --list-commands
+def test_no_commands(self):
+self.assertEqual(main(), 1)
+
+def test_no_existent_action(self):
+args = ('NO_EXISTENT',)
+self.asser
[issue14183] Test coverage for lib/packaging.install and lib/packaging/pypi/wrapper
Changes by Francisco Martín Brugué : -- type: -> enhancement ___ Python tracker <http://bugs.python.org/issue14183> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14183] Test coverage for lib/packaging.install and lib/packaging/pypi/wrapper
New submission from Francisco Martín Brugué : I've added a test to Lib/packaging/tests/test_install.py to increase the line test coverage of lib/packaging.install (and lib/packaging/pypi/wrapper indirectly from 14% to 80%). -- components: Tests files: packaging_get_infos_coverage_e67b3a9bd2dc.patch keywords: patch messages: 154839 nosy: francismb priority: normal severity: normal status: open title: Test coverage for lib/packaging.install and lib/packaging/pypi/wrapper versions: Python 3.3 Added file: http://bugs.python.org/file24720/packaging_get_infos_coverage_e67b3a9bd2dc.patch ___ Python tracker <http://bugs.python.org/issue14183> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12659] Add tests for packaging.tests.support
Francisco Martín Brugué added the comment: I've updated the patch with a test case for 'create_distribution' and one minor rename. I personally don't like too much the structure of 'LoggingCatcherTestCase' so improvements are welcome. Cheers, francis -- Added file: http://bugs.python.org/file24718/issue12659_e67b3a9bd2dc.patch ___ Python tracker <http://bugs.python.org/issue12659> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12659] Add tests for packaging.tests.support
Francisco Martín Brugué added the comment: > Patch looks good, thanks! BTW are you running a coverage tool to see > how > far along we are? Yes, always. The classes tested in that patch are at 100%. The overall coverage is: Name Stmts Miss Cover Missing --- Lib/packaging/tests/support 173 3480% 296-301, 306-310, 334-337, 341-347, 371-390, 395-396 -- ___ Python tracker <http://bugs.python.org/issue12659> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12659] Add tests for packaging.tests.support
Francisco Martín Brugué added the comment: Patch updated. BTW, I didn't get any email due the review that Éric did (does one has to be registered? I've done that now). -- Added file: http://bugs.python.org/file24689/issue12659_434cd2fedf81.patch ___ Python tracker <http://bugs.python.org/issue12659> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13447] Add tests for some scripts in Tools/scripts
Francisco Martín Brugué added the comment: Sorry, my fault: I meant "Test for Tools" instead of """Tests for reindent.py.""" (Im not talking about the skip message but the test documentation or the first line 0,0...) -- ___ Python tracker <http://bugs.python.org/issue13447> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13447] Add tests for some scripts in Tools/scripts
Francisco Martín Brugué added the comment: Hi Éric, some questions: 1)if test_tools is going to be the test for all the Tools (at least until it grows to much), shoudn't be be module doc something like “””Tests for scripts in Tools/**“”” 2)is the SkipTest “reindent” specific? Cheers, francis -- ___ Python tracker <http://bugs.python.org/issue13447> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14019] Unify tests for str.format and string.Formatter
Francisco Martín Brugué added the comment: I have some questions about this: 1) In Lib/test/string_tests.py it says: “Common tests shared by test_str, test_unicode, test_userstring and test_string” but a) I cannot find test_str b) string is imported and only some constants ascii_letters and digits are used c) In test_join there is a comment “see the test in test.test_string.StringTest.test_join” Is that obsolete? (I cannot find StringTest in the test_string test) 2) Is there more tests for the build in format (in test_buildin.BuiltinTest.test_format only the basic machinery is tested. I would expect something like in test_format.py somewhere 3) it is true that all tests for the build in 'format' should also pass in 'string.Formatter().format' Thanks in advance! francis -- ___ Python tracker <http://bugs.python.org/issue14019> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13447] Add tests for some scripts in Tools/scripts
Francisco Martín Brugué added the comment: > My only concern is communication: how do we tell people working on a tool > that they should write a test in test_tools? I’m not sure they would read > Tools/README; maybe a note at the top of the Python files would work; a note > in the devguide; sending an email to python-dev to tell about the new file + > reminders when we see a new tool bug opened. Patch patchcheck to "check" ;-) if some file in Tool/** has been touched and give a message accordingly (that happens already for NEWS and ACKS) … -- ___ Python tracker <http://bugs.python.org/issue13447> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14053] Make patchcheck work with MQ
Francisco Martín Brugué added the comment: Ok! I haven't added NEWS as I thing is easier for the person that applies the patch to simply write the line directly there instead of merging. Is that ok? let me know if something has to be improved. Thanks again for your mentoring this! -- Added file: http://bugs.python.org/file24592/issue14053_2cceb4d3079a.patch ___ Python tracker <http://bugs.python.org/issue14053> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14053] Make patchcheck work with MQ
Francisco Martín Brugué added the comment: Updated. Interesting: I saw that repetition but due “[…] Ideally, it should distinguish between this and other errors by checking the subprocess's stderr, so that if a different error occurs, we can still print out the error message. […]” I just wanted to keep cmd's separated first :-) Let me know what can be done … Cheers, francis -- Added file: http://bugs.python.org/file24585/issue14053_3297dcdad196.patch ___ Python tracker <http://bugs.python.org/issue14053> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13447] Add tests for some scripts in Tools/scripts
Francisco Martín Brugué added the comment: +1 while working on #issue14053 I missed the test for the scripts (in this case some kind of mocking is needed). -- ___ Python tracker <http://bugs.python.org/issue13447> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14053] Make Tools/scripts/patchcheck.py compatible with mercurial mqueues.
Francisco Martín Brugué added the comment: The patch is updated. Notice about: [...]Ideally, it should distinguish between this and other errors by checking the subprocess's stderr, so that if a different error occurs, we can still print out the error message. […] that should be improved as now stderr is ignored in 'mq_changed_files' (user case: 'no mq extension enabled'). Suggestions are welcome! > [..] but this is a bit orthogonal. IMHO the MQ feature works very well for pydev newbies (as I'm) and it's a good recommendation (it's a taste thing ...) > The easiest thing to do is to make some changes and use > "hg diff> patch.diff" and the devguide should advertise this IMHO. This > also works fine with `make patchcheck`. There is some small differences between diff, qdiff and status but if one uses MQ then diff isn't enough. One really wants to know the changes from qparent to qtip and using 'status' as proposed I thing that it's the best solution. Cheers, francis -- Added file: http://bugs.python.org/file24582/issue14053_1f9461ef6312.patch ___ Python tracker <http://bugs.python.org/issue14053> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14053] Make Tools/scripts/patchcheck.py compatible with mercurial mqueues.
Francisco Martín Brugué added the comment: Nice feedback ! One question : > >An alternative approach that solves all three of these problems is to >check whether we have any patches applied (using "hg qapplied"), and if >this is the case, then add "--rev qbase" to the "hg status" command >line. This will list all files added/modified by patches as well as by >uncommitted changes. > Shouldn't be --rev qparent ? with --rev qbase the first MQ patch applied changes are not listed ... (one wants the changes between qparent and qtip) -- title: Make patchcheck compatible with MQ -> Make Tools/scripts/patchcheck.py compatible with mercurial mqueues. ___ Python tracker <http://bugs.python.org/issue14053> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14053] Make Tools/scripts/patchcheck.py compatible with mercurial mqueues.
Francisco Martín Brugué added the comment: Here is a patch that works for me. Please check and review it. Thanks in advance! Francis -- keywords: +patch Added file: http://bugs.python.org/file24566/issue14053_336a614f35a3.patch ___ Python tracker <http://bugs.python.org/issue14053> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13579] string.Formatter doesn't understand the !a conversion specifier
Francisco Martín Brugué added the comment: Well, it's done: http://bugs.python.org/issue14053 -- ___ Python tracker <http://bugs.python.org/issue13579> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14053] Make Tools/scripts/patchcheck.py compatible with mercurial mqueues.
New submission from Francisco Martín Brugué :
The devguide (http://docs.python.org/devguide/patch.html) recommends the use of
the mercurial “mq” feature to work with patches and that works IMHO very well.
It also states that before sending the patch a sanity check should be done
('devguide: Preparation and Generation'). At this stage, if one has the patch
as tip (hg qapplied), the advice to run “pathcheck” doesn't help as no changes
are noticed.
The message is:
---
Modules/Setup.dist is newer than Modules/Setup;
check to make sure you have all the updates you
need in your Modules/Setup file.
Usually, copying Modules/Setup.dist to Modules/Setup will work.
---
./python ./Tools/scripts/patchcheck.py
Getting the list of files that have been added/changed ... 0 files
Fixing whitespace ... 0 files
Fixing C file whitespace ... 0 files
Fixing docs whitespace ... 0 files
Docs modified ... NO
Misc/ACKS updated ... NO
Misc/NEWS updated ... NO
The tool should check if some mq patches are applied (from “normal” tip to
“mqtip” and make it's checks there.
Thanks in advance !
Francis
--
components: Demos and Tools, Devguide
messages: 153703
nosy: ezio.melotti, francismb
priority: normal
severity: normal
status: open
title: Make Tools/scripts/patchcheck.py compatible with mercurial mqueues.
___
Python tracker
<http://bugs.python.org/issue14053>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13579] string.Formatter doesn't understand the !a conversion specifier
Francisco Martín Brugué added the comment: > I suspect mq will confuse make patchcheck (since it looks for > differences between the working copy and the hg branch tip, and there > are no such differences for an applied mq patch). Does it makes sense to open a feature request for that? -- ___ Python tracker <http://bugs.python.org/issue13579> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13579] string.Formatter doesn't understand the !a conversion specifier
Francisco Martín Brugué added the comment: Updated. The NEWS line is now at the top of the section. >As near as I can tell, the two change block beginning with >+In less formal terms, >[...] >are strictly re-wrapping and no text changes. Correct? Yes. Just a pydev question here: I now this re-wrapping adds noise to the patch, but can/should be done? Please correct me if I'm wrong: one should try to limit the line width to 80. If one word starts before and ends behind is not bad but new words should start in a new line. Now in the devguide states “To perform a quick sanity check on your path, you can run make patchcheck” I did that (I'm using the mq approach here) but I get no useful information (AFAIN): --- Modules/Setup.dist is newer than Modules/Setup; check to make sure you have all the updates you need in your Modules/Setup file. Usually, copying Modules/Setup.dist to Modules/Setup will work. --- ./python ./Tools/scripts/patchcheck.py Getting the list of files that have been added/changed ... 0 files Fixing whitespace ... 0 files Fixing C file whitespace ... 0 files Fixing docs whitespace ... 0 files Docs modified ... NO Misc/ACKS updated ... NO Misc/NEWS updated ... NO Thanks in advance ! -- Added file: http://bugs.python.org/file24555/issue13579_4720cc9e.patch ___ Python tracker <http://bugs.python.org/issue13579> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13579] string.Formatter doesn't understand the !a conversion specifier
Francisco Martín Brugué added the comment: I have updated the patch with the documentation changes proposed and also added a news entry (does a new entry has to be added in some order?). Thank for the review in advance. -- Added file: http://bugs.python.org/file24526/issue13579_a99632426af5.patch ___ Python tracker <http://bugs.python.org/issue13579> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14019] Unify tests for str.format and string.Formatter
Changes by Francisco Martín Brugué : -- nosy: +francismb ___ Python tracker <http://bugs.python.org/issue14019> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13579] string.Formatter doesn't understand the !a conversion specifier
Francisco Martín Brugué added the comment: Hi, here's a patch with the changes proposed by Terry Cheers, francis -- keywords: +patch nosy: +francismb Added file: http://bugs.python.org/file24512/issue13579_80a50b7ad88f.patch ___ Python tracker <http://bugs.python.org/issue13579> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13953] Get rid of doctests in packaging.tests.test_version
Francisco Martín Brugué added the comment: Does a "doc test" test the output literally? (I've just always used unittest) Ok, thanks -- ___ Python tracker <http://bugs.python.org/issue13953> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12659] Add tests for packaging.tests.support
Francisco Martín Brugué added the comment: On 02/11/2012 05:59 AM, Éric Araujo wrote: >> BTW: in distutils2 I get (not because of this change): > Actually I did fix that, but depending on your Python version the conditional > in the test may be wrong. What’s the Python version you used? I did: python2.7 runtests.py The exact version is: python2.7 -V --> Python 2.7.2+ and the machine is a Debian: uname -a --> Linux random 3.1.0-1-amd64 #1 SMP Tue Jan 10 05:01:58 UTC 2012 x86_64 GNU/Linux Thanks for your time as mentor! -- ___ Python tracker <http://bugs.python.org/issue12659> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13953] Get rid of doctests in packaging.tests.test_version
Francisco Martín Brugué added the comment: Thank you for the review. Just some questions: Isn't that what the previous code (doctest code) did? I thought that the code should be ported as far backwards as possible and that's why I used the plain assertEqual (I don't know exactly in with version the other assert methods were introduced. Unittest2?) Can one use all the new unittest2 methods to test packaging (distutils2) code? > -- > Added file: http://bugs.python.org/file24482/cleanup-test_version.diff > > ___ > Python tracker > <http://bugs.python.org/issue13953> > ___ > -- ___ Python tracker <http://bugs.python.org/issue13953> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13990] Benchmarks: 2to3 failures on the py3 side
New submission from Francisco Martín Brugué : Steps to reproduce: after following the usage instructions from make_perf3.sh go to the the py3 benchmarks directory and run the lib/2to3 tests (python3.2 test.py). The result are 3 failures and 17 errors. The equivalent procedure in the py2 benchmarks directory succeeds (python2.7 test.py). A summary is attached (the whole paste at http://pastebin.com/PAAhGsdR) Cheers, francis -- assignee: collinwinter components: 2to3 (2.x to 3.x conversion tool), Benchmarks files: FailuresErrors.txt messages: 153069 nosy: collinwinter, francismb priority: normal severity: normal status: open title: Benchmarks: 2to3 failures on the py3 side versions: Python 3.2 Added file: http://bugs.python.org/file24477/FailuresErrors.txt ___ Python tracker <http://bugs.python.org/issue13990> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13953] Get rid of doctests in packaging.tests.test_version
Francisco Martín Brugué added the comment: I've done some cleanups -- Added file: http://bugs.python.org/file24471/issue13953_bf6f306ad5cf.patch ___ Python tracker <http://bugs.python.org/issue13953> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13953] Get rid of doctests in packaging.tests.test_version
Francisco Martín Brugué added the comment: Hi here's a patch preview: it has to be re factored further but I stopped here as some tests failed: the out commented ones ... I've checked twice but I cannot see any diff, could you check that? Or, has maybe the behavior (due that bug) changed and nobody noticed? Thanks in advance ! Francis -- keywords: +patch Added file: http://bugs.python.org/file24459/issue13953_58bd6a58365d.patch ___ Python tracker <http://bugs.python.org/issue13953> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12659] Add tests for packaging.tests.support
Francisco Martín Brugué added the comment: > If so, could you provide a patch this time? Done. The patch is against default. what about against distutils2? Do you need also a patch for it? -- Added file: http://bugs.python.org/file24458/issue12659_58bd6a58365d.patch ___ Python tracker <http://bugs.python.org/issue12659> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13953] test_packaging: unused test?
Changes by Francisco Martín Brugué : -- nosy: +francismb ___ Python tracker <http://bugs.python.org/issue13953> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12659] Add tests for packaging.tests.support
Francisco Martín Brugué added the comment: I've just updated “test_support.py” and tested against 'default' and 'distutils2' (after changing the imports). Just let me know what has to be changed ... BTW: in distutils2 I get (not because of this change): == FAIL: test_bad_urls (distutils2.tests.test_pypi_simple.SimpleCrawlerTestCase) -- Traceback (most recent call last): File "/home/ci/prog/cpython/distutils2/distutils2/tests/pypi_server.py", line 68, in wrapped func(server=server, *args, **kwargs) File "/home/ci/prog/cpython/distutils2/distutils2/tests/test_pypi_simple.py", line 93, in test_bad_urls self.assertIn(wanted, str(v)) AssertionError: 'nonnumeric port' not found in 'Download error for http://http://svn.pythonpaste.org/Paste/wphp/trunk: [Errno -2] Name or service not known' -- Cheers, francis -- Added file: http://bugs.python.org/file24440/test_support_v2.py ___ Python tracker <http://bugs.python.org/issue12659> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12659] Add tests for packaging.tests.support
Francisco Martín Brugué added the comment: Hi Éric, I've mutated test_support.py a bit and now passes in https://bitbucket.org/tarek/distutils2 changeset:6c3d67ed3adb. I've added runTest to Tester, used os.unlink also removed the test fake_dec test as in support.py from distutils2 version is not present. Best regards, Francis -- Added file: http://bugs.python.org/file23687/test_support_v1.py ___ Python tracker <http://bugs.python.org/issue12659> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13193] test_packaging and test_distutils failures
Francisco Martín Brugué added the comment: > >> Where should be the distro? > > You won't find it in the hg repository - it gets created by the test, and > then deleted afterwards. Thanks for the info > >> The changeset was: >> $ hg tip >> changeset: 73075:d4839fea4a5a >> [...] > > That's not possible - these failures have been around for over a week now, > and that changeset was only committed yesterday. > Thanks again, next time I'll search the exact start point of failure in the repo. I've just put the ref to MY actual tip ;) -- ___ Python tracker <http://bugs.python.org/issue13193> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13193] test_packaging and test_distutils failures
Francisco Martín Brugué added the comment: The changeset was: $ hg tip changeset: 73075:d4839fea4a5a [...] -- ___ Python tracker <http://bugs.python.org/issue13193> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13193] test_packaging and test_distutils failures
Francisco Martín Brugué added the comment: Hi Eli, I cannot find the file/Distro: find / -name *'dist-info' 2> /dev/null /home/ci/cpython/Lib/packaging/tests/fake_dists/grammar-1.0a4.dist-info /home/ci/cpython/Lib/packaging/tests/fake_dists/towel_stuff-0.1.dist-info /home/ci/cpython/Lib/packaging/tests/fake_dists/babar-0.1.dist-info /home/ci/cpython/Lib/packaging/tests/fake_dists/choxie-2.0.0.9.dist-info /home/ci/cpython/.hg/store/data/_lib/packaging/tests/fake__dists/grammar-1.0a4.dist-info /home/ci/cpython/.hg/store/data/_lib/packaging/tests/fake__dists/babar-0.1.dist-info /home/ci/cpython/.hg/store/data/_lib/packaging/tests/fake__dists/towel__stuff-0.1.dist-info /home/ci/cpython/.hg/store/data/_lib/packaging/tests/fake__dists/choxie-2.0.0.9.dist-info Where should be the distro? Cheers, francis -- nosy: +francismb ___ Python tracker <http://bugs.python.org/issue13193> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12659] Add tests for packaging.tests.support
Francisco Martín Brugué added the comment: Hi Éric, Nice! and thanks for the info: I was just waiting to the check-in to compare and try further with the tests. Now I can just commit another patch by synching against the actual tip. Cheers, francis -- ___ Python tracker <http://bugs.python.org/issue12659> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12659] Add tests for packaging.tests.support
Francisco Martín Brugué added the comment: The patch is updated. Let me know if I've understood your review. Thanks ! -- Added file: http://bugs.python.org/file23370/issue12659_v3.patch ___ Python tracker <http://bugs.python.org/issue12659> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13117] Broken links in the “compiler” page, section “references” from the devguide.
Francisco Martín Brugué added the comment: A patch with the links mentioned above. -- keywords: +patch Added file: http://bugs.python.org/file23329/issue13117.patch ___ Python tracker <http://bugs.python.org/issue13117> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13117] Broken links in the “compiler” page, section “references” from the devguide.
Francisco Martín Brugué added the comment: The reference to [Wang97] could be changed to: http://www.cs.princeton.edu/research/techreps/TR-554-97 -- ___ Python tracker <http://bugs.python.org/issue13117> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13117] Broken links in the “compiler” page, section “references” from the devguide.
Francisco Martín Brugué added the comment: The reference for [1] could be changed to: http://www.python.org/workshops/1998-11/proceedings/papers/montanaro/montanaro.html -- ___ Python tracker <http://bugs.python.org/issue13117> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13117] Broken links in the “compiler” page, section “references” from the devguide.
New submission from Francisco Martín Brugué : Hi, In the page http://docs.python.org/devguide/compiler.html the links in the references [1] (http://www.foretec.com/python/workshops/1998-11/proceedings/papers/montanaro/montanaro.html) and in [Wang97] (http://www.cs.princeton.edu/%7Edanwang/Papers/dsl97/dsl97.html) are broken. Cheers, francis -- components: Devguide messages: 145030 nosy: francismb priority: normal severity: normal status: open title: Broken links in the “compiler” page, section “references” from the devguide. ___ Python tracker <http://bugs.python.org/issue13117> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12659] Add tests for packaging.tests.support
Francisco Martín Brugué added the comment: I've updated the patch. From your review: the class 'Mixin' is still there as the idea was to imitate the use of 'TempdirManager' as is used in the rest of the tests and test what it's documentation says. Just let me know your preferences here. Thank in advance ! -- Added file: http://bugs.python.org/file23116/issue12659_v2.patch ___ Python tracker <http://bugs.python.org/issue12659> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12659] Add tests for packaging.tests.support
Francisco Martín Brugué added the comment: Hi Éric, sorry but I've not received that email. Could you simply paste/send me the link (I've not used Rietveld already and I can not to find that review). Thanks ! -- ___ Python tracker <http://bugs.python.org/issue12659> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12659] Add tests for packaging.tests.support
Francisco Martín Brugué added the comment: I've started with test for “fake_dec” and “TempdirManager”. Please let me know if that in the line you want. Thanks in advance Francis -- keywords: +patch nosy: +francismb Added file: http://bugs.python.org/file22895/issue12659_v1.patch ___ Python tracker <http://bugs.python.org/issue12659> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2259] Poor support other than 44.1khz, 16bit audio files?
Francisco Martín Brugué added the comment: Adding a test that opens the 24b48k.aif file, gets some information and does navigation on it. I'm aware that it doesn't triggers any extra failure against the actual tip (5a1bb8d4afd7) but it does if r72100 is undone (with some small rework :)). I'm not sure if that is the kind of test needed (if not just ignore it). -- nosy: +francismb Added file: http://bugs.python.org/file22688/test_issue2259.patch ___ Python tracker <http://bugs.python.org/issue2259> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10206] python program starting with unmatched quote spews spaces to stdout
Francisco Martín Brugué added the comment:
On 06/24/2011 06:07 PM, R. David Murray wrote:
> self.assertRegex(err.decode('ascii', 'ignore'), 'SyntaxError')
I understand that's the standard way to check if a given failure
happened in the command line or there is also a helper for that case
(maybe something: assert_python_raises('-c', "'", SyntaxError))
Thanks !
Francisco
--
___
Python tracker
<http://bugs.python.org/issue10206>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10206] python program starting with unmatched quote spews spaces to stdout
Francisco Martín Brugué added the comment: Just attaching the review patch -- Added file: http://bugs.python.org/file22443/issue10206v2.patch ___ Python tracker <http://bugs.python.org/issue10206> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10206] python program starting with unmatched quote spews spaces to stdout
Francisco Martín Brugué added the comment:
I've attached an alternative test case.
I'm not sure if there is a more robust way to test:
self.assert_('SyntaxError' in err.decode('ascii', 'ignore'))
Due the use of 'SyntaxtError' directly as string. I would prefer something like
str(SyntaxtError) (or just the name of the exception
without extra text)
Review is welcome
--
nosy: +francismb
Added file: http://bugs.python.org/file22441/issue10206.patch
___
Python tracker
<http://bugs.python.org/issue10206>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12185] Decimal documentation lists "first" and "second" arguments, should be "self" and "other"
Francisco Martín Brugué added the comment: Hi Adam, I couldn’t see that from the threat context, I'm new to this and just wanted to learn the work flow and tools so I've just picked up an easy issue to start with. Anyway your patch seems more complete. -- ___ Python tracker <http://bugs.python.org/issue12185> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12185] Decimal documentation lists "first" and "second" arguments, should be "self" and "other"
Francisco Martín Brugué added the comment: Hi all, that is my first contribution. Please let me know if all it's OK. Thanks in advance ! -- keywords: +patch nosy: +francismb Added file: http://bugs.python.org/file8/issue_12185.patch ___ Python tracker <http://bugs.python.org/issue12185> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
