[issue46530] `'thread_time'` is missing from `test_get_clock_info`

2022-01-27 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset c27a33132be101e246ae2584f1826477357138d6 by Nikita Sobolev in branch 'main': bpo-46530: add `"thread_time"` to `test_time.test_get_clock_info` (#30913) https://github.com/python/cpython/commit/c27a33132be101e246ae2584f18264

[issue46553] typing: get_type_hints on stringified lone ClassVar raises TypeError

2022-01-27 Thread Guido van Rossum
Guido van Rossum added the comment: I To be clear: I am okay with this patch, just not with making dataclasses import typing. -- --Guido (mobile) -- ___ Python tracker <https://bugs.python.org/issue46

[issue46553] typing: get_type_hints on stringified lone ClassVar raises TypeError

2022-01-27 Thread Guido van Rossum
Guido van Rossum added the comment: Please just don't go there. I beg you. It's not worth it. -- ___ Python tracker <https://bugs.python.org/issue46553> ___ ___

[issue46552] typing: get_type_hints can't handle stringified annotations with leading spaces

2022-01-27 Thread Guido van Rossum
Change by Guido van Rossum : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46553] typing: get_type_hints on stringified lone ClassVar raises TypeError

2022-01-27 Thread Guido van Rossum
Guido van Rossum added the comment: It seems acceptable to mypy. I'm not sure I like the agenda of "moving dataclasses to using typing.py introspection tools". -- ___ Python tracker <https://bugs.python.o

[issue44791] Substitution of ParamSpec in Concatenate

2022-01-27 Thread Guido van Rossum
Guido van Rossum added the comment: Before you start supporting things that contradict PEP 612 this should be discussed on typing-sig (or in the python/typing tracker). Honestly I'd feel more comfortable if there was agreement on typing-sig with your previous PRs in this issue as well

[issue46552] typing: get_type_hints can't handle stringified annotations with leading spaces

2022-01-27 Thread Guido van Rossum
Guido van Rossum added the comment: We should not accept leading spaces.-- --Guido (mobile) -- ___ Python tracker <https://bugs.python.org/issue46552> ___ ___

[issue46539] typing: forward references don't understand special type forms

2022-01-26 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset ced50051bb752a7c1e616f4b0c001f37f0354f32 by Gregory Beauregard in branch 'main': bpo-46539: Pass status of special typeforms to forward references (GH-30926) https://github.com/python/cpython/commit/ced50051bb752a7c1e616f4b0c001f37f0354f32

[issue46539] typing: forward references don't understand special type forms

2022-01-26 Thread Guido van Rossum
Guido van Rossum added the comment: Agree it's not the same issue, but there's similarity -- both are due to putting a stringized annotation (presumably a forward ref) somewhere inside another construct. whether it's list["N"] or Annotated[&qu

[issue46539] typing: forward references don't understand special type forms

2022-01-26 Thread Guido van Rossum
Guido van Rossum added the comment: I wonder if this is at all similar to bpo-41370. -- ___ Python tracker <https://bugs.python.org/issue46539> ___ ___ Pytho

[issue43853] [sqlite3] Improve sqlite3_value_text() error handling

2022-01-26 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 3eb3b4f270757f66c7fb6dcf5afa416ee1582a4b by Erlend Egeberg Aasland in branch 'main': bpo-43853: Expand test suite for SQLite UDF's (GH-27642) https://github.com/python/cpython/commit/3eb3b4f270757f66c7fb6dcf5afa416ee1582a4b -- nosy

[issue46491] typing: allow Annotated in outermost scope

2022-01-25 Thread Guido van Rossum
Guido van Rossum added the comment: Yeah, there are no perfect solutions. Please let it go. -- ___ Python tracker <https://bugs.python.org/issue46491> ___ ___

[issue46491] typing: allow Annotated in outermost scope

2022-01-25 Thread Guido van Rossum
Guido van Rossum added the comment: Well that's *always* a problem right? If you take that to the extreme we wouldn't need bugfix releases. :-) Apart from some examples in the 3.5-3.6 timeframe, what makes you think that *this* fix *specifically* is going to make more people unhappy than

[issue46491] typing: allow Annotated in outermost scope

2022-01-25 Thread Guido van Rossum
Guido van Rossum added the comment: But it *is* a bugfix. -- ___ Python tracker <https://bugs.python.org/issue46491> ___ ___ Python-bugs-list mailing list Unsub

[issue41370] PEP 585 and ForwardRef

2022-01-25 Thread Guido van Rossum
Guido van Rossum added the comment: Here's a patch that doesn't do it right but illustrates the point: diff --git a/Lib/typing.py b/Lib/typing.py index 972b8ba24b..4616db60c3 100644 --- a/Lib/typing.py +++ b/Lib/typing.py @@ -1807,6 +1807,12 @@ def get_type_hints(obj, globalns=None, localns

[issue41370] PEP 585 and ForwardRef

2022-01-25 Thread Guido van Rossum
Guido van Rossum added the comment: Ah, I see the issue. I stepped through get_type_hints() using pdb, and it does have a special case for when it encounters a string: it wraps it in a ForwardRef and proceeds from there: https://github.com/python/cpython/blob

[issue41370] PEP 585 and ForwardRef

2022-01-25 Thread Guido van Rossum
Guido van Rossum added the comment: When PEP 585 was discussed and implemented we did not expect people to care as much about runtime types as they did. I already explained that making list['Node'] incorporate a ForwardRef instance is unrealistic (we'd have to reimplement ForwardRef in C

[issue41370] PEP 585 and ForwardRef

2022-01-25 Thread Guido van Rossum
Guido van Rossum added the comment: I asked for a brief example that explains your issue to me. Instead you sent me links to production code and patches to it. Sorry, but that doesn't help me understand your problem. Is there really no way that you can write a little story that goes along

[issue33125] Windows 10 ARM64 platform support

2022-01-25 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: -Guido.van.Rossum ___ Python tracker <https://bugs.python.org/issue33125> ___ ___ Python-bugs-list mailing list Unsub

[issue46519] test_typing failing on branch 3.10

2022-01-25 Thread Guido van Rossum
Guido van Rossum added the comment: Exactly what I just thought. A bit more research might find a buggy assumption in the test "framework". -- nosy: +gvanrossum ___ Python tracker <https://bugs.python.o

[issue46396] `Concatenate` should not raise any semantic errors

2022-01-25 Thread Guido van Rossum
Guido van Rossum added the comment: No, that would make the behavior normative. Let sleeping dogs lie. -- resolution: -> wont fix stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

2022-01-24 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker <https://bugs.python.org/issue46483> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46449] Deep-freezed modules create inconsistency in sys.gettotalrefcount() (_Py_Reftotal)

2022-01-24 Thread Guido van Rossum
Guido van Rossum added the comment: I tried to make the 'FROZEN' variable in freeze_modules.py empty, but it has a bunch of places where this is unexpected. Maybe someone can fix that? -- ___ Python tracker <https://bugs.python.org/issue46

[issue46431] Trouble subclassing ExceptionGroup

2022-01-24 Thread Guido van Rossum
Guido van Rossum added the comment: So, a PR with that fix would be nice? -- ___ Python tracker <https://bugs.python.org/issue46431> ___ ___ Python-bugs-list m

[issue46396] `Concatenate` should not raise any semantic errors

2022-01-24 Thread Guido van Rossum
Guido van Rossum added the comment: "When in doubt, the status quo wins." Maybe we should just close this and the PR without merging. -- ___ Python tracker <https://bugs.python.o

[issue46494] Mention typing_extensions in the typing documentation

2022-01-24 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker <https://bugs.python.org/issue46494> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46476] Not all memory allocated by _Py_Quicken() is released at Python exit

2022-01-23 Thread Guido van Rossum
Guido van Rossum added the comment: > With the current design, it isn't possible though because the code objects > are modified in place so if co_quickened is freed the VM still tries to > execute the copied instructions. Or the cleanup code could also restore co_firstinstr and oth

[issue46471] use global singletons for single byte bytes objects in deepfreeze

2022-01-23 Thread Guido van Rossum
Change by Guido van Rossum : -- resolution: -> fixed stage: patch review -> resolved status: pending -> closed ___ Python tracker <https://bugs.python.or

[issue46449] Deep-freezed modules create inconsistency in sys.gettotalrefcount() (_Py_Reftotal)

2022-01-23 Thread Guido van Rossum
Guido van Rossum added the comment: @Kumar do you want to tackle this? -- nosy: +kumaraditya303 ___ Python tracker <https://bugs.python.org/issue46449> ___ ___

[issue46491] typing: allow Annotated in outermost scope

2022-01-23 Thread Guido van Rossum
Guido van Rossum added the comment: +1-- --Guido (mobile) -- ___ Python tracker <https://bugs.python.org/issue46491> ___ ___ Python-bugs-list mailing list Unsub

[issue46471] use global singletons for single byte bytes objects in deepfreeze

2022-01-23 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset ca78130d7eb5265759697639e42487ec6d0a4caf by Kumar Aditya in branch 'main': bpo-46471: Use single byte singletons (GH-30781) https://github.com/python/cpython/commit/ca78130d7eb5265759697639e42487ec6d0a4caf

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-23 Thread Guido van Rossum
Guido van Rossum added the comment: I'm wondering if the test is faulty. It seems to call EventLoop.sendfile() with a file that is 8K + 1 byte long, and the protocol is instructed to close after 1K bytes have been written, but it seems to try to send as much of the file as it can. Could

[issue44642] Union of a type and the typing module function

2022-01-22 Thread Guido van Rossum
Guido van Rossum added the comment: Do you recommend to just close this as "fixed"? -- ___ Python tracker <https://bugs.python.org/issue44642> ___ ___

[issue46476] Not all memory allocated by _Py_Quicken() is released at Python exit

2022-01-22 Thread Guido van Rossum
Guido van Rossum added the comment: > Would it be possible to enhance deepfreeze be produce a list of all > (immortal) code objects? That should be simple. We could see if Kumar is interested. -- nosy: +kumaraditya303 ___ Python tracker

[issue46449] Deep-freezed modules create inconsistency in sys.gettotalrefcount() (_Py_Reftotal)

2022-01-22 Thread Guido van Rossum
Guido van Rossum added the comment: > Is there a way to disable deepfreeze when building Python? It looks like this isn't easy, sorry. :-( Adding Christian Heimes in case he has a suggestion. -- nosy: +christian.heimes ___ Python tracker <

[issue46476] Not all memory allocated by _Py_Quicken() is released at Python exit

2022-01-22 Thread Guido van Rossum
Guido van Rossum added the comment: If any of the immortal, deep-frozen code objects is ever quickened, I suppose the quickening data is never freed. But when we finalize and reinitialize, the co_quickened flag should remain set, so this would be a one-time leak. The question is whether

[issue46431] Trouble subclassing ExceptionGroup

2022-01-22 Thread Guido van Rossum
Guido van Rossum added the comment: Is this a matter of adding some documentation showing how it should be done? Even if we don't want to encourage such subclassing, we do have APIs to support it, and I think we ought to show how to do it, given that you have to coordinate a bunch of things

[issue46465] test_unittest: TestBreakSignalDefault.testInstallHandler() fails if run after TestBreak

2022-01-22 Thread Guido van Rossum
Guido van Rossum added the comment: @kj, are you looking into this? -- ___ Python tracker <https://bugs.python.org/issue46465> ___ ___ Python-bugs-list mailin

[issue43118] inspect.signature() raises RuntimeError on failed to resolve the default argument value

2022-01-22 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 83aef4d34022f293336f606dba8598cc7ac8f9f2 by Miss Islington (bot) in branch '3.10': bpo-43118: Fix bug in inspect.signature around 'base.__text_signature__' (GH-30285) (#30765) https://github.com/python/cpython/commit

[issue46419] Incomplete Comparison to C++ Methods

2022-01-21 Thread Guido van Rossum
Guido van Rossum added the comment: You appear more interested in a discussion of Python semantics than in improving the tutorial. I see nothing actionable here. -- resolution: -> wont fix stage: -> resolved status: open -> closed _

[issue46445] Multiple inheritance of TypedDict is not covered in `test_typing`

2022-01-21 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 65b88d5e01c845c0cfa3ff61bc8b2faec8f67a57 by Nikita Sobolev in branch 'main': bpo-46445: Cover multiple inheritance of `TypedDict` in `test_typing` (GH-30719) https://github.com/python/cpython/commit/65b88d5e01c845c0cfa3ff61bc8b2faec8f67a57

[issue46396] Typing: test invalid usages of `Concatenate`

2022-01-21 Thread Guido van Rossum
Guido van Rossum added the comment: Arguably the runtime should not check for incorrect calls to Concatenate. That's the job of static type checkers. So maybe that code could just be removed? (We don't bother checking things like list[0] either

[issue43118] inspect.signature() raises RuntimeError on failed to resolve the default argument value

2022-01-21 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 881a763cfe07ef4a5806ec78f13a9bc99e8909dc by Weipeng Hong in branch 'main': bpo-43118: Fix bug in inspect.signature around 'base.__text_signature__' (GH-30285) https://github.com/python/cpython/commit/881a763cfe07ef4a5806ec78f13a9bc99e8909dc

[issue46419] Incomplete Comparison to C++ Methods

2022-01-21 Thread Guido van Rossum
Guido van Rossum added the comment: Just because __init__ is extra weird doesn't mean that other methods aren't roughly like C++. But I can't find the text the OP refers to. Without a specific pointer (at least a URL and quoted text) this issue is non-actionable and should probably

[issue44975] [typing] Runtime protocols with ClassVar data members should support issubclass

2022-01-21 Thread Guido van Rossum
Guido van Rossum added the comment: IMO we shouldn't update PEP 544. PEPs reflect the historical proposal, they are not documentation for the current state of the interpreter. -- ___ Python tracker <https://bugs.python.org/issue44

[issue46449] Deep-freezed modules create inconsistency in sys.gettotalrefcount() (_Py_Reftotal)

2022-01-21 Thread Guido van Rossum
Guido van Rossum added the comment: I was hoping @eric.snow could tell me. -- ___ Python tracker <https://bugs.python.org/issue46449> ___ ___ Python-bugs-list m

[issue46449] Deep-freezed modules create inconsistency in sys.gettotalrefcount() (_Py_Reftotal)

2022-01-20 Thread Guido van Rossum
Guido van Rossum added the comment: Hm, the deep-frozen objects are statically initialized with a very large refcount that isn't accounted for (they are intended to be immortal). It seems that Py_Finalize() somehow decrefs those objects. I guess this means we need some kind of flag

[issue46399] Addition of `mapping` attribute to dict views classes has inadvertently broken type-checkers

2022-01-20 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker <https://bugs.python.org/issue46399> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46429] Merge all deepfrozen files into one

2022-01-20 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset ef3ef6fa43d5cca072eed2a66064e818de583be7 by Kumar Aditya in branch 'main': bpo-46429: Merge all deepfrozen files into one (GH-30572) https://github.com/python/cpython/commit/ef3ef6fa43d5cca072eed2a66064e818de583be7

[issue46441] Caret points to wrong line on 'return yield 42' in REPL

2022-01-20 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks for the quick fix! -- ___ Python tracker <https://bugs.python.org/issue46441> ___ ___ Python-bugs-list mailin

[issue46443] Deepfreeze use preallocated small ints

2022-01-19 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 194ecc6d44adc1fb39a56ca696418368b69432ce by Kumar Aditya in branch 'main': bpo-46443: deepfreeze: use small ints and singleton zero bytes (GH-30715) https://github.com/python/cpython/commit/194ecc6d44adc1fb39a56ca696418368b69432ce

[issue46441] Caret points to wrong line on 'return yield 42' in REPL

2022-01-19 Thread Guido van Rossum
New submission from Guido van Rossum : This seems to happen in 3.11 in the REPL only. >>> def f(): ... print(0) ... return yield 42 File "", line 3 def f(): ^ SyntaxError: invalid syntax Note that running it from a file gives the expected output: PS

[issue46437] Non-required `hasattr` checks in `test_typing`

2022-01-19 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 263c0dd16017613c5ea2fbfc270be4de2b41b5ad by Nikita Sobolev in branch 'main': bpo-46437: remove useless `hasattr` from `test_typing` (#30704) https://github.com/python/cpython/commit/263c0dd16017613c5ea2fbfc270be4de2b41b5ad -- nosy

[issue46399] Addition of `mapping` attribute to dict views classes has inadvertently broken type-checkers

2022-01-19 Thread Guido van Rossum
Guido van Rossum added the comment: Given all this discussion I defer to Serhiy and Inada-San. On Wed, Jan 19, 2022 at 02:23 Serhiy Storchaka wrote: > > Serhiy Storchaka added the comment: > > I share concerns of Inada-san. I also think that keeping a status quo > (ignor

[issue46429] Merge all deepfrozen files into one

2022-01-18 Thread Guido van Rossum
New submission from Guido van Rossum : This saves some space when strings are shared across deep-frozen module. Kumar measured this at around 0.2 Mbyte. See discussion https://github.com/faster-cpython/ideas/issues/218 -- ___ Python tracker <ht

[issue46399] Addition of `mapping` attribute to dict views classes has inadvertently broken type-checkers

2022-01-17 Thread Guido van Rossum
Guido van Rossum added the comment: Probably. On Mon, Jan 17, 2022 at 02:14 Alex Waygood wrote: > > Alex Waygood added the comment: > > Do these changes warrant an entry in "What's New in 3.11"? > > -- > >

[issue12782] Multiple context expressions do not support parentheses for continuation across lines

2022-01-16 Thread Guido van Rossum
Guido van Rossum added the comment: [Meta: Why did adding a comment add all those people (back?) to the nosy list?] -- ___ Python tracker <https://bugs.python.org/issue12

[issue46399] Addition of `mapping` attribute to dict views classes has inadvertently broken type-checkers

2022-01-16 Thread Guido van Rossum
Guido van Rossum added the comment: Okay, PR welcome. (Though since this can only work for 3.11+, maybe typeshed could also be adjusted? For that you’d have to file a bug there.) -- ___ Python tracker <https://bugs.python.org/issue46

[issue46345] Add an explicit test for `get_type_hints` for a class field with `None` default

2022-01-12 Thread Guido van Rossum
Guido van Rossum added the comment: Wasn’t the fix for it also backported? (Weird that the test wasn’t part of the fix.) -- ___ Python tracker <https://bugs.python.org/issue46

[issue46345] Add an explicit test for `get_type_hints` for a class field with `None` default

2022-01-12 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 1de60155d5d01be2924e72fb68dd13d4fd00acd7 by Nikita Sobolev in branch 'main': bpo-46345: Add a test case for implicit `Optional` class attribute (GH-30535) https://github.com/python/cpython/commit/1de60155d5d01be2924e72fb68dd13d4fd00acd7

[issue46342] Make @final introspectable at runtime

2022-01-12 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset 0bbf30e2b910bc9c5899134ae9d73a8df968da35 by Jelle Zijlstra in branch 'main': bpo-46342: make @typing.final introspectable (GH-30530) https://github.com/python/cpython/commit/0bbf30e2b910bc9c5899134ae9d73a8df968da35

[issue46348] Modernize `test_typing`

2022-01-12 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset e2a9c8ef09cb7123d6b28852a323e6cc1f878b5b by Nikita Sobolev in branch 'main': bpo-46348: modernize `test_typing` (GH-30547) https://github.com/python/cpython/commit/e2a9c8ef09cb7123d6b28852a323e6cc1f878b5b

[issue46303] _Py_stat and _Py_wstat using incorrect type for status argument

2022-01-11 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: +gvanrossum ___ Python tracker <https://bugs.python.org/issue46303> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46346] New compilation warnings on Windows

2022-01-11 Thread Guido van Rossum
New submission from Guido van Rossum : I am getting these warnings: C:\Users\gvanrossum\cpython\PC\_testconsole.c(70,38): warning C4013: '_Py_get_osfhandle' undefined; assuming extern returnin g int [C:\Users\gvanrossum\cpython\PCbuild\_testconsole.vcxproj] C:\Users\gvanrossum\cpython\PC

[issue46244] typing._TypeVarLike missing __slots__

2022-01-10 Thread Guido van Rossum
Guido van Rossum added the comment: Yes.-- --Guido (mobile) -- ___ Python tracker <https://bugs.python.org/issue46244> ___ ___ Python-bugs-list mailin

[issue41987] singledispatchmethod raises an error when relying on a forward declaration

2022-01-10 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks for the bisection. It's not surprising that that's the culprit, and in other situations that's the right thing to do. I'm not sure how to address this without breaking other stuff -- maybe leave the ForwardRef if evaluating it doesn't work

[issue46162] Make `builtins.property` generic

2022-01-10 Thread Guido van Rossum
Guido van Rossum added the comment: Since the conclusion is that we can't do this without breaking backwards compatibility, should we just close this? Or is there still a compromise possible? -- ___ Python tracker <https://bugs.python.

[issue46333] ForwardRef.__eq__ does not respect module parameter

2022-01-10 Thread Guido van Rossum
Guido van Rossum added the comment: Good catch. Do you want to submit a PR? I agree that the repr() could also be better (but please only show other values if they differ from the default). -- versions: +Python 3.11 ___ Python tracker <ht

[issue46333] ForwardRef.__eq__ does not respect module parameter

2022-01-10 Thread Guido van Rossum
Change by Guido van Rossum : -- stage: -> needs patch ___ Python tracker <https://bugs.python.org/issue46333> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-08 Thread Guido van Rossum
Guido van Rossum added the comment: Yup. All better: https://speed.python.org/timeline/#/?exe=12=python_startup=1=50=off=on=on -- ___ Python tracker <https://bugs.python.org/issue46

[issue46148] Optimize pathlib

2022-01-08 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker <https://bugs.python.org/issue46148> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-08 Thread Guido van Rossum
Guido van Rossum added the comment: To close the loop, setuptools 60.4.0 should fix this, see https://github.com/pypa/setuptools/pull/3009. -- ___ Python tracker <https://bugs.python.org/issue46

[issue45661] [meta] Freeze commonly used stdlib modules.

2022-01-07 Thread Guido van Rossum
Guido van Rossum added the comment: Deep-freezing is definitely not a miracle cure. We should continue to trim or delay unneeded imports (like Christian just did for setuptools' _distutils_hack). What *would* be a miracle cure would be if we could deep-freeze the module contents after

[issue41370] PEP 585 and ForwardRef

2022-01-07 Thread Guido van Rossum
Guido van Rossum added the comment: Niklas, can you show a brief example showing the issue you're running into? Is it just that list["Node"].__args__ is just ("Node",), not (ForwardRef("Node"),)? Or is it more complex? --

[issue46263] FreeBSD buildbots cannot compile Python

2022-01-06 Thread Guido van Rossum
Guido van Rossum added the comment: IIUC Steve is still on vacation, so we shouldn't wait for him to fix this. -- ___ Python tracker <https://bugs.python.org/issue46

[issue46263] FreeBSD buildbots cannot compile Python

2022-01-06 Thread Guido van Rossum
Guido van Rossum added the comment: Is this under control, or do you still need help with some part? (Are there two separate issues or not?)-- --Guido (mobile) -- ___ Python tracker <https://bugs.python.org/issue46

[issue46263] FreeBSD buildbots cannot compile Python

2022-01-04 Thread Guido van Rossum
Change by Guido van Rossum : -- title: FreeBSL buiildbots cannot compile Python -> FreeBSD buildbots cannot compile Python ___ Python tracker <https://bugs.python.org/issu

[issue45665] Problems caused by isinstance(list[int], type) returning True

2022-01-04 Thread Guido van Rossum
Guido van Rossum added the comment: I now agree with Serhiy's plan. We should execute ASAP so people get a chance to try this in the next alpha release. We will still allow instantiating e.g. list[int], right? -- ___ Python tracker <ht

[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-04 Thread Guido van Rossum
Guido van Rossum added the comment: More data. On my Mac, with SETUPTOOLS_USE_DISTUTILS=stdlib, using -X importtime I see the following extra modules being imported: import time: 278 |278 | types import time: 112 |112 | _operator import time

[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-04 Thread Guido van Rossum
Guido van Rossum added the comment: I'm still wondering why speed.python.org showed such a slowdown, and how we can revert that. Here's a new theory. Thanks to an investigation I did together with Eric, I now suspect that the release of setuptools 60.0.0 on Dec 19 is a smoking gun

[issue45665] Problems caused by isinstance(list[int], type) returning True

2022-01-04 Thread Guido van Rossum
Guido van Rossum added the comment: Okay, so it is probably here to stay. We could justify it (after the fact :-) by saying that you can instantiate list[int], but not Any. Are there exceptions to that? (I.e. are there other annotation types that have isinstance(X, type) return False

[issue45665] Problems caused by isinstance(list[int], type) returning True

2022-01-04 Thread Guido van Rossum
Guido van Rossum added the comment: So is it too late to change this? This went out with 3.10, Serhiy has argued it's a bugfix. -- ___ Python tracker <https://bugs.python.org/issue45

[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-03 Thread Guido van Rossum
Guido van Rossum added the comment: "is very very unlike that there is no actual regression" I presume you meant "it is very very *likely* that there is no actual regression" This shouldn't hold up releases, but (having spent months trying to improve startup speed

[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-03 Thread Guido van Rossum
Guido van Rossum added the comment: I wrote a tiny script that calls compile() on raw bytes read from some source file, does this 100 times, and reports the total time. I tested the script with Lib/pydoc_data/topics.py (which happens to be the largest source file in the CPython repo

[issue46244] typing._TypeVarLike missing __slots__

2022-01-03 Thread Guido van Rossum
Guido van Rossum added the comment: Confirmed about _TypeVarLike. Go ahead and make a PR. Do add a news blurb when requested. Please open separate issues for other such classes, each fix may need to be reviewed by a different expert

[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-03 Thread Guido van Rossum
Guido van Rossum added the comment: I propose a test: revert the PR and see if speed.Python.org shows a speedup back to the previous number.-- --Guido (mobile) -- ___ Python tracker <https://bugs.python.org/issue46

[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-02 Thread Guido van Rossum
Guido van Rossum added the comment: Maybe something unrelated changed on the benchmark machines? (Like installing a new version of pyperformance???) Though it happened across both benchmark machines. What configuration and flags are being used to run the benchmark suite on that machine

[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-02 Thread Guido van Rossum
Guido van Rossum added the comment: Maybe it's Linux specific? I managed to run pyperformance and got this: ### python_startup ### Mean +- std dev: 23.2 ms +- 0.8 ms -> 23.4 ms +- 1.2 ms: 1.01x slower Not significant Note, I am not dismissing the report -- in fact it looks quite bad. Bu

[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-02 Thread Guido van Rossum
Guido van Rossum added the comment: So if I understand the speed.python.org results correctly, the time to run `python -c pass` went way up, but the time for `python -S -c pass` did not go up significantly. Unfortunately the only machine I have access to is a Mac, and I cannot repro

[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-02 Thread Guido van Rossum
Guido van Rossum added the comment: Let me have a look. May take a day, okay?-- --Guido (mobile) -- ___ Python tracker <https://bugs.python.org/issue46

[issue44394] [security] CVE-2013-0340 "Billion Laughs" fixed in Expat >=2.4.0: Update vendored copy to expat 2.4.1

2022-01-01 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker <https://bugs.python.org/issue44394> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46195] Annotated and Optional get_type_hints buggy interaction

2021-12-30 Thread Guido van Rossum
Guido van Rossum added the comment: Yes, we changed PEP 484 in https://github.com/python/peps/pull/689. So get_type_hints() should follow suit. -- ___ Python tracker <https://bugs.python.org/issue46

[issue46191] Conflict between using annotations in singledispatch() and MyPy

2021-12-29 Thread Guido van Rossum
Guido van Rossum added the comment: If we allow registering list[int] but give it the same meaning as registering plain list (at runtime), that would violate user expectations pretty strongly -- for the same reason why we don't allow isinstance(x, list[int]). If you want stronger checking

[issue46195] Annotated and Optional get_type_hints buggy interaction

2021-12-29 Thread Guido van Rossum
Guido van Rossum added the comment: Could you try with 3.10 and the stdlib typing.Annotated please? There might be changes (in the past a default of None automatically caused an Optional to be added, but we changed our minds.-- --Guido (mobile

[issue34498] Python 3.7+ break on singledispatch_function.register(pseudo_type), which Python 3.6 accepted

2021-12-29 Thread Guido van Rossum
Guido van Rossum added the comment: Let's close this issue as "won't fix" then. The solution "use collections.abc.Sequence" makes sense. -- ___ Python tracker <https://bug

[issue46191] Conflict between using annotations in singledispatch() and MyPy

2021-12-29 Thread Guido van Rossum
Guido van Rossum added the comment: That mypy error is only reported with a certain mypy setting (--strict, or probably one of the specific settings that that turns on). We won't be supporting Sequence[Any] at runtime (because we only support actual types), but we should support Sequence

[issue34498] Python 3.7+ break on singledispatch_function.register(pseudo_type), which Python 3.6 accepted

2021-12-28 Thread Guido van Rossum
Guido van Rossum added the comment: There's no point in lamenting the compatibility with Python 3.6, it's water under the bridge. Dispatching on types like list[int] or types generated by NewType is not realistic. Maybe the only thing left to do is to raise an error on registration when

[issue46170] Improving the error message when subclassing NewType

2021-12-26 Thread Guido van Rossum
Guido van Rossum added the comment: Weird, the docs you cite claims # Also does not typecheck ProUserId = NewType('ProUserId', UserId) but when I try it, it works at runtime and passes mypy (even with --strict) and also pyright. So maybe those docs are incorrect? I can't find

[issue46170] Improving the error message when subclassing NewType

2021-12-26 Thread Guido van Rossum
Guido van Rossum added the comment: Do you have evidence that people make this particular mistake often? And that the suggested solution is indeed what they should use? Why would you want to subclass UserId? Do we have examples of other error messages split across two lines like

[issue45665] Problems caused by isinstance(list[int], type) returning True

2021-12-24 Thread Guido van Rossum
Guido van Rossum added the comment: See https://github.com/python/mypy/issues/9773#issuecomment-1000975000. I may have talked myself into agreeing with Serhiy there! It does seem inconsistent that Any is not considered a type but list[int] is: >>> isinstance(list[int], type) True &

  1   2   3   4   5   6   7   8   9   10   >