[issue21571] Python build should check CPATH, C_INCLUDE_PATH for module dependencies

2014-07-03 Thread Jan Kanis
Jan Kanis added the comment: I can write a patch. I haven't signed a contributor agreement but I have no problem doing so. I am not sure when I will have time to write a patch though, so it could take some time. -- ___ Python tracker rep

[issue21910] File protocol should document if writelines must handle generators sensibly

2014-07-03 Thread Jan Kanis
New submission from Jan Kanis: The resolution of issue 5445 should be documented somewhere properly, so people can depend on it or not. IOBase.writelines handles generator arguments without problems, i.e. without first draining the entire generator and then writing the result in one go

[issue18141] tkinter.Image.__del__ can throw an exception if module globals are destroyed in the wrong order

2014-06-08 Thread Jan Kanis
Jan Kanis added the comment: I tested 2.7 tip (6dfbe504f659), which does not show the problem, as expected. I think there was a real bug in that the tkinter.TclError global was being set to None on exit, but a TclError being raised is expected if I go by the comment in tkinter. The bug

[issue18141] tkinter.Image.__del__ can throw an exception if module globals are destroyed in the wrong order

2014-06-07 Thread Jan Kanis
Jan Kanis added the comment: I tried changing the last block in turtulemodule/__init__.py to if __name__ == '__main__': demo = DemoWindow() print(ENTERING mainloop) demo.root.mainloop() print(Bye) but that does not solve the problem: python3 -m turtledemo ENTERING mainloop

[issue18141] tkinter.Image.__del__ can throw an exception if module globals are destroyed in the wrong order

2014-06-07 Thread Jan Kanis
Jan Kanis added the comment: I have verified that DemoWindow._destroy(self) indeed gets called before the exception is raised. I did a bisect, on the default branch the bug was introduced by commit f0833e6ff2d2: Issue #1545463: Global variables caught in reference cycles are now garbage

[issue18141] tkinter.Image.__del__ can throw an exception if module globals are destroyed in the wrong order

2014-06-07 Thread Jan Kanis
Jan Kanis added the comment: The 3.3 branch is not affected as the f0833e6ff2d2 changeset was never merged into that branch. In the default branch the exception stops appearing after commit 79e2f5bbc30c: Issue #18214: Improve finalization of Python modules to avoid setting their globals

[issue18132] buttons in turtledemo disappear on small screens

2014-06-03 Thread Jan Kanis
Jan Kanis added the comment: I wasn't aware that mixing grid and pack was a bad idea, as I was looking over turtledemo to learn how to use tkinter. The patch replaces a packing in one frame with a grid. All direct children of the graph_frame are gridded. graph_frame itself is still packed

[issue18141] tkinter.Image.__del__ can throw an exception if module globals are destroyed in the wrong order

2014-06-03 Thread Jan Kanis
Jan Kanis added the comment: The main block has been like that from the beginning of recorded time. I could see a use for this if the turtle demo allowed changing of the code in the gui, but it doesn't. -- ___ Python tracker rep...@bugs.python.org

[issue21571] Python build should check CPATH, C_INCLUDE_PATH for module dependencies

2014-05-24 Thread Jan Kanis
New submission from Jan Kanis: When building, pythons setup.py tries to find external sources for optional modules such as ssl, sqlite, etc. For that it searches the CFLAGS environment variable for -I options. C compilers such as gcc and clang also interpret CPATH and C_INCLUDE_PATH as extra

[issue18132] buttons in turtledemo disappear on small screens

2013-06-05 Thread Jan Kanis
Jan Kanis added the comment: I've created a patch, replacing the packed layout by a gridded layout -- hgrepos: +195 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18132

[issue18132] buttons in turtledemo disappear on small screens

2013-06-05 Thread Jan Kanis
Changes by Jan Kanis jan.pyt...@jankanis.nl: -- keywords: +patch Added file: http://bugs.python.org/file30469/7cdaf0223e67.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18132

[issue18141] tkinter.Image.__del__ can throw an exception if module globals are destroyed in the wrong order

2013-06-05 Thread Jan Kanis
New submission from Jan Kanis: While fixing #18132 I noticed that when closing the turtledemo window an exception is thrown (and ignored) because the __del__ tries to catch a TclError exception, but the TclError global has already been deleted and set to None. I could only reproduce

[issue18141] tkinter.Image.__del__ can throw an exception if module globals are destroyed in the wrong order

2013-06-05 Thread Jan Kanis
Jan Kanis added the comment: added a fix -- hgrepos: +196 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18141 ___ ___ Python-bugs-list mailing

[issue18141] tkinter.Image.__del__ can throw an exception if module globals are destroyed in the wrong order

2013-06-05 Thread Jan Kanis
Changes by Jan Kanis jan.pyt...@jankanis.nl: -- keywords: +patch Added file: http://bugs.python.org/file30470/3fdd418be9f8.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18141

[issue18141] tkinter.Image.__del__ can throw an exception if module globals are destroyed in the wrong order

2013-06-05 Thread Jan Kanis
Jan Kanis added the comment: Oops, the diff includes patches for both this issue and #18132, that should be just commit 3fdd418be9f8. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18141

[issue18132] buttons in turtledemo disappear on small screens

2013-06-04 Thread Jan Kanis
Changes by Jan Kanis jan.pyt...@jankanis.nl: -- components: +Demos and Tools type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18132

[issue18132] buttons in turtledemo disappear on small screens

2013-06-04 Thread Jan Kanis
New submission from Jan Kanis: If the window of the turtledemo is small enough, the start/stop/clear buttons disappear. This is specifically a problem when running on a netbook with a small screen, because the buttons are never shown. For a newcommer checking out the demo app this could