[issue19075] Add sorting algorithm visualization to turtledemo
Jason Yeo added the comment: Nothing much AFAIK, except that someone must be willing to maintain the code. I wrote the code, I guess I should be the one maintaining this. I am new to this, what must I look out for if I want to maintain this? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19075 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19075] Add sorting algorithm visualization to turtledemo
New submission from Jason Yeo: My university uses python to teach sorting algorithms. It will be great if the turtledemo comes with a visualization of some of the algorithms. I have attached a patch for it. -- components: Demos and Tools files: animation.diff keywords: patch messages: 198295 nosy: Jason.Yeo priority: normal severity: normal status: open title: Add sorting algorithm visualization to turtledemo type: enhancement versions: Python 3.5 Added file: http://bugs.python.org/file31845/animation.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19075 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14032] test_cmd_line_script prints undefined 'data' variable
Jason Yeo jasonye...@gmail.com added the comment: hi, *friendly ping* how's the review for this patch? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14032 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14026] test_cmd_line_script should include more sys.argv checks
Jason Yeo jasonye...@gmail.com added the comment: *friendly ping*, how's the review for this patch? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14026 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14026] test_cmd_line_script should include more sys.argv checks
Jason Yeo jasonye...@gmail.com added the comment: For the two failures, I suggest modifying _check_script() to return the rc, out, err from the underlying assert_python_ok() call I've decided to simple pass in *example_args into the assert_python_ok() in those two offending tests. There are less changes this way. Please let me know if I am doing this correctly. Thanks. ;) -- Added file: http://bugs.python.org/file24587/mypatch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14026 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14026] test_cmd_line_script should include more sys.argv checks
Changes by Jason Yeo jasonye...@gmail.com: Removed file: http://bugs.python.org/file24587/mypatch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14026 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14026] test_cmd_line_script should include more sys.argv checks
Changes by Jason Yeo jasonye...@gmail.com: Removed file: http://bugs.python.org/file24556/14026patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14026 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14026] test_cmd_line_script should include more sys.argv checks
Changes by Jason Yeo jasonye...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file24588/14026v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14026 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14026] test_cmd_line_script should include more sys.argv checks
Jason Yeo jasonye...@gmail.com added the comment: Just define a list of example args as a module global, append them to the run_args in _check_script, and check them against sys.argv[1:] with assertEqual() in the test script. Okay I have done that but the assertion passes in all the tests except in test_issue8202 and test_issue8202_dash_m_file_ignored. It seems that the script didn't receive any arguments from the cmd line from the way it is executed in these functions. I have attached a patch to let you see what I am doing. Let me know if I am wrong. Thanks. -- Added file: http://bugs.python.org/file24556/14026patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14026 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14026] test_cmd_line_script should include more sys.argv checks
Changes by Jason Yeo jasonye...@gmail.com: -- nosy: +Jason.Yeo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14026 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14032] test_cmd_line_script prints undefined 'data' variable
New submission from Jason Yeo jasonye...@gmail.com: Hi, I'm new around here. I was trying to fix issue 14026 and I found this problem. In test_cmd_line_script, the test_issue8202 tries to print an undefined data variable when verbose is set to 1. I have a patch attached to print(out) instead of print(data). Please let me know if this is the correct thing to do. -- components: Tests files: mypatch messages: 153485 nosy: Jason.Yeo priority: normal severity: normal status: open title: test_cmd_line_script prints undefined 'data' variable type: compile error versions: Python 3.3 Added file: http://bugs.python.org/file24531/mypatch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14032 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14032] test_cmd_line_script prints undefined 'data' variable
Changes by Jason Yeo jasonye...@gmail.com: Added file: http://bugs.python.org/file24532/mypatch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14032 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14032] test_cmd_line_script prints undefined 'data' variable
Changes by Jason Yeo jasonye...@gmail.com: Removed file: http://bugs.python.org/file24532/mypatch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14032 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14026] test_cmd_line_script should include more sys.argv checks
Jason Yeo jasonye...@gmail.com added the comment: I would like to work on this but I am not sure how to go about it. It seems that the method signature for _check_script has to be changed in include another parameter for expected_argv1, expected_argv2, etc. The _check_output also has to be changed to include assertIn(printed_argv1, data) for the additional parameters. This also means that test_source has to include some lines to print the sys.argv[1], sys.argv[2], etc. Am I on the right track? Or is there a easier way? (By the way, when I set verbose to a value 1, errors are found. I realized that a print() statement was printing an undefined variable. I have filed an issue and attached a patch to it. The link for the issue is http://bugs.python.org/issue14032) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14026 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
