[issue23863] Fix EINTR Socket Module issues in 2.7

2015-05-21 Thread Jeff McNeil

Jeff McNeil added the comment:

Do we have a decision on this yet?  I'm willing to rework bits that may need 
it, but I'd like to know whether this is going to be a fruitful effort or not. 
Thanks!

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23863
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23863] Fix EINTR Socket Module issues in 2.7

2015-04-21 Thread Jeff McNeil

Jeff McNeil added the comment:

Fixing the underlying connect call should also address EINTR failing with a 
operation already in progress when a connect+timeout fails due to a signal. 

I can understand not addressing EINTR generically (though it is already 
partially addressed in 2.7's socket.py - this just completes it), but IMO, not 
handling it on connect  responding with a seemingly unrelated error is the 
wrong thing to do.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23863
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23863] Fix EINTR Socket Module issues in 2.7

2015-04-14 Thread Jeff McNeil

Jeff McNeil added the comment:

I'm not a big fan of the settimeout approach myself (and only did it because it 
was mentioned as a possible approach).  I think the existing implementations of 
EINTR retry also suffer from the same issue in which the timeout isn't adjusted 
per iteration (but that's okay, see below).

The _fileobject explicitly states only to use a blocking socket (i.e. one 
without a timeout set), so in practice, that shouldn't be a problem.  I'd like 
to ensure the rest of the calls in that class take the same approach (thus the 
retryable call function, originally without the settimeout code) as they're a 
higher level abstraction above recv/send. 

The only other call in socket.py that also qualifies as a higher abstraction is 
create_connection.   If we could apply the 2.7 patch you created, connect ought 
to be correct at that point.  All that remains after that would be isolating 
_retryable_call to _fileobject calls -- sans the settimeout -- which requires a 
blocking socket anyway. In retrospect, I probably should have just placed that 
call in _fileobject anyway. 

I think that addresses most of what I'd like to fix.  Of course, I'm happy to 
go through and weave PEP 475 into the socketmodule.c code entirely, but if the 
code churn creates too much worry, I think the above is a good medium.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23863
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23863] Fix EINTR Socket Module issues in 2.7

2015-04-13 Thread Jeff McNeil

Jeff McNeil added the comment:

Added a flag to allow for at least one run -- I know nothing of non-Linux clock 
resolution.  That should handle that.

As for the thread safety of the socket timeouts, yeah, that was why I didn't do 
that initially, I assumed the suggestion to take that approach took the risk 
into account; you'll know far more about potential impact than I will.

Since this is at a higher abstraction than socket primitives, another option 
would be to track remaining time in thread local data so that we don't mutate 
the timeout on the object (which I don't really like doing anyway). 

Thoughts on approach before I put it together?

--
Added file: http://bugs.python.org/file38944/socket_eintr.5.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23863
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23863] Fix EINTR Socket Module issues in 2.7

2015-04-13 Thread Jeff McNeil

Jeff McNeil added the comment:

Actually, never mind that suggestion. Now that I think a bit more about it, 
that actually doesn't do anything since I'd still need to set the updated 
timeout on the current socket object anyway. Whoops. 

I'll leave it up to you as to whether we go with an approach like this as is or 
not. I'm happy to change the approach if there's a better one.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23863
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23863] Fix EINTR Socket Module issues in 2.7

2015-04-09 Thread Jeff McNeil

Jeff McNeil added the comment:

Updated to recalculate timeout at Python level.  The current module already 
works this way on recv() calls. See attached.

I'd be happy to churn through and fix the other modules (using the 3.5 work as 
a guide), though I think only addressing the higher level abstractions makes 
sense (I think that's been noted elsewhere). For example, the _fileobject 
wrappers, but not the recv from sock_recv_guts.

--
Added file: http://bugs.python.org/file38883/socket_eintr.3.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23863
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23863] Fix EINTR Socket Module issues in 2.7

2015-04-08 Thread Jeff McNeil

Jeff McNeil added the comment:

Missed check on _ex func.

--
Added file: http://bugs.python.org/file38865/socket_eintr.2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23863
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23863] Fix EINTR Socket Module issues in 2.7

2015-04-08 Thread Jeff McNeil

Jeff McNeil added the comment:

So, yeah, that's right. In the attached patch, I'm closing the file descriptor 
if the timeout/error happens on a non-blocking call.  It fails with an EBADF on 
reconnect at that point, but it doesn't potentially leave an FD in the proc's 
file table.

Should be no more EINTR's coming out of the select call.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23863
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23863] Fix EINTR Socket Module issues in 2.7

2015-04-04 Thread Jeff McNeil

Jeff McNeil added the comment:

Whoops. Accidentally attached the wrong patch that I generated during testing.

--
Added file: http://bugs.python.org/file38832/socket_eintr.1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23863
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23863] Fix EINTR Socket Module issues in 2.7

2015-04-03 Thread Jeff McNeil

Jeff McNeil added the comment:

mcjeff@mcjeff:~/cpython_clean$ hg summary
parent: 95416:fe34dfea16b0 
 Escaped backslashes in docstrings.
branch: 2.7
commit: 3 modified, 3 unknown
update: (current)

--
keywords: +patch
nosy: +gregory.p.smith
Added file: http://bugs.python.org/file38826/socket_eintr.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23863
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23863] Fix EINTR Socket Module issues in 2.7

2015-04-03 Thread Jeff McNeil

New submission from Jeff McNeil:

There are a collection of places in the socket module that do not correctly 
retry on EINTR.  Updated to wrap those calls in a retry loop.  However, when 
fixing connect calls, I noticed that when EINTR is retried on a socket with a 
timeout specified, the retry fails with EALREADY.. so I fixed that.

I was going to shy away from primitive calls on sockets as one expects these 
things when working at a lower level, however, due to the way socket timeouts 
were implemented, I handled it differently in internal_connect.  The 
create_connection calls probably ought to shield users from retry.

Python 2.7.6.

--
files: socket_intr.py
messages: 240044
nosy: mcjeff
priority: normal
severity: normal
status: open
title: Fix EINTR Socket Module issues in 2.7
versions: Python 2.7
Added file: http://bugs.python.org/file38825/socket_intr.py

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23863
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10050] urllib.request still has old 2.x urllib primitives

2012-11-10 Thread Jeff McNeil

Jeff McNeil added the comment:

Reverting of the len(block) back to 'bs' here aside, does it even make sense to 
include block information at all? 

That's the attempted read size, so it might not be an accurate representation 
of the size of the data actually read.  Thus the reason for the initial change.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10050
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10050] urllib.request still has old 2.x urllib primitives

2012-11-10 Thread Jeff McNeil

Jeff McNeil added the comment:

Ah, disregard. I followed up on the other bug. The legacy interface indeed 
should have stayed consistant.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10050
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16357] SSLSocket created from SSLContext.wrap_socket doesn't include cert/keyfile

2012-10-29 Thread Jeff McNeil

New submission from Jeff McNeil:

mcjeff@martian:~/cpython$ ./python -V
Python 3.4.0a0

When an SSLSocket is created via SSLContext.wrap_socket, it is passed a 
_context parameter directly.  SSLSocket.__init__ sets self.context at this 
point, but it does not set self.keyfile or self.certfile.

However, in SSLSocket.accept, both keyfile  certfile are passed when creating 
a new, wrapped SSLSocket, from socket.accept's newsock.

The result is an attribute error.
 import ssl
 c = ssl.SSLContext(ssl.PROTOCOL_SSLv23)
 c.load_cert_chain('Lib/test/keycert.pem')
 import socket
 s = socket.socket(socket.AF_INET, socket.SOCK_STREAM, 0)
 s.bind(('127.0.0.1', 5050))
 s.listen(5)
 s.accept()  # nc localhost 5050 in another term.
Traceback (most recent call last):
  File stdin, line 1, in module
  File /usr/local/google/home/mcjeff/cpython/Lib/ssl.py, line 557, in accept
keyfile=self.keyfile, certfile=self.certfile,
AttributeError: 'SSLSocket' object has no attribute 'keyfile'
 

Attached one-liner addresses it by passing in the context rather than the 
keyfile  certfile.

 s.accept()
(socket.socket object, fd=4, family=2, type=1, proto=0, ('127.0.0.1', 37306))


--
components: Library (Lib)
files: ssl_context.patch
keywords: patch
messages: 174121
nosy: mcjeff
priority: normal
severity: normal
status: open
title: SSLSocket created from SSLContext.wrap_socket doesn't include 
cert/keyfile
versions: Python 3.4
Added file: http://bugs.python.org/file27776/ssl_context.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16357
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16357] SSLSocket created from SSLContext.wrap_socket doesn't include cert/keyfile

2012-10-29 Thread Jeff McNeil

Jeff McNeil added the comment:

Ak! Yes, cut and paste error.

Python 3.4.0a0 (default:57a33af85407, Oct 27 2012, 21:26:30) 
[GCC 4.4.3] on linux
Type help, copyright, credits or license for more information.
 import ssl  
 c = ssl.SSLContext(ssl.PROTOCOL_SSLv23)
 c.load_cert_chain('Lib/test/keycert.pem')
 import socket
 s = socket.socket(socket.AF_INET, socket.SOCK_STREAM, 0)
 s.bind(('127.0.0.1', 5050))
 s = c.wrap_socket(s)
 s.listen(5)
 s.accept()
Traceback (most recent call last):
  File stdin, line 1, in module
  File /home/jeff/cpython/Lib/ssl.py, line 557, in accept
keyfile=self.keyfile, certfile=self.certfile,
AttributeError: 'SSLSocket' object has no attribute 'keyfile'
 

I'll add a corresponding test, sure thing.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16357
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16357] SSLSocket created from SSLContext.wrap_socket doesn't include cert/keyfile

2012-10-29 Thread Jeff McNeil

Jeff McNeil added the comment:

Updated to pass in the parent context only actually, as it doesn't look like 
all of the attributes on SSLSocket will be set if a context was initially 
passed in.

--
Added file: http://bugs.python.org/file27784/ssl_context_2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16357
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13403] Option for XMLPRC Server to support HTTPS

2012-10-28 Thread Jeff McNeil

Jeff McNeil added the comment:

I've hacked this support in myself a few times with a simple socket wrap call 
in SimpleXMLRPCServer's __init__.  I'd be happy to put a quick patch together 
if that's a viable approach.

Is there any desire to support client authentication or advanced features like 
that? Or, are we simply looking for encryption?

--
nosy: +mcjeff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13403
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13403] Option for XMLPRC Server to support HTTPS

2012-10-28 Thread Jeff McNeil

Jeff McNeil added the comment:

Attached... worked in the way I've done it in the past and updated documents.

--
keywords: +patch
Added file: http://bugs.python.org/file27773/ssl_xmlrpc_server.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13403
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5004] socket.getfqdn() doesn't cope properly with purely DNS-based setups

2012-10-27 Thread Jeff McNeil

Jeff McNeil added the comment:

Gave this a go myself...

$ ./python
Python 3.4.0a0 (default:57a33af85407, Oct 27 2012, 21:26:30) 
[GCC 4.4.3] on linux
Type help, copyright, credits or license for more information.
 import socket
 socket.getfqdn()
'host.domain.com'
 

$ hostname -f
host.domain.com

$ cat /etc/hosts
127.0.0.1   localhost.localdomain   localhost

# The following lines are desirable for IPv6 capable hosts
::1 ip6-localhost ip6-loopback
fe00::0 ip6-localnet
ff00::0 ip6-mcastprefix
ff02::1 ip6-allnodes
ff02::2 ip6-allrouters

Linux host 3.5.2-x86_64 #1 SMP Wed Aug 15 14:31:07 EDT 2012 x86_64 GNU/Linux

According to strace, both rely on DNS:

recvfrom(3, Wj\201\200\0\1\0\1\0\5\0\0\00219\003134\003230\003173\7in-a..., 
1024, 0, {sa_family=AF_INET, sin_port=htons(53), 
sin_addr=inet_addr(1.2.3.4)}, [16]) = 176

Same behavior on both 2.6  hg tip.  I think this is a non-issue.

--
nosy: +mcjeff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5004
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14255] tempfile.gettempdir() didn't return the path with correct case.

2012-10-20 Thread Jeff McNeil

Jeff McNeil added the comment:

Yeah clearly the wrong behavior on Winders.

I think that moving to 'normpath' instead of 'normcase' is likely the right 
thing to do. Patch is attached, so if someone with commit powers could review 
real quick I'll address whatever needs to be addressed.

IMHO, the 'normcase' calls are of questionable benefit since the posix call is 
simply an identity and as this bug details, it isn't necessarily the right 
behavior on Win.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14134] xmlrpc.client.ServerProxy needs timeout parameter

2012-05-17 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

Yeah, that's a good point too. I still personally favor the transport 
encapsulation and related unit testing, but I think that's a call for someone 
with a snake icon next to their tracker name.

Your English is just fine. =)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14134
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14134] xmlrpc.client.ServerProxy needs timeout parameter

2012-05-16 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

I would think it might make more sense just to make the change to the Transport 
object.  Since there's an argument for a transport on ServerProxy already, that 
seems more straightforward and keeps the network layer isolated.

Otherwise, it seems slightly ambiguous to me. Consider that maybe I passed in a 
transport and a timeout, why wasn't my timeout honored?  Though, I guess 
use_datetime already behaves that way.

--
nosy: +mcjeff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14134
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14652] Better error messages for wsgiref validator failures

2012-05-16 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

I went through the patch real quick and I noticed that your using single 
element tuples in your string formatting.  That makes sense in situations where 
the argument might itself be a tuple, however, not on calls to len() as that 
will return an integer.

--
nosy: +mcjeff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14652
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14487] Add pending() query method to Queue.Queue

2012-04-03 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

I looked at doing this. The empty() and full() methods are marked with a 
disclaimer stating they're likely to be removed at some point?

I'm curious, does just checking the value of Queue.unfinished_tasks satisfy 
the requirement? It could still easily be non-zero even if the queue itself is 
empty, signifying work in progress.  Another option might be to allow 
non-blocking use of join()?

--
nosy: +mcjeff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14487
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14425] Improve handling of 'timeout' parameter default in urllib.urlopen

2012-03-27 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

Quick little patch to change the default to None and update the corresponding 
documentation.

--
keywords: +patch
nosy: +mcjeff
Added file: http://bugs.python.org/file25044/urllib_urlopen_default.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14425
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10050] urllib.request still has old 2.x urllib primitives

2012-03-25 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

I was looking at a somewhat unrelated issue and I bumped up against a similar 
situation with the warnings system. 

I didn't look too much into it, but it appeared that warnings didn't get added 
to __warningregistry__ correctly. Though, when I set the stack level explicitly 
(to an incorrect value for the issue at hand), the warnings were caught by 
catch_warnings.

I don't know if it is related or not, but my assumption at the time was that 
smarter people than I had vetted warnings. =)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10050
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10050] urllib.request still has old 2.x urllib primitives

2012-03-25 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

Disregard. That was in concert with ntpath, which uses a funky approach to 
testing.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10050
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14255] tempfile.gettempdir() didn't return the path with correct case.

2012-03-15 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

Here's a tiny patch that just changes normcase-normpath.  This fixes the 
casing issue at the 'gettempdir' level, though it doesn't address the 
'normcase' function itself.

Note that *both* macpath.py and ntpath.py use s.lower, which obviously won't 
fly on case-sensitive mounts. If someone more experienced than I has a 
suggestion on how to handle that -- or whether its worthwhile to even touch -- 
I'll gladly implement.

--
keywords: +patch
Added file: http://bugs.python.org/file24861/tempfile_normpath.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14255] tempfile.gettempdir() didn't return the path with correct case.

2012-03-15 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

It doesn't seem to me that the right approach on either platform is to simply 
downcase.  Maybe just deprecate the call altogether as its not doing anything 
normpath isn't if the s.lower call is removed?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14255] tempfile.gettempdir() didn't return the path with correct case.

2012-03-14 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

The normcase call isn't exactly a no-op in ntpath.py as it also swaps / for \\. 
 Removing the .lower() seems to simply make it a watered down version of 
normpath.

There are a couple of options I guess.  We could simply keep the altsep, or 
update _get_default_tempdir to use normpath?  

I'd be happy to do it once everyone agrees =)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10050] urllib.request still has old 2.x urllib primitives

2012-03-14 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

I don't see why we'd need to make these _private -- they're just 
accessors/mutators for the most part.  I'd be happy to help clean this up if 
you need it.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10050
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12890] cgitb displays p tags when executed in text mode

2012-03-13 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

Did this ever get committed? Is there anything left for me to do here?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1666318] shutil.copytree doesn't give control over directory permissions

2012-03-13 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

I made the change suggested in the last comment, patch is attached. Trying to 
clean up any bugs I've got my name on!

--
keywords: +patch
Added file: http://bugs.python.org/file24816/makedirs_function.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1666318
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12365] URLopener should support context manager protocol

2012-03-13 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

Documentation patch to outline the use of context manager protocol attached. 
Trying to cleanup any bugs with my name on them.

--
keywords: +patch
Added file: http://bugs.python.org/file24817/urllib_request_doc.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12365
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10050] urllib.request still has old 2.x urllib primitives

2012-03-13 Thread Jeff McNeil

Changes by Jeff McNeil j...@jmcneil.net:


--
nosy:  -mcjeff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10050
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1429] FD leak in SocketServer

2012-03-13 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

In an effort to walk through bugs in my nosy list, I dug into this and tried to 
reproduce it to no avail. 

Also, as the handle_error method is supposed to handle problems gracefully, 
calling shutdown on handle_error exception is probably questionable. I'd be 
happy to submit a patch to do just that if those smarter than I think it is 
worthwhile, but I don't so much believe it is.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1429
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1666318] shutil.copytree doesn't give control over directory permissions

2012-03-13 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

Ah, understood. I kind of like the idea of having the added functionality 
behind a custom callable, but if it's generally just a bug then copystat is a 
good solution, too.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1666318
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12365] URLopener should support context manager protocol

2012-03-13 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

Yeah, updated with different wording and proper caps.  I left the piece in 
regarding the use without the context manager as I think that's probably the 
more common use case still.

--
Added file: http://bugs.python.org/file24832/urllib_request_doc.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12365
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10050] urllib.request still has old 2.x urllib primitives

2012-03-13 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

I'd be happy to do that (URLopener, to begin with), though I'm not familiar 
with the usual approach.  Is it simply a matter of warning in __init__?

--
nosy: +mcjeff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10050
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14255] tempfile.gettempdir() didn't return the path with correct case.

2012-03-13 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

The actual implementation calls os.path.normcase from 
tempfile._get_default_tempdir. In this scenario here, that resolves to the 
ntpath module  triggers a lowercase conversion.

On the other hand, the posixpath module is simply an identity function.

Now, it *is* possible to force a Windows file system to run in a case-sensitive 
configuration. Since ntpath.py forces lower case, this could actually cause 
breakage in that situation, however rare.

In my opinion, changing the ntpath.normcase function to retain case probably 
yields more correct behavior.

--
nosy: +mcjeff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14255
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12890] cgitb displays p tags when executed in text mode

2011-11-21 Thread Jeff McNeil

Changes by Jeff McNeil j...@jmcneil.net:


Added file: http://bugs.python.org/file23743/head-cgitb-display.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12890] cgitb displays p tags when executed in text mode

2011-11-20 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

Added everything to one file. Updated tests to also include a logdir argument 
as that is required to trigger the original bug.  Weeded out a spurious write 
that occurred when format was set to text.

--
Added file: http://bugs.python.org/file23737/head-cgitb-display.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12890] cgitb displays p tags when executed in text mode

2011-11-19 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

Is there anything else needed here?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12890] cgitb displays p tags when executed in text mode

2011-11-19 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

I didn't add one initially as I was just changing output format and not actual 
behavior.  I guess I could add something to ensure it doesn't regress? I'll 
make sure there's coverage to begin with.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12890] cgitb displays p tags when executed in text mode

2011-11-19 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

Test to ensure html isn't included when the formatting is text.  I don't seem 
to be able to update the stage.

--
Added file: http://bugs.python.org/file23731/head-cgitb-display-tests.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12890] cgitb displays p tags when executed in text mode

2011-09-02 Thread Jeff McNeil

New submission from Jeff McNeil j...@jmcneil.net:

If cgitb.enable is ran with a logdir set and a format='text' argument, then a 
trailing message is printed that includes p tags.  This should only happen if 
the format requested is HTML.

The following tiny script shows the problem:

import cgitb
cgitb.enable(format='text', logdir='/tmp')
1/0

Attaching a small patch which addresses. This is against tip on the default 
branch.

mcjeff@macbook:~/cpython$ ./python.exe --version
Python 3.3.0a0

--
components: Library (Lib)
files: head-cgitb-display.patch
keywords: patch
messages: 143449
nosy: mcjeff
priority: normal
severity: normal
status: open
title: cgitb displays p tags when executed in text mode
versions: Python 3.3
Added file: http://bugs.python.org/file23091/head-cgitb-display.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12890
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12365] URLopener should support context manager protocol

2011-06-20 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

Isn't that snippet (contextlib.closing(...)) passing the result of 
urllib.urlopen to closing? The urlopen call is a factory function of sorts, so 
there's really no context to manage on its part?  Maybe it's just a matter of 
making that clear?

If you can share what you've got in mind, I'd love to give it a go. The urllib 
stuff I've done thus far has been a great way to get my feet wet!

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12365
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12365] URLopener should support context manager protocol

2011-06-19 Thread Jeff McNeil

New submission from Jeff McNeil j...@jmcneil.net:

Per discussion within Issue10050, URLopener ought to support the context 
manager protocol. That allows more idiomatic usage and doesn't require calls to 
contextlib.closing for use with the 'with' statement.

If agreed, I'll create a patch.

--
components: Library (Lib)
messages: 138649
nosy: mcjeff
priority: normal
severity: normal
status: open
title: URLopener should support context manager protocol
versions: Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12365
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12365] URLopener should support context manager protocol

2011-06-19 Thread Jeff McNeil

Changes by Jeff McNeil j...@jmcneil.net:


--
type:  - feature request

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12365
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12365] URLopener should support context manager protocol

2011-06-19 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

In looking at this again, I may have spoken too soon. It seems that addinfobase 
 HTTPResponse already handle this. As this is what's returned by the opener, 
then what I was shooting for should already be handled.

--
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12365
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10050] urllib.request still has old 2.x urllib primitives

2011-03-30 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

I'd be happy to pick some of that stuff up. I'd like to address separately as 
it keeps fewer concerns in this one patch. I'll grab them once they're created.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10050
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10050] urllib.request still has old 2.x urllib primitives

2011-03-21 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

Just wanted to check so this doesn't sit with people waiting on me.  Is there 
anything else I need/should do to this patch? Little unclear on how to handle 
the deprecation process.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10050
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10050] urllib.request still has old 2.x urllib primitives

2011-03-20 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

I'm not exactly sure what the steps are with respect to the DeprecationWarning. 
Is the common case just to raise the warning in the __init__ method? Are there 
related documentation changes?

Thanks again! Learning a ton. Hopefully the next patch I submit will go much 
smoother.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10050
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10050] urllib.request still has old 2.x urllib primitives

2011-03-19 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

I'll make those changes, sure.  I had the same thought re: block size, but I 
was trying to keep inline with what the current function did.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10050
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10050] urllib.request still has old 2.x urllib primitives

2011-03-19 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

Take four! Includes Antoine's suggestions. I changed the callback to return 
(block num, read size, file size) as opposed to (block num, block size, file 
size) as this seems to make more sense. 

I appreciate the back and forth. I'd be happy to create issues  handle the 
other things that have been moved out of this patch.

--
Added file: http://bugs.python.org/file21299/issue10050.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10050
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10050] urllib.request still has old 2.x urllib primitives

2011-03-18 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

Alright, attaching a patch that reworks urlretrieve to use urlopen internal to 
urllib.request.  

1. I dropped the local caching as it isn't turned on by default anyway (and 
isn't really documented).

2. Updated documentation to reflect caching changes  make urlretrieve part of 
the official API again.

3. Kept the urlcleanup function, but use a global list to track temporary 
files.  I'd be happy to change this functionality if that makes sense.

4. After moving the urlretrieve stuff out of test_urllibnet, I realized that 
file didn't serve much of a purpose any longer, so I just removed it. 

5. Updated NEWS.

I'd be happy to rework any of this in order to bring it up to stuff. Comments 
and suggestions are very much welcomed.

--
keywords: +patch
Added file: http://bugs.python.org/file21285/issue10050.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10050
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10050] urllib.request still has old 2.x urllib primitives

2011-03-18 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

Made recommended changes. Moved to NamedTemporaryFile. I don't think the 
spooled file makes sense here as the existing protocol provides a filename in 
the returned tuple, not a f.l.o. 

As far as the description?  Here are a couple suggestions:

1. URL Retrieval Library
2. URL Access Module

Updated the module documentation as well as the howto.

--
Added file: http://bugs.python.org/file21286/issue10050.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10050
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10050] urllib.request still has old 2.x urllib primitives

2011-03-18 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

Made requested change to Synopsis/Description.

--
Added file: http://bugs.python.org/file21287/issue10050.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10050
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-17 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

So, it turned out to be more complicated than that.  The HTTPConnection object 
returns an HTTPResponse, but never closes the underlying socket after calling 
makesock. 

Since persistent connections aren't supported, nothing actually closes  the 
socket itself, it's just set to None.  Explicitly calling a close turns out not 
to be correct either.

I went down the same path as AbstractHTTPHandler and added a Connection: close 
header.  That ensures that the remote host will close the underlying connection 
(more importantly, setting the HTTP Response object's will_close to True).  
That ensures  HTTPConnection performs in a fire and forget mode, causing 
everything to close out as it should.

I contemplated changing urlretrieve to use build_opener as urlopen does, but I 
figure that would have been done by now if it was a trivial operation. I'd be 
happy to take a whack at it if it's just a matter of getting around to it.

--
keywords: +patch
Added file: http://bugs.python.org/file21273/11562.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11563
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-17 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

Sounds good. I'll look at doing that, too.

--
versions: +Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11563
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10050] urllib.request still has old 2.x urllib primitives

2011-03-17 Thread Jeff McNeil

Changes by Jeff McNeil j...@jmcneil.net:


--
nosy: +mcjeff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10050
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-16 Thread Jeff McNeil

Changes by Jeff McNeil j...@jmcneil.net:


--
nosy: +mcjeff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11563
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-16 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

So, I've been meaning to get more into contributing back to Python and I found 
this one somewhat interesting.

As it turns out, even the following simple script raises the same warning:


[jeff@martian cpython]$ ./python -c 'import urllib.request; 
urllib.request.urlretrieve(http://www.python.org;)'
/home/jeff/cpython/Lib/socket.py:340: ResourceWarning: unclosed socket.socket 
object, fd=3, family=2, type=1, proto=6
  self._sock = None
[64388 refs]
[jeff@martian cpython]$ 

The close method of Socket.SocketIO simply sets the underlying socket object to 
None, which causes that warning.  Explicitly calling the close method on the 
underlying socket clears that up (and it's protected by that reference counter).

The _decref_socketios just drops the internal ref count and never actually 
closes -- it won't unless self.__closed is True. 

So, when self._sock is set to None, that error bubbles up. As SocketIO is the 
foundation used in socket.makefile, I think just adding that close call ought 
to be correct.

I can do the simple patch if you agree.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11563
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1429] FD leak in SocketServer

2011-03-13 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

I entirely forgot I had signed up to look, my apologies. 

I'm going through this w/ what's lying on Mercurial's tip, I can't reproduce it 
at all. I can raise exceptions of various flavors from within the handle method 
of a StreamRequestHandler and there are no leaking file descriptors.  

The only thing worthy of discusion, IMO, is the fact that raising an exception 
in a handle_error method of a subclass of BaseServer *does* cause the the 
self.shutdown_request to not run.  

Unless I'm mistaken, that does then leave the cleanup of that open socket to GC 
(but, at that point, anyone overriding handle_error method should know that). 
Does it make sense to run shutdown_request, even if handle_error throws an 
Exception?  

If anyone thinks that's worthwhile, I can do that.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1429
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1429] FD leak in SocketServer

2010-09-18 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

I'll see if I can get it to reproduce and put a patch together.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1429
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1429] FD leak in SocketServer

2010-05-02 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

I was toying with adding Unix Socket support for one of our internal tools and 
I thought I ran into a leak in my own code. Searched the bug tracker and found 
this.

I tried to reproduce, but wasn't able to. Though, if you look at the 
ThreadingMixIn class, you'll see this:

self.handle_error(request, client_address)
self.close_request(request)

An exception in handle_error, most likely from a subclass, would cause 
close_request to never fire. Though, the socket.accept'd channel would probably 
be shut down implicitly when leaving _handle_request_nonblock.

--
nosy: +mcjeff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1429
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8556] Confusing string formatting examples

2010-04-30 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

Attaching a patch against the trunk, unified format, changed to 'number' as per 
suggestion.

--
versions: +Python 2.7 -Python 2.6
Added file: http://bugs.python.org/file17155/stdtypes.rst.trunk.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8556
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8556] Confusing string formatting examples

2010-04-27 Thread Jeff McNeil

New submission from Jeff McNeil j...@jmcneil.net:

I was going through the string formatting examples this evening and noticed 
this:

print '%(language)s has %(#)03d quote types.' % \
  {'language': Python, #: 2}


The example uses a '#' as a map key. This is somewhat misleading as if we had 
simply left the parenthesis off, the '#' would have been interpreted as an 
alternate conversion flag. Should be updated to use a more verbose (and less 
confusing) dictionary key.

--
assignee: d...@python
components: Documentation
files: stdtypes.rst.2.6.5.patch
keywords: patch
messages: 104410
nosy: d...@python, mcjeff
priority: normal
severity: normal
status: open
title: Confusing string formatting examples
versions: Python 2.6
Added file: http://bugs.python.org/file17115/stdtypes.rst.2.6.5.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8556
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1666318] shutil.copytree doesn't preserve directory permissions

2010-04-27 Thread Jeff McNeil

Changes by Jeff McNeil j...@jmcneil.net:


--
nosy: +mcjeff -j_mcneil

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1666318
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5102] urllib2.py timeouts do not propagate across redirects for 2.6.1 (and 3.x?)

2009-06-12 Thread Jeff McNeil

Jeff McNeil j...@jmcneil.net added the comment:

I ran into this problem this afternoon as well. The same issue appears
to exist within the Basic  Digest Auth retry code (though it's much
less likely to surface).

I wound up making the suggested fixes to my local install so I'm
attaching the tiny patch in hopes that someone finds it useful.

--
keywords: +patch
nosy: +j_mcneil
Added file: http://bugs.python.org/file14276/urllib2_timeouts.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5102
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com