[issue27806] 2.7 32-bit builds fail on macOS 10.12 Sierra due to dependency on deleted header file QuickTime/QuickTime.h
Jeremy Sequoia added the comment: QuickTime/QuickTime.h was deprecated long ago. python fails to compile if QuickTime/QuickTime.h isn't present. QuickTime/QuickTime.h was removed in Sierra, causing the build to fail on Sierra. This patch fixes that issue. > On Oct 17, 2016, at 05:23, Lapsang Leaf <rep...@bugs.python.org> wrote: > > > Lapsang Leaf added the comment: > > Can we have this in English, please, for noobs? > > I only use python in order to run zim on my mac. I do not have the same > technical know-how as many users and I do not understand the parlance here. > Currently I have OS X 10.12 with python 2.7 - updating to sierra seems to > have broken it. > > Please let me know, step by step, what I need to do to patch and get it > running again. Thanks > > -- > nosy: +Lapsang Leaf > > ___ > Python tracker <rep...@bugs.python.org> > <http://bugs.python.org/issue27806> > ___ -- Added file: http://bugs.python.org/file45123/smime.p7s ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue27806> ___ smime.p7s Description: S/MIME cryptographic signature ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file
Jeremy Sequoia added the comment: sys/cdefs.h (on new enough darwin) does this for such cases: #ifndef __has_include #define __has_include(x) 0 #endif but of course that isn't present in sys/cdefs.h on older SDKs, so you can just shove that above the check and it should fallback the way you want. Using gcc-4.2 on Sierra would end up with the wrong result, but that's not a supported configuration. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue27806> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file
Jeremy Sequoia added the comment: Thanks, yep that looks much nicer to me. Containing the core logic at a central choke point makes maintenance much easier. I'll work to get this into MacPorts. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue27806> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file
Jeremy Sequoia added the comment: Correction (bugfix and Tiger-compat): #if __has_include() #include #define APPLE_SUPPORTS_QUICKTIME (__MAC_OS_X_VERSION_MAX_ALLOWED < 101200) && !__LP64__ #else #define APPLE_SUPPORTS_QUICKTIME !__LP64__ #endif -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue27806> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file
Jeremy Sequoia added the comment: AvailabilityMacros.h is super deprecated and should not be used by anything current. Availability.h was added as replacement in 10.5. __MAC_OS_X_VERSION_MAX_ALLOWED should be checked instead of defined (DEPRECATED_IN_MAC_OS_X_VERSION_10_12_AND_LATER) You should really have a central config and use that instead. Eg: #include #define APPLE_SUPPORTS_QUICKTIME (__MAC_OS_X_VERSION_MAX_ALLOWED < 101200) || !__LP64__ Then use APPLE_SUPPORTS_QUICKTIME throughout. That avoids tons of churn whenever things change (as exemplified by this very bug) -- nosy: +jeremyhu ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue27806> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
