[issue16428] turtle with compound shape doesn't get clicks
Changes by Jessica McKellar jesst...@mit.edu: -- keywords: +needs review stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16428 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18624] Add alias for iso-8859-8-i which is the same as iso-8859-8
Changes by Jessica McKellar jesst...@mit.edu: -- keywords: +needs review stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18624 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21868] Tbuffer in turtle allows negative size
Changes by Jessica McKellar jesst...@mit.edu: -- keywords: +needs review stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21868 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Jessica McKellar added the comment:
Thanks for the patch, Lita! Lita: I have some patch feedback for you at the end
of this message.
--
Lita and I talked about this a bit via email; here's some additional context
from that conversation:
There were a couple of questions to answer before working on a patch:
1. Are brackets allowed in flag names according to the RFC?
2. If brackets aren't allowed, do other popular IMAP services permit them
anyway? If so, we should consider allowing them even though this deviates from
the RFC.
To answer (1), my read of http://tools.ietf.org/html/rfc3501 is as follows:
a. Look at http://tools.ietf.org/html/rfc3501, search for PERMANENTFLAGS
definition. Note use of flag-perm variable.
b. Search for flag-perm. Find it on page 85, in section 9, Formal Syntax.
This is describing the formal syntax in Backus-Naur Form (BNF).
c. flag-perm = flag / \*
d. flag = \Answered / \Flagged / \Deleted /
\Seen / \Draft / flag-keyword / flag-extension
; Does not include \Recent
e. flag-keyword = atom
f. atom = 1*ATOM-CHAR
g. ATOM-CHAR = any CHAR except atom-specials
h. atom-specials = ( / ) / { / SP / CTL / list-wildcards /
quoted-specials / resp-specials
i. resp-specials = ]
My reading of this series of definitions is that ] is not allowed in flag
names.
To answer (2), Lita ran some tests against GMail's IMAP service and found that
it does let you create flags containing ].
--
Patch feedback:
1. Can you attach the script you used to probe GMail's IMAP service for what
flag names were permitted?
2. Since this patch causes us to violate the RFC (but with good reason!), can
you add a comment above the regex noting the violation and stating what
characters we allow for flags and why?
3. This change need tests.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21815
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1186900] nntplib shouldn't raise generic EOFError
Changes by Jessica McKellar jesst...@mit.edu: -- keywords: +needs review stage: test needed - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1186900 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21585] Run Tkinter tests with wantobjects=False
Changes by Jessica McKellar jesst...@mit.edu: -- keywords: +needs review stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21585 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6639] turtle: _tkinter.TclError: invalid command name .10170160
Changes by Jessica McKellar jesst...@mit.edu: -- keywords: +needs review stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6639 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21914] Create unit tests for Turtle guionly
Changes by Jessica McKellar jesst...@mit.edu: -- keywords: +needs review stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21914 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21916] Create unit tests for turtle textonly
Changes by Jessica McKellar jesst...@mit.edu: -- keywords: +needs review stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21916 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21404] Document options used to control compression level in tarfile
Changes by Jessica McKellar jesst...@mit.edu: -- stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21404 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21463] RuntimeError when URLopener.ftpcache is full
Jessica McKellar added the comment:
I want to state explicitly what the error is for some new contributors who
might pick this up at a sprint this weekend:
The issue is that you can't change a dictionary while iterating over it:
d = {a: b}
for elt in d.keys():
... del d[elt]
...
Traceback (most recent call last):
File stdin, line 1, in module
RuntimeError: dictionary changed size during iteration
In Python 2, d.keys() produced a copy of the list of keys, and we delete items
from the dictionary while iterating over that copy, which is safe. In Python 3,
d.keys() produces a view object* instead, and mutating the dictionary while
iterating over it is unsafe and raises an error.
The patch makes a copy of the keys before iterating over it so that it is safe
in Python 3.
* https://docs.python.org/3/library/stdtypes.html#dict-views
--
nosy: +jesstess
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21463
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21646] Add tests for turtle.ScrolledCanvas
Changes by Jessica McKellar jesst...@mit.edu: -- assignee: - jesstess ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21646 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21573] Clean up turtle.py code formatting
Jessica McKellar added the comment: Terry, thank you for all the time you've been putting into the GSoC and OPW tickets. Questions: is there project link? are any of the mentors core developers, with commit rights? or would you need commits from someone like me? https://wiki.python.org/moin/OPW/2014#Graphical_Python is a broad-strokes outline. As we get further into the internship we'll decide on areas of focus. I'm the main mentor. I don't have commit rights but would be reviewing most of the changes before putting them in the commit review stage. I looked for and did not fine test/test_turtle. Did I miss something? Turtledemo is a partial substitute, but it might not exercise all turtle functions. You didn't miss anything. :) Part of this internship will be adding unit test coverage. @Lita: I'll take care of creating unit test tickets that split up the work between you and Ingrid. Testing: A complete 'unit' test would test each function in each layer. A minimal 'unit' test should at least test each top-level function and check response on the canvas. Assuming that one can get to tk root and canvas, some things should be possible. But I don't know what introspection functions a canvas has. An alternative would be to replace the canvas with a mock-canvas with extra introspection added. Another alternative would be a human-verified test, a turtle script that systematically called every function and said that it was doing for a person to verify. Line width: 1, 2, 3, 5, 8, 12 17, 30 (with a slight pause for each width). Ingrid Cheung (added to the nosy list) is working on unit test scaffolding, inspired by the tkinter tests. I want to make sure there's a clear course of action for Lita on this ticket. If cleanup is controversial, how about rescoping this to points (3) and (4) from the original ticket statement: 3. Examine commented out code, and either remove it or open a ticket if it represents an issue that should be fixed. 4. Examine # XXX comments, and either remove them if they are no longer applicable, or open tickets for them if they still represent bugs and then remove them. @Terry, what do you think about that? @Lita, your pep8 and linter work has not been in vain. :) It'll come in handy local to where you fix bugs and add features down the road. -- nosy: +ingrid ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21573 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19980] Improve help('non-topic') response
Jessica McKellar added the comment:
@BreamoreBoy, thanks for following up on this!
I propose the following. help('') returns help on strings in the same way
that help([]) and help({}) returns help on lists and dicts respectively,
Sounds good.
further help(''.method) returns help on the string method or an attribute
error, so this appears to me consistent.
This already happens (which I think you are saying, but it's a bit confusing in
reading your message which functionality you are proposing to add and which
functionality you are restating that already exists).
help('doh') returns enhanced output along the lines Terry suggested in
msg206157.
Sounds good.
help('module') gives the path to the module as well as the help output, if
any, as I think this could be useful in cases where you're looking for
problems and have a stdlib module masked by a file of your own.
I think you are stating the current functionality?
Note that I've tried looking at the test code and it didn't make much sense
to me, pointers welcome.
Do you have specific questions?
Terry suggests that help() tests for functionality using pydoc live in
test_pydoc.py, and that help() tests for functionality not using pydoc live in
test_site.py.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3015] tkinter with wantobjects=False has been broken for some time
Jessica McKellar added the comment: @Lita.Cho: (I'd like to this on the web but the links are still broken after the website port) if you search for `wantobjects` in `Doc/whatsnew/2.3.rst`, there's a description of why the parameter was added. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3015 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17496] OS X test for Tk availability in runtktests.py doesn't work
Jessica McKellar added the comment: Some IRC discussion about what contributors should do while this is unresolved, and the bigger plan for comprehensively addressing this: 01:53 ned_deily jesstess, saw your nosy on Issue17496. Beware that it's really a can of worms and definitely was misclassified as easy. Lots of edge cases, some not discussed in the issue. 03:01 jesstess ned_deily: can you update the ticket with edge cases not yet discussed? The issue is making life hard for some of our interns, so I'd love to see some progress on it. 03:02 jesstess ned_deily: I also found ronaldoussoren's conclusions hard to follow. I think a re-statement of what the best solution for the problem is would be really helpful, if you have opinions on it. 03:04 ned_deily jesstess, can you say how it is causing problems? 03:08 jesstess ned_deily: They are working on Tkinter tickets, and their primary development platform happens to be OSX, where the tests are getting skipped. One has set up a Linux VM already, which is fine, but it's a confusing issue to hit for new contributors and they also want to have the confidence that changes and new tests pass on OSX before submitting patches for review. 03:09 ned_deily jesstess, OK. Alas, Tk is a bit of a problem on any platform and it's pretty much a mess on OS X. 03:15 ned_deily jesstess, Currently, there are three different variants of Tk in use on OS X. And the most commonly used variant, the Cocoa Tk 8.5, is still relatively new and has had major bugs (still present in the version shipped by Apple in OS X) and has variations from minor release to minor release. 03:20 ned_deily jesstess, The plan is to make things a lot easier to test by making it easier to use a custom-built Tk for OS X. In the meantime, there really is no easy way around things. Fixing #17496 by itself won't allow testing on OS X. 03:20 ned_deily jesstess, For the time being, I would suggest just testing as best as possible on whatever platforms one can and submitting the patches. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17496 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21573] Clean up turtle.py code formatting
New submission from Jessica McKellar: Lib/turtle.py has some code formatting issues. Let's clean them up to make the module easier to read as interns start working on it this summer. Specifically: 1. Run turtle.py through a pep8 checker and fix the issues that are reasonable to fix. 2. Run turtle.py through a linter like pyflakes and fix reasonable linter issues. 3. Examine commented out code, and either remove it or open a ticket if it represents an issue that should be fixed. 4. Examine # XXX comments, and either remove them if they are no longer applicable, or open tickets for them if they still represent bugs and then remove them. -- assignee: jesstess keywords: gsoc messages: 219068 nosy: jesstess priority: normal severity: normal stage: needs patch status: open title: Clean up turtle.py code formatting type: enhancement versions: Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21573 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16428] turtle with compound shape doesn't get clicks
Changes by Jessica McKellar jessica.mckel...@gmail.com: -- nosy: +jesstess ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16428 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17496] OS X test for Tk availability in runtktests.py doesn't work
Changes by Jessica McKellar jessica.mckel...@gmail.com: -- nosy: +jesstess ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17496 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13583] sqlite3.Row doesn't support slice indexes
Jessica McKellar added the comment: Thanks for the ticket and patch, xapple! I updated the patch to address the compiler warning and use assertEqual. While testing, I noticed that slicing with steps wasn't supported, so I expanded the sqlite3.Row slicing code to support steps, and added some additional tests. The slicing code in Modules/_sqlite/row.c:pysqlite_row_subscript is unfortunately pretty redundant with the slicing code in Objects/tupleobject.c. It'd be better to either be able to factor the code from both into a function (but I couldn't see how to do this without making it part of the public API), or have tuple, sqlite.Row, etc. implement a shared slicing interface. Perhaps we should defer that decision to a future ticket, though. Note that even after this patch, sqlite.Row instances don't support negative indices. * This patch passes `make patchcheck`. * The full test suite passes with this patch. * There are no build warnings related to the patch. -- keywords: +needs review nosy: +jesstess versions: +Python 3.5 -Python 3.3 Added file: http://bugs.python.org/file35070/issue13583.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13583 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13583] sqlite3.Row doesn't support slice indexes
Jessica McKellar added the comment: I've also uploaded a short script that sets up an in-memory sqlite database that fetches Rows, for easy manual testing. -- Added file: http://bugs.python.org/file35071/sqlite3_slicing_demo.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13583 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11709] help-method crashes if sys.stdin is None
Jessica McKellar added the comment: Thanks for reporting this, palm.kevin, and thanks for the patch, amaury.forgeotdarc. First, just to be explicit here's a short reproducer: import sys sys.stdin = None help(1) (Note that to get to the isatty check you need to provide an argument and it has to be something that has help, so `help()` and `help(a)` don't exercise this code path) Also, here is where sys.stdin can be set to None: http://hg.python.org/cpython/file/dbceba88b96e/Python/pythonrun.c#l1201 The provided patch fixes the above test case; instead of erroring out with the traceback in the original bug report, the plain pager is used and the help message is printed to stdout. Anyone on the nosy list interested in writing some tests? -- nosy: +jesstess stage: patch review - test needed versions: +Python 3.5 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11709 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5001] Remove assertion-based checking in multiprocessing
Jessica McKellar added the comment: Thanks for the patches, vladris! I've reviewed the latest version, and it addresses all of Antoine's review feedback. Ezio left some additional feedback (http://bugs.python.org/review/5001/#ps3407) which still needs to be addressed. -- nosy: +jesstess ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5001 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13330] Attempt full test coverage of LocaleTextCalendar.formatweekday
Jessica McKellar added the comment: Thanks for working to increase our test coverage, Sean.Fleming! Looking at the current coverage, the there is one line in LocaleTextCalendar.formatweekday without coverage: http://hg.python.org/cpython/file/e159cb0d955b/Lib/calendar.py#l519. You add some additional tests, but they are mostly testing some very literal aspects of the implementation rather than the purpose of the function. For example: +self.assertRaises(IndexError, calendar.LocaleTextCalendar(locale='').formatweekday, 7, 1 ) It's true that this will raise an IndexError, but formatweekday isn't supposed to be called with these values. I've added some tests that add coverage for the line that didn't have coverage, while focusing on the purpose of the function, namely to provide an appropriate day name when constrained to various widths. * The patch passes the full test suite * The patch passes `make patchcheck` * The patch results in full coverage for LocaleTextCalendar.formatweekday Coverage results, before and after: $ ./python.exe ../coveragepy/ run --pylib --source=calendar Lib/test/regrtest.py test_calendar [1/1] test_calendar 1 test OK. nitefly:cpython jesstess$ ./python.exe ../coveragepy/ report --show-missing Name Stmts Miss Cover Missing Lib/calendar 375 5486% 511, 519, 541, 608-699, 703 $ patch -p1 issue13330.patch patching file Lib/test/test_calendar.py patching file Misc/ACKS $ ./python.exe ../coveragepy/ run --pylib --source=calendar Lib/test/regrtest.py test_calendar [1/1] test_calendar 1 test OK. nitefly:cpython jesstess$ ./python.exe ../coveragepy/ report --show-missing Name Stmts Miss Cover Missing Lib/calendar 375 5386% 511, 541, 608-699, 703 (519 was the one line without coverage inside LocaleTextCalendar.formatweekday) -- nosy: +jesstess versions: +Python 3.5 -Python 3.3 Added file: http://bugs.python.org/file35060/issue13330.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13330 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13204] sys.flags.__new__ crashes
Jessica McKellar added the comment: Thanks for reporting this and providing a patch, Trundle. The Python 3 patch didn't apply cleanly anymore, so I regenerated it and added tests for sys.version_info and sys.getwindowsversion. * The patch passes `make patchcheck` * The full test suite passes with this patch. * Testing manually, without this patch each of the following segfaults, and with the patch they raise errors instead: import sys; sys.flags.__new__(type(sys.flags)) import sys; sys.version_info.__new__(type(sys.version_info)) import sys; sys.getwindowsversion().__new__(type(sys.getwindowsversion())) One important caveat is that while I confirmed the sys.getwindowsversion segfault on Windows, I don't have Visual Studio set up so I couldn't build and test the new test for sys.getwindowsversion (I ran the full test suite on OSX, where this test is skipped). -- keywords: +needs review nosy: +jesstess versions: +Python 3.5 -Python 3.2, Python 3.3 Added file: http://bugs.python.org/file35068/issue13204.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13204 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13096] ctypes: segfault with large POINTER type names
Jessica McKellar added the comment: Thanks for the report and patch, meador.inge. I'd prefer not to add more globals that are only used in one place, but doing so is consistent with the existing style of test_pointers.py, and there's plenty in this file that could be cleaned up in another ticket. * The patch passes `make patchcheck`. * The full test suite passes with this patch. * The reproducers in this issue segfault for me without this patch and do not segfault with this patch. lgtm! = commit review -- keywords: +needs review nosy: +jesstess stage: patch review - commit review versions: +Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13096 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9850] obsolete macpath module dangerously broken and should be removed
Jessica McKellar added the comment: Thanks for writing up this issue, ned.deily, and thanks for providing a patch, chortos. I couldn't find documentation clearly specifying what the correct behavior of macpath.join should be (i.e. what are the exact rules for leading and trailing colons), but comparing the old and updated behavior against the new tests, this patch does make the function's behavior more consistent. * The patch passes `make patchcheck`. * The full test suite passes with this patch. = commit review -- keywords: +needs review nosy: +jesstess stage: needs patch - commit review versions: +Python 2.7, Python 3.5 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9850 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21361] Add how to run a single test case to the devguide
New submission from Jessica McKellar: I had wanted to run a single TestCase, or single TestCase test method, and saw that how to do this wasn't in the devguide. Pattern-matching from the other rules doesn't work (for now, you have to use unittest instead of test), and asking on IRC, many people didn't know it was possible. :) This patch adds documentation on how to run a single TestCase. I visually inspected the built HTML to confirm that it looks as desired. -- components: Devguide files: devguide.diff keywords: easy, needs review, patch messages: 217239 nosy: ezio.melotti, jesstess priority: normal severity: normal stage: patch review status: open title: Add how to run a single test case to the devguide type: enhancement Added file: http://bugs.python.org/file35048/devguide.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21361 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8387] use universal newline mode in csv module examples
Jessica McKellar added the comment: I realized that I typo'd 2 instead of 3 in http://bugs.python.org/issue8387#msg216888 which makes that message confusing. Here's a restatement of my findings: * All of the Python 3 csv examples work in Python 3 on all platforms. * The Python 2 binary-mode csv examples work in Python 2.7 on all platforms. * The Python 2 binary-mode csv examples error out on Windows and OSX when run under Python 3. We could do nothing to address this, or, if we determine that there's no negative impact to removing the 'b', update the examples to accommodate readers who are running Python 2 examples using Python 3 for whatever reason. Which does bring me to the same question as @pitrou, which is what data and code cause an error for @sfinnie on Python 2. :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8387 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7221] DispatcherWithSendTests_UsePoll with test_asyncore does nothing
Jessica McKellar added the comment: This looks like a copy-paste typo from test_asynchat, which does use `usepoll`. Attached is a patch that removes `usepoll` and a `DispatcherWithSendTests_UsePoll` TestCase that did nothing but set `usepoll=True`. * The diff passes `make patchcheck`. * The full test suite passes with this diff. -- keywords: +needs review, patch nosy: +jesstess stage: needs patch - patch review Added file: http://bugs.python.org/file34978/issue7221.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7221 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10291] Clean-up turtledemo in-package documentation
Jessica McKellar added the comment: Thanks for the bug report and patch, belopolsky! The original patch no longer applies cleanly, so attached is a regenerated version. * The new patch passes `make patchcheck`. * The full test suite passes with this patch. * I manually tested that before the patch, `./python.exe Lib/turtledemo/__main__.py` would start the demo window behind the Terminal on OSX, and after the patch it starts in front as desired. * I manually checked the 3 help menu drop-down options in the demo, and they have the expected content. There is a lot of out of date content in the turtle docs, and I think we should consider that work separate from this ticket and do a full audit of what needs updating in a new ticket. = commit review -- keywords: +needs review nosy: +jesstess stage: needs patch - commit review Added file: http://bugs.python.org/file34979/issue10291_2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10291 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8387] use universal newline mode in csv module examples
Jessica McKellar added the comment: I ran some experiments to see what the state of the world is. I generated a test.csv by exporting a CSV file from Numbers on OSX. This generated a file with Windows-style \r\n-terminated lines. The attached test_csv.py tries to open this CSV file in binary and universal newlines modes. Here's what happens on various platforms Python 3: * Linux: both binary and universal work * OSX: binary errors out, universal works * Windows: binary errors out, universal works In both cases, the error was: $ python3 test_csv.py Traceback (most recent call last): File test_csv.py, line 5, in module for row in spamreader: _csv.Error: iterator should return strings, not bytes (did you open the file in text mode?) Python 2: * Linux: both binary and universal work * OSX: both binary and universal * Windows: wasn't readily able to test If I manually create a CSV file using TextEdit in plaintext mode on OSX, that produces a file with Mac-style \r-terminated lines. test_csv.py has the same results on this file on OSX (errors out in binary mode in Python 3). -- nosy: +jesstess Added file: http://bugs.python.org/file34981/test_csv.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8387 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8387] use universal newline mode in csv module examples
Changes by Jessica McKellar jesst...@mit.edu: Added file: http://bugs.python.org/file34982/test.csv ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8387 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8387] use universal newline mode in csv module examples
Jessica McKellar added the comment: All of the examples from https://docs.python.org/3/library/csv.html run without issue on OSX, though. In summary, the Python 2 examples error out on OSX and switching them to use 'U' instead of 'b' would fix this. I don't think any action needs to be taken for Python 3. My one remaining question is about binary files on Windows. The Python 2 csv docs say If csvfile is a file object, it must be opened with the ‘b’ flag on platforms where that makes a difference. I don't readily have a Windows machine to play with this -- do binary CSV files exist, or can we eliminate the 'b' language entirely and just talk about 'U'? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8387 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11748] test_ftplib failure in test for source_address
Jessica McKellar added the comment: Antoine, thanks for the patch, and Giampaolo, thanks for the ping. I confirmed that http://hg.python.org/cpython/rev/8a2d848244a2 does address the issue: Before the patch, if another process bound to the port selected for the test before the test ran, the test would error out. After the patch, if this race happens the test is skipped instead. Anecdotally from local tests and from looking at recent buildbot builds, the test does generally run (so we don't have a problem with it skipping all the time and the behavior not getting tested). = Closing as resolved. -- nosy: +jesstess resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11748 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19980] Improve help('non-topic') response
Jessica McKellar added the comment:
Elias, thanks for your patch!
I think it's important to add the second part of Terry's suggestion which gives
the user a specific next step to take, namely:
Try help('help') for information on recognized strings or help(str) for help
on the str class.
Can you add that to your patch?
Additionally, we'll want to make sure we don't accidentally break this new
functionality. Can you add a few test cases, for example what happens when you
run help on a module (e.g. help(os), 2) help on an instance of a class (e.g.
help(1)), and help on a string that doesn't have a special meaning, (e.g.
help(abcxyz))?
I don't see any existing tests for help(), but it is an instance of
site._Helper (as reported by type(help)), and site tests live in
Lib/test/test_site.py. It also gets loaded into builtins, so tests could also
live in Lib/test/test_builtins.py.
--
nosy: +Jessica.McKellar, jesstess
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16665] doc for builtin hex() is poor
Jessica McKellar added the comment: Thanks for the patch, Michael! There's a small doc build issue with your patch: the note on int shows up inside the code block for the examples. In response to rhettinger's feedback I've attached a slightly more compact patch that hits the highlights. I checked that the docs build cleanly with the patch and that the output looks visually as expected. I think both patches are an improvement over the current docs. = review -- nosy: +jesstess stage: needs patch - patch review Added file: http://bugs.python.org/file34435/issue16665_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16665 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4849] instantiating and populating xml.dom.minidom.Element is cumbersome
Changes by Jessica McKellar jesst...@mit.edu: Added file: http://bugs.python.org/file34356/issue4849_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4849 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20882] Link to OpenHatch “getting started” page from devguide
Changes by Jessica McKellar jesst...@mit.edu: -- nosy: +jesstess ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20882 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19873] There is a duplicate function in Lib/test/test_pathlib.py
Jessica McKellar added the comment: Thanks for the patch, NAVNEET.SUMAN! The patch implements ezio.melotti's proposal and applies cleanly without test regressions for me locally. = patch review -- nosy: +jesstess stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19873 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19363] Python 2.7's future_builtins.map is not compatible with Python 3's map
Jessica McKellar added the comment: Thanks for the patch, Gareth.Rees! The patch applies cleanly and the docs build cleanly with it. I visually inspected the addition in the built HTML docs and it looks good. = patch review -- keywords: +needs review -patch nosy: +jesstess stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19363 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20627] Add context manager support to xmlrpc.client.ServerProxy
Jessica McKellar added the comment: Thanks for the patch, Claudiu.Popa! I noticed one tiny thing, which is that it introduced some trailing whitespace. I've uploaded a trivial change to your patch that removes the whitespace. * The patch applies cleanly. * The docs build cleanly with the patch. * test_xmlrpc passes with the patch. * I visually inspected the changes in the built HTML docs and they look good. I also ran the modified example code from the docs and confirmed that it runs as expected. = needs review -- keywords: +needs review -easy, patch nosy: +jesstess stage: needs patch - patch review Added file: http://bugs.python.org/file34313/issue20627.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20627 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4849] instantiating and populating xml.dom.minidom.Element is cumbersome
Jessica McKellar added the comment: Thanks for the patch, Alexandre.Zani! -- keywords: +needs review nosy: +jesstess versions: +Python 3.5 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4849 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4849] instantiating and populating xml.dom.minidom.Element is cumbersome
Jessica McKellar added the comment: Sorry, stray submit, one more time: Thanks for the patch, Alexandre.Zani! Your patch had some whitespace issues according to `make patchcheck` (see http://docs.python.org/devguide/patch.html#generation for details). I've uploaded a trivial update to your patch that passes patchcheck. The patch applies cleanly and test_minidom passes. This enhancement may need some documentation on the new constructor before getting merged, but let's get a design review going. = patch review -- stage: needs patch - patch review Added file: http://bugs.python.org/file34317/issue4849.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4849 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7152] urllib2.build_opener() skips ProxyHandler
Jessica McKellar added the comment: I confirm Barry's observation in msg94150 that if you set http_proxy (or any `*_proxy` environment variable), ProxyHandler does show up in build_opener().handlers. You can also add a ProxyHandler to build_opener through the public API as described in http://docs.python.org/dev/library/urllib.request.html#examples. I've attached a patch that updates the urllib2 and urllib.request documentation to clarify the situation. The patch also adds a missing DataHandler to the enumerated default handlers in the urllib2 note on basic authentication. I built the documentation and inspected the generated HTML to confirm proper formatting. -- As a side note on what's going on with ProxyHandler's interaction with `if meth in [redirect_request, do_open, proxy_open]:`, since this was confusing to me until I dug into the source a bit: When you don't have any proxy environment variables set, ProxyHandler only has one protocol_condition method that might get the handler registered -- proxy_open -- which gets skipped because of the above blacklisted methods check. When a proxy environment variable is set, ProxyHandler grows a *_open method which does get it registered as a handler. -- keywords: +patch nosy: +jesstess versions: +Python 3.3, Python 3.4 -Python 2.6 Added file: http://bugs.python.org/file29817/issue7152.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7152 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9297] SMTP with Sqlite3 file attached problem
Jessica McKellar added the comment: murilobr, thank you for the detailed and persistent bug report :) I was not able to reproduce this issue when sending mail from myself to myself through an open Google SMTP server*, using either Python 2.7** or 3.1. Do you experience this issue with a GMail SMTP server? If not, this seems like something specific to your environment--perhaps a custom SMTP server you are using? Unless someone can reproduce the issue, I recommend that we close this ticket. * e.g. one from $ nslookup set type=MX google.com Server:192.168.1.1 Address:192.168.1.1#53 Non-authoritative answer: google.commail exchanger = 10 aspmx.l.google.com. google.commail exchanger = 50 alt4.aspmx.l.google.com. google.commail exchanger = 20 alt1.aspmx.l.google.com. google.commail exchanger = 30 alt2.aspmx.l.google.com. google.commail exchanger = 40 alt3.aspmx.l.google.com. ** This is targeted at 3.1 but the example uses str.decode, which doesn't exist in Python 3, so I went back and checked on 2.7. -- nosy: +jesstess versions: +Python 2.7 -Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9297 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7100] test_xmlrpc: global name 'stop_serving' is not defined
Jessica McKellar added the comment: To summarize (as I understand it) the state of this ticket: * stop_serving no longer exists anywhere in the code base, so the proximal cause of the bug report from 2009 no longer exists. * the tests in test_xmlrpc currently all pass without issue. * If you tried to create a test in a subclass of BaseServerTestCase which never issues a request to the MyXMLRPCServer instance set up by http_server, it will hang. The reason is that BaseServerTestCase uses setUp and tearDown methods that force the test to coordinate a threading.Event with http_server; if no request is made to the XMLRPC server, the test will hang in tearDown waiting for the server to set the Event flag. I think this ticket could be closed because the proximal issue no longer exists. Alternatively, a docstring could be added to BaseServerTestCase saying tests in subclasses must make at least 1 request else they should live in a different TestCase, or BaseServerTestCase could be refactored to not have this constraint. -- nosy: +jesstess ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7100 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4140] urllib2: request with digest auth through proxy fail
Jessica McKellar added the comment: jan.kollhof, thanks for the report and your work on this ticket! The format of the client response to a server's digest challenge is detailed in RFC 2617, section 3.2.2: The Authorization Request Header. The urllib2.py attachment is unfortunately the whole file and not a diff, but I think from the transcript in msg74918 that Jan is discussing the format of the digest-uri header. That field is in turn defined in RFC 2616, section 5.1.2: Request-URI. Request-URI= * | absoluteURI | abs_path | authority The absoluteURI form is REQUIRED when the request is being made to a proxy. So I believe urllib2 has the correct, RFC-conforming behavior here by sending the full URI through a proxy, and the issue is with IIS. Thus, I recommend that we close this ticket as invalid. -- nosy: +jesstess ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4140 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2244] urllib and urllib2 decode userinfo multiple times
Jessica McKellar jesst...@mit.edu added the comment: I can confirm that the combination of urllib_issue_updated.diff and urllib_ftptests_doubleencode.patch apply cleanly against py3k, that the added tests exercise the described bug, and that the full test suite passes after applying the patches. The patches look clean and conforming to PEP 8. -- nosy: +jesstess ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2244 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7325] tempfile.mkdtemp() does not return absolute pathname when relative dir is specified
Jessica McKellar jesst...@mit.edu added the comment: Thomas, I think the weirdness you were sensing when trying to adapt the nameCheck calls in test__RandomNameSequence after adding the abspath check is that those test cases really don't need nameCheck. For example, test_get_six_char_str should be testing that _RandomNameSequence returns something that is both a string and 6 characters, not properties of some path manufactured around it. I've attached a patch based on Thomas's that factors out the string check in nameCheck and has the tests in test__RandomNameSequence just use the string check. The patch is against release27-maint. -- nosy: +jesstess title: tempfile.mkdtemp() does not return absolute pathname when dir is specified - tempfile.mkdtemp() does not return absolute pathname when relative dir is specified Added file: http://bugs.python.org/file19610/issue7325.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7325 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5066] IDLE documentation for Unix obsolete/incorrect
Jessica McKellar jesst...@mit.edu added the comment: Attached is a patch updating the IDLE web documentation as well as the help file displayed when you click the Help - Idle Help menu item in IDLE. It looks like the IDLE web documentation was lifted directly from the help file at some point and they have gotten out of sync. The section of the document describing starting IDLE was updated in March of 2009, so I've left that alone. I've updated the Menu option descriptions in both files, including: adding missing items, making the help file and web document descriptions the same, and using a consistent format. The patch is against release27-maint. -- keywords: +patch nosy: +jesstess versions: +Python 2.7, Python 3.2 -Python 2.6, Python 3.0 Added file: http://bugs.python.org/file19535/issue5066.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5066 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6744] calling kevent repr raises a TypeError
Jessica McKellar jessica.mckel...@gmail.com added the comment: Added a tiny example to generate the error, repeated here. Just: from select import kevent if __name__ == '__main__': ev = kevent(1) print(repr(ev)) -- Added file: http://bugs.python.org/file14781/kevent-repr-test.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6744 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2560] removal of stale code from myreadline.c
Jessica McKellar jessica.mckel...@gmail.com added the comment: Here's an updated patch against trunk that has 8 space tabs and doesn't remove some of the existing comments like the other patch did. I checked that the patch applies and that re-building doesn't error. -- nosy: +jesstess versions: +Python 3.2 Added file: http://bugs.python.org/file14773/myreadline-v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2560 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6744] calling kevent repr raises a TypeError
New submission from Jessica McKellar jessica.mckel...@gmail.com: kqueue_event_repr uses PyBytes_FromString when every other repr uses PyUnicode_FromString, and this gets you a TypeError: __repr__ returned non-string (type bytes). The patch swaps in PyUnicode_FromString and adds a very simple unittest to test_kqueue. -- components: Extension Modules files: kqueue-event-repr.patch keywords: patch messages: 91782 nosy: jesstess severity: normal status: open title: calling kevent repr raises a TypeError type: behavior versions: Python 3.1, Python 3.2 Added file: http://bugs.python.org/file14749/kqueue-event-repr.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6744 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
